D4911: add Baloo DBus signals for moved or removed files

[Christoph Cullmann]

cullmann added a comment.


  @cullmann: https://phabricator.kde.org/T7860 lists some of my observations 
wrt samba shares. I don't know NFS, can you enlighten me regarding deviceids 
and inodes on NFS?
  
  I can only tell that baloo can't work at all on NFS/SMB home dirs with the 
current DB and that its idea of inode number usage to encode the file won't 
work there either (it already doesn't work on large file systems with 64-bit 
inodes).
  
  I am very happy that somebody is working on fixing the current bugs, but I am 
still not sure it would not just be better to port away to some better 
maintained and more secure thing like tracker, but my  
https://cgit.kde.org/clones/baloo/cullmann/tbaloo.git/ port stagnated
  as there was no interest.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien, vhanda, dfaure, michaelh, #baloo
Cc: ngraham, cullmann, apol, #frameworks, michaelh, spoorun, alexeymin

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/46/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 02 Feb 2018 12:51:14 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/47/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 02 Feb 2018 13:32:09 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/44/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Feb 2018 12:51:14 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/46/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 02 Feb 2018 12:51:14 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

D10250: track the validity of the texture

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  the texture of ManagedTextureNode gets deleted by the
  refcountung of the internal QSharedPointer,
  but in some rare cases, it can be deleted too by some
  external cause, usually when a widget changes its parent
  window (either changing containment or switching between
  full/collapsed view)
  dragging a system monitor applet that uses the plotter
  component between the desktop and panel quite reliably
  crashes plasma, as it was trying to access the texture that may
  have become invalid at the moment.
  track it also with a qpointer which is used only to provide
  an hasValidTexture boolean which should be checked before
  accessing the texture of the node.
  
  BUG:388508
  BUG:374280
  BUG:365052
  BUG:343576

TEST PLAN
  The bug is easily reproducible without the patch, wasn't
  able to reproduce it anymore with it

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/guardTexture

REVISION DETAIL
  https://phabricator.kde.org/D10250

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
  src/qmlcontrols/kquickcontrolsaddons/plotter.h
  src/quickaddons/managedtexturenode.cpp
  src/quickaddons/managedtexturenode.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/47/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 02 Feb 2018 13:32:09 +
 Build duration:
5 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

D10243: Improve visibility of disconnected Wi-Fi icons

[Nathaniel Graham]

ngraham added a comment.


  If this is only a change for the "disconnected wifi" icon, then maybe we 
should mimic the "disconnected wired network" icon and make the color red, 
rather than fiddling with the lightness, which will never satisfy everyone (if 
this merged, I predict bug reports that say "The disconnected wifi icon looks 
almost exactly like the connected wifi icon!")

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/45/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 02 Feb 2018 12:31:14 +
 Build duration:
7 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate added a comment.


  Unfortunately, the last connect creates a memory leak:
  
  1018== 10,152 (72 direct, 10,080 indirect) bytes in 1 blocks are definitely 
lost in loss record 928 of 943
  
--
  
  1018==at 0x4C2E6FF: operator new(unsigned long) (in 
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
  
--
  
  1018==by 0xCAEFCFC: QObjectPrivate::connectImpl(QObject const*, int, 
QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int 
const*, QMetaObject const*) (in /usr/lib64/libQt5Core.so.5.10.0)
  
--
  
  1018==by 0xCAF0084: QObject::connectImpl(QObject const*, void**, QObject 
const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, 
QMetaObject const*) (in /usr/lib64/libQt5Core.so.5.10.0)
  
--
  
  1018==by 0x9141BB5: 
std::enable_if::ArgumentCount==(-1), QMetaObject::Connection>::type 
QObject::connect(QtPrivate::Object 
const*, 
std::enable_if::ArgumentCount==(-1), QMetaObject::Connection>::type, QObject 
const*, QtPrivate::FunctionPointer, Qt::ConnectionType) (qobject.h:338)
  

  
  1018==by 0x913FCCB: KIO::SimpleJobPrivate::start(KIO::Slave*) 
(simplejob.cpp:151)
  
-
  
  1018==by 0x914B3D1: KIO::TransferJobPrivate::start(KIO::Slave*) 
(transferjob.cpp:362)
  
-
  
  1018==by 0x914D063: startJob(KIO::SimpleJob*, KIO::Slave*) 
(scheduler.cpp:60)
  
-
  
  1018==by 0x914F661: KIO::ProtoQueue::startAJob() (scheduler.cpp:635)
  
  
  1018==by 0x9152AC4: KIO::ProtoQueue::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**) (moc_scheduler_p.cpp:252)
  
---
  
  1018==by 0xCAEBDB9: QMetaObject::activate(QObject*, int, int, void**) (in 
/usr/lib64/libQt5Core.so.5.10.0)
  
--
  
  1018==by 0xCAF8236: QTimer::timeout(QTimer::QPrivateSignal) (in 
/usr/lib64/libQt5Core.so.5.10.0)
  

  
  1018==by 0xCAF8567: QTimer::timerEvent(QTimerEvent*) (in 
/usr/lib64/libQt5Core.so.5.10.0)
  
-

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/45/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 02 Feb 2018 12:31:14 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/45/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Feb 2018 13:32:09 +
 Build duration:
2 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  -1 from my side because:
  
  - Dolphin: By default, the sidebar now has an ugly scrollbar. (The screenshot 
is "staged" in that regard.)
  - Gwenview: This clutters the Places list on the Start Page with a bunch of 
stuff not relevant for users (e.g. Music). I'm still busy fixing the fallout 
from the last patch similarly adding unwanted/broken entries, so please help 
out if you must add this globally. Note this is not only about Gwenview, but a 
lot of other apps using `KFilePlaces` are not interested in some of the entries 
either.
  - In general: Now there's duplication with Search For. For example, what's 
the difference between "Documents" and "Documents"? (Not everybody is aware of 
the headers, and rightfully shouldn't!) Same for "Pictures" vs. "Images". Maybe 
I could live with that if this only appeared if Baloo was turned off.
  
  I'd rather use `KFilePlaces` more as a bookmark thingy, i.e. something where 
users add custom entries they want to see either in all or in specific apps. 
Those are highly specialized folders in my experience, depending on user's 
workflows and not something we could predict. Better leave some space so users 
can customize themselves.
  
  Sorry Nate, I know you meant well. Nevertheless, let's hear first what others 
have to say, maybe I'm wrong or we could tone down the list a bit…

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: rkflx, michaelh, ngraham

D4911: add Baloo DBus signals for moved or removed files

[Michael Heidelbach]

michaelh added a comment.


  Considering that I'm more or less the only one working on baloo, I'd prefer 
to postpone this for a while instead of adding more complexity. At least until 
I have understood the inner workings of baloo.
  Also the list of bugs reporting baloo's crashes is quite long. Fixing those 
has become my top priority.
  
  @mgallien: Unless it really thwarts you I ask for your patience.
  
  > I would actually not even do that, as baloo isn't working that well e.g. on 
NFS and co. and that will limit the use of your application (which is cool 
btw.!).
  
  @cullmann: T7860  lists some of my 
observations wrt samba shares. I don't know NFS, can you enlighten me regarding 
deviceids and inodes on NFS?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien, vhanda, dfaure, michaelh, #baloo
Cc: ngraham, cullmann, apol, #frameworks, michaelh, spoorun, alexeymin

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/43/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Feb 2018 12:31:13 +
 Build duration:
4 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

D10243: Improve visibility of disconnected Wi-Fi icons

[Nathaniel Graham]

ngraham added a comment.


  Thanks @andreask. Could we also see what it looks like next to the icon with 
all bars filled, or with only a few filled? This looks better for disconnected 
ones, but without seeing those use cases, it do worry that the presentation 
becomes too muddy for weak connections.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10245: Add more default user locations to Places model/panel

[Nathaniel Graham]

ngraham added a comment.


  The scrollbar issue is real, though I don't think scrollbars are as awful as 
you do. :-) Something to think about. I could see removing Music and Pictures, 
maybe. But Desktop, Documents, and Downloads are heavily used by ordinary 
regular users and I think it makes sense to provide links to them in the Places 
panel by default.
  
  This raises a greater question of whether or not it makes sense to have 
`KFilePlaces` in Gwenview. Gwenview is an image viewer, and necessarily, the 
majority of `KFilePlaces` items are not going to be relevant to pictures. Same 
for other apps using it. Even without my patch, this issue will occur for users 
who add their own items to the Places panel.
  
  I feel like the label duplication with the Search For section is a minor 
issue, and mostly a red herring. The header is right there, so at least in 
English, the implied imperative sentence is quite obvious: "Search for 
Documents", "Search for Music," etc. The functions are totally different, and 
equally important (and if anything, the functionality gained by this patch is 
more important).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: rkflx, michaelh, ngraham

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D10245#199564, @ngraham wrote:
  
  > The scrollbar issue is real, though I don't think scrollbars are as awful 
as you do. :-) Something to think about.
  
  
  Not awful per se, but a huge problem if they hide important stuff below the 
fold.
  
  > This raises a greater question of whether or not it makes sense to have 
`KFilePlaces` in Gwenview. Gwenview is an image viewer, and necessarily, the 
majority of `KFilePlaces` items are not going to be relevant to pictures.
  
  It's very useful if users can add directories and then have them show up in 
every app. I'm thinking of things like `Projects/2018/BigEvent/Files`. Note 
those aren't filetype or app specific.
  
  > I feel like the label duplication with the Search For section is a minor 
issue, and mostly a red herring. The header is right there, so at least in 
English, the implied imperative sentence is quite obvious: "Search for 
Documents", "Search for Music," etc.
  
  We'd need an eyetracking study to resolve that. I suspect your solution would 
get worse results, because the headers are only looked at second when randomly 
searching for something (at least in my experience when I evaluated eyetracking 
videos). Not having duplication would be better.
  
  > if anything, the functionality gained by this patch is more important
  
  That's true. I doubt the search is used that often. While for Recently Saved 
the list of results might be manageable, for Search For the list of results can 
be too large to be useful.
  
  ---
  
  Suggestion which would resolve most of my issues:
  
  - Remove "Pictures" and "Music" again.
  - Remove Search for (could be added back once we have collapsible headers).
  - Move up Devices, right below Remote.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: rkflx, michaelh, ngraham

D10245: Add more default user locations to Places model/panel

[Störm Poorun]

spoorun added a comment.


  I'm afraid that removing pictures would be a bad idea.
  The majority of users would find Pictures in particular essential - and lots 
of software and services automatically store images in the Pictures folder (for 
example when plugging in an SD card or camera, when downloading from a 
webservice).
  So lay users (the ones who would be least likely to create their own items in 
the places menu) would miss it most.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: spoorun, rkflx, michaelh, ngraham

D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate added a comment.


  In https://phabricator.kde.org/D10124#199601, @mwolff wrote:
  
  > only that one, not the others? strange, why should that be the case? are 
you sure `q` and `slave` get destroyed?
  
  
  Yes, only that one. I've tried with const parámeters in the lambdas, same 
problem.
  And 
https://forum.qt.io/topic/86962/qt5-new-signal-to-lambda-connections-can-result-memory-leak/3
 

 says the leaks were fixed in Qt5.0.1
  How to reproduce:
  apply the patch :-)
  valgrind --log-file=whatever.log dolphin (that uses the compiled kio)
  copy one file and drag one file.
  Exit and check whatever.log

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D10245: Add more default user locations to Places model/panel

[Nathaniel Graham]

ngraham added a comment.


  Keeping Pictures but removing Music would seem to be a compromise, no? But 
since this has proved controversial, it's obviously not going in anytime soon, 
so no need to worry about that.
  
  Since the places model is now in KIO, once a user adds a location in Dolphin, 
it automatically shows up in all apps now, right? Or am I wrong and there is a 
way to make things appear only in Dolphin and the file open/save dialogs, but 
not other apps' own uses of `KFilePlaces`? If so, that would seem to be an 
obvious intermediate solution and I'll focus on that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

D10250: track the validity of the texture

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Good analysis on the plotter. Thanks for looking into it.
  
  > but in some rare cases, it can be deleted too by some external cause, 
usually when a widget changes its parent
  
  If someone deletes something that's meant to be ref-counted it's being used 
wrong.  
  If there was a real bug in ManagedTextureNode we would have seen it in all 
the code that already used it; iconitem, framesvgitem, etc...
  
  This is just a bug in plotter. If you do need to reverse the smart pointer 
logic to have a weak pointer, keep it within there.
  
  Btw, you don't need managedtexturenode unless you're using the texturecache, 
since Qt 5.4 you can use QSGSimpleTextureNode::setOwnsTexture.   It might help?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D10250

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, ngraham, plasma-devel, #frameworks, michaelh, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate added a comment.


  In https://phabricator.kde.org/D10124#199645, @mwolff wrote:
  
  > can you test and make sure that q and slave actually get destroyed? If that 
is the case, then the slotobj should get destroyed too. If not then this is a 
bug in Qt, which would make me wonder... Do you have a selfcompiled Qt, or one 
shipped by your distro? There was https://codereview.qt-project.org/#/c/215333/ 
but that's for QMetaObject::invoke which isn't relevant here... Odd!
  
  
  Here doesn't happen!. Only in the other Linux. I'll try again next week in 
the other linux.
  Both linux have Qt from OpenSuse.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D10245#199564, @ngraham wrote:
  
  > I could see removing Music and Pictures, maybe.
  
  
  
  
  In https://phabricator.kde.org/D10245#199578, @rkflx wrote:
  
  > - Remove "Pictures" and "Music" again.
  
  
  
  
  In https://phabricator.kde.org/D10245#199643, @ngraham wrote:
  
  > Music, maybe. Pictures no
  
  
  You propose a compromise, I agree and suddenly the situation is different 
again? Let's not rush this, please.
  
  > Also, the Pictures item is useful for Gwenview, no? :)
  
  It is, but it could be added in Gwenview, just like Kdenlive could add Movies 
or JuK could add Music. We don't need Pictures in KDevelop, though! When fixing 
the fallout from https://phabricator.kde.org/D8332 I discovered what you are 
changing here will propagate to every app using `KUrlNavigator`, which is quite 
common. (Meanwhile I gave up on adding fixes like 
https://phabricator.kde.org/R260:50e6fa3ffc490eca33b8e2025120ec041b333fee 
everywhere, because I realized this has to be solved at Baloo level.)
  
  Next big caveat: Our file dialog is used in Okular, Kate and every 
well-integrated Qt app, where some of the additions make no sense at all. Do 
you want a Music folder in your EDA and CAD app?
  
  I completely agree it is useful in Dolphin. However, then it should be added 
in Dolphin.
  
  TL;DR:
  
  - Places and searches useful everywhere should go to KIO.
  - Specialized stuff (i.e. "Does it only return one specific filetype") should 
be added in the app or at least be opt-in. Perhaps we need `KExtraFilePlaces` 
or some mimetype dependent automagic?
  
  
  
  ---
  
  > https://bugs.kde.org/show_bug.cgi?id=389803
  
  That's what I meant. Collapsible headers (i.e. one click, discoverable how to 
do that only by looking at it) are great. Our current hide-able headers are 
more of a configuration thing, you wouldn't want to use them regularly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik created this revision.
fredrik added reviewers: Plasma, VDG.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
fredrik requested review of this revision.

REVISION SUMMARY
  Blit the contents of the window texture to a separate mipmap texture, and 
(re)generate the mipmaps on each damage event.
  
  The mipmap filter is the default linear filter, which results in soft images. 
Using a filter with a sharpening kernel, such as a cubic or a windowed sinc 
filter would produce better results, but this is still an improvement over not 
using a mipmap filter at all.
  
  The scaling is gamma-correct when desktop GL is used.
  
  Note that this patch only modifies the GLX path.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp
  src/declarativeimports/core/windowthumbnail.h

To: fredrik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10245: Add more default user locations to Places model/panel

[Mark Gaiser]

markg added a comment.


  Ha, funny. I would say +1 :)
  Your idea is good and the default user places could imho be more then what is 
there by default right now.
  
  I personally would only add:
  
  - Desktop
  - Downloads
  
  Pictures, music and documents are in my case rarely used items. I usually 
have those stored somewhere else which would make them being there by default 
(for me) just a waste of screen space. But i can see others that do use that so 
it might be valuable to them.
  
  You have a +1 and a -1 now. That's going to be interesting ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

D10124: Faster simplejob start

[Milian Wolff]

mwolff added a comment.


  can you test and make sure that q and slave actually get destroyed? If that 
is the case, then the slotobj should get destroyed too. If not then this is a 
bug in Qt, which would make me wonder... Do you have a selfcompiled Qt, or one 
shipped by your distro? There was https://codereview.qt-project.org/#/c/215333/ 
but that's for QMetaObject::invoke which isn't relevant here... Odd!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D10245#199671, @ngraham wrote:
  
  > Keeping Pictures but removing Music would seem to be a compromise, no? But 
since this has proved controversial, it's obviously not going in anytime soon, 
so no need to worry about that.
  
  
  Well, Documents and Downloads would be useful (perhaps Desktop if we really 
want to promote that, personally I'd leave it out).
  
  If you want to do it right, your patch (or multiple patches) could:
  
  - add common stuff to KIO (Documents, Downloads)
  - add special stuff to Dolphin (Search For, Pictures, Music etc.)
  - remove special stuff from KIO (e.g. Search For)
  - change the order
  
  > Since the places model is now in KIO, once a user adds a location in 
Dolphin, it automatically shows up in all apps now, right? Or am I wrong and 
there is a way to make things appear only in Dolphin and the file open/save 
dialogs, but not other apps' own uses of `KFilePlaces`? If so, that would seem 
to be an obvious intermediate solution and I'll focus on that.
  
  Well, if the user checks Only show when using this application (Dolphin) 
while adding an item, it should (unless there's a bug) only appear in Dolphin, 
otherwise it will be available everywhere. Both are valid use cases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

D10251: [RFC] Use mipmap filtering in window thumbnails

[Eike Hein]

hein added a comment.


  It's definitely nicer, but could we go for the full thing and make it crisper 
too?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  > file open/save dialogs
  
  I'd assume the use case of those is quite broad, so those should be opt-in. 
However, I'm not sure whether an app can change it's file dialog's places 
model? That may be a deficiency, but then the deficiency should be solved 
instead of being worked around by a global addition.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

D10124: Faster simplejob start

[Milian Wolff]

mwolff added a comment.


  only that one, not the others? strange, why should that be the case? are you 
sure `q` and `slave` get destroyed?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D10245: Add more default user locations to Places model/panel

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D10245#199673, @rkflx wrote:
  
  > In https://phabricator.kde.org/D10245#199671, @ngraham wrote:
  >
  > > Keeping Pictures but removing Music would seem to be a compromise, no? 
But since this has proved controversial, it's obviously not going in anytime 
soon, so no need to worry about that.
  >
  >
  > Well, Documents and Downloads would be useful (perhaps Desktop if we really 
want to promote that, personally I'd leave it out).
  >
  > If you want to do it right, your patch (or multiple patches) could:
  >
  > - add common stuff to KIO (Documents, Downloads)
  > - add special stuff to Dolphin (Search For, Pictures, Music etc.)
  > - remove special stuff from KIO (e.g. Search For)
  > - change the order
  >
  > > Since the places model is now in KIO, once a user adds a location in 
Dolphin, it automatically shows up in all apps now, right? Or am I wrong and 
there is a way to make things appear only in Dolphin and the file open/save 
dialogs, but not other apps' own uses of `KFilePlaces`? If so, that would seem 
to be an obvious intermediate solution and I'll focus on that.
  >
  > Well, if the user checks Only show when using this application (Dolphin) 
while adding an item, it should (unless there's a bug) only appear in Dolphin, 
otherwise it will be available everywhere. Both are valid use cases.
  
  
  I don't think almost any users use or know about that because the two most 
obvious methods of adding something to the Places panel--drag-and-drop and the 
file's "Add to places" context menu item--make it global by default. Also if we 
add Music and Pictures et al to just Dolphin by default, then they're not going 
to show up in the file open/save dialogs where they're useful, right?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

D10250: track the validity of the texture

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> managedtexturenode.cpp:42
> +{
> +if (s_d.contains(this)) {
> +delete s_d[this];

`delete s_d.take(this);`

> managedtexturenode.cpp:50
> +{
> +if (s_d.contains(this)) {
> +return s_d[this];

auto *d = s_d.value(this);
  if (!d) {
  d = new ManagedTextureNodePrivate();
  s_d.insert(this, d);
  }
  return d;

> managedtexturenode.cpp:68
> +{
> +return d_ptr()->textureTracker;
> +}

Can you perhaps prevent creation of the `ManagedTextureNodePrivate` for this 
check? `d_ptr()` would create it just to then see that its `textureTracker` is 
`null`. (Might be worth profiling, though)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D10250

To: mart, #plasma
Cc: broulik, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik added a comment.


  Before and after:
  F5688790: before-after.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10245: Add more default user locations to Places model/panel

[Störm Poorun]

spoorun added a comment.


  In https://phabricator.kde.org/D10245#199562, @rkflx wrote:
  
  > -1 from my side because:
  >
  > - Dolphin: By default, the sidebar now has an ugly scrollbar. (The 
screenshot is "staged" in that regard.)
  > - Gwenview: This clutters the Places list on the Start Page with a bunch of 
stuff not relevant for users (e.g. Music). I'm still busy fixing the fallout 
from the last patch similarly adding unwanted/broken entries, so please help 
out if you must add this globally. Note this is not only about Gwenview, but a 
lot of other apps using `KFilePlaces` are not interested in some of the entries 
either.
  > - In general: Now there's duplication with Search For. For example, what's 
the difference between "Documents" and "Documents"? (Not everybody is aware of 
the headers, and rightfully shouldn't!) Same for "Pictures" vs. "Images". Maybe 
I could live with that if this only appeared if Baloo was turned off.
  > - Plugged in an external thumbdrive? Good luck finding it below the fold! 
(This should be solved first by moving things around a bit.)
  >
  >   I'd rather use `KFilePlaces` more as a bookmark thingy, i.e. something 
where users add custom entries they want to see either in all or in specific 
apps. Those are highly specialized folders in my experience, depending on 
user's workflows and not something we could predict. Better leave some space so 
users can customize themselves.
  >
  >   Sorry Nate, I know you meant well. Nevertheless, let's hear first what 
others have to say, maybe I'm wrong or we could tone down the list a bit…
  
  
  I disagree about the search entries - they are incredibly useful, again for 
lay users, or just those with not much time, searching for an image, document, 
or pdf - not knowing which folder they are in - are incredibly common tasks 
that warrant prime location for all to discover.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: spoorun, rkflx, michaelh, ngraham

D10245: Add more default user locations to Places model/panel

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D10245#199578, @rkflx wrote:
  
  > Suggestion which would resolve most of my issues:
  >
  > - Remove "Pictures" and "Music" again.
  
  
  Music, maybe. Pictures no, for the reasons that @spoorun gave. Also, the 
Pictures item is useful for Gwenview, no? :) Again, we're talking about good 
defaults for average users, not for people like us (who can and do customize to 
our heart's content).
  
  > - Remove Search for (could be added back once we have collapsible headers).
  
  We already do have collapsible headers! Well... hide-able headers. I think 
that we shouldn't hide anything by default until the the UI for showing hidden 
sections is improved, otherwise our users won't be able to find them and will 
erroneously complain that we're removing features. My vote is for the macOS 
Finder approach, where the header is clickable and shows/hides its content, but 
the header itself sticks around. It's quite slick:
  F5688836: places.gif 
  
  Everybody seemed to like this the last time I brought it up: Let me file a 
task to track implementing that: https://bugs.kde.org/show_bug.cgi?id=389803
  
  I think this section could definitely be hidden by default once we improve 
the show/hide UI. My sense is that it's infrequently used, and you can easily 
get it via the Find toolbar item. Might not be worth the pixels it's occupying 
by default.
  
  > - Move up Devices, right below Remote.
  
  +1, sounds good.
  
  I suspect that hiding the Search For category by default and moving up the 
Devices category would resolve the complaints.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

Re: save and restore the geometry of KMainWindow

[Alexander Semke]

On 01.02.2018 20:52, Albert Astals Cid wrote:

El dimarts, 30 de gener de 2018, a les 21:06:02 CET, Alexander Semke va
escriure:


The state is already saved and restored there. Why not to do the same
for the geometry?

I think that it's generally frowned upon putting your position on screen
because it means "you know too much".

Basically it's supposed to be the window manager task, not your app.
And if the window manager doesn't do this the user has to move their 
windows around again upon start?
Especially when working on big displays where the user wants to have 
certain placements for different programs
it would be helpful also to restore the position on the screen 
automatically.


The size is being restored, at least for a couple of programs I checked 
(konsole, kwrite, dolphin). Is this done by kwin?
I don't think there is a big practical difference from the user 
perspective between "restoring the size" and "restoring the position"

with respect to "you know too much"...


--
Alexander

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D10245#199688, @ngraham wrote:
  
  > I don't think almost any users use or know about that because the two most 
obvious methods of adding something to the Places panel--drag-and-drop and the 
file's "Add to places" context menu item--make it global by default.
  
  
  Users adding custom entries has nothing to do with your patch. If a users 
adds a place and it appears everywhere, well that's his problem. Your patch 
adds it everywhere //for every user//, which is what I disagree with.
  
  > Also if we add Music and Pictures et al to just Dolphin by default, then 
they're not going to show up in the file open/save dialogs where they're 
useful, right?
  
  See comment above. I doubt Kate's users want to see Pictures. I agree that 
some apps would want to opt-in, not sure how to do that. I think the best thing 
would be to make this mimetype dependent: If the file dialog detects you want 
to open/save Music files, it should add "Music" to the standard model. That 
would be an addition to the file dialog though, not where you are currently 
changing it. Do we have a resident file dialog expert around we could ask about 
that?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  Also, I feel a bit sorry for you. If I had realized the problem when Search 
For was added I would've added the same comment. I'd be glad if we could fix 
that again and remove the mimetype dependent items from the standard places 
model (or make it more intelligent about what to show).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/105/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 02:28:49 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31563/59434)38%
(18624/48714)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5352/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14343)50%
(4872/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(516/989)41%
(418/1014)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10245: Add more default user locations to Places model/panel

[Störm Poorun]

spoorun added a comment.


  In https://phabricator.kde.org/D10245#199691, @rkflx wrote:
  
  > In https://phabricator.kde.org/D10245#199688, @ngraham wrote:
  >
  > > I don't think almost any users use or know about that because the two 
most obvious methods of adding something to the Places panel--drag-and-drop and 
the file's "Add to places" context menu item--make it global by default.
  >
  >
  > Users adding custom entries has nothing to do with your patch. If a users 
adds a place and it appears everywhere, well that's his problem. Your patch 
adds it everywhere //for every user//, which is what I disagree with.
  
  
  It's easy for power users to 'hide' places they don't want in the panel.
  It's much easier than for the majority of users, lay users, who can neither 
add nor remove panel items, and want to see their pictures, their documents, 
and their downloads. 
  They also want to find their images and pdfs using search, the current 
interface makes that easy for them, for the majority workflow, who may not find 
things at easily otherwise.
  Most PC users, including many Linux users, don't even know where they store 
pictures or documents, they just expect them to appear, and if the UI (in this 
case Dolphin and the file-picker) doesn't do that anymore they're lost.
  For those who need more or less items in the panel, the minority, they're far 
more likely to be ones who can add or remove it themselves as required.
  
  >> Also if we add Music and Pictures et al to just Dolphin by default, then 
they're not going to show up in the file open/save dialogs where they're 
useful, right?
  > 
  > See comment above. I doubt Kate's users want to see Pictures. I agree that 
some apps would want to opt-in, not sure how to do that. I think the best thing 
would be to make this mimetype dependent: If the file dialog detects you want 
to open/save Music files, it should add "Music" to the standard model. That 
would be an addition to the file dialog though, not where you are currently 
changing it. Do we have a resident file dialog expert around we could ask about 
that?
  
  It should be fine for Pictures to show up in Kate's dialogue. It's easy to 
miss something very important for much users: they prefer - our brains prefer - 
consistency in presentation - it makes it easier to find things.
  If the panel changes each time we open it both feels less comfortable, less 
familiar, and makes it harder for our eyes to jump to what we want (whether 
through Kate, or uploading via browser, or trying to open a pdf).
  So (unintuitively) removing Pictures in Kate can slow the workflow rather 
than improve it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: markg, spoorun, rkflx, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 164 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/164/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 03 Feb 2018 07:19:37 +
 Build duration:
22 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/87/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 07:19:37 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/107/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 07:19:37 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31561/59419)38%
(18605/48560)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5350/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14344)50%
(4875/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 106 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/106/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 07:19:37 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31560/59418)38%
(18602/48636)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8632/9060)50%
(5351/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14344)50%
(4870/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(510/974)42%
(395/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D9966: [KIO] Fix issues with sharing of file descriptor

[Thiago Macieira]

thiago added a comment.


  Why do you ask for a rewview then not wait for the review?
  
  Belated -1. No actual review of the change done, because I can't tell what 
you've done.

INLINE COMMENTS

> fdreceiver.cpp:34
>  {
> +SocketAddress addr(m_path.toStdString());
> +if (!addr.address()) {

Don't use toStdString(). I know this is what it used to do, but you can take 
the opportunity to fix the issue.

> fdreceiver.cpp:88
> +}
> +#else
> +#error Cannot get socket credentials!

Where's the support for other OSes?

> fdreceiver.h:45
>  int m_fileDes;
> +QString m_path;
>  };

Nitpick: always sort your members by size.

> file.h:106
>  bool privilegeOperationUnitTestMode();
> -PrivilegeOperationReturnValue execWithElevatedPrivilege(ActionType 
> action, const QVariant ,
> -const QVariant 
>  = QVariant(),
> -const QVariant 
>  = QVariant());
> -PrivilegeOperationReturnValue tryOpen(QFile , const QByteArray , 
> int flags, int mode);
> +PrivilegeOperationReturnValue execWithElevatedPrivilege(ActionType 
> action, const QVariantList , int errcode);
> +PrivilegeOperationReturnValue tryOpen(QFile , const QByteArray , 
> int flags, int mode, int errcode);

This change should be in a separate commit. I can't tell what you're doing 
specifically to fix the bug with so much noise in this commit.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10233: [KIO] Remove PrivilegeExecution job flag

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for remembering to clean this up in time.
  
  Indeed not many people tested it, since it's still disabled...
  
  I tried to revert 
https://phabricator.kde.org/R241:5a1ea84476e63a97313d2201fc3d1f7033ea56af, 
restart kdeinit5 and kill kio_file instances, and copying a file to '/' indeed 
offers to do it as root, but then fails (no password prompt is shown). Either 
it's broken or I'm not testing it right (I'm installing everything into a 
custom prefix, so I copied the polkit file to 
/usr/share/polkit-1/actions/org.kde.kio.file.policy but maybe there are other 
files I need to copy?)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10233

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

[Mark Gaiser]

markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.

REVISION SUMMARY
  Small performance improvement of just not caching the targetUrlList() result.
  The only use for that list was returning it in 
KFileItemListProperties::urlList() so we might as well just call 
m_items.targetUrlList() there and not save it locally.
  
  This came up as redundant list creation when figuring out where all the QUrl 
objects came from in a drag/drop action in Dolphin.

TEST PLAN
  I did not benchmark this, seems rather trivial.
  Ran the testcases (most relevant is probablt KFileItemTest), all pass just 
fine.

REPOSITORY
  R241 KIO

BRANCH
  KFileItemListProperties_optimizations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10256

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham

D9672: Don't emit error signal before we tried all list commands.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  ERR_* is KIO-wide, and isn't technically an enum.
  
  But the proper error code for no error is KJob::NoError (which is 0). Can you 
switch to that, and adjust the second comment, and kill the first comment 
altogether? (redundant with code and with 2nd comment)
  
  Thanks! (and sorry for the delay, too)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9672

To: wcpan, dfaure
Cc: cfeck, #frameworks, michaelh, ngraham

D10155: Use the much faster urls() method from QMimeData

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kurlmimedata.cpp:75
> +QByteArray ba = mimeData->data(firstMimeType);
> +if (ba.isEmpty() || firstMimeType == QStringLiteral("text/uri-list")) {
>  // Extracting uris from text/uri-list, use the much faster QMimeData 
> method urls()

This can't be right, it would mean ba is ignored when 
firstMimeType==text/uri-list (which would mean the call to data() above was for 
nothing).

Since the method to call (data() or urls()) depends on the mimetype, either the 
whole idea of swapping the mimetypes has to be dropped, or as Milian suggests, 
a helper with an if() should encapsulate this (so we can call it in both 
places) (but that's more string comparisons).

To make it fast I'd do, well, OK the code wouldn't fit into this margin, let's 
make a separate RR: https://phabricator.kde.org/D10257

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10155

To: jtamate, #frameworks, dfaure
Cc: mwolff, michaelh, ngraham

D10257: KUrlMimeData: fix handling of PreferLocalUrls

[David Faure]

dfaure updated this revision to Diff 26397.
dfaure added a comment.


  remove unrelated change

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10257?vs=26396=26397

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10257

AFFECTED FILES
  src/lib/io/kurlmimedata.cpp

To: dfaure, mwolff, jtamate
Cc: #frameworks, michaelh, ngraham

D10257: KUrlMimeData: fix handling of PreferLocalUrls

[David Faure]

dfaure created this revision.
dfaure added reviewers: mwolff, jtamate.
Restricted Application added a project: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  https://phabricator.kde.org/R244:18e4d245d3d595cdc17ad40aa88495d6d2c30bf7 
didn't quite have the right logic after all

TEST PLAN
  Unittest passes (but this commit proves that it doesn't cover all cases...)

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10257

AFFECTED FILES
  KF5CoreAddonsMacros.cmake
  src/lib/io/kurlmimedata.cpp

To: dfaure, mwolff, jtamate
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/103/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 00:35:14 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31576/59418)38%
(18606/48636)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5351/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8350/14344)50%
(4877/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10233: [KIO] Remove PrivilegeExecution job flag

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  Try copying org.kde.kio.file.conf and .service file to dbus-1 directory. It 
worked for me.
  
  On a completely different note, do all jobs have a uidelgate or does passing 
HideProgressInfo flag prevent it from being created?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10233

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/104/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 01:47:44 +
 Build duration:
41 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31569/59436)38%
(18638/48714)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5352/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8341/14344)50%
(4880/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(516/989)41%
(418/1014)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10172: KRun: allow executing "add network folder" without confirmation prompt

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10172

To: dfaure, mwolff, dhaumann
Cc: elvisangelaccio, ngraham, #dolphin, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/83/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Feb 2018 23:45:21 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

[Mark Gaiser]

markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.

REVISION SUMMARY
  As the title says. Minor optimization.

TEST PLAN
  Ran the testcases, all pass just fine.
  Also in callgrind it's one less call to the KFileItemListProperties 
constructor that takes a KFileItemList. A small win :)

REPOSITORY
  R241 KIO

BRANCH
  KFileItemListProperties_stage2

REVISION DETAIL
  https://phabricator.kde.org/D10261

AFFECTED FILES
  src/widgets/dropjob.cpp

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8d8f3025dffd: [KIO] Fix issues with sharing of file 
descriptor (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9966?vs=26220=26403

REVISION DETAIL
  https://phabricator.kde.org/D9966

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/105/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 01:47:44 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31571/59436)38%
(18627/48638)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5354/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8337/14343)50%
(4868/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3856/7802)33%
(1626/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(516/989)41%
(418/1014)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 163 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/163/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 03 Feb 2018 01:54:51 +
 Build duration:
9 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 401.10 KB...][ 20%] Automatic MOC for target jobtestGenerating MOC source EWIEGA46WW/moc_jobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target jobtest_autogenScanning dependencies of target kprotocolinfotest_autogen[ 20%] Automatic MOC for target kprotocolinfotestGenerating MOC source include/kprotocolinfotest.mocGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target kprotocolinfotest_autogenScanning dependencies of target ktcpsockettest_autogen[ 21%] Automatic MOC for target ktcpsockettestGenerating MOC source EWIEGA46WW/moc_ktcpsockettest.cppGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target ktcpsockettest_autogenScanning dependencies of target mkpathjobtest_autogen[ 21%] Automatic MOC for target mkpathjobtestGenerating MOC source include/mkpathjobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target mkpathjobtest_autogenScanning dependencies of target threadtest_autogen[ 22%] Automatic MOC for target threadtestGenerating MOC source include/threadtest.mocGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target threadtest_autogenScanning dependencies of target udsentrytest_autogen[ 22%] Automatic MOC for target udsentrytestGenerating MOC source EWIEGA46WW/moc_udsentrytest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target udsentrytest_autogenScanning dependencies of target deletejobtest_autogen[ 22%] Automatic MOC for target deletejobtestGenerating MOC source EWIEGA46WW/moc_deletejobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target deletejobtest_autogenScanning dependencies of target urlutiltest_autogen[ 23%] Automatic MOC for target urlutiltestGenerating MOC source include/urlutiltest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target urlutiltest_autogenScanning dependencies of target batchrenamejobtest_autogen[ 23%] Automatic MOC for target batchrenamejobtestGenerating MOC source include/batchrenamejobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target batchrenamejobtest_autogenScanning dependencies of target http_jobtest_autogen[ 23%] Automatic MOC for target http_jobtestGenerating MOC source include/http_jobtest.mocGenerating MOC source EWIEGA46WW/moc_httpserver_p.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target http_jobtest_autogenScanning dependencies of target kcookiejartest_autogen[ 23%] Automatic MOC for target kcookiejartestGenerating MOC source include/kcookiejartest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kcookiejartest_autogenScanning dependencies of target kio_http_autogen[ 23%] Automatic MOC for target kio_httpGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kio_http_autogenScanning dependencies of target httpauthenticationtest_autogen[ 24%] Automatic MOC for target httpauthenticationtestGenerating MOC source EWIEGA46WW/moc_httpauthenticationtest.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpauthenticationtest_autogenScanning dependencies of target httpobjecttest_autogen[ 24%] Automatic MOC for target httpobjecttestGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cppScanning dependencies of target kio_file[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_win.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.objfile.cppfile_win.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file_win.cpp(392): error C2660: 'PrivilegeOperationReturnValue::failure': function does not take 0 argumentsC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file_win.cpp(396): error C2660: 'PrivilegeOperationReturnValue::failure': function does not take 0 argumentsC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file_win.cpp(401): error C2660: 'PrivilegeOperationReturnValue::failure': function does not take 0 argumentsmocs_compilation.cppTODO: st_uid and st_gid are always zero, use GetSecurityInfo to find the ownerjom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\src\ioslaves\file\CMakeFiles\kio_file.dir\build.make [src\ioslaves\file\CMakeFiles\kio_file.dir\file_win.cpp.obj] Error 

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/86/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 01:53:46 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D10257: KUrlMimeData: fix handling of PreferLocalUrls

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Looks OK to me.
  Had to read up on the KDE urls and local urls first though :)
  
  Funny side note. Those that text/uri-list can contain comments! 
https://tools.ietf.org/html/rfc2483#section-5
  But judging from the qmimedata.cpp file, Qt also doesn't check for that (or i 
didn't find it, possible as well).

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10257

To: dfaure, mwolff, jtamate, markg
Cc: markg, ngraham, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 106 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/106/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 02:06:41 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31572/59436)38%
(18620/48638)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5353/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8338/14343)50%
(4864/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3856/7802)33%
(1626/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(516/989)41%
(418/1014)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 103 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/103/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 02 Feb 2018 23:45:21 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31585/59420)38%
(18611/48560)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5350/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8363/14345)50%
(4880/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3856/7802)33%
(1626/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/84/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 00:31:46 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 162 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/162/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 03 Feb 2018 01:47:44 +
 Build duration:
6 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 402.28 KB...]Generating MOC source EWIEGA46WW/moc_jobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target jobtest_autogenScanning dependencies of target kprotocolinfotest_autogen[ 20%] Automatic MOC for target kprotocolinfotestGenerating MOC source include/kprotocolinfotest.mocGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target kprotocolinfotest_autogenScanning dependencies of target ktcpsockettest_autogen[ 21%] Automatic MOC for target ktcpsockettestGenerating MOC source EWIEGA46WW/moc_ktcpsockettest.cppGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target ktcpsockettest_autogenScanning dependencies of target mkpathjobtest_autogen[ 21%] Automatic MOC for target mkpathjobtestGenerating MOC source include/mkpathjobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target mkpathjobtest_autogenScanning dependencies of target threadtest_autogen[ 22%] Automatic MOC for target threadtestGenerating MOC source include/threadtest.mocGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target threadtest_autogenScanning dependencies of target udsentrytest_autogen[ 22%] Automatic MOC for target udsentrytestGenerating MOC source EWIEGA46WW/moc_udsentrytest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target udsentrytest_autogenScanning dependencies of target deletejobtest_autogen[ 22%] Automatic MOC for target deletejobtestGenerating MOC source EWIEGA46WW/moc_deletejobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target deletejobtest_autogenScanning dependencies of target urlutiltest_autogen[ 23%] Automatic MOC for target urlutiltestGenerating MOC source include/urlutiltest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target urlutiltest_autogenScanning dependencies of target batchrenamejobtest_autogen[ 23%] Automatic MOC for target batchrenamejobtestGenerating MOC source include/batchrenamejobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target batchrenamejobtest_autogenScanning dependencies of target http_jobtest_autogen[ 23%] Automatic MOC for target http_jobtestGenerating MOC source include/http_jobtest.mocGenerating MOC source EWIEGA46WW/moc_httpserver_p.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target http_jobtest_autogenScanning dependencies of target kcookiejartest_autogen[ 23%] Automatic MOC for target kcookiejartestGenerating MOC source include/kcookiejartest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kcookiejartest_autogenScanning dependencies of target kio_http_autogen[ 23%] Automatic MOC for target kio_httpGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kio_http_autogenScanning dependencies of target httpauthenticationtest_autogen[ 24%] Automatic MOC for target httpauthenticationtestGenerating MOC source EWIEGA46WW/moc_httpauthenticationtest.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpauthenticationtest_autogenScanning dependencies of target httpobjecttest_autogen[ 24%] Automatic MOC for target httpobjecttestGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpobjecttest_autogenScanning dependencies of target kio_file[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_win.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.objfile.cppfile_win.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file_win.cpp(392): error C2660: 'PrivilegeOperationReturnValue::failure': function does not take 0 argumentsC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file_win.cpp(396): error C2660: 'PrivilegeOperationReturnValue::failure': function does not take 0 argumentsC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file_win.cpp(401): error C2660: 'PrivilegeOperationReturnValue::failure': function does not take 0 argumentsmocs_compilation.cppTODO: st_uid and st_gid are always zero, use GetSecurityInfo to find the ownerjom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\src\ioslaves\file\CMakeFiles\kio_file.dir\build.make [src\ioslaves\file\CMakeFiles\kio_file.dir\file_win.cpp.obj] 

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

[Mark Gaiser]

markg edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10256

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  If urlList() is called often, then this is actually slower (targetUrlList() 
has to iterate and convert). But yeah I doubt it is called often...

REPOSITORY
  R241 KIO

BRANCH
  KFileItemListProperties_optimizations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10256

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/104/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 00:25:30 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31560/59419)38%
(18601/48560)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5350/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8339/14344)50%
(4871/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D9966: [KIO] Fix issues with sharing of file descriptor

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thiago, Ossi, looks ok to you too?
  
  (Tagging tomorrow...)

INLINE COMMENTS

> dfaure wrote in sharefd_p.h:51
> Is strlen needed? It seems to me that sun_path will be null if make_address 
> failed, so a simple null-pointer check would be enough here. Plus I remember 
> some implementations of strlen breaking on null pointers...

Looks good.

My own comment was partly nonsense, I see now (sun_path can't be a null 
pointer). But still this change is for the better, it makes it faster.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

[Mark Gaiser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c44784c98fcb: Dont cache the targetUrlList() result 
locally, return them from the locally… (authored by markg).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10256?vs=26394=26395

REVISION DETAIL
  https://phabricator.kde.org/D10256

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 102 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/102/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 02 Feb 2018 23:45:21 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31590/59419)38%
(18615/48636)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5350/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8363/14345)50%
(4877/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(510/974)42%
(395/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/85/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 01:47:44 +
 Build duration:
5 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D10233: [KIO] Remove PrivilegeExecution job flag

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ecaf513ed3cd: [KIO] Remove PrivilegeExecution job flag 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10233?vs=26326=26404

REVISION DETAIL
  https://phabricator.kde.org/D10233

AFFECTED FILES
  src/core/job_base.h

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/44/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 02 Feb 2018 10:05:03 +
 Build duration:
9 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

D10243: Improve visibility of disconnected Wi-Fi icon

[Andreas Kainz]

andreask retitled this revision from "Disconnected wi-fi icons are almost 
invisible BUG:384018" to "Improve visibility of disconnected Wi-Fi icon".
andreask edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5400: new class, KActionRunner

[Tomaz Canabrava]

tcanabrava abandoned this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D5400

To: tcanabrava, #frameworks, ltoscano
Cc: ltoscano, michaelh, ngraham

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask retitled this revision from "Improve visibility of disconnected Wi-Fi 
icon" to "Improve visibility of disconnected Wi-Fi icons".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7909: Add syntax support for Crystal Programming Language

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Sorry for the late reply.
  
  Please do the following changes:
  
  - remove hard-coded colors from itemDatas. This way, your highlighting will 
look good in all color themes.
  
  Also, is this language similar to other languages ? It seems it was copied 
from some other language, since it contains many authors.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate
Cc: ngraham, #kate, #frameworks, faguilar, michaelh, genethomas, cullmann, 
vkrause, dhaumann

D5209: Load translations from KPackage files if bundled

[Luigi Toscano]

ltoscano removed a dependency: D10215: Make KReport use marble component, KEXI 
& KEXI frameworks stable is 3.1.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5209

To: davidedmundson, #plasma, mart
Cc: ltoscano, Zren, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/42/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Feb 2018 10:05:03 +
 Build duration:
2 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask added a comment.


  F5688471: wifi icon.png 
  top after
  
  - breeze(light)
  - breeze-dark
  
  bottom before
  
  - breeze(light)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/44/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 02 Feb 2018 10:05:03 +
 Build duration:
5 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)