How to switch hosts?
I run RB via lighttpd on my desktop machine. It was recently swapped out for new hardware, and following company policy, the machine was renamed. Searching the files in my ~/local/servers/hostname directory, I found a couple innocuous references to my old hostname: ./review-board/logs/lighttpd-access.log ./review-board/logs/lighttpd-error.log and several which were in ASCII files (easily modified): ./review-board/conf/settings_local.py ./review-board/conf/lighttpd.conf ./review-board/conf/search-cron.conf ./review-board/htdocs/reviewboard.fcgi However, I found one SQLite file which contains a reference to the old hostname: ./review-board/db/reviewboard.db Can that reference be ignored? If not, how can I update that file without losing all my past review stuff? Thx, -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Tabbed diff viewer
Eduardo could you do a mockup of what you intend? I'm not sure a full mockup is necessary. Suppose you post a review with changes to five files. The left-hand sidebar would be file1 file2 file3 file4 file5 while the main pane would consist of five tabs, one for each file (file2 is the active tab in my bad ASCII art): /file1\ /file2\ /file3\ /file4\ /file5\ --- --- line 1 | line 1 line 2 | line 2 ...| ... Each tab would display just the diff for a single file. Clicking a tab or the file name in the sidebar would bring that file's diff to the front. At least that's how I understood the OP's proposal. Eduardo Also, how would your proposed design scale to a very large Eduardo review? Say one consisting of 50+ files. I suspect at that size your tabs would have to cascade into multiple rows: /file1\ /file2\ /file3\ /file4\ /file5\ --- /file6\ /file7\ /file8\ /file9\ /file10\ --- etc but I view that as just a complication of the JavaScript necessary to work this wizardry. -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to properly close out review requests?
Christian You should almost never use Delete Permanently. We use it in Christian the case of spam, but even a history of abandoned code Christian reviews can be useful. Yeah, I sort of figured that. Christian The proper way is to use Submitted. Where are you seeing Christian existing entries with [Submitted]? You shouldn't in the Christian dashboard (unless it's the My Requests, which is explicitly Christian designed to show you that so you can get back to them) or the Christian All Review Requests page (in which case you can toggle Christian whether these are shown). I guess Submitted and Discarded don't mean anything to me. Names like Completed, Rejected, etc. would seem to make more sense. Could you maybe provide a tooltip/rollover in future versions which provides a short help message for those terms? Thanks, -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
How to review an entire application?
I'm still getting familiar with Review Boar. I use it like so: * make a branch * edit/debug/lather/rinse/repeat * post-review * visit url fill in description, title, assign reviewers One of my colleagues asked a few of us to review a couple small applications written by a new hire. This stuff had already been checked into our CVS repository. I suspect this is not standard practice, but is there some way to post a review request for an entire application or an entire directory (that is, where there are no changes against the repository for the current directory)? I see nothing obvious in post-review --help output which suggests this is possible. I'm using post-review 0.8 and ReviewBoard 0.9 ATM, but I have the power to upgrade it if necessary (it's just running on my desktop machine). Outside of me and a few other developers ReviewBoard is unknown at work, so I imagine this sort of here, the application is finished, please review it all request is going to pop up for some time to come. I'd really like to be able to accommodate such requests as a way to demonstrate RB's usefulness. Thanks, -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to review an entire application?
Christian Let me see if I have this right. You have a directory full of Christian committed code that hasn't been reviewed yet. This code may Christian span multiple revisions. You want to put that code up for Christian review. Is that correct? Yup. Christian There's no built-in option for doing this with CVS, but with Christian RBTools 0.2 RC1, you could make use of the new Christian --diff-filename. Basically, you'd generate a diff using cvs Christian diff and covering all revisions of that directory only, and Christian then pass the resulting filename using post-review Christian --diff-filename=filename Thanks. In looking back at what was installed I think I actually had 1.0.4 installed, not 0.9. I was looking at the version string in __init__.py. I have upgraded to the latest versions of ReviewBoard and RBTools nonetheless. It seems to me that If I'm trying to gather up all the Python files in a directory for submission as a review diff that this should work: for f in $(find . -name '*.py') ; do diff -Nu /dev/null $f done review.diff post-review --diff-filename=review.diff ... I haven't actually tried that yet, but that would seem to be a good first approximation. Skip -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can I create logical repositories from one large one?
The easiest way to post to Review Board is to use post-review, part of RBTools (see the downloads page and user manual). This will handle creating the review request and diff and uploading with all the correct information. Thanks. I created a .reviewboardrc file to specify the URL then executed post-review -r 2 (I intended to update an existing review). It munched for a bit, then asked me for my RB username and password, then exited with this error: Unable to access http://servername/reviews/api/json/reviewrequests/2/diff/new/. The host path may be invalid HTTP Error 503: Service Not Available I looked all over the admin settings to see if there was something I needed to do to enable JSON access but didn't see anything. What am I missing? Thx, Skip You do need one repository entry per actual CVS repository though, which will cover all modules in that repository. Christian On Thursday, October 8, 2009, Skip Montanaro skip.montan...@gmail.com wrote: We have one big CVS repository. I'd like to create multiple logical repositories for ReviewBoard use. For example, we have one project called Snake: :pserver:u...@cvs:/cvs/python/modules/snake We have lots of application code stored there as well, e.g.: :pserver:u...@cvs:/cvs/apps/snakeCharmer The CVSROOT is :pserver:u...@cvs:/cvs. Can I create a logical Snake repository and another repo for the snakeCharmer app with extended path names or must people submitting review requests know to always include the path from ...:/cvs to the base of the diff? To make it more concrete, suppose I want to submit a diff to snakeCharmer as a review request. The normal way to diff would be (I think): cd .../apps/snakeCharmer cvs diff request.diff then submit request.diff for review. Is there some way to create a snakeCharmer repository which knows about apps/snakeCharmer and makes it unnecessary for the user to always enter that as the base path to request.diff? My apologies for all these elementary questions. I'm sure the frequency will decrease as I gain experience. Thx, Skip Montanaro -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Can I create logical repositories from one large one?
post-review -r 2 (I intended to update an existing review). It munched for a bit, then asked me for my RB username and password, then exited with this error: Unable to access http://servername/reviews/api/json/reviewrequests/2/diff/new/. The host path may be invalid HTTP Error 503: Service Not Available I eventually got around this problem. Not sure how. In any case I am able to successfully post-review for our Subversion repository. I still can't post-review for CVS though. Here's my CVS/Root: :pserver:sk...@cvs.trdlnk.com:/cvs I never set CVSROOT. cvs.trdlnk.com is an alias for vicksburg.wacker.trdlnk.com. When I try to create a review from our CVS repository using post- review it thinks for a bit then responds: Error creating review request: The repository path specified is not in the list of known repositories (code 206) I found that message (webapi/json.py I believe), then added an import logging and a logging.error() call to tell me what the invalid path was. In my reviewboard.log file I found 2009-10-09 19:40:12,695 - ERROR - Invalid repository path: u'vicksburg:/cvs' Where is it coming up with vicksburg? I tried fiddling with my CVS repository path through the website, then killing reviewboard.fcgi to make sure the change was picked up. Where is it picking up u'vicksburg:/cvs'? Thx, Skip --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: reviews don't show up, djblets ref seems incorrect
See what your Media URL says. It should be /media/ That did the trick. It was set to something like /reviews/ servername. Everything seems to be working fine now. I was even able to create a review... Woo hoo! Thanks, --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Can I create logical repositories from one large one?
We have one big CVS repository. I'd like to create multiple logical repositories for ReviewBoard use. For example, we have one project called Snake: :pserver:u...@cvs:/cvs/python/modules/snake We have lots of application code stored there as well, e.g.: :pserver:u...@cvs:/cvs/apps/snakeCharmer The CVSROOT is :pserver:u...@cvs:/cvs. Can I create a logical Snake repository and another repo for the snakeCharmer app with extended path names or must people submitting review requests know to always include the path from ...:/cvs to the base of the diff? To make it more concrete, suppose I want to submit a diff to snakeCharmer as a review request. The normal way to diff would be (I think): cd .../apps/snakeCharmer cvs diff request.diff then submit request.diff for review. Is there some way to create a snakeCharmer repository which knows about apps/snakeCharmer and makes it unnecessary for the user to always enter that as the base path to request.diff? My apologies for all these elementary questions. I'm sure the frequency will decrease as I gain experience. Thx, Skip Montanaro --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
How do I fire up Review Board at this point?
I'm trying to get Review Board fired up for testing. I got most everything set up. I skipped PyLucene and memcached, at least for now (couldn't get cmemcache to build on Sol10). I successfully ran rb-site install and think I copied the necessary bits from the generated lighttpd.conf file into the config file I'm using. I got an Internal Server Error when I tried to access the home page (it worked before I added the lighttpd.conf stuff). Then I remembered I needed to set PYTHONPATH, so added a bin-environment clause to my config. Now when I try to access the home page I get a 404. Interestingly enough, I can get to the loging/register/admin pages, so *something* is working. Warning: Not only am I a Review Board novice, this is my first exposure to either lighttpd or Django. It's quite likely that the changes necessary to get be going are pretty trivial. Where do I go from here? Thanks, Skip Montanaro --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
reviews don't show up, djblets ref seems incorrect
I think I successfully created a couple users, groups and repositories. I then tried to create a review request. Nothing shows up when I select the All review requests link. Also, the djblets URL is incorrect. It's clear no css activity is taking place, so I wonder if the necessary JavaScript isn't loaded. Here's a line wrapped record from the access log file: 10.100.0.34 udesktop116:3000 - [07/Oct/2009:15:43:40 +] GET /reviews/udesktop116/djblets/js/jquery-1.3.2.min.js HTTP/1.1 404 2904 http://udesktop116:3000/reviews/groups/Rigel/; Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.1) Gecko/20090625 Firefox/3.5 When I look for djblets I find them in media: % pwd /home/titan/skipm/local/servers/udesktop116 % find . -name djblets ./review-board/htdocs/media/djblets but the request doesn't include ...media I'm probably missing something in some piece of ReviewBoard configuration, but don't know where I should look. Any pointers much appreciated. Skip Montanaro --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Review Board on Solaris or Mac?
I see no install instructions for non-Linux Unix variants such as Solaris or Mac OS X. Before I launch into installing all the bits and pieces only to find out that one bit or piece doesn't work on non-Linux platforms. I searched the group for both Solaris and Apple but got no hits. Someone must have tried. Any BTDT experience to relate? Thanks, Skip Montanaro --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board on Solaris or Mac?
Thanks for the replies. Our IT folk are just installing/testing Python 2.6.x so maybe this would be a good test case. Skip --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
