Issue 1704 in reviewboard: Problem with clearcase and post-review....
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1704 by louishovasse: Problem with clearcase and post-review
http://code.google.com/p/reviewboard/issues/detail?id=1704
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
ReviewBoard 1.0.8
What steps will reproduce the problem?
1.try to post-review with clearcase
What is the expected output? What do you see instead?
Z:\vob_demopost-review
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
File C:\Python25\lib\site-packages\rbtools-0.2-py2.5.egg\rbtools\postreview.p
y, line 2847, in main
File C:\Python25\lib\site-packages\rbtools-0.2-py2.5.egg\rbtools\postreview.p
y, line 1033, in diff
File C:\Python25\lib\site-packages\rbtools-0.2-py2.5.egg\rbtools\postreview.p
y, line 897, in get_extended_namespace
File C:\Python25\lib\site-packages\rbtools-0.2-py2.5.egg\rbtools\postreview.p
y, line 888, in get_previous_version
IndexError: list index out of range
Z:\vob_demo
What operating system are you using? What browser?
Windows XP SP3 4x3GHz 4Go ram
WAMP5 Python2.5 mod_python
Please provide any additional information below.
Everytime I try to post a review with clearcase configuration, I have this
error message...
Thank you for helping.
Regards
Louis
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1705 in reviewboard: SELLING A PHONE
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1705 by angelapelaez90: SELLING A PHONE http://code.google.com/p/reviewboard/issues/detail?id=1705 BRAND NEW BLACKBERRY BOLD 9700 BUY IT :D *NOTE: Do not post confidential information in this bug report.* What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1706 in reviewboard: View Diff causes un-saved changes to Description to be dropped
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1706 by gtalvola: View Diff causes un-saved changes to Description to be dropped http://code.google.com/p/reviewboard/issues/detail?id=1706 What version are you running? 1.5 beta 2 What steps will reproduce the problem? When viewing a review request, start editing the description field. Then click on View Diff. This drops your edits to the Description field without warning, potentially causing you to lose quite a lot of typing. I'd prefer automatic save of all pending edits. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1707 in reviewboard: Description should not be required
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1707 by gtalvola: Description should not be required http://code.google.com/p/reviewboard/issues/detail?id=1707 What version are you running? 1.5 beta 2 Sometimes the summary is enough to describe the review request, and the description isn't necessary. I'd prefer the option to allow an empty description. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1705 in reviewboard: SELLING A PHONE
Updates: Status: Spam Comment #1 on issue 1705 by trowbrds: SELLING A PHONE http://code.google.com/p/reviewboard/issues/detail?id=1705 Try craigslist.org -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1637 in reviewboard: Review Board + perforce can not upload diff
Comment #8 on issue 1637 by paul.dubois: Review Board + perforce can not upload diff http://code.google.com/p/reviewboard/issues/detail?id=1637 That was the issue. p4 in /usr/sbin instead of /usr/bin. Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1708 in reviewboard: guess-summary generates bad summary when hg doesn't trust hgrc
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1708 by gordon.morehouse: guess-summary generates bad summary when hg doesn't trust hgrc http://code.google.com/p/reviewboard/issues/detail?id=1708 What version are you running? post-review 0.2.1 alpha 0 What steps will reproduce the problem? 1. Post a review using post-review in a case where relevant .hgrc is not trusted by Mercurial -- see http://www.selenic.com/pipermail/mercurial/2006-October/011550.html 2. Summary contains two concatenated error messages: Not trusting file /path/to/.hg/hgrc from untrusted user user1, group group1 Not trusting file /path/to/.hg/hgrc from untrusted user user1, group group1 Should instead see a proper summary, or something other than smushed-together error messages. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1708 in reviewboard: guess-summary generates bad summary when hg doesn't trust hgrc
Comment #1 on issue 1708 by gordon.morehouse: guess-summary generates bad summary when hg doesn't trust hgrc http://code.google.com/p/reviewboard/issues/detail?id=1708 I'm going to amend this -- post-review doesn't appear to be using the global .hgrc in ~/.hgrc, because in the above example, user1 and group1 are listed as trusted there. The title of this bug should be changed and the priority bumped a bit higher accordingly, it's less than just cosmetic. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1708 in reviewboard: guess-summary generates bad summary when hg doesn't trust hgrc
Comment #2 on issue 1708 by gordon.morehouse: guess-summary generates bad summary when hg doesn't trust hgrc http://code.google.com/p/reviewboard/issues/detail?id=1708 ...This also appears in the description. Sorry about the rapid fire posting, but I forgot to mention that fact and that this applies to --guess-summary and --guess-description. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1709 in reviewboard: The diff view is misplaced
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1709 by vera1171: The diff view is misplaced http://code.google.com/p/reviewboard/issues/detail?id=1709 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.5beta2 What's the URL of the page containing the problem? It's in the LAN,so there is no way to give. What steps will reproduce the problem? 1.create review topic,and then publish 2.view diff 3. What is the expected output? What do you see instead? I expected the diff view is exactly show difference.However,I saw the difference is misplaced. What operating system are you using? What browser? Window xp sp2.Firefox. Please provide any additional information below. You can see the picture I uploaded. Attachments: 错位.JPG 64.7 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1710 in reviewboard: Bad link (subversion installers) in installation dox
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1710 by repenning.jack: Bad link (subversion installers) in installation dox http://code.google.com/p/reviewboard/issues/detail?id=1710 What's the URL of the page containing the problem? http://www.reviewboard.org/docs/manual/dev/admin/installation/windows/#subversion Describe the problem and any recommendations below. Link text: Subversion downloads Link target: http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=8100 Problem: that folder no longer exists Symptom: Tigris site reports servlet error (which is pretty bogus, but not ReviewBoard's problem!) Suggested replacement target: http://www.open.collab.net/downloads/subversion.html Please provide any additional information below. The folder you've linked two was formerly maintained by community volunteers, but has fallen into disuse (hasn't been updated in half a dozen releases). The volunteers abandoned this process because professionally built and certified (but still free) installers are now available. The contents of these folders have become stale, and will soon be entirely superseded (by Subversion 1.7). The Tigris folders were rearranged to draw attention to this, and lead users to more current installers. There are a couple sources, but the one I suggested above is the most popular. Alternatively, but somewhat less directly, you might link to the community's package directory, from which your users would then select their own installers for any platform: http://subversion.apache.org/packages.html -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1672 in reviewboard: ReviewBoard hide existing revisions
Comment #3 on issue 1672 by Jan.Koprowski: ReviewBoard hide existing revisions http://code.google.com/p/reviewboard/issues/detail?id=1672 I still don't know what is happen but I make a little investigation. There is reviewboard/diffviewer/views.py:view_diff_fragment():line 218 'standalone': chunkindex is not None and for some reason for this two files chunkindex is None. But I don't know why. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1518 in reviewboard: new json api - get list of review requests created between date range
Updates: Status: Fixed Owner: chipx86 Comment #3 on issue 1518 by chipx86: new json api - get list of review requests created between date range http://code.google.com/p/reviewboard/issues/detail?id=1518 Added on master (cd0f182) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1539 in reviewboard: 'WatchedGroupDataGrid' object has no attribute 'counts'
Updates: Owner: chipx86 Labels: Milestone-Release1.5 Comment #3 on issue 1539 by chipx86: 'WatchedGroupDataGrid' object has no attribute 'counts' http://code.google.com/p/reviewboard/issues/detail?id=1539 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1539 in reviewboard: 'WatchedGroupDataGrid' object has no attribute 'counts'
Updates: Status: Fixed Comment #4 on issue 1539 by chipx86: 'WatchedGroupDataGrid' object has no attribute 'counts' http://code.google.com/p/reviewboard/issues/detail?id=1539 Fixed on master (7245bed) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1711 in reviewboard: Bug in RBTools with Clearcase and post-review
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1711 by louishovasse: Bug in RBTools with Clearcase and
post-review
http://code.google.com/p/reviewboard/issues/detail?id=1711
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.08
What's the URL of the page containing the problem?
the problem is the RBTools
What steps will reproduce the problem?
1.go in a clearcase dynamic view
2.try to post-review
What is the expected output? What do you see instead?
I expexted the link to the new review.
I got this error message:
Z:\vob_demo\soft\gdjololipost-review file.c@@\main\1
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in module
load_entry_point('rbtools==0.2', 'console_scripts', 'post-review')()
File C:\Python25\lib\site-packages\rbtools-0.2-py2.5.egg\rbtools\postreview.p
y, line 2927, in main
File C:\Python25\lib\site-packages\rbtools-0.2-py2.5.egg\rbtools\postreview.p
y, line 1061, in diff
File C:\Python25\lib\site-packages\rbtools-0.2-py2.5.egg\rbtools\postreview.p
y, line 952, in get_extended_namespace
IndexError: list index out of range
Z:\vob_demo\soft\gdjololi
What operating system are you using? What browser?
Windows XP SP3 with Firefox 3.6.6
Please provide any additional information below.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1543 in reviewboard: keyboard shortcuts for main application views (individual review and dashboard)
Comment #2 on issue 1543 by zitrax1978: keyboard shortcuts for main application views (individual review and dashboard) http://code.google.com/p/reviewboard/issues/detail?id=1543 Could there also be an option in preferences for disabling keyboard shortcuts altogether ? It annoys me that it overrides my default browser shortcuts. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1543 in reviewboard: keyboard shortcuts for main application views (individual review and dashboard)
Comment #3 on issue 1543 by chipx86: keyboard shortcuts for main application views (individual review and dashboard) http://code.google.com/p/reviewboard/issues/detail?id=1543 Can you file that as a separate request? It's hard to manage feature requests that contain several different tasks. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1709 in reviewboard: The diff view is misplaced
Updates: Status: NeedInfo Comment #1 on issue 1709 by chipx86: The diff view is misplaced http://code.google.com/p/reviewboard/issues/detail?id=1709 That is certainly very, very odd. I haven't seen this before. Are there any non-UTF-8 characters in this diff? Would you mind trying 1.5 RC 1, clearing your memcached, and then viewing the diff again? There was a small bug in the diff viewer that was fixed. It *might* be related, but it's really hard to say. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1712 in reviewboard: Increase auth_user.username field size and allow '@' in user names
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1712 by ricklei: Increase auth_user.username field size and allow '@' in user names http://code.google.com/p/reviewboard/issues/detail?id=1712 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.5 RC1 What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. Allow '@' in user names and increase the size of auth_user.username column would allow email address to be used as user account names. Our LDAP server returns email addresses as principal names, which therefore will be used as account names. Since RB doesn't really allow '@' in account name, this kind of accounts can't be edited (granting permissions etc) in the admin dashboard. Also the varchar(30) size limit for user name holds a big problem for longer email address. What operating system are you using? What browser? RB server: Ubuntu 10.04 w/ lighttpd + postgresql Client: Windows XP SP3 / Windows 7 Browser: Firefox 3.x / Chrome 5.x / IE 7/8 Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1712 in reviewboard: Increase auth_user.username field size and allow '@' in user names
Comment #1 on issue 1712 by chipx86: Increase auth_user.username field size and allow '@' in user names http://code.google.com/p/reviewboard/issues/detail?id=1712 Unfortunately, these are restrictions put in place by Django, and not something we have a lot of control over. At least, the name length. We could potentially do something about the '@', and I thought that was covered under another bug report already, but I'm not seeing it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1712 in reviewboard: Increase auth_user.username field size and allow '@' in user names
Comment #2 on issue 1712 by ricklei: Increase auth_user.username field size and allow '@' in user names http://code.google.com/p/reviewboard/issues/detail?id=1712 A one byte patch to accounts/admin.py would fix the '@' issue: --- accounts/admin.py 2010-07-06 13:09:40.0 +0800 +++ ../reviewboard-local/accounts/admin.py 2010-07-02 09:08:36.0 +0800 @@ -8,7 +8,7 @@ from reviewboard.accounts.models import ReviewRequestVisit, Profile -USERNAME_REGEX = r'^[-\w.]+$' +USERNAME_REGEX = r'^[-...@]+$' USERNAME_HELP_TEXT = _(Required. 30 characters or fewer. Alphanumeric characters only (letters, digits, underscores, and periods).) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1713 in reviewboard: postreview.py fails with API Error 105
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1713 by daniel.shiryu: postreview.py fails with API Error 105
http://code.google.com/p/reviewboard/issues/detail?id=1713
We use the pre-commit-hook from this review:
http://reviews.reviewboard.org/r/822/
It uses the api-classes in reviewboard.py from RBTools 0.2 to make the
calls to the server and create a new review-request.
Since upgrading from 1.5beta2 to 1.5rc1 the commit-hook does not work
anymore because of the following error:
HTTP POSTing to
http://reviewboard.xxx.com/api/json/reviewrequests/44/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['table diffviewer_filediff has no
column named status']}, 'stat': 'fail', 'err': {'msg': 'One or more
fields had errors', 'code': 105}, 'deprecated': {'in_version': '1.5'}}
Is this a regression introduced in ReviewBoard 1.5rc1, or is it that
reviewboard.py or the pre-commit-hook is outdated and needs fixing?
What version are you running?
ReviewBoard 1.5RC1.
What's the URL of the page containing the problem?
Probably api/json/reviewrequests/44/diff/new/
What steps will reproduce the problem?
1. Try to create a new review-request through the commit-handler (which
uses postreview.py)
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1713 in reviewboard: postreview.py fails with API Error 105
Comment #1 on issue 1713 by chipx86: postreview.py fails with API Error 105 http://code.google.com/p/reviewboard/issues/detail?id=1713 Neither. It looks like you didn't run 'rb-site upgrade' on your site, so there are fields missing from your database. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1684 in reviewboard: Error: Please correct the error below django.utils.functional.__proxy__ object at 0x257dfd0
Comment #3 on issue 1684 by Jan.Koprowski: Error: Please correct the error below django.utils.functional.__proxy__ object at 0x257dfd0 http://code.google.com/p/reviewboard/issues/detail?id=1684 Now I can't reproduce. Before - change git repository owner helps. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1714 in reviewboard: post-review not working from SUSE machine
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1714 by mandarb: post-review not working from SUSE machine http://code.google.com/p/reviewboard/issues/detail?id=1714 *NOTE: Do not post confidential information in this bug report.* What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. run command post-review change-set or post-review-qa change-set 2. It asks for Review Board Login Required 3. After entering username and password, it gives message as below Unable to access http://reviewboard-qa.eng.vmware.com/reviewboard-qa.eng.vmware.com/api/json/accounts/login/. The host path may be invalid HTTP Error 501: Not Implemented What is the expected output? What do you see instead? - Expected output : post review on reviewboard-qa - Output seen Unable to access http://reviewboard-qa.eng.vmware.com/reviewboard-qa.eng.vmware.com/api/json/accounts/login/. The host path may be invalid HTTP Error 501: Not Implemented What operating system are you using? What browser? SLES 11 Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1714 in reviewboard: post-review not working from SUSE machine
Updates: Status: SetupIssue Comment #1 on issue 1714 by chipx86: post-review not working from SUSE machine http://code.google.com/p/reviewboard/issues/detail?id=1714 It looks like a configuration issue on your end. You'll need to file a ticket against the maintainers at VMware. This tracker is for bugs in the software. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1715 in reviewboard: Rb breaks Git patches with new files/deleted files
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1715 by j...@multani.info: Rb breaks Git patches with new files/deleted files http://code.google.com/p/reviewboard/issues/detail?id=1715 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.5 beta 2 (dev) What steps will reproduce the problem? 1. Create a new review request using a patch from a Git repository, which creates a new file. The header of the hunk looks like this: diff --git a/foo.py b/foo.py new file mode 100644 index 000..e4da686 --- /dev/null +++ b/foo.py @@ -0,0 +1 @@ +Some content 2. Then, download the patch from ReviewBoard, by clicking on the Download Diff button. the patch contains the following content: diff --git a/foo.py b/foo.py --- /dev/null +++ b/foo.py @@ -0,0 +1 @@ +Some content 3. Using git apply to apply the patch, retrieved from the Reviewboard, on a repository result in the following error: $ git apply foo.patch error: dev/null: No such file or directory 4. If I manually update the patch file downloaded from the ReviewBoard, adding the two lines which has disappeared, the patch can be applied by git AFAIR, the same problem occurs when the patch contains files which have been deleted. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 164 in reviewboard: Add an optional checklist for reviewers to check off
Comment #5 on issue 164 by AaronJSherman: Add an optional checklist for reviewers to check off http://code.google.com/p/reviewboard/issues/detail?id=164 schapht, I don't think that was in the request. It was just a request for a checklist that reviewers could be asked to complete before signing off on a review. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1716 in reviewboard: There is no option to delete a draft.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1716 by santhosh214: There is no option to delete a draft. http://code.google.com/p/reviewboard/issues/detail?id=1716 *NOTE: Do not post confidential information in this bug report.* After uploading a diff, there is no way to delete it, if i dont want it anymore. What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1716 in reviewboard: There is no option to delete a draft.
Updates: Status: UserError Comment #1 on issue 1716 by chipx86: There is no option to delete a draft. http://code.google.com/p/reviewboard/issues/detail?id=1716 There is. If it's a new update on an existing review request, just click Discard Draft above the review request in the green bar. If it's a new review request, click Discard Review Request. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1717 in reviewboard: post-review w/ perforce fails on multiple aliases for perforce server
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1717 by dadkins: post-review w/ perforce fails on multiple
aliases for perforce server
http://code.google.com/p/reviewboard/issues/detail?id=1717
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
RBTools 0.2
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. post-review --server=http://reviews/sfoffice.qc 46624
2. (w/ perforce)
3.
What is the expected output? What do you see instead?
dadkins-l:p4 dadkins$ post-review --debug
--server=http://reviews.sfoffice.qc 46624
svn info
git rev-parse --git-dir
hg root
p4 info
repository info: Path:
['perforce1.sfo1.qc:1666', '40.1.10.10.in-addr.arpa:1666'], Base path:
None, Supports changesets: True
Generating diff for changenum 46624
p4 describe -s 46624
Processing edit of
//depot/main/platform/kfssort/kosmosfs/src/cc/telemetry/packet.h
Writing //depot/main/platform/kfssort/kosmosfs/src/cc/telemetry/packet.h#3
to /var/folders/q8/q8r34PtkFFWw67FjK1-cxU+++TM/-Tmp-/tmpd5Qit7
p4 print -o /var/folders/q8/q8r34PtkFFWw67FjK1-cxU+++TM/-Tmp-/tmpd5Qit7
-q //depot/main/platform/kfssort/kosmosfs/src/cc/telemetry/packet.h#3
Writing //depot/main/platform/kfssort/kosmosfs/src/cc/telemetry/packet.h#4
to /var/folders/q8/q8r34PtkFFWw67FjK1-cxU+++TM/-Tmp-/tmplOac32
p4 print -o /var/folders/q8/q8r34PtkFFWw67FjK1-cxU+++TM/-Tmp-/tmplOac32
-q //depot/main/platform/kfssort/kosmosfs/src/cc/telemetry/packet.h#4
diff -urNp /var/folders/q8/q8r34PtkFFWw67FjK1-cxU+++TM/-Tmp-/tmpd5Qit7
/var/folders/q8/q8r34PtkFFWw67FjK1-cxU+++TM/-Tmp-/tmplOac32
Looking for 'reviews.sfoffice.qc /' cookie in
/Users/dadkins/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
Repositories on Server: [{u'path': u'perforce1:1666', u'tool':
u'Perforce', u'id': 1, u'name': u'Perforce'}]
Server Aliases:
['perforce1.sfo1.qc:1666', '40.1.10.10.in-addr.arpa:1666']
Attempting to create review request on
['perforce1.sfo1.qc:1666', '40.1.10.10.in-addr.arpa:1666'] for 46624
HTTP POSTing to
http://reviews.sfoffice.qc/api/json/reviewrequests/new/:
{'repository_path':
['perforce1.sfo1.qc:1666', '40.1.10.10.in-addr.arpa:1666'], 'changenum': '46624'}
Traceback (most recent call last):
File /usr/local/bin/post-review, line 8, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2861, in
main
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2497, in
tempt_fate
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 422, in
new_review_request
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 648, in
api_post
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 620, in
http_post
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 666, in
_encode_multipart_formdata
TypeError: can only concatenate list (not str) to list
What operating system are you using? What browser?
Mac OS X
Please provide any additional information below.
Problem is originates when a list is supplied for the repository path:
postreview.py:1396
# If aliases exist for hostname, create a list of alias:port
# strings for repository_path.
if info[1]:
servers = [info[0]] + info[1]
repository_path = [%s:%s % (server, port)
for server in servers]
else:
repository_path = %s:%s % (info[0], port)
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #8 on issue 839 by paul.dubois: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 This is biting us too. I think for now we'll work around by hacking postreview. FWIW, moz 4.0 has css for modifying tab width (and IIUC it looks like recent versions of opera do too). https://bugzilla.mozilla.org/show_bug.cgi?id=517882 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1719 in reviewboard: post-review should support subversion changelists.
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1719 by phil.cornelius: post-review should support subversion changelists. http://code.google.com/p/reviewboard/issues/detail?id=1719 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.0.5.1 What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. Subversion v1.5 and above support changelists for associating files. This is supported in the svn diff command with --changelist option. It should be supported by post-review to allow the user to post a new review with the diffs from only those files identified by a provided changelist name. This would make the post-review tool much more useful in a subversion environment. What operating system are you using? What browser? Mac OS X, Safari Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #10 on issue 839 by paul.dubois: Option to convert tabs in the diff
to (n) spaces
http://code.google.com/p/reviewboard/issues/detail?id=839
Same issue as max9219. We modified PerforceClient in postreview.py to do
tab-expansion before diffing, and got patch failures after/upon upload.
chipx86, when you suggest do[ing] it in postreview was there a
corresponding server-side change you had in mind to get around the patch
failure?
I can confirm that adding
pre {
-moz-tab-size: 4;
-o-tab-size: 4;
}
to diffviewer.css gives reasonable results in opera; moz4 is untested.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1720 in reviewboard: Submitters does not work
Comment #1 on issue 1720 by eduardo.macalinao: Submitters does not work http://code.google.com/p/reviewboard/issues/detail?id=1720 My mistake. Internal server issue. Please close this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1720 in reviewboard: Submitters does not work
Comment #2 on issue 1720 by eduardo.macalinao: Submitters does not work http://code.google.com/p/reviewboard/issues/detail?id=1720 My mistake. This was an internal server issue. Could you please close (preferably delete) this issue? Thanks. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1720 in reviewboard: Submitters does not work
Updates: Status: SetupIssue Comment #3 on issue 1720 by trowbrds: Submitters does not work http://code.google.com/p/reviewboard/issues/detail?id=1720 Sure thing. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1721 in reviewboard: Change font used in the HTML emails
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1721 by pchan...@gmail.com: Change font used in the HTML emails http://code.google.com/p/reviewboard/issues/detail?id=1721 What version are you running? 1.5 RC1 What email client are you using? Gmail The descriptions that are shown in the HTML emails are rendered in a horrible font, it's hard to read and so I end up clicking the link and just reading the text on the review page itself. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1722 in reviewboard: UTF-16 file from Perforce not displayed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1722 by AaronJSherman: UTF-16 file from Perforce not displayed http://code.google.com/p/reviewboard/issues/detail?id=1722 What version are you running? 1.0.9 What's the URL of the page containing the problem? Not available to public What steps will reproduce the problem? 1. In Perforce, p4 add -t utf16 a new file in UTF-16 encoding 2. p4 change and post-review the new file 3. View in ReviewBoard What is the expected output? What do you see instead? New file contents should display Note: In theory, UTF-16 diffs can be re-encoded and displayed as UTF-8 What operating system are you using? What browser? Linux/Firefox Please provide any additional information below. This seems to be related to issue #1326 which was closed as user-error, but in this case, the VCS and does know that the file is UTF-16. I also tried Perforce type xutf16. Same results. Attaching my test file. Attachments: utf-16-test-file4.txt 30 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1723 in reviewboard: Attempt to recover password causes CSRF verification failed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1723 by gtalvola: Attempt to recover password causes CSRF verification failed http://code.google.com/p/reviewboard/issues/detail?id=1723 When I attempt to recover my password, after I enter my email address and press the Recover button, I get an error page stating CSRF verification failed. Request aborted What version are you running? 1.5 RC1 What's the URL of the page containing the problem? /account/recover/ What steps will reproduce the problem? 1. Simply attempt to recover your password. What is the expected output? What do you see instead? I see the error message mentioned above. What operating system are you using? What browser? Debian Lenny, with Google Chrome browser -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1723 in reviewboard: Attempt to recover password causes CSRF verification failed
Updates: Labels: Milestone-Release1.5 Component-Accounts Comment #1 on issue 1723 by chipx86: Attempt to recover password causes CSRF verification failed http://code.google.com/p/reviewboard/issues/detail?id=1723 Will look into it for 1.5. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1724 in reviewboard: error when trying to view diff for create_gse_esl.mac
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1724 by andrewcdyer: error when trying to view diff for create_gse_esl.mac http://code.google.com/p/reviewboard/issues/detail?id=1724 *NOTE: Do not post confidential information in this bug report.* What version are you running? I don't know which version -- please include instructions in this form on how to determine this. What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? I'm trying to view the diff of the file attached here, and instead I'm getting this error: The patch to '//Adams/Dev/ADAMSDEV/source/controls/bld_gui/create_gse_esl.mac' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.50tn3p' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.50tn3p/tmpXpXne6 Hunk #13 FAILED at 611. 1 out of 13 hunks FAILED -- saving rejects to file /tmp/reviewboard.50tn3p/tmpXpXne6-new.rej Traceback (most recent call last): File /usr/local/lib/python2.5/site-packages/ReviewBoard-1.0-py2.5.egg/reviewboard/diffviewer/views.py, line 152, in view_diff interdiffset, highlighting, True) File /usr/local/lib/python2.5/site-packages/ReviewBoard-1.0-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/local/lib/python2.5/site-packages/Djblets-0.5-py2.5.egg/djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.5/site-packages/ReviewBoard-1.0-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/local/lib/python2.5/site-packages/ReviewBoard-1.0-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/local/lib/python2.5/site-packages/ReviewBoard-1.0-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/local/lib/python2.5/site-packages/ReviewBoard-1.0-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to '//Adams/Dev/ADAMSDEV/source/controls/bld_gui/create_gse_esl.mac' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.50tn3p' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.50tn3p/tmpXpXne6 Hunk #13 FAILED at 611. 1 out of 13 hunks FAILED -- saving rejects to file /tmp/reviewboard.50tn3p/tmpXpXne6-new.rej What operating system are you using? What browser? WinXP SP3, win32, Firefox 3.6.6 Please provide any additional information below. Attachments: create_gse_esl.mac 30.4 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1715 in reviewboard: Rb breaks Git patches with new files/deleted files
Comment #1 on issue 1715 by jad.saklawi: Rb breaks Git patches with new files/deleted files http://code.google.com/p/reviewboard/issues/detail?id=1715 I am facing the same issue over here. Can you please point out on how to temporarily address issue/be able to apply review board patches? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1725 in reviewboard: Missing requirement (python-dev) causes gcc errors in linux install
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1725 by wsudan: Missing requirement (python-dev) causes gcc errors in linux install http://code.google.com/p/reviewboard/issues/detail?id=1725 What's the URL of the page containing the problem? http://www.reviewboard.org/docs/manual/1.0/admin/installation/linux/ Describe the problem and any recommendations below. The python-dev package is not listed as a requirement before running the command 'easy_install ReviewBoard'. If it is not installed the command fails with gcc errors. Please provide any additional information below. The dependency djblets is itself dependent on PIL. PIL installation requires python.h which is in python-dev. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 46 in reviewboard: 80-column indicator in diff view
Comment #10 on issue 46 by arunbalaji1985: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Hi, We also follow certain standards like this in our company. And we have been using review board for quite some time now. Can the review board show margin after 80th column, or allow the admin to configure the limit based on the file extension. It could be a thin vertical line, or a slightly different background color. And/or, lines violating the limit could be highlighted. Any idea of this would be implemented? =Arun -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 46 in reviewboard: 80-column indicator in diff view
Comment #11 on issue 46 by chipx86: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Arun, this is one of those situations where an easy solution for one group is going to cause complaints for another. In large deployments, different teams may very well have different coding standards, and because of this we need a solution that is a bit more flexible. The trick is to figure out *where* the 80th column is. We need something that is fast but flexible. Doing it server-side is possible and may be speedy enough, but will become part of the cached content, so depending on how we let the users customize it (whether we choose to make it an admin setting or something flexible the user can change) it may or may not be an option. If doing it client-side, we need a way to quickly find the 80th column on each row, which can be slow. We also need to figure out the UI for showing that column. Background color could work. A thin line is a bit more difficult and looks odd on wrapped content. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1726 in reviewboard: Question regarding usage of ReviewBoard for review of arbitrary files
Updates: Status: NotABug Comment #1 on issue 1726 by trowbrds: Question regarding usage of ReviewBoard for review of arbitrary files http://code.google.com/p/reviewboard/issues/detail?id=1726 Looks like you found the right place to ask this. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1727 in reviewboard: post-review wrongly detects client class if few source control tools installed on server (e.g mercurial and clearcase)
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1727 by xrevolver: post-review wrongly detects client class if few source control tools installed on server (e.g mercurial and clearcase) http://code.google.com/p/reviewboard/issues/detail?id=1727 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.9 What's the URL of the page containing the problem? What steps will reproduce the problem? 1. install on server mercurial and clearcase 2. try to post review request from clearcase view 3. you get error from MercurialClient class What is the expected output? What do you see instead? I expect post-review to use ClearCase client in clearcase view. What operating system are you using? What browser? RHEL5, firefox 3.6 Please provide any additional information below. As far as I understand, Client class, that post-review use to generate review, determined by trying to execute source control tool of each client defined in SCMCLIENTS list. In this list MercurialClient class listed before ClearCaseClient class. Post-review run hg --help succesfully and use it for review generation even in ClearCase view. I can work around it by moving ClearCase to be first in SCMCLIENTS list but then I can not not generate review request in Mercurial view. - run of postreview when clearcase listed AFTER mercurial # /storage/src/rbtools.staging/rbtools/rbtools/postreview.py -d --server=http://rboard -n test.file svn info git rev-parse --git-dir hg showconfig hg root hg svn info repository info: Path: ., Base path: /, Supports changesets: False Traceback (most recent call last): File /storage/src/rbtools.staging/rbtools/rbtools/postreview.py, line 3030, in ? main() File /storage/src/rbtools.staging/rbtools/rbtools/postreview.py, line 2998, in main diff, parent_diff = tool.diff(args) File /storage/src/rbtools.staging/rbtools/rbtools/postreview.py, line 2058, in diff return self._get_outgoing_diff(files) File /storage/src/rbtools.staging/rbtools/rbtools/postreview.py, line 2104, in _get_outgoing_diff remote = self._remote_path[0] IndexError: tuple index out of range # --- run of postreview when clearcase listed BEFORE mercurial # /storage/src/rbtools.staging/rbtools/rbtools/postreview.py -d --repository-url=/vobs --server=http://rboard; -n test.file cleartool pwv -short repository info: Path: /vobs, Base path: /vobs, Supports changesets: False cleartool desc -pre /vobs/test_view/test.file cleartool desc -fmt %Vn /vobs/test_view --- /vobs/test_view/@@/main/I_test_view_somebranch/3/test.file/@@/main/I_test_view_somebranch/me_test_view_somebranch_2/0 2002-02-21 23:30:39.942229878 -0800 +++ /vobs/test_view/test.file 2002-02-21 23:30:50.442260588 -0800 @@ -8,6 +8,10 @@ bla bla bla bla bla bla bla bla bla + +FIXME 4: test for rboard + +FIXME 5: another change for test - -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 46 in reviewboard: 80-column indicator in diff view
Comment #12 on issue 46 by bernard3000: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 If it is decided that this should be a user-level setting, why not cache the content with that setting as part of the cache key? So yes, that means a bigger cache, if there are a lot of variant of that setting and everybody is looking at everything. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1728 in reviewboard: Repository resolution fails if mirror path set to host name alias (cname)
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1728 by balla...@aicas.com: Repository resolution fails if mirror
path set to host name alias (cname)
http://code.google.com/p/reviewboard/issues/detail?id=1728
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
RB 1.5beta2, RBTools 0.2.1alpha0-2010-07-15
What's the URL of the page containing the problem?
post-review output
What steps will reproduce the problem?
1. Create CVS repository on server count
2. Create alias cvs for count
3. Configure repository on ReviewBoard with mirror path cvs
4. Create working directory from repository at cvs
5. Run post-review in working directory
What is the expected output? What do you see instead?
Should post review. Instead does not find repository:
plato:testsuite ballarin$ post-review
--server=http://reviewboard.aicas.burg -d
svn info
repository info: Path: count:/CVSROOT, Base path: None, Supports
changesets: False
cvs diff -uN
Looking for 'reviewboard/' cookie in
/Users/ballarin/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on count:/CVSROOT for None
HTTP POSTing to http://reviewboard/api/json/reviewrequests/new/:
{'repository_path': 'count.aicas.burg:/CVSROOT'}
Got API Error 206 (HTTP code 200): The repository path specified is not
in the list of known repositories
Error data:
{'repository_path': 'count:/CVSROOT', 'stat': 'fail', 'err':
{'msg': 'The repository path specified is not in the list of known
repositories', 'code': 206}, 'deprecated': {'in_version': '1.5'}}
There was an error creating this review request.
The repository path count:/CVSROOT is not in the
list of known repositories on the server.
What operating system are you using? What browser?
Local: Mac OS X 10.5, RB server CentOS 5.5
Please provide any additional information below.
plato:testsuite ballarin$ cat CVS/Root
cvs:/CVSROOT
The problem has an obvious workaround (set mirror path to real host name).
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1729 in reviewboard: Unable to login to Review board with NT user name and NT password.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1729 by singarayya: Unable to login to Review board with NT user name and NT password. http://code.google.com/p/reviewboard/issues/detail?id=1729 Dear, Unable to login to Review board with NT user name and NT password.Could you please check and let me know. Thanks, Singaraiah *NOTE: Do not post confidential information in this bug report.* What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1060 in reviewboard: easy_install P4PythonInstaller *Error*
Comment #22 on issue 1060 by gi.sreenivas: easy_install P4PythonInstaller *Error* http://code.google.com/p/reviewboard/issues/detail?id=1060 all my compile problems solved after running sudo apt-get install python-dev sudo apt-get install g++ -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1730 in reviewboard: post-review with mercurial fails with obscure error if there are no outgoing changesets
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1730 by balla...@aicas.com: post-review with mercurial fails with
obscure error if there are no outgoing changesets
http://code.google.com/p/reviewboard/issues/detail?id=1730
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
RB 1.5beta2, RBTools 0.2.1alpha0
What's the URL of the page containing the problem?
post-review output
What steps will reproduce the problem?
1.Setup RB with a mercurial repository
2. Make a local clone
3.Invoke 'post-review -d' (there are no outgoing changes)
What is the expected output? What do you see instead?
Expected: reasonable error or information message.
Instead I get:
plato:testservice ballarin$ post-review -d
svn info
hg showconfig
hg root
hg svn info
Using candidate path 'default': 'ssh://...//.../testservice'
repository info: Path: ssh://...//.../testservice, Base path: ,
Supports changesets: False
hg branch
hg -q outgoing --template b:{branches}
r:{rev}
default
Failed to execute command:
['hg', '-q', 'outgoing', '--template', 'b:{branches}\nr:{rev}\n\n', 'default']
What operating system are you using? What browser?
RB: CentOS 5.5, Local: Mac OS X
Please provide any additional information below.
Behaves normally if there are outgoing changes.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1731 in reviewboard: Can not create new review when no repository is set
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1731 by tim.pinet: Can not create new review when no repository is set http://code.google.com/p/reviewboard/issues/detail?id=1731 *NOTE: Do not post confidential information in this bug report.* What version are you running? -RB 1.0.9 What's the URL of the page containing the problem? -both web and post-review What steps will reproduce the problem? -Since I am using TFS as a repository and RB does not support it, I wanted to manually create diffs (either context or unified) and create a new review using the diff file. I tried creating a new diff in the web interface but that requires that a repository is set. Preferably I would like to use post-review so I can script the TFS checkout/diff/RB post process but post-review seems to rely on a repository working directory as well. I tried using the post-review --diff-filename=diff.file but that also relies on the repository. Is there any way to use RB without specifying a repository or what is necessary to enable TFS support? What is the expected output? What do you see instead? -expected: review is created -actual (web): try to upload diff file but no repository (field mandatory). No review created. -actual (post-review): not a working folder issue. No review created. What operating system are you using? What browser? -Windows XP (to test the RB system), Python 2.6, Apache 2.2 Please provide any additional information below. -N/A -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1729 in reviewboard: Unable to login to Review board with NT user name and NT password.
Updates: Status: SetupIssue Comment #1 on issue 1729 by chipx86: Unable to login to Review board with NT user name and NT password. http://code.google.com/p/reviewboard/issues/detail?id=1729 Review Board by default requires that you create accounts (one will be created for you on 'rb-site install' and others can be registered from the web UI). If you want to use the existing accounts you have on a network, you must configure Active Directory or LDAP or NIS and link it up with your existing server. It won't just authenticate with your local Windows accounts. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1718 in reviewboard: DoesNotExist: Profile matching query does not exist.
Comment #1 on issue 1718 by Jan.Koprowski: DoesNotExist: Profile matching query does not exist. http://code.google.com/p/reviewboard/issues/detail?id=1718 Reproduce: # You must be logged out # Your user can't be known by Review Board * Set Review Board to LDAP authentication * Go to http://reviewboard/r/NUMBER (i.e. http://reviews.reviewboard.org/r/1 ) * In authentication form enter username and password BUT USER which NEVER log into ReviewBoard before. * Login - You will get error in backtrace -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1732 in reviewboard: upgrading from 1.5b2 to 1.5rc1 - this app uses RandomPool which is deprecated
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1732 by latchkey: upgrading from 1.5b2 to 1.5rc1 - this app uses RandomPool which is deprecated http://code.google.com/p/reviewboard/issues/detail?id=1732 Not sure if this is an error or not, but felt like it should be reported... http://lists.dlitz.net/pipermail/pycrypto/2008q3/00.html # rb-site upgrade /opt/rb-install Rebuilding directory structure Updating database. This may take a while. Upgrading Review Board from 1.5 beta 2 to 1.5 RC1 There are unapplied evolutions for diffviewer. Project signature has changed - an evolution is required No fixtures found. /usr/lib/python2.4/site-packages/pycrypto-2.1.0-py2.4-linux-x86_64.egg/Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken Evolution successful. Upgrade complete. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1732 in reviewboard: upgrading from 1.5b2 to 1.5rc1 - this app uses RandomPool which is deprecated
Updates: Status: ThirdParty Comment #1 on issue 1732 by chipx86: upgrading from 1.5b2 to 1.5rc1 - this app uses RandomPool which is deprecated http://code.google.com/p/reviewboard/issues/detail?id=1732 Thanks for reporting it, but it's a third-party issue. We're never specifically invoking RandomPool, or actually anything in pycrypto directly. This is probably coming from Paramiko. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1733 in reviewboard: Comments to deleted files aren't reported properly
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1733 by jamesdlin: Comments to deleted files aren't reported properly http://code.google.com/p/reviewboard/issues/detail?id=1733 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.9 What's the URL of the page containing the problem? r161356 on the internal VMware reviewboard server. What steps will reproduce the problem? 1. View the diff to a review request that deletes files. 2. Comment on some of the lines to one of the deleted files. What is the expected output? What do you see instead? The review feedback should list the filename above the quoted code, but instead it says none. What operating system are you using? What browser? Windows XP x64 SP2, Firefox 3.6.6. Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1444 in reviewboard: DLL load failed on trying to create SVN repository
Comment #6 on issue 1444 by ruslan.tarasov: DLL load failed on trying to create SVN repository http://code.google.com/p/reviewboard/issues/detail?id=1444 I have found the reason of the problem. Looks like libapr-1.dll library coming with some Apache server versions conflicts with the one coming with pysvn. You just need to install latest versions of both products to make sure these are compatible enough. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1444 in reviewboard: DLL load failed on trying to create SVN repository
Comment #7 on issue 1444 by ruslan.tarasov: DLL load failed on trying to create SVN repository http://code.google.com/p/reviewboard/issues/detail?id=1444 You can still use Review Board in standalone mode if you do not want to find compatible versions of Apache server and pysvn. Use the following command: rb-site manage [path to your site] runserver -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1734 in reviewboard: Document which version(s) of PyLucene are supported
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1734 by email.app: Document which version(s) of PyLucene are supported http://code.google.com/p/reviewboard/issues/detail?id=1734 What's the URL of the page containing the problem? http://www.reviewboard.org/docs/manual/1.0/admin/installation/linux/#installing-pylucene Describe the problem and any recommendations below. The documentation says to use the latest PyLucene for searching. But PyLucene 3.x doesn't work. Please provide any additional information below. Actually I can't get PyLucene 2.9.3 to work either, although it gets a lot farther than 3.0.2 does. What's the maximum version of PyLucene that does work? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1449 in reviewboard: Incompatible with Pylucene 3.0.0
Updates: Labels: -Priority-Medium Priority-Critical Milestone-Release1.5 Component-Search Comment #6 on issue 1449 by chipx86: Incompatible with Pylucene 3.0.0 http://code.google.com/p/reviewboard/issues/detail?id=1449 We need to fix this for 1.5. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1734 in reviewboard: Document which version(s) of PyLucene are supported
Updates: Status: Duplicate Mergedinto: 1449 Comment #1 on issue 1734 by chipx86: Document which version(s) of PyLucene are supported http://code.google.com/p/reviewboard/issues/detail?id=1734 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1449 in reviewboard: Incompatible with Pylucene 3.0.0
Comment #7 on issue 1449 by chipx86: Incompatible with Pylucene 3.0.0 http://code.google.com/p/reviewboard/issues/detail?id=1449 Issue 1734 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1735 in reviewboard: Perforce clients not adding the charset
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1735 by carodolan: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 *NOTE: Do not post confidential information in this bug report.* What version are you running? Applies both to 1.0 and 1.5RC1 What's the URL of the page containing the problem? It's an issue on the reviewboard/scmtools/perforce.py file What steps will reproduce the problem? 1. Add a perforce repository whose server is unicode 2. try to upload a review 3. The log will say: Unicode servers permits only unicode enabled clients What is the expected output? What do you see instead? You should be able to post reviews, you get an error message. What operating system are you using? What browser? Doesn't apply. Please provide any additional information below. One could solve it by adding the environment variable P4CHARSET, but if you want to use different repositories, some unicode, some not, that won't work. I have fixed it temporarily by adding on perforce.py: import P4 self.p4 = P4.P4() self.p4.port = str(repository.mirror_path or repository.path) self.p4.user = str(repository.username) self.p4.password = str(repository.password) if (str(repository.encoding)): self.p4.charset = str(repository.encoding) self.p4.exception_level = 1 And cmdline = ['p4', '-p', self.p4.port] if self.p4.user: cmdline.extend(['-u', self.p4.user]) if self.p4.password: cmdline.extend(['-P', self.p4.password]) if self.p4.charset: cmdline.extend(['-C', self.p4.charset]) cmdline.extend(['print', '-q', file]) But that's just a temporary fix, since I don't know the real meaning of the encoding attribute. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1736 in reviewboard: Perforce clients not adding the charset
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1736 by carodolan: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1736 *NOTE: Do not post confidential information in this bug report.* What version are you running? Applies both to 1.0 and 1.5RC1 What's the URL of the page containing the problem? It's an issue on the reviewboard/scmtools/perforce.py file What steps will reproduce the problem? 1. Add a perforce repository whose server is unicode 2. try to upload a review 3. The log will say: Unicode servers permits only unicode enabled clients What is the expected output? What do you see instead? You should be able to post reviews, you get an error message. What operating system are you using? What browser? Doesn't apply. Please provide any additional information below. One could solve it by adding the environment variable P4CHARSET, but if you want to use different repositories, some unicode, some not, that won't work. I have fixed it temporarily by adding on perforce.py: import P4 self.p4 = P4.P4() self.p4.port = str(repository.mirror_path or repository.path) self.p4.user = str(repository.username) self.p4.password = str(repository.password) if (str(repository.encoding)): self.p4.charset = str(repository.encoding) self.p4.exception_level = 1 And cmdline = ['p4', '-p', self.p4.port] if self.p4.user: cmdline.extend(['-u', self.p4.user]) if self.p4.password: cmdline.extend(['-P', self.p4.password]) if self.p4.charset: cmdline.extend(['-C', self.p4.charset]) cmdline.extend(['print', '-q', file]) But that's just a temporary fix, since I don't know the real meaning of the encoding attribute. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1737 in reviewboard: Exception is thrown when adding a private GitHub repository
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1737 by kevin.go...@googlemail.com: Exception is thrown when
adding a private GitHub repository
http://code.google.com/p/reviewboard/issues/detail?id=1737
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.5RC1
What's the URL of the page containing the problem?
http://reviews.kevmaster.com/admin/db/scmtools/repository/add/
What steps will reproduce the problem?
1. Add new repository: Hosting service GitHub (private)
2. Fill out all data
3. Hit Save
What is the expected output? What do you see instead?
Expected: repository gets added.
Actual: 500 page.
What operating system are you using? What browser?
OS X 10.6.4
Chrome 5.0, Firefox 3.6.8 (error happens in both)
Please provide any additional information below.
Error log dump is below:
ERROR:root:Exception thrown for user admin at
http://reviews.kevmaster.com/admin/db/scmtools/repository/add/
'tool'
Traceback (most recent call last):
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/core/handlers/base.py,
line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/sites.py,
line 512, in root
return self.model_page(request, *url.split('/', 2))
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/views/decorators/cache.py,
line 69, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/sites.py,
line 531, in model_page
return admin_obj(request, rest_of_url)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/options.py,
line 1190, in __call__
return self.add_view(request)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py,
line 21, in _wrapper
return decorator(bound_func)(*args, **kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py,
line 76, in _wrapped_view
response = view_func(request, *args, **kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py,
line 17, in bound_func
return func(self, *args2, **kwargs2)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/db/transaction.py,
line 299, in _commit_on_success
res = func(*args, **kw)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/options.py,
line 777, in add_view
if form.is_valid():
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 577, in is_valid
return (super(RepositoryForm, self).is_valid() and
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 121, in is_valid
return self.is_bound and not bool(self.errors)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 112, in _get_errors
self.full_clean()
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 499, in full_clean
return super(RepositoryForm, self).full_clean()
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 268, in full_clean
self._clean_form()
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 296, in _clean_form
self.cleaned_data = self.clean()
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 515, in clean
self._clean_hosting_info()
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 447, in _clean_hosting_info
tool_name = self.cleaned_data['tool'].name
KeyError: 'tool'
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1737 in reviewboard: Exception is thrown when adding a private GitHub repository
Updates: Labels: -Priority-Medium Priority-Critical Milestone-Release1.5 Component-SCMTools Comment #1 on issue 1737 by chipx86: Exception is thrown when adding a private GitHub repository http://code.google.com/p/reviewboard/issues/detail?id=1737 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1736 in reviewboard: Perforce clients not adding the charset
Updates: Status: Duplicate Mergedinto: 1735 Comment #1 on issue 1736 by trowbrds: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1736 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Comment #1 on issue 1735 by trowbrds: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 Issue 1736 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1737 in reviewboard: Exception is thrown when adding a private GitHub repository
Comment #2 on issue 1737 by kevin.go...@googlemail.com: Exception is thrown
when adding a private GitHub repository
http://code.google.com/p/reviewboard/issues/detail?id=1737
The admin account just received this email containing the post-data for the
failing request. Hope this helps.
WSGIRequest
GET:QueryDict: {},
POST:QueryDict: {u'username': [u'host...@partyearth.com'], u'name':
[u'Partyearth'], u'bug_tracker_type': [u'none'], u'encoding': [u''],
u'tool': [u'2'], u'api_token': [u'xxx'], u'bug_tracker_project_name':
[u'Partyearth'], u'hosting_project_name': [u'Partyearth'],
u'bug_tracker_base_url': [u''], u'visible': [u'on'], u'hosting_type':
[u'github-private'], u'bug_tracker_owner': [u''], u'_save': [u'Save'],
u'raw_file_url': [u''], u'bug_tracker': [u''], u'path': [u''],
u'csrfmiddlewaretoken': [u'46fd13a07a342baa7c4ba8397e2e65be'], u'password':
[u'pe4life!'], u'mirror_path': [u''], u'hosting_owner': [u'partyearth']},
COOKIES:{'csrftoken': '46fd13a07a342baa7c4ba8397e2e65be',
'rbsessionid': 'ebd5c17c7efcd94f605785518577a94d'},
META:{'CONTENT_LENGTH': '2448',
'CONTENT_TYPE': 'multipart/form-data;
boundary=---168072824752491622650073',
'CSRF_COOKIE': '46fd13a07a342baa7c4ba8397e2e65be',
'DOCUMENT_ROOT': '/home3/kevmaste/public_html/reviews',
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT':
'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate',
'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'rbsessionid=ebd5c17c7efcd94f605785518577a94d;
csrftoken=46fd13a07a342baa7c4ba8397e2e65be',
'HTTP_HOST': 'reviews.kevmaster.com',
'HTTP_KEEP_ALIVE': '115',
'HTTP_REFERER':
'http://reviews.kevmaster.com/admin/db/scmtools/repository/add/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8',
'PATH': '/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/bin:/usr/local/sbin',
'PATH_INFO': u'/admin/db/scmtools/repository/add/',
'PATH_TRANSLATED':
'redirect:/reviewboard.fcgi/admin/db/scmtools/repository/add//db/scmtools/repository/add/',
'QUERY_STRING': '',
'REDIRECT_STATUS': '200',
'REDIRECT_UNIQUE_ID': 'TE3hZ0rc12UAADR2IQ8AAACN',
'REDIRECT_URL': '/admin/db/scmtools/repository/add/',
'REDIRECT_file_gzip': '/ramdisk/cpud/status',
'REMOTE_ADDR': '99.107.206.17',
'REMOTE_PORT': '51075',
'REQUEST_METHOD': 'POST',
'REQUEST_URI': '/admin/db/scmtools/repository/add/',
'SCRIPT_FILENAME': '/home3/kevmaste/public_html/reviews/reviewboard.fcgi',
'SCRIPT_NAME': u'',
'SERVER_ADDR': '74.220.202.29',
'SERVER_ADMIN': 'webmas...@reviews.kevmaster.com',
'SERVER_NAME': 'reviews.kevmaster.com',
'SERVER_PORT': '80',
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SIGNATURE': 'addressApache/2.2.15 (CentOS) mod_ssl/2.2.15 0.9.8l
DAV/2 mod_auth_passthrough/2.1 FrontPage/5.0.2.2635 Server at
reviews.kevmaster.com Port 80/address\n',
'SERVER_SOFTWARE': 'Apache/2.2.15 (CentOS) mod_ssl/2.2.15 0.9.8l DAV/2
mod_auth_passthrough/2.1 FrontPage/5.0.2.2635',
'UNIQUE_ID': 'TE3hZ0rc12UAADR2IQ8AAACN',
'file_gzip': '/ramdisk/cpud/status',
'wsgi.errors': flup.server.fcgi_base.OutputStream object at 0x19354d0,
'wsgi.input': flup.server.fcgi_base.InputStream object at 0x1935d50,
- Hide quoted text -
'wsgi.multiprocess': False,
'wsgi.multithread': True,
'wsgi.run_once': False,
'wsgi.url_scheme': 'http',
'wsgi.version': (1, 0)}
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1738 in reviewboard: post-review --revision-range fails when files have been removed.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1738 by tagster: post-review --revision-range fails when files have been removed. http://code.google.com/p/reviewboard/issues/detail?id=1738 *NOTE: Do not post confidential information in this bug report.* What version are you running? RBTools 0.2 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. remove a file in a revision (we'll call revision 3). 2. post-review --revision-range=0:4 What is the expected output? What do you see instead? Review request #number created. http://location/number What operating system are you using? What browser? Linux, Firefox 3 Please provide any additional information below. post-review --revision-range attempts to call svn info on the removed node, this causes failure: Failed to execute command: ['svn', 'info', 'path'] ['path: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n'] -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1739 in reviewboard: Version diff with files added + removed from diff show the wrong files in the diff
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1739 by MichaelvdB: Version diff with files added + removed from diff show the wrong files in the diff http://code.google.com/p/reviewboard/issues/detail?id=1739 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.9 What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/157999/diff/3-4 This is correct: https://reviewboard.eng.vmware.com/r/157999/diff/4 What steps will reproduce the problem? 1. Upload diff of change 2. Remove a file from the diff: CloneSessionRequestEvent.## 3. Add a file to the diff: CSharpNavigationRequestEvent.## 4. Upload the new diff: Diff was created using: p5 diff -du -c CL# F:\work\diff\change_CL#.diff What is the expected output? CloneSessionRequestEvent - This file was removed, or the diff of the removal, or not listed CSharpNavigationRequestEvent [new content] What do you see instead? CloneSessionRequestEvent - [new content] CSharpNavigationRequestEvent - not listed What operating system are you using? What browser? Windows 2008 R2 + Windows 2003 IE8 + Chrome Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 422 in reviewboard: Discard Review and Set Submitted should send email
Comment #5 on issue 422 by akshah123: Discard Review and Set Submitted should send email http://code.google.com/p/reviewboard/issues/detail?id=422 It would be also great if it logged this action (submitted or discarded) as a history via comment. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on Summer_of_Code_Ideas in reviewboard
Comment by brijendra.s.singh: It helps me to familiar with Python and, to a some extent, Django. Not sure how long this will go because of too many dependencies, if one of them is broken..not sure how this tool will survive good luck For more information: http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1740 in reviewboard: ReviewBoard sends emails to you about your own updates.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1740 by earthling: ReviewBoard sends emails to you about your own updates. http://code.google.com/p/reviewboard/issues/detail?id=1740 What version are you running? 1.0.9 What steps will reproduce the problem? 1. Edit a review 2. Publish the review 3. The system sends you an email letting you know that you edited a review. What is the expected output? What do you see instead? Don't spam about a user's own edits. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1740 in reviewboard: ReviewBoard sends emails to you about your own updates.
Updates: Status: Duplicate Mergedinto: 1214 Comment #1 on issue 1740 by trowbrds: ReviewBoard sends emails to you about your own updates. http://code.google.com/p/reviewboard/issues/detail?id=1740 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1214 in reviewboard: Make the email script smarter so it does not email the user that issued the action for the email.
Comment #2 on issue 1214 by trowbrds: Make the email script smarter so it does not email the user that issued the action for the email. http://code.google.com/p/reviewboard/issues/detail?id=1214 Issue 1740 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #2 on issue 1113 by trowbrds: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Issue 1738 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1738 in reviewboard: post-review --revision-range fails when files have been removed.
Updates: Status: Duplicate Mergedinto: 1113 Comment #1 on issue 1738 by trowbrds: post-review --revision-range fails when files have been removed. http://code.google.com/p/reviewboard/issues/detail?id=1738 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1739 in reviewboard: Version diff with files added + removed from diff show the wrong files in the diff
Updates: Status: Duplicate Mergedinto: 1486 Comment #1 on issue 1739 by trowbrds: Version diff with files added + removed from diff show the wrong files in the diff http://code.google.com/p/reviewboard/issues/detail?id=1739 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1486 in reviewboard: Diff viewer displays incorrectly diffs for files which were removed in later revision of the change
Comment #2 on issue 1486 by trowbrds: Diff viewer displays incorrectly diffs for files which were removed in later revision of the change http://code.google.com/p/reviewboard/issues/detail?id=1486 Issue 1739 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1741 in reviewboard: Stray control characters with perforce diff
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1741 by December1981: Stray control characters with perforce diff
http://code.google.com/p/reviewboard/issues/detail?id=1741
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.0.9
What steps will reproduce the problem?
1. Add, say, a carriage return character \r directly to a file under
perforce
2. Post a review with this edited file in the perforce changelist
3. patch will have trouble understanding the diff, as it will have \n\n in
the middle of the diff
Please provide any additional information below.
I got round this by adding the two lines below (after line 104 in
diffutils.py)
diff = convert_line_endings(diff)
--# filter any strings of \n characters = 2 in the middle of the diff
--diff = re.sub(r'\n{2,}(.)', r'\n\1', diff)
This was a temporary fix for me - it doesn't capture the additions to the
file in this pathological case, but it stops the exception generated when
patch returns a failure (and if there were other genuine differences in the
file, these would appear normally in the diff view)
I also noticed that diffutils.py has the following lines of code at line 79
temp = data.replace('\r\r\n', '\n')
temp = data.replace('\r\n', '\n')
temp = temp.replace('\r', '\n')
Shouldn't the second line be ?
temp = temp.replace('\r\n', '\n')
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1742 in reviewboard: Awkward workflow when reviewing code.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1742 by earthling: Awkward workflow when reviewing code. http://code.google.com/p/reviewboard/issues/detail?id=1742 What version are you running? 1.0.9 What's the URL of the page containing the problem? It starts by clicking the link in the review request. What steps will reproduce the problem? 1. Click the link in the review request. 2. It's completely unapparent what you're supposed to do. What is the expected output? What do you see instead? I usually click the review button. But then you're taken to an overlay that has a checkbox ship it and an unlabeled text area. Clicking the back button doesn't work, so you have to go back to your email and click the request link again or navigate there some other way. Clicking the view diff button is actually what you want. When you do that, the diff shows up, but then there's no obvious way to approve the diff. A big approve or diff button that looks like a submit button would really help. Instead, you have to click on a little tab in the upper right that says review. What operating system are you using? What browser? Please provide any additional information below. One possible quick and dirty solution might be to go straight to the diff from the email link. Then a prominent way to approve the diff would make the whole process more obvious. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1743 in reviewboard: Weired Error occurred when the file has windows endline charactor.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1743 by Cynthia.J.Yu: Weired Error occurred when the file has windows endline charactor. http://code.google.com/p/reviewboard/issues/detail?id=1743 I'm using review board 1.0.6, which is installed in Unbuntu. And I'm using perforce as the source manangement system. At the same time, I'm using post-review tool to post review request from a Window client on which installed Perforce client. I have a file created from Windows and it contains Windows endline charactor. In Vim editer tool, this Win endline charator is show as ^M. When I do modification for this file and post review request using post-review, everything looks OK. But when I click View Diff button from review board web GUI, weired error occured, like this: = Diff currently unavailable. Error: The patch to '//depot/playpen/b.txt' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.76Xlcj' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.76Xlcj/tmpOEenSn patch: malformed patch at line 8: fgg Details Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-py2.6.egg/reviewboard/diffviewer/views.py, line 214, in view_diff_fragment file = get_requested_diff_file() File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-py2.6.egg/reviewboard/diffviewer/views.py, line 190, in get_requested_diff_file get_chunks) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/local/lib/python2.6/dist-packages/Djblets-0.5.9-py2.6.egg/djblets/util/misc.py, line 166, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to '//depot/playpen/b.txt' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.76Xlcj' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.76Xlcj/tmpOEenSn patch: malformed patch at line 8: fgg == I attached the file that I'm using, please take a look. Thanks Cynthia Yu Attachments: b.txt 19 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1744 in reviewboard: Custom syntax highlighting format
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1744 by stuart.gunter: Custom syntax highlighting format http://code.google.com/p/reviewboard/issues/detail?id=1744 What version are you running? 1.0.9 What's the URL of the page this enhancement relates to, if any? Code review diff viewer Describe the enhancement and the motivation for it. Would it be possible to allow custom syntax highlighting in the code viewer? I've integrated Review Board with another dev system that uses a non-standard language, and I'd like to make sure the syntax is highlighted as per the dev environment. This could be similar to how Notepad++ allows you to customise the style configurator. This would allow Review Board to work for any language in any organisation. What operating system are you using? What browser? Windows 7 with Chrome 5, Firefox 3.6 IE 8. Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1745 in reviewboard: plain CentOS 5.4 requires yum install python-devel before easy_install ReviewBoard
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1745 by itaifren...@live.com: plain CentOS 5.4 requires yum install python-devel before easy_install ReviewBoard http://code.google.com/p/reviewboard/issues/detail?id=1745 Hello, I'm not a linux expeert, but during the installation of reviewboard I got the following error when running easy_install ReviewBoard: Python.h: No such file or directory It seams that yum install python-devel solves this problem , and thus could be a prerequisite for the installation. Regards, Itai -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1746 in reviewboard: plain CentOS 5.4 requires yum install mysql-devel before easy_install MYSQL-python
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1746 by itaifren...@live.com: plain CentOS 5.4 requires yum install mysql-devel before easy_install MYSQL-python http://code.google.com/p/reviewboard/issues/detail?id=1746 Hello, I am not a linux expert but I found the following prerequisite installation problem: east_install MYSQL-python failed with the following error: _mysql.c:76: error: expected specifier-qualifier-list before MYSQL running yum install mysql-devel solved the problem. Please update the documentation. Regards, Itai -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1744 in reviewboard: Custom syntax highlighting format
Updates: Status: ThirdParty Comment #1 on issue 1744 by trowbrds: Custom syntax highlighting format http://code.google.com/p/reviewboard/issues/detail?id=1744 Implementing a custom formatter in pygments will let you do this. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1746 in reviewboard: plain CentOS 5.4 requires yum install mysql-devel before easy_install MYSQL-python
Updates: Labels: Component-Docs Comment #1 on issue 1746 by trowbrds: plain CentOS 5.4 requires yum install mysql-devel before easy_install MYSQL-python http://code.google.com/p/reviewboard/issues/detail?id=1746 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1744 in reviewboard: Custom syntax highlighting format
Comment #2 on issue 1744 by stuart.gunter: Custom syntax highlighting format http://code.google.com/p/reviewboard/issues/detail?id=1744 Unfortunately I'm not familiar with Pygments, so will have to skip over this one. Pity there isn't a user-configurable formatting option that would make it easier for the site admin to customise syntax highlighting. Admittedly this probably wouldn't be a requirement for the majority of users. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1744 in reviewboard: Custom syntax highlighting format
Comment #3 on issue 1744 by chipx86: Custom syntax highlighting format http://code.google.com/p/reviewboard/issues/detail?id=1744 Defining a syntax highlighting grammar is a complicated task. You need a pretty thorough language to describe what things are highlighted when and where. That's not something that can really be done in an easy, user-configurable way. That's where Pygments comes in, since it provides a whole API for doing such a thing, but it does mean getting into the code and writing a lexer. It'd be nice if we could make it happen easily, but it's just not really an option. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1747 in reviewboard: post-review --revison-range=XXXXX crashes
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1747 by codemonkey.uk: post-review --revison-range=X crashes
http://code.google.com/p/reviewboard/issues/detail?id=1747
What version are you running?
RBTools 0.2
What's the URL of the page containing the problem?
N/A
What steps will reproduce the problem?
1. post-review --revison-range=X
What is the expected output? What do you see instead?
I expect this to create a post-checkin review with diff for change list
specified.
Instead it crashes with the following stack trace:
Traceback (most recent call last):
File C:\Python26\Scripts\post-review-script.py, line 9, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
File C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools\postreview.p
y, line 2861, in main
submit_as=options.submit_as)
File C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools\postreview.p
y, line 2554, in tempt_fate
parent_diff_content)
File C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools\postreview.p
y, line 503, in upload_diff
debug(Uploading diff, size: %d % len(diff_content))
TypeError: object of type 'NoneType' has no len()
What operating system are you using? What browser?
Windows XP SP3.
P4 Server 2005.1/89985.
Safari
Please provide any additional information below.
I am trying to set up to evaluate Review Board for use with a post check-in
workflow using P4 source control on a large project.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #3 on issue 1113 by bobafeth2000: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 I added a workaround for that issue on my local installation. I hope it can help anybody having the same problem until an official fix come out. Attached are two files: - postreview.org is the original one upon which the fix is based (RBTools-0.2) - postreview.py is the modified one that handles the case of deleted files. Attachments: postreview.py 104 KB postreview.org 104 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1748 in reviewboard: error posting to review board
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1748 by lbelcz13: error posting to review board http://code.google.com/p/reviewboard/issues/detail?id=1748 I get the following error when posting to review board: Error creating review request: User does not exist (code 208) posting review request... Traceback (most recent call last): File c:\python25\lib\site-packages\cx_Freeze\initscripts\Console.py, line 27, in module File rb.py, line 1194, in module File rb.py, line 1179, in main TypeError: 'NoneType' object is unsubscriptable -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1748 in reviewboard: error posting to review board
Updates: Status: NeedInfo Comment #1 on issue 1748 by chipx86: error posting to review board http://code.google.com/p/reviewboard/issues/detail?id=1748 Please provide information on what you're trying to do, exactly, step-by-step. Also the version numbers of everything. There isn't enough information for us to figure out anything. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1449 in reviewboard: Incompatible with Pylucene 3.0.0
Updates: Status: Fixed Comment #8 on issue 1449 by trowbrds: Incompatible with Pylucene 3.0.0 http://code.google.com/p/reviewboard/issues/detail?id=1449 Fixed in 7adf5b3. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1718 in reviewboard: DoesNotExist: Profile matching query does not exist.
Comment #2 on issue 1718 by hadru...@gmail.com: DoesNotExist: Profile matching query does not exist. http://code.google.com/p/reviewboard/issues/detail?id=1718 We had the same error, but when user was trying to create new codereview request, upon clicking upload for diff it was presented with 500 error page and logs were saying DoesNotExist. It occured, that upon first login (we also use LDAP) user was migrated from LDAP (created user in RB), but his profile in RB was not created. It only happened after he clicked my account link and saved preferences. After that everything works as expected. Shouldn't the profile be created automatically upon first login regardless of saving preferences ? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
