Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96508
---

Ship it!


Ship It!

- Guangya Liu


On Aug. 25, 2015, 10:53 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 25, 2015, 10:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> Also copied to v1 API.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35984/#review96503
---

Ship it!


Awesome tests! LGTM!


src/tests/reservation_endpoints_tests.cpp (line 19)


This is C++ header. Please put it after  and 



src/tests/reservation_endpoints_tests.cpp (lines 103 - 132)


This piece of code is duplicated in many tests here. Could you please pull 
them into a helper method in the test fixture. For instance

```
createBasicAuthHeader();
createResourcesParameter(...);
```



src/tests/reservation_endpoints_tests.cpp (line 109)


Are we allowed to use cxx11 raw string literals now? This is definitely 
better!



src/tests/reservation_endpoints_tests.cpp (line 501)


Please move this comments right above 'Resources taskResources'.

Also, could you please add a comment about why you want to launch a task 
here.


- Jie Yu


On Aug. 5, 2015, 9:55 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35984/
> ---
> 
> (Updated Aug. 5, 2015, 9:55 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris 
> Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2600
> https://issues.apache.org/jira/browse/MESOS-2600
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/tests/reservation_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35984/diff/
> 
> 
> Testing
> ---
> 
> (1) Added `src/tests/reservation_endpoints_tests.cpp`
> (2) `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96506
---

Ship it!


Ship It!

- Guangya Liu


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Guangya Liu]

> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > 
> >
> > It is better consider the alpha order of those files, we can add quota 
> > related files under module related files.
> 
> Alexander Rukletsov wrote:
> Could you please elaborate? I'm not sure I follow.
> 
> Guangya Liu wrote:
> I mean the file order in Makefile.am should follow alpha order as other 
> part in this file.
> 
> My propose is that you only need to re-order the file list here as 
> following:
> 
> module/module.pb.cc \
>   ../include/mesos/module/module.pb.h   \
> master/quota.pb.cc  \
>   ../include/mesos/master/quota.pb.h\
> 
> Just adjust the order should works.
> 
> Alexander Rukletsov wrote:
> I see. We also include folder into lexicographic sorting, therefore 
> `module > master` and hence all `master/**` go before `module/**`. Does it 
> make sense?
> 
> Guangya Liu wrote:
> Exactly, this can make the code more readable. I found that both Mesos 
> and OpenStack projects are following such style ;-)
> 
> Alexander Rukletsov wrote:
> Not sure I follow. Your suggestion above says to put `module/**` before 
> `master/**`. Could you please elaborate what variant is more readable?

My bad,you are right Alex, the current order works.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review96504
---

Ship it!


Ship It!

- Guangya Liu


On Aug. 26, 2015, 2:13 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> ---
> 
> (Updated Aug. 26, 2015, 2:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
> 
> Diff: https://reviews.apache.org/r/37284/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37779: Added labels documentation.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96502
---

Ship it!


Ship It!

- Jie Yu


On Aug. 26, 2015, 12:42 a.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> ---
> 
> (Updated Aug. 26, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added labels documentation to the framework development guide.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> db0181c0b82fded1860ef636747e70d80e3884f2 
> 
> Diff: https://reviews.apache.org/r/37779/diff/
> 
> 
> Testing
> ---
> 
> Rendered in Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/#review96501
---


Patch looks great!

Reviews applied: [37787]

All tests passed.

- Mesos ReviewBot


On Aug. 26, 2015, 5:43 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37787/
> ---
> 
> (Updated Aug. 26, 2015, 5:43 a.m.)
> 
> 
> Review request for Benjamin Hindman, Timothy Chen and Vinod Kone.
> 
> 
> Bugs: MESOS-3313
> https://issues.apache.org/jira/browse/MESOS-3313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, 
> ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8.
> 
> 
> Diffs
> -
> 
>   support/docker/centos-6.6-gcc-4.8/Dockerfile PRE-CREATION 
>   support/docker/centos-6.6-gcc-4.8/wandisco-svn.repo PRE-CREATION 
>   support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
>   support/jenkins_build_docker.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37787/diff/
> 
> 
> Testing
> ---
> 
> `jenkins-build-docker.sh` is a reworked version of the original 
> `jenkins-build.sh` that is ran by Jenkins buildbot for building and testing 
> Mesos distributions. 
> 
> Features:
>  * Runs libevent, SSL and ROOT tests.
>  * Easily add OS/compiler Docker images for testing Mesos.
>  * Exclude tests on per-image basis.
>  * Easily reproduce the test image locally.
>  * Three new test images (ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, 
> centos-6.6-gcc-4.8).
> 
> How to run
> 
> The following environment variables have to be set for the script to run:
>  * OS - OS name/version. Currently images are available for ubuntu-14.04, 
> ubuntu-12.04, centos-7.1, centos-6.6.
>  * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
>  * COMPILER - Compiler name/version. Currently available images include 
> gcc-4.8 (default value) on all platforms, clang-3.6 on ubuntu-14.04.
> 
> Examples:
> `OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' 
> COMPILER=clang-3.6 ./jenkins_build_docker.sh`
> `OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' 
> ./jenkins_build_docker.sh`
> 
> NOTE: Mesos Python module has a known issue on centos-6.6 ( 
> https://issues.apache.org/jira/browse/MESOS-3314 ), so **for now centos-6.6 
> should not be enabled in Jenkins**.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37234/#review96500
---

Ship it!


Ship It!

- Guangya Liu


On Aug. 26, 2015, 2:13 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37234/
> ---
> 
> (Updated Aug. 26, 2015, 2:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
> 
> Diff: https://reviews.apache.org/r/37234/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---

(Updated Aug. 25, 2015, 10:17 p.m.)


Review request for Joris Van Remoortere and Joseph Wu.


Changes
---

Addressed some comments.


Bugs: MESOS-2964
https://issues.apache.org/jira/browse/MESOS-2964


Repository: mesos


Description
---

JIRA: https://issues.apache.org/jira/browse/MESOS-2964


Diffs (updated)
-

  3rdparty/libprocess/include/process/io.hpp 
975923f40f82357f31b89428f24d01df6a8ac9fc 
  3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
  3rdparty/libprocess/src/tests/io_tests.cpp 
c642bab9e2845668767ad237985cb9ce1109 

Diff: https://reviews.apache.org/r/36404/diff/


Testing
---

- Added a test case for process::io::peek
- make check


Thanks,

Artem Harutyunyan

Re: Review Request 37289: Corrected the comments for DRFSorter::dirty.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37289/#review96499
---

Ship it!


Ship It!

- haosdent huang


On Aug. 14, 2015, 12:06 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37289/
> ---
> 
> (Updated Aug. 14, 2015, 12:06 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3245
> https://issues.apache.org/jira/browse/MESOS-3245
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected the comments for DRFSorter::dirty.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> f66ade06c6a5b4bf816839477cec2d18036c7b1a 
> 
> Diff: https://reviews.apache.org/r/37289/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

> On Aug. 25, 2015, 9:29 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/io.cpp, lines 274-286
> > 
> >
> > This is the "old style", in the "new style" we just dupliate the file 
> > descriptor so that if someone closes the file descriptor passed to us we 
> > don't either read from a closed file descriptor or WORSE read from a newly 
> > opened file descriptor that we shouldn't be reading from. See 'io::read(int 
> > fd)' for an example. Note that the other ones need to get changed as well 
> > but I've done that for the Mesos on Windows work (in the my 
> > github/benh/mesos mesos-on-windows branch, which was necessary to do there 
> > because we can't support os::isNonblock on Windows).

I initially had the dup() here (it's in this same review) but then Joris 
pointed out that ::recv() with MSG_PEEK set can not surpass single message 
boundaries. I removed the call to dup() because unlike the case with io::read() 
we are not looping here and are performing just a single peek() request. I will 
look into this further and will update accordingly.


> On Aug. 25, 2015, 9:29 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/io.cpp, line 577
> > 
> >
> > The declaration uses the variable named 'limit' but here it's 'size' 
> > which sort of implies a different semantics? Either way, we should use the 
> > same name please.

That was an oversight. Fixed.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/#review96342
---


On Aug. 5, 2015, 8:26 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36404/
> ---
> 
> (Updated Aug. 5, 2015, 8:26 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-2964
> https://issues.apache.org/jira/browse/MESOS-2964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-2964
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/io.hpp 
> 975923f40f82357f31b89428f24d01df6a8ac9fc 
>   3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> c642bab9e2845668767ad237985cb9ce1109 
> 
> Diff: https://reviews.apache.org/r/36404/diff/
> 
> 
> Testing
> ---
> 
> - Added a test case for process::io::peek
> - make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37445: Fix typos in style guide.

[Neil Conway]

Hi,

Can someone commit this patch for me?

Thanks,
Neil


On Fri, Aug 14, 2015 at 5:26 AM, Guangya Liu  wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37445/
>
> Ship it!
>
> Ship It!
>
>
> - Guangya Liu
>
>
> On 八月 13th, 2015, 9:58 p.m. UTC, Neil Conway wrote:
>
> Review request for mesos.
> By Neil Conway.
>
> Updated 八月 13, 2015, 9:58 p.m.
>
> Repository: mesos
>
> Description
>
> Fix typos in style guide.
>
> Diffs
>
> docs/mesos-c++-style-guide.md (9c1a00c32043fa10038e38bd7cbc561aafcd6ea0)
>
> View Diff

Re: Review Request 37289: Corrected the comments for DRFSorter::dirty.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37289/#review96498
---

Ship it!


Ship It!

- Alexander Rukletsov


On Aug. 14, 2015, 12:06 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37289/
> ---
> 
> (Updated Aug. 14, 2015, 12:06 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3245
> https://issues.apache.org/jira/browse/MESOS-3245
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected the comments for DRFSorter::dirty.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> f66ade06c6a5b4bf816839477cec2d18036c7b1a 
> 
> Diff: https://reviews.apache.org/r/37289/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Alexander Rukletsov]

> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > 
> >
> > It is better consider the alpha order of those files, we can add quota 
> > related files under module related files.
> 
> Alexander Rukletsov wrote:
> Could you please elaborate? I'm not sure I follow.
> 
> Guangya Liu wrote:
> I mean the file order in Makefile.am should follow alpha order as other 
> part in this file.
> 
> My propose is that you only need to re-order the file list here as 
> following:
> 
> module/module.pb.cc \
>   ../include/mesos/module/module.pb.h   \
> master/quota.pb.cc  \
>   ../include/mesos/master/quota.pb.h\
> 
> Just adjust the order should works.
> 
> Alexander Rukletsov wrote:
> I see. We also include folder into lexicographic sorting, therefore 
> `module > master` and hence all `master/**` go before `module/**`. Does it 
> make sense?
> 
> Guangya Liu wrote:
> Exactly, this can make the code more readable. I found that both Mesos 
> and OpenStack projects are following such style ;-)

Not sure I follow. Your suggestion above says to put `module/**` before 
`master/**`. Could you please elaborate what variant is more readable?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/
---

Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.


Bugs: MESOS-3313
https://issues.apache.org/jira/browse/MESOS-3313


Repository: mesos


Description
---

Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, 
ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8.


Diffs
-

  support/docker/centos-6.6-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/centos-6.6-gcc-4.8/wandisco-svn.repo PRE-CREATION 
  support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/jenkins_build_docker.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/37787/diff/


Testing
---

`jenkins-build-docker.sh` is a reworked version of the original 
`jenkins-build.sh` that is ran by Jenkins buildbot for building and testing 
Mesos distributions. 

Features:
 * Easily add OS/compiler Docker images for testing Mesos.
 * Exclude tests on per-image basis.
 * Easily reproduce the test image locally.
 * Three new test images (ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, 
centos-6.6-gcc-4.8).

How to run

The following environment variables have to be set for the script to run:
 * OS - OS name/version. Currently images are available for ubuntu-14.04, 
ubuntu-12.04, centos-7.1, centos-6.6.
 * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
 * COMPILER - Compiler name/version. Currently available images include gcc-4.8 
(default value) on all platforms, clang-3.6 on ubuntu-14.04.

Examples:
`OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' 
COMPILER=clang-3.6 ./jenkins_build_docker.sh`
`OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' 
./jenkins_build_docker.sh`

NOTE: Mesos Python module has a known issue on centos-6.6 ( 
https://issues.apache.org/jira/browse/MESOS-3314 ), so **for now centos-6.6 
should not be enabled in Jenkins**.


Thanks,

Artem Harutyunyan

Re: Review Request 37785: Fix Flaky SlaveTest.HTTPSchedulerSlaveRestart test

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37785/#review96491
---


Patch looks great!

Reviews applied: [37785]

All tests passed.

- Mesos ReviewBot


On Aug. 26, 2015, 3:07 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37785/
> ---
> 
> (Updated Aug. 26, 2015, 3:07 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3311
> https://issues.apache.org/jira/browse/MESOS-3311
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> I was not able to reproduce this with 300 gtest iterations in a loop on a 
> Ubuntu 14.04 VM with clang + ssl i.e. similar to the ASF setup.
> 
> The logs though made it pretty evident on what was going on. The slave was 
> sending a retry re-register message to the master, resulting in the master 
> sending back another FrameworkUpdateMessage, the 2nd one used to set the PID 
> from None() to the original pid() making the message go through directly to 
> the scheduler instead of being routed through the master.
> 
> Log Lines:
> 
> I0825 22:07:39.085610 27642 slave.cpp:1209] Will retry registration in 
> 6.014445ms if necessary
> I0825 22:07:39.092914 27640 master.cpp:3773] Re-registering slave 
> 20150825-220736-234885548-51219-27610-S0 at slave(286)@172.17.0.14:51219 
> (09c6504e3a31)
> I0825 22:07:39.093181 27630 slave.cpp:1209] Will retry registration in 
> 20.588077ms if necessary
>  some lines and then
> I0825 22:07:39.094435 27640 master.cpp:3773] Re-registering slave 
> 20150825-220736-234885548-51219-27610-S0 at slave(287)@172.17.0.14:51219 
> (09c6504e3a31)
> ... more lines
> I0825 22:07:39.096372 27635 slave.cpp:2131] Updating framework 
> 20150825-220736-234885548-51219-27610- pid to @0.0.0.0:0
> ... more lines
> I0825 22:07:39.097450 27635 slave.cpp:2131] Updating framework 
> 20150825-220736-234885548-51219-27610- pid to 
> scheduler-6c5ddcdb-9dd1-4b38-b051-5f714d3c1c55@172.17.0.14:51219
> ... more lines
> I0825 22:07:39.098433 27635 slave.cpp:3043] Sending message for framework 
> 20150825-220736-234885548-51219-27610- to 
> scheduler-6c5ddcdb-9dd1-4b38-b051-5f714d3c1c55@172.17.0.14:51219
> 
> 
> Paused the clock and then settle/resume invocations to ensure the retry does 
> not happen
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37785/diff/
> 
> 
> Testing
> ---
> 
> make check again with 300 iterations without failure
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37784: Remove the redundant check in HierarchicalDRFAlocator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37784/#review96488
---


Patch looks great!

Reviews applied: [37784]

All tests passed.

- Mesos ReviewBot


On Aug. 26, 2015, 2:54 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37784/
> ---
> 
> (Updated Aug. 26, 2015, 2:54 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3301
> https://issues.apache.org/jira/browse/MESOS-3301
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove the redundant check in HierarchicalDRFAlocator.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 38f8fd2c84314bb3731684d0e9795cb4f50a227e 
> 
> Diff: https://reviews.apache.org/r/37784/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Guangya Liu]

> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > 
> >
> > It is better consider the alpha order of those files, we can add quota 
> > related files under module related files.
> 
> Alexander Rukletsov wrote:
> Could you please elaborate? I'm not sure I follow.
> 
> Guangya Liu wrote:
> I mean the file order in Makefile.am should follow alpha order as other 
> part in this file.
> 
> My propose is that you only need to re-order the file list here as 
> following:
> 
> module/module.pb.cc \
>   ../include/mesos/module/module.pb.h   \
> master/quota.pb.cc  \
>   ../include/mesos/master/quota.pb.h\
> 
> Just adjust the order should works.
> 
> Alexander Rukletsov wrote:
> I see. We also include folder into lexicographic sorting, therefore 
> `module > master` and hence all `master/**` go before `module/**`. Does it 
> make sense?

Exactly, this can make the code more readable. I found that both Mesos and 
OpenStack projects are following such style ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 37785: Fix Flaky SlaveTest.HTTPSchedulerSlaveRestart test

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37785/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-3311
https://issues.apache.org/jira/browse/MESOS-3311


Repository: mesos


Description
---

I was not able to reproduce this with 300 gtest iterations in a loop on a 
Ubuntu 14.04 VM with clang + ssl i.e. similar to the ASF setup.

The logs though made it pretty evident on what was going on. The slave was 
sending a retry re-register message to the master, resulting in the master 
sending back another FrameworkUpdateMessage, the 2nd one used to set the PID 
from None() to the original pid() making the message go through directly to the 
scheduler instead of being routed through the master.

Log Lines:

I0825 22:07:39.085610 27642 slave.cpp:1209] Will retry registration in 
6.014445ms if necessary
I0825 22:07:39.092914 27640 master.cpp:3773] Re-registering slave 
20150825-220736-234885548-51219-27610-S0 at slave(286)@172.17.0.14:51219 
(09c6504e3a31)
I0825 22:07:39.093181 27630 slave.cpp:1209] Will retry registration in 
20.588077ms if necessary
 some lines and then
I0825 22:07:39.094435 27640 master.cpp:3773] Re-registering slave 
20150825-220736-234885548-51219-27610-S0 at slave(287)@172.17.0.14:51219 
(09c6504e3a31)
... more lines
I0825 22:07:39.096372 27635 slave.cpp:2131] Updating framework 
20150825-220736-234885548-51219-27610- pid to @0.0.0.0:0
... more lines
I0825 22:07:39.097450 27635 slave.cpp:2131] Updating framework 
20150825-220736-234885548-51219-27610- pid to 
scheduler-6c5ddcdb-9dd1-4b38-b051-5f714d3c1c55@172.17.0.14:51219
... more lines
I0825 22:07:39.098433 27635 slave.cpp:3043] Sending message for framework 
20150825-220736-234885548-51219-27610- to 
scheduler-6c5ddcdb-9dd1-4b38-b051-5f714d3c1c55@172.17.0.14:51219


Paused the clock and then settle/resume invocations to ensure the retry does 
not happen


Diffs
-

  src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 

Diff: https://reviews.apache.org/r/37785/diff/


Testing
---

make check again with 300 iterations without failure


Thanks,

Anand Mazumdar

Review Request 37784: Remove the redundant check in HierarchicalDRFAlocator.

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37784/
---

Review request for mesos.


Bugs: MESOS-3301
https://issues.apache.org/jira/browse/MESOS-3301


Repository: mesos


Description
---

Remove the redundant check in HierarchicalDRFAlocator.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
38f8fd2c84314bb3731684d0e9795cb4f50a227e 

Diff: https://reviews.apache.org/r/37784/diff/


Testing
---


Thanks,

Yong Qiao Wang

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Alexander Rukletsov]

> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > 
> >
> > It is better consider the alpha order of those files, we can add quota 
> > related files under module related files.
> 
> Alexander Rukletsov wrote:
> Could you please elaborate? I'm not sure I follow.
> 
> Guangya Liu wrote:
> I mean the file order in Makefile.am should follow alpha order as other 
> part in this file.
> 
> My propose is that you only need to re-order the file list here as 
> following:
> 
> module/module.pb.cc \
>   ../include/mesos/module/module.pb.h   \
> master/quota.pb.cc  \
>   ../include/mesos/master/quota.pb.h\
> 
> Just adjust the order should works.

I see. We also include folder into lexicographic sorting, therefore `module > 
master` and hence all `master/**` go before `module/**`. Does it make sense?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review96484
---


Bad patch!

Reviews applied: [37655, 36321, 36571]

Failed command: ./support/apply-review.sh -n -r 36571

Error:
 2015-08-26 02:15:28 URL:https://reviews.apache.org/r/36571/diff/raw/ 
[8196/8196] -> "36571.patch" [1]
error: patch failed: src/Makefile.am:414
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 26, 2015, 2:13 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37623/
> ---
> 
> (Updated Aug. 26, 2015, 2:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37623/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Vaibhav Khanduja]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/
---

(Updated Aug. 26, 2015, 2:15 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod 
Kone.


Changes
---

Addressed comments .. changed function to compare two strings


Bugs: MESOS-3187
https://issues.apache.org/jira/browse/MESOS-3187


Repository: mesos


Description
---

MESOS-3187, support docker host command line option.

Docker daemon supports starting on a non-default port. Such scenarios would 
needed when starting Docker daemon on TCP or non-default unix port. Mesos slave 
does not work if Docker daemon is started on any of such non-default port. The 
code change is needed in Mesos slave to accept this parameter so as connect for 
its operations to the right Docker daemon. The change is made in Mesos slave, 
so as it is available to any framework making using Docker executor. 

The code is added to start slave binary with --docker_host, instructing it to 
connect on port as specified in the parameter. The default value of 
--default_host is "unix:///var/run/docker.sock, which is default port for 
Docker daemon.

The main class src/docker.cpp/.hpp is kept backward compartible to make Docker 
cli execute on default Docker port.


Diffs (updated)
-

  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
  src/tests/containerizer/docker_containerizer_tests.cpp 
80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
  src/tests/containerizer/docker_tests.cpp 
a4a2725c05ae0cb88426c587f7ded0da77154edc 
  src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
  src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 

Diff: https://reviews.apache.org/r/37114/diff/


Testing
---

Following scenarios were executed to test the code changes. Kindly suggest if 
more test-cases are required:


a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
 
   i) Start slave with --docker_host parameter 
"unix:///var/run/docker_myport.sock
   ii) Using a framework, in my case Marathon, post a Docker job
   iii) The docker job does get started on the slave, confirmed with docker ps 
command output 
   
docker -H unix:///var/run/docker_myport.sock ps

CONTAINER IDIMAGE   COMMANDCREATED  
   STATUS  PORTS   NAMES
07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago   
   Up 19 minutes   */tcp, */udp
mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c

iv) Stop or destroy the job from Marathon GUI

b) Two mesos slave with non-default docker port
i) On two different hosts, start slave, with one running on default port 
and other non-default. The start slaves with attributes - default and or 
non-default.
ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
slave - non-default & default
iii) Stop/destroy the jobs

d) Modified unit test-case taking docker port value - make check


Thanks,

Vaibhav Khanduja

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37622/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37623/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37283/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37280/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
38f8fd2c84314bb3731684d0e9795cb4f50a227e 
  src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb 

Diff: https://reviews.apache.org/r/37280/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37621/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37621/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 

Diff: https://reviews.apache.org/r/37284/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 

Diff: https://reviews.apache.org/r/37180/diff/


Testing
---

The tests break as expected.
With the scheduler API change there are CHECKs that fail.
Once we update the API these will be resolved.


Thanks,

Joris Van Remoortere

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6 
  src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9 
  src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9 
  src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765 
  src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 

Diff: https://reviews.apache.org/r/37282/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37234/
---

(Updated Aug. 26, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 

Diff: https://reviews.apache.org/r/37234/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/v1/scheduler/scheduler.proto 
bd5e82a614b1163b29f9b20e562208efa1ba4b55 

Diff: https://reviews.apache.org/r/37178/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Guangya Liu]

> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > 
> >
> > It is better consider the alpha order of those files, we can add quota 
> > related files under module related files.
> 
> Alexander Rukletsov wrote:
> Could you please elaborate? I'm not sure I follow.

I mean the file order in Makefile.am should follow alpha order as other part in 
this file.

My propose is that you only need to re-order the file list here as following:

module/module.pb.cc \
  ../include/mesos/module/module.pb.h   \
master/quota.pb.cc  \
  ../include/mesos/master/quota.pb.h\

Just adjust the order should works.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/sorter/drf/sorter.hpp 
f66ade06c6a5b4bf816839477cec2d18036c7b1a 
  src/master/allocator/sorter/drf/sorter.cpp 
bfc273493419fe46a4d907f4f7fa282cff71b800 
  src/master/allocator/sorter/sorter.hpp 
536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 

Diff: https://reviews.apache.org/r/37176/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  include/mesos/master/allocator.proto 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
38f8fd2c84314bb3731684d0e9795cb4f50a227e 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/hierarchical_allocator_tests.cpp 
9748ca0b3fee25dcec51c64d8ba84dbd4aaf 
  src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 
  src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb 
  src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
  src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 

Diff: https://reviews.apache.org/r/37173/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.hpp PRE-CREATION 
  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
38f8fd2c84314bb3731684d0e9795cb4f50a227e 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/hierarchical_allocator_tests.cpp 
9748ca0b3fee25dcec51c64d8ba84dbd4aaf 
  src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 
  src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb 
  src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
  src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 
  src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 

Diff: https://reviews.apache.org/r/37177/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
  src/master/allocator/mesos/allocator.hpp 
aa55755a9c3250579e9366bdbc17a2449e95d659 
  src/master/allocator/mesos/hierarchical.hpp 
38f8fd2c84314bb3731684d0e9795cb4f50a227e 
  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 
  src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb 

Diff: https://reviews.apache.org/r/37175/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.hpp PRE-CREATION 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37172/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/
---

(Updated Aug. 26, 2015, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 

Diff: https://reviews.apache.org/r/37170/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96482
---



src/Makefile.am (line 182)


I mean the file order in Makefile.am should follow alpha order as other 
part in this file.

My propose is that you only need to re-order the file list here as 
following:

module/module.pb.cc \
  ../include/mesos/module/module.pb.h   
\
master/quota.pb.cc  \
  ../include/mesos/master/quota.pb.h
\
  
Just adjust the order should works.


- Guangya Liu


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96478
---



src/master/master.cpp (line 1920)


I think that the logic in 
void Master::_subscribe(
const UPID& from,
const scheduler::Call::Subscribe& subscribe,
const Future& authorized)
should also be udpated?


- Guangya Liu


On Aug. 25, 2015, 8:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37500/
> ---
> 
> (Updated Aug. 25, 2015, 8:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3240
> https://issues.apache.org/jira/browse/MESOS-3240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user to master's state, slave's state (not exposed) and updated user in 
> all slaves that have the registered framework. Added the test too.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
>   src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
>   src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
>   src/tests/fault_tolerance_tests.cpp 
> 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37500/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 37773: WIP: Docker: Adding registry client.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review96477
---


Bad patch!

Reviews applied: [37426, 37427]

Failed command: ./support/apply-review.sh -n -r 37427

Error:
 2015-08-26 01:58:00 URL:https://reviews.apache.org/r/37427/diff/raw/ 
[35576/35576] -> "37427.patch" [1]
error: patch failed: src/Makefile.am:736
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 26, 2015, 1:10 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37773/
> ---
> 
> (Updated Aug. 26, 2015, 1:10 a.m.)
> 
> 
> Review request for mesos, Lily Chen and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added implementation for docker registry's Get Manifest and Get Blob APIs.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/registry_client.cpp 
> PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37773/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96474
---



src/tests/maintenance.hpp (lines 78 - 79)


Why do we have to fall down to second percision here?
Can we take an Option instead?
Is the start time really optional?


- Joris Van Remoortere


On Aug. 25, 2015, 5:03 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37325/
> ---
> 
> (Updated Aug. 25, 2015, 5:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2067 and MESOS-3069
> https://issues.apache.org/jira/browse/MESOS-2067
> https://issues.apache.org/jira/browse/MESOS-3069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint: /maintenance.schedule
> 
> Registry operation = maintenance::UpdateSchedule
>   Replaces the schedule with the given one.  Also sets all scheduled machines 
> into Draining mode.
> 
> Other changes:
>   Added a note about the "strict" flag.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/maintenance.hpp PRE-CREATION 
>   src/master/maintenance.cpp PRE-CREATION 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 
>   src/tests/maintenance.hpp PRE-CREATION 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
>   src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 
> 
> Diff: https://reviews.apache.org/r/37325/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> New Tests:
>   RegistrarTest.UpdateMaintenanceSchedule
> Schedules 3 machines, 1 at a time.  Rearranges schedules.
> Checks that machines are put into Draining mode.  Removes machines.
>   MasterMaintenanceTest.UpdateSchedule
> Hits the new endpoint with some valid and invalid schedules.
> Only tests a subset of invalid schedules (requires other endpoints to 
> fully test).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37779: Added labels documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96473
---


Patch looks great!

Reviews applied: [37779]

All tests passed.

- Mesos ReviewBot


On Aug. 26, 2015, 12:42 a.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> ---
> 
> (Updated Aug. 26, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added labels documentation to the framework development guide.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> db0181c0b82fded1860ef636747e70d80e3884f2 
> 
> Diff: https://reviews.apache.org/r/37779/diff/
> 
> 
> Testing
> ---
> 
> Rendered in Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 37773: WIP: Docker: Adding registry client.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/
---

(Updated Aug. 26, 2015, 1:10 a.m.)


Review request for mesos, Lily Chen and Timothy Chen.


Changes
---

Review comments addressed.


Repository: mesos


Description
---

Added implementation for docker registry's Get Manifest and Get Blob APIs.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/slave/containerizer/provisioners/docker/registry_client.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/registry_client.cpp PRE-CREATION 
  src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37773/diff/


Testing
---

make check


Thanks,

Jojy Varghese

Re: Review Request 37427: Docker registry: adding TokenManager.

[Jojy Varghese]

> On Aug. 25, 2015, 10:11 p.m., Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 318
> > 
> >
> > Capitalize beginning of failure messages.

for internal error messages (that bubbles up), the leaf level messsages are 
recommended to start with lower case. This is so that when the root level 
logger logs the message, it does not look like : "Failed to do operation foo: 
Failed to fetch data".


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review96421
---


On Aug. 26, 2015, 1:03 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> ---
> 
> (Updated Aug. 26, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 37427: Docker registry: adding TokenManager.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---

(Updated Aug. 26, 2015, 1:03 a.m.)


Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.


Changes
---

review comments addressed.


Repository: mesos


Description
---

Changes:
  - Added Token implementation (RFC 7519).
  - Added TokenManager implementation. This component keeps a cache of tokens
  requested for any future requests.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
  src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37427/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 37779: Added labels documentation.

[Niklas Nielsen]

> On Aug. 25, 2015, 5:38 p.m., Kapil Arya wrote:
> > Looks like you got some unwanted diffs in there :-).

Whoops - should be updated now


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96464
---


On Aug. 25, 2015, 5:42 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> ---
> 
> (Updated Aug. 25, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added labels documentation to the framework development guide.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> db0181c0b82fded1860ef636747e70d80e3884f2 
> 
> Diff: https://reviews.apache.org/r/37779/diff/
> 
> 
> Testing
> ---
> 
> Rendered in Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 37779: Added labels documentation.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/
---

(Updated Aug. 25, 2015, 5:42 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Ignore previous patch; needed rebase


Bugs: MESOS-2413
https://issues.apache.org/jira/browse/MESOS-2413


Repository: mesos


Description
---

Added labels documentation to the framework development guide.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
db0181c0b82fded1860ef636747e70d80e3884f2 

Diff: https://reviews.apache.org/r/37779/diff/


Testing
---

Rendered in Marked2


Thanks,

Niklas Nielsen

Re: Review Request 37779: Added labels documentation.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96464
---


Looks like you got some unwanted diffs in there :-).

- Kapil Arya


On Aug. 25, 2015, 8:34 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> ---
> 
> (Updated Aug. 25, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added labels documentation to the framework development guide.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> eb34251d24b1e5d1540151b59cf1062ca85aeb03 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> db5e33220844d20ef08a7324f641eeb1ff6d2052 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> 4010ad961b5e0cd6b26bfddd6f8761e2d6586c2b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> fdd33512c8d8752093f72f597a7d647eb5e3c285 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
> 657aaef95e6969e07e94a47d9e868e2bc5cd703d 
>   3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp 
> f109e97936a00c6a5503d354c1682850786e026d 
>   3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp 
> 0a126397b74c441ec1c06711cb80a144ed8a7f63 
>   3rdparty/libprocess/Makefile.am 7ef515848508c2e84ab7607595f635f67e24b19b 
>   3rdparty/libprocess/include/process/future.hpp 
> 9006b8a83d03eab6e67de12a954110029b7d150e 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> bd33a5af7bc7b1d5b0c70cbe09c2cd369d9cba76 
>   docs/app-framework-development-guide.md 
> db0181c0b82fded1860ef636747e70d80e3884f2 
>   docs/committers.md a44333e652ccfde57f97b5b9ede2765a26a4abb3 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/appc/paths.hpp 
> 41e3bf79da0854406c488855f953111e67353829 
>   src/slave/containerizer/provisioners/appc/paths.cpp 
> 3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7 
>   src/slave/containerizer/provisioners/backend.hpp 
> a25b4eaa1894178d4816cfbf1d9da2690bbe24bd 
>   src/slave/containerizer/provisioners/backend.cpp 
> 2f7c335f62fdeb27526ab9a38a07c097422ae92b 
>   src/slave/containerizer/provisioners/backends/bind.hpp 
> 61a883898ec170e7a61d04f78650f357de52ff0f 
>   src/slave/containerizer/provisioners/backends/bind.cpp 
> 1cdae61786790dc6a475ae5f73c8cc92d2bbf739 
>   src/slave/paths.hpp 35b0439e89193b0933b33b67450008b0da9bbae7 
>   src/slave/paths.cpp f5697fb5bbb40064a55c4465210dcbdcd8630c87 
>   src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 096bd4d4bbd602913796c5e542e033bdd9e04964 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
>   src/tests/utils.hpp d4fc6ac96e0cfd6924304dfa1e9e454a113f46f7 
> 
> Diff: https://reviews.apache.org/r/37779/diff/
> 
> 
> Testing
> ---
> 
> Rendered in Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 37779: Added labels documentation.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/
---

(Updated Aug. 25, 2015, 5:34 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Addressed comments from Kapil


Bugs: MESOS-2413
https://issues.apache.org/jira/browse/MESOS-2413


Repository: mesos


Description
---

Added labels documentation to the framework development guide.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
eb34251d24b1e5d1540151b59cf1062ca85aeb03 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
db5e33220844d20ef08a7324f641eeb1ff6d2052 
  3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
4010ad961b5e0cd6b26bfddd6f8761e2d6586c2b 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
fdd33512c8d8752093f72f597a7d647eb5e3c285 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
657aaef95e6969e07e94a47d9e868e2bc5cd703d 
  3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp 
f109e97936a00c6a5503d354c1682850786e026d 
  3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp 
0a126397b74c441ec1c06711cb80a144ed8a7f63 
  3rdparty/libprocess/Makefile.am 7ef515848508c2e84ab7607595f635f67e24b19b 
  3rdparty/libprocess/include/process/future.hpp 
9006b8a83d03eab6e67de12a954110029b7d150e 
  3rdparty/libprocess/src/tests/future_tests.cpp 
bd33a5af7bc7b1d5b0c70cbe09c2cd369d9cba76 
  docs/app-framework-development-guide.md 
db0181c0b82fded1860ef636747e70d80e3884f2 
  docs/committers.md a44333e652ccfde57f97b5b9ede2765a26a4abb3 
  include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/slave/containerizer/provisioners/appc/paths.hpp 
41e3bf79da0854406c488855f953111e67353829 
  src/slave/containerizer/provisioners/appc/paths.cpp 
3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7 
  src/slave/containerizer/provisioners/backend.hpp 
a25b4eaa1894178d4816cfbf1d9da2690bbe24bd 
  src/slave/containerizer/provisioners/backend.cpp 
2f7c335f62fdeb27526ab9a38a07c097422ae92b 
  src/slave/containerizer/provisioners/backends/bind.hpp 
61a883898ec170e7a61d04f78650f357de52ff0f 
  src/slave/containerizer/provisioners/backends/bind.cpp 
1cdae61786790dc6a475ae5f73c8cc92d2bbf739 
  src/slave/paths.hpp 35b0439e89193b0933b33b67450008b0da9bbae7 
  src/slave/paths.cpp f5697fb5bbb40064a55c4465210dcbdcd8630c87 
  src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 
  src/tests/containerizer/provisioner_backend_tests.cpp 
096bd4d4bbd602913796c5e542e033bdd9e04964 
  src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
  src/tests/utils.hpp d4fc6ac96e0cfd6924304dfa1e9e454a113f46f7 

Diff: https://reviews.apache.org/r/37779/diff/


Testing
---

Rendered in Marked2


Thanks,

Niklas Nielsen

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review96462
---


Patch looks great!

Reviews applied: [37532]

All tests passed.

- Mesos ReviewBot


On Aug. 22, 2015, 2:27 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Aug. 22, 2015, 2:27 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   include/mesos/v1/scheduler/scheduler.proto 
> bd5e82a614b1163b29f9b20e562208efa1ba4b55 
>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37747/
---

(Updated Aug. 25, 2015, 5:19 p.m.)


Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone.


Changes
---

Comments. NNFR.


Bugs: MESOS-3190
https://issues.apache.org/jira/browse/MESOS-3190


Repository: mesos


Description
---

Introduced bind-mount based provisioner Backend.


Diffs (updated)
-

  src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
  src/slave/containerizer/provisioners/backend.hpp 
46120e8420cc491a0decbd88301f89d6dfcff120 
  src/slave/containerizer/provisioners/backend.cpp 
6190ce3eeff6ea22142c9eaa5a771ae1b767740c 
  src/slave/containerizer/provisioners/backends/bind.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/backends/bind.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp PRE-CREATION 
  src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 

Diff: https://reviews.apache.org/r/37747/diff/


Testing
---

sudo make check. Added one test.


Thanks,

Jiang Yan Xu

Re: Review Request 37780: Added oversubscription in maintainers section

[Joseph Wu]

> On Aug. 25, 2015, 4:56 p.m., Jie Yu wrote:
> > docs/committers.md, lines 243-248
> > 
> >
> > I think maintainer names are sorted by last names. Please adjust the 
> > order accordingly.

If so, you might want to rearrange the row right above too.  (H < N)


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37780/#review96457
---


On Aug. 25, 2015, 4:54 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37780/
> ---
> 
> (Updated Aug. 25, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   docs/committers.md f37da303552f69aa5a62ecc06fd3077b89360181 
> 
> Diff: https://reviews.apache.org/r/37780/diff/
> 
> 
> Testing
> ---
> 
> Rendered with Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 37780: Added oversubscription in maintainers section

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37780/#review96457
---

Ship it!



docs/committers.md (lines 243 - 248)


I think maintainer names are sorted by last names. Please adjust the order 
accordingly.


- Jie Yu


On Aug. 25, 2015, 11:54 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37780/
> ---
> 
> (Updated Aug. 25, 2015, 11:54 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   docs/committers.md f37da303552f69aa5a62ecc06fd3077b89360181 
> 
> Diff: https://reviews.apache.org/r/37780/diff/
> 
> 
> Testing
> ---
> 
> Rendered with Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 37779: Added labels documentation.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/#review96456
---


We should also mention that Labels are supposed to be "light-weight" so that 
the framework writers don't abuse them. Another point worth mentioning would be 
namespacing of labels to avoid conflicts. Finally, should we add pointers to 
the hook modules documentation so as to make the documentation complete?


docs/app-framework-development-guide.md (line 216)


s/StatusUpdate/TaskStatus



docs/app-framework-development-guide.md (line 217)


Can we make it a more explicit? i.e. "module writers use Labels to tag and 
..."



docs/app-framework-development-guide.md (line 218)


s/key value/key-value



docs/app-framework-development-guide.md (line 219)


s/decorators/label decorator hooks


- Kapil Arya


On Aug. 25, 2015, 7:49 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37779/
> ---
> 
> (Updated Aug. 25, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2413
> https://issues.apache.org/jira/browse/MESOS-2413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added labels documentation to the framework development guide.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> db0181c0b82fded1860ef636747e70d80e3884f2 
> 
> Diff: https://reviews.apache.org/r/37779/diff/
> 
> 
> Testing
> ---
> 
> Rendered in Marked2
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Review Request 37780: Added oversubscription in maintainers section

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37780/
---

Review request for mesos, Ben Mahler and Jie Yu.


Repository: mesos


Description
---

See summary


Diffs
-

  docs/committers.md f37da303552f69aa5a62ecc06fd3077b89360181 

Diff: https://reviews.apache.org/r/37780/diff/


Testing
---

Rendered with Marked2


Thanks,

Niklas Nielsen

Review Request 37779: Added labels documentation.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37779/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-2413
https://issues.apache.org/jira/browse/MESOS-2413


Repository: mesos


Description
---

Added labels documentation to the framework development guide.


Diffs
-

  docs/app-framework-development-guide.md 
db0181c0b82fded1860ef636747e70d80e3884f2 

Diff: https://reviews.apache.org/r/37779/diff/


Testing
---

Rendered in Marked2


Thanks,

Niklas Nielsen

Re: Review Request 37734: Used recursive bind mounts for volumes.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37734/#review96455
---

Ship it!


Not exactly necessary for now but ship it considering this is future proof for 
a certain way of implementing OverlayfsBackend for certain kernels (3.18 kernel 
supports overlayfs but not multiple lower layers).

- Jiang Yan Xu


On Aug. 24, 2015, 4 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37734/
> ---
> 
> (Updated Aug. 24, 2015, 4 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used recursive bind mounts for volumes.
> 
> This is for the case where the volume source itself contains mounts. This 
> will become common when we start to support image as the source of a volume.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> f36424e94c380870cfde49d55af397fa3dc4a612 
> 
> Diff: https://reviews.apache.org/r/37734/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review96453
---


Can you split the addition of suppress to the driver (sched.cpp) and http 
library (scheduler.cpp) into separate patches? Note that the former needs 
updates to the Java and Python bindings as well.

More importantly, are you planning to plumb this call through to the allocator 
to actually do the quiescing/suppressing?

- Vinod Kone


On Aug. 22, 2015, 2:27 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Aug. 22, 2015, 2:27 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   include/mesos/v1/scheduler/scheduler.proto 
> bd5e82a614b1163b29f9b20e562208efa1ba4b55 
>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37747/#review96452
---


Patch looks great!

Reviews applied: [37722, 37747]

All tests passed.

- Mesos ReviewBot


On Aug. 25, 2015, 10:59 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37747/
> ---
> 
> (Updated Aug. 25, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3190
> https://issues.apache.org/jira/browse/MESOS-3190
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced bind-mount based provisioner Backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/slave/containerizer/provisioners/backend.hpp 
> 46120e8420cc491a0decbd88301f89d6dfcff120 
>   src/slave/containerizer/provisioners/backend.cpp 
> 6190ce3eeff6ea22142c9eaa5a771ae1b767740c 
>   src/slave/containerizer/provisioners/backends/bind.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backends/bind.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
>   src/tests/containerizer/provisioner_backend_tests.cpp PRE-CREATION 
>   src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 
> 
> Diff: https://reviews.apache.org/r/37747/diff/
> 
> 
> Testing
> ---
> 
> sudo make check. Added one test.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Vaibhav Khanduja]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/#review96449
---



src/docker/docker.cpp (line 111)


This should be comparison of ! with 0



src/docker/docker.cpp (line 116)


This should be comparison of ! with 0



src/docker/docker.cpp (line 121)


This should be comparison of ! with 0


- Vaibhav Khanduja


On Aug. 25, 2015, 10:53 p.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37114/
> ---
> 
> (Updated Aug. 25, 2015, 10:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3187
> https://issues.apache.org/jira/browse/MESOS-3187
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3187, support docker host command line option.
> 
> Docker daemon supports starting on a non-default port. Such scenarios would 
> needed when starting Docker daemon on TCP or non-default unix port. Mesos 
> slave does not work if Docker daemon is started on any of such non-default 
> port. The code change is needed in Mesos slave to accept this parameter so as 
> connect for its operations to the right Docker daemon. The change is made in 
> Mesos slave, so as it is available to any framework making using Docker 
> executor. 
> 
> The code is added to start slave binary with --docker_host, instructing it to 
> connect on port as specified in the parameter. The default value of 
> --default_host is "unix:///var/run/docker.sock, which is default port for 
> Docker daemon.
> 
> The main class src/docker.cpp/.hpp is kept backward compartible to make 
> Docker cli execute on default Docker port.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
>   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
>   src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
>   src/tests/containerizer/docker_tests.cpp 
> a4a2725c05ae0cb88426c587f7ded0da77154edc 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 
> 
> Diff: https://reviews.apache.org/r/37114/diff/
> 
> 
> Testing
> ---
> 
> Following scenarios were executed to test the code changes. Kindly suggest if 
> more test-cases are required:
> 
> 
> a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
>  
>i) Start slave with --docker_host parameter 
> "unix:///var/run/docker_myport.sock
>ii) Using a framework, in my case Marathon, post a Docker job
>iii) The docker job does get started on the slave, confirmed with docker 
> ps command output 
>
> docker -H unix:///var/run/docker_myport.sock ps
> 
> CONTAINER IDIMAGE   COMMANDCREATED
>  STATUS  PORTS   NAMES
> 07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago 
>  Up 19 minutes   */tcp, */udp
> mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c
> 
> iv) Stop or destroy the job from Marathon GUI
> 
> b) Two mesos slave with non-default docker port
> i) On two different hosts, start slave, with one running on default port 
> and other non-default. The start slaves with attributes - default and or 
> non-default.
> ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
> slave - non-default & default
> iii) Stop/destroy the jobs
> 
> d) Modified unit test-case taking docker port value - make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37747/#review96444
---

Ship it!



src/slave/containerizer/provisioners/backend.cpp (line 24)


Add a blank line above.



src/slave/flags.hpp (line 51)


See my comments below. It's not used, please remove it.



src/slave/flags.cpp (lines 67 - 71)


This is no longer used in this patch. Could you please remove it.



src/tests/containerizer/provisioner_backend_tests.cpp (line 63)


Add one line above.



src/tests/containerizer/provisioner_backend_tests.cpp (line 67)


Kill one line.



src/tests/containerizer/provisioner_backend_tests.cpp (line 85)


You can do:

```
AWAIT_READY(backends["bind"]->provision(...));
```



src/tests/containerizer/provisioner_backend_tests.cpp (line 95)


backends["bind"]->destroy(...)


- Jie Yu


On Aug. 25, 2015, 10:59 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37747/
> ---
> 
> (Updated Aug. 25, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3190
> https://issues.apache.org/jira/browse/MESOS-3190
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced bind-mount based provisioner Backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/slave/containerizer/provisioners/backend.hpp 
> 46120e8420cc491a0decbd88301f89d6dfcff120 
>   src/slave/containerizer/provisioners/backend.cpp 
> 6190ce3eeff6ea22142c9eaa5a771ae1b767740c 
>   src/slave/containerizer/provisioners/backends/bind.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backends/bind.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
>   src/tests/containerizer/provisioner_backend_tests.cpp PRE-CREATION 
>   src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 
> 
> Diff: https://reviews.apache.org/r/37747/diff/
> 
> 
> Testing
> ---
> 
> sudo make check. Added one test.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Alexander Rukletsov]

> On Aug. 25, 2015, 9:55 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, line 129
> > 
> >
> > For consistency, please one space between sentences! Here and below.
> 
> Joseph Wu wrote:
> The codebase isn't consistent in this respect.  But grammatically, 2 
> spaces is correct (notice that the ASF license text uses 2 spaces).

Not saying anything about grammatical correctness, I haven't found any 2 space 
comments in `mesos.proto`, except indents. Since 1 space is correct as well, 
let's be consistent. You're not updating the license, but the comment, right?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96126
---


On Aug. 25, 2015, 10:53 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 25, 2015, 10:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> Also copied to v1 API.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

[Jiang Yan Xu]

> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/bind.cpp, line 41
> > 
> >
> > No need for the process ID generation unless it's proven needed.

It's much harder to do this when debugging becauase you don't know which 
process to add the id to: https://issues.apache.org/jira/browse/MESOS-1457

But I understand that we are not doing this consistently. OK for dropping it. 
/sigh


> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/bind.cpp, line 45
> > 
> >
> > I would sugguest you save the slave flags at least.
> > 
> > ```
> > public:
> >   BindBackendProcess(const Flags& _flags)
> > : flags(_flags) {}
> > 
> > private:
> >   const Flags flags;
> > ```

Chatted offline. Not saving it for now because it's not needed for BindBackend. 
we can add it back when necessary of course.


> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/bind.cpp, line 107
> > 
> >
> > Can you try if MS_BIND | MS_RDONLY works here (so that you can save the 
> > remount below).
> > 
> > Also, I think you might want to do a recursive bind mount in case the 
> > layer itself has some mounts underneath it.
> > 
> > YOu can drop a TODO here.

MS_BIND | MS_RDONLY in one call doesn't work. Remount is necessary.

MS_REC: Not necessary for APPC but added the TODO. It's only necessary if 
mounts are used during image preparation for a single layer. Bind mount already 
limits the number of layers to be 1. Feels unlikely to me but a note here is 
definitely helpful.


> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/bind.cpp, line 121
> > 
> >
> > The read-only bind mount introduces a problem that the filesystem 
> > isolator cannot create the mount point for the sandbox anymore if it does 
> > not exist.
> > 
> > Please add a NOTE states that all mount points needed must already be 
> > present in the rootfs.

Thanks for spotting this! This is quite a limitation for BindBackend's 
usability but luckily the user can work around this.


> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/bind.cpp, line 143
> > 
> >
> > Please add a TODO here saying that if recursive bind mount is used 
> > above, here you need to check `strings::contains(entry.target, rootfs)`.

`strings::startsWith(entry.target, rootfs)`. Added a note.


> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/bind.cpp, line 144
> > 
> >
> > Any reason use a detached UMOUNT here? The os::rmdir will fail if 
> > unmount hasn't finished yet.

Removed MNT_DETACH flag.


> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_backend_tests.cpp, line 45
> > 
> >
> > Could you please call it ProvisionerBindBackendTest.

Named it `BindBackendTest`, I imagine `OverlayfsBackend` can also use this test 
but oh well, let's refactor later.


> On Aug. 25, 2015, 12:24 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_backend_tests.cpp, lines 74-76
> > 
> >
> > This is expensive. You don't need a working rootfs as far as I can 
> > tell, right?

Created a dummy fs.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37747/#review96384
---


On Aug. 25, 2015, 3:59 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37747/
> ---
> 
> (Updated Aug. 25, 2015, 3:59 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3190
> https://issues.apache.org/jira/browse/MESOS-3190
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced bind-mount based provisioner Backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/slave/containerizer/provisioners/backend.hpp 
> 46120e8420cc491a0decbd88301f89d6dfcff120 
>   src/slave/containerizer/pro

Re: Review Request 37747: Introduced bind-mount based provisioner Backend.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37747/
---

(Updated Aug. 25, 2015, 3:59 p.m.)


Review request for mesos, Lily Chen, Jie Yu, Timothy Chen, and Vinod Kone.


Changes
---

Comments.


Bugs: MESOS-3190
https://issues.apache.org/jira/browse/MESOS-3190


Repository: mesos


Description
---

Introduced bind-mount based provisioner Backend.


Diffs (updated)
-

  src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
  src/slave/containerizer/provisioners/backend.hpp 
46120e8420cc491a0decbd88301f89d6dfcff120 
  src/slave/containerizer/provisioners/backend.cpp 
6190ce3eeff6ea22142c9eaa5a771ae1b767740c 
  src/slave/containerizer/provisioners/backends/bind.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/backends/bind.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
  src/tests/containerizer/provisioner_backend_tests.cpp PRE-CREATION 
  src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 

Diff: https://reviews.apache.org/r/37747/diff/


Testing
---

sudo make check. Added one test.


Thanks,

Jiang Yan Xu

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/
---

(Updated Aug. 25, 2015, 3:53 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Commenting changes and clarifications.


Bugs: MESOS-2061 and MESOS-2066
https://issues.apache.org/jira/browse/MESOS-2061
https://issues.apache.org/jira/browse/MESOS-2066


Repository: mesos


Description (updated)
---

MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
MESOS-2066: Add the Unavailability field to Offers.

Also copied to v1 API.

No integration with other components (that part is tracked in separate JIRAs, 
see MESOS-1474).


Diffs (updated)
-

  include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/36321/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Vaibhav Khanduja]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/
---

(Updated Aug. 25, 2015, 10:53 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod 
Kone.


Changes
---

Addressed comments & feedback


Bugs: MESOS-3187
https://issues.apache.org/jira/browse/MESOS-3187


Repository: mesos


Description
---

MESOS-3187, support docker host command line option.

Docker daemon supports starting on a non-default port. Such scenarios would 
needed when starting Docker daemon on TCP or non-default unix port. Mesos slave 
does not work if Docker daemon is started on any of such non-default port. The 
code change is needed in Mesos slave to accept this parameter so as connect for 
its operations to the right Docker daemon. The change is made in Mesos slave, 
so as it is available to any framework making using Docker executor. 

The code is added to start slave binary with --docker_host, instructing it to 
connect on port as specified in the parameter. The default value of 
--default_host is "unix:///var/run/docker.sock, which is default port for 
Docker daemon.

The main class src/docker.cpp/.hpp is kept backward compartible to make Docker 
cli execute on default Docker port.


Diffs (updated)
-

  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
  src/tests/containerizer/docker_containerizer_tests.cpp 
80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
  src/tests/containerizer/docker_tests.cpp 
a4a2725c05ae0cb88426c587f7ded0da77154edc 
  src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
  src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 

Diff: https://reviews.apache.org/r/37114/diff/


Testing
---

Following scenarios were executed to test the code changes. Kindly suggest if 
more test-cases are required:


a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
 
   i) Start slave with --docker_host parameter 
"unix:///var/run/docker_myport.sock
   ii) Using a framework, in my case Marathon, post a Docker job
   iii) The docker job does get started on the slave, confirmed with docker ps 
command output 
   
docker -H unix:///var/run/docker_myport.sock ps

CONTAINER IDIMAGE   COMMANDCREATED  
   STATUS  PORTS   NAMES
07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago   
   Up 19 minutes   */tcp, */udp
mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c

iv) Stop or destroy the job from Marathon GUI

b) Two mesos slave with non-default docker port
i) On two different hosts, start slave, with one running on default port 
and other non-default. The start slaves with attributes - default and or 
non-default.
ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
slave - non-default & default
iii) Stop/destroy the jobs

d) Modified unit test-case taking docker port value - make check


Thanks,

Vaibhav Khanduja

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Joseph Wu]

> On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, line 129
> > 
> >
> > For consistency, please one space between sentences! Here and below.

The codebase isn't consistent in this respect.  But grammatically, 2 spaces is 
correct (notice that the ASF license text uses 2 spaces).


> On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, lines 847-850
> > 
> >
> > As per my comment for `InverseOffers`, let's clarify the contract and 
> > guarantees here.
> 
> Alexander Rukletsov wrote:
> Or, as I said earlier, we can pull the contarct description out and 
> reference it here.

I actually left it out on purpose.  

The Unavailability in an Offer is a nugget of extra information about the 
resources.  The presence of the unavailability shouldn't drastically alter how 
frameworks perceive the offer; an offer is still meant to be an allocation.  If 
we put too much of the contract/guarantee logic into the offer, it'll start 
sounding like an offer for deallocation (that's what the InverseOffer is for).


> On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, line 123
> > 
> >
> > Let's add a comment saying it's not a generic range, but a range 
> > relative to unavailability event. I think the reason you do not use a more 
> > generic name is that you plan to add specific fields in the future. If this 
> > is the case, let's reflect it in the comment for posterity. If it's not, 
> > let's rename the message for something more general : ).

I'll add a comment *and* a TODO :)


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96126
---


On Aug. 25, 2015, 3:53 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 25, 2015, 3:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> Also copied to v1 API.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Joseph Wu]

> On Aug. 25, 2015, 10:21 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 939
> > 
> >
> > Thanks Joe! Got it, but I think that it is better that we can add some 
> > notes here to be more clear

Next time, please continue the discussion thread (and re-open the issue) 
instead of adding a new comment.

I'll expand on the sentence a bit.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96366
---


On Aug. 25, 2015, 3:53 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 25, 2015, 3:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> Also copied to v1 API.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/
---

(Updated Aug. 25, 2015, 10:48 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/37281/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
---

(Updated Aug. 25, 2015, 10:48 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
  src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6 
  src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9 
  src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9 
  src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765 
  src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 

Diff: https://reviews.apache.org/r/37282/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 36908: Added QuotaInfo Protobuf.

[Alexander Rukletsov]

> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > include/mesos/master/quota.proto, line 19
> > 
> >
> > Yes, does v1 API will be supportted for quota?

Adding new protobufs should be backwards-compatible, so I suppose the answer is 
"yes".


> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > 
> >
> > It is better consider the alpha order of those files, we can add quota 
> > related files under module related files.

Could you please elaborate? I'm not sure I follow.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Vaibhav Khanduja]

> On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 104
> > 
> >
> > prefixit sounds wierd, how about prefixSocket?

Will change


> On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 106
> > 
> >
> > Let's make these constants.

will change


> On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 107
> > 
> >
> > Btw I think you should just use strings::startswith, same for all other 
> > checks.

I don't know of method strings::startswith in c++ .. .but would change it to 
compare if that's okay ...


- Vaibhav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/#review96424
---


On Aug. 25, 2015, 9:29 p.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37114/
> ---
> 
> (Updated Aug. 25, 2015, 9:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3187
> https://issues.apache.org/jira/browse/MESOS-3187
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3187, support docker host command line option.
> 
> Docker daemon supports starting on a non-default port. Such scenarios would 
> needed when starting Docker daemon on TCP or non-default unix port. Mesos 
> slave does not work if Docker daemon is started on any of such non-default 
> port. The code change is needed in Mesos slave to accept this parameter so as 
> connect for its operations to the right Docker daemon. The change is made in 
> Mesos slave, so as it is available to any framework making using Docker 
> executor. 
> 
> The code is added to start slave binary with --docker_host, instructing it to 
> connect on port as specified in the parameter. The default value of 
> --default_host is "unix:///var/run/docker.sock, which is default port for 
> Docker daemon.
> 
> The main class src/docker.cpp/.hpp is kept backward compartible to make 
> Docker cli execute on default Docker port.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
>   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
>   src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
>   src/tests/containerizer/docker_tests.cpp 
> a4a2725c05ae0cb88426c587f7ded0da77154edc 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 
> 
> Diff: https://reviews.apache.org/r/37114/diff/
> 
> 
> Testing
> ---
> 
> Following scenarios were executed to test the code changes. Kindly suggest if 
> more test-cases are required:
> 
> 
> a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
>  
>i) Start slave with --docker_host parameter 
> "unix:///var/run/docker_myport.sock
>ii) Using a framework, in my case Marathon, post a Docker job
>iii) The docker job does get started on the slave, confirmed with docker 
> ps command output 
>
> docker -H unix:///var/run/docker_myport.sock ps
> 
> CONTAINER IDIMAGE   COMMANDCREATED
>  STATUS  PORTS   NAMES
> 07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago 
>  Up 19 minutes   */tcp, */udp
> mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c
> 
> iv) Stop or destroy the job from Marathon GUI
> 
> b) Two mesos slave with non-default docker port
> i) On two different hosts, start slave, with one running on default port 
> and other non-default. The start slaves with attributes - default and or 
> non-default.
> ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
> slave - non-default & default
> iii) Stop/destroy the jobs
> 
> d) Modified unit test-case taking docker port value - make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/#review96433
---


Patch looks great!

Reviews applied: [37196, 37197, 37198, 37200, 37247, 37495, 37496, 37497]

All tests passed.

- Mesos ReviewBot


On Aug. 25, 2015, 9:03 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37497/
> ---
> 
> (Updated Aug. 25, 2015, 9:03 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Docker provisioner paths which handles path manipulation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37497/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
> --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37427: Docker registry: adding TokenManager.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review96421
---



src/Makefile.am (line 477)


Group token_manager.hpp with other provisioner header files, see lines 
740-744.



src/slave/containerizer/provisioners/docker/token_manager.hpp (lines 22 - 23)


Make sure included libraries are in alphabetical order.



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 26)


Same here (libraries in alphabetical order).



src/slave/containerizer/provisioners/docker/token_manager.hpp (lines 30 - 33)


Stout libraries are usually included before process libraries



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 57)


Name parameters.



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 96)


Period at the end of comment.



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 97)


classes are separated by two empty lines.



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 198)


name parameter.



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 213)


place member variables after function declarations.



src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 57 - 70)


Why not just use a private member function?



src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 217 - 219)


Should only be indented 4 spaces.



src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 249 - 251)


Indent 2 more spaces



src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 254 - 255)


Indent by 2 spaces



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 318)


Capitalize beginning of failure messages.



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 321)


indent 2 more spaces?



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 323)


Here too.



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 330)


here too.



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 341)


Fix implementatio typo and period at the end of comment.



src/tests/provisioners/docker_provisioner_tests.cpp (line 562)


extra space here.


- Lily Chen


On Aug. 24, 2015, 5:16 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> ---
> 
> (Updated Aug. 24, 2015, 5:16 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Alexander Rukletsov]

> On Aug. 25, 2015, 9:55 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, lines 847-850
> > 
> >
> > As per my comment for `InverseOffers`, let's clarify the contract and 
> > guarantees here.

Or, as I said earlier, we can pull the contarct description out and reference 
it here.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96126
---


On Aug. 25, 2015, 3:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 25, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Alexander Rukletsov]

> On Aug. 21, 2015, 6:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, lines 917-920
> > 
> >
> > I think the name `Unavailability` is too specific to maintenance, how 
> > about something more generic, like `Period`?
> > 
> > I'm thinking about a use case, when a custom allocator uses 
> > InverseOffers to ask a framework to release resources. In this case, we 
> > need a "timeout", which is naturally expressed by `unavailability.start`. 
> > Given we don't need duration in this case, the name can be misleading for 
> > users.
> 
> Joseph Wu wrote:
> A while ago, I posted a few diffs where this object was called `Interval` 
> (https://reviews.apache.org/r/36321/diff/7/).  The reason why it was changed 
> back to `Unavailability` is that we may wish to extend this object to be more 
> specific, in the future.
> 
> (We've already removed all the maintenance-specific language in the 
> comments for `Unavailability` and `InverseOffer`.)
> 
> Taking your example, the custom allocator asks for resources back.  It 
> says that these will be unavailable by the `start` time.  Duration is 
> optional; in the case of maintenance, when `duration` is omitted, it means 
> the duration is forever or unknown.
> I think the term also works for non-maintenance uses.
> 
> Alexander Rukletsov wrote:
> For me "unavailability" implies the resources will be given back once the 
> period (interval) is over. Unless resource are reserved, this is not the 
> case, since allocator has no obligations to offer resources to prior users 
> once unavailability period is over.
> 
> In an offline conversation, Joris pointed out, that unavailability events 
> are mostly interesting for stateful frameworks, which most probably will have 
> reservations for resources. If you plan to leave current term, could you 
> please reflect in the comment what unavailability guarantees and what it does 
> not?
> 
> Joseph Wu wrote:
> Updated the comments.  Let me know what you think.

I think the comment is great: brief and clear. One thing I'm not sure about is 
whether it should be placed in the `InverseOffer` message, since there is a 
similar field in `ResourceOffer`. Maybe it makes sense to pull it up to the 
`Unavailability` definition and leave a reference to it in both places, where 
`unavailability` is used.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96073
---


On Aug. 25, 2015, 3:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 25, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96126
---



include/mesos/mesos.proto (line 123)


Let's add a comment saying it's not a generic range, but a range relative 
to unavailability event. I think the reason you do not use a more generic name 
is that you plan to add specific fields in the future. If this is the case, 
let's reflect it in the comment for posterity. If it's not, let's rename the 
message for something more general : ).



include/mesos/mesos.proto (line 129)


For consistency, please one space between sentences! Here and below.



include/mesos/mesos.proto (lines 847 - 850)


As per my comment for `InverseOffers`, let's clarify the contract and 
guarantees here.


- Alexander Rukletsov


On Aug. 25, 2015, 3:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> ---
> 
> (Updated Aug. 25, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
> https://issues.apache.org/jira/browse/MESOS-2061
> https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 36868: Added -> operators for Option, Try, Result.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36868/#review96429
---

Ship it!


Adjust the operator spacing.
Keeping the current style for now, we can align it differently later if we 
want. I'd rather get the functionality in.
Using the recommended way to delegate from the non-const version to the const 
version.

- Joris Van Remoortere


On July 28, 2015, 12:56 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36868/
> ---
> 
> (Updated July 28, 2015, 12:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2757
> https://issues.apache.org/jira/browse/MESOS-2757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-2757.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 549fc46cedb643ef1ebdf8441c332a02ac45016d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> 3d20614333864bff9c3801c71f2a384c4aa41a3f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> 5ad611497a47be64c539e832b9a1c23e6cf9586d 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
> 0c3f89bafe1afb15d1a2d775ed598cdf1a5ea147 
>   3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp 
> 0a381060ef418ab09b1d4ec2101d75a2a2c29e65 
>   3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36868/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 36869: Added try_tests.cpp to libprocess makefile.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36869/#review96430
---

Ship it!


Ship It!

- Joris Van Remoortere


On July 28, 2015, 12:56 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36869/
> ---
> 
> (Updated July 28, 2015, 12:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2757
> https://issues.apache.org/jira/browse/MESOS-2757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-2757.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> bd95fe197532131255072a86aba83cd5e822419a 
> 
> Diff: https://reviews.apache.org/r/36869/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/#review96424
---



src/docker/docker.cpp (line 104)


prefixit sounds wierd, how about prefixSocket?



src/docker/docker.cpp (line 106)


Let's make these constants.



src/docker/docker.cpp (line 107)


Btw I think you should just use strings::startswith, same for all other 
checks.


- Timothy Chen


On Aug. 25, 2015, 9:29 p.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37114/
> ---
> 
> (Updated Aug. 25, 2015, 9:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3187
> https://issues.apache.org/jira/browse/MESOS-3187
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3187, support docker host command line option.
> 
> Docker daemon supports starting on a non-default port. Such scenarios would 
> needed when starting Docker daemon on TCP or non-default unix port. Mesos 
> slave does not work if Docker daemon is started on any of such non-default 
> port. The code change is needed in Mesos slave to accept this parameter so as 
> connect for its operations to the right Docker daemon. The change is made in 
> Mesos slave, so as it is available to any framework making using Docker 
> executor. 
> 
> The code is added to start slave binary with --docker_host, instructing it to 
> connect on port as specified in the parameter. The default value of 
> --default_host is "unix:///var/run/docker.sock, which is default port for 
> Docker daemon.
> 
> The main class src/docker.cpp/.hpp is kept backward compartible to make 
> Docker cli execute on default Docker port.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
>   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
>   src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
>   src/tests/containerizer/docker_tests.cpp 
> a4a2725c05ae0cb88426c587f7ded0da77154edc 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 
> 
> Diff: https://reviews.apache.org/r/37114/diff/
> 
> 
> Testing
> ---
> 
> Following scenarios were executed to test the code changes. Kindly suggest if 
> more test-cases are required:
> 
> 
> a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
>  
>i) Start slave with --docker_host parameter 
> "unix:///var/run/docker_myport.sock
>ii) Using a framework, in my case Marathon, post a Docker job
>iii) The docker job does get started on the slave, confirmed with docker 
> ps command output 
>
> docker -H unix:///var/run/docker_myport.sock ps
> 
> CONTAINER IDIMAGE   COMMANDCREATED
>  STATUS  PORTS   NAMES
> 07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago 
>  Up 19 minutes   */tcp, */udp
> mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c
> 
> iv) Stop or destroy the job from Marathon GUI
> 
> b) Two mesos slave with non-default docker port
> i) On two different hosts, start slave, with one running on default port 
> and other non-default. The start slaves with attributes - default and or 
> non-default.
> ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
> slave - non-default & default
> iii) Stop/destroy the jobs
> 
> d) Modified unit test-case taking docker port value - make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Vaibhav Khanduja]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/#review96414
---



src/docker/docker.cpp (line 104)


lowerCamelCase function name



src/docker/docker.cpp (lines 682 - 683)


Intended with two spaces from continuation statement



src/docker/executor.cpp (line 409)


Intend with two spaces



src/tests/containerizer/docker_containerizer_tests.cpp (line 242)


Intent with two spaces



src/tests/containerizer/docker_containerizer_tests.cpp (line 424)


Intent with two spaces ...and rest of the code


- Vaibhav Khanduja


On Aug. 25, 2015, 9:29 p.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37114/
> ---
> 
> (Updated Aug. 25, 2015, 9:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3187
> https://issues.apache.org/jira/browse/MESOS-3187
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3187, support docker host command line option.
> 
> Docker daemon supports starting on a non-default port. Such scenarios would 
> needed when starting Docker daemon on TCP or non-default unix port. Mesos 
> slave does not work if Docker daemon is started on any of such non-default 
> port. The code change is needed in Mesos slave to accept this parameter so as 
> connect for its operations to the right Docker daemon. The change is made in 
> Mesos slave, so as it is available to any framework making using Docker 
> executor. 
> 
> The code is added to start slave binary with --docker_host, instructing it to 
> connect on port as specified in the parameter. The default value of 
> --default_host is "unix:///var/run/docker.sock, which is default port for 
> Docker daemon.
> 
> The main class src/docker.cpp/.hpp is kept backward compartible to make 
> Docker cli execute on default Docker port.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
>   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
>   src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
>   src/tests/containerizer/docker_tests.cpp 
> a4a2725c05ae0cb88426c587f7ded0da77154edc 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 
> 
> Diff: https://reviews.apache.org/r/37114/diff/
> 
> 
> Testing
> ---
> 
> Following scenarios were executed to test the code changes. Kindly suggest if 
> more test-cases are required:
> 
> 
> a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
>  
>i) Start slave with --docker_host parameter 
> "unix:///var/run/docker_myport.sock
>ii) Using a framework, in my case Marathon, post a Docker job
>iii) The docker job does get started on the slave, confirmed with docker 
> ps command output 
>
> docker -H unix:///var/run/docker_myport.sock ps
> 
> CONTAINER IDIMAGE   COMMANDCREATED
>  STATUS  PORTS   NAMES
> 07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago 
>  Up 19 minutes   */tcp, */udp
> mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c
> 
> iv) Stop or destroy the job from Marathon GUI
> 
> b) Two mesos slave with non-default docker port
> i) On two different hosts, start slave, with one running on default port 
> and other non-default. The start slaves with attributes - default and or 
> non-default.
> ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
> slave - non-default & default
> iii) Stop/destroy the jobs
> 
> d) Modified unit test-case taking docker port value - make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Vaibhav Khanduja]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/
---

(Updated Aug. 25, 2015, 9:29 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod 
Kone.


Changes
---

Fixed intentation issues


Bugs: MESOS-3187
https://issues.apache.org/jira/browse/MESOS-3187


Repository: mesos


Description
---

MESOS-3187, support docker host command line option.

Docker daemon supports starting on a non-default port. Such scenarios would 
needed when starting Docker daemon on TCP or non-default unix port. Mesos slave 
does not work if Docker daemon is started on any of such non-default port. The 
code change is needed in Mesos slave to accept this parameter so as connect for 
its operations to the right Docker daemon. The change is made in Mesos slave, 
so as it is available to any framework making using Docker executor. 

The code is added to start slave binary with --docker_host, instructing it to 
connect on port as specified in the parameter. The default value of 
--default_host is "unix:///var/run/docker.sock, which is default port for 
Docker daemon.

The main class src/docker.cpp/.hpp is kept backward compartible to make Docker 
cli execute on default Docker port.


Diffs (updated)
-

  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
  src/tests/containerizer/docker_containerizer_tests.cpp 
80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
  src/tests/containerizer/docker_tests.cpp 
a4a2725c05ae0cb88426c587f7ded0da77154edc 
  src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
  src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 

Diff: https://reviews.apache.org/r/37114/diff/


Testing
---

Following scenarios were executed to test the code changes. Kindly suggest if 
more test-cases are required:


a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
 
   i) Start slave with --docker_host parameter 
"unix:///var/run/docker_myport.sock
   ii) Using a framework, in my case Marathon, post a Docker job
   iii) The docker job does get started on the slave, confirmed with docker ps 
command output 
   
docker -H unix:///var/run/docker_myport.sock ps

CONTAINER IDIMAGE   COMMANDCREATED  
   STATUS  PORTS   NAMES
07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago   
   Up 19 minutes   */tcp, */udp
mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c

iv) Stop or destroy the job from Marathon GUI

b) Two mesos slave with non-default docker port
i) On two different hosts, start slave, with one running on default port 
and other non-default. The start slaves with attributes - default and or 
non-default.
ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
slave - non-default & default
iii) Stop/destroy the jobs

d) Modified unit test-case taking docker port value - make check


Thanks,

Vaibhav Khanduja

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96422
---


Patch looks great!

Reviews applied: [37500]

All tests passed.

- Mesos ReviewBot


On Aug. 25, 2015, 8:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37500/
> ---
> 
> (Updated Aug. 25, 2015, 8:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3240
> https://issues.apache.org/jira/browse/MESOS-3240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user to master's state, slave's state (not exposed) and updated user in 
> all slaves that have the registered framework. Added the test too.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
>   src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
>   src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
>   src/tests/fault_tolerance_tests.cpp 
> 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37500/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/
---

(Updated Aug. 25, 2015, 9:03 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Added Docker provisioner paths which handles path manipulation.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37497/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
---

(Updated Aug. 25, 2015, 9:02 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Move docker provisioner local store into dedicated folders.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37496/diff/


Testing
---

sudo make check 
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 25, 2015, 9:01 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 25, 2015, 9 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Rebased on master.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37200/
---

(Updated Aug. 25, 2015, 8:59 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Refactored DockerImage struct to store a list of layer ids instead of linked 
list of DockerLayers.


Diffs (updated)
-

  src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 

Diff: https://reviews.apache.org/r/37200/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37198: Add Docker image provisioner and copy backend.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/
---

(Updated Aug. 25, 2015, 8:58 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Rebased on master.


Bugs: MESOS-2850
https://issues.apache.org/jira/browse/MESOS-2850


Repository: mesos


Description
---

Add Docker image provisioner and copy backend.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
f36424e94c380870cfde49d55af397fa3dc4a612 
  src/slave/containerizer/provisioner.hpp 
541dd4e0b2f0c92a45c00cab6132a2be69654838 
  src/slave/containerizer/provisioner.cpp 
efc7e6996ff6663bebaf61989a7e040bd2ad7a5e 
  src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
  src/tests/containerizer/provisioner.hpp 
c4ba46794fe5d7875fda11155367f521c34ea339 

Diff: https://reviews.apache.org/r/37198/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37197: Docker image store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
---

(Updated Aug. 25, 2015, 8:57 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Stored images currently kept indefinitely.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
  src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
  src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 

Diff: https://reviews.apache.org/r/37197/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

[Joseph Wu]

> On Aug. 24, 2015, 4:56 p.m., Vinod Kone wrote:
> > This review is a bit hard to follow because it's doing multiple things. I 
> > would recommend you to split this into multiple reviews
> > 
> > #1) Expose framework user in state.json
> > #2) Update framework user on re-registration (need a test for this!)
> 
> Aditi Dixit wrote:
> Added the test. How do I split this into multiple reviews? Discard this 
> one and open two new ones by shifting the code into new branches and then 
> opening review requests?

You could:
```
# To update this review into the first in a review chain:
git branch temp # Save your work.
 # i.e. the re-registration stuff.
git add --update
git commit --amend

# For the second review:
git checkout temp -- . # Restore everything you deleted into a second commit.
git commit

support/post-reviews.py
```


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96240
---


On Aug. 25, 2015, 1:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37500/
> ---
> 
> (Updated Aug. 25, 2015, 1:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3240
> https://issues.apache.org/jira/browse/MESOS-3240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user to master's state, slave's state (not exposed) and updated user in 
> all slaves that have the registered framework. Added the test too.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
>   src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
>   src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
>   src/tests/fault_tolerance_tests.cpp 
> 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37500/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

[Aditi Dixit]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/
---

(Updated Aug. 25, 2015, 8:25 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3240
https://issues.apache.org/jira/browse/MESOS-3240


Repository: mesos


Description
---

Added user to master's state, slave's state (not exposed) and updated user in 
all slaves that have the registered framework. Added the test too.


Diffs (updated)
-

  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
  src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
  src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
  src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
  src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 

Diff: https://reviews.apache.org/r/37500/diff/


Testing
---

make check


Thanks,

Aditi Dixit

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

[Aditi Dixit]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/
---

(Updated Aug. 25, 2015, 8:19 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3240
https://issues.apache.org/jira/browse/MESOS-3240


Repository: mesos


Description
---

Added user to master's state, slave's state (not exposed) and updated user in 
all slaves that have the registered framework. Added the test too.


Diffs (updated)
-

  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
  src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
  src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
  src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
  src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 

Diff: https://reviews.apache.org/r/37500/diff/


Testing
---

make check


Thanks,

Aditi Dixit

Re: Review Request 36868: Added -> operators for Option, Try, Result.

[Michael Park]

> On July 29, 2015, 4:42 a.m., Michael Park wrote:
> > Why wasn't [r36869](https://reviews.apache.org/r/36869) just included in 
> > this patch?

Ah, it's because this patch is `stout` whereas 
[r36869](https://reviews.apache.org/r/36869/) is `libprocess`.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36868/#review93388
---


On July 28, 2015, 12:56 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36868/
> ---
> 
> (Updated July 28, 2015, 12:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2757
> https://issues.apache.org/jira/browse/MESOS-2757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-2757.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 549fc46cedb643ef1ebdf8441c332a02ac45016d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> 3d20614333864bff9c3801c71f2a384c4aa41a3f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> 5ad611497a47be64c539e832b9a1c23e6cf9586d 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
> 0c3f89bafe1afb15d1a2d775ed598cdf1a5ea147 
>   3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp 
> 0a381060ef418ab09b1d4ec2101d75a2a2c29e65 
>   3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36868/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96412
---


Bad patch!

Reviews applied: [37500]

Failed command: ./support/apply-review.sh -n -r 37500

Error:
 2015-08-25 20:17:03 URL:https://reviews.apache.org/r/37500/diff/raw/ 
[11293/11293] -> "37500.patch" [1]
37500.patch:163: trailing whitespace.
  
warning: 1 line adds whitespace errors.
Successfully applied: Update the FrameworkInfo.user on scheduler failover

Added user to master's state, slave's state (not exposed) and updated user in 
all slaves that have the registered framework. Added the test too.


Review: https://reviews.apache.org/r/37500
src/tests/fault_tolerance_tests.cpp:1943: trailing whitespace.
+  
Failed to commit patch

- Mesos ReviewBot


On Aug. 25, 2015, 8:19 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37500/
> ---
> 
> (Updated Aug. 25, 2015, 8:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3240
> https://issues.apache.org/jira/browse/MESOS-3240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user to master's state, slave's state (not exposed) and updated user in 
> all slaves that have the registered framework. Added the test too.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
>   src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
>   src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
>   src/tests/fault_tolerance_tests.cpp 
> 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37500/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 37114: MESOS-3187, support docker host command line option

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/#review96408
---


Content-wise, LGTM.

Style-wise, there's a bit of jaggedness in your function definitions and calls 
(marked a subset of them).
See the "Function Definition/Invocation" section in 
http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/


src/docker/docker.hpp (lines 49 - 50)


Indent of 4 spaces.



src/docker/docker.cpp (lines 131 - 132)


Indent of 4 spaces.



src/docker/docker.cpp (lines 682 - 683)


Indent of 4 spaces.



src/slave/containerizer/docker.cpp (line 129)


Extra newline.



src/tests/flags.hpp (line 83)


Extra space before `\n`.


- Joseph Wu


On Aug. 25, 2015, 12:27 p.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37114/
> ---
> 
> (Updated Aug. 25, 2015, 12:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3187
> https://issues.apache.org/jira/browse/MESOS-3187
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3187, support docker host command line option.
> 
> Docker daemon supports starting on a non-default port. Such scenarios would 
> needed when starting Docker daemon on TCP or non-default unix port. Mesos 
> slave does not work if Docker daemon is started on any of such non-default 
> port. The code change is needed in Mesos slave to accept this parameter so as 
> connect for its operations to the right Docker daemon. The change is made in 
> Mesos slave, so as it is available to any framework making using Docker 
> executor. 
> 
> The code is added to start slave binary with --docker_host, instructing it to 
> connect on port as specified in the parameter. The default value of 
> --default_host is "unix:///var/run/docker.sock, which is default port for 
> Docker daemon.
> 
> The main class src/docker.cpp/.hpp is kept backward compartible to make 
> Docker cli execute on default Docker port.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
>   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
>   src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
>   src/tests/containerizer/docker_tests.cpp 
> a4a2725c05ae0cb88426c587f7ded0da77154edc 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc 
> 
> Diff: https://reviews.apache.org/r/37114/diff/
> 
> 
> Testing
> ---
> 
> Following scenarios were executed to test the code changes. Kindly suggest if 
> more test-cases are required:
> 
> 
> a) Mesos slave with unix port : unix:///var/run/docker_myport.sock
>  
>i) Start slave with --docker_host parameter 
> "unix:///var/run/docker_myport.sock
>ii) Using a framework, in my case Marathon, post a Docker job
>iii) The docker job does get started on the slave, confirmed with docker 
> ps command output 
>
> docker -H unix:///var/run/docker_myport.sock ps
> 
> CONTAINER IDIMAGE   COMMANDCREATED
>  STATUS  PORTS   NAMES
> 07fc4ec86bacmygoserver  "/bin/sh -c /mygoser   19 minutes ago 
>  Up 19 minutes   */tcp, */udp
> mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c
> 
> iv) Stop or destroy the job from Marathon GUI
> 
> b) Two mesos slave with non-default docker port
> i) On two different hosts, start slave, with one running on default port 
> and other non-default. The start slaves with attributes - default and or 
> non-default.
> ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting 
> slave - non-default & default
> iii) Stop/destroy the jobs
> 
> d) Modified unit test-case taking docker port value - make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 36870: Added -> operator for Future.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36870/#review96409
---

Ship it!


Adjusted the operater spacing to match updated style.

- Joris Van Remoortere


On July 28, 2015, 12:56 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36870/
> ---
> 
> (Updated July 28, 2015, 12:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2757
> https://issues.apache.org/jira/browse/MESOS-2757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-2757.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a 
>   3rdparty/libprocess/include/process/future.hpp 
> db92767619ec7b6ab1a0803c240725a2633d2489 
>   3rdparty/libprocess/src/tests/future_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36870/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>