Re: Review Request 39432: Add /master/frameworks to master endpoint

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39432/
---

(Updated 十月 19, 2015, 6:31 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3735
https://issues.apache.org/jira/browse/MESOS-3735


Repository: mesos


Description
---

Add /master/frameworks to master endpoint


Diffs
-

  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 

Diff: https://reviews.apache.org/r/39432/diff/


Testing (updated)
---

gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/frameworks; 
2>/dev/null| jq .
{
  "unregistered_frameworks": [],
  "frameworks": [
{
  "webui_url": "",
  "user": "root",
  "used_resources": {
"mem": 256,
"disk": 0,
"cpus": 1
  },
  "unregistered_time": 0,
  "id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
  "hostname": "devstack007.cn.ibm.com",
  "failover_timeout": 0,
  "executors": [],
  "completed_tasks": [],
  "checkpoint": false,
  "capabilities": [],
  "active": true,
  "name": "",
  "offered_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "offers": [],
  "pid": 
"scheduler-43ee3a42-9302-4815-8a07-500e42367f41@9.111.242.187:60454",
  "registered_time": 1445236263.95058,
  "resources": {
"mem": 256,
"disk": 0,
"cpus": 1
  },
  "role": "*",
  "tasks": [
{
  "statuses": [
{
  "timestamp": 1445236266.63443,
  "state": "TASK_RUNNING",
  "container_status": {
"network_infos": [
  {
"ip_address": "9.111.242.187"
  }
]
  }
}
  ],
  "state": "TASK_RUNNING",
  "slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
  "resources": {
"mem": 256,
"disk": 0,
"cpus": 1
  },
  "name": "cluster-test",
  "id": "cluster-test",
  "framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
  "executor_id": ""
}
  ]
}
  ],
  "completed_frameworks": []
}


Thanks,

Guangya Liu

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39429/#review103106
---


Patch looks great!

Reviews applied: [39428, 39429]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 4:48 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39429/
> ---
> 
> (Updated Oct. 19, 2015, 4:48 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3326
> https://issues.apache.org/jira/browse/MESOS-3326
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3326. We adopted std::atomic in most of the code base earlier 
> (commits
> 87de003c6e8a, 4b938052b6af, and 4a01850c5540), but a few places were omitted;
> those locations are fixed by this commit.
> 
> There's one last place to fix: we use the GCC intrinsic __sync_synchronize() 
> in
> 3rdparty/libprocess/include/process/logging.h. Because that is used to protect
> modifications to the FLAGS_v variable defined by glog, we can't easily adapt 
> it
> to use std::atomic.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/owned.hpp 
> 17c42614155fed8fec185f29f9a9babb71ff5f85 
>   3rdparty/libprocess/include/process/shared.hpp 
> 021807b961bb55f11c9e04327135bd83f4d86c21 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> a3c57a261c09f7b76b78225719e64a26f2d66cd3 
> 
> Diff: https://reviews.apache.org/r/39429/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39432: Add /master/frameworks to master endpoint

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39432/#review103112
---


Patch looks great!

Reviews applied: [39432]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 6:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39432/
> ---
> 
> (Updated Oct. 19, 2015, 6:31 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add /master/frameworks to master endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
> 
> Diff: https://reviews.apache.org/r/39432/diff/
> 
> 
> Testing
> ---
> 
> gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/frameworks; 
> 2>/dev/null| jq .
> {
>   "unregistered_frameworks": [],
>   "frameworks": [
> {
>   "webui_url": "",
>   "user": "root",
>   "used_resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "unregistered_time": 0,
>   "id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "hostname": "devstack007.cn.ibm.com",
>   "failover_timeout": 0,
>   "executors": [],
>   "completed_tasks": [],
>   "checkpoint": false,
>   "capabilities": [],
>   "active": true,
>   "name": "",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "offers": [],
>   "pid": 
> "scheduler-43ee3a42-9302-4815-8a07-500e42367f41@9.111.242.187:60454",
>   "registered_time": 1445236263.95058,
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "role": "*",
>   "tasks": [
> {
>   "statuses": [
> {
>   "timestamp": 1445236266.63443,
>   "state": "TASK_RUNNING",
>   "container_status": {
> "network_infos": [
>   {
> "ip_address": "9.111.242.187"
>   }
> ]
>   }
> }
>   ],
>   "state": "TASK_RUNNING",
>   "slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "name": "cluster-test",
>   "id": "cluster-test",
>   "framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "executor_id": ""
> }
>   ]
> }
>   ],
>   "completed_frameworks": []
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 39432: Add /master/frameworks to master endpoint

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39432/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3735
https://issues.apache.org/jira/browse/MESOS-3735


Repository: mesos


Description
---

Add /master/frameworks to master endpoint


Diffs
-

  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 

Diff: https://reviews.apache.org/r/39432/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 39444: Fixed typo in docs.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39444/#review103135
---

Ship it!


Ship It!

- Joris Van Remoortere


On Oct. 19, 2015, 5:47 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39444/
> ---
> 
> (Updated Oct. 19, 2015, 5:47 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3757.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 
> 
> Diff: https://reviews.apache.org/r/39444/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38117: Export per container SNMP statistics

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/
---

(Updated Oct. 19, 2015, 6:49 p.m.)


Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone.


Changes
---

Address review comments from Ian


Bugs: MESOS-3365
https://issues.apache.org/jira/browse/MESOS-3365


Repository: mesos


Description
---

These stats are those we get by `netstat -s`, they are important for diagnose 
networking issues.


Diffs (updated)
-

  include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a811cf8002e 
  src/slave/containerizer/isolators/network/port_mapping.hpp 
ae53c1b1716a7ad9c6e64f9079c972bae31e4ed2 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
  src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 

Diff: https://reviews.apache.org/r/38117/diff/


Testing (updated)
---

./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics 
--pid=


Thanks,

Cong Wang

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/#review103149
---



docs/containerizer.md (line 37)


Based on the description above, it seems like `host_path="tmp"` is actually 
correct?


- Michael Park


On Oct. 19, 2015, 7:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39451/
> ---
> 
> (Updated Oct. 19, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix double dashes typo, highlighting, bullet points
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/39451/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 39455: Added documentation for asynchronous pimpl pattern used in libprocess

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39455/
---

Review request for mesos, Benjamin Hindman, Greg Mann, and Neil Conway.


Repository: mesos


Description
---

See summary


Diffs
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39455/diff/


Testing
---

https://gist.github.com/hatred/76a7619ba7b892dd0542


Thanks,

Anand Mazumdar

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/
---

(Updated Oct. 19, 2015, 9:23 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

comments addressed


Bugs: MESOS-3692
https://issues.apache.org/jira/browse/MESOS-3692


Repository: mesos


Description
---

MESOS-3692 - better documented --switch_user flag
Added better logging around the point where the error may occur.


Diffs (updated)
-

  3rdparty/libprocess/README.md 8e434c68a2c9bead608324b0e9ad0d31a2a3bb08 
  docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
  docs/upgrades.md 3854e59f68d53892b2673a4542ea2aaf96936cbb 
  src/examples/persistent_volume_framework.cpp 
176ac3df6f6a536affb4853d5d2f0bfda81fd720 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
  src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 

Diff: https://reviews.apache.org/r/39447/diff/


Testing
---

make check


Thanks,

Marco Massenzio

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:35 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing (updated)
---

https://gist.github.com/greggomann/b5b35a164a006bec9357


Thanks,

Greg Mann

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review103147
---



support/apply-reviews.py (line 12)


s/rid/review_id/

here and everywhere else.



support/apply-reviews.py (line 22)


why not have this return JSON instead of string?



support/apply-reviews.py (line 25)


s/extract/review/



support/apply-reviews.py (line 32)


s/r_list/reviews/

also, the function name is misleading. how about

s/parent_review/review_chain/ ?



support/apply-reviews.py (lines 33 - 34)


what does "reversed chain of review requests for a  given Review ID" mean? 
i'm assuming you mean dependent reviews? please make that more clear.



support/apply-reviews.py (lines 35 - 36)


if review_json returns json, this could be

json = review_json(review_url(rid))



support/apply-reviews.py (line 43)


s/A may/A review may/

do we want to allow reviews that have more than one parent review? what 
does that mean for the order of reviews to be applied? i think it makes sense 
to disallow such reviews. throw an error.



support/apply-reviews.py (lines 49 - 52)


i don't follow what's happening here. you are appending the same 
 pair multiple times to the list?



support/apply-reviews.py (line 56)


2 lines.



support/apply-reviews.py (line 75)


seems weird to have this function return the command if dry_run is true and 
None otherwise.

how about just prefixing "echo" to the command if dry_run is true?



support/apply-reviews.py (line 101)


s/print //


- Vinod Kone


On Oct. 18, 2015, 10:30 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> ---
> 
> (Updated Oct. 18, 2015, 10:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103150
---


This is great! Thanks! The current patch does not apply, can you do a rebase?

- Jie Yu


On Oct. 15, 2015, 11:23 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 15, 2015, 11:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 6f49e5ac77ab03248127a607664c8f895be72877 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 6368bf4caec6f8c3ac97282f41c55381f920bce9 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/paths.hpp  
>   

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Oct. 19, 2015, 8:11 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Changes
---

Adressed comments


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:10 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann

Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 8:39 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 8:58 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

> On Oct. 19, 2015, 7:27 p.m., Kapil Arya wrote:
> > src/slave/paths.cpp, lines 427-429
> > 
> >
> > Why not use the same `LOG(WARNING)` statement? That way the entire 
> > message will appear together instead of being sliced up by some other 
> > concurrent message.

Because a priori I don't know what `chown.error()` will emit (can be a 
multiline error, whatever) and so it may look pretty awful.
However, having looked at it - I've actually moved it to the end of the 
sentence, so it should still look good.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103148
---


On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated Oct. 19, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:14 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann

Review Request 39456: Documentation: added containerizer internals

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39456/
---

Review request for mesos and Timothy Chen.


Repository: mesos


Description
---

Documentation: added containerizer internals


Diffs
-

  docs/containerizer-internals.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39456/diff/


Testing
---


Thanks,

Jojy Varghese

Review Request 39457: [WIP] Document messages in messages.proto.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/
---

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3759
https://issues.apache.org/jira/browse/MESOS-3759


Repository: mesos


Description
---

Due to the heavy overlap between these messages and the comments in 
mesos/scheduler.hpp and v1/scheduler/scheduler.proto, these comments aim to 
document the backwards compatibility.  A brief summary of each message was 
added, as well as a reference to the appropriate Event/Call API object.


Diffs
-

  src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 

Diff: https://reviews.apache.org/r/39457/diff/


Testing
---

None.  (Comment change only)


Thanks,

Joseph Wu

Re: Review Request 39449: Documented order of includes.

[Jan Schlicht]

> On Oct. 19, 2015, 9:13 p.m., Marco Massenzio wrote:
> > docs/c++-style-guide.md, line 243
> > 
> >
> > I would specify what .ccp file is this example related to.
> > 
> > I think we have the 'related header' rule, where, if this where 
> > `master/flags.cpp` then `master/flags.hpp` should be included first.

Currently the related headers are not included first (contrary to the Google 
Style Doc), will add this behavior to the doc.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/#review103145
---


On Oct. 19, 2015, 8:58 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39449/
> ---
> 
> (Updated Oct. 19, 2015, 8:58 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-2275
> https://issues.apache.org/jira/browse/MESOS-2275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented order of includes.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/39449/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/
---

(Updated Oct. 19, 2015, 9:06 p.m.)


Review request for mesos and Ian Downes.


Bugs: https://issues.apache.org/jira/browse/MESOS-1563

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

Enable build on FreeBSD, start porting components.

My build steps are:

- Install dependencies from http://mesos.apache.org/gettingstarted/
- Install libexecinfo
- Install clang36 (system clang is 3.4)
- boostrap
- ../configure --with-curl=/usr/local --with-apr=/usr/local 
--with-svn=/usr/local CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36 check

I disabled one test because I haven't had a chance to debug it and I wanted to 
get a bit further in the test suite. A check run is attached.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
53e83d4905945593e174601a0b791d01824dc34b 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1c776cd2facfb86854c7b2a8fe6be7949b566587 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
1baf142d53fd06149c80d4b2677c2a976c05ef71 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
e9b05ef3b59fd068137cb12e36591de2d4a801a1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 
0a98e9e310d3931c2341053595b7d62f68214783 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
8a8ede325cfe8f024e1be4db24b0c8118d18f359 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
4cc781bddbf7ee10cc0671f62d710fb4fa80e293 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
  3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 
  3rdparty/libprocess/src/poll_socket.cpp 
28ed102972a9d8f88048aea4046ed837b6a25b35 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 
  configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 
  src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc 
  src/slave/containerizer/isolators/posix/disk.cpp 
73e62a225da062733557287afa2273d8183d76fd 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39345/diff/


Testing
---

make check on coreos (I'll get a ubuntu instance for future testing)

gmake check on freebsd 10.2 (failing) (log attached)


File Attachments (updated)


freebsd_check2.log
  
https://reviews.apache.org/media/uploaded/files/2015/10/19/5b62f825-006f-4316-b0a4-c1f39f9a__check2.log


Thanks,

David Forsythe

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103157
---


You probably want to move src/tests/containerizer too?

- Cong Wang


On Oct. 15, 2015, 11:23 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39360/
> ---
> 
> (Updated Oct. 15, 2015, 11:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relocate MesosContainerizer specific files to the correct location
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/examples/test_isolator_module.cpp 
> 577dfcac260b4f5df7ab4e9599e4caac46ccd1e1 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/cgroups/constants.hpp  
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> ba748c6caec7253b42167e8a4f9b4535da858259 
>   src/slave/containerizer/isolators/cgroups/mem.hpp  
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 6f49e5ac77ab03248127a607664c8f895be72877 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp  
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 93e85f2aa7bfceb7e55ff33bdc2e0e0a5cb8f880 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.hpp  
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.hpp  
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/isolators/namespaces/pid.hpp  
>   src/slave/containerizer/isolators/namespaces/pid.cpp 
> a9823e08b195b8df82de2a7b410a4e6ef99f8853 
>   src/slave/containerizer/isolators/network/helper.cpp 
> e5fb99e87ac16150b85b1c6f6965681f7fe77ce0 
>   src/slave/containerizer/isolators/network/port_mapping.hpp  
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/containerizer/isolators/posix.hpp  
>   src/slave/containerizer/isolators/posix/disk.hpp  
>   src/slave/containerizer/isolators/posix/disk.cpp 
> 73e62a225da062733557287afa2273d8183d76fd 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/provisioner/appc/paths.hpp  
>   src/slave/containerizer/provisioner/appc/paths.cpp 
> 8817c0ff4b6806f08afd322e250a9a53b7b0a5d6 
>   src/slave/containerizer/provisioner/appc/spec.hpp  
>   src/slave/containerizer/provisioner/appc/spec.cpp 
> bbe523d2ee1dd558cc5007e578cbf23abac8e1de 
>   src/slave/containerizer/provisioner/appc/store.hpp 
> e8455197dcc3f4c9856db20605f6862b8755a946 
>   src/slave/containerizer/provisioner/appc/store.cpp 
> a5ef4ea7cd08423360120430833c5881053637f5 
>   src/slave/containerizer/provisioner/backend.hpp  
>   src/slave/containerizer/provisioner/backend.cpp 
> b5d96701ae6bd49365b169f4e5150b8c4dae1870 
>   src/slave/containerizer/provisioner/backends/bind.hpp 
> 1685938fb4349e790b9595cc4c67584c7f31a392 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 7a5aaa41d8f6842ef437ed7a34235d8baac4bfff 
>   src/slave/containerizer/provisioner/backends/copy.cpp 
> 92fb0988da0bdd5a2b5a5f53ab61b7bb19c61cda 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp 
> 4574e8a04663482625d7b54f765741f221ec13e0 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 74d0e1ead7d630e65a7e75cb6123139b9197efef 
>   src/slave/containerizer/provisioner/docker/message.hpp 
> 6368bf4caec6f8c3ac97282f41c55381f920bce9 
>   src/slave/containerizer/provisioner/docker/message.proto  
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> 885080dbd3603f8c71ac867b88edcfd22276567f 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> 2b2de5245bccbd01a856b214ac6525278d794537 
>   src/slave/containerizer/provisioner/docker/paths.hpp  
>   

Re: Review Request 39449: Documented order of includes.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/
---

(Updated Oct. 19, 2015, 11:20 p.m.)


Review request for mesos and Michael Park.


Changes
---

Addressed issues. Headers are included alphabetically.


Bugs: MESOS-2275
https://issues.apache.org/jira/browse/MESOS-2275


Repository: mesos


Description
---

Documented order of includes.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 

Diff: https://reviews.apache.org/r/39449/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/
---

(Updated Oct. 19, 2015, 9:27 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-3692
https://issues.apache.org/jira/browse/MESOS-3692


Repository: mesos


Description
---

MESOS-3692 - better documented --switch_user flag
Added better logging around the point where the error may occur.


Diffs (updated)
-

  docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
  src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 

Diff: https://reviews.apache.org/r/39447/diff/


Testing
---

make check


Thanks,

Marco Massenzio

Re: Review Request 39455: Added documentation for asynchronous pimpl pattern used in libprocess

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39455/#review103160
---



3rdparty/libprocess/README.md (line 49)


Space after "process".



3rdparty/libprocess/README.md (line 77)


All on one line?



3rdparty/libprocess/README.md (line 99)


We are "using namespace process;", so process:: prefix is unnecessary.



3rdparty/libprocess/README.md (line 102)


Probably should return a value, although not required by C++.



3rdparty/libprocess/README.md (line 107)


Should we use EXPECT_TRUE / ASSERT_TRUE instead?



3rdparty/libprocess/README.md (line 116)


Link to dispatch?


- Neil Conway


On Oct. 19, 2015, 9:17 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39455/
> ---
> 
> (Updated Oct. 19, 2015, 9:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39455/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/76a7619ba7b892dd0542
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 1:26 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes typo, highlighting, bullet points


Diffs (updated)
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 8:48 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 1:48 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes typo, highlighting, bullet points


Diffs (updated)
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

> On Oct. 19, 2015, 7:35 p.m., Michael Park wrote:
> > Thanks for doing this! It's definitely clearer (at least to me) as to what 
> > this flag is controlling.
> > 
> > A few general comments here:
> > (1) We should be using ``` in some of the cases instead of `'` right? It 
> > seems to be a bit inconsistent currently.
> > (2) Based on existing documentation, I don't think we should go out of our 
> > way to capitalize `Agent`.

agreed - tried to use `` consistently, and replaced '


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103146
---


On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated Oct. 19, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103152
---

Ship it!



docs/scheduler-http-api.md (line 59)


independent


- Joerg Schad


On Oct. 19, 2015, 7:59 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 7:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Oct. 19, 2015, 9:07 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:07 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/
---

(Updated Oct. 19, 2015, 9:19 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, 
MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693


Repository: mesos


Description
---

CMake: Added `slave/state.cpp` to Windows builds.


Diffs (updated)
-

  CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776 
  src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 

Diff: https://reviews.apache.org/r/39220/diff/


Testing
---

Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39375: Windows: Introduced socket flag interop.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/
---

(Updated Oct. 19, 2015, 9:19 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

POSIX has a bunch of flags like `SHUT_SD` which let you do things like
specify (e.g.) how a socket shuts down. Windows has equivalents for many
of these flags as well, but they have different names.

So that we can avoid changing any of the socket code, we alias the flags
we know we need with their POSIX names.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
4a0761f4bdd6a881429cb25d0a5f6e445da405cb 

Diff: https://reviews.apache.org/r/39375/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103163
---

Ship it!


Ship It!

- Guangya Liu


On 十月 19, 2015, 9:27 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated 十月 19, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Review Request 39446: Fixed typos in libprocess docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39446/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Fixed typos in libprocess docs.


Diffs
-

  3rdparty/libprocess/README.md 79304af8ff2bcf29ed0704acadb17b38c09596c4 

Diff: https://reviews.apache.org/r/39446/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 38117: Export per container SNMP statistics

[Cong Wang]

> On Oct. 16, 2015, 6 p.m., Ian Downes wrote:
> > include/mesos/mesos.proto, lines 702-720
> > 
> >
> > Are the statistics signed? If not, suggest using uint64 type.

Yes, I used uint64 initially and then noticed some TCP stat is -1. :)


> On Oct. 16, 2015, 6 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1171-1174
> > 
> >
> > Do these inside the parsing loop as you parse each line pair for a 
> > statistics type.

The problem is we don't expose all SNMP stats from kernel here, for example we 
don't care about UDPlite.


> On Oct. 16, 2015, 6 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1140-1141
> > 
> >
> > Clearer to just declare these inside the loop scope (but my suggestions 
> > below obviate them anyway).

If declared inside the loop, its value can't be kept for the next loop, right? 
We need to at least keep keys across one loop.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review102933
---


On Sept. 8, 2015, 9:12 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> ---
> 
> (Updated Sept. 8, 2015, 9:12 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone.
> 
> 
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These stats are those we get by `netstat -s`, they are important for diagnose 
> networking issues.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 34ba2294b0bd7d57aa9de073692a2ea8ec62681d 
>   src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
>   src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d 
> 
> Diff: https://reviews.apache.org/r/38117/diff/
> 
> 
> Testing
> ---
> 
> Manual tests
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes type, highlighting, bullet points


Diffs
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 39444: Fixed typo in docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39444/
---

(Updated Oct. 19, 2015, 5:53 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-3757
https://issues.apache.org/jira/browse/MESOS-3757


Repository: mesos


Description
---

MESOS-3757.


Diffs
-

  docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 

Diff: https://reviews.apache.org/r/39444/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/
---

(Updated Oct. 19, 2015, 7:06 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Added better logging around the point where the error may occur


Bugs: MESOS-3692
https://issues.apache.org/jira/browse/MESOS-3692


Repository: mesos


Description (updated)
---

MESOS-3692 - better documented --switch_user flag
Added better logging around the point where the error may occur.


Diffs (updated)
-

  docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
  src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 

Diff: https://reviews.apache.org/r/39447/diff/


Testing (updated)
---

make check


Thanks,

Marco Massenzio

Re: Review Request 39449: Documented order of includes.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/#review103145
---



docs/c++-style-guide.md (line 241)


s/seperate/separate



docs/c++-style-guide.md (line 243)


I would specify what .ccp file is this example related to.

I think we have the 'related header' rule, where, if this where 
`master/flags.cpp` then `master/flags.hpp` should be included first.


- Marco Massenzio


On Oct. 19, 2015, 6:58 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39449/
> ---
> 
> (Updated Oct. 19, 2015, 6:58 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-2275
> https://issues.apache.org/jira/browse/MESOS-2275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented order of includes.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/39449/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 39444: Fixed typo in docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39444/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

MESOS-3757.


Diffs
-

  docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 

Diff: https://reviews.apache.org/r/39444/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 39423: Fixed `ExamplesTest.PersistentVolumeFramework` on OS X El Capitan.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39423/#review103143
---

Ship it!


Ship It!

- Jie Yu


On Oct. 19, 2015, 2:39 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39423/
> ---
> 
> (Updated Oct. 19, 2015, 2:39 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Till Toenshoff.
> 
> 
> Bugs: MESOS-3604
> https://issues.apache.org/jira/browse/MESOS-3604
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `MESOS_LAUNCHER_DIR` was being set to `/src/.libs` rather than 
> `/src`. This leads to us attemping to execute 
> `/src/.libs/mesos-executor` which doesn't have the correct 
> `DYLD_LIBRARY_PATH` set.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> 426d33813f8f17397c6ed29b8a8b33df4137bba6 
> 
> Diff: https://reviews.apache.org/r/39423/diff/
> 
> 
> Testing
> ---
> 
> ```
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from ExamplesTest
> [ RUN  ] ExamplesTest.PersistentVolumeFramework
> [   OK ] ExamplesTest.PersistentVolumeFramework (3391 ms)
> [--] 1 test from ExamplesTest (3391 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (3403 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103142
---


Patch looks great!

Reviews applied: [39447]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated Oct. 19, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103148
---

Ship it!


Gave it a go :)


docs/configuration.md (line 1441)


The "(its default value)" is redundant wrt "(default: true)" at the end of 
the help message. Can we kill this?

s/ the Agent/, the Agent/



docs/configuration.md (line 1444)


Kill `obviously`?



docs/configuration.md (line 1445)


s/exist a/exist, a/



src/slave/flags.cpp (lines 166 - 169)


Same comments as for the doc.



src/slave/paths.cpp (lines 427 - 429)


Why not use the same `LOG(WARNING)` statement? That way the entire message 
will appear together instead of being sliced up by some other concurrent 
message.


- Kapil Arya


On Oct. 19, 2015, 3:06 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated Oct. 19, 2015, 3:06 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39446: Fixed typos in libprocess docs.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39446/#review103137
---

Ship it!


Ship It!

- Till Toenshoff


On Oct. 19, 2015, 6:12 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39446/
> ---
> 
> (Updated Oct. 19, 2015, 6:12 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in libprocess docs.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 79304af8ff2bcf29ed0704acadb17b38c09596c4 
> 
> Diff: https://reviews.apache.org/r/39446/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39446: Fixed typos in libprocess docs.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39446/#review103138
---

Ship it!


Ship It!

- Benjamin Hindman


On Oct. 19, 2015, 6:12 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39446/
> ---
> 
> (Updated Oct. 19, 2015, 6:12 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in libprocess docs.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 79304af8ff2bcf29ed0704acadb17b38c09596c4 
> 
> Diff: https://reviews.apache.org/r/39446/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-3692
https://issues.apache.org/jira/browse/MESOS-3692


Repository: mesos


Description
---

MESOS-3692 - better documented --switch_user flag


Diffs
-

  docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 

Diff: https://reviews.apache.org/r/39447/diff/


Testing
---


Thanks,

Marco Massenzio

Review Request 39449: Documented order of includes.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/
---

Review request for mesos and Michael Park.


Bugs: MESOS-2275
https://issues.apache.org/jira/browse/MESOS-2275


Repository: mesos


Description
---

Documented order of includes.


Diffs
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 

Diff: https://reviews.apache.org/r/39449/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103146
---


Thanks for doing this! It's definitely clearer (at least to me) as to what this 
flag is controlling.

A few general comments here:
(1) We should be using ``` in some of the cases instead of `'` right? It seems 
to be a bit inconsistent currently.
(2) Based on existing documentation, I don't think we should go out of our way 
to capitalize `Agent`.


docs/configuration.md (line 1441)


`s/(its default value)//`



docs/configuration.md (line 1443)


> rather than the one running the Agent

Let's just mention this once in the `false` case.



docs/configuration.md (line 1444)


`s/, obviously,//`



docs/configuration.md (line 1445)


`s/exist/exist,/`



docs/configuration.md (line 1446)


How about we keep it symmetric? i.e. `If set to `true`, ... . If set to 
`false`, ... .`?


- Michael Park


On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated Oct. 19, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 12:49 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description (updated)
---

Fix double dashes typo, highlighting, bullet points


Diffs
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

[Michael Park]

> On Oct. 18, 2015, 11:02 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 182-189
> > 
> >
> > Indent 2 spaces, not the strings themselves, but within the strings.
> 
> Klaus Ma wrote:
> The 2 sparces indent are in the strings, do you mean we should move it 
> out?

I mean at the `[ ... ]` level:

```cpp
"["
"  {"
"\"id\": \"message1\","
"\"numbers\": [1, 2]"
"  },"
"  {"
"\"id\": \"message2\","
"\"numbers\": [1, 2]"
"  }"
"]"
```


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review103078
---


On Oct. 16, 2015, 9:56 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> ---
> 
> (Updated Oct. 16, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 
> 
> Diff: https://reviews.apache.org/r/38342/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

[Michael Park]

> On Oct. 18, 2015, 11:02 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 764-768
> > 
> >
> > As mentioned before, let's remove the `default` case entirely. Refer to 
> > [MESOS-3754](https://issues.apache.org/jira/browse/MESOS-3754) for details.
> 
> Klaus Ma wrote:
> I just remove `default:` becase keep `ABORT` for deprecated case 
> (`google::protobuf::FieldDescriptor::TYPE_GROUP:`).

Yep, that's good. Thanks.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review103078
---


On Oct. 16, 2015, 9:56 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> ---
> 
> (Updated Oct. 16, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 
> 
> Diff: https://reviews.apache.org/r/38342/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/
---

(Updated Oct. 19, 2015, 10:21 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-3692
https://issues.apache.org/jira/browse/MESOS-3692


Repository: mesos


Description
---

MESOS-3692 - better documented --switch_user flag
Added better logging around the point where the error may occur.


Diffs (updated)
-

  docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
  src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 

Diff: https://reviews.apache.org/r/39447/diff/


Testing
---

make check


Thanks,

Marco Massenzio

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/#review103176
---



docs/docker-containerizer.md (lines 22 - 23)


According to 
http://mesos.apache.org/documentation/latest/markdown-style-guide/, I think we 
should still wrap the command in ```.



docs/docker-containerizer.md (line 63)


Another instance of `.dockercfg` to be wrapped in ```?



docs/docker-containerizer.md (line 79)


`s/docker_mesos_image/--docker_mesos_image/`?


- Michael Park


On Oct. 19, 2015, 8:48 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39451/
> ---
> 
> (Updated Oct. 19, 2015, 8:48 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix double dashes typo, highlighting, bullet points
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/39451/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

> On Oct. 19, 2015, 10:09 p.m., Michael Park wrote:
> > docs/configuration.md, line 1445
> > 
> >
> > `\Could not chown work directory\` -- is this intentional? If yes, what 
> > does it do...?

good catch!
copy & paste & find & replace fail :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103170
---


On Oct. 19, 2015, 9:27 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated Oct. 19, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/#review103177
---


Patch looks great!

Reviews applied: [39451]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 8:48 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39451/
> ---
> 
> (Updated Oct. 19, 2015, 8:48 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix double dashes typo, highlighting, bullet points
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/39451/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/#review103180
---


Bad patch!

Reviews applied: [39345]

Failed command: ./support/apply-review.sh -n -r 39345

Error:
 2015-10-19 22:50:43 URL:https://reviews.apache.org/r/39345/diff/raw/ 
[26664/26664] -> "39345.patch" [1]
Successfully applied: Enable build on FreeBSD, start porting components.

Enable build on FreeBSD, start porting components.

My build steps are:

- Install dependencies from http://mesos.apache.org/gettingstarted/
- Install libexecinfo
- Install clang36 (system clang is 3.4)
- boostrap
- ../configure --with-curl=/usr/local --with-apr=/usr/local 
--with-svn=/usr/local CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36 check

I disabled one test because I haven't had a chance to debug it and I wanted to 
get a bit further in the test suite. A check run is attached.


Review: https://reviews.apache.org/r/39345
Checking 20 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  configure.ac
  src/Makefile.am
  src/slave/containerizer/isolators/posix/disk.cpp
  src/tests/attributes_tests.cpp
  src/tests/resources_tests.cpp
  src/tests/values_tests.cpp
stout:
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
libprocess:
  3rdparty/libprocess/3rdparty/Makefile.am
  3rdparty/libprocess/configure.ac
  3rdparty/libprocess/src/poll_socket.cpp
  3rdparty/libprocess/src/tests/http_tests.cpp
Failed to commit patch

- Mesos ReviewBot


On Oct. 19, 2015, 9:06 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39345/
> ---
> 
> (Updated Oct. 19, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-1563
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable build on FreeBSD, start porting components.
> 
> My build steps are:
> 
> - Install dependencies from http://mesos.apache.org/gettingstarted/
> - Install libexecinfo
> - Install clang36 (system clang is 3.4)
> - boostrap
> - ../configure --with-curl=/usr/local --with-apr=/usr/local 
> --with-svn=/usr/local CC=clang36 CXX=clang++36
> - gmake CC=clang36 CXX=clang++36
> - gmake CC=clang36 CXX=clang++36 check
> 
> I disabled one test because I haven't had a chance to debug it and I wanted 
> to get a bit further in the test suite. A check run is attached.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 53e83d4905945593e174601a0b791d01824dc34b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> dc7c6522b283916b975a77957909f6cdc02944d3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 9428717fac4655898d7768957f02937592e1a398 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 1c776cd2facfb86854c7b2a8fe6be7949b566587 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
> 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 1baf142d53fd06149c80d4b2677c2a976c05ef71 
>   

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39388/#review103182
---

Ship it!


See comments below :)


src/tests/containerizer/docker_containerizer_tests.cpp (line 504)


Mind adding a comment about the test sequence? Why does the 'test 
$LIBPROCESS_IP = \"foobar"\' work, etc.



src/tests/containerizer/docker_containerizer_tests.cpp (lines 509 - 510)


No biggie; but could we have done the creation of the mock docker inline in 
line 512? The first thing that came to my mind was that we were leaking the 
object.



src/tests/containerizer/docker_containerizer_tests.cpp (line 518)


Can we make this assumption (do we have other places where we assume 
localhost is always 127.0.0.1)?


- Niklas Nielsen


On Oct. 17, 2015, 4:18 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39388/
> ---
> 
> (Updated Oct. 17, 2015, 4:18 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3740
> https://issues.apache.org/jira/browse/MESOS-3740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
> 
> Diff: https://reviews.apache.org/r/39388/diff/
> 
> 
> Testing
> ---
> 
> Added `DockerContainerizerTest.ROOT_DOCKER_LaunchWithLibprocessIP` test which 
> fails without the changes made to `src/docker/docker.cpp`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/
---

(Updated Oct. 19, 2015, 11:55 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Updated the message to reflect that the task fails.


Bugs: MESOS-3692
https://issues.apache.org/jira/browse/MESOS-3692


Repository: mesos


Description
---

MESOS-3692 - better documented --switch_user flag
Added better logging around the point where the error may occur.


Diffs (updated)
-

  docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
  src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 

Diff: https://reviews.apache.org/r/39447/diff/


Testing
---

make check


Thanks,

Marco Massenzio

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

[Michael Park]

> On Oct. 19, 2015, 11:22 p.m., Niklas Nielsen wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, line 504
> > 
> >
> > Mind adding a comment about the test sequence? Why does the 'test 
> > $LIBPROCESS_IP = \"foobar"\' work, etc.

Yep, will do.


> On Oct. 19, 2015, 11:22 p.m., Niklas Nielsen wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, lines 509-510
> > 
> >
> > No biggie; but could we have done the creation of the mock docker 
> > inline in line 512? The first thing that came to my mind was that we were 
> > leaking the object.

Probably, I'll look into it a bit more. I followed the pattern of existing 
tests so I'll perhaps update those correspondingly.


> On Oct. 19, 2015, 11:22 p.m., Niklas Nielsen wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, line 518
> > 
> >
> > Can we make this assumption (do we have other places where we assume 
> > localhost is always 127.0.0.1)?

The choice of `127.0.0.1` is arbitrary here. We could've assigned it to `x`, 
and performed `test $LIBPROCESS_IP = x` instead.
Actually, I'll pull it out to a variable and leave a comment in line with what 
I described here.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39388/#review103182
---


On Oct. 17, 2015, 11:18 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39388/
> ---
> 
> (Updated Oct. 17, 2015, 11:18 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3740
> https://issues.apache.org/jira/browse/MESOS-3740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
> 
> Diff: https://reviews.apache.org/r/39388/diff/
> 
> 
> Testing
> ---
> 
> Added `DockerContainerizerTest.ROOT_DOCKER_LaunchWithLibprocessIP` test which 
> fails without the changes made to `src/docker/docker.cpp`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39378/
---

(Updated Oct. 19, 2015, 11:31 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3649 and MESOS-3680
https://issues.apache.org/jira/browse/MESOS-3649
https://issues.apache.org/jira/browse/MESOS-3680


Repository: mesos


Description
---

Windows: Added support for `process/subprocess.hpp`.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
d2341a53aac7c779668ee80983f73158fd44bff5 

Diff: https://reviews.apache.org/r/39378/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

(Updated Oct. 19, 2015, 5:42 p.m.)


Review request for mesos, Adam B and Dave Lester.


Changes
---

Addressing comments.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/site-docker/Dockerfile PRE-CREATION 
  support/site-docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

(Updated Oct. 19, 2015, 5:15 p.m.)


Review request for mesos and Adam B.


Changes
---

Addressed comments.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/site-docker/Dockerfile PRE-CREATION 
  support/site-docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39447/#review103170
---



docs/configuration.md (line 1442)


How about `s/submitted/launched/`?



docs/configuration.md (line 1445)


`\Could not chown work directory\` -- is this intentional? If yes, what 
does it do...?



docs/configuration.md (line 1448)


`s/Agent/agent/`



src/slave/paths.cpp (line 427)


`s/non existing/nonexistent/`
`s/Agent/agent/`



src/slave/paths.cpp (line 428)


Wrap `--switch_user` in ```


- Michael Park


On Oct. 19, 2015, 9:27 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39447/
> ---
> 
> (Updated Oct. 19, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3692
> https://issues.apache.org/jira/browse/MESOS-3692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3692 - better documented --switch_user flag
> Added better logging around the point where the error may occur.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/39447/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 3:29 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes typo, highlighting, bullet points


Diffs (updated)
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103186
---



support/site-docker/README.md (line 13)


How about something like `` or `` 
instead of `/home/me/dev/mesos`?



support/site-docker/README.md (line 16)


`s/yout/your/`



support/site-docker/README.md (line 18)


`s/OSX/OS X/`
`docker VM` -- my guess is that this is referring to boot-to-docker stuff, 
might be worth mentioning it?


- Michael Park


On Oct. 20, 2015, 12:26 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 20, 2015, 12:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

[Neil Conway]

> On Oct. 19, 2015, 10:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/README.md, line 378
> > 
> >
> > Nit, How about:
> > 
> > ```A process that initiates
> > an asynchronous operation would like to know if the operation hasn't 
> > completed
> > within a certain time bound. To facilitate this, libprocess provides a 
> > set of
> > abstractions that simplify writing timeout logic.```

I was trying to support the idea that you can use timeouts for lots of things, 
although pursuing an alternative after an operation hasn't completed is a 
common case. Happy to change if you think your text is clearer though.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review103179
---


On Oct. 19, 2015, 11:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated Oct. 19, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/
---

(Updated Oct. 19, 2015, 11:26 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3649
https://issues.apache.org/jira/browse/MESOS-3656


Repository: mesos


Description
---

Windows: Add Windows support to `process/socket.hpp`.


Diffs
-

  3rdparty/libprocess/include/process/socket.hpp 
4b2597f617fc4072144c9666a378d4ffad53a592 
  3rdparty/libprocess/src/poll_socket.cpp 
28ed102972a9d8f88048aea4046ed837b6a25b35 

Diff: https://reviews.apache.org/r/39377/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39376: Windows: Prepared agent for Windows support of `process/socket.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39376/
---

(Updated Oct. 19, 2015, 11:25 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

In particular, we will remove the inclusion of `stout/os.hpp` from
`process/socket.hpp`, which will cause  a couple of files to break. Our
solution to this problem is to include `os.hpp` directly in those files.


Diffs (updated)
-

  src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a 
  src/slave/containerizer/composing.cpp 
8c3a2353999523ef055332320443931b61843d21 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
6f49e5ac77ab03248127a607664c8f895be72877 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 
  src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f 

Diff: https://reviews.apache.org/r/39376/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39381/
---

(Updated Oct. 19, 2015, 11:27 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3610
https://issues.apache.org/jira/browse/MESOS-3610


Repository: mesos


Description
---

CMake: Added protobuf and `slave/flags.cpp` to Windows builds.


Diffs (updated)
-

  src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 

Diff: https://reviews.apache.org/r/39381/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
---

(Updated Oct. 19, 2015, 11:27 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
e64aa6baeab9d816bb42242e3c9234d4da80f401 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1c776cd2facfb86854c7b2a8fe6be7949b566587 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
eaeed7393b1c44f04737e18cd90a6fc292aa061d 

Diff: https://reviews.apache.org/r/39382/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39380/
---

(Updated Oct. 19, 2015, 11:27 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Added support for `stout/flags/flags.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
b91318cfd5748b3387bb6b32b910f327853274dd 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
e34ed78386130a1e757be1b1f1a2dbf794b7cd37 

Diff: https://reviews.apache.org/r/39380/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39375: Windows: Introduced socket flag interop.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39375/
---

(Updated Oct. 19, 2015, 11:25 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

POSIX has a bunch of flags like `SHUT_SD` which let you do things like
specify (e.g.) how a socket shuts down. Windows has equivalents for many
of these flags as well, but they have different names.

So that we can avoid changing any of the socket code, we alias the flags
we know we need with their POSIX names.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
4a0761f4bdd6a881429cb25d0a5f6e445da405cb 

Diff: https://reviews.apache.org/r/39375/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Review Request 39463: Fixed typos in log messages and comments in replicated log code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39463/
---

Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Timothy 
Chen.


Repository: mesos


Description
---

Fixed typos in log messages and comments in replicated log code.


Diffs
-

  src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
  src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
  src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
  src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
  src/state/log.cpp a75a605a4b0edb8863a3378e2133df7d6eb1cc3d 
  src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
  src/tests/slave_tests.cpp 10a4fa7eaa8e868ccc6d60ac220d66a4f0a523b4 

Diff: https://reviews.apache.org/r/39463/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/
---

(Updated Oct. 19, 2015, 11:37 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Summary (updated)
-

CMake: Added subset of agent target in Windows builds.


Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, 
MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693


Repository: mesos


Description
---

CMake: Added `slave/state.cpp` to Windows builds.


Diffs
-

  CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776 
  src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 

Diff: https://reviews.apache.org/r/39220/diff/


Testing
---

Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103191
---

Ship it!


Ship It!

- Guangya Liu


On 十月 20, 2015, 12:42 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated 十月 20, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/#review103206
---


Bad patch!

Reviews applied: [39375, 39376, 39377, 39378, 39379, 39380, 39381]

Failed command: ./support/apply-review.sh -n -r 39381

Error:
 2015-10-20 04:23:01 URL:https://reviews.apache.org/r/39381/diff/raw/ [760/760] 
-> "39381.patch" [1]
error: patch failed: src/CMakeLists.txt:166
error: src/CMakeLists.txt: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 19, 2015, 11:37 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39220/
> ---
> 
> (Updated Oct. 19, 2015, 11:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, 
> MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3627
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3629
> https://issues.apache.org/jira/browse/MESOS-3630
> https://issues.apache.org/jira/browse/MESOS-3631
> https://issues.apache.org/jira/browse/MESOS-3633
> https://issues.apache.org/jira/browse/MESOS-3658
> https://issues.apache.org/jira/browse/MESOS-3659
> https://issues.apache.org/jira/browse/MESOS-3660
> https://issues.apache.org/jira/browse/MESOS-3693
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added `slave/state.cpp` to Windows builds.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776 
>   src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 
> 
> Diff: https://reviews.apache.org/r/39220/diff/
> 
> 
> Testing
> ---
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, 
> Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on 
> Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/
---

(Updated Oct. 20, 2015, 5:37 a.m.)


Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.


Changes
---

Address comments


Bugs: MESOS-3405
https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
---

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
converts a `google::protobuf::Message` into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField` by 
introducing overloaded functions.


Diffs (updated)
-

  src/common/http.cpp f56d8a1 
  src/docker/executor.cpp 1e49013 
  src/examples/persistent_volume_framework.cpp 176ac3d 
  src/launcher/executor.cpp 50b3c6e 
  src/master/contender.cpp c641305 
  src/master/http.cpp 093f793 
  src/master/maintenance.cpp 5fe9358 
  src/master/registrar.cpp 1117232 
  src/slave/containerizer/fetcher.cpp e0d02d5 
  src/slave/containerizer/mesos/containerizer.cpp d1fc5a4 
  src/slave/monitor.cpp aa6e958 
  src/tests/containerizer/launch_tests.cpp de655ec 
  src/tests/fault_tolerance_tests.cpp f78a291 
  src/tests/master_maintenance_tests.cpp e89ce3b 
  src/tests/master_tests.cpp ee24739 
  src/tests/mesos.hpp 3e58b45 
  src/tests/mesos.cpp ab2d85b 
  src/tests/monitor_tests.cpp 583e711 
  src/tests/reservation_endpoints_tests.cpp f5f9c48 
  src/tests/resources_tests.cpp 6584fc6 
  src/tests/scheduler_http_api_tests.cpp d338a1b 
  src/tests/script.cpp bcc1fab 
  src/tests/slave_tests.cpp 10a4fa7 
  src/usage/main.cpp 86fd796 

Diff: https://reviews.apache.org/r/38335/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Ben Whitehead]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103194
---



docs/scheduler-http-api.md (lines 28 - 36)


This text isn't helpful.

I wanted a grammar that defined what the RecordIO format was, having the 
formal grammar removes any subtelties of examples.

Here is a grammar that reflects RecordIO:

```
records = *record

record  = record-size LF
  record-data

record-size = 1*DIGIT
record-data = record-size(OCTET)
```

`record-size` should be interpreted as an unsigned 64-bit integer (uint64)



docs/scheduler-http-api.md (lines 38 - 57)


The rest of the HTTP API Documentation is language agnostic and I feel 
strongly that it should be kept that way.

Please remove this example. In the future when there are implementations 
available they can be linked to in an appendix.



docs/scheduler-http-api.md (line 59)


+1


- Ben Whitehead


On Oct. 19, 2015, 2:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 2:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39456: Documentation: added containerizer internals

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39456/#review103197
---


Patch looks great!

Reviews applied: [39456]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 10:18 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39456/
> ---
> 
> (Updated Oct. 19, 2015, 10:18 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation: added containerizer internals
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39456/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103208
---



support/apply-reviews.py (line 23)


hey, as mentioned, could you please remove whitespace around `=` in args 
call (and default params)

here and everywhere.

thanks!



support/apply-reviews.py (line 27)


is this right? by looking at the args names, looks like it returns the URL 
of a PR given its number?

either the comment or the args names are wrong.

also, I would much prefer `pull_request_number`



support/apply-reviews.py (line 44)


could you please add an @param and explain what `options` is and what does 
it look like?
(also an @type would be awesome)



support/apply-reviews.py (lines 46 - 47)


is this dead code? please remove.



support/apply-reviews.py (line 48)


this will cause a KeyError if `reveiw_id` is not there.
you can achieve the same result (but better) with:
```
if options.get('review_id'):
```
(this also protects you further below in the call to `format`)



support/apply-reviews.py (line 97)


```
if not options or 'dry_run' not in options:
```



support/apply-reviews.py (line 103)


it would be really nice if we could make our code work under both 2.7 and 
3.x Python ;)



support/apply-reviews.py (line 133)


this line exceeds 100 char (I'm almost sure)
you can break it using \

or, even better, build the command via string.join():
```
' '.join(['wget',
  '--no-check-certificate',
  '--no-verbose',
  '-O {}.patch'.format(patch_id(options)),
  patch_url(options)])
```



support/apply-reviews.py (line 136)


s/beacuse/because



support/apply-reviews.py (line 145)


unnecessary parentheses; also, please use `get()` instead of `[]`
(unless you are terminally positive both keys are there every time)



support/apply-reviews.py (line 156)


you don't really need to escape the quotes, just take advantage of Python 
being able to use single and double quotes interchangeably (or even use """ if 
you really want to be hip :)



support/apply-reviews.py (lines 179 - 181)


this looks a bit ugly - prefer:
```
message = '{summary}\n\n{description}\n\nThis closes: {pr}'.
format(summary=title, description=description, pr=pr_number)
```



support/apply-reviews.py (lines 184 - 188)


no space before `:`

(also, it's more "pythonic" to use double quotes for the dict's keys - but 
really a micro-nit!)



support/apply-reviews.py (lines 200 - 205)


could you please reformat this code to something more readable?
```
username = review.get('links').get('submitter').get('title')
user = url_to_json(user_url(username)).get('user')
url = review_url(rid)
author = '{author} {email}'.format(author=user.get('fullname'), 
   email=user.get('email'))
message = '\n\n'.join([review.get('summary'),
   review.get('description'),
   'Review: {}'.format(url)
```



support/apply-reviews.py (lines 251 - 255)


Much better:
```  
options = {
'review_id': args.review_id,
'dry_run': args.dry_run,
'no_amend': args.no_amend,
'github': args.github
}
```
or if you really want to be pythonic:
```
options = dict()
for k in ['review_id', 'dry_run', 'no_amend', 'github']:
options[k] = args.getattr(k)
```
although, I'm not sure right now if this will work with your having made 
`github` and `review_id` mutually exclusive (but, then again, the dotted 
notation should blow up too if the arg is not there?)



support/apply-reviews.py (lines 265 - 270)


this code look familiar and I remember already commenting about `applied` :)


- Marco Massenzio


On Oct. 18, 2015, 10:32 p.m., Artem Harutyunyan wrote:
> 
> 

Re: Review Request 39018: Added JSON parsing for Resources.

[Greg Mann]

> On Oct. 18, 2015, 12:41 a.m., Michael Park wrote:
> > src/common/resources.cpp, line 377
> > 
> >
> > I think you need to check for `resource.role() == "*"` instead, since 
> > `role` has `[default = "*"]`. Please verify.

The `has_field` methods return false if the default value was used to 
initialize the message; I checked this to be sure. This has the added benefit 
that the method doesn't need to hard-code the protobuf's default role.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/#review103042
---


On Oct. 20, 2015, 5:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> ---
> 
> (Updated Oct. 20, 2015, 5:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes code changes necessary for JSON parsing of Resources. 
> Documentation changes will be posted soon in another review 
> (https://reviews.apache.org/r/39102/).
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39018/diff/
> 
> 
> Testing
> ---
> 
> New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were 
> added: `ResourcesTest.ParsingFromJSONWithRoles` and 
> `ResourcesTest.ParsingFromJSONError`. These attempt to test common error 
> scenarios that might show up in user-supplied JSON.
> 
> `make check` was used to confirm that all tests pass, with one notable 
> failure (ResourcesTest.ParsingFromJSONError) related to a picojson issue 
> tracked here: https://issues.apache.org/jira/browse/MESOS-3698
> 
> The original resources parsing format is used throughout many other tests 
> (check `src/tests/sorter_tests.cpp`, for example), so it's clear that the 
> original parsing continues to work correctly.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39223: WIP Added Quota Request Validation Tests.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/
---

(Updated Oct. 20, 2015, 2:15 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Changes
---

Adressed reviews.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Right now intented for TDD.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39223/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review103199
---


Patch looks great!

Reviews applied: [39459]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 11:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated Oct. 19, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39455: Added documentation for asynchronous pimpl pattern used in libprocess

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39455/#review103204
---



3rdparty/libprocess/README.md (lines 76 - 77)


Can we merge those two lines to one?


- Guangya Liu


On 十月 19, 2015, 10:05 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39455/
> ---
> 
> (Updated 十月 19, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39455/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/76a7619ba7b892dd0542
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 39018: Added JSON parsing for Resources.

[Greg Mann]

> On Oct. 18, 2015, 6:18 p.m., Michael Park wrote:
> > src/common/resources.cpp, lines 482-532
> > 
> >
> > How about a structure like the following?
> > 
> > ```cpp
> > Resources result;
> > 
> > // Populate `result` based on which format.
> > Try resourcesJSON = JSON::parse(text);
> > if (resourcesJSON.isSome()) {
> >   result = internal::convertJSON(resourcesJSON.get(), defaultRole);
> > } else {
> >   foreach (...) {
> > ...
> > result += resource.get();
> >   }
> > }
> > 
> > // Validate the result regardless of what format
> > Option validate = validateCommandLineResources(result);
> > if (validate.isSome()) {
> >   return validate.get();
> > }
> > 
> > return result;
> > ```
> > 
> > `validateCommandLineResources` is as suggested before, with the 
> > `conflictingTypes` logic encapsulated within it.
> > 
> > I noticed we only perform the minimal validation necessary for the 
> > semicolon-delimited string format currently.
> > That is, we only do the `conflictingTypes` check. While this is 
> > sufficient in the current state of the format,
> > I think it simplifies the code to just do the full check. It's also 
> > future-proof if we need to extend the string format later on.

Yep I agree that this is cleaner. I implemented it and unfortunately, since 
`internal::convertJSON` returns a `Try`, we have to unwrap the Try 
before assigning it to `result`. We could get around this by wrapping the `if 
... else` block in a lambda and assigning the result to a `Try 
result`. In that case, however, we end up wrapping the old-style parsed 
resources in a `Try` unnecessarily, so we do extra work either way. I think the 
current version (without the lambda) is a bit more readable, so I went with 
that one.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/#review103063
---


On Oct. 20, 2015, 5:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> ---
> 
> (Updated Oct. 20, 2015, 5:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes code changes necessary for JSON parsing of Resources. 
> Documentation changes will be posted soon in another review 
> (https://reviews.apache.org/r/39102/).
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39018/diff/
> 
> 
> Testing
> ---
> 
> New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were 
> added: `ResourcesTest.ParsingFromJSONWithRoles` and 
> `ResourcesTest.ParsingFromJSONError`. These attempt to test common error 
> scenarios that might show up in user-supplied JSON.
> 
> `make check` was used to confirm that all tests pass, with one notable 
> failure (ResourcesTest.ParsingFromJSONError) related to a picojson issue 
> tracked here: https://issues.apache.org/jira/browse/MESOS-3698
> 
> The original resources parsing format is used throughout many other tests 
> (check `src/tests/sorter_tests.cpp`, for example), so it's clear that the 
> original parsing continues to work correctly.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Anand Mazumdar]

> On Oct. 20, 2015, 1:03 a.m., Ben Whitehead wrote:
> > docs/scheduler-http-api.md, lines 38-57
> > 
> >
> > The rest of the HTTP API Documentation is language agnostic and I feel 
> > strongly that it should be kept that way.
> > 
> > Please remove this example. In the future when there are 
> > implementations available they can be linked to in an appendix.

I tend to agree with BenW here. Let's add pseudo code instead of python code 
here in addition to the suggested ABNF grammar. Borrowed from: 
https://dev.twitter.com/streaming/overview/processing ( Delimited section )

```
while (true) {
  do {
lengthBytes = readline()
  } while (lengthBytes.length < 1)
  messageLength = parseInt(lengthBytes);
  messageBytes = read(messageLength);
  process(messageBytes);
}
```

What do you think ?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103194
---


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

[Ben Mahler]

> On Oct. 18, 2015, 4:18 p.m., Joris Van Remoortere wrote:
> > We can use snake case in stout.

What made you think that? We certainly haven't been doing that intentionally, 
and this is still called bootId(), not boot_id().. although I see some snake 
case slipped in :(


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39213/#review103058
---


On Oct. 13, 2015, 6:34 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39213/
> ---
> 
> (Updated Oct. 13, 2015, 6:34 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.
> 
> (NOTE: this does not close MESOS-3632, but does contribute to its resolution.)
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5141c1369af60afd6cd5c70c6295d575ea960a83 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/bootid.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/bootid.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39213/diff/
> 
> 
> Testing
> ---
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, 
> Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on 
> Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39459/#review103202
---

Ship it!


Ship It!

- Guangya Liu


On 十月 19, 2015, 11:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39459/
> ---
> 
> (Updated 十月 19, 2015, 11:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Lots more to add, but this is a start.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39459/diff/
> 
> 
> Testing
> ---
> 
> Previewed via Github Gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review103214
---


The code diff of #38335 are alos upedted based on master.

- Klaus Ma


On Oct. 20, 2015, 2:39 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> ---
> 
> (Updated Oct. 20, 2015, 2:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp f0e7870 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 
> 
> Diff: https://reviews.apache.org/r/38342/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

[Klaus Ma]

> On Sept. 29, 2015, 3:48 p.m., Alexander Rukletsov wrote:
> > src/tests/mesos.hpp, line 1844
> > 
> >
> > We tend not to use `typedef`s in the codebase. However, this looks like 
> > a good idea, but I would place it in `Resources`, e.g. 
> > `Resources::ProtoType`.
> > 
> > However, I'll leave the decision whether to use `typedef` or not to you 
> > and your shepherd.

It's related to test only, so keep it in test module for now.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/#review100961
---


On Oct. 20, 2015, 5:37 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38335/
> ---
> 
> (Updated Oct. 20, 2015, 5:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/persistent_volume_framework.cpp 176ac3d 
>   src/launcher/executor.cpp 50b3c6e 
>   src/master/contender.cpp c641305 
>   src/master/http.cpp 093f793 
>   src/master/maintenance.cpp 5fe9358 
>   src/master/registrar.cpp 1117232 
>   src/slave/containerizer/fetcher.cpp e0d02d5 
>   src/slave/containerizer/mesos/containerizer.cpp d1fc5a4 
>   src/slave/monitor.cpp aa6e958 
>   src/tests/containerizer/launch_tests.cpp de655ec 
>   src/tests/fault_tolerance_tests.cpp f78a291 
>   src/tests/master_maintenance_tests.cpp e89ce3b 
>   src/tests/master_tests.cpp ee24739 
>   src/tests/mesos.hpp 3e58b45 
>   src/tests/mesos.cpp ab2d85b 
>   src/tests/monitor_tests.cpp 583e711 
>   src/tests/reservation_endpoints_tests.cpp f5f9c48 
>   src/tests/resources_tests.cpp 6584fc6 
>   src/tests/scheduler_http_api_tests.cpp d338a1b 
>   src/tests/script.cpp bcc1fab 
>   src/tests/slave_tests.cpp 10a4fa7 
>   src/usage/main.cpp 86fd796 
> 
> Diff: https://reviews.apache.org/r/38335/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/
---

(Updated Oct. 20, 2015, 2:39 a.m.)


Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.


Changes
---

Address comments


Bugs: MESOS-3405
https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
---

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
converts a `google::protobuf::Message` into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField` by 
introducing overloaded functions.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp f0e7870 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 

Diff: https://reviews.apache.org/r/38342/diff/


Testing
---

cd 3rdparty/libprocess/3rdparty/stout
./boostrap
./configure
make


Thanks,

Klaus Ma

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/
---

(Updated Oct. 20, 2015, 3:14 a.m.)


Review request for mesos and Ian Downes.


Bugs: https://issues.apache.org/jira/browse/MESOS-1563

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

Enable build on FreeBSD, start porting components.

My build steps are:

- Install dependencies from http://mesos.apache.org/gettingstarted/
- Install libexecinfo
- Install clang36 (system clang is 3.4)
- boostrap
- ../configure --with-curl=/usr/local --with-apr=/usr/local 
--with-svn=/usr/local CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36 check

I disabled one test because I haven't had a chance to debug it and I wanted to 
get a bit further in the test suite. A check run is attached.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
53e83d4905945593e174601a0b791d01824dc34b 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1c776cd2facfb86854c7b2a8fe6be7949b566587 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
1baf142d53fd06149c80d4b2677c2a976c05ef71 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
e9b05ef3b59fd068137cb12e36591de2d4a801a1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 
0a98e9e310d3931c2341053595b7d62f68214783 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
8a8ede325cfe8f024e1be4db24b0c8118d18f359 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
4cc781bddbf7ee10cc0671f62d710fb4fa80e293 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
  3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 
  3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 
  configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 
  src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc 
  src/slave/containerizer/isolators/posix/disk.cpp 
73e62a225da062733557287afa2273d8183d76fd 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39345/diff/


Testing
---

make check on coreos (I'll get a ubuntu instance for future testing)

gmake check on freebsd 10.2 (failing) (log attached)


File Attachments


freebsd_check2.log
  
https://reviews.apache.org/media/uploaded/files/2015/10/19/5b62f825-006f-4316-b0a4-c1f39f9a__check2.log


Thanks,

David Forsythe

Re: Review Request 39457: Document messages in messages.proto.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103210
---


Patch looks great!

Reviews applied: [39457]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 12:42 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> ---
> 
> (Updated Oct. 20, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
> https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> ---
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>