Re: [OpenJDK 2D-Dev] [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

Adding 2d-dev because a number of the files are 2D. What is the general reason for changing the appearance of the tables? -phil. On 5/12/17, 4:25 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9-dev. This fix is a part of the effort to make all javadoc in jdk9 be compatible to

Re: [OpenJDK 2D-Dev] [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

Does this in any way match the rest of the docs ? Or is everyone left to style things how they want. I thought (?) maybe there is to be some javadoc tool support for CSS styles. Also why are all the table summaries removed ? -phil. On 5/12/17, 4:52 PM, Sergey Bylokhov wrote: This is because I

Re: [OpenJDK 2D-Dev] [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

st to be different .. -phil. -- Jon On 05/12/2017 04:54 PM, Philip Race wrote: Does this in any way match the rest of the docs ? Or is everyone left to style things how they want. I thought (?) maybe there is to be some javadoc tool support for CSS styles. Also why are all the table summ

Re: [OpenJDK 2D-Dev] RFR: 8177393: Result of RescaleOp for 4BYTE_ABGR images may be 25% black

Some review discussion with Jim is in the bug report comments. Updated webrev to address the minimal set of issues : http://cr.openjdk.java.net/~prr/8177393.1/ -phil. On 5/18/17, 3:32 AM, Prasanta Sadhukhan wrote: Looks good to me. [Checked 8080287 also works ok with this change] Regards Pra

Re: [OpenJDK 2D-Dev] Safe to take Base64 encoded image from client?

From a JDK perspective you need to make sure you run with the latest secure baseline update for your version : for more info see http://www.oracle.com/technetwork/java/javase/overview/security-2043272.html The rest is application architecture for which I don't think we can or should give advice.

Re: [OpenJDK 2D-Dev] [9] Review request for 8181192: [macos] javafx.print.PrinterJob.showPrintDialog() hangs on macOS

The fix is fine but rather than deleting the test just mark it @ignore .. it can be then updated with a new version of the fix. -phil. On 6/1/17, 11:19 AM, Anton Litvinov wrote: Hello, Could you please review the following fix for the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-81811

Re: [OpenJDK 2D-Dev] [9] Review request for 8181192: [macos] javafx.print.PrinterJob.showPrintDialog() hangs on macOS

+1 Please add the required RDP2 process label + comment to request this fix be pushed -phil. On 6/2/17, 5:40 AM, Anton Litvinov wrote: Hello Phil and Sergey, The new version of the back out fix, which does not remove the regression test and adds "@ignore" jtreg tag, is following. Webrev

Re: [OpenJDK 2D-Dev] [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

I don't remember anything left that I would object to .. and we'll push client changes to dev this week anyway so it all sounds fine. -phil. On 6/4/17, 5:53 PM, Sergey Bylokhov wrote: If there are no objections I'll change the target ws from dev to client, to minimize the merges between some

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

rs, Laurent Le 17 mai 2017 22:05, "Phil Race" <mailto:philip.r...@oracle.com>> a écrit : Early next week is the hope. -phil On 05/16/2017 02:20 PM, Laurent Bourgès wrote: Phil, Did you get any answer from the CSR process on this bug ? Laurent 201

Re: [OpenJDK 2D-Dev] [9]JDK-6949753:[TEST BUG]: java/awt/print/PageFormat/PDialogTest.java needs update by removing a infinite loop

asanta Sadhukhan *Sent:* Tuesday, June 6, 2017 11:52 AM *To:* Shashidhara Veerabhadraiah ; 2d-dev@openjdk.java.net *Cc:* Philip Race *Subject:* Re: [9]JDK-6949753:[TEST BUG]: java/awt/print/PageFormat/PDialogTest.java needs update by removing a infinite loop As I told, pageDialog is modal so lat

Re: [OpenJDK 2D-Dev] [9]JDK-6949753:[TEST BUG]: java/awt/print/PageFormat/PDialogTest.java needs update by removing a infinite loop

949753/webrev_06/ <http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_06/> Thanks and regards, Shashi *From:*Shashidhara Veerabhadraiah *Sent:* Monday, June 12, 2017 11:19 PM *To:* Philip Race ; Prasanta Sadhukhan *Cc:* 2d-dev@openjdk.java.net *Subject:* RE: [9]JDK-6949753:[TE

Re: [OpenJDK 2D-Dev] [10]JDK-8183341:Better cleanup for javax/imageio/AllowSearch.java

nks and regards, Shashi *From:*Sergey Bylokhov *Sent:* Wednesday, July 12, 2017 12:13 AM *To:* Shashidhara Veerabhadraiah <mailto:shashidhara.veerabhadra...@oracle.com>> *Cc:* Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>>; 2d-dev@openjdk.java.net <mailto:2d-dev@ope

Re: [OpenJDK 2D-Dev] [10] Review Request: 8185093 Expensive multi-core choke point when any graphics objects are created

I think minimal or low .. I could never say "none". I've added my "review" as well. -phil On 7/31/17, 1:32 PM, Jim Graham wrote: I adjusted one of the statements to be a little more straightforward and set the compatibility risk to minimal. If Phil thinks the risk can be set to "None", that

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8164971: PNG metadata does not handle ImageCreationTime

I am OK with this. It would be good if Brian could look at it too to make sure it functions as he expects since he was the original reporter and requestor here .. -phil. On 8/15/17, 2:57 AM, Prahalad Kumar Narayanan wrote: Hello Everyone Thanks to Phil for his time in reviewing the fix. I 've

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

* * @since 10 */ +public abstract void trimToSize(); It will match the proposed patch. Thanks, Laurent 2017-04-20 23:04 GMT+02:00 Philip Race mailto:philip

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

I have filed https://bugs.openjdk.java.net/browse/JDK-8186364 and created and submitted the CSR for it : https://bugs.openjdk.java.net/browse/JDK-8186365 -phil. On 8/17/17, 8:05 AM, Philip Race wrote: OK I'll handle the bureaucracy. -phil. On 8/17/17, 7:31 AM, Laurent Bourgès wrote:

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8186987:NullPointerException in RasterPrinterJob without PrinterResolution

r the same to occur on many devices as well. . Besides printers may not be supporting low 300 DPI resolution going forward. I may be wrong in my understanding. You could wait for other's review & follow up. Thank you Have a good day Prahalad N. -Original Message- From: Pr

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

I think for JDK 8 you can pass down a flag to decide whether to include or exclude CFF. This flag would be the value of FontUtilities.isOpenJDK() and that should tell us what we need. That would preserve the status quo for Oracle JDK and it would be our problem if the same bug were then report

[OpenJDK 2D-Dev] RFR: 8170681 : Remove fontconfig header files from JDK source tree

Bug: https://bugs.openjdk.java.net/browse/JDK-8170681 Webrev: http://cr.openjdk.java.net/~prr/8170681/ This fix removes the copy of fontconfig.h from the JDK sources. The file was originally included in the JDK sources because the build platforms of the day were too old to include it. It will h

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

The screenshot shows you directly calling this method in your test which the documentation says you are not supposed to do. So I am not able to be 100% sure that the test you have re-creates what the submitter saw .. in his stack trace you have below it seems to be valid. But to have a NPE at lin

Re: [OpenJDK 2D-Dev] JDK-8153732 Add refresh prossibility for known printers

Hi, I think this is the issue you raised last year in this thread, correct ? http://mail.openjdk.java.net/pipermail/2d-dev/2016-May/006897.html And the problem is that even though we use the Windows APIs to be notified of a change in printers, for whatever reason (did we discuss the reasons ?, I

[OpenJDK 2D-Dev] RFR: 8190280 [macos] Font2DTest demo started failing for Arabic range from JDK 8 u162 b01 on Mac

Bug: https://bugs.openjdk.java.net/browse/JDK-8190280 Webrev: http://cr.openjdk.java.net/~prr/8190280/ This is a JDK8 version of the bug https://bugs.openjdk.java.net/browse/JDK-8172967 which affected harfbuzz in JDK 9 It is triggered by a couple of things but mainly that the Mac font code so

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8189702: Broken links in javadoc for Adobe TIFF related documents

+1 -phil. On 11/3/17, 11:42 AM, Brian Burkhalter wrote: Hi Jay, On Nov 3, 2017, at 12:47 AM, Jayathirth D V > wrote: I also feel that we should have at least have reference to TIFF spec and ITU link seems reasonable. @Brian : I previously looked intohttps:

Re: [OpenJDK 2D-Dev] [10] Review Request: 8019816 [TEST_BUG][macosx] closed/java/awt/BasicStroke/DashZeroWidth.java not on EDT

Approved. -phil. On 11/2/17, 6:43 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk10. Description: The tests were reworked to use only 2d api. The check for VolatileImage is added just to improve code coverage and it is executed only in headful mode. This is a request to move

Re: [OpenJDK 2D-Dev] [10] Review Request JDK - 8164811 : [hidpi]Tests fail with OpenGL Rendering

Adding new API to BufferedImage was definitely NOT the way to approach this. Adding new public API we need to support forever to fix an internal implementation bug on one platform in a very atypical scenario is the wrong trade-off. And anyway as Sergey said BI should have no dependency or relat

Re: [OpenJDK 2D-Dev] RFR: 8190814: javax/imageio/stream/NullStreamCheckTest writes to the repo

Hmm. I pointed this out in the review of the original fix http://mail.openjdk.java.net/pipermail/2d-dev/2016-March/006491.html and thought it was resolved .. I should have looked more closely at the update. The fix looks fine although I also think this should be main/othervm as this test is de-

[OpenJDK 2D-Dev] RFR: 8186306: Remove pisces from Java2D sources + build.

bug: https://bugs.openjdk.java.net/browse/JDK-8186306 webrev: http://cr.openjdk.java.net/~prr/8186306/ This fix removes the pisces rasterizer code since it is superseded by marlin. In addition it removes the (always) un-used Jules code from the Xrender pipe-line. This code has never been en

Re: [OpenJDK 2D-Dev] [10] Review request for 8190228: Remove redundant modifiers in java.desktop module

These all seem fine although I don't think you need bother including the jules files in this change. In a separate webrev I just sent out I remove all the jules files. -phil. On 11/7/17, 9:26 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK10: bug: https://bugs.openjdk.java.net/b

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

I'm giving this an OK. I've looked at the code, if not the maths, and run our regression test suite. I had a bit of trouble with my full baseline run against which to compare so I've re-run just the test failures that seem like they might go anywhere need this code. and they were pre-existing.

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

-November/008741.html I will push tomorrow to jdk forrest as phil & sergey? approved 2D changes. This RFR thread remains open for the JavaFX patch that Kevin started to test & review. Cheers, Laurent 2017-12-10 18:36 GMT+01:00 Philip Race <mailto:philip.r...@oracle.com>>: I

Re: [OpenJDK 2D-Dev] Problems logging in to http://bugs.openjdk.java.net

Perhaps o...@openjdk.java.net for things like this but I'll forward this onto some folks who may be able to help. -phil. On 12/14/17, 12:21 AM, Dmitry Batrak wrote: Hello, I'm sorry to bother you with this, but I regularly have problems logging in to OpenJDK issue tracker (bugs.openjdk.java.n

Re: [OpenJDK 2D-Dev] RFR : 8193515 : AIX : new Harfbuzz 1.7.1 version fails to compile

+1 from me .. yes push to jdk/jdk10. -phil. On 12/18/17, 1:51 AM, Volker Simonis wrote: Hi Matthias, the change looks good and I can sponsor it. I'd just propose to slightly change the comment to "..by the overloaded versions of 'cmp' in IntType" if you don't mind. There's no need for a new w

Re: [OpenJDK 2D-Dev] jdk-hs ppc64le build error, probably related to libpng update

This all sounds fine to me. Definitely we should report this upstream to see what they say but clearly we aren't bound to wait for an answer from there since this is a build breakage for PPC. If someone upstream comes back with a better answer we can update the fix. I think this png update will g

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

The discussion about SLE seems to have taken over. This was originally about zLinux. If it actually makes sense for zLinux for JDK 11 then I have no objections to the proposed toolchain specific patch ... If it does not make sense for 11 then I think you should look only at 8u and prepare a

Re: [OpenJDK 2D-Dev] bug 8146238 - Java Queue Flusher on MacOS

There was a reply to the proposal when it was submitted : http://mail.openjdk.java.net/pipermail/2d-dev/2015-December/006130.html suggesting a different approach, but there was no follow-up. So I don't really know what the current status is .. and that was a long time ago. -phil. On 1/25/18,

[OpenJDK 2D-Dev] RFR: 8193483: Update client-libs ProblemList.txt

bug: https://bugs.openjdk.java.net/browse/JDK-8193483 webrev; http://cr.openjdk.java.net/~prr/8193483/ An update to the ProblemList to exclude most of the tests that fail on Windows. There are still a number of tests that have "errors" like timeouts that need to be added. Also I need to do

Re: [OpenJDK 2D-Dev] Fwd: [PATCH] Fix compiler warnings with newer GCC 7.2.1

jpeg + harfbuzz are imported libraries. There's no point in a source fix in JDK'scopy as it will get overwritten when we upgrade. No way we are tracking such patches to reapply them. If warnings there are an issue either update the makefiles or use disable-warnings-as-errors ... and perhaps r

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8195131: Dead code removal for changes present in JDK-8176795

Looks fine. If anyone needs this in the future they can add back this or an overload that does the pre-multiplication. -phil. On 1/18/18, 12:44 PM, Prahalad Kumar Narayanan wrote: Hello Jay I understand that the last argument to XRColor.setColorValues (int pixel, boolean pre) is set to 'true

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

On 2/21/18, 7:45 AM, Sergey Bylokhov wrote: Hi, Prasanta. I have updated the tests mentioned in your previous email: http://cr.openjdk.java.net/~serb/8198333/webrev.10 /java/awt/font/TextLayout/TestAATMorxFont.java should be for mac only if (!osName.startsWith("mac")) { 42 ret

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

That is fine. -phil. On 2/21/18, 9:34 AM, Sergey Bylokhov wrote: On 21/02/2018 08:49, Philip Race wrote: I am not sure it has mac specific code, I'll reevaluate this test in JDK-8198406. This is mac-specific. It looks for specific fonts by name that exist only on MacOS. And moreove

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

No. -phil. On 3/9/18, 3:23 PM, Sergey Bylokhov wrote: Hi, Phil Headers of the new files refer to LICENSE.TXT. Should we import it as well? On 09/03/2018 14:10, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193017 Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

Just to be clear, I mean we don't import it to each of the source files. But it is there in the file legal/freetype.md in this webrev. On 3/9/18, 3:26 PM, Philip Race wrote: No. -phil. On 3/9/18, 3:23 PM, Sergey Bylokhov wrote: Hi, Phil Headers of the new files refer to LICENSE.TXT. S

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

he license and provide the text only for one or for both. On 09/03/2018 15:28, Philip Race wrote: Just to be clear, I mean we don't import it to each of the source files. But it is there in the file legal/freetype.md in this webrev. On 3/9/18, 3:26 PM, Philip Race wrote: No. -phil. On

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

This is a tricky one. Since Oracle no longer ships 32 bit JDKs for any platform for the new releases, then there aren't resources or effort being put into making sure it still builds. Our build systems might still support it, but for how long? It might effectively have to become a "port" that som

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi Laurent, It took me I at least 5 tries to get all the way through this. I don't have any substantial comments, just a few clean up questions. What is this in Curve.java + DCurve.java ? +if (false) { +dax = 0.0d; +day = 0.0d; +dbx = 0.0d; +

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

On 3/23/18, 2:21 AM, Jayathirth D V wrote: Hi Prahalad, Change looks fine. Test case works properly before and after the code change. ? You mean it does not fail before the fix ? It definitely fails for me before the fix. Since we are touching getNumThumbnailsSupported() function and it is

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

On 3/23/18, 11:56 AM, Sergey Bylokhov wrote: Hi, Prahalad. A few small comments about the test: - Is it possible to test all installed ImageWriterSpi? It seems that the test itself is not a JPEG plugin specific? None of the other plugins support thumbnails so they will all return 0 regard

Re: [OpenJDK 2D-Dev] RFR: JDK-8202052: Disable warnings when building libawt with VS2017

+1 -phil. On 4/19/18, 3:41 PM, Mikael Vidstedt wrote: Please review the following change which disables some warnings in libawt which show up when building with VS2017: bug: https://bugs.openjdk.java.net/browse/JDK-8202052 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8202062/webrev.0

Re: [OpenJDK 2D-Dev] RFR [11] JDK-8202580: Dashed BasicStroke randomly painted incorrectly, may freeze application

Looks fine to me. Did you run the rendering related regression tests ? I am not sure if a backport to 10 will be approved under the new guidelines : http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2018-April/000102.html -phil. On 5/4/18, 5:30 AM, Laurent Bourgès wrote: Sergey, Please

Re: [OpenJDK 2D-Dev] RFR [11] JDK-8202580: Dashed BasicStroke randomly painted incorrectly, may freeze application

On 5/7/18, 9:27 AM, Laurent Bourgès wrote: Phil, Le dim. 6 mai 2018 à 01:11, Philip Race <mailto:philip.r...@oracle.com>> a écrit : Looks fine to me. Did you run the rendering related regression tests ? I ran all tests in sun/java2d/marlin. What other tests should I run ? Th

[OpenJDK 2D-Dev] RFR: 8198991: Move Java2D demo to the open repository

Bug: https://bugs.openjdk.java.net/browse/JDK-8198991 Webrev: http://cr.openjdk.java.net/~prr/8198991/ This moves the Java 2D demo from "closed" to "open". It is now called "J2Ddemo" to avoid any trademark questions. This has already been reviewed internally and the images here are OK to keep.

Re: [OpenJDK 2D-Dev] RFR: 8198412 : MonospacedGlyphWidthTest.java may fail on Solaris

On 5/11/18, 2:58 PM, Sergey Bylokhov wrote: Looks fine, Note that the problem list should be updated. Yes, I remembered that after sending out the webrev. Fixed in the push. -phil. On 11/05/2018 14:46, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8198412 webrev: http://

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

Hi, OK .. if you can convince upstream this is worth doing, then we can accept it as we would not regress when updating. As I noted previously : http://mail.openjdk.java.net/pipermail/2d-dev/2018-March/009086.html this is still an issue in the currently being developed 9c train. -phil. On 5/1

Re: [OpenJDK 2D-Dev] RFR: 8191522: Remove references to Lucida fonts from OpenJDK sources

http://cr.openjdk.java.net/~prr/8191522.1 uploaded. Adding .. the removal of .. a couple of uses of lucida - sanity check of lucida in font config files is no longer needed. - J2DBench demo opts change from lucida to dialog. Not sure why it had lucida anyway .. -phil. On 5/16/18, 4:08 PM, Erik

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

There's a lot to think about here but I have some requests to first clean up the proposed code to conform to coding standards. I see lots of lines > 80 chars. Please fix I see if(foo){ and else{ which should be "if (foo) {" and "else {" Basically always have a space before { and after ) and aro

Re: [OpenJDK 2D-Dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow

Fix sounds good. The test has a bug 47 static final Font fnt = new Font("Time New Roamn", Font.PLAIN, 1).deriveFont(12.0f); "Roamn" should be "Roman". But since Linux is very unlikely to have that font, I think you should use Font.SERIF instead. Actually I am unclear why you need to u

Re: [OpenJDK 2D-Dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow

+1 (approved) from me. -phil. On 5/22/18, 9:40 AM, Andrew Brygin wrote: corrected: 47 static final Font fnt = new Font(Font.SERIF, Font.PLAIN, 12); Updated webrev: http://cr.openjdk.java.net/~bae/8203485/webrev.01/ Thanks, Andrew On May 22, 2018, at 7:26 PM, Philip Race wrote: Fix

Re: [OpenJDK 2D-Dev] Question about splashscreen lib

So far as I can see it does, just indirectly. png.c includes pngpriv.h which includes png.h Not including the declarations of the exported API in the file that defines them would be a problem waiting to happen. -phil. On 5/29/18, 3:54 AM, Adam Farley8 wrote: Hi All, Does anyone know why png.c

Re: [OpenJDK 2D-Dev] [XS] RFR : JDK-8204085: avoid printing uninitialized pointer in java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp

Yes, please. And it looks fine. We have an internal static code analysis tool which should catch this sort of thing but it is weakest on Windows .. -phil. On 5/30/18, 7:11 AM, Baesken, Matthias wrote: Hi Christoph, Sergey and Thomas , thanks for the reviews . * And make sure you push it t

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

> It looks fine to me but I am a bit hazy about who to give attribution for the fix .. I pondered this for a little while and decided it should be joint between Adam who identified the issue and championed it and Thomas who I think first suggested the code change, modified only slightly at Guido

[OpenJDK 2D-Dev] RFR: Fix compilation error in harfbuzz 1.7.6 for Solaris Developer Studio 12.6

Bug: https://bugs.openjdk.java.net/browse/JDK-8204509 Webrev: http://cr.openjdk.java.net/~prr/8204509/ This enables harfbuzz to compile with both 12.4 (current default) and 12.6 (near future default) -phil.

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

OK . go ahead .. I just keep failing to get to this. I think we will have to use a follow-up bug in the eventuality of remaining issues on Oracle JDK8u. -phil. On 6/11/18, 8:23 AM, Mario Torre wrote: Hi Phil, I realise this is quite an old thread, but do you think I can request the proposed pa

[OpenJDK 2D-Dev] RFR: 8204929: Fonts with embedded bitmaps are not always rotated

Bug : https://bugs.openjdk.java.net/browse/JDK-8205046 Webrev : http://cr.openjdk.java.net/~prr/8204929/ The submitter was using MS UI Gothic which has embedded bitmaps. When rotating text the baseline was rotated, and the glyphs positioned appropriately but the images themselves were not rotat

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

--Updated webrev 02 https://urldefense.proofpoint.com/v2/ur"Steven R. Loomis" ---2018/06/19 02:02:35---Updated webrev 02 _INVALID URI REMOVED_ From: "Steven R. Loomis" __ <mailto:s...@icu-project.org> To: Toshio 5 Nakamura __

[OpenJDK 2D-Dev] Fwd: Re: [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

: Philip Race Organization: Oracle Corporation To: Shashidhara Veerabhadraiah CC: awt-...@openjdk.java.net, swing-...@openjdk.java.net This is on the wrong lists. Not Swing. Not AWT. Should be 2d. I'll forward it there and continue there. Consider the AWT+Swing threads dead. -phil.

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

otifications** calls are a blocking function calls hence I could not add the remote printers monitor to the existing thread. Hence there is a new thread being added to listen to remote printers status changes. http://cr.openjdk.java.net/~sveerabhadra/8153732/

Re: [OpenJDK 2D-Dev] [11] Review Request: 8202696 glyphs in textfield only shown when thai baht-character is added

estion and please find the updated webrev at http://cr.openjdk.java.net/~dkumar/8202696/webrev.03/ . Request you to have a look at it again and let me know your comments. Thanks, Dipak -Original Message- From: Naoto Sato Sent: 21 June 2018 22:52 To: Dipak Kumar; Philip Race; 2d-dev@openjd

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

t/%7Esveerabhadra/8153732/webrev.06/> Thanks and regards, Shashi *From:*Prasanta Sadhukhan *Sent:* Friday, June 22, 2018 2:00 PM *To:* Shashidhara Veerabhadraiah ; Philip Race ; 2d-dev <2d-dev@openjdk.java.net> *Subject:* Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer

Re: [OpenJDK 2D-Dev] COMPOUND_TEXT charset is missing on JDK11

The DnD & clipboard cases on such a desktop are the only possible use I can think of for this charset, so if it were to exist anywhere it would be in the desktop module, since it depends on all the X decoders that were moved there. But since MToolkit is gone so we don't have direct need for it.

[OpenJDK 2D-Dev] JDK 11 RDP1 and the jdk/client repository

I want to make sure people understand some of the nuances of RDP1 for JDK 11 [1] - Any fix pushed to jdk/client after 2am PT Tue 26th June will be destined for JDK 12. Not JDK 11 - That is because this is the time we start the build for the final JDK 11 Client PIT (PIT == Pre-Integration T

Re: [OpenJDK 2D-Dev] RFR: 8204391: Colors with alpha are painted incorrectly on Linux

Actually, although the recommendation is not "as strong", it is still recommended to use the EDT for initialising AWT apps. You'll find the same in some other tests I think. In any case it is just a harmless precaution. -phil. On 7/27/18, 3:11 AM, Prasanta Sadhukhan wrote: Fix looks good to me.

Re: [OpenJDK 2D-Dev] RFR: 8204391: Colors with alpha are painted incorrectly on Linux

If Clemens can also look at it, that would be great, but if he does not have time right now, I would not like to hold it up, since its a tck-red for 11. -phil. On 7/27/18, 2:27 AM, Jayathirth D V wrote: Hi Phil, Thanks for fixing the regression introduced by https://bugs.openjdk.java.net/bro

[OpenJDK 2D-Dev] RFR: 8208466: Fix potential memory leak in harfbuzz shaping

bug: https://bugs.openjdk.java.net/browse/JDK-8208466 webrev: http://cr.openjdk.java.net/~prr/8208466/ Simple fix for possible memory leaks on error conditions. This is the same fix as in upstream harfbuzz. -phil.

Re: [OpenJDK 2D-Dev] libsplashscreen compilation on ppc64 ( le) - was : RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update

Works for me. Include build-dev on the review. And splashscreen is considered an AWT feature so it should be awt-dev not 2d-dev although you may want to reference back to this earlier exchange. -phil. On 8/7/18, 8:04 AM, Baesken, Matthias wrote: Hello, should I prepare a change setting t

Re: [OpenJDK 2D-Dev] [12] Review request for 8201818: [macosx] Printing attributes break page size set via "java.awt.print.Book" object

Hi, The fix looks reasonable. But we've touched the code being touched here quite recently and the history there shows that this can be tricky to get right : 8167102: [macosx] PrintRequestAttributeSet breaks page size set using PageFormat caused 8181192: [macos] javafx.print.PrinterJob.showPrin

Re: [OpenJDK 2D-Dev] [12] Review request for 8201818: [macosx] Printing attributes break page size set via "java.awt.print.Book" object

no print dialog - attached to the bug record test case "PrintingAttributeBreaksBookPageSize.java" b) native print dialog - the created regression test "test/jdk/java/awt/print/PageFormat/WrongPaperForBookPrintingTest.java" c) swing print dialog - the regression test in point #b with

Re: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

Some day, I'd like to replace a lot of medialib functionality with something like the proposed Vector API. But that is far enough away that medialib needs to be maintained, and unlike a previous discussion about a similar issue in the JPEG library, we are on the hook for maintaining medialib. So

Re: [OpenJDK 2D-Dev] [8u] RFR 8201801: RTL language (Hebrew) is presented from left to right

> it will break non-macos build as you are checking for CFont in a shared class? Indeed. And on top of that, the apparent assumption that all Apple platform fonts are AAT fonts is wrong. Even if we agreed with this approach, which needs thought, it should only apply to AAT fonts > Also, if

[OpenJDK 2D-Dev] RFR: 7017058: Malayalam glyph substitution is failing for Malayalam with Windows Kartika font.

This fixes 3 submitted bugs https://bugs.openjdk.java.net/browse/JDK-7017058 : the Malayalam bug above And also https://bugs.openjdk.java.net/browse/JDK-8191130 : Sinhala text rendering problem with C+VIRAMA+ZWJ+RA/YA+V and https://bugs.openjdk.java.net/browse/JDK-8195836: opentype:Bengali: "Khand

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

This looks good to me. I've run all our automated tests + done some manual testing as well as building on all platforms and reviewing the source changes. > PS: What is the process to ask for backport to JDK11 updates ? If you think this important enough to backport, then this is the process :

[OpenJDK 2D-Dev] RFR: 8210384: SunLayoutEngine.isAAT() font is expensive on MacOS

bug: https://bugs.openjdk.java.net/browse/JDK-8210384 webrev: http://cr.openjdk.java.net/~prr/8210384/ AAT is the Apple alternative to OpenType layout. Calls to the Harfbuzz layout engine need to pass a flag which says whether the font is an AAT font because we need to set up transforms differe

Re: [OpenJDK 2D-Dev] LineBreakMeasurer 7-70x slower on Java 10 compared to Java 8

You missed https://bugs.openjdk.java.net/browse/JDK-8202131 It is on my to-do list .. -phil. On 9/8/18, 1:55 PM, Eirik Bakke wrote: Hi, 2D-dev. Switching from Java 1.8.0_172 to Java 10.0.2, at least on Windows 10, it has become very expensive to call LineBreakMeasurer.nextLayout--it takes

Re: [OpenJDK 2D-Dev] JDK-8210707: Some line shaped characters are not displayed without Anti Aliasing

Hi, So I believe we have concluded this is a core freetype problem since it manifests with multiple fonts even outside the JDK. In which case I don't know why you are posting this here. Whilst I sympathise with the problem, the right place to discuss it is on the freetype list, or submit a su

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

Interesting and I assume that it was somewhat less in JD8u ? Off the top of my head that is one thing that didn't change in any big way since JDK 8u. Perhaps something has changed so that it is now [considered] needed whereas before it was not? So did it go from zero percent to 29% or from 10

Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

Hi, 1) Has this been built on all platforms ? 2) I can't find the list of warnings that you are seeing and fixing and they are all over the place. So adding 2d-dev and build-dev. For each of these changes, please show what was the warning that you received from the compiler This might sound l

Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

You really do need to explain *each* of the changes better. This one .. why not NULL ? http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html -phil On 10/1/18, 9:19 AM, Philip Race wrote: Hi, 1) Has this been built on

Re: [OpenJDK 2D-Dev] RFR JDK-8211300: Convert C-style array declarations in Java code

Hi, On 9/30/18, 8:29 PM, Tagir Valeev wrote: Hello! Please review JDK-8211300 [1] this change: [2]. Also it needs a sponsor as I have only JDK author status in OpenJDK Census [3]. Adding awt + swing. I can sponsor this. Have you submitted a build via hg.openjdk.java.net/jdk/submit ? I can s

Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

I suspect I understand this one now .. the array is stack allocated so we don't want NULL but the compiler probably complained about possible uninitialised use of the values ? -phil. On 10/1/18, 9:38 AM, Philip Race wrote: You really do need to explain *each* of the changes better. Thi

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

I've spent some time examining what pdfbox is passing to ColorConvertOp It is called about 10 or 11 times in this test with images typically 1-2K in each dimension. The input image is a Custom BufferedImage which uses an ICC_ColorSpace constructed from a color profile file that is embedded in pd

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211055:Provide print to a file (PDF) feature even when printer was not connected

Good enough to fix the regression. +1 -phil. On 9/26/18, 11:24 PM, Prasanta Sadhukhan wrote: I have added @requires tag and also did an initial check of existing printers and exit if there is any. Regarding setting,retrieving Destination attribute, if we do not show the print dialog and a

Re: [OpenJDK 2D-Dev] RFR JDK-8211300: Convert C-style array declarations in Java code

Given what Sergey has done, I don't need to repeat that work. I am now just looking for formatting anomalies, but there is a lot to look at. I should be able to OK this tomorrow and we can then commit it on your behalf. Have you looked at the other client modules ? datatransfer, accessibility

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

Cheers, Laurent Le mar. 2 oct. 2018 à 23:35, Philip Race <mailto:philip.r...@oracle.com>> a écrit : I've spent some time examining what pdfbox is passing to ColorConvertOp It is called about 10 or 11 times in this test with images typically 1-2K in each dimension.

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

s mailto:bourges.laur...@gmail.com>> wrote: Very good job, phil. I will try your CCONV test on my linux machine to see if it is platform dependent ... or hw ? Laurent Le mer. 3 oct. 2018 à 19:19, Philip Race mai

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

ICC profiles and I haven't checked if it is even applying the pdfbox one properly. But it does have support to split a job into concurrent tasks for sub-images which can help on the larger images like the one I am using in CConv. -phil. On 10/4/18, 2:24 PM, Philip Race wrote: I might be losi

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

FToImage.java?revision=1829374&view=markup <https://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java?revision=1829374&view=markup> That's all folks ! Le ven. 5 oct. 2018 à 01:00, Philip Race <mailto:philip.r...@oracle.com>> a

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

k/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java?revision=1829374&view=markup <https://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java?revision=1829374&view=markup> That's all folks ! Le ven. 5 oct. 2018

Re: [OpenJDK 2D-Dev] Rendering images from PDF files slower in OpenJDK

like you've been in this discussion before https://bugs.openjdk.java.net/browse/JDK-8041125 Wasn't aware that PDFBox PDF2Image used the Kcms Provider per default. You may close this issue as we have figured out the reason. Best regards Daniel On Fri, Oct 5, 2018 at 7:27 AM P

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

On 10/10/18, 6:07 AM, Peter Hull wrote: On Wed, Oct 10, 2018 at 1:21 PM Peter Hull wrote: -Dsun.java2d.uiScale=1.0 And this does make it fast again for me (paint time< 0.1sec)! Which would sound like drawing wide lines on the software pipeline is slowing it down which makes sense except

Re: [OpenJDK 2D-Dev] Crash in CGraphicsDevice.m

The code you suspect has nothing to do with the webrev you list. It was introduced in fixing https://bugs.openjdk.java.net/browse/JDK-7124247 So has been there since JDK 8 GA. Not recent .. perhaps you can tell us more about your users JDK versions and what is the earliest that reproduces this cr

Re: [OpenJDK 2D-Dev] Setting the FreeType LCD filter

SFAIK OpenJDK still requires that fixes be posted on cr.openjdk.java.net I don't think we are allowed to pull fixes from github, or to review changes there. So an in-line patch would be better. That will likely change with skara but not yet .. Also reviews should start out with a thread with a

  1   2   3   4   5   6   7   8   >