+1
On Nov 7, 2013, at 4:59 PM, Mandy Chung wrote:
This reverts
com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl back to the
previous serial version.
diff --git
a/src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java
+1
On Nov 7, 2013, at 5:29 PM, roger riggs wrote:
Please review this straightforward typo correction:
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-doc-readlong-8024458/
Thanks, Roger
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
looks fine Joe
On Nov 8, 2013, at 2:40 PM, Joe Darcy wrote:
Hello,
Please review the simple patch below which addresses a handful of raw types
lint warning in the core reflection implementation code.
(If memory serves, this code dates back from a time during the development of
JDK 5
Looks Ok Joe
On Nov 12, 2013, at 4:28 AM, Joe Darcy wrote:
Hello,
Please review the patch below which would remove another batch of raw type
javac lint warnings from the core libraries.
No signatures of public or protected methods in the Java SE specification
have been modified.
The wording changes seem fine to me.
Thanks for the specdiff as it made it much easier to review
On Nov 12, 2013, at 11:43 AM, Stuart Marks wrote:
Hi all,
Here's an updated version of the String spec change. Changes from the
previous version address comments made by Brent Christian and
+1
On Nov 12, 2013, at 2:29 PM, Mandy Chung wrote:
This is a simple code deletion in sun.misc.JavaAWTAccess and its
implementation class:
Webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/
This patch removes the methods from sun.misc.JavaAWTAccess that are no
looks fine joe
On Nov 13, 2013, at 3:02 PM, huizhe wang wrote:
Hi,
The issue is that the limits applied to each processing process rather than
each file processing. This applies to not only StAX as reported, but also
other parsers and validators. The fix is to add reset to
The changes seem OK. I did not run the tests though
On Nov 19, 2013, at 2:08 PM, Dan Xu wrote:
Hi All,
We have java/io/pathNames/GeneralWin32.java testcase to do the general
exhaustive test of pathname handling on windows. I am adding a new test
GeneralSolaris.java to test the pathname
looks fine
On Nov 19, 2013, at 5:24 PM, Stuart Marks wrote:
Hi all,
Please review this small fix for an intermittent timeout. Nothing seems to be
going wrong except that if the machine running the test is exceptionally
slow, spurious timeouts will occur. The solution is to raise the
looks OK Joe
On Nov 26, 2013, at 5:27 PM, huizhe wang wrote:
On 11/26/2013 1:59 PM, roger riggs wrote:
Hi,
I looked at that twice also.java.time had a similar situation.
To get to the TCCL you need to call ServiceLoader.load(type).
The FactoryFinder:348 findServiceProvider method
Hi all
This is a review request for some minor javadoc clarifications for JDBC 4.2
based on some feedback that I received.
The webrev can be found http://cr.openjdk.java.net/~lancea/8029417/webrev.00
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java
looks OK
On Dec 3, 2013, at 8:40 PM, Stuart Marks wrote:
Hi all,
Please review the following small javadoc change. The StringJoiner doc for a
couple methods uses i.e. in the first sentence, which screws up the javadoc
logic that pulls the first sentence into the Method Summary. This is an
Hi Serge
This looks OK.
For
--- old/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.587885460
+
+++ new/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.435885464
+
Please remove the following
Package Specification
•
looks fine joe
On Dec 11, 2013, at 4:10 PM, huizhe wang wrote:
On 12/11/2013 12:21 PM, Alan Bateman wrote:
On 11/12/2013 19:52, huizhe wang wrote:
Hi,
This is a quick documentation change to fix an error in
javax.xml.stream.XMLOutputFactory:
Joe,
I thought this looked OK also
On Dec 17, 2013, at 12:26 PM, huizhe wang wrote:
On 12/17/2013 4:10 AM, Daniel Fuchs wrote:
Hi Joe,
The fix looks good - though I wonder at whether incrementing
whiteSpaceLookup by a fix amount wouldn't be better than
doubling its length.
Both
the change did not get pushed
to where you generated the webrev from?
and replaced br/ to br for compliance with html 3.2
On 12/05/2013 10:39 PM, Lance Andersen - Oracle wrote:
Hi Serge
This looks OK.
For
--- old/src/share/classes/java/sql/package.html 2013-12-05
15:08
looks fine Roger
On Jan 6, 2014, at 2:09 PM, roger riggs wrote:
Please review this minor specification correction to the
java.time.Duration.toDays() and
toHours() methods. Only the javadoc is corrected, no code or tests are
affected.
Webrev:
+1
On Jan 6, 2014, at 3:53 PM, Joe Darcy wrote:
Hello,
Please review the simple change to fix JDK-8027063
SecurityManger.getClassContext returns a raw type, which changes a signature
of a protected method in SecurityManger to remove a use of raw types in the
core libraries:
---
+1
On Jan 6, 2014, at 4:41 PM, Joe Darcy wrote:
Hello,
Please review the patch below to add a @SuppressWarning(serial) to
java.lang.Enum to resolve a lint warning in the core libraries.
Thanks,
-Joe
--- a/src/share/classes/java/lang/Enum.javaMon Jan 06 11:48:32 2014 -0800
+++
Dan,
Looks OK, but line 914 which you did not change, notice the comments not sure
if that is common in this code but seemed a bit off to me:
914 //// If at first, you don't succeed...
On Jan 6, 2014, at 5:29 PM, Dan Xu wrote:
Hi All,
Please review the simple fix for JNI
+1
On Jan 7, 2014, at 3:30 PM, Joe Darcy wrote:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
diff -r 2647b91dbc2a
src/share/classes/java/lang/management/ManagementFactory.java
---
looks good Joe
On Jan 7, 2014, at 6:58 PM, Joe Darcy wrote:
Hello,
Please review the fix below to address
JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}
by a quick-and-dirty generification and deprecation of some very old classes
looks fine Roger as am sure this will make the doclint warnings less
On Jan 22, 2014, at 4:26 PM, roger riggs wrote:
Please review this javadoc improvement to add @param tags to readObject
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-time-param-8032502/
Thanks, Roger
Lance
+1
On Jan 24, 2014, at 3:31 PM, huizhe wang wrote:
Hi,
Please review a javadoc change to javax.xml.stream factories. This change
makes it clear that the two args ServiceLoader#load method is used when the
specified classLoader is not null.
looks fine. getting rid of tt and code, is something I guess we should
look to do throughout all of our code?
On Jan 31, 2014, at 1:33 PM, roger riggs wrote:
Please review a typo and javadoc cleanup for java.util.Date
webrev:
http://cr.openjdk.java.net/~rriggs/webrev-date-typo-8032221/
Hi Mandy
This looks OK to me
On Feb 12, 2014, at 12:46 PM, Mandy Chung wrote:
This patch cleans up a few trivial native warnings (mainly remove local
unreferenced variable)
https://bugs.openjdk.java.net/browse/JDK-8030010
Webrev at:
Looks fine. assume the code/code will be addressed as part of a full sweep
of javax/naming
On Feb 14, 2014, at 2:48 PM, Ivan Gerasimov wrote:
Hello!
May I please have a review of the fix?
It's not meant to be a proof reading, I only fixed some obvious typos.
Some of them were reported
Looks Ok. Kind of surprised the tck tests have no assertion details in the
tests. Minor nit would have been nice to have even a minor comment for the new
method DateTimeFormatterBuilder though that seems to be the norm in some
scenarios for the smaller methods.
On Feb 28, 2014, at 4:48 PM,
On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
nitpicking,
(1) shouldn't the variable at #468 to be updated to lch instead of uch as
well?
I would agree given you are now calling Character.toLowerCase
(2) StringBuilder can be used to replace the StringBuffer in toString().
Agree, but I
On Mar 5, 2014, at 5:10 PM, huizhe wang wrote:
On 3/5/2014 12:46 PM, Lance Andersen - Oracle wrote:
On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
nitpicking,
(1) shouldn't the variable at #468 to be updated to lch instead of uch
as well?
I would agree given you are now calling
I think this OK.
The comments with the o--o did not do much for me though and found them a bit
confusing but perhaps I need more coffee this morning ?
Also, not sure we need the @author tag but I think its usage varies in the
workspace
Best
Lance
On Mar 19, 2014, at 7:10 PM, David Li wrote:
Hi Sean,
I think this looks good. ship it :-)
Best
Lance
On Jun 25, 2012, at 4:26 PM, Sean Coffey wrote:
Hi,
I'm looking for a code review around the following corba changes. It turns
out that we've a few bug fixes in corba area for jdk6 that were never forward
ported to jdk7 or 8. The
Hi Deven,
Thanks for the email and the proposed patch. I will look at this later today
or tomorrow. I actually have made these changes in my workspace for JDK 8 but
will compare your changes to mine.
Best
Lance
On Jul 2, 2012, at 5:04 AM, Deven You wrote:
Hi All,
Could anyone notice this
being thrown.
2. getBinaryStream(long pos,long length)
add a javadoc:
* @throws SerialException if this SerialBlob already be freed.
add throws SerialException from this method
Any suggestions?
Thanks a lot!
On 07/02/2012 06:25 PM, Lance Andersen - Oracle wrote:
Hi Deven
+1
Best
Lance
On Jul 12, 2012, at 5:42 AM, Paul Sandoz wrote:
Hi Joe,
On Jul 11, 2012, at 7:59 AM, Joe Wang wrote:
Hi Paul,
This is now for 7u8, so I started a new thread.
As we discussed, I've removed the hack of using escapeNonUSAscii. In this
regard, we're now in sync with the
Looking for a reviewer for the following change:
- add a call to Thread.currentThread().getContextClassLoader() to
DriverManager.getDriver()
- Remove the synchronized block for the same call in getConnection()
Thank you.
Best
Lance
localhost:sql lanceandersen$ hg diff DriverManager.java
/classes/java/sql/DriverManager.java:
Line 334 in deregisterDriver(Driver driver)
Line 365 in getDrivers()
Thanks,
Dave
On Fri, Aug 10, 2012 at 1:19 PM, Lance Andersen - Oracle
lance.ander...@oracle.com wrote:
Looking for a reviewer for the following change:
- add a call
Hi Sean,
This looks good.
Best
Lance
On Aug 14, 2012, at 12:38 PM, Seán Coffey wrote:
I'm looking to forward port this corba fix from 6u34 to jdk8 (and eventually
port to 7u)
d.macdon...@auckland.ac.nz originally reported this issue and I'll be marking
the fix as contributed by him.
Hi Joe,
Looks fine.
Best
Lance
On Aug 17, 2012, at 12:07 AM, Joe Wang wrote:
In the patch for 6756677, we fixed errors in StAX's input and output
factories where factoryId such as 'javax.xml.stream.XMLInputFactory was
taken as factory class e.g.
This looks fine.
Dan, I will commit this for you Thursday
Best
Lance
On Aug 29, 2012, at 1:29 AM, Dan Xu wrote:
I made a simple fix to clean up build warnings in java.sql package. The
change can be reviewed at http://cr.openjdk.java.net/~dxu/7193683/webrev.01/.
Thanks!
-Dan
Lance
Hi all,
Looking for a reviewer for the removal of PropertyChangeSupport from
JDBCRowSetImpl that was originally going to be used by the EOL Rave product.
As it is no longer needed the code has been removed. The SQE and RowSet TCK
tests all continue to run without regression.
The webrev can
. SQE and RowSet TCKs
continue to pass with these changes.
Best
Lance
On Sep 5, 2012, at 5:17 PM, Alan Bateman wrote:
On 05/09/2012 22:04, Lance Andersen - Oracle wrote:
Hi all,
Looking for a reviewer for the removal of PropertyChangeSupport from
JDBCRowSetImpl that was originally going
Thank you for the comments Alan
On Sep 6, 2012, at 9:00 AM, Alan Bateman wrote:
On 06/09/2012 13:40, Lance Andersen - Oracle wrote:
Here is the updated webrev
http://cr.openjdk.java.net/~lancea/7192302/webrev.01
I know there is more clean-up that can be done to remove other Rave added
On Sep 6, 2012, at 9:31 AM, Alan Bateman wrote:
On 06/09/2012 14:09, Lance Andersen - Oracle wrote:
:
The latest webrev looks okay except that in one of the constructors you
have removed a call to ensure that the connection is established, I'm not
sure about the significance
Hi Mandy,
Thank you also for the feedback along with Alan. I will push these back shortly
and also create a CR.
Best
Lance
On Sep 6, 2012, at 11:04 AM, Mandy Chung wrote:
Lance,
On 9/6/2012 5:40 AM, Lance Andersen - Oracle wrote:
Here is the updated webrev
http://cr.openjdk.java.net
Hi Alan,
The connect method is used by the RI not the RowSet spec. It was made
protected for Rave.
Best
Lance
On Sep 6, 2012, at 1:21 PM, Alan Bateman wrote:
Lance,
I see you've just pushed this but one thing I didn't spot initially is that
in the second webrev you changed the protected
The recommended way to access a rowset is via the factory now.For whatever
reason the original authors chose not to provide a factory.
The connect() method has always been a method to be used internally by
JdbcRowSetRIImpl and Rave. There is no reason for a user of the API to ever
have to
looks OK Dan and I was able to access the URL and download the zip
Best
Lance
On Sep 18, 2012, at 1:29 AM, Dan Xu wrote:
Hi,
This is the change to correct a java doc link in java.util.zip package page.
The webrev can be reviewed at
http://cr.openjdk.java.net/~dxu/7195933/webrev/.
Hi,
This is a review request for adding @Deprecated to the remaining JDBC methods
to suppress compiler warnings. The CCC was approved as this annotation results
in the signatures changing (though they do not effect the execution of any
applications).
The webrev is
Look OK Joe
On Oct 9, 2012, at 12:31 AM, Joe Wang wrote:
This is an issue found while I was working with SQE to expand test coverage.
For a non-validating parser, when load-external-dtd is false, entity
references are skipped. However, the skippedEntity() event was not reported.
The
looks fine Sean
Best
Lance
On Oct 9, 2012, at 2:38 PM, Seán Coffey wrote:
steve.si...@oracle.com has contributed the following patch which I'd like to
push to jdk8 TL. It's the correction of copyright years in corba repo.
Need a reviewer.
webrev :
looks fine Alan and in line with the other work we have done
Best
Lance
On Oct 10, 2012, at 7:19 AM, Alan Bateman wrote:
JEP 162 [1] captures a number of things that we can do in preparation for
future modularization of the platform. One of these items is deprecating the
Java SE APIs that
Need a reviewer for a simple typo in the DriverManager javadoc
new-host-2:sql lanceandersen$ hg diff
diff -r 036c55976cef src/share/classes/java/sql/DriverManager.java
--- a/src/share/classes/java/sql/DriverManager.java Tue Oct 09 08:58:27
2012 -0400
+++
Hi,
Looking for a reviewer for the removal of the following non-used fields in
SyncFactory
private static String default_provider
private static Level rsLevel
private static Object logSync
private static java.io.PrintWriter logWriter
Best
Lance
new-host-2:spi lanceandersen$ hg
looks fine alan
On Oct 11, 2012, at 9:40 AM, Alan Bateman wrote:
This is a follow-on from yesterday's mail on deprecating the LogManager's
add/removePropertyChangeListener methods. The other 4 problematic methods
identified in JEP 162 [1] are the same name methods on Pack200.Packer and
Hi,
Need a review for changing to use the XXX.valueOf methods from constructors.
Thank you
Best
Lance
new-host-2:rowset lanceandersen$ hg status -m
M src/share/classes/com/sun/rowset/CachedRowSetImpl.java
M src/share/classes/com/sun/rowset/FilteredRowSetImpl.java
M
Hi,
Revised CachedRowSetImpl as I noticed Findbugs missed a scenario where you
should use the XXX.valueOf methods from constructors.
Thank you
Best
Lance
new-host-2:rowset lanceandersen$ hg status -m
M src/share/classes/com/sun/rowset/CachedRowSetImpl.java
M
This fix is fine Dan
Best
Lance
On Oct 25, 2012, at 5:45 PM, Dan Xu wrote:
Hi,
Please help review the javadoc typo fix at,
http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks!
-Dan
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1
Hi Deven,
I will address the needed updates a bit later.
Thank you for your input
Best
Lance
On Oct 29, 2012, at 3:51 AM, Deven You wrote:
Hi Alan,
The Java Spec does not mention the thread safe for JDBC API. But I see the
other code in SerialBlob/SerialClob have not consider it.
I
Hi,
This is a request for review of
http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds
read/writeObject as well as clone methods to SerialXLob classes.
All SQE tests passed, 1 failure in the RowSet JCK/TCK tests due to a bug in
the test that the TCK team is aware of and will
Lance Andersen - Oracle:
Hi,
This is a request for review of
http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds
read/writeObject as well as clone methods to SerialXLob classes.
All SQE tests passed, 1 failure in the RowSet JCK/TCK tests due to a bug in
the test
Hi Remi,
Thank you for the feedback
On Oct 30, 2012, at 2:05 PM, Remi Forax wrote:
On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote:
Hi,
This is a request for review of
http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds
read/writeObject as well as clone methods
the subject of the request in clear text in the list view of the
email client would be a great help.
-Ulf
Am 30.10.2012 19:28, schrieb Lance Andersen - Oracle:
Hi Ulf,
The bug is described below, it is just adding the read/writeObject and clone
methods.
Best
Lance
On Oct 30, 2012
Here is revised webrev taking into account Remi's suggestions
http://cr.openjdk.java.net/~lancea/8001536/webrev.01/
Best,
Lance
On Oct 30, 2012, at 2:05 PM, Remi Forax wrote:
On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote:
Hi,
This is a request for review of
http
looks fine
On Nov 1, 2012, at 5:12 PM, Alan Bateman wrote:
I need a reviewer to remove 5 tests from the exclude list. 4 of the tests
were excluded temporarily during the perm gen removal work. The other one was
a compiler2 bug that is long fixed.
While I was there I updated TEST.ROOT
This is similar to 8001536, just additional classes.
This adds read/writeObject, equals, clone methods to additional SerialXXX
classes
SQE, JCK and JDBC Unit tests all pass.
The webrev can be viewed at http://cr.openjdk.java.net/~lancea/8002212/webrev.00
Best
Lance
Lance Andersen| Principal
Hi Remi,
Thank you for the feedback
On Nov 2, 2012, at 7:42 PM, Remi Forax wrote:
On 11/02/2012 11:57 PM, Lance Andersen - Oracle wrote:
This is similar to 8001536, just additional classes.
This adds read/writeObject, equals, clone methods to additional SerialXXX
classes
SQE, JCK
Andersen - Oracle wrote:
This is similar to 8001536, just additional classes.
This adds read/writeObject, equals, clone methods to additional SerialXXX
classes
SQE, JCK and JDBC Unit tests all pass.
The webrev can be viewed at
http://cr.openjdk.java.net/~lancea/8002212/webrev.00
Hi Lance
On Nov 3, 2012, at 11:14 AM, Remi Forax wrote:
On 11/03/2012 01:46 AM, Lance Andersen - Oracle wrote:
Hi Remi,
[...]
In SerialDataLink, do you really need readObject/writeObject given
that you call the default implementations.
I thought about that but had decided to add them
On Nov 3, 2012, at 11:34 AM, Remi Forax wrote:
On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote:
I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01,
taking into account the vast majority of Remi's suggestions.
in SerialJavaObject, hasStaticFields doesn't work
Is there a reason the patch was not created originally leveraging
try-with-resoruces as it seems like the perfect candidate from the webrev?
I can create a bug for it, but I think I would prefer to see the patch take
advantage of try-with-resoruces
Best
Lance
On Nov 7, 2012, at 3:30 PM, Andrew
The bug number is 8003120
Best
Lance
On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote:
IcedTea bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
com.sun.naming.internal.ResourceManager.getApplicationResources() does not
close the input streams it gets from
Frank,
If you can please post the bug info here, I will take a look at your patch
Best
Lance
On Nov 8, 2012, at 10:01 PM, Frank Ding wrote:
Hi guys,
We discovered a bug in CachedRowSetWriter.writeData method where incorrect
number of conflicts is reported. I searched in Oracle bug
at
com.sun.rowset.internal.CachedRowSetWriter.writeData(CachedRowSetWriter.java:412)
at com.sun.rowset.CachedRowSetImpl.acceptChanges(CachedRowSetImpl.java:880)
5. In fact, there is only one conflicting row but 4 were reported.
Best regards,
Frank
On 11/9/2012 7:41 PM, Lance Andersen
looks Ok.
On Nov 14, 2012, at 4:15 PM, Jim Gish wrote:
Please review
http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/
http://cr.openjdk.java.net/%7Ejgish/Bug8003380-logging-test-warnings/
These are simple changes to eliminate compiler warnings from
java.util.logging
Andersen - Oracle wrote:
Hi Deven,
I will address the needed updates a bit later.
Thank you for your input
Best
Lance
On Oct 29, 2012, at 3:51 AM, Deven You wrote:
Hi Alan,
The Java Spec does not mention the thread safe for JDBC API. But I see the
other code in SerialBlob/SerialClob
Hi,
For JDBC 4.2, I am adding methods to allow for larger update counts (request
from JDBC driver vendors) and because of this I have to tweak
BatchUpdateException
The Statement interface has the method
int[] executeBatch()
I am planning to add
long[] executeLargeBatch().
To accomodate
documenting the correctness conditions regarding the updateCounts and
longUpdateCounts fields; I think that would ease reviewing the new
constructors and serialization code.
Cheers,
-Joe
On 11/24/2012 2:05 PM, Lance Andersen - Oracle wrote:
Hi,
For JDBC 4.2, I am adding methods
would throw an IllegalStateException if invoking e.g. getUpdateCounts on
integer overflow.
-Ulf
Am 26.11.2012 20:44, schrieb Lance Andersen - Oracle:
Hi Joe,
Thank you for the sanity check.
I had added the following to the top of the javadoc (still playing with the
wording
On Nov 30, 2012, at 7:56 AM, Remi Forax wrote:
On 11/30/2012 01:50 PM, Lance Andersen - Oracle wrote:
On Nov 30, 2012, at 4:58 AM, Chris Hegarty wrote:
On 30/11/2012 02:03, David Holmes wrote:
On 30/11/2012 12:44 AM, Chris Hegarty wrote:
On 11/29/2012 05:50 AM, David Holmes wrote
, Lance Andersen - Oracle
lance.ander...@oracle.com wrote:
On Nov 30, 2012, at 4:58 AM, Chris Hegarty wrote:
On 30/11/2012 02:03, David Holmes wrote:
On 30/11/2012 12:44 AM, Chris Hegarty wrote:
On 11/29/2012 05:50 AM, David Holmes wrote:
...
I don't agree that we need
it. By the way, the new Oracle bug
(internal id 2376620) submitted by me several days ago seems not having been
reviewed. Could you also help me on this?
Best regards,
Frank
On 11/30/2012 8:40 PM, Lance Andersen - Oracle wrote:
Hi Frank,
Thank you for the email. No we do not want tests
I am still wondering if we need some sort of javadoc tag for default
implementations so that it will stand out better and allow us to be consistent
with how we specify this across Java SE and other APIs that leverage default
methods.
Has any thought been given to this?
Best
Lance
On Dec 5,
Folks,
Will the signatures for interfaces that are recorded by the TCKs for interfaces
record the fact that a method includes a default method? or will it just record
the method definition?
I am assuming it will, but I know there has been discussion that a implementor
could choose a different
Looks fine Rob
On Dec 6, 2012, at 4:22 PM, Rob McKenna wrote:
Hi folks,
There's a missing folder in the jdk_other test target:
http://cr.openjdk.java.net/~robm/8004337/webrev.01/
http://cr.openjdk.java.net/%7Erobm/8004337/webrev.01/
-Rob
Lance Andersen| Principal Member of
. By the way, the newly added unit test is not
jtreg test case?
Best regards,
Frank
On 12/5/2012 4:38 AM, Lance Andersen - Oracle wrote:
All,
Attached is the patch for: 8004374 based off the issue that Frank reported.
for http://cr.openjdk.java.net/~lancea/8004374/webrev.00/
http
Need a reviewer for 8004357:Implement various methods in
SerialBlob/Clob/Array and specify Thread Safety
This defines thread safety adds missing methods to SerialBlob/Clob/Array
The CCC request has been reviewed. The changes uncovered a couple of bugs in
the JCK which the JCK team is
On Dec 14, 2012, at 7:28 AM, Alan Bateman wrote:
On 14/12/2012 01:24, Akhil Arora wrote:
As part of the library lambdafication, this patch adds a forEach default
method to Iterator, and converts remove() into a default method so that
implementations of Iterator no longer have to override
Hi Joe,
Shouldn't this also be private:
static final char [] xmlDecl = {'','?','x','m','l'};
otherwise it is fine
Best
Lance
On Dec 14, 2012, at 1:33 PM, Joe Wang wrote:
Hi,
This is one of the three [findbug] issues. I've checked with Drew. None of
them are vulnerabilities. Nonetheless,
Thanks Joe. maybe a quick comment would help in the code could be useful
Best
Lance
On Dec 14, 2012, at 2:49 PM, Joe Wang wrote:
On 12/14/2012 10:36 AM, Lance Andersen - Oracle wrote:
Hi Joe,
Shouldn't this also be private:
static final char [] xmlDecl = {'','?','x','m','l
+1
On Dec 14, 2012, at 3:43 PM, Joe Wang wrote:
Thanks. I added a comment. Here's the webrev again:
http://cr.openjdk.java.net/~joehw/7u12/8003260/webrev/
Best
Joe
On 12/14/2012 11:52 AM, Lance Andersen - Oracle wrote:
Thanks Joe. maybe a quick comment would help in the code could
me know.
Thanks a lot!
On 11/24/2012 12:45 AM, Lance Andersen - Oracle wrote:
It is on my list. to update the javadocs I need a ccc which I have not done
yet and is needed as part of this change
On Nov 23, 2012, at 3:07 AM, Deven You wrote:
Hi Lance,
Is there any plan
for implementing these methods are committed.
Do you have a plan to add the test cases[1] I created too?
Thanks a lot!
[1]http://cr.openjdk.java.net/~youdwei/OJDK-576/webrev.01/
On 01/10/2013 08:31 PM, Lance Andersen - Oracle wrote:
Deven,
This was pushed a while ago you should
The following webrev has the bulk of the JDBC 4.2 changes:
http://cr.openjdk.java.net/~lancea/8005080/webrev.00/
There will be additional updates to java.sql.Date/TIme/Timestamp (by Sherman)
once JSR 310 is integrated to aide in moving to and from the new date time
datatypes.
I will also
On Jan 11, 2013, at 2:05 PM, Joe Wang wrote:
On 1/11/2013 8:58 AM, Alan Bateman wrote:
On 09/01/2013 14:28, Daniel Fuchs wrote:
Hi,
Here is a new webrev in the series that addresses using ServiceLoader in
JAXP for JDK 8.
7169894: JAXP Plugability Layer: using service loader
This
Hi
This is a review request for 8006139 which adds missing methods to
SQLInput/Output
The webrev can be found at http://cr.openjdk.java.net/~lancea/8006139/webrev.00/
best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
thread, these classes are hardly ever, if at all
used and would only be used when UDTs are used and the majority of databases do
not support this.
Best
lance
On Jan 14, 2013, at 5:11 AM, Alan Bateman wrote:
On 13/01/2013 23:51, Lance Andersen - Oracle wrote:
:
One other thing is that the CCE
+1
On Jan 15, 2013, at 12:59 PM, Chris Hegarty wrote:
Minor oversight in the changes from 7193719: Support repeating annotations
in javax.lang.model.
~/repos/jdk8/tl/adder/build/solaris-i586/impsrc/javax/lang/model/element/Element.java:199:
warning - Tag @see: can't find getAnnotation()
Thank you Ulf.
I deleted the extra line on 579
Best
Lance
On Jan 15, 2013, at 3:45 PM, Ulf Zibis wrote:
Looks great!
Little nit:
SQLOutputImpl.java line 579 could be dropped.
-Ulf
Am 15.01.2013 17:48, schrieb Lance Andersen - Oracle:
Here is a revision
http
On Jan 19, 2013, at 9:43 AM, Alan Bateman wrote:
On 15/01/2013 16:48, Lance Andersen - Oracle wrote:
Here is a revision
http://cr.openjdk.java.net/~lancea/8006139/webrev.01
I still have to enter the JBS entry for the javadoc clarifications (and I
also found another javadoc issue
1 - 100 of 262 matches
Mail list logo
