Review Request 69576: ATLAS-3002: added instrumentation to collect time taken for sub-tasks during entity create/update

2018-12-17 Thread Madhan Neethiraj
/src/main/java/org/apache/atlas/metrics/Metrics.java e0f4e4948 webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java 926acfb67 webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 165ea91b7 Diff: https://reviews.apache.org/r/69576/diff/1/ Testing --- - verified the instumentation output in metric.log - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/868/ Thanks, Madhan Neethiraj

Review Request 69587: ATLAS-3002: added instrumentation to collect time taken for sub-tasks during entity create/update

2018-12-18 Thread Madhan Neethiraj
org/apache/atlas/RequestContext.java 099d713f6 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java e0a60a133 webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java b5e7ed871 webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java b95594831 Diff: https://reviews.apache.org/r/69587/diff/1/ Testing --- - verified the instumentation output in metric.log - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/869 Thanks, Madhan Neethiraj

Re: Review Request 69587: ATLAS-3002: added instrumentation to collect time taken for sub-tasks during entity create/update

2018-12-18 Thread Madhan Neethiraj
tion/EntityNotificationListenerV2.java e0a60a133 webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java b5e7ed871 webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java b344c50e6 Diff: https://reviews.apache.org/r/69587/diff/2/ Changes: https://reviews.apache.org/r/69587/diff/1-2/ Testing --- - verified the instumentation output in metric.log - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/869 Thanks, Madhan Neethiraj

Review Request 69631: ATLAS-3006: option to ignore/prune hive entities in hook notifications

2018-12-24 Thread Madhan Neethiraj
temp.tempTable; INSERT INTO TABLE prod.prodTable SELECT * FROM prod.myView_stg; INSERT INTO TABLE prod.prodTable SELECT * FROM staging.stagingView; INSERT INTO TABLE prod.prodTable SELECT * FROM prod.prodSourceTable; Thanks, Madhan Neethiraj

Review Request 69632: ATLAS-3006: option to ignore/prune hive entities in hook notifications

2018-12-25 Thread Madhan Neethiraj
prod.prodTable SELECT * FROM prod.prodSourceTable; Thanks, Madhan Neethiraj

Re: Review Request 69632: ATLAS-3006: option to ignore/prune hive entities in hook notifications

2018-12-26 Thread Madhan Neethiraj
prod.prodTable SELECT * FROM prod.prodSourceTable; Thanks, Madhan Neethiraj

Re: Review Request 69631: ATLAS-3006: option to ignore/prune hive entities in hook notifications

2018-12-26 Thread Madhan Neethiraj
temp.tempTable; INSERT INTO TABLE prod.prodTable SELECT * FROM prod.myView_stg; INSERT INTO TABLE prod.prodTable SELECT * FROM staging.stagingView; INSERT INTO TABLE prod.prodTable SELECT * FROM prod.prodSourceTable; Thanks, Madhan Neethiraj

Re: Review Request 69682: ATLAS-3024 On hive_db rename few attributes are still not renamed after successful import

2019-01-09 Thread Madhan Neethiraj
me:timeStamp For more details, please look into BaseHiveEvent.getQualifiedName(inputs, outputs) - https://github.com/apache/atlas/blob/master/addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java#L752 - Madhan Neethiraj On Jan. 7, 2019, 2:06 p.m., Kapildeo

Re: Consensus for migration of git repositories to gitbox

2019-01-09 Thread Madhan Neethiraj
+1 Thanks Apoorv for volunteering. Please keep the community updated of the progress and actions to be done by each to access the migrated repo. Thanks, Madhan On 1/9/19, 11:01 PM, "Ashutosh Mestry" wrote: +1 for migrating Atlas repositories. Thanks Apoorv! ~ ashutos

Re: Consensus for migration of git repositories to gitbox

2019-01-11 Thread Madhan Neethiraj
. Only bugfixes should go into maint branches (like branch-1.0), hence it should be safer. Thanks, Madhan From: David Radley Date: Thursday, January 10, 2019 at 2:44 AM To: Madhan Neethiraj Cc: "dev@atlas.apache.org" Subject: Re: Consensus for migration of git repos

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-11 Thread Madhan Neethiraj
hanced to include more criterion - like 'createTime', 'modifiedTime', 'entityType' - Madhan Neethiraj On Jan. 10, 2019, 11:52 p.m., Ashutosh Mestry wrote: > > --- > This

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-13 Thread Madhan Neethiraj
il. To reply, visit: > https://reviews.apache.org/r/69707/ > --- > > (Updated Jan. 14, 2019, 5:23 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, > and Sarath Subramanian. >

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-14 Thread Madhan Neethiraj
nt297591> Consider adding AtlasEntityStore.setClassifications() method (similar to add/update/delete classification methods) and call it directly from here, instead of going through classificationAssociator. - Madhan Neethiraj On Jan. 15, 2019,

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-17 Thread Madhan Neethiraj
ent297746> 'Updater' class is no more used. If true, please remove. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 98 (original), 98 (patched) <https://reviews.apache.org/r/69707/#comment297745> Why remove 'final

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-18 Thread Madhan Neethiraj
lassification classification : toDelete) { entityStore.deleteClassification(existingEntity.getGuid(), classification.getName()); } } - Madhan Neethiraj On Jan. 18, 2019, 7:40 p.m., Ashutosh Mestry wrote: > > --- > This is an automati

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-20 Thread Madhan Neethiraj
te operations. One option is for computeChanges() to ignore them. - Madhan Neethiraj On Jan. 20, 2019, 4:49 p.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-21 Thread Madhan Neethiraj
-classification-updates.patch Lines 1 (patched) <https://reviews.apache.org/r/69707/#comment297846> Patch file included by mistake? Please remove before committing the patch. - Madhan Neethiraj On Jan. 21, 2019, 7:59 p.m., Ashutosh Mestry

Re: Review Request 69804: ATLAS-3034: Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-21 Thread Madhan Neethiraj
review. - Madhan Neethiraj On Jan. 21, 2019, 11:30 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 69804: ATLAS-3034: Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-22 Thread Madhan Neethiraj
the interface, consider the following: ret = getOrCreateRelationship(fromVertex, toVertex, relationship); boolean isCreated = getSystemProperty(ret, TIMESTAMP_PROPERTY_KEY) == RequestContext.get().getRequestTime(); if (isCreated) { recordEntityUpdate(attributeVert

Re: Review Request 69804: ATLAS-3034: Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69804/#review21 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 23, 2019, 5:25

Review Request 69816: ATLAS-3035: updated entity-get/delete to retrieve/delete soft-ref entities

2019-01-23 Thread Madhan Neethiraj
-ref entities - verified that entity-delete marks owned-ref soft-ref entities as deleted Thanks, Madhan Neethiraj

Re: Review Request 69816: ATLAS-3035: updated entity-get/delete to retrieve/delete soft-ref entities

2019-01-23 Thread Madhan Neethiraj
/v2/EntityGraphRetriever.java Lines 780 (patched) <https://reviews.apache.org/r/69816/#comment297984> mapVertexToObjectId() needs edgeLabel and edge to find the vertex to map. This one is specifically for soft-ref entities. - Madhan Neethiraj On Jan. 23, 2019, 9 a.m., Madhan Nee

Re: python client for atlas

2019-01-26 Thread Madhan Neethiraj
Tao, Atlas supports REST and Java APIs, however there are no equivalent Python library. If use of Jython is feasible, you can consider using Atlas Java API from Python (AtlasClientV2 - https://github.com/apache/atlas/blob/master/client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.jav

Review Request 69844: ATLAS-3037: fixed is-entity-updated detection to handle object-id attributes correctly

2019-01-26 Thread Madhan Neethiraj
unit and integration tests pass successfully Thanks, Madhan Neethiraj

Re: Review Request 69822: ATLAS-3033 - ATLAS Hive hook fails for CTAS query involving UDFs

2019-01-26 Thread Madhan Neethiraj
= toTableEntity(table, entityExtInfo); } } break; - Madhan Neethiraj On Jan. 23, 2019, 3:07 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 69846: ATLAS-3036: Improve FullTextMapper performance during entity retrieval (Master branch)

2019-01-27 Thread Madhan Neethiraj
- #863 go here } } else { ret = getPrimitiveMap(entityVertex, attribute.getVertexPropertyName()); } Similarly review and update mapVertexToArray() as well. - Madhan Neethiraj On Jan. 28, 2019, 12:56 a.m., Sarath Subramanian wrote: > > --

Re: Review Request 69835: ATLAS-3036: Improve FullTextMapper performance during entity retrieval (branch-0.8)

2019-01-27 Thread Madhan Neethiraj
java Line 579 (original), 596 (patched) <https://reviews.apache.org/r/69835/#comment298146> It will be efficient to bail out earlier, in case of includeReferences=false && isReferenceType(mapValueType). Similarly review and update mapVertexToArray() as well. - Madhan

Review Request 69847: ATLAS-3037: updated createOrUpate() API to skip entities that don't have any change in attribute values

2019-01-27 Thread Madhan Neethiraj
tests pass successfully Thanks, Madhan Neethiraj

Re: Review Request 69822: ATLAS-3033 - ATLAS Hive hook fails for CTAS query involving UDFs

2019-01-28 Thread Madhan Neethiraj
/apache/atlas/hive/hook/HiveHook.java Lines 151 (patched) <https://reviews.apache.org/r/69822/#comment298151> Please replace hardcoded value "Values__Tmp__Table__" with constant SemanticAnalyzer.VALUES_TMP_TABLE_NAME_PREFIX. - Madhan Neethiraj On Jan. 28, 2019, 12:21 p.m.,

Re: Review Request 69847: ATLAS-3037: updated createOrUpate() API to skip entities that don't have any change in attribute values

2019-01-28 Thread Madhan Neethiraj
at the vertex will not help here. - Madhan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69847/#review212393 ------- On Jan

Re: Review Request 69835: ATLAS-3036: Improve FullTextMapper performance during entity retrieval (branch-0.8)

2019-01-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69835/#review212403 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 29, 2019, 4:41

Re: Review Request 69846: ATLAS-3036: Improve FullTextMapper performance during entity retrieval (Master branch)

2019-01-30 Thread Madhan Neethiraj
sitory/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 864 (original), 888 (patched) <https://reviews.apache.org/r/69846/#comment298223> Wouldn't this cause to return null for non-object-id type attribute also? Please review and update.

Review Request 69877: ATLAS-3043: added unique-attributes constraints at store-level

2019-01-31 Thread Madhan Neethiraj
. Thanks, Madhan Neethiraj

Re: Review Request 69882: ATLAS-3044: fixed import to handle entity-delete

2019-02-03 Thread Madhan Neethiraj
/916/ Thanks, Madhan Neethiraj

Review Request 69915: ATLAS-3044: fixed import to handle entity-delete

2019-02-07 Thread Madhan Neethiraj
entities deleted through import - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/918 Thanks, Madhan Neethiraj

Re: Review Request 69926: Classification Updater: Updated to not use hard coded qualifiedName

2019-02-07 Thread Madhan Neethiraj
ttribute(getUniqueAttribute(header.getTypeName()); Currently, this statement returns the name of the uniqueAttribute; and not entity attribute value. - Madhan Neethiraj On Feb. 8, 2019, 12:01 a.m., Ashutosh Mestry wrote: > > -

Re: Review Request 69926: Classification Updater: Updated to not use hard coded qualifiedName

2019-02-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69926/#review212661 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 8, 2019, 6:18

Re: Review Request 69925: Removed hard-code Use of QualifiedName as Attribute

2019-02-08 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69925/#review212675 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 8, 2019, 6:56

Review Request 69940: ATLAS-3049: updates to avoid repeated calls to encode-property-key

2019-02-10 Thread Madhan Neethiraj
://reviews.apache.org/r/69940/diff/1/ Testing --- - verified that all UTs pass successfully - pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/922 Thanks, Madhan Neethiraj

Re: Contributor on Atlas

2019-02-13 Thread Madhan Neethiraj
Aadarsh, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 2/13/19, 12:22 PM, "aadarsh jajodia" wrote: Hello, I would like to contribute to Apache Atlas. Can you please add me as a

Re: Request to add as a contributor

2019-02-13 Thread Madhan Neethiraj
Sridhar, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan From: Sridhar Swamy Date: Wednesday, February 13, 2019 at 11:49 AM To: "dev@atlas.apache.org" Subject: Request to add as a c

Re: Request to add as a contributor.

2019-02-18 Thread Madhan Neethiraj
Binit, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 2/18/19, 9:44 AM, "Binit Gutka" wrote: Hi, I would like to contribute to Apache Atlas. Kindly add me as a contributor to th

Re: Commit to Atlas.

2019-02-19 Thread Madhan Neethiraj
Le, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 2/19/19, 2:15 PM, "Le Ma" wrote: Hello, I would like to contribute to Apache Atlas. Can you please add me as a contribu

Re: Need Contributor access to Apache Atlas projects

2019-02-26 Thread Madhan Neethiraj
Sridhar, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan From: Sridhar Koritala Date: Tuesday, February 26, 2019 at 10:15 AM To: "dev@atlas.apache.org" Subject: Need Contributor

[DRAFT] Board report for Apache Atlas: March 2019

2019-03-13 Thread Madhan Neethiraj
Atlas team, Please review the draft board report below and send your feedback/comments. Thanks, Madhan ## Description: Apache Atlas is a scalable and extensible set of core foundational governance services that enables enterprises to effectively and efficiently meet their c

Re: [DRAFT] Board report for Apache Atlas: March 2019

2019-03-14 Thread Madhan Neethiraj
ache Atlas: March 2019 Madhan thanks for draft, It looks good. Slight correction in needed in 2.0.0 release date. >> 2.0.0plan to release by 12/31/2018 Nixon On Thu, Mar 14, 2019 at 6:50 AM Madhan Neethiraj wrote:

Re: [DRAFT] Board report for Apache Atlas: March 2019

2019-03-14 Thread Madhan Neethiraj
ibm.com LinkedIn: http://www.linkedin.com/pub/mandy-chessell/22/897/a49 Assistant: Janet Brooks - jsbrook...@uk.ibm.com From: Madhan Neethiraj To: "dev@atlas.apache.org" Date: 14/03/2019 08:18 Subject:Re: [DRAFT] Board repor

Re: becoming a contributor

2019-03-18 Thread Madhan Neethiraj
Lina, Thank you for your interest in contributing to Apache Atlas. Can you please send you Apache JIRA id, so that I can add you as a contributor? If you don't have one yet, please signup for one at https://issues.apache.org/jira/secure/Signup!default.jspa. To join dev mailing list, please sen

Re: Becoming an Atlas contributor

2019-03-18 Thread Madhan Neethiraj
Xinran, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 3/18/19, 4:27 PM, "Xinran Yu" wrote: Hi, I would like to become Atlas contributor and my Apache Jira username is xyu2

Re: becoming a contributor

2019-03-19 Thread Madhan Neethiraj
Lina, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor (username=LinaAtAustin). Welcome to Apache Atlas community! Regards, Madhan On 3/18/19, 4:31 PM, "Madhan Neethiraj" wrote: Lina, Thank you for your interest in contr

Re: Add me as a Contributor for Atlas

2019-03-19 Thread Madhan Neethiraj
Chaitali, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 3/19/19, 11:23 PM, "Chaitali Borole" wrote: Hello, I would like to be a contributor for Apache Atlas. My jira id is

Re: would like to be a contributor

2019-03-19 Thread Madhan Neethiraj
Kiran, Thank you for your interest in contributing to Apache Atlas. Can you please send your Apache JIRA id, so that I can add you as a contributor? If you don't have one yet, please signup for one at https://issues.apache.org/jira/secure/Signup!default.jspa. Regards, Madhan On 3/19/19, 8:55

Re: Atlas Contributor Request

2019-03-20 Thread Madhan Neethiraj
Umesh, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 3/20/19, 12:02 AM, "Umesh S. Padashetty" wrote: Hi Atlas Team, I am interested in contributing to Apache Atlas project, ki

Re: would like to be a contributor

2019-03-20 Thread Madhan Neethiraj
Kiran, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan From: kirankumar D G Date: Wednesday, March 20, 2019 at 12:37 AM To: Madhan Neethiraj Cc: "dev@atlas.apache.org" S

Re: Integrating

2019-03-25 Thread Madhan Neethiraj
Daan, 1. "release-1.1.0-rc2" is the tag for 1.1.0 release - https://github.com/apache/atlas/tree/release-1.1.0-rc2 2. Sarath is working on a fix to address the storage configuration issue; the fix should get merged shortly (JIRA ATLAS-3099). Hope this helps. Madhan On 3/25/19, 9:40 AM, "Da

Re: [atlas] branch master updated: Missing AtlasEntityDef constructor for serviceType

2019-03-26 Thread Madhan Neethiraj
Diego, Apoorv - please make sure to prefix commit messages with Apache JIRA reference, like: ATLAS-3096: Missing AtlasEntityDef constructor for serviceType Thanks, Madhan On 3/25/19, 8:27 AM, "apoorvn...@apache.org" wrote: This is an automated email from the ASF dual-hosted git repos

Re: Review Request 70328: ATLAS-3092:Atlas Plugin ClassLoader Doesn't Restore Thread ClassLoader

2019-03-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70328/#review214145 --- Ship it! Ship It! - Madhan Neethiraj On March 28, 2019, 12

Re: Review Request 70333: ATLAS-3104: Fix stale transaction alerts in atlas logs

2019-03-28 Thread Madhan Neethiraj
is works; in some frameworks (like ORM) changes to the retrieved object are honored only in the scope of the transaction in which they are retrievd. - Madhan Neethiraj On March 28, 2019, 7:30 a.m., Sarath Subramanian wrote: > > --- >

Review Request 70347: ATLAS-3107: updated AtlasEntityDef with addition of read-only field relationshipAttributeDefs

2019-03-29 Thread Madhan Neethiraj
Diff: https://reviews.apache.org/r/70347/diff/1/ Testing --- - verified that entity-defs referenced in relationship-types are updated - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1007/ Thanks, Madhan Neethiraj

Re: Review Request 70357: ATLAS-3112: Allow Indexing of array attributes (LIST or SET) in indexing store

2019-04-01 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70357/#review214256 --- Ship it! Ship It! - Madhan Neethiraj On April 2, 2019, 4:37

Re: Review Request 70358: ATLAS-3113: Use index query to search for active entities and better logging in java patch framework

2019-04-01 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70358/#review214257 --- Ship it! Ship It! - Madhan Neethiraj On April 2, 2019, 4:43

Review Request 70359: ATLAS-3054: preprocess updated to add container entity reference in moved entities

2019-04-01 Thread Madhan Neethiraj
://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1010/ Thanks, Madhan Neethiraj

Re: Review Request 70359: ATLAS-3054: preprocess updated to add container entity reference in moved entities

2019-04-02 Thread Madhan Neethiraj
) --- - precommit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1011/ Thanks, Madhan Neethiraj

Re: Review Request 70359: ATLAS-3054: preprocess updated to add container entity reference in moved entities

2019-04-02 Thread Madhan Neethiraj
://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1011/ Thanks, Madhan Neethiraj

Re: Review Request 70357: ATLAS-3112: Allow Indexing of array attributes (LIST or SET) in indexing store

2019-04-03 Thread Madhan Neethiraj
value); } } else { for (Object value : values) { addToSetProperty(vertex, vertexPropertyName, value); } } - Madhan Neethiraj On April 2, 2019, 4:37 a.m., Sarath Subramanian wrote: > > ---

Re: Review Request 70359: ATLAS-3054: preprocess updated to add container entity reference in moved entities

2019-04-04 Thread Madhan Neethiraj
run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1011/ Thanks, Madhan Neethiraj

Re: Review Request 70359: ATLAS-3054: preprocess updated to add container entity reference in moved entities

2019-04-04 Thread Madhan Neethiraj
/notification/preprocessor/RdbmsPreprocessor.java adc19836a Diff: https://reviews.apache.org/r/70359/diff/5/ Changes: https://reviews.apache.org/r/70359/diff/4-5/ Testing --- - precommit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1011/ Thanks, Madhan

Re: Review Request 70359: ATLAS-3054: preprocess updated to add container entity reference in moved entities

2019-04-05 Thread Madhan Neethiraj
://reviews.apache.org/r/70359/diff/6/ Changes: https://reviews.apache.org/r/70359/diff/5-6/ Testing --- - precommit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1011/ Thanks, Madhan Neethiraj

Re: Review Request 70359: ATLAS-3054: preprocess updated to add container entity reference in moved entities

2019-04-05 Thread Madhan Neethiraj
nerated e-mail. To reply, visit: https://reviews.apache.org/r/70359/#review214401 --- On April 5, 2019, 7:04 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically

Re: Review Request 70343: AtlasGraphProvider Support for Graph with Batch-loading Enabled

2019-04-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70343/#review21 --- Ship it! Ship It! - Madhan Neethiraj On March 29, 2019, 6

Re: Review Request 70304: Improvements to PC Framework

2019-04-07 Thread Madhan Neethiraj
/atlas/pc/WorkItemConsumer.java Lines 64 (patched) <https://reviews.apache.org/r/70304/#comment300636> 'countdownLatch' might not be initialzied or null. Please review all references and update. Same for 'results'

Re: Atlas client request header

2019-04-07 Thread Madhan Neethiraj
Vasanth, AtlasBaseClient.setCoookie() allows the caller to send a custom-cookie with each request. A method similar to this can be added to support sending headers as well - like, addHeader(String name, String value). Can you please file a JIRA with an use-case showing the need for this update?

Re: Review Request 70422: Adding default value to the relationship

2019-04-08 Thread Madhan Neethiraj
uteDef().getDefaultValue(); if (StringUtils.isNotEmpty(defaultValue)) { AtlasGraphUtilsV2.setEncodedProperty(relationshipEdge, attrVertexProperty, attr.getAttributeType().createDefaultValue(defaultValue)); } } - Madhan Neethiraj On April 8, 2019, 8:06 a.m., Kirankum

Review Request 70437: ATLAS-3071: updated stats/metrics module to collect notification metrics

2019-04-09 Thread Madhan Neethiraj
41, "Notification:totalAvgTime": 758, "Notification:totalCreates": 3992989, "Notification:totalDeletes": 103, "Notification:totalFailed": 1450, "Notification:totalUpdates":148490, "Server:activeTimeStamp":1554841108133, "Server:startTimeStamp": 1554841108133, "Server:upTime": "1 day 2 hour 20 min 17 sec" } Thanks, Madhan Neethiraj

Re: Review Request 70437: ATLAS-3071: updated stats/metrics module to collect notification metrics

2019-04-10 Thread Madhan Neethiraj
ousHourEntityUpdates":0, "Notification:previousHourFailed": 0, "Notification:total":91641, "Notification:totalAvgTime": 758, "Notification:totalCreates": 3992989, "Notification:totalDeletes": 103, "Notification:totalFailed": 1450, "Notification:totalUpdates":148490, "Server:activeTimeStamp":1554841108133, "Server:startTimeStamp": 1554841108133, "Server:upTime": "1 day 2 hour 20 min 17 sec" } Thanks, Madhan Neethiraj

Re: Review Request 70433:

2019-04-10 Thread Madhan Neethiraj
in this file. - Madhan Neethiraj On April 9, 2019, 11:12 a.m., Ayush Nigam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 70462: ATLAS-3133 : Adding support for Process Executions in Atlas

2019-04-11 Thread Madhan Neethiraj
eviews.apache.org/r/70462/#comment300788> To be consistent with other base types (like AtlasServer, AtlasUserProfile, AtlasUserSavedSearch, ExportImportAuditEntry), consider renaming "Process_Execution" to "ProcessE

Re: Review Request 70463: ATLAS-3132: Improvements for Structure and Performance

2019-04-12 Thread Madhan Neethiraj
ory/store/graph/v2/AtlasGraphUtilsV2.java Lines 393 (patched) <https://reviews.apache.org/r/70463/#comment300830> findAllByTypeAndUniquePropertyName => findActiveEntityVerticesByTypeAndPropertyName - Madhan Neethiraj On April 12, 2019, 5:43 a.m., Ashutosh Mestry wrote: > > --

Review Request 70475: ATLAS-3139: updated basic search to include relationship attributes as well in the result

2019-04-15 Thread Madhan Neethiraj
-ATLAS-Build-Test/1033/ Thanks, Madhan Neethiraj

Re: Review Request 70463: ATLAS-3132: Improvements for Structure and Performance

2019-04-16 Thread Madhan Neethiraj
/atlas/repository/patches/UniqueAttributePatchProcessor.java Lines 206 (patched) <https://reviews.apache.org/r/70463/#comment300893> please verify if AtlasSchemaViolationException is thrown on commit or on setting property value. - Madhan Neethiraj On April 16, 2019, 6:15 a.m., Ashutosh

Review Request 70495: ATLAS-3147: added periodic logging of stats

2019-04-17 Thread Madhan Neethiraj
quot;:0,"Notification:currentHourFailed":0,"Notification:currentDayAvgTime":2116,"Notification:previousHourFailed":0,"Notification:total":1513,"Notification:previousDayEntityDeletes":0,"Server:activeTimeStamp":124379689,"Notification:previousDay":0,"Notification:offsetCurrent":1512,"Notification:previousHourAvgTime":2117,"Notification:previousDayFailed":0,"Notification:previousDayAvgTime":0} (NotificationHookConsumer:723) Thanks, Madhan Neethiraj

Re: Review Request 70488: PatchFx: Memory Usage Improvement

2019-04-17 Thread Madhan Neethiraj
rc/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java Line 204 (original), 200 (patched) <https://reviews.apache.org/r/70488/#comment300971> 'graph' can be made final as well. - Madhan Neethiraj On April 17, 2019,

Re: Contributor on Atlas

2019-04-18 Thread Madhan Neethiraj
Yu-Hsin, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 4/18/19, 3:31 PM, "Yu-Hsin Shih" wrote: Hello, I would like to contribute to Apache Atlas. Could you please add me a

Re: Review Request 70511: ATLAS-3121: Change version from 2.0.0-SNAPSHOT to 2.0.0

2019-04-21 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70511/#review214784 --- Ship it! Ship It! - Madhan Neethiraj On April 22, 2019, 3

Re: Add me as a Contributor for Atlas

2019-04-23 Thread Madhan Neethiraj
Rahul, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 4/23/19, 8:19 AM, "Rahul Kurup" wrote: Hello, I would like to be a contributor for Apache Atlas. My jira id is Rahul_FI

Re: [VOTE] Release Apache Atlas version 2.0.0 - rc0

2019-04-23 Thread Madhan Neethiraj
Sarath - thanks for putting this release together. Impressive set of enhancements. 250+ fixed JIRAs! +1 for Apache Atlas 2.0.0 release Performed the following: - downloaded tar.gz and verified the signature - built and installed Atlas for embedded HBase, Solr profile - started Atlas with embedde

Re: Repost: ReferredEntities in basic search API

2019-04-24 Thread Madhan Neethiraj
Verdan Mahmood, Using REST endpoint "POST /v2/search/basic", you can ask a set of entity attributes to be included in the search result. For attributes that refer to other entities (like hive_table.db), the entity-header details will be added in result.referrredEntities. For example, to includ

Re: Review Request 70536: ATLAS-3157: Add Integration tests for Hive metastore hook

2019-04-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70536/#review214852 --- Ship it! Ship It! - Madhan Neethiraj On April 24, 2019, 1

Re: Add me as a Contributor for Atlas

2019-04-24 Thread Madhan Neethiraj
Mandar, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 4/24/19, 6:23 AM, "Mandar Ambawane" wrote: Atlas community, I would like to be a contributor for Apache Atlas. My ji

Re: Review Request 70543: PatchFx: Support for HA Mode

2019-04-24 Thread Madhan Neethiraj
fer to leave out "@Order" annotation here. If you decide to leave "@Order" annotation in place, please add a comment that this service should be the last one. - Madhan Neethiraj On April 24, 2019, 10:42 p

Re: Repost: ReferredEntities in basic search API

2019-04-24 Thread Madhan Neethiraj
*Verdan Mahmood* (+31) 655 576 560 On Wed, Apr 24, 2019 at 2:17 PM Madhan Neethiraj wrote: > Verdan Mahmood, > > Using REST endpoint "POST /v2/search/basic", you can ask a set of entity > attributes to be included in the search result. For att

Re: Review Request 70543: PatchFx: Support for HA Mode

2019-04-24 Thread Madhan Neethiraj
s that are called from there. - Madhan Neethiraj On April 25, 2019, 12:02 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 70543: PatchFx: Support for HA Mode

2019-04-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70543/#review214873 --- Ship it! Ship It! - Madhan Neethiraj On April 25, 2019, 1

Re: [VOTE] Release Apache Atlas version 2.0.0 - rc0

2019-04-25 Thread Madhan Neethiraj
Ayush, Did you follow the steps in http://atlas.apache.org/InstallationSteps.html to build, install and start Atlas? It might be helpful to clear your .m2/repository directory and try agin. I followed above documentation to build for embedded-hbase-solr profile, and was able perform operations

Re: [VOTE] Release Apache Atlas version 2.0.0 - rc0

2019-04-25 Thread Madhan Neethiraj
Apr, 2019, 8:21 PM Madhan Neethiraj, wrote: > Ayush, > > Did you follow the steps in http://atlas.apache.org/InstallationSteps.html > to build, install and start Atlas? It might be helpful to clear your > .m2/repository directory and try agin. > &g

Re: Review Request 70574: Import Transforms: Fix QualifiedName Transformation

2019-04-30 Thread Madhan Neethiraj
/HiveTableEntityHandler.java Lines 133 (patched) <https://reviews.apache.org/r/70574/#comment301232> use of .replace() will not work db/tbl/clu are substrings of other - like: - dbName: default - tableName: test1 - clusterName: test (or default or t or ..) - Madhan Nee

Re: contribute to Atlas project

2019-05-01 Thread Madhan Neethiraj
Carol, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 4/30/19, 3:43 PM, "Carol Drummond" wrote: Would you please add me to the list of potential contributors to the Apache projec

Re: Review Request 70574: Import Transforms: Fix QualifiedName Transformation

2019-05-01 Thread Madhan Neethiraj
rmer with a call to setAttribute(HIVE_TABLE_NAME_ATTRIBUTE, newName). Also, how does this impact the 'tableName' in other entity-type's qualifiedName - like hive_column, hive_storagedesc? - Madhan Neethiraj On May 2, 2019, 5

Re: Add me as a Contributor for Atlas

2019-05-01 Thread Madhan Neethiraj
Mayank, Thanks for your interest in contributing to Apache Atlas. You have been added as a contributor. Welcome to Apache Atlas community! Regards, Madhan On 5/1/19, 11:05 PM, "mayank jain" wrote: Atlas community, I would like to be a contributor for Apache Atlas. My jira id i

Re: [VOTE] Release Apache Atlas version 2.0.0 - rc1

2019-05-02 Thread Madhan Neethiraj
Sarath - thanks for the updated release candidate. +1 for Apache Atlas 2.0.0 release candidate #1 Performed the following: - downloaded tar.gz and verified the signature - built and installed Atlas for embedded HBase, Solr profile - started Atlas with embedded HBase and Solr - ran QuickStart succ

<    1   2   3   4   5   6   7   8   9   10   >