Re: Review Request 53736: fix GEODE-2088 Incorrect TransactionDataNotColocatedException is thrown after bucket has been moved due to rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53736/#review155860 --- Ship it! Ship It! - Darrel Schneider On Nov. 14, 2016, 10

Re: Review Request 53657: GEODE-2091: Do not return false when containsValueForKey call failed in transaction due to BucketNotFoundException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53657/#review155649 --- Ship it! Ship It! - Darrel Schneider On Nov. 10, 2016, 12

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/#review155633 --- Ship it! Ship It! - Darrel Schneider On Nov. 10, 2016, 8:47

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

enerated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155516 --- On Nov. 9, 2016, 5:01 p.m., Darrel Schneider wrote: > > --- > This is an automatically ge

Re: Review Request 53637: GEODE-2090 Update off-heap statistics documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53637/#review155527 --- Ship it! Ship It! - Darrel Schneider On Nov. 9, 2016, 4:46

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

geode/internal/cache/VersionedThinRegionEntryOffHeapUUIDKey.java 5cb31ce1e67403f1b62ab06ec2499ad926ccb2bc Diff: https://reviews.apache.org/r/53632/diff/ Testing --- precheckin, spotlessCheck Thanks, Darrel Schneider

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

of the goals of pdx is that you do not need to be able to load the domain classes on the server, so you might not want to do this check. If you leave it with just a simple equals check you should document that in the case of pdx the value-constraint needs to exactly match (i.e. no instanceof s

Re: Review Request 53442: GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit

I think lockForTXCacheModification is now dead code - Darrel Schneider On Nov. 3, 2016, 4:08 p.m., Scott Jewell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 53503: GEODE-2077: throw appropriate exceptions when get call in transactions failed with certain exceptions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53503/#review155205 --- Ship it! Ship It! - Darrel Schneider On Nov. 7, 2016, 1:53

Re: Review Request 53442: GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53442/#review155204 --- Ship it! Ship It! - Darrel Schneider On Nov. 3, 2016, 4:08

Re: Review Request 53553: GEODE-2082: fix flakiness in sameKeepsOneFile

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53553/#review155203 --- Ship it! Ship It! - Darrel Schneider On Nov. 7, 2016, 11:25

Re: Review Request 53503: GEODE-2077: throw appropriate exceptions when get call in transactions failed with certain exceptions.

/apache/geode/internal/cache/PartitionedRegion.java (line 4020) <https://reviews.apache.org/r/53503/#comment225008> I think the following wording is clearer: // Make transaction fail so client can retry - Darrel Schneider On Nov.

Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

eImpl.java ba4f1f410cef89a276634dadecf46ac80d9c3990 geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ShutdownAllDUnitTest.java 1bb06f1ce1d93c801a51c1d8eb4f18ffeaa9f5cc Diff: https://reviews.apache.org/r/53355/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

. This broke ShutdownAllPersistentGatewaySenderDUnitTest - Darrel Schneider On Nov. 3, 2016, 3:16 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 53442: GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit

egions. That way you do not end up calling unlockTXRegions if exceptions cause you to never calls lockTXRegions. - Darrel Schneider On Nov. 3, 2016, 3:01 p.m., Scott Jewell wrote: > > --- > This is an automatically generate

Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

ache.org/r/53355/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53414/#review154767 --- Ship it! Ship It! - Darrel Schneider On Nov. 3, 2016, 10:04

Re: Review Request 53410: GEODE-2064 Added check for system shutdown while handlling connect exception.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53410/#review154766 --- Ship it! Ship It! - Darrel Schneider On Nov. 2, 2016, 4:41

Re: Review Request 53410: GEODE-2064 Added check for system shutdown while handlling connect exception.

/membership/gms/mgr/GMSMembershipManager.java (line 1707) <https://reviews.apache.org/r/53410/#comment224447> I noticed that lines 1707-1711 are duplicated in directChannelSend lines 1698-1702. Consider refactoring this code into a single method. - Darrel Schneider On Nov. 2, 2016, 4:

Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

(line 1016) <https://reviews.apache.org/r/53414/#comment22> I would change "integer number" to "number of". Almost all of our stats are integers so I don't think you need to say that. - Darrel Schneider On Nov. 2, 2016, 4:5

Re: Review Request 53431: GEODE-1821: Adjust timing to wait for async thread

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53431/#review154760 --- Ship it! Ship It! - Darrel Schneider On Nov. 3, 2016, 8:06

Re: Review Request 53402: GEODE-2013: throw IllegalStateException if resource type is missing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53402/#review154635 --- Ship it! Ship It! - Darrel Schneider On Nov. 2, 2016, 1:07

Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

Testing --- precheckin Thanks, Darrel Schneider

Re: Backwards compatibility for 1.1

yes +1 On Tue, Nov 1, 2016 at 4:00 PM, Dan Smith wrote: > Hi, > > We made a lot of changes in 1.0 that broke compatibility with old versions > of gemfire for various reasons (package renaming, changing membership > system). I just wanted to confirm that starting with 1.1,

Re: Review Request 53108: GEODE-2012: always write stat types to archive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review154425 --- Ship it! Ship It! - Darrel Schneider On Oct. 31, 2016, 4:54

Re: Review Request 53108: GEODE-2012: always write stat types to archive

tps://reviews.apache.org/r/53108/#comment223803> only the null check is needed here. Shouldn't this block also null out "notifier" if it stops it? Pull the code in lines 79-82 into a stopNotifier method and then call that method from here and there - Darr

Review Request 53268: GEODE-2043: change makeTombstone to handle exception

/ Testing --- precheckin and hydra test that was failing. Thanks, Darrel Schneider

Re: Tweaking the IntelliJ and Eclipse formatters

something I noticed that may have been caused by the reformatting was an end of line comment that ended up with one word on every line. A longer max line probably would have prevented this but now that everything has been reformatted with a max of 100 I doubt that it would combine comments like

Re: Review Request 53108: GEODE-2012: always write stat types to archive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review153965 --- Ship it! Ship It! - Darrel Schneider On Oct. 26, 2016, 2:45

Re: Review Request 53150: GEODE-2024 Deadlock creating a new distributed lock service Grantor while transactions are in progress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53150/#review153944 --- Ship it! Ship It! - Darrel Schneider On Oct. 25, 2016, 9:13

Re: Review Request 53108: GEODE-2012: always write stat types to archive

/HostStatSampler.java (line 279) <https://reviews.apache.org/r/53108/#comment223420> I would not check this change in. - Darrel Schneider On Oct. 21, 2016, 4:43 p.m., Kirk Lund wrote: > > --- > This is an automatically g

Re: Review Request 53154: GEODE-2026: fix flaky test

) - geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java 5ca3d014b4bac01e239561301666fae5fb0d61ea Diff: https://reviews.apache.org/r/53154/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: 2.0 release in JIRA

+1 On Tue, Oct 25, 2016 at 10:28 AM, Swapnil Bawaskar wrote: > +1 > > On Tuesday, October 25, 2016, Anthony Baker wrote: > > > +1 > > > > > On Oct 25, 2016, at 9:44 AM, Dan Smith > > > wrote: > > > > > > It looks like

Re: Review Request 53154: GEODE-2026: fix flaky test

/partitioned/PersistentPartitionedRegionDUnitTest.java (line 1643) <https://reviews.apache.org/r/53154/#comment223273> Need to add: vm1.invoke(waitForIntValue); - Darrel Schneider On Oct. 24, 2016, 4:19 p.m., Darrel Schneider

Re: Review Request 53154: GEODE-2026: fix flaky test

omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53154/#review153756 ------- On Oct. 24, 2016, 4:19 p.m., Darrel Schneider wrote: > > --- > This is an automatically gener

Re: Review Request 53154: GEODE-2026: fix flaky test

/partitioned/PersistentPartitionedRegionDUnitTest.java (line 1632) <https://reviews.apache.org/r/53154/#comment223167> no need to "throw InterruptedException" - Darrel Schneider On Oct. 24, 2016, 4:19 p.m., Darrel

Review Request 53154: GEODE-2026: fix flaky test

/cache/partitioned/PersistentPartitionedRegionDUnitTest.java 5ca3d014b4bac01e239561301666fae5fb0d61ea Diff: https://reviews.apache.org/r/53154/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 53094: GEODE-706 race condition between expiry thread and other user thread.

/LocalRegion.java (line 8660) <https://reviews.apache.org/r/53094/#comment223003> It would be better to remove these calls instead of just commenting them out. - Darrel Schneider On Oct. 21, 2016, 11:41 a.m., Hitesh Khamesra

Re: Review Request 53092: GEODE-2011 Client clears pdx registry needs synchronization

I wonder if you should be doing this on line 77 with the new endpoint. - Darrel Schneider On Oct. 21, 2016, 10:57 a.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 53071: GEODE-2021: Get on non colocated keys in a transaction does not throw TransactionDataNotColocatedException

ng this method to just be "getTx" and pass in a boolean that says "doCust1First". Then do this: CustId first = doCust1First ? cust1 : cust2; CustId second = !doCust1First ? cust1 : cust2; mgr.begin(); pr.get(first); pr.get(second); mgr commit(); -

Re: Review Request 53071: GEODE-2021: Get on non colocated keys in a transaction does not throw TransactionDataNotColocatedException

le of how to use it. - Darrel Schneider On Oct. 20, 2016, 10:39 a.m., Eric Shu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 52963: GEODE-388: Deprecating DynamicRegionFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52963/#review153182 --- Ship it! Ship It! - Darrel Schneider On Oct. 17, 2016, 5:06

Re: Review Request 52812: GEODE-1999: Fix offheap memory leak when exception is thrown during basicDestroy call to remove GatewaySenderEventImpl from the sender queue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52812/#review152422 --- Ship it! Ship It! - Darrel Schneider On Oct. 12, 2016, 4:32

Re: Coding practices/standards

h. >>> >>> -Dan >>> >>> On Wed, Oct 12, 2016 at 11:24 AM, Jared Stewart <jstew...@pivotal.io> >>> wrote: >>> >>> +1 to running during the precheckin target as well as Travis CI >>>> >>>> On Oct 12

Re: Coding practices/standards

If Travis CI is only run on pull requests then that is not enough because committers do not submit pull requests. Having it run during the gradle build or precheckin target is also needed. In addition to that I also wanted PRs to be checked. On Wed, Oct 12, 2016 at 11:12 AM, Jared Stewart

Re: Coding practices/standards

+1 When a pull request is submitted some type of build is automatically done to make sure the code compiles. Would this new "code check" also be done in that automatic check? On Wed, Oct 12, 2016 at 10:07 AM, Nabarun Nag wrote: > +1 > > On Wed, Oct 12, 2016 at 10:06 AM Dan

Re: Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

fixes. I recommend that you redo this fix without the reformatting changes. Reformatting should be done as a seperate ticket. If your IDE is configured to do automatic reformatting it should be changed to not be automatic. - Darrel Schneider On Oct. 10, 2016, 8:34 p.m., Udo Kohlmeyer wrote

Review Request 52228: fix hang introduced by GEODE-1885

/internal/cache/AbstractRegionMap.java 33e98b6ae8a795c5a7b60aa93c7384750eb9582b Diff: https://reviews.apache.org/r/52228/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 52152: GEODE-1921: Redis adaptor Strings region has incorrect attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52152/#review150032 --- Ship it! Ship It! - Darrel Schneider On Sept. 22, 2016, 12

Re: Review Request 52052: GEODE-1128: Enhance missing-disk-stores command with missing regions

/ColocationLogger.java (line 149) <https://reviews.apache.org/r/52052/#comment217462> should this be renamed to "updateAndGet..."? - Darrel Schneider On Sept. 19, 2016, 12:12 p.m., Ken Howe wrote: > > --- > This is a

Re: Review Request 51510: GEODE-1830: Use event, not entry, to check for a tombstone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51510/#review147364 --- Ship it! Ship It! - Darrel Schneider On Aug. 30, 2016, 1:26

Re: Review Request 51465: GEODE-1128: Cleaned up some of the colocation logging test

ws.apache.org/r/51465/#comment214002> Another way to unstick these async0 guys that are waiting for vm1 to do something (like create all its regions) would be to have the test create those regions and confirm that we stop logging warnings in vm1 and that vm0 completes region creation.

Re: Review Request 51439: GEODE-1770: CI failure: OffHeapEvictionDUnitTest.testDummyInlineNCentralizedEviction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51439/#review146880 --- Ship it! Ship It! - Darrel Schneider On Aug. 25, 2016, 2:53

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

rg/r/50715/#comment212424> I think you need to deal with missingColoctedRegionLogger being null. And it can become null async if stop is called. So this method should read it into a local var; test the local var; if not null call getMissingChildRegions; otherwise return Collecti

Review Request 51183: GEODE-67: fix nonTxnFindObject for partitioned region

/LocalRegion.java 304a5ade6d6647bf961345090bd3cc02bc04669f Diff: https://reviews.apache.org/r/51183/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 51098: GEODE-1781: repackage internal statistics classes and refactor statistics tests

/tier/sockets/CacheServerStats.java (line 29) <https://reviews.apache.org/r/51098/#comment212249> Change "Bridge" to "Cache" - Darrel Schneider On Aug. 15, 2016, 6:39 p.m., Kirk Lund wrote: > > --- > T

Re: Review Request 51098: GEODE-1781: repackage internal statistics classes and refactor statistics tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51098/#review145890 --- Ship it! Ship It! - Darrel Schneider On Aug. 15, 2016, 6:39

Re: Review Request 51125: GEODE-1782: stat resources with different time stamps should not be equal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51125/#review145879 --- Ship it! Ship It! - Darrel Schneider On Aug. 15, 2016, 6:56

Review Request 51118: change EntryEventImpl to protect off-heap access

/gemfire/internal/cache/EntryEventImplTest.java 265795f3f3da2c64d713da7cc240b2ad7ca69c0b Diff: https://reviews.apache.org/r/51118/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 51063: GEODE-1648: fix new javadocs on security-enabled-components

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51063/#review145796 --- Ship it! Ship It! - Darrel Schneider On Aug. 15, 2016, 12

Re: Review Request 51063: GEODE-1648: fix new javadocs on security-enabled-components

ve a closing ? Also why does the Default on line 1269 just have a without a beginning ? - Darrel Schneider On Aug. 12, 2016, 5:19 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 50967: GEODE-599: CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50967/#review145579 --- Ship it! Ship It! - Darrel Schneider On Aug. 11, 2016, 12

Review Request 51018: fix diskStats and prStats related to entry count and data size

/ Testing --- precheckin Also run a bunch of hydra tests that had been failing Thanks, Darrel Schneider

Re: Revised SSL properties failure scenario advice.

how does ssl-default-alias interact with this one in the spec: ssl-certificate-alias=[empty,string] (default - use first cert in keystore) I thought ssl-certificate-alias was the one to use by default. It could be overridden by a component one. And the default for it is to use the first

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

hat says the parent is offline because... Instead you will have a log message about its child that also says it is causing a problem for its parent. This is better than before. Lets talk about this one. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Coloca

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

+1 On Mon, Aug 8, 2016 at 4:51 PM, Michael Stolz wrote: > +1 > > All indications are this attempt is correct > > -- > Mike Stolz > Principal Engineer - Gemfire Product Manager > Mobile: 631-835-4771 > On Aug 8, 2016 6:09 PM, "William Markito" wrote: > >

Re: Review Request 50856: GEODE-225 excessive CPU utilization and garbage collection strain for JSON processing

re/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java (line 233) <https://reviews.apache.org/r/50856/#comment27> This would be: objMapper = createObjectMapper(); - Darrel Schneider On Aug. 5, 2016, 9:14 a.m.,

Re: Review Request 50855: Geode-1569: require principal to be Serializable so that post process can happen in a remote server

/PostProcessor.java (line 41) <https://reviews.apache.org/r/50855/#comment211098> typo: implemented In your comment you said that you wanted to require that the principal was Serializable. But did you also intend to not require it to be an instanceof Principal? - Darrel Schneider On Aug. 5, 2016

Re: Internal statistics classes package

+1 On Thu, Aug 4, 2016 at 4:35 PM, Dan Smith wrote: > +1 > > -Dan > > On Thu, Aug 4, 2016 at 3:00 PM, Kirk Lund wrote: > > > I'm working on a statistics related issue. While I'm working on this > code, > > I'd like to move all of the internal statistics

Re: Review Request 50680: fix replace on overflowed entry

> On Aug. 3, 2016, 11:35 a.m., Darrel Schneider wrote: > > This fix has a problem. It always reads the value from disk if it had > > overflowed. > > But just a couple of lines before this basicPut has called > > setOldValueInEvent. > > I think the correct

Re: Review Request 50680: fix replace on overflowed entry

--- precheckin Thanks, Darrel Schneider

Re: Review Request 50680: fix replace on overflowed entry

if it had overflowed. But just a couple of lines before this basicPut has called setOldValueInEvent. I think the correct fix is to use that old value from the event instead of rereading from disk/memory. - Darrel Schneider On Aug. 1, 2016, 4:17 p.m., Darrel Schneider wrote

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

15/#comment210570> Instead of "is not present" how about "must be created" or "does not exist". geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java (line 3764) <https://reviews.apache.org/r/50715/#comment210571> Since

Review Request 50680: fix replace on overflowed entry

/internal/cache/AbstractRegionMap.java f3cb3d654087c797de430f448348c3ba66846ac4 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ReplaceWithOverflowJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50680/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review144013 --- Ship it! Ship It! - Darrel Schneider On July 28, 2016, 1:44

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC6

flaky tests are supposed to be flickering. In this case it seems like it fails everytime On Thu, Jul 28, 2016 at 1:38 PM, Bruce Schuchardt wrote: > commit 4c5a699490b2702d6abe3a40e5d74a7e2f6b5acf > Author: Bruce Schuchardt > Date: Tue Jul 26

Re: Review Request 50468: fix stat corrupting when async queue full

is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50468/#review143633 --- On July 26, 2016, 3:11 p.m., Darrel Schneider wrote: > > --- > Thi

Review Request 50468: fix stat corrupting when async queue full

Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 50399: GEODE-1692: fix IllegalStateException in Transaction when the node is disconnecting from the ds

> On July 25, 2016, 11 a.m., Darrel Schneider wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXLockRequest.java, > > line 99 > > <https://reviews.apache.org/r/50399/diff/1/?file=1451920#file1451920line99> > > > > I think it i

Re: Review Request 50399: GEODE-1692: fix IllegalStateException in Transaction when the node is disconnecting from the ds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50399/#review143405 --- Ship it! Ship It! - Darrel Schneider On July 25, 2016, 10

Re: Review Request 50399: GEODE-1692: fix IllegalStateException in Transaction when the node is disconnecting from the ds

/TXLockRequest.java (line 99) <https://reviews.apache.org/r/50399/#comment209181> I think it is wrong for this release method to call "createDTLS". If the TXLockService no longer exists then release should not recreate it. - Darrel Schneider On July 25, 2016, 10:30 a.m.

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

e-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java (line 74) <https://reviews.apache.org/r/50242/#comment209046> Shouldn't this return the result of super.put(object)? - Darrel Schneider On July 22, 2016, 11:26 a.m., Er

Review Request 50276: fix 100ms delay in stopping tombstone sweeper

precheckin Thanks, Darrel Schneider

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

entImpl.release(object); } } Note the change of how the release is done (using the static method makes this code cleaner). - Darrel Schneider On July 20, 2016, 9:29 a.m., Eric Shu wrote: > > --- > This is an automatically ge

Re: Recovering large data for persisted regions

This is a known issue in GemFire. I filed a corresponding Geode ticket: GEODE-1672. The issue involves recovering large amounts of when using the heap LRU. The data get recovered asynchronously before it can be evicted by the heap LRU. So it is possible you will run out of heap during recovery.

Review Request 49811: add defragmentationsInProgress stat

/offheap/OffHeapStorageJUnitTest.java 90ff3cf593b3803a0f9fb2f81ff35c4adf7a678b Diff: https://reviews.apache.org/r/49811/diff/ Testing --- OffHeapStorageJUnitTest Thanks, Darrel Schneider

Re: Review Request 49536: refactor TombstoneService and add more info to testTombstones

ps://reviews.apache.org/r/49536/#review141040 ------- On July 1, 2016, 3:13 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 49712: GEODE-1621 Fix resources not being released during cleanup when an IllegalArgumentException is thrown

t case it seems like the IllegalArgumentException would never be expected and you could get rid of all catches of it. - Darrel Schneider On July 6, 2016, 10:21 a.m., Eric Shu wrote: > > --- > This is an automatically generated e

Review Request 49713: increase default number of off-heap free lists

://reviews.apache.org/r/49713/diff/ Testing --- precheckin Thanks, Darrel Schneider

Re: Review Request 49667: GEODE-1631: Removing a hardcoded apache-geode from location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49667/#review140905 --- Ship it! Ship It! - Darrel Schneider On July 5, 2016, 4:58

Re: Review Request 49409: GEODE-1573: Use snappy java implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49409/#review140464 --- Ship it! Ship It! - Darrel Schneider On July 1, 2016, 4:49

Re: Review Request 49409: GEODE-1573: Use snappy java implementation

like you should go ahead and change them to use the constructor instead of calling getDefaultInstance - Darrel Schneider On July 1, 2016, 11:53 a.m., Sai Boorlagadda wrote: > > --- > This is an auto

Re: Review Request 49329: GEODE-1607: ConcurrentModificationException could occur when iterating through hostedTXStates HashMap during closing cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49329/#review140048 --- Ship it! Ship It! - Darrel Schneider On June 29, 2016, 1

Re: Review Request 49329: GEODE-1607: ConcurrentModificationException could occur when iterating through hostedTXStates HashMap during closing cache

<https://reviews.apache.org/r/49329/#comment205216> Why do you release the sync BEFORE iterating the hostedTXStates? - Darrel Schneider On June 28, 2016, 10:07 a.m., Eric Shu wrote: > > --- > This is an automatically generated e-

Re: Review Request 49101: GEODE-1546: Proxy server may not be able to send message to other servers to clean up transactions initiated by a shutdown client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49101/#review139394 --- Ship it! Ship It! - Darrel Schneider On June 24, 2016, 11

Re: Review Request 49101: GEODE-1546: Proxy server may not be able to send message to other servers to clean up transactions initiated by a shutdown client

emfire/internal/cache/TXManagerImpl.java (line 1582) <https://reviews.apache.org/r/49101/#comment204480> isEmpty is better than size() == 0 - Darrel Schneider On June 22, 2016, 3:47 p.m., Eric Shu wrote: > > --- > Thi

Re: Snappy compressor (native->java)

+1 A problem with the native bits is this product feature only works on certain native platforms. On Mon, Jun 20, 2016 at 7:48 PM, Sai Boorlagadda wrote: > There were no problems on the JNI wrapper (with native bits) except that > maintaining native bits needs

Re: Review Request 48432: GEODE-1494: Allowing stats to be measured with callbacks

va (line 58) <https://reviews.apache.org/r/48432/#comment203265> why not final? - Darrel Schneider On June 9, 2016, 11:41 a.m., Dan Smith wrote: > > --- > This is an automa

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/#review138045 --- Ship it! Ship It! - Darrel Schneider On June 15, 2016, 10

Re: M3 status?

The test failing in GEODE-840 I think is going to be classified as "flaky". It should not hold up the m3 release. On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade wrote: > GEODE-1493 > Its not assigned to anyone...Someone with gradle/build experience can pick > this

  1   2   3   4   >