[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-07-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3213/7//COMMIT_MSG Commit Message: PS7, Line 9: ISO

[Impala-CR](cdh5-trunk) IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables

2016-07-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables .. Patch Set 1: Is there something we can do to help you along? -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

2016-07-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). .. Patch Set 1: > > > Abdur, are you still interested in working on this? > &

[Impala-CR](cdh5-trunk) IMPALA-3442: Replace '> >' with '>>' in template decls

2016-07-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3442: Replace '> >' with '>>' in template decls .. Patch Set 1: This confuses emacs's c++ mode. I also think it is not strictly required by o

[Impala-CR](cdh5-trunk) IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-03 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3566 Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. IMPALA-3817: Ensure filter hash function

[Impala-CR] IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-03 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. Abandoned wrong branch -- To view, visit http://gerrit.cloudera.org:8080/3565 To unsubscribe

[Impala-CR] IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-03 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3565 Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. IMPALA-3817: Ensure filter hash function

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-06-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3213/2/be/src/exprs/string-functions-ir.cc File be/src

Re: Failed to start hdfs

2016-06-24 Thread Jim Apple
Oh, and this is after switching to the ASF branch and then switching back On Fri, Jun 24, 2016 at 9:16 AM, Jim Apple <jbap...@cloudera.com> wrote: > I finding the following in testdata/bin/run-all.sh > > Failed to start hdfs-namenode. The end of the log > (/home/jbapple/Impal

Failed to start hdfs

2016-06-24 Thread Jim Apple
I finding the following in testdata/bin/run-all.sh Failed to start hdfs-namenode. The end of the log (/home/jbapple/Impala/testdata/cluster/cdh5/node-1/var/log/hdfs-namenode.out) is: /home/jbapple/Impala/testdata/cluster/cdh5/node-1/etc/init.d/common: line 22: hdfs: command not found Has anyone

[Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.

2016-06-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. .. Patch Set 5: > > I noticed there are no end-to-end tests yet. Is there anyt

[Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.

2016-06-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. .. Patch Set 5: I noticed there are no end-to-end tests yet. Is there anything I can help

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-06-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3213/2/be/src/exprs/string-functions-ir.cc File be/src

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. IMPALA-3762: Download Python requirements before they are needed. This is needed

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 1: Code-Review+2 Verified+1 Carry from https://gerrit.cloudera.org/#/c/3426

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3452 Change subject: IMPALA-3762: Download Python requirements before they are needed. .. IMPALA-3762: Download Python requirements before

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Abandoned Abandoning to make a new submit without a -1 from the fake GVM so I can submit this through

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: Verified+1 verified in private build -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-2428: Support multiple-character string as the field delimiter

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2428: Support multiple-character string as the field delimiter .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/3314/4//COMMIT_MSG Commit

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3401 To unsubscribe

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 25: (2 comments) http://gerrit.cloudera.org:8080/#/c/3081/22/be/src/util/bit

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). .. Patch Set 1: > > Abdur, are you still interested in working on this? > >

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3401/5/be/src/codegen/llvm

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: Running a private build and test job now. -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: GVMs going haywire -- To view, visit http://gerrit.cloudera.org:8080/3426

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: packaging build passed -- To view, visit http://gerrit.cloudera.org:8080/3426

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 4: (14 comments) http://gerrit.cloudera.org:8080/#/c/3401/4/be/src/codegen/constant

[Impala-CR](cdh5-trunk) IMPALA-3767: bootstrap virtualenv fails to find cython distribution

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3767: bootstrap_virtualenv fails to find cython distribution .. Patch Set 2: Code-Review+2 (1 comment) Carry Tim's +2 http://gerrit.cloudera.org:8080/#/c

[Impala-CR](cdh5-trunk) IMPALA-3767: bootstrap virtualenv fails to find cython distribution

2016-06-21 Thread Jim Apple (Code Review)
: Ic6733ccb71bcf99196075faa2fb6cf2a1d6276ce Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3767: bootstrap virtualenv fails to find cython distribution

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3767: bootstrap_virtualenv fails to find cython distribution .. Patch Set 1: Passed packaging build -- To view, visit http://gerrit.cloudera.org:8080/3427

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 4: Does this fix the regression in IMPALA-3636? -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3426/1/buildall.sh File

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-3762: Download Python requirements before they are needed. .. IMPALA-3762: Download Python requirements before they are needed. This is needed for ASF builds

[Impala-CR](cdh5-trunk) IMPALA-3767: bootstrap virtualenv fails to find cython distribution

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3767: bootstrap_virtualenv fails to find cython distribution .. Patch Set 1: testing packagin build now -- To view, visit http://gerrit.cloudera.org:8080

[Impala-CR](cdh5-trunk) IMPALA-3767: bootstrap virtualenv fails to find cython distribution

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3427 Change subject: IMPALA-3767: bootstrap_virtualenv fails to find cython distribution .. IMPALA-3767: bootstrap_virtualenv fails to find

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 1: Testing in packaging build now -- To view, visit http://gerrit.cloudera.org

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3426 Change subject: IMPALA-3762: Download Python requirements before they are needed. .. IMPALA-3762: Download Python requirements before

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 10: Code-Review+2 (1 comment) Carry +2 http://gerrit.cloudera.org:8080/#/c/3338/8/be/src

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-21 Thread Jim Apple (Code Review)
nsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Dan Hecht <

[Impala-CR](cdh5-trunk) IMPALA-2428: Support multiple-character string as the field delimiter

2016-06-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2428: Support multiple-character string as the field delimiter .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3314/1/be/src/exec/delimited

[Impala-CR](cdh5-trunk) IMPALA-3763: download requirements fixes

2016-06-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3763: download_requirements fixes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3416 To unsubscribe, visit http

[Impala-CR](cdh5-trunk) IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables

2016-06-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables .. Patch Set 1: (4 comments) This needs much more explanation and some tests. http

[Impala-CR](cdh5-trunk) IMPALA-889 Add support for ISO-SQL trim()

2016-06-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889 Add support for ISO-SQL trim() .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/3213/2/be/src/exprs/expr-test.cc File be/src/exprs/expr

[Impala-CR](cdh5-trunk) IMPALA-2428: Support multiple-character string as the field delimiter

2016-06-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2428: Support multiple-character string as the field delimiter .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/3314/1//COMMIT_MSG Commit

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

2016-06-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). .. Patch Set 1: Abdur, are you still interested in working on this? -- To view, visit

Re: Issues with Impala dataloading (power8 gcc4.9.3 Impala2.6)

2016-06-20 Thread Jim Apple
I haven't seen this before, but data loading is sometimes troublesome. Other Impala developers, have you seen this before? This looks to me like a Hive error from our load-functional-query-exhaustive-hive-generated.sql. You might find some interesting information in

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-06-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 21: (5 comments) http://gerrit.cloudera.org:8080/#/c/3081/21/be/src/util/bit

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h File

[Impala-CR](cdh5-trunk) IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

2016-06-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3311 To unsubscribe

[Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.

2016-06-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/ To unsubscribe

[Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3311/3/be/src/util/url-coding-test.cc

[Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3311/3/be/src/util/url-coding-test.cc File

[Impala-CR](cdh5-trunk) IMPALA-3604: Clean up SSE handling

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3604: Clean up SSE handling .. Patch Set 3: Code-Review-1 In my experiments, using the target attribute prevents inlining into functions that don't have

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSE or AVX2.

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSE or AVX2. .. Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/3081/17/be/src/util/bit

[Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3311/3/be/src/util/url-coding-test.cc

[Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. .. Patch Set 4: Oh, and it would be good if the commit message included a description of the outcome

[Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c//4//COMMIT_MSG Commit Message: Line

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 8: This has passed a private packaging build. -- To view, visit http://gerrit.cloudera.org

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 8: Code-Review+1 Carry Tim's +1 -- To view, visit http://gerrit.cloudera.org:8080/3338

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter-test.cc

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-14 Thread Jim Apple (Code Review)
ibe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Dan Hecht <

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: PS7: 15% increase in lookup speed by using constants, rather than lea + aligned load

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 6: (5 comments) I have changed the layout of the BFs so that they are the same no matter what

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-14 Thread Jim Apple (Code Review)
ibe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Dan Hecht <

[Impala-CR](cdh5-trunk) Use toolchain binutils.

2016-06-14 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Use toolchain binutils. .. Use toolchain binutils. This ensures that old assemblers that don't understand AVX2 instructions don't break compilation

[Impala-CR](cdh5-trunk) Use toolchain binutils.

2016-06-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use toolchain binutils. .. Patch Set 2: Passed private build-and-test, regular GVM still not working -- To view, visit http://gerrit.cloudera.org:8080/3352

[Impala-CR](cdh5-trunk) Use toolchain binutils.

2016-06-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use toolchain binutils. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3352 To unsubscribe, visit http://gerrit.cloudera.org:8080

Re: Branch model discussion

2016-06-14 Thread Jim Apple
ch merged back into "master". Feature branches can be merged back into "master" by a vote of the PMC. Feature branches that have lost all of their momentum can be closed by a vote of the PMC. +++++ Thoughts? On Thu, Jun 9, 2016 at 10:52 AM, Jim Apple <jba

[Impala-CR](cdh5-trunk) Use toolchain binutils.

2016-06-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use toolchain binutils. .. Patch Set 2: Packaging build passed - #316 -- To view, visit http://gerrit.cloudera.org:8080/3352 To unsubscribe, visit http

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 5: > My feeling is: > > pre-SSE 4.1: as long as it works, we're goo

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 5: > How much of a regression will pre-SSE4.1 incur? Regressing that > case in

Re: LLVM codegen functionality

2016-06-13 Thread Jim Apple
LLVM codegen has a significant (and good) effect on performance. https://blog.cloudera.com/blog/2013/02/inside-cloudera-impala-runtime-code-generation/ http://llvm.org/devmtg/2013-11/slides/Wanderman-Milne-Cloudera.pdf As for GCC/altivec problems, you might want to file a bug suggesting that

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 5: In PS5, I changed the way the AVX2 operations work in Insert(), and added AVX2 operations

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-11 Thread Jim Apple (Code Review)
anch: cdh5-trunk Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

2016-06-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 4: > Looks good once we confirm we can build it ok. OK. Blocked on ht

[Impala-CR](cdh5-trunk) IMPALA-3507: update binutils version to fix slow linking

2016-06-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3507: update binutils version to fix slow linking .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3353 To unsubscribe, visit

"Impala" is an approved name for Impala now

2016-06-09 Thread Jim Apple
https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-96 I will be working on getting the legal paperwork in order.

[Impala-CR](cdh5-trunk) IMPALA-3507: update binutils version to fix slow linking

2016-06-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3507: update binutils version to fix slow linking .. Patch Set 1: Should we wait until the version is uploaded? -- To view, visit http

[Impala-CR](cdh5-trunk) Use toolchain assembler.

2016-06-09 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3352 Change subject: Use toolchain assembler. .. Use toolchain assembler. This ensures that old assemblers that don't understand AVX2

Re: Branch model discussion

2016-06-09 Thread Jim Apple
> I > don't think we should force the project into a regular every-N-weeks > cadence without being sure that the release process can keep up. That sounds good to me. It is my understanding that the way Kudu does it is that someone generally volunteers to drive the next K releases, anticipating

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSE or AVX2.

2016-06-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSE or AVX2. .. Patch Set 17: (8 comments) http://gerrit.cloudera.org:8080/#/c/3081/17/be/src/util/bit

[Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.

2016-06-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. .. Patch Set 3: (17 comments) Still getting my head around this. http

[Toolchain-CR] IMPALA-3507: binutils fix for slow linking

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3507: binutils fix for slow linking .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3341 To unsubscribe, visit http

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 4: > It looks like it hit this on one of the builds: > > 11:45:59 /tmp/c

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/4/bin/impala-config.sh File bin

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Use AVX2 operations to speedup Bloom filter insert by 10-50%. Impala supports machines that do

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/3338/2/be/src/util/bloom-filter

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Use AVX2 operations to speedup Bloom filter insert by 10-50%. Impala supports machines that do

[Impala-CR](cdh5-trunk) IMPALA-2459: Implement next day date/time UDF

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF .. Patch Set 13: I notice this hasn't been merged yet. Is there any problem here that I can help with? -- To view

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Use AVX2 operations to speedup Bloom filter insert by 10-50%. Impala supports machines that do

[Impala-CR](cdh5-trunk) Allow compiler to use SSE3 and SSSE3 instructions.

2016-06-08 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: Allow compiler to use SSE3 and SSSE3 instructions. .. Abandoned Too much bookkeepping necessary to deal with older machines, ec2 machines, etc. -- To view, visit http

Re: Fw: Issues with generating testdata for Impala

2016-06-08 Thread Jim Apple
I'd suggest that it will be easier to address any cluster test issues one-by-one in its own email thread or bug report, since each one may have a different cause. On Wed, Jun 8, 2016 at 5:30 AM, Valencia Serrao wrote: > Hi Casey, > > Data loading issues on ppc are resolved.

Re: Branch model discussion

2016-06-07 Thread Jim Apple
Thank you. I think these are good questions. > What would happen if we discover that a tagged release has a critical bug > that was missed by the test cases? Would we have a release branch to > stabilise the release with any critical fixes? I think that is the right choice. What do you think? >

Branch model discussion

2016-06-07 Thread Jim Apple
How should Impala branches be a manged? Today, most of our new development happens on trunk, except when a CDH release is imminent. I propose we move to a time-based release model, where development happens on the "master" branch and every N weeks a commit that is passing all of the tests is

[Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.

2016-06-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3311/2/be/src/exprs/string-functions

[Impala-CR](cdh5-trunk) IMPALA-2361: Using AVX2 intrinsic to accelerate the sort operation Use AVX2 intrinsic to accelerate the sort operation (corresponding to the "order by" clause). Only si

2016-06-06 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-2361: Using AVX2 intrinsic to accelerate the sort operation Use AVX2 intrinsic to accelerate the sort operation (corresponding to the "order by" clause). Only single column is supported due to AVX2 restriction.

[Impala-CR](cdh5-trunk) IMPALA-3604: Clean up SSE handling

2016-06-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3604: Clean up SSE handling .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3227/2/be/src/util/sse-util.h File be/src/util/sse-util.h

[Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.

2016-06-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/exprs/string-functions-ir.cc

[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test metadata query statements.py.

2016-06-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_metadata_query_statements.py. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.

2016-06-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3244/5/be/src/exprs/string-functions

<    3   4   5   6   7   8   9   10   >