Re: Review Request 28315: Refactor clock to simplify libev cut.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/ --- (Updated Dec. 3, 2014, 8:24 p.m.) Review request for mesos, Benjamin Hindman

Re: [proposal] Module extension: hooks

Why can only the master obtain the information? I think it's fair to say that an organization might prefer to limit the exposure of certain security credentials to fewer machines, such as just the masters. My impression is that because these constraints are rigid, we are forced to have a

Re: Review Request 28665: Updated Allocator::slaveAdded to take the total resources explicitly.

On Dec. 3, 2014, 10:18 p.m., Jie Yu wrote: src/master/allocator.hpp, lines 83-86 https://reviews.apache.org/r/28665/diff/1/?file=781875#file781875line83 Maybe mention that slaveInfo resources are from --resources from slave command line. Thanks! Will do. - Ben

Re: Review Request 28666: Updated allocator.hpp to idiomatically use the Process wrapper pattern.

On Dec. 3, 2014, 10:23 p.m., Jie Yu wrote: src/master/allocator.hpp, lines 60-62 https://reviews.apache.org/r/28666/diff/1/?file=781897#file781897line60 Your text wrapping looks weired. Are they wrapped by 70 chars? This was copy/pasted, but I'll clean it up :) - Ben

Re: Rocket

inline below - Original Message - From: Tim Chen t...@mesosphere.io To: u...@mesos.apache.org Cc: dev dev@mesos.apache.org Sent: Wednesday, December 3, 2014 11:20:47 AM Subject: Re: Rocket Hi Tim, I see you've already commented on the rocket repo about this, and from their

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28319/ --- (Updated Dec. 3, 2014, 9:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28315: Refactor clock to simplify libev cut.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/ --- (Updated Dec. 3, 2014, 7:09 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

On Dec. 3, 2014, 8:02 p.m., Niklas Nielsen wrote: Do we want to add configure tests for the availability of libevent libraries and headers? If not, you could use the flag and fail building, right? Added these to the configure.ac - Joris

Re: Review Request 28618: Splitted resource and resource usage checkers.

On Dec. 3, 2014, 8:20 p.m., Ben Mahler wrote: src/master/master.cpp, lines 1946-1948 https://reviews.apache.org/r/28618/diff/1/?file=780558#file780558line1946 This check misses the case where a task explicitly uses no resources: cpus=0, for example. How about moving

Re: Review Request 28626: Added basic DiskInfo check in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28626/#review63726 --- Ship it! src/master/master.cpp

Re: Review Request 28321: Introduce libevent header and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28321/ --- (Updated Dec. 4, 2014, 12:19 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25369: Add Dockerfile for building Mesos from source

On Sept. 7, 2014, 1:47 a.m., Tom Arnfeld wrote: Dockerfile, line 32 https://reviews.apache.org/r/25369/diff/1/?file=679166#file679166line32 You can avoid these `cd /opt` commands by defining a `WORKDIR /opt` instruction before this line, every subsequent container will pick that

Re: Review Request 28574: Moved repeated labels to Labels message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28574/#review63785 --- Ship it! Ship It! include/mesos/mesos.proto

Re: Review Request 28576: Changed HTTP task modeling to use Labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28576/#review63787 --- Ship it! Ship It! - Timothy Chen On Dec. 1, 2014, 10:31 p.m.,

Re: Review Request 28627: Added tests for basic DiskInfo checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28627/#review63732 --- Ship it! Thanks for the tests! All of the task validation tests

Re: Review Request 28069: Propagated slave shutdown grace period to Executor and CommandExecutor.

On Nov. 20, 2014, 12:39 p.m., Niklas Nielsen wrote: src/tests/slave_tests.cpp, lines 1407-1408 https://reviews.apache.org/r/28069/diff/2/?file=765866#file765866line1407 Please align like we do here: https://github.com/apache/mesos/blob/master/src/tests/slave_tests.cpp#L803

Re: Review Request 28069: Propagated slave shutdown grace period to Executor and CommandExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28069/#review63751 --- Ship it! Almost there. Also, see my comment on moving the code

Re: Review Request 28315: Refactor clock to simplify libev cut.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/ --- (Updated Dec. 3, 2014, 11:18 p.m.) Review request for mesos, Benjamin Hindman

Build failed in Jenkins: mesos-reviewbot #2919

See https://builds.apache.org/job/mesos-reviewbot/2919/ -- [...truncated 5532 lines...] rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs rm -rf local/.libs local/_libs rm -rf log/.libs log/_libs rm -rf log/tool/.libs log/tool/_libs rm -rf

Re: Review Request 28577: Changed tests to use Labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28577/#review63788 --- Ship it! Ship It! - Timothy Chen On Dec. 1, 2014, 10:31 p.m.,

Review Request 28681: Made GC_DISK_HEADROOM configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28681/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-2169

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2330

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2330/changes

Review Request 28683: Add travis config file for travis-ci.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28683/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description

Re: Review Request 28082: Disable building static libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28082/#review63801 --- Ship it! Ship It! - Timothy St. Clair On Nov. 15, 2014, 2:17

Re: Review Request 28663: Cleaned up the utility structs in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28663/#review63753 --- Ship it! src/master/hierarchical_allocator_process.hpp

Re: Review Request 28485: Provide a default bind() in Socket: any port localhost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28485/#review63776 --- Ship it! Ship It! - Niklas Nielsen On Dec. 2, 2014, 6:09 p.m.,

Re: Review Request 28323: Introduce libevent poll implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28323/ --- (Updated Dec. 3, 2014, 11:27 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28662: Removed unnecessary 'whitelisted' variable in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28662/#review63738 --- Ship it! Ship It! - Jie Yu On Dec. 3, 2014, 7:53 p.m., Ben

Re: Review Request 28321: Introduce libevent header and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28321/ --- (Updated Dec. 3, 2014, 7:33 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28323: Introduce libevent poll implementation.

On Dec. 3, 2014, 8:09 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/libevent_poll.cpp, lines 27-28 https://reviews.apache.org/r/28323/diff/3/?file=781921#file781921line27 I have a bit of a hard time understanding this - can you expand/comment on what's going on? Since the

Review Request 28655: [WIP] Added Master hook for adding task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git

Review Request 28664: Added duplicated persistence id check in ResourceChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28664/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2030

Re: Review Request 28665: Updated Allocator::slaveAdded to take the total resources explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28665/#review63755 --- Ship it! src/master/allocator.hpp

Review Request 28684: Renamed task and offer visitors to validators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28684/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28681/#review63824 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 4, 2014, 12:29

Re: Review Request 28315: Refactor clock to simplify libev cut.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/#review63713 --- Ship it! One general comment; introducing the event manager

Re: Review Request 28052: Match future dispatch messages with type info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28052/#review63739 --- 3rdparty/libprocess/include/process/gmock.hpp

Review Request 28656: Added Slave hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git

Re: Review Request 28626: Added basic DiskInfo check in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28626/ --- (Updated Dec. 3, 2014, 7:41 p.m.) Review request for mesos and Ben Mahler.

Re: Rocket

Hey Tim C, Out of curiosity, which GitHub issue are you referring to when you say Apache is one of the options mentioned? I don't see it it in the discussion thread for https://github.com/coreos/rocket/issues/139, but I would love to find it and +1 the idea. Moving to Apache would be great to

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28319/#review63758 --- Ship it! Ship It! - Niklas Nielsen On Dec. 3, 2014, 1:49 p.m.,

Re: Review Request 28320: Add multiple include guard to libev.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28320/#review63715 --- Ship it! Ship It! - Niklas Nielsen On Dec. 3, 2014, 10:45 a.m.,

Re: Review Request 28666: Updated allocator.hpp to idiomatically use the Process wrapper pattern.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28666/#review63759 --- Ship it! src/master/allocator.hpp

Re: Review Request 28667: Cleaned up the allocator method naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28667/#review63760 --- Ship it! Ship It! - Jie Yu On Dec. 3, 2014, 7:53 p.m., Ben

Re: Review Request 28321: Introduce libevent header and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28321/ --- (Updated Dec. 3, 2014, 7:45 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28065: Introduced grace shutdown adjustment across shutdown levels.

On Nov. 20, 2014, 10:26 a.m., Niklas Nielsen wrote: src/Makefile.am, line 292 https://reviews.apache.org/r/28065/diff/2/?file=765853#file765853line292 s/grace/graceful/? If so, then do a scan over the files. Alexander Rukletsov wrote: I think it makes sense to be consistent.

Re: Review Request 28467: Move poll based socket implementation into poll_socket.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28467/ --- (Updated Dec. 3, 2014, 11:41 p.m.) Review request for mesos, Benjamin Hindman

Re: [2/8] mesos git commit: Cleaned up the utility structs in the allocator.

Hi Ben! FYI, one of your recent commits seems to have caused the build on Macs to fail: libtool: compile: g++ -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\ -DPACKAGE_VERSION=\0.22.0\ -DPACKAGE_STRING=\mesos 0.22.0\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\

Re: Review Request 28668: Fixed a bug in the allocator's framework activation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28668/#review63762 --- Ship it! Ship It! - Jie Yu On Dec. 3, 2014, 7:53 p.m., Ben

Re: Review Request 28684: Renamed task and offer visitors to validators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28684/#review63791 --- Ship it! Thanks jie! Make sure to update all the comments per my

Re: Review Request 28321: Introduce libevent header and implementation.

On Dec. 2, 2014, 10:13 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/libevent.cpp, line 39 https://reviews.apache.org/r/28321/diff/3/?file=779192#file779192line39 Can we get out better error messages here? Maybe a TODO? There is currently no way to get a return code here.

Re: Proposal: shared Mesos framework hosting and registry

Hi Connor, Thanks for sharing the work you've been doing with Universe. Sounds complimentary and pretty exciting! I thought I'd take a stab at making some clarifications. To rephrase your proposal by using a comparison, you're proposing the homebrew model of package management here in terms of

Re: Review Request 28669: Updated allocator to only check initialization in exposed methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28669/#review63763 --- Ship it! Ship It! - Jie Yu On Dec. 3, 2014, 7:53 p.m., Ben

Re: Review Request 28322: Introduce libevent clock implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28322/ --- (Updated Dec. 3, 2014, 7:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28323: Introduce libevent poll implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28323/ --- (Updated Dec. 3, 2014, 7:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Rocket

Thanks, I'll take the discussion to the GitHub issue. On Wed, Dec 3, 2014 at 11:44 AM, Tim Chen t...@mesosphere.io wrote: Hi Dave, I actually can't remember is it on the github issue, email list or twitter feed, but definitely one of them. Tim St Clair just brought up Apache on #139, and

Re: Review Request 28467: Move poll based socket implementation into poll_socket.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28467/ --- (Updated Dec. 3, 2014, 7:52 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28681/#review63794 --- Patch looks great! Reviews applied: [28681] All tests passed. -

Re: Review Request 28669: Updated allocator to only check initialization in exposed methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28669/#review63743 --- Patch looks great! Reviews applied: [28662, 28663, 28665, 28666,

Review Request 28662: Removed unnecessary 'whitelisted' variable in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28662/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Review Request 28663: Cleaned up the utility structs in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28663/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Review Request 28666: Updated allocator.hpp to idiomatically use the Process wrapper pattern.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28666/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Review Request 28668: Fixed a bug in the allocator's framework activation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28668/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Review Request 28669: Updated allocator to only check initialization in exposed methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28669/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Review Request 28667: Cleaned up the allocator method naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28667/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Review Request 28665: Updated Allocator::slaveAdded to take the total resources explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28665/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description

Re: Review Request 28626: Added basic DiskInfo check in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28626/#review63766 --- src/master/master.cpp

Re: Review Request 28626: Added basic DiskInfo check in master.

On Dec. 3, 2014, 10:35 p.m., Ben Mahler wrote: src/master/master.cpp, line 1938 https://reviews.apache.org/r/28626/diff/2/?file=781896#file781896line1938 Do you need to validate the ID as well? Will it ultimately need to land as a directory name on the slave (i.e. no slashes,

Review Request 28673: Introduce libevent socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28673/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs:

Review Request 28672: Add configure flag for libevent socket implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28672/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs:

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review63475 --- src/slave/slave.hpp

Re: Review Request 28684: Renamed task and offer visitors to validators.

On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote: src/master/master.cpp, lines 1799-1800 https://reviews.apache.org/r/28684/diff/1/?file=782165#file782165line1799 Visitor pattern no longer relevant. Done. On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote: src/master/master.cpp, lines

Re: Review Request 28683: Add travis config file for travis-ci.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28683/#review63798 --- Patch looks great! Reviews applied: [28683] All tests passed. -

Re: Review Request 28664: Added duplicated persistence id check in ResourceChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28664/#review63764 --- Ship it! This is only a partial check for duplicate IDs, can you

Jenkins build is back to normal : mesos-reviewbot #2920

See https://builds.apache.org/job/mesos-reviewbot/2920/

Re: Review Request 28656: Added Slave hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review63701 --- Bad patch! Reviews applied: [28655] Failed command:

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28319/#review63722 --- Do we want to add configure tests for the availability of libevent

Re: Review Request 28315: Refactor clock to simplify libev cut.

On Dec. 3, 2014, 7:39 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/event_loop.hpp, line 23 https://reviews.apache.org/r/28315/diff/4/?file=781851#file781851line23 Why the void pointer argument? For now, since we are using pthreads, this is the prototype expected by

Re: Review Request 28467: Move poll based socket implementation into poll_socket.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28467/#review63723 --- Ship it! Taken it's a code move

Re: Review Request 28589: stout: Created initialization wrappers for sockaddr_in and addrinfo.

On Dec. 2, 2014, 9:58 a.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 139 https://reviews.apache.org/r/28589/diff/1/?file=779860#file779860line139 should we check for ENAMETOOLONG here? it seems a shame to expose this to the caller when

Re: Review Request 28315: Refactor clock to simplify libev cut.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/ --- (Updated Dec. 3, 2014, 6:43 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28322: Introduce libevent clock implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28322/ --- (Updated Dec. 3, 2014, 10:48 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28323: Introduce libevent poll implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28323/#review63719 --- 3rdparty/libprocess/src/libevent_poll.cpp

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28319/ --- (Updated Dec. 3, 2014, 6:44 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28545: Created accept, bind, connect and getsockname wrappers for different protocol families

On Dec. 2, 2014, 10:04 a.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/socket.hpp, line 69 https://reviews.apache.org/r/28545/diff/2/?file=779866#file779866line69 add a family - may as well get used to it. Evelina Dumitrescu wrote: Wouldn't it be better if I

Re: Review Request 28320: Add multiple include guard to libev.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28320/ --- (Updated Dec. 3, 2014, 6:45 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28319/ --- (Updated Dec. 3, 2014, 6:46 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28322: Introduce libevent clock implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28322/#review63718 --- Looks good - astonishing how much simpler the libevent clock

Re: Review Request 28663: Cleaned up the utility structs in the allocator.

On Dec. 3, 2014, 10:07 p.m., Jie Yu wrote: src/master/hierarchical_allocator_process.hpp, lines 423-432 https://reviews.apache.org/r/28663/diff/1/?file=781872#file781872line423 This is in the header file which can polute the namespace. Probably either put that in the

Re: Review Request 28316: Reorganize clock event callback functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28316/ --- (Updated Dec. 3, 2014, 6:48 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28673: Introduce libevent socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28673/#review63746 --- Bad patch! Reviews applied: [28314, 28315] Failed command:

Re: Review Request 28315: Refactor clock to simplify libev cut.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/ --- (Updated Dec. 3, 2014, 8:18 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28673: Introduce libevent socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28673/ --- (Updated Dec. 3, 2014, 8:19 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28618: Splitted resource and resource usage checkers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28618/#review63724 --- Ship it! src/master/master.cpp

Re: Review Request 28485: Provide a default bind() in Socket: any port localhost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28485/#review63692 --- Ship it! Ship It! - Dominic Hamon On Dec. 2, 2014, 6:09 p.m.,

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28681/#review63842 --- Ship it! LGTM, just wondering about inclusive/exclusive [0,1] vs.

Re: Review Request 28063: Introduced grace period in CommandInfo.

On Dec. 3, 2014, 9:20 p.m., Niklas Nielsen wrote: src/slave/slave.hpp, line 275 https://reviews.apache.org/r/28063/diff/3/?file=774392#file774392line275 /es/e/ Current implementation updates all present CommandInfo fields in a TaskInfo. On Dec. 3, 2014, 9:20 p.m., Niklas Nielsen

Re: Review Request 28589: stout: Created initialization wrappers for sockaddr_in and addrinfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28589/ --- (Updated Dec. 4, 2014, 4:11 p.m.) Review request for mesos, Dominic Hamon and

Re: Review Request 28589: stout: Created initialization wrappers for sockaddr_in and addrinfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28589/#review63861 --- Ship it! Ship It! - Dominic Hamon On Dec. 4, 2014, 8:11 a.m.,

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

On Dec. 4, 2014, 6:20 a.m., Adam B wrote: src/slave/slave.cpp, line 284 https://reviews.apache.org/r/28681/diff/1/?file=782157#file782157line284 Can it even be ==0 or ==1? Shouldn't change much. You can still do 0.0001 or 0. while being exclusive. The age calculation:

  1   2   >