---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30616/#review70975
---
Patch looks great!
Reviews applied: [30616]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/
---
(Updated Feb. 4, 2015, 9:40 a.m.)
Review request for mesos and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30624/
---
(Updated Feb. 4, 2015, 9:40 a.m.)
Review request for mesos and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30626/
---
Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29931/
---
(Updated Feb. 4, 2015, 4:53 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29929/
---
(Updated Feb. 4, 2015, 4:51 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/#review70983
---
Patch looks great!
Reviews applied: [30074]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29932/#review70987
---
Bad patch!
Reviews applied: [29890, 29925]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30618/#review70976
---
Bad patch!
Reviews applied: [30618]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29932/
---
(Updated Feb. 4, 2015, 4:55 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30624/
---
(Updated Feb. 4, 2015, 9:43 a.m.)
Review request for mesos and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/
---
(Updated Feb. 4, 2015, 4:49 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
---
(Updated Feb. 4, 2015, 4:50 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30621/
---
Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30624/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-2314
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30624/#review70989
---
Ship it!
src/tests/paths_tests.cpp
On Feb. 3, 2015, 5:32 p.m., Jie Yu wrote:
src/slave/paths.cpp, line 453
https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453
const string directory
the function returns a string by value. there's no improvement here using a
const ref (the copy will be elided).
On Feb. 4, 2015, 1:32 a.m., Jie Yu wrote:
src/slave/paths.cpp, line 453
https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453
const string directory
Dominic Hamon wrote:
the function returns a string by value. there's no improvement here using
a const
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30082/
---
(Updated Feb. 4, 2015, 4:54 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/#review70984
---
Ship it!
src/slave/paths.cpp
On Feb. 4, 2015, 1:32 a.m., Jie Yu wrote:
src/slave/paths.cpp, line 453
https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453
const string directory
Dominic Hamon wrote:
the function returns a string by value. there's no improvement here using
a const
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30624/
---
(Updated Feb. 4, 2015, 9:55 a.m.)
Review request for mesos and Jie Yu.
Bugs:
On Jan. 28, 2015, 8:20 p.m., Niklas Nielsen wrote:
src/tests/master_tests.cpp, lines 1733-1738
https://reviews.apache.org/r/29883/diff/4/?file=823553#file823553line1733
Can we use createTasks() here? Take a look at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/
---
Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy
On Feb. 2, 2015, 1:20 p.m., Ian Downes wrote:
src/slave/containerizer/mesos/containerizer.hpp, lines 221-226
https://reviews.apache.org/r/30510/diff/1/?file=843873#file843873line221
In my current working code I've added an Optionstring rootfs to
struct Container. Would that be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30628/
---
Review request for mesos and Jie Yu.
Repository: mesos
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30628/#review70999
---
Ship it!
- Jie Yu
On Feb. 4, 2015, 6:07 p.m., Ian Downes wrote:
On Jan. 23, 2015, 6:44 p.m., Jie Yu wrote:
src/slave/state.hpp, line 120
https://reviews.apache.org/r/29918/diff/9/?file=829596#file829596line120
One more thought:
Can we introduce a third parameter for this function to let users opt
out the temp + rename (we can use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30626/#review71019
---
Bad patch!
Reviews applied: [30033, 30034, 30036, 30037, 30039,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/#review71021
---
Very nice! First high level pass, haven't looked at the tests yet.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30621/#review71003
---
Patch looks great!
Reviews applied: [30033, 30034, 30036, 30037,
You are understanding is right. The driver is single threaded. So, if it is
busy in a callback it can't send a message to the master.
On Tue, Feb 3, 2015 at 7:04 PM, Chengwei Yang chengwei.yang...@gmail.com
wrote:
On Tue, Feb 03, 2015 at 05:21:55PM -0800, Vinod Kone wrote:
On Tue, Feb 3,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review71016
---
Ship it!
src/tests/master_validation_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/
---
(Updated Feb. 4, 2015, 7:50 p.m.)
Review request for mesos, Dominic Hamon, Ian
On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
src/master/master.cpp, lines 601-603
https://reviews.apache.org/r/30612/diff/2/?file=847632#file847632line601
Shouldn't it be `/frameworks.json`?
This is a good question. On principle, I agree with you, but the route is more
On Feb. 4, 2015, 8:01 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 197-246
https://reviews.apache.org/r/30514/diff/5/?file=847032#file847032line197
It looks like we only log when we're shutting down the slave, when
there's no rate limiter?
Have you considered
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review70982
---
Thanks for the patch, Alexander! I have a high-level question. In
Hi Mesos Community!
I'm looking for possible interested presenters located in Sweden.
Please contact me with a brief summery of possible presentations.
Best regards,
Niklas Volcz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28809/
---
(Updated Feb. 4, 2015, 7:13 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review71028
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
On Feb. 4, 2015, 8:01 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 197-246
https://reviews.apache.org/r/30514/diff/5/?file=847032#file847032line197
It looks like we only log when we're shutting down the slave, when
there's no rate limiter?
Have you considered
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
---
(Updated Feb. 4, 2015, 10:59 a.m.)
Review request for mesos, Adam B, Benjamin
On Feb. 4, 2015, 4:50 p.m., Alexander Rukletsov wrote:
I was specifically requested not to do so. If I decided to do these cleanups, I
am supposed to provide a patch which does them.
- Alexander
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30635/
---
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Bugs:
On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
Thanks for the patch, Alexander! I have a high-level question. In such
checks:
```
TryJSON::Value expected = JSON::parse([]);
ASSERT_SOME(expected);
ResultJSON::Value _tasks = framework.findJSON::Value(tasks);
On Feb. 4, 2015, 8:01 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 197-246
https://reviews.apache.org/r/30514/diff/5/?file=847032#file847032line197
It looks like we only log when we're shutting down the slave, when
there's no rate limiter?
Have you considered
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30628/#review71041
---
Patch looks great!
Reviews applied: [30628]
All tests passed.
-
On Feb. 4, 2015, 8:01 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 197-246
https://reviews.apache.org/r/30514/diff/5/?file=847032#file847032line197
It looks like we only log when we're shutting down the slave, when
there's no rate limiter?
Have you considered
On Feb. 4, 2015, 8:31 p.m., Ben Mahler wrote:
Is there a test of this function?
Might be nice to add a NOTE or TODO about how to address the issue of
leaving dangling files when we failover at the wrong time?
Jie Yu wrote:
Yes, SlaveStateTest should catch the regression.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review71046
---
Patch looks great!
Reviews applied: [29727]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71023
---
Looks great. Just need some better naming. I suggested one. Feel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30386/#review71040
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30597/
---
(Updated Feb. 4, 2015, 10:10 p.m.)
Review request for mesos, Alexander
This was just me discarding this one after the off-thread chats, had to
remove the dependency first.
On Wed, Feb 4, 2015 at 2:10 PM, Ben Mahler benjamin.mah...@gmail.com
wrote:
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30635/#review71033
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 4, 2015, 7:38 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review71048
---
Drive-by review...
Tests!?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30635/#review71035
---
Ship it!
Is there a test of this function?
Might be nice to add a
On Feb. 4, 2015, 8:56 p.m., Ben Mahler wrote:
src/master/master.cpp, line 1348
https://reviews.apache.org/r/30386/diff/2/?file=846897#file846897line1348
Maybe we should add a little note there that there is no direct
feedback to the framework when an operation is dropped, they
On Feb. 4, 2015, 8:01 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 197-246
https://reviews.apache.org/r/30514/diff/5/?file=847032#file847032line197
It looks like we only log when we're shutting down the slave, when
there's no rate limiter?
Have you considered
On Feb. 4, 2015, 8:31 p.m., Ben Mahler wrote:
Is there a test of this function?
Might be nice to add a NOTE or TODO about how to address the issue of
leaving dangling files when we failover at the wrong time?
Yes, SlaveStateTest should catch the regression.
Will add a NOTE, the
On Feb. 4, 2015, 8:01 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 197-246
https://reviews.apache.org/r/30514/diff/5/?file=847032#file847032line197
It looks like we only log when we're shutting down the slave, when
there's no rate limiter?
Have you considered
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/#review71044
---
Just curious, what did you need this stuff for? Inferring
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/#review70969
---
src/tests/slave_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29597/
---
(Updated Feb. 4, 2015, 10:15 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30300/
---
(Updated Feb. 4, 2015, 10:15 p.m.)
Review request for mesos, Alexander
On Feb. 4, 2015, 8:01 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 197-246
https://reviews.apache.org/r/30514/diff/5/?file=847032#file847032line197
It looks like we only log when we're shutting down the slave, when
there's no rate limiter?
Have you considered
On Feb. 4, 2015, 1:45 p.m., Alexander Rukletsov wrote:
src/tests/slave_tests.cpp, line 1621
https://reviews.apache.org/r/30601/diff/1/?file=847062#file847062line1621
// Create a task with shutdown grace period set explicitly.
Thanks!
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/
---
(Updated Feb. 4, 2015, 10:44 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/
---
(Updated Feb. 4, 2015, 10:57 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/
---
Review request for mesos, Timothy Chen and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review71078
---
src/linux/cgroups.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30580/#review71060
---
src/slave/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30596/#review71058
---
Patch looks great!
Reviews applied: [30579, 30580, 30583, 30595,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30583/
---
(Updated Feb. 4, 2015, 10:43 p.m.)
Review request for mesos, Alexander
On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote:
src/tests/master_tests.cpp, lines 1653-1654
https://reviews.apache.org/r/30612/diff/2/?file=847633#file847633line1653
What black magic do you mean?
You're right, this comment shouldn't be there. Moreover, two slaves are not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30644/#review71085
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 4, 2015, 11:53 p.m., Jie
On Feb. 4, 2015, 11:01 p.m., Ben Mahler wrote:
src/master/master.cpp, line 243
https://reviews.apache.org/r/30514/diff/6/?file=849030#file849030line243
Does this comment add any insight? It looks like the LOG(INFO) line
reveals this already :)
Also, it looks like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/
---
(Updated Feb. 5, 2015, 12:13 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30601/#review71091
---
Patch looks great!
Reviews applied: [30579, 30580, 30583, 30595,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/
---
(Updated Feb. 5, 2015, 12:13 a.m.)
Review request for mesos, Ben Mahler, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30601/#review71062
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30596/#review71064
---
Ship it!
It would be easier to follow you change if you could
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review71104
---
Per our dicussion, could you expose and reuse the existing
On Feb. 4, 2015, 11:47 a.m., Alexander Rukletsov wrote:
Ben, I like the refactor you've done. A special thanks goes for updating
comments for clarity and brevity. Below are my 2ยข on naming.
In general, the naming of executors and executor drivers in our codebase is
a bit ambiguous.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/#review71059
---
Took a look at the tests as well.
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30642/
---
(Updated Feb. 4, 2015, 11:52 p.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
---
(Updated Feb. 5, 2015, 12:52 a.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30642/#review71083
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 4, 2015, 11:52 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30595/#review71090
---
Ship it!
- Niklas Nielsen
On Feb. 3, 2015, 6:14 p.m., Ben Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 4, 2015, 4:19 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71080
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/#review71098
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 5, 2015, 12:13 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/#review71099
---
Ship it!
TIL: Americans spell it canceled, not cancelled :)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
---
(Updated Feb. 5, 2015, 1:54 a.m.)
Review request for mesos, Ben Mahler, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30361/
---
(Updated Feb. 5, 2015, 12:58 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/#review71108
---
Patch looks great!
Reviews applied: [30509, 30510]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28809/#review7
---
tests?
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review71120
---
Patch looks great!
Reviews applied: [30643]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71124
---
Bad patch!
Reviews applied: [27531]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review71139
---
Patch looks great!
Reviews applied: [30612]
All tests passed.
-
1 - 100 of 149 matches
Mail list logo
