Re: [DISCUSS] Changing role <-> priv relationship from M:N to 1:N

e acceptable? I am curious, apart from simplicity what other value is this bringing? What do other folks think about this? > > - Alex > -- Sravya Tirukkovalur

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review153758 --- Ship it! Ship It! - Sravya Tirukkovalur On Oct. 24, 2016

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

, but just add info on what kind of user can run this tool? - Sravya Tirukkovalur On Oct. 18, 2016, 10:19 p.m., Anne Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

5/#comment222506> What these values correspond to? Can we add some description to the class itself on what inputs it expects and how it gets the values and privileges a user needs to run this tool? - Sravya Tiru

Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

795/#comment221665> Typo? - Sravya Tirukkovalur On Oct. 12, 2016, 6:12 p.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

iving the snapshot? - Sravya Tirukkovalur On Oct. 12, 2016, 7:15 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: [DISCUSS] Test monitoring process and rotation

does it include both the master and feature branch? > > On Tue, Oct 4, 2016 at 1:28 PM, Sravya Tirukkovalur <sra...@apache.org> > wrote: > > > Hi all, > > > > As the project grows, I think it might be useful to have a process and > > rotation of responsibility

[DISCUSS] Test monitoring process and rotation

Hi all, As the project grows, I think it might be useful to have a process and rotation of responsibility on how we maintain the health of test runs which is a crucial piece in project health. I documented a draft of the process, please provide your inputs if you think it would be useful also

Re: Review Request 51445: SENTRY-1453: Enable passing sentry client cache configs from kafka conf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51445/#review147382 --- Ship it! Ship It! - Sravya Tirukkovalur On Aug. 30, 2016, 6

Re: [2/4] sentry git commit: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration, refactor this huge test class, improve its cleanUp and setUp for temp HDFS dirs; divide test class into smoke test

The commit message should instead be SENTRY-1454: Fix intermittent time out issue for TestHDFSIntegration On Mon, Aug 29, 2016 at 2:54 PM, Sravya Tirukkovalur <sra...@cloudera.com> wrote: > Isn't this commit for https://issues.apache.org/jira/browse/SENTRY-1454. > Looks like co

Re: [2/4] sentry git commit: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration, refactor this huge test class, improve its cleanUp and setUp for temp HDFS dirs; divide test class into smoke test

Isn't this commit for https://issues.apache.org/jira/browse/SENTRY-1454. Looks like commit message mentions wrong jira numbers? On Mon, Aug 29, 2016 at 1:10 PM, wrote: > http://git-wip-us.apache.org/repos/asf/sentry/blob/ >

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java (line 447) <https://reviews.apache.org/r/51471/#comment214282> User needs to have execute bit set to get to the children. So we will need 771. - Sravya Tirukkovalur On Aug. 27, 2016, 12:42 a.m., Anne Yu

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

> On Aug. 27, 2016, 12:30 a.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java, > > line 447 > > <https://reviews.apache.org/r/51471/diff/2/?file=1487247#file1487247line447>

Force push on sentry-ha-redesign branch

Hi folks, I just had to do a force push due to an incorrect commit on this branch. Please refetch if you have pulled the feature branch in the last couple days. Sorry about that. Regards,

[ANNOUNCE] New Sentry committer - Ashish Singh

involvement from Ashish! Regards, -- Sravya Tirukkovalur

Re: Sentry-jdk-1.7 - Build # 709 - Failure

Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/709/ > to view the results. -- Sravya Tirukkovalur

Re: Sentry-HDFS sync

ed by Sentry? or they MUST use HCatalog IOFormat/Loader? > Regards,Mohammad > -- Sravya Tirukkovalur

Re: Delegation tokens?

seem like a useful feature which could potentially avoid trusted impersonation in Sentry as well. Please feel free to file a jira as always. And thanks for volunteering to take a stab at it! I am not intimately familiar with the implementation details but can dig into it a bit more as well.

Re: Delegation tokens?

a security loophole. > > > > This would be similar to what KMS offers via > > https://issues.apache.org/jira/browse/HADOOP-10769. > > > > > > Thanks in advance, > > Bhooshan > > > > > > > -- > Bhooshan > -- Sravya Tirukkovalur

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

chable -> is unreachable? - Sravya Tirukkovalur On Aug. 2, 2016, 9:55 p.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 50182: Sentry-1371: Rework Sentry start up and Hive state fetch

ollower.java (lines 269 - 272) <https://reviews.apache.org/r/50182/#comment210182> Seems like this needs to be implemented partially in this patch? That is, use fullUpdateComplete? Eventually we should set this value based on notification id stored in Sentry? - Sravya Tirukkovalur On J

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

> On July 28, 2016, 10:18 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java, > > lines 273-278 > > <https://reviews.apache.org/r/50578/diff/2/?file=14

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

ava/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java (line 26) <https://reviews.apache.org/r/50578/#comment209960> I only see tests for hostString parsing logic, shall we add tests for actual standbyException handling? - Sravya Tirukkovalur

Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

not complete yet. Submmitting a preview of changes for review as this work also is important for SENTRY-1371 Thanks, Sravya Tirukkovalur

Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

/ Testing --- Testing not complete yet. Submmitting a preview of changes for review as this work also is important for SENTRY-1371 Thanks, Sravya Tirukkovalur

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 25, 2016, 8:37 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > line 140 > > <https://reviews.apache.org/r/50404/diff/1/?file=1451990#file1451990line140> > > &

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

ailover.java (line 77) <https://reviews.apache.org/r/50404/#comment209211> nit: not -> now - Sravya Tirukkovalur On July 25, 2016, 6:43 p.m., Rahul Sharma wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 48055: SENTRY-1209: Sentry does not block Hive's cross-schema table renames

for rename db1.tb1 to db1.tb2? - Sravya Tirukkovalur On July 15, 2016, 1:22 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Meeting minutes - July 2016

Hi all, Thanks all for joining the call today! Here are the notes: 1. Discussed merging of Sentry-1205 Follow on work on refactoring module dependencies: - authorization-provider and db-provider (Colin to file a jira) - SENTRY-1395: Move the HDFS code which lives inside the sentry daemon into

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49738/#review141940 --- Ship it! Ship It! - Sravya Tirukkovalur On July 11, 2016, 6

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

sit: https://reviews.apache.org/r/49397/#review141754 --- On July 9, 2016, 8:38 a.m., Sravya Tirukkovalur wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

://reviews.apache.org/r/49777/diff/ Testing --- Testing not complete yet. Submmitting a preview of changes for review as this work also is important for SENTRY-1371 Thanks, Sravya Tirukkovalur

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java PRE-CREATION Diff: https://reviews.apache.org/r/49397/diff/ Testing --- Added new tests Thanks, Sravya Tirukkovalur

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

> > > > Should we make it configurable? Same as above. - Sravya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49397/#review141307

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

sically executing select* . What is the purpose of it? - Sravya Tirukkovalur On July 8, 2016, 7:59 p.m., Colin McCabe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 49526: SENTRY-1365

. sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.derby.sql (line 15) <https://reviews.apache.org/r/49526/#comment206785> We use Varchar(4000) for URIs, are you sure 255 would be sufficient? - Sravya Tirukkovalur On July 5, 2016, 11:54 p.m., Hao Hao

Re: Review Request 49738: SENTRY-1317: Implement fencing required for active/passive

ntry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java (line 992) <https://reviews.apache.org/r/49738/#comment206778> It is unclear to me what new validations are we adding to this test? - Sravya Tirukko

Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

2c4948e9d100f2cf0cb5b7772489194c62b8a857 Diff: https://reviews.apache.org/r/49777/diff/ Testing --- Testing not complete yet. Submmitting a preview of changes for review as this work also is important for SENTRY-1371 Thanks, Sravya Tirukkovalur

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java PRE-CREATION Diff: https://reviews.apache.org/r/49397/diff/ Testing --- Added new tests Thanks, Sravya Tirukkovalur

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java PRE-CREATION Diff: https://reviews.apache.org/r/49397/diff/ Testing --- Added new tests Thanks, Sravya Tirukkovalur

Re: Review Request 49477: SENTRY-1378: Login fails for a secure Sentry Web UI

with AD. So, I think we should rather fix the part which is lowercasing these values. What do you think? Also, can you change/add the test to trigger this failure and test your fix? - Sravya Tirukkovalur On June 30, 2016, 11:06 p.m., Rahul Sharma wrote

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

> On June 30, 2016, 10:19 p.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1829 > > <https://reviews.apache.org/r/49290/diff/2/?file=1431344#file1431344line1829> >

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

On June 28, 2016, 4:08 p.m., Sravya Tirukkovalur wrote: > > A general comment. We have had testing running too long and vm gets killed > > issue. So for each test class, ideally it is a small and focused test > > suite. If it grows large, can put into a seperate test class. S

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49290/#review139706 --- On June 28, 2016, 12:27 a.m., Sravya Tirukkovalur wrote: > > --

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

On June 28, 2016, 4:08 p.m., Sravya Tirukkovalur wrote: > > A general comment. We have had testing running too long and vm gets killed > > issue. So for each test class, ideally it is a small and focused test > > suite. If it grows large, can put into a seperate test class. S

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

; Sorry, are you recommending a new string value here or new name for the variable? I am trying to keep the same variable name, so that it is easy to know what is the current table name. If it is the string value, that does not really matter right? - Sravya Tirukkovalur On J

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogWithSentryListener.java PRE-CREATION Diff: https://reviews.apache.org/r/49397/diff/ Testing --- Added new tests Thanks, Sravya Tirukkovalur

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogWithSentryListener.java PRE-CREATION Diff: https://reviews.apache.org/r/49397/diff/ Testing --- Added new tests Thanks, Sravya Tirukkovalur

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

che.org/r/49290/#review139706 --- On June 28, 2016, 12:27 a.m., Sravya Tirukkovalur wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Review Request 49292: SENTRY-1374: Add alter table test cases for HDFS sync for managed/unmanaged table, with/without partitions

/r/49292/diff/ Testing --- Thanks, Sravya Tirukkovalur

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

Diff: https://reviews.apache.org/r/49290/diff/ Testing --- Thanks, Sravya Tirukkovalur

Re: Review Request 48761: SENTRY-1316 Implement Sentry leadership election

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48761/#review139130 --- Ship it! Ship It! - Sravya Tirukkovalur On June 22, 2016, 7

Re: Review Request 48055: SENTRY-1209: Sentry does not block Hive's cross-schema table renames

/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java (line 108) <https://reviews.apache.org/r/48055/#comment201321> Should this be all too? As we are essentially creating a new table in this op DB? - Sravya Tirukkovalur On June 6, 2016, 1:44 p.m., Colin Ma

Re: Review Request 48055: SENTRY-1209: Sentry does not block Hive's cross-schema table renames

/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java (line 96) <https://reviews.apache.org/r/48055/#comment200696> Should we enforce "all" instead? As rename is equivalent to dropping the original table from the original db? And creating a new table in new db? - Sravya Tirukkov

Re: Review Request 47640: SENTRY-1260: ArrayIndexOutOfBoundsException in PathsUpdate.parsePath can cause MetastoreCacheInitializer startup to fail

: https://reviews.apache.org/r/47640/diff/ Testing --- Added tests. Thanks, Sravya Tirukkovalur

Review Request 47640: SENTRY-1260: ArrayIndexOutOfBoundsException in PathsUpdate.parsePath can cause MetastoreCacheInitializer startup to fail

/sentry/hdfs/TestMetastoreCacheInitializer.java 9e6072df23ca404cd500a940a1035dfdc03d6928 Diff: https://reviews.apache.org/r/47640/diff/ Testing --- Added tests. Thanks, Sravya Tirukkovalur

Re: Review Request 47569: SENTRY-1265: Sentry service should not require a TGT as it is not talking to other kerberos services as a client

tryServiceIntegrationBase.java 14de0fac6a4a6cc25b36a65c4a7f02dd6fc135e9 Diff: https://reviews.apache.org/r/47569/diff/ Testing --- Updated test TestConnectionWithTicketTimeout to make sure client is able to connect after max.life.time Thanks, Sravya Tirukkovalur

Re: Review Request 47566: SENTRY-1269: Converter vs Convertor is inconsistent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47566/#review133848 --- Ship it! Ship It! - Sravya Tirukkovalur On May 18, 2016, 11

Review Request 47569: SENTRY-1265: Sentry service should not require a TGT as it is not talking to other kerberos services as a client

to connect after max.life.time Thanks, Sravya Tirukkovalur

Re: Review Request 47267: SENTRY-1253: SentryShellKafka is incorrectly setting component as "KAFKA"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47267/#review132765 --- Ship it! Ship It! - Sravya Tirukkovalur On May 11, 2016, 10

Re: [ANNOUNCE] New Sentry Committers - Li Li and Colm O hEigeartaigh

e Li > Li and Colm O hEigeartaigh as committers on the Apache Sentry project. > > Please join me in congratulating Li and Colm! > > Thanks, > Lenni > -- Sravya Tirukkovalur

[DISCUSS] Sentry/HMS HA and HDFS Sentry sync

Hi folks, We are looking into some alternate design choices for HDFS Sentry sync to be able to maintain the edit logs of both path updates(coming from HMS) and perm updates (coming from Sentry) in a persistent state. The main motivation is to make the HA cases more stable, as making the services

Re: Sentry jira dashboard

ew queues, can we have a label or status for > “Design Review” to track the new features Jira that have designs need to be > reviewed? > > Best, > Hao > > On Mon, May 2, 2016 at 6:35 PM, Sravya Tirukkovalur <sra...@apache.org> > wrote: > > > Hi all, > > &

Fwd: Sentry web server - Spnego

Forwarding it to dev@s.a.o instead of dev@s.i.a.o -- Forwarded message -- From: Sravya Tirukkovalur <sra...@cloudera.com> Date: Fri, Apr 29, 2016 at 2:51 PM Subject: Sentry web server - Spnego To: dev <d...@sentry.incubator.apache.org> Hi Dapeng, I am trying t

Build failing

rg refused for project org.restlet.jee:org.restlet.ext.servlet:jar:2.1.1: Connection timed out Is any one here aware of an infra problem? Regards, -- Sravya Tirukkovalur

Re: Notification for brancning Sentry 1.7.0 release

[mailto:gcha...@cloudera.com] > > > > > Sent: Thursday, April 14, 2016 10:40 AM > > > > > To: dev@sentry.apache.org > > > > > Subject: Re: Notification for brancning Sentry 1.7.0 release > > > > > > > > > > Are commits allowed again? I assume so, since I've seen some, but > I > > > > > didn't see a notification on this list. > > > > > > > > > > Thanks, > > > > > Greg > > > > > > > > > > On Mon, Apr 11, 2016 at 11:04 PM, Hao Hao <hao@cloudera.com> > > > wrote: > > > > > > > > > > > Hi All, > > > > > > > > > > > >The official branching for Sentry 1.7.0 is about to start. > > Please > > > > > > hold off any commits until it is finished. Will give another > notice > > > > > > shortly after the process is complete. Thanks a lot! > > > > > > > > > > > > Best, > > > > > > Hao > > > > > > > > > > > > > > > > > > > > > -- Sravya Tirukkovalur

Re: Review Request 46077: SENTRY-1184: Clean up HMSPaths.renameAuthzObject

sts/e2e/hdfs/TestHDFSIntegration.java (line 624) <https://reviews.apache.org/r/46077/#comment191976> table rename always means oldName !=newName - Sravya Tirukkovalur On April 12, 2016, 7:45 p.m., Sravya Tirukkovalur wrote: > > --- &g

Review Request 46081: SENTRY-1181: Lock SentryAuthorizationInfo#processUpdates

/ Testing --- Thanks, Sravya Tirukkovalur

Re: Review Request 45790: SENTRY-1153: Ensure AccessURI work with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45790/#review127986 --- Ship it! Thanks for the change Hao! - Sravya Tirukkovalur

Re: Review Request 45793: SENTRY-1175: Improve usability of URI privileges when granting URIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45793/#review127985 --- Ship it! Ship It! - Sravya Tirukkovalur On April 6, 2016, 1

Re: Review Request 44501: SENTRY-1076: Add SSL support, print version info on Sentry Service webpage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44501/#review127983 --- Ship it! Thanks for adding the test Li! - Sravya Tirukkovalur

Re: [Announcement] Sentry TLP : Git changes

The move has been completed. Please update your repo to https://git-wip-us.apache.org/repos/asf/sentry.git Also, update the sentry website repo to https://svn.apache.org/repos/asf/sentry/site/trunk Thanks! On Sun, Mar 20, 2016 at 12:27 AM, Sravya Tirukkovalur <sra...@apache.org> wrote:

Re: [DISCUSS] Separate commits@ and issues@

nd issues@ > > +1 for doing it while post graduation. Thanks! > > Best, > Hao > > On Wed, Mar 9, 2016 at 11:47 AM, Lenni Kuff <lsk...@cloudera.com> wrote: > > > +1 - This would be great. Would make e-mail filter management much > easier. > > > > O

Re: Sentry Graduation Blog

d contribute > <https://cwiki.apache.org/confluence/display/SENTRY/How+to+Contribute> > through jumping on the discussions on the mailing list, filing bugs through > Jira, reviewing other's’ code or even providing new patches. > -- Sravya Tirukkovalur