[GitHub] 296537044 commented on issue #4544: SQL Editor preview error, choose Hive table and preview throws error. version is v0.22.1.bug?

296537044 commented on issue #4544: SQL Editor preview error, choose Hive table and preview throws error. version is v0.22.1.bug? URL: https://github.com/apache/incubator-superset/issues/4544#issuecomment-380683940 when I use SQL editor to Preview Hive Partition table which has some

[GitHub] mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test

mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test URL: https://github.com/apache/incubator-superset/pull/4798#discussion_r180940507 ## File path: tests/utils.py ## @@ -0,0 +1,14 @@ +# -*- coding: utf-8 -*- +from __future__

[GitHub] mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test

mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test URL: https://github.com/apache/incubator-superset/pull/4798#discussion_r180940507 ## File path: tests/utils.py ## @@ -0,0 +1,14 @@ +# -*- coding: utf-8 -*- +from __future__

[GitHub] mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap

mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180940171 ## File path: superset/migrations/versions/bf706ae5eb46_cal_heatmap_metric_to_metrics.py ## @@ -0,0

[GitHub] mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap

mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180939868 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@ -1003,6 +1010,46 @@ export

[GitHub] mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap

mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180939868 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@ -1003,6 +1010,46 @@ export

[GitHub] codecov-io commented on issue #4800: Improve the calendar heatmap

codecov-io commented on issue #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#issuecomment-380320073 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4800?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4800: Improve the calendar heatmap

codecov-io commented on issue #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#issuecomment-380320073 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4800?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #4791: apply new Dashboard builder to dashboard

williaster commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380619142 @graceguo-supercat 1) the code history etc is a valid concern. I think we should still delete v1, but move files with

[GitHub] williaster commented on issue #4791: apply new Dashboard builder to dashboard

williaster commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380619142 @graceguo-supercat 1) the code history etc is a valid concern. I think we should still delete v1, but move files with

[GitHub] williaster commented on issue #4791: apply new Dashboard builder to dashboard

williaster commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380619142 @graceguo-supercat 1) the code history etc is a valid concern. I think we should still delete v1, but move files with

[GitHub] mistercrunch commented on issue #4807: Make the bottom margin a bit taller

mistercrunch commented on issue #4807: Make the bottom margin a bit taller URL: https://github.com/apache/incubator-superset/pull/4807#issuecomment-380613354 Yeah I had validated the changes mostly in the explore view which has it's own padding, so I missed how close to the edge is was.

[GitHub] mistercrunch commented on issue #4801: [bugfix] dedup groupby columns in Deck visualizations

mistercrunch commented on issue #4801: [bugfix] dedup groupby columns in Deck visualizations URL: https://github.com/apache/incubator-superset/pull/4801#issuecomment-380613068 Didn't want to risk it, the set and list api are not the exact same, not sure if we handle the conversion on

[GitHub] mistercrunch closed pull request #4807: Make the bottom margin a bit taller

mistercrunch closed pull request #4807: Make the bottom margin a bit taller URL: https://github.com/apache/incubator-superset/pull/4807 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mistercrunch closed pull request #4801: [bugfix] dedup groupby columns in Deck visualizations

mistercrunch closed pull request #4801: [bugfix] dedup groupby columns in Deck visualizations URL: https://github.com/apache/incubator-superset/pull/4801 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch commented on issue #4793: [line] do not show 0 or nulls in rich tooltip

mistercrunch commented on issue #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#issuecomment-380612770 @vylc `Show Zeroes in Tooltip` boolean? This is an

[GitHub] mistercrunch closed pull request #4803: [explore] set working default for MetricsControl

mistercrunch closed pull request #4803: [explore] set working default for MetricsControl URL: https://github.com/apache/incubator-superset/pull/4803 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] hughhhh closed pull request #4809: Filter recently viewed to just have explore and dashboard types

hug closed pull request #4809: Filter recently viewed to just have explore and dashboard types URL: https://github.com/apache/incubator-superset/pull/4809 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] hughhhh commented on issue #4809: Filter recently viewed to just have explore and dashboard types

hug commented on issue #4809: Filter recently viewed to just have explore and dashboard types URL: https://github.com/apache/incubator-superset/pull/4809#issuecomment-380609167 Dupe #4808 This is an automated message

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here are my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here are my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here is my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here is my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] betodealmeida commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test

betodealmeida commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test URL: https://github.com/apache/incubator-superset/pull/4798#discussion_r180908278 ## File path: tests/utils.py ## @@ -0,0 +1,14 @@ +# -*- coding: utf-8 -*- +from __future__

[GitHub] codecov-io commented on issue #4793: [line] do not show 0 or nulls in rich tooltip

codecov-io commented on issue #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#issuecomment-379988834 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4793?src=pr=h1) Report > Merging

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here is my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180903978 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180904481 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap

betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180903916 ## File path: superset/assets/javascripts/modules/colors.js ## @@ -122,6 +122,42 @@ export const

[GitHub] GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180903869 ## File path: superset/assets/javascripts/explore/AdhocMetric.js ## @@ -23,10

[GitHub] mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap

mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180903656 ## File path: superset/assets/javascripts/modules/colors.js ## @@ -122,6 +122,42 @@ export const

[GitHub] betodealmeida commented on issue #4793: [line] do not show 0 or nulls in rich tooltip

betodealmeida commented on issue #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#issuecomment-380601086 > Default off/hide as well But showing them is currently not an option — I'm fine with it being an option.

[GitHub] vylc commented on issue #4793: [line] do not show 0 or nulls in rich tooltip

vylc commented on issue #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#issuecomment-380600309 Default off/hide as well Sent from my iPhone > On Apr 11, 2018, at 2:05 PM, Maxime Beauchemin

[GitHub] betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap

betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180900714 ## File path: superset/assets/visualizations/cal_heatmap.js ## @@ -1,38 +1,84 @@ -// JS import d3

[GitHub] betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap

betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180899647 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@ -1003,6 +1010,46 @@

[GitHub] betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap

betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180899636 ## File path: superset/assets/javascripts/modules/colors.js ## @@ -122,6 +122,42 @@ export const

[GitHub] betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap

betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180901321 ## File path: superset/migrations/versions/bf706ae5eb46_cal_heatmap_metric_to_metrics.py ## @@ -0,0

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180898341 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180898894 ## File path: superset/assets/javascripts/explore/components/AdhocMetricOption.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180899096 ## File path: superset/assets/javascripts/explore/components/AdhocMetricOption.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180897757 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180897336 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180899633 ## File path: superset/assets/spec/javascripts/explore/AdhocMetric_spec.js ## @@

[GitHub] williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

williaster commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180896732 ## File path: superset/assets/javascripts/explore/AdhocMetric.js ## @@ -23,10

[GitHub] john-bodley closed pull request #4806: [tests] cleaning up test configuration

john-bodley closed pull request #4806: [tests] cleaning up test configuration URL: https://github.com/apache/incubator-superset/pull/4806 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884402 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] mistercrunch commented on issue #4793: [line] do not show 0 or nulls in rich tooltip

mistercrunch commented on issue #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#issuecomment-380595181 @vylc what do you think about `0`s ? This is an

[GitHub] michellethomas commented on issue #4659: Adding tests for the time table viz

michellethomas commented on issue #4659: Adding tests for the time table viz URL: https://github.com/apache/incubator-superset/pull/4659#issuecomment-380594393 I don't have access, I'm not a committer yet. This is an

[GitHub] betodealmeida commented on a change in pull request #4793: [line] do not show 0 or nulls in rich tooltip

betodealmeida commented on a change in pull request #4793: [line] do not show 0 or nulls in rich tooltip URL: https://github.com/apache/incubator-superset/pull/4793#discussion_r180893787 ## File path: superset/assets/visualizations/nvd3_vis.js ## @@ -424,17 +424,24 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889321 ## File path: superset/assets/javascripts/dashboard/v2/stylesheets/builder.less ## @@ -1,12

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883377 ## File path: superset/assets/javascripts/dashboard/reducers/datasources.js ## @@ -0,0 +1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886743 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884161 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885018 ## File path: superset/assets/javascripts/dashboard/reducers/propShapes.jsx ## @@ -0,0 +1,15

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885141 ## File path: superset/assets/javascripts/dashboard/v2/actions/dashboardLayout.js ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888454 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardComponent.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886001 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180872924 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -127,24

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885413 ## File path: superset/assets/javascripts/dashboard/v2/components/BuilderComponentPane.jsx

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879856 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877123 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877483 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877948 ## File path: superset/assets/javascripts/dashboard/components/SliceAdderContainer.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180880328 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180872812 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -87,12

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876462 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881204 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879319 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,36 +8,17 @@ import {

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874993 ## File path: superset/assets/javascripts/dashboard/components/GridLayout.jsx ## @@ -1,33

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879257 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,36 +8,17 @@ import {

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180869980 ## File path: superset/assets/javascripts/dashboard/actions/allSlices.js ## @@ -0,0 +1,66 @@

[GitHub] mistercrunch commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly

mistercrunch commented on issue #4612: In the “SQL Lab”, the “Results” section shows “Pending” constantly URL: https://github.com/apache/incubator-superset/issues/4612#issuecomment-380587655 Also make sure the port is open, I usually check using the `telnet {host} {port}` command

[GitHub] hughhhh opened a new pull request #4809: Filter recently viewed to just have explore and dashboard types

hug opened a new pull request #4809: Filter recently viewed to just have explore and dashboard types URL: https://github.com/apache/incubator-superset/pull/4809 Filter recently view to only show explore and dashboard actions @betodealmeida @mistercrunch

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180887080 ## File path: superset/assets/javascripts/dashboard/v2/components/gridComponents/ChartHolder.jsx

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883699 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180887685 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889672 ## File path: superset/assets/javascripts/dashboard/v2/util/propShapes.jsx ## @@ -19,6 +19,9

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889189 ## File path: superset/assets/javascripts/dashboard/v2/reducers/index.js ## @@ -1,17 +1,10

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180887523 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardComponent.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885543 ## File path: superset/assets/javascripts/dashboard/v2/components/BuilderComponentPane.jsx

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889255 ## File path: superset/assets/javascripts/dashboard/v2/reducers/index.js ## @@ -1,17 +1,10

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180869813 ## File path: superset/assets/javascripts/dashboard/actions/allSlices.js ## @@ -0,0 +1,66 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881331 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877358 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -1,43

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883555 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180873274 ## File path: superset/assets/javascripts/chart/chartReducer.js ## @@ -6,6 +6,7 @@ import *

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180871667 ## File path: superset/assets/javascripts/dashboard/actions/datasources.js ## @@ -0,0 +1,33

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876633 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883909 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883434 ## File path: superset/assets/javascripts/dashboard/reducers/datasources.js ## @@ -0,0 +1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874259 ## File path: superset/assets/javascripts/dashboard/components/DashboardContainer.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877222 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180878276 ## File path: superset/assets/javascripts/dashboard/components/SliceHeader.jsx ## @@ -1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879991 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876866 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886368 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180871121 ## File path: superset/assets/javascripts/chart/chartAction.js ## @@ -111,6 +111,17 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r18096 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardHeader.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888627 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardGrid.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874614 ## File path: superset/assets/javascripts/dashboard/components/GridCell.jsx ## @@ -4,8 +4,8

  1   2   >