[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-1886/IMPALA-2154: Add support for multi-stream bz2/gzip compressed files.

2016-02-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1886/IMPALA-2154: Add support for multi-stream bz2/gzip compressed files. .. Patch Set 14: (8 comments) http://gerrit.cloudera.org:8080/#/c/2219/14/be/src/e

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-1886/IMPALA-2154: Add support for multi-stream bz2/gzip compressed files.

2016-02-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1886/IMPALA-2154: Add support for multi-stream bz2/gzip compressed files. .. Patch Set 16: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/221

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers

2016-02-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2305/5//COMMI

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3085: Unregister data sinks' MemTrackers at their Close() functions.

2016-02-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3085: Unregister data sinks' MemTrackers at their Close() functions. .. Patch Set 3: Code-Review+2 (1 comment) > (2 comments) > > Yes, I had the same que

[Impala-CR](cdh5-trunk) Get and use Kudu from the toolchain by default

2016-02-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Get and use Kudu from the toolchain by default .. Patch Set 3: Code-Review+2 (3 comments) Please get a review from a kudu person too, especially regarding the testd

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers

2016-02-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2305/5//COMMIT

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers

2016-02-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2305/5//COMMIT

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2592: DataStreamSender::Channel::CloseInternal() does not close the channel on an error.

2016-02-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2592: DataStreamSender::Channel::CloseInternal() does not close the channel on an error. .. Patch Set 7: Now that IMPALA-3093 is resolved, can we move forwar

[Impala-CR](cdh5-2.5.0_5.7.0) Test for IMPALA-2987

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Test for IMPALA-2987 .. Patch Set 2: Tim, please comment on the testing you've done. Do you loop the test some number of iterations to verify it's not flaky? -- T

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2592: DataStreamSender::Channel::CloseInternal() does not close the channel on an error.

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2592: DataStreamSender::Channel::CloseInternal() does not close the channel on an error. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-CR](cdh5-2.5.0_5.7.0) Test for IMPALA-2987

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Test for IMPALA-2987 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2306/3/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: Line 71

[Impala-CR](cdh5-2.5.0_5.7.0) Test for IMPALA-2987

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Test for IMPALA-2987 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2306/3/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: Line 7

[Impala-CR](cdh5-trunk) Specify whether to clone IR function in GetFunction() instead of ReplaceCallSites()

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Specify whether to clone IR function in GetFunction() instead of ReplaceCallSites() .. Patch Set 2: Code-Review+2 (1 comment) Nice cleanup. http://gerrit.cloudera

[Impala-CR](cdh5-trunk) IMPALA-3068: Don't call exit(1) on fatal errors.

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3068: Don't call exit(1) on fatal errors. .. Patch Set 1: Code-Review+2 How did you test this? If you haven't already, please force one of these paths to mak

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor.

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor. .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/2203/6/be/src

[Impala-CR](cdh5-2.5.0_5.7.0) Test for IMPALA-2987

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Test for IMPALA-2987 .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2306 To unsubscribe, visit http://gerrit.cloudera.org:8080/sett

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2592: DataStreamSender::Channel::CloseInternal() does not close the channel on an error.

2016-03-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2592: DataStreamSender::Channel::CloseInternal() does not close the channel on an error. .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-CR](cdh5-trunk) IMPALA-1822: Cleanup query profile log

2016-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1822: Cleanup query profile log .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2260/5/be/src/util/simple-logger.h File be/src/

[Impala-CR](cdh5-trunk) IMPALA-1822: Cleanup query profile log

2016-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1822: Cleanup query profile log .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2260 To unsubscribe, visit http://gerrit.clou

[Impala-CR](cdh5-trunk) IMPALA-1939: Impalad should not require a co-located DataNode

2016-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1939: Impalad should not require a co-located DataNode .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/1121/5/fe/src/main/java/com/cloudera/i

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor.

2016-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor. .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/2203/7/be/src

[Impala-CR](cdh5-trunk) IMPALA-3102: Admission control supportability

2016-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3102: Admission control supportability .. Patch Set 1: Code-Review+2 What testing have you done? -- To view, visit http://gerrit.cloudera.org:8080/2410 To u

[Impala-CR](cdh5-trunk) IMPALA-3102: Admission control supportability

2016-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3102: Admission control supportability .. Patch Set 2: This change is currently on cdh5-trunk. Do you mean to retarget to 2.5.0 branch? -- To view, visit ht

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3102: Admission control supportability

2016-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3102: Admission control supportability .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2432 To unsubscribe, visit http://gerr

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3107: Change DataStreamMgr::lock_ to mutex

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3107: Change DataStreamMgr::lock_ to mutex .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2433 To unsubscribe, visit http://

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3075: Remove -only_metastore option from run-hive-server.sh

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3075: Remove -only_metastore option from run-hive-server.sh .. Patch Set 1: We're going with the other fix on the release right? If so, please abandon this

[Impala-CR](cdh5-2.5.0_5.7.0) Remove unused add_probe_filters field from THashJoinNode

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove unused add_probe_filters field from THashJoinNode .. Patch Set 1: How about we finish this on cdh5-trunk? -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-CR](cdh5-2.5.0_5.7.0) Fix test_exchange_delays in S3 build

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Fix test_exchange_delays in S3 build .. Patch Set 1: We've thought about doing this before, but have always avoided it due to the reason Alex gives. In any case, s

[Impala-CR](cdh5-trunk) IMPALA-1939: Impalad should not require a co-located DataNode

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1939: Impalad should not require a co-located DataNode .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/1121/6//COMMIT_MSG Commit Message: L

[Impala-CR](cdh5-trunk) IMPALA-2728: reenable mem limit test now that it is stable

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2728: reenable mem limit test now that it is stable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2442 To unsubscribe, visi

[Impala-CR](cdh5-2.5.0_5.7.0) Disable logging for fragment report that has no corresponding query

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Disable logging for fragment report that has no corresponding query .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2447 To unsubsc

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor.

2016-03-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/2203/9/be/src/

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/2203/10/be/sr

[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3142: avoid spinlock in MemTracker::GcMemory()

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3142: avoid spinlock in MemTracker::GcMemory() .. Patch Set 1: Code-Review+2 Please ask Silvius for approval. -- To view, visit http://gerrit.cloudera.org:8

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/2203/10/be/src

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/2203/12/be/sr

[Impala-CR](cdh5-trunk) Reduce size of cross-compiled IR

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Reduce size of cross-compiled IR .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2464/1//COMMIT_MSG Commit Message: Line 9: instnamer what did tha

[Impala-CR](cdh5-trunk) IMPALA-2892: buffered-tuple-stream-ir.cc is not cross-compiled

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2892: buffered-tuple-stream-ir.cc is not cross-compiled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2465 To unsubscribe,

[Impala-CR](cdh5-trunk) IMPALA-2949: enable -Werror for debug builds

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2949: enable -Werror for debug builds .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2420/1/be/CMakeLists.txt File be/CMakeLis

[Impala-CR](cdh5-trunk) IMPALA-2466: Add more tests for the HDFS parquet scanner.

2016-03-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2466: Add more tests for the HDFS parquet scanner. .. Patch Set 1: ping -- To view, visit http://gerrit.cloudera.org:8080/1500 To unsubscribe, visit http://

[Impala-CR](cdh5-trunk) Reduce size of cross-compiled IR

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Reduce size of cross-compiled IR .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2464/1/be/src/common/status.h File be/src/common/status.h: Line 15

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/2203/12/be/sr

[Impala-CR](cdh5-trunk) IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random.

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random. .. Patch Set 1: (1 comment) How did you test this? http://ger

[Impala-CR](cdh5-trunk) IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random.

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random. .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-CR](cdh5-trunk) IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random.

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random. .. Patch Set 3: This change is against cdh5-trunk. Did you mea

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/2203/13/be/sr

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/2203/13/be/src

[Impala-CR](cdh5-trunk) IMPALA-3105: rework handling of tuple buffer sizing in RowBatch

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3105: rework handling of tuple buffer sizing in RowBatch .. Patch Set 2: Can this be used in HdfsScanner::StartNewRowBatch(). Also, DataStreamSender::Channel

[Impala-CR](cdh5-trunk) Reduce size of cross-compiled IR

2016-03-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Reduce size of cross-compiled IR .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.o

[Impala-CR](cdh5-trunk) Review Only: Kudu Impala integration

2016-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Review Only: Kudu Impala integration .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1403/1/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanne

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/2203/14/be/sr

[Impala-CR](cdh5-trunk) IMPALA-561: Allow multiple callbacks in a thread resource pool.

2016-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool. .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/2430/4/be/src/exec/hdfs-scan-node.c

[Impala-CR](cdh5-trunk) IMPALA-561: Allow multiple callbacks in a thread resource pool.

2016-03-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool. .. Patch Set 5: Code-Review+2 Using a list and list iterators (rather than vector and indices) might

[Impala-CR](cdh5-trunk) IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/2500 Change subject: IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay .. IMPALA-3161: gperfutil SpinLock suffers from potentia

[Impala-CR](cdh5-trunk) IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay .. Patch Set 1: While we don't build the thirdparty version by default (unless toolchain is dis

[Impala-CR](cdh5-trunk) IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#2). Change subject: IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay .. IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay Backport

[Impala-CR](cdh5-trunk) IMPALA-3161: (part 1) gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/2501 Change subject: IMPALA-3161: (part 1) gperfutil SpinLock suffers from potential wakeup delay .. IMPALA-3161: (part 1) gperfutil SpinLock suf

[Impala-CR](cdh5-trunk) IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay .. Patch Set 2: > Did you consider upgrading gperftools completely? > > The release

[Toolchain-CR] IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/2503 Change subject: IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay .. IMPALA-3161: gperfutil SpinLock suffers from potentia

[Impala-CR](cdh5-trunk) IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay .. Patch Set 2: Filed IMPALA-3162 for the full upgrade. I still think this targeted fix

[Toolchain-CR] IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3161: gperfutil SpinLock suffers from potential wakeup delay .. Patch Set 1: I'll wait for these: http://gerrit.cloudera.org:8080/2501 http://gerrit.clouder

[Impala-CR](cdh5-trunk) Review Only: Kudu Impala integration

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Review Only: Kudu Impala integration .. Patch Set 7: Code-Review+1 (1 comment) Backend still looks okay to me. http://gerrit.cloudera.org:8080/#/c/1403/7/be/src/sc

[Impala-CR](cdh5-trunk) IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/1121/6/tests/query_test/test_mult

[Impala-CR](cdh5-trunk) IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3161: (part 2) gperfutil SpinLock suffers from potential wakeup delay .. Patch Set 2: Code-Review-2 Want to prevent this from merging until we figure out som

[Impala-CR](cdh5-trunk) IMPALA-3161: (part 1) gperfutil SpinLock suffers from potential wakeup delay

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3161: (part 1) gperfutil SpinLock suffers from potential wakeup delay .. Patch Set 1: Code-Review-2 Want to prevent this from merging until we figure out som

[Impala-CR](cdh5-trunk) IMPALA-3045: Allow user defined package root.

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3045: Allow user defined package root. .. Patch Set 1: > So the work flow is something like: > fork your own native-toolchain > make changes as patches > c

[Impala-CR](cdh5-trunk) IMPALA-3045: Allow user defined package root.

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3045: Allow user defined package root. .. Patch Set 1: I see. Yeah, we need to sort this out one way or another so it's possible to test end-to-end changes t

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 15: (2 comments) Just one more thing about the DCHECK. lmk what yo

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#4). Change subject: IMPALA-3136: Use gutil SpinLock .. IMPALA-3136: Use gutil SpinLock Impala's SpinLock implementation does a busy wait (it yields, but won't block). This is bad because

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2507/4/be/src/gutil/dynamic_annotations.h File be/src/gutil/dynamic_

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock .. Patch Set 4: > (1 comment) > > Do we want to review the spinlock implementation in detail? It > looks like it does what we wan

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#5). Change subject: IMPALA-3136: Use gutil SpinLock .. IMPALA-3136: Use gutil SpinLock Impala's SpinLock implementation does a busy wait (it yields, but won't block). This is bad because

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2507/4//COMMIT_MSG Commit Message: Line 28: defintions > definition

[Toolchain-CR] Add gperftools 2.4

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add gperftools 2.4 .. Patch Set 1: Code-Review+2 Assuming testing goes okay seems fine to me. (I guess we don't keep the base source tar in source control at all,

[Impala-CR](cdh5-trunk) IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-CR](cdh5-trunk) Switch to gperftools 2.4

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Switch to gperftools 2.4 .. Patch Set 1: Code-Review+1 (1 comment) Please, double check with Henry on the DISABLE_IMPALA_TOOLCHAIN case (which I think will then de

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock .. Patch Set 5: > Also, is there any reason to use boost::mutex still, given that > this is reasonable to use under contention? Pro

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2507 to look at the new patch set (#6). Change subject: IMPALA-3136: Use gutil SpinLock .. IMPALA-3136: Use gutil SpinL

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2507/6/be/src/gutil/atomicops-internals-x86.h File be/src/gutil/atom

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2507/6/be/src/gutil/atomicops-internals-x86.h File be/src/gutil/atom

[Impala-CR](cdh5-trunk) Remove AMD Opteron Rev E workaround from atomicops

2016-03-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/2516 Change subject: Remove AMD Opteron Rev E workaround from atomicops .. Remove AMD Opteron Rev E workaround from atomicops Impala doesn't run

[Impala-CR](cdh5-trunk) Remove AMD Opteron Rev E workaround from atomicops

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove AMD Opteron Rev E workaround from atomicops .. Patch Set 1: > Does Impala just shutdown if you try starting it on Opeteron Rev E > today ? In practice, yes

[Impala-CR](cdh5-trunk) Remove AMD Opteron Rev E workaround from atomicops

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove AMD Opteron Rev E workaround from atomicops .. Patch Set 1: > Just passing by. Re: "make out Atomic class use these functions" - > wouldn't we prefer to depe

[Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2507 To unsubscribe, visit http://gerrit.cloudera.or

[Impala-CR](cdh5-trunk) Remove AMD Opteron Rev E workaround from atomicops

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove AMD Opteron Rev E workaround from atomicops .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2516 To unsubscribe, visit http:/

[Impala-CR](cdh5-trunk) IMPALA-3162: Upgrade to gperftools 2.4

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3162: Upgrade to gperftools 2.4 .. Patch Set 2: > +Henry: Per the discussion about removing thirdparty, does it seem > OK to make this change to use gperfto

[Impala-CR](cdh5-trunk) Remove AMD Opteron Rev E workaround from atomicops

2016-03-10 Thread Dan Hecht (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2516 to look at the new patch set (#2). Change subject: Remove AMD Opteron Rev E workaround from atomicops .

[Impala-CR](cdh5-trunk) Remove AMD Opteron Rev E workaround from atomicops

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove AMD Opteron Rev E workaround from atomicops .. Patch Set 2: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/2516 To unsubscribe, visi

[Impala-CR](cdh5-trunk) Refer to local rather than member in PAGG::ProcessBatchStreaming()

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Refer to local rather than member in PAGG::ProcessBatchStreaming() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2524 To unsubscr

[Impala-CR](cdh5-trunk) IMPALA-3162: Upgrade to gperftools 2.4

2016-03-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3162: Upgrade to gperftools 2.4 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2509 To unsubscribe, visit http://gerrit.clou

[Impala-CR](cdh5-trunk) Review Only: Kudu Impala integration

2016-03-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Review Only: Kudu Impala integration .. Patch Set 8: Code-Review+1 (1 comment) BE looks okay but would be good if you could address that one nit. http://gerrit.clo

[Impala-CR](cdh5-trunk) IMPALA-3114: Add a pause monitor for impala processes.

2016-03-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3114: Add a pause monitor for impala processes. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2405/4/be/src/common/init.cc File be/src/com

[Impala-CR](cdh5-trunk) IMPALA-3183: clang doesn't allow C files to have -std=c++14

2016-03-14 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/2540 Change subject: IMPALA-3183: clang doesn't allow C files to have -std=c++14 .. IMPALA-3183: clang doesn't allow C files to have -std=c++14 U

[Impala-CR](cdh5-trunk) IMPALA-3183: clang doesn't allow C files to have -std=c++14

2016-03-14 Thread Dan Hecht (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2540 to look at the new patch set (#2). Change subject: IMPALA-3183: clang doesn't allow C files to have -std=c++14 ..

[Impala-CR](cdh5-trunk) IMPALA-3183: clang doesn't allow C files to have -std=c++14

2016-03-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3183: clang doesn't allow C files to have -std=c++14 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2540/1/be/src/gutil/dynamic_annotations.

[Impala-CR](cdh5-trunk) IMPALA-3114: Add a pause monitor for impala processes.

2016-03-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3114: Add a pause monitor for impala processes. .. Patch Set 5: > Dan, do you think the param defaults are ok? Should they be made > configurable? Generall

[Impala-CR](cdh5-trunk) IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option

2016-03-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option .. Patch Set 1: (1 comment) What would break if we made this the default behavior? http://gerrit.cloudera.or

[Impala-CR](cdh5-trunk) PREVIEW do parquet schema resolution by name instead of ordinal

2016-03-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: PREVIEW do parquet schema resolution by name instead of ordinal .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2384/1/be/src/exec/hdfs-parquet-sca

[Toolchain-CR] IMPALA-3162: Upgrade gperftools from 2.4 to 2.5

2016-03-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3162: Upgrade gperftools from 2.4 to 2.5 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2538 To unsubscribe, visit http://ge

[Impala-CR](cdh5-trunk) IMPALA-3162: Upgrade to gperftools 2.5

2016-03-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3162: Upgrade to gperftools 2.5 .. Patch Set 5: Code-Review+2 Assuming you did the same testing as for 2.4. Please don't forget to wait until after the kimpa

  1   2   3   4   5   6   7   8   9   >