Because PrepareApStartupVector() stores StackAddress to
"mExchangeInfo->StackStart" (which has type (VOID*)), and because
"UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm" reads the latter with:
add edi, StackStartAddressLocation
add rax, qword [edi]
mov rsp, rax
Because CpuS3Data memory will be copy to smram at SmmReadToLock point by
PiSmmCpuDxeSmm driver,
the memory type no need to be ACPI NVS type, also the address not limit to
below 4G.
This change remove the limit of ACPI NVS memory type and below 4G.
Cc: Marvin H user
Cc: Fan Jeff
Cc: Laszlo
Because CpuS3Data memory will be copy to smram at SmmReadyToLock point,
the memory type no need to be ACPI NVS type, also the address not
limit to below 4G.
This change remove the limit of ACPI NVS memory type and below 4G.
Pass OS boot and resume from S3 test.
Cc: Marvin Häuser
Cc: Fan Jeff
Current implementation copies GDT/IDT at SmmReadyToLock point
from ACPI NVS memory to Smram. Later at S3 resume phase, it restores
memory saved in Smram to ACPI NVS. Driver can directly use GDT/IDT
saved in Smram instead of restore the original ACPI NVS memory.
This patch do this change.
Test
V1 changes:
> Current code logic can't confirm CpuS3DataDxe driver start before
> CpuFeaturesDxe driver. So the assumption in CpuFeaturesDxe not valid.
> Add implementation for AllocateAcpiCpuData function to remove this
> assumption.
V2 changes:
> Because CpuS3Data memory will be copy to smram
ACPI_CPU_DATA structure first introduced to save data in
normal boot phase. Also this data will be used in S3 phase
by one PEI driver. So in first phase, this data is been
defined to use ACPI NVS memory type and must below 4G.
Later in order to fix potential security issue,
PiSmmCpuDxeSmm driver
Sorry. Correct some critical wording.
“ACPI NVS and 4G limitation are history reason and are NOT necessary currently.”
Jeff
发件人: edk2-devel 代表 Fan Jeff
发送时间: Friday, August 10, 2018 12:00:08 PM
收件人: Dong, Eric; 'Laszlo Ersek'
抄送: Ni, Ruiyu; Kinney,
Hi,
ACPI NVS and 4G limitation are history reason and are necessary currently. I
agree to do such cleanup from header file and implementation.
Long term, could we think of combine CpuFeaturesDxe and CpuS3DataDxe?
Jeff
发送自 Windows 10
Hi Laszlo,
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, August 9, 2018 12:55 AM
> To: Dong, Eric
> Cc: Ni, Ruiyu ; Kinney, Michael D
> ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [Patch v2 2/2]
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, August 9, 2018 7:21 PM
> To: Ni, Ruiyu ; Dong, Eric ; edk2-
> de...@lists.01.org
> Subject: Re: [edk2] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib:
> Combine implementation.
>
> On
One minor comment:
Please help to remove the comment that mentioned 'UfsPeimUnlinkMemBlock'
within function UfsPeimFreeMemPool().
For me,
//
// Unlink all the memory blocks from the pool, then free them.
//
will be fine.
With that change,
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
>
One minor comment:
Please help to remove the comment that mentioned 'SdPeimUnlinkMemBlock'
within function SdPeimFreeMemPool().
For me,
//
// Unlink all the memory blocks from the pool, then free them.
//
will be fine.
With that change,
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
>
One minor comment:
Please help to remove the comment that mentioned 'EmmcPeimUnlinkMemBlock'
within function EmmcPeimFreeMemPool().
For me,
//
// Unlink all the memory blocks from the pool, then free them.
//
will be fine.
With that change,
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
>
在 8/4/2018 10:47 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:14PM +0800, Ming Huang wrote:
>> From: Luqi Jiang
>>
>> This driver provide a means for the platform to
>> convey error information to OSPM.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by:
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Wednesday, August 08, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Zeng, Star
> Subject: [edk2] [PATCH 05/26]
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Wednesday, August 08, 2018 4:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Zeng, Star
> Subject: [edk2] [PATCH 12/26]
在 8/4/2018 11:18 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:18PM +0800, Ming Huang wrote:
>> From: shaochangliang
>>
>> During the period of I2c accessing, if the board is reset
>> unexpectedly, and because the I2c client can not reset,
>> the SDA will be always pull down, then it
在 8/9/2018 8:27 PM, Leif Lindholm 写道:
> On Thu, Aug 09, 2018 at 08:15:27PM +0800, Ming wrote:
>> 在 8/4/2018 11:14 PM, Leif Lindholm 写道:
>>> On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote:
From: ZhenYao
When BIOS booting, the power consumption is too high, so need
The series will add RSB stuffing logics to avoid RSB underflow on return
from SMM (rsm instruction).
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Laszlo Ersek
Hao Wu (2):
UefiCpuPkg/SmmCpuFeaturesLib: Add RSB stuffing before rsm instruction
UefiCpuPkg/PiSmmCpuDxeSmm: Add RSB stuffing before rsm
System Management Interrupt (SMI) handlers can leave the Return Stack
Buffer (RSB) in a state that application program or operating-system does
not expect.
In order to avoid RSB underflow on return from SMI, this commit will add
RSB stuffing logic before instruction 'rsm'.
After the stuffing,
在 8/8/2018 8:53 PM, Leif Lindholm 写道:
> On Wed, Aug 08, 2018 at 07:44:36PM +0800, Ming wrote:
>>
>>
>> 在 8/8/2018 5:59 PM, Leif Lindholm 写道:
>>> On Wed, Aug 08, 2018 at 05:02:15PM +0800, Ming wrote:
在 8/3/2018 1:36 AM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:51PM +0800, Ming
System Management Interrupt (SMI) handlers can leave the Return Stack
Buffer (RSB) in a state that application program or operating-system does
not expect.
In order to avoid RSB underflow on return from SMI, this commit will add
RSB stuffing logic before instruction 'rsm'.
After the stuffing,
Hi Siva,
Since the gateway and Remote IP is accessible from shell, it means the platform
already has the valid gateway, then according the IP policy, it should be ready
for the upper layer to access the Internet, UEFI HttpBootDxe driver has
verified that by registering one valid gateway. So,
From: "Kinney, Michael D"
Cc: David Wei
Cc: Mang Guo
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
---
.../Library/GenericBdsLib/BdsConsole.c| 11 +++
.../Library/GenericBdsLib/GenericBdsLib.inf | 1
Cc: David Wei
Cc: Mang Guo
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
---
.../Capsule/Library/FmpDeviceLib/FmpDeviceLib.c| 607 +
.../Capsule/Library/FmpDeviceLib/FmpDeviceLib.inf | 63 +++
Cc: David Wei
Cc: Mang Guo
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
---
Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc | 61 +++
Vlv2TbltDevicePkg/FmpCertificate.dsc | 28 +
Use GenerateCapsule to generate capsules for MinnowMax
debug and release builds and sample devices.
Cc: David Wei
Cc: Mang Guo
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
---
.../Capsule/GenerateCapsule/GenCapsuleAll.bat | 35 +
Update Vlv2TbltDevicePkg to build UEFI capsules for system firmare and device
firmware using the GenerateCapsule tool and use the FmpDevicePkg to implement
drivers that produce the Firmware Management Protocol to process UEFI capsules.
* Update Vlv2TbltDevicePkg specific BDS to notify when test
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
D Kinney
Sent: Friday, August 10, 2018 5:20 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] Maintainers.txt: Add FmpDevicePkg maintainers
This patch adds
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric
> Dong
> Sent: Thursday, August 09, 2018 1:14 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A
> Subject: [edk2] [Patch]
This patch adds maintainers for the FmpDevicePkg.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7295cd6b83..df7dc48f75 100644
---
The "MicroPython Test Framework for UEFI" project has been added to
edk2-staging for community feedback.
https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework
This includes a port of MicroPython to UEFI and a test execution environment
that can run from the UEFI Shell.
On 08/09/18 16:33, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The library constructor is not being called because of the typo,
> causing TPM2 detection/initialization to fail.
>
> This fixes OVMF TPM2 regression since commit f15cb995bb38.
>
On 08/09/18 14:14, Hristo Mihaylov wrote:
> Hello,
>
> This is my first time posting to a mailing list. I am building a custom
> platform that fails when handing off control from PEIM to DXE.
>
> Here's the error:
>
> ```
> ASSERT_EFI_ERROR (Status = Not Found)
> ASSERT
>
On 08/09/18 17:41, jim.dai...@dell.com wrote:
> The InvalidChars[] array is only used in function IsValidCommandName().
> The array should be deleted also, I think.
I've pointed out a similar continuation for another patch:
On 08/09/18 17:46, Zhang, Chao B wrote:
> Hi Laszlo:
>We seriously considered such dependency change in design. The library is
> shared between DXE & PEI. So PCD is the generic way to share the data and
> reduce real register touch.
> Therefore, the problem is that Library can’t be used by
On Thu, Aug 09, 2018 at 11:40:12PM +0800, Ming wrote:
>
>
> 在 8/9/2018 10:44 PM, Leif Lindholm 写道:
> > On Thu, Aug 09, 2018 at 10:17:43PM +0800, Ming wrote:
> >>
> >>
> >> 在 8/4/2018 11:20 PM, Leif Lindholm 写道:
> >>> On Tue, Jul 24, 2018 at 03:09:19PM +0800, Ming Huang wrote:
> If install
Hi Laszlo:
We seriously considered such dependency change in design. The library is
shared between DXE & PEI. So PCD is the generic way to share the data and
reduce real register touch.
Therefore, the problem is that Library can’t be used by SEC anymore. The
decision is, since there is no
The InvalidChars[] array is only used in function IsValidCommandName().
The array should be deleted also, I think.
Regards,
Jim
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of shenglei
Sent: Thursday, August 9, 2018 12:42 AM
To:
在 8/9/2018 10:44 PM, Leif Lindholm 写道:
> On Thu, Aug 09, 2018 at 10:17:43PM +0800, Ming wrote:
>>
>>
>> 在 8/4/2018 11:20 PM, Leif Lindholm 写道:
>>> On Tue, Jul 24, 2018 at 03:09:19PM +0800, Ming Huang wrote:
If install SPCR table, KVM will not output while install or boot
some OS, like
HI Lureau:
Thanks for you investigation. It is my typo! The reason why we didn’t have
this issue is that we only use TPM2InstanceLib.
That lib use the correct definition.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Reviewed-by : Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
marcandre.lur...@redhat.com
Sent: Thursday, August 9, 2018 10:33 PM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Zhang, Chao B ;
Long, Qin
Subject: [edk2] [PATCH 1/1]
Both look good.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Wednesday, August 08, 2018 8:45 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/2] Fix two bugs regarding shell
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, August 08, 2018 10:42 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [PATCH] ShellPkg Shell: Remove redundant functions
> Importance: High
>
> The redundant functions
On 08/09/18 16:33, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The library constructor is not being called because of the typo,
> causing TPM2 detection/initialization to fail.
>
> This fixes OVMF TPM2 regression since commit f15cb995bb38.
>
On 08/09/18 16:09, Marc-André Lureau wrote:
> Hi
>
> On Mon, Aug 6, 2018 at 5:26 PM, Zhang, Chao B wrote:
>> Hi Ricardo
>>I double checked OVMF Debug Build. All the 2 PCDs are already built as
>> Dynamic PCD. There should be no problem
>> Setting & Getting these PCD as Dynamic. We also
On Thu, Aug 09, 2018 at 10:17:43PM +0800, Ming wrote:
>
>
> 在 8/4/2018 11:20 PM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:09:19PM +0800, Ming Huang wrote:
> >> If install SPCR table, KVM will not output while install or boot
> >> some OS, like ubuntu,
> >
> > Will not output?
> > Do you
在 8/9/2018 6:19 PM, Leif Lindholm 写道:
> On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote:
+UINT16 crc_tab[256] = {
>>>
>>> CrcTable.
>>
>> Modify it in v2.
>>
>>> Hmm.
>>> This might be useful to add to a core library/driver/protocol. We
>>> don't appear to have it yet. This is another
From: Marc-André Lureau
The library constructor is not being called because of the typo,
causing TPM2 detection/initialization to fail.
This fixes OVMF TPM2 regression since commit f15cb995bb38.
https://bugzilla.tianocore.org/show_bug.cgi?id=1075
Cc: Laszlo Ersek
Cc: Zhang Chao B
Cc: Long
在 8/6/2018 6:03 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:22PM +0800, Ming Huang wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang
>> ---
>> Platform/Hisilicon/D03/D03.dsc | 2 +-
>> Platform/Hisilicon/D05/D05.dsc | 2 +-
>>
在 8/6/2018 6:01 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:21PM +0800, Ming Huang wrote:
>> Add a Null PciPlatformLib for build D06.
>
> Why? (Add some more detail to commit message, please.)
This patch set is base the switch generic PciHostBridge patch set
which add two api for
On 08/08/18 10:47, shenglei wrote:
> The function IsDevicePathExist that is never called
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
>
On 08/08/18 10:47, shenglei wrote:
> The functions that are never called have been removed.
> They are SockRcvdErr,SockGroup and TcpPawsOK.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
>
在 8/6/2018 5:59 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:20PM +0800, Ming Huang wrote:
>> Select without SMMU iort while SMMU item is disable,
>> Select with SMMU iort while SMMU item is enable.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming
On 08/08/18 10:47, shenglei wrote:
> The function IScsiFindTcbByITT that is never calld
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
>
在 8/4/2018 11:20 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:19PM +0800, Ming Huang wrote:
>> If install SPCR table, KVM will not output while install or boot
>> some OS, like ubuntu,
>
> Will not output?
> Do you mean it disables the graphical output of the OS?
Yes, the behaviour of
On 08/08/18 10:47, shenglei wrote:
> The function Ip4Config2OnDhcp4Event that is never calld
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
>
On 08/08/18 10:47, shenglei wrote:
> The function GetStorageWidth that is never calld
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
>
On 08/08/18 10:47, shenglei wrote:
> The function UnicodeFiFoGetKeyCount that is never calld
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
>
On 08/08/18 10:47, shenglei wrote:
> The function DisableKeyboard that is never calld
> has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
>
Hi
On Mon, Aug 6, 2018 at 5:26 PM, Zhang, Chao B wrote:
> Hi Ricardo
>I double checked OVMF Debug Build. All the 2 PCDs are already built as
> Dynamic PCD. There should be no problem
> Setting & Getting these PCD as Dynamic. We also verified this feature on
> several real hardware
On 08/08/18 10:47, shenglei wrote:
> The functions that are never called have been removed.
> They are IsImageInsideSmram,FindImageRecord,SmmRemoveImageRecord,
> SmmMemoryAttributesTableConsistencyCheck,DumpSmmMemoryMapEntry,
> SmmMemoryMapConsistencyCheckRange,SmmMemoryMapConsistencyCheck,
>
On 08/08/18 10:47, shenglei wrote:
> The functions that are never called have been removed.
> They are ClearGuardMapBit,SetGuardMapBit,IsHeadGuard,
> IsTailGuard and CoreEfiNotAvailableYetArg0.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
>
On 08/08/18 10:47, shenglei wrote:
> The functions that are never called have been removed.
> They are UsbHubCtrlSetHubFeature,UsbHubCtrlResetTT,UsbHcReset,
> UsbHcAsyncIsochronousTransfer,UsbHcGetState,UsbHcSetState and
> UsbHcIsochronousTransfer.
>
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are XhcReadDoorBellReg and XhcWriteOpReg16.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are ReadNvmeAdminSubmissionQueueBaseAddress,
> ReadNvmeAdminCompletionQueueBaseAddress and ReadNvmeAdminQueueAttributes
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc:
On 08/03/18 14:15, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: open_file_by_devpath_tiano_1008_v2
>
> This is version 2 of the patch set that was originally posted at:
>
> https://lists.01.org/pipermail/edk2-devel/2018-July/027253.html
>
> for
BUILD_CPPFLAGS should be expanded before BUILD_CFLAGS. (The rule for C++
source files already does this, with BUILD_CPPFLAGS and BUILD_CXXFLAGS.)
This patch doesn't change behavior.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
Contributed-under:
Allow the caller of the top-level makefile either to set EXTRA_LDFLAGS in
the environment or to pass EXTRA_LDFLAGS as a macro definition on the
command line. EXTRA_LDFLAGS extends (and potentially overrides) default
link-editing flags set in the makefiles.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref:
Allow the caller of the top-level makefile either to set EXTRA_OPTFLAGS in
the environment or to pass EXTRA_OPTFLAGS as a macro definition on the
command line. EXTRA_OPTFLAGS extends (and potentially overrides) default C
compilation flags set in the makefiles.
Cc: Liming Gao
Cc: Yonghong Zhu
The option "-O2" is not a preprocessor flag, but a code generation
(compilation) flag. Move it from BUILD_CPPFLAGS to BUILD_CFLAGS and
BUILD_CXXFLAGS.
Because "VfrCompile/GNUmakefile" uses "-O2" through BUILD_CPPFLAGS, and
because it doesn't use BUILD_CXXFLAGS, we have to introduce BUILD_OPTFLAGS
Option "-c" is a mode selection flag (choosing between compiling and
linking); it should not be in BUILD_CFLAGS, which applies only to
compiling anyway. The compilation rule for C source files, in
"footer.makefile", already includes "-c" -- currently we have double "-c"
options.
This patch
Repo: https://github.com/lersek/edk2.git
Branch: extra_flags_rhbz1540244_v2
Version 1 of this set was posted at
20180726004415.13381-1-lersek@redhat.com">http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html
In
On Thu, Aug 09, 2018 at 08:15:27PM +0800, Ming wrote:
> 在 8/4/2018 11:14 PM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote:
> >> From: ZhenYao
> >>
> >> When BIOS booting, the power consumption is too high, so need close
> >> some clusters clock that don't work
在 8/4/2018 11:14 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote:
>> From: ZhenYao
>>
>> When BIOS booting, the power consumption is too high, so need close
>> some clusters clock that don't work to reduce power consumption.
>
> On the one hand: should this
Hello,
This is my first time posting to a mailing list. I am building a custom
platform that fails when handing off control from PEIM to DXE.
Here's the error:
```
ASSERT_EFI_ERROR (Status = Not Found)
ASSERT
在 8/4/2018 10:58 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:15PM +0800, Ming Huang wrote:
>> Add soem Lpc macro to LpcLib.h for D06.
>
> soem -> some
>
> I have no issue with this patch, but can you explain when these macros
> are intended to be used? And if in this set, move this
在 8/9/2018 6:27 PM, Leif Lindholm 写道:
> On Thu, Aug 09, 2018 at 03:07:07PM +0800, Ming wrote:
>> 在 8/4/2018 5:59 PM, Leif Lindholm 写道:
>>> On Tue, Jul 24, 2018 at 03:09:11PM +0800, Ming Huang wrote:
This peim configuare SMMU,AP,MN.
>>>
>>> configuare -> configure
>>>
>>> I know SMMU and AP,
On Thu, Aug 09, 2018 at 07:40:27PM +0800, Ming wrote:
>
>
> 在 8/3/2018 6:31 PM, Ard Biesheuvel 写道:
> > On 24 July 2018 at 09:08, Ming Huang wrote:
> >> From: Sun Yuanchen
> >>
> >> according as watchdog design on D06, watchdog should be
> >> stoped befor boot a option.
> >>
> >
> > Why? The
在 8/3/2018 6:31 PM, Ard Biesheuvel 写道:
> On 24 July 2018 at 09:08, Ming Huang wrote:
>> From: Sun Yuanchen
>>
>> according as watchdog design on D06, watchdog should be
>> stoped befor boot a option.
>>
>
> Why? The DXE core already handles the watchdog, why do you need
> something special
On 08/09/18 05:18, Ni, Ruiyu wrote:
> We've reviewed the whole producer/consumer code and came to the conclusion
> that 4GB/NVS restriction is unnecessary.
I'd like to comment on this from a workflow POV as well.
If you perform a detailed review of the code, that's great. However, in
that case,
On 08/09/18 05:18, Ni, Ruiyu wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Thursday, August 9, 2018 5:29 AM
>> To: Dong, Eric ; edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>> Subject: Re: [edk2] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib:
>> Combine implementation.
>>
>>
Hello Jiaxin,
There is no firewall blocking this. The gateway and Remote IP is accessible
from shell.
Thanks
Siva
-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Monday, August 6, 2018 1:35 PM
To: Sivaraman Nainar; Ye, Ting; Laszlo Ersek; edk2-devel@lists.01.org
On Thu, Aug 09, 2018 at 03:07:07PM +0800, Ming wrote:
> 在 8/4/2018 5:59 PM, Leif Lindholm 写道:
> > On Tue, Jul 24, 2018 at 03:09:11PM +0800, Ming Huang wrote:
> >> This peim configuare SMMU,AP,MN.
> >
> > configuare -> configure
> >
> > I know SMMU and AP, but I don't know MN.
>
> MN:
There is a typo in commit log. 'calld' should be 'callled'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 21/26]
There is a typo in commit log. 'calld' should be 'callled'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 22/26]
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 26/26] MdeModulePkg SetupBrowserDxe: Remove a redundant function
The function IsDevicePathExist that is never
Cc Siyuan and Jiaxin.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 25/26] MdeModulePkg Tcp4Dxe: Remove redundant functions
The functions that are never called have
Cc Siyuan and Jiaxin.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 24/26] MdeModulePkg IScsiDxe: Remove a redundant function
The function IScsiFindTcbByITT that is
Cc Siyuan and Jiaxin.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 23/26] MdeModulePkg Ip4Dxe: Remove a redundant function
The function Ip4Config2OnDhcp4Event that
Reviewed-by: Star Zeng
Cc Hao.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 05/26] MdeModulePkg NvmExpressDxe: Remove redundant functions
The functions that are
On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote:
> >> +UINT16 crc_tab[256] = {
> >
> > CrcTable.
>
> Modify it in v2.
>
> > Hmm.
> > This might be useful to add to a core library/driver/protocol. We
> > don't appear to have it yet. This is another note to the universe.
>
> Do you suggest
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions
The functions that are never called have been
I agree with Laszlo. Reviewed-by: Star Zeng .
The commit log only mentions the changes in AhciMode.c, but not IdeMode.c.
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 9, 2018 2:12 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc:
On Thu, Aug 09, 2018 at 05:42:02AM +, Chris Co wrote:
> Hi Leif,
>
> > -Original Message-
> > From: Leif Lindholm
> > Sent: Tuesday, August 7, 2018 5:50 AM
> > To: Chris Co
> > Cc: edk2-devel@lists.01.org; Michael D Kinney
> > ; Ard Biesheuvel
> > Subject: Re: [PATCH edk2-platforms
There is a typo in commit log. 'calld' should be 'callled'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 01/26]
A redundant GUID and some library classes are removed
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h | 1 -
在 8/4/2018 9:41 PM, Leif Lindholm 写道:
> Ard: could you give this one an additional sanity check?
>
> Some (mostly style) comments inline below.
>
> On Tue, Jul 24, 2018 at 03:09:13PM +0800, Ming Huang wrote:
>> PciHostBridgeLib which is need by PciHostBridgeDxe,provide
>> root bridges and deal
在 8/4/2018 6:06 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:12PM +0800, Ming Huang wrote:
>> From: shaochangliang
>>
>> Add PcdSFCMEM0BaseAddress to D06 and switch three 32-bit macro
>> PcdFlashNvStorage to 64-bit for D05/D03.
>>
>> Contributed-under: TianoCore Contribution Agreement
1 - 100 of 110 matches
Mail list logo
