Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Ming Huang
On 11/20/2018 10:39 PM, Leif Lindholm wrote: > On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote: > And all Hisilicon platforms still use > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > regardless of Secure Boot setting. > > So

Re: [edk2] [PATCH] BaseTools: AutoGen and GenFds share the parser data.

2018-11-20 Thread Feng, Bob C
Hi Zhiqiang, Could you extract the common part of your new API and the original main() function into one function. And call it in both your new API and main() ? Thanks, Bob -Original Message- From: Zhao, ZhiqiangX Sent: Wednesday, November 21, 2018 2:33 PM To: edk2-devel@lists.01.org

[edk2] [PATCH] BaseTools: AutoGen and GenFds share the parser data.

2018-11-20 Thread Zhaozh1x
https://bugzilla.tianocore.org/show_bug.cgi?id=1288 Currently, AutoGen and GenFds run in different python interpreters. The parser are duplicated. This patch is going to create new API for GenFds and have the build to call that API instead of executing GenFds.py. As such, the GenFds and build can

Re: [edk2] [PATCH v2 1/2] MdeModulePkg/SmmCorePerfLib: [CVE-2017-5753] Fix bounds check bypass

2018-11-20 Thread Wu, Hao A
Got it. Since the patches have already been checked in. I will follow this style next time. Best Regards, Hao Wu > -Original Message- > From: Gao, Liming > Sent: Wednesday, November 21, 2018 2:16 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Laszlo Ersek; Yao, Jiewen;

Re: [edk2] [PATCH v2 1/2] MdeModulePkg/SmmCorePerfLib: [CVE-2017-5753] Fix bounds check bypass

2018-11-20 Thread Gao, Liming
Hao: In previous discussion, the suggested subject style is MdeModulePkg/SmmCorePerfLib: Fix bounds check bypass(CVE-2017-5753). Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu > Sent: Friday, November 16, 2018 12:13

Re: [edk2] [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

2018-11-20 Thread Lokesh Belathur Veerappa
Hi Supreeth, Yes it has been compiled and tested against edk2 with SHA da2c81ee96eba5d5c8ef91fd870ac98d3cf72beb. -Original Message- From: Supreeth Venkatesh Sent: Tuesday, November 20, 2018 8:34 PM To: Lokesh Belathur Veerappa ; edk2-devel@lists.01.org; eric@intel.com Cc: Lokesh

[edk2] [PATCH 4/6] EmulatorPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-20 Thread Fu Siyuan
This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have been updated to use the NetworkPkg's terms, and the value has been overridden with the original default value on this platform. Cc: Jordan

[edk2] [PATCH 6/6] Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-20 Thread Fu Siyuan
This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have been updated to use the NetworkPkg's terms, and the value has been overridden with the original default value on this platform. Cc: David

[edk2] [PATCH 2/6] Nt32Pkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-20 Thread Fu Siyuan
This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have be updated to use the NetworkPkg's terms, and the value have been overridden with the original default value on this platform. Cc: Ruiyu Ni

[edk2] [PATCH 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-20 Thread Fu Siyuan
This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have been updated to use the NetworkPkg's terms, and the value has been overridden with the original default value on this platform. Cc: Laszlo

[edk2] [PATCH 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-20 Thread Fu Siyuan
This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. The feature enabling flags in [Defines] section have been updated to use the NetworkPkg's terms, and the value has been overridden with the original default value on this platform. Cc: Jordan

[edk2] [PATCH 0/6] Add DSC/FDF include segment files for network stack

2018-11-20 Thread Fu Siyuan
There is a patch to remove the redudant IP4 only iSCSI/PXE/TCP drivers from MdeModulePkg, which has been reviewed before edk2-stable201811 tag. And we also have plan to move all network related libraries/modules to NetworkPkg. In order to make these change more smoothly, 2 configuration fragment

[edk2] [PATCH 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

2018-11-20 Thread Fu Siyuan
The "Network.dsc.inc" and "Network.fdf.inc" are added for platform owner to easily enable/disable network stack support on their platform, by adding !include NetworkPkg/Network.dsc.inc and !include NetworkPkg/Network.fdf.inc to their platform DSC/FDF files. A set of flags can be changed

[edk2] [Patch] BaseTools Script: Update ConvertFceToStructurePcd to report warning messages

2018-11-20 Thread Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1297 When the header files are not found for the used C structure, this script will report the warning, let user know there is no header file to define C structure. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang BinX

[edk2] [edk2-test][Patch] uefi-sct/SctPkg:Remove old unused files in EfiCompliant test

2018-11-20 Thread Eric Jin
Cc: Supreeth Venkatesh Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../BlackBoxTest/EfiCompliantBBTestDriver_efi.c| 64 - .../BlackBoxTest/EfiCompliantBBTestMain_efi.c | 126 -- .../BlackBoxTest/EfiCompliantBBTestMain_efi.h | 117 --

Re: [edk2] [PATCH v2] SecurityPkg: Update TCG PFP spec revision.

2018-11-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zhang, Chao B > Sent: Tuesday, November 20, 2018 10:54 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [PATCH v2] SecurityPkg: Update TCG PFP spec revision. > > UEFI TCG has aligned with TCG PFP 1.03 v51 along

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-20 Thread Zeng, Star
On 2018/11/20 22:37, Gao, Liming wrote: Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, November 20, 2018 4:52 PM To: Gary Lin ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-20 Thread Zeng, Star
On 2018/11/20 19:17, Laszlo Ersek wrote: On 11/20/18 11:38, Vijayenthiran Subramaniam wrote: Print debug messages if size of the VariableName plus DataSize exceeds Max(Auth|Voltaile)VariableSize bytes. The messages will be useful if any platform specific value of Max(Auth|Voltaile)VariableSize

Re: [edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-20 Thread yuchenlin via edk2-devel
On 2018-11-21 03:59, Laszlo Ersek wrote: On 11/07/18 18:06, Laszlo Ersek wrote: On 11/07/18 04:47, yuchen...@synology.com wrote: From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2|

Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-20 Thread Marcin Wojtas
Hi Leif, śr., 14 lis 2018 o 18:33 Leif Lindholm napisał(a): > > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > > I think all of my comments on this patch can be summarised as "what is > > > an AP in this context"? > > > > > > The term either needs explicit documenting, or

Re: [edk2] [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

2018-11-20 Thread Zeng, Star
On 2018/11/20 21:15, Leif Lindholm wrote: On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg package. This driver requires the

Re: [edk2] [RFC] Proposal to remove DuetPkg

2018-11-20 Thread Andrew Fish
Works for me too. Thanks, Andrew Fish > On Nov 20, 2018, at 3:20 PM, Kinney, Michael D > wrote: > > I agree with this proposal. > > I also agree with Leif that large patch series > must be shared on a branch for review. > > Mike > >> -Original Message- >> From: edk2-devel

Re: [edk2] [edk2-announce] Research Request

2018-11-20 Thread stephano
Thank you both for taking the time to add some insight to our discussions. Please see the list of questions here: https://lists.01.org/pipermail/edk2-devel/2018-November/032462.html These are a summary from our community meetings. Enjoy the holiday! Cheers, Stephano On 11/20/2018 3:47 PM,

Re: [edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

2018-11-20 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Vijayenthiran Subramaniam [mailto:vijayenthiran.subraman...@arm.com] > Sent: Tuesday, November 20, 2018 6:40 PM > To: edk2-devel@lists.01.org; Fu, Siyuan ; Wu, Jiaxin > > Cc: Vijayenthiran Subramaniam > Subject: [PATCH]

Re: [edk2] [edk2-announce] Research Request

2018-11-20 Thread Jeremiah Cox via edk2-devel
Hi Stephano, Sean and I will put something together for GitHub by next Tuesday. Thank you, Jeremiah Cox (departing for Thanksgiving holiday... now...) -Original Message- From: edk2-devel On Behalf Of stephano Sent: Wednesday, November 14, 2018 10:34 AM To: edk2-devel@lists.01.org

Re: [edk2] [RFC] Proposal to remove DuetPkg

2018-11-20 Thread Kinney, Michael D
Ray, One additional note. There are some tools in BaseTools that are only used by Duet. We should remove those tools too. Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, November 20, 2018 3:21 PM > To: Leif Lindholm ; Ni, Ruiyu > ; Kinney, Michael D > > Cc:

Re: [edk2] [RFC] Proposal to remove DuetPkg

2018-11-20 Thread Kinney, Michael D
I agree with this proposal. I also agree with Leif that large patch series must be shared on a branch for review. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On Behalf Of Leif Lindholm > Sent: Tuesday, November 20, 2018 1:57 AM > To: Ni, Ruiyu

Re: [edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-20 Thread Laszlo Ersek
On 11/07/18 18:06, Laszlo Ersek wrote: > On 11/07/18 04:47, yuchen...@synology.com wrote: >> From: yuchenlin >> >> BAR |std vga | vmsvga >> - >> 0| Framebuffer | I/O space >> 1| Reserved | Framebuffer >> 2| MMIO | FIFO >> >>

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 11:00:49PM +0800, Ming Huang wrote: > On 11/20/2018 10:39 PM, Leif Lindholm wrote: > > On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote: > > And all Hisilicon platforms still use > >

Re: [edk2] [PATCH v2] ArmPkg/ArmSmcPsciResetSystemLib: add missing call to ExitBootServices()

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 04:44:33PM +0100, Ard Biesheuvel wrote: > Our poor man's implementation of EnterS3WithImmediateWake () currently > sets a high TPL level to disable interrupts, and simply calls the > PEI entrypoint again after disabling the MMU. > > Unfortunately, this is not sufficient:

[edk2] [PATCH v2] ArmPkg/ArmSmcPsciResetSystemLib: add missing call to ExitBootServices()

2018-11-20 Thread Ard Biesheuvel
Our poor man's implementation of EnterS3WithImmediateWake () currently sets a high TPL level to disable interrupts, and simply calls the PEI entrypoint again after disabling the MMU. Unfortunately, this is not sufficient: DMA capable devices such as network controllers or USB controllers may

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Laszlo Ersek
On 11/20/18 16:00, Ming Huang wrote: > > > On 11/20/2018 10:39 PM, Leif Lindholm wrote: >> On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote: >> And all Hisilicon platforms still use >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Laszlo Ersek
On 11/20/18 15:40, Ard Biesheuvel wrote: > On Tue, 20 Nov 2018 at 15:30, Ming Huang wrote: >> >> >> >> On 11/20/2018 8:58 PM, Leif Lindholm wrote: >>> On Tue, Nov 20, 2018 at 08:40:28PM +0800, Ming Huang wrote: On 11/20/2018 8:13 PM, Leif Lindholm wrote: > On Tue, Nov 20, 2018

Re: [edk2] [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

2018-11-20 Thread Supreeth Venkatesh
Thanks Lokesh for the patch. Has this been compiled and sanity tested against latest edk2? Let me know SHA of edk2 tested, so that I can test it against that SHA and push it. If so, Reviewed-by: Supreeth Venkatesh -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Ming Huang
On 11/20/2018 10:39 PM, Leif Lindholm wrote: > On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote: > And all Hisilicon platforms still use > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > regardless of Secure Boot setting. > > So

Re: [edk2] [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 07:32:35PM +0530, Thomas Abraham wrote: > On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm > wrote: > > > > On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: > > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > > >

Re: [edk2] [PATCH] ArmPkg/ArmSmcPsciResetSystemLib: add missing call to ExitBootServices()

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 03:33:00PM +0100, Ard Biesheuvel wrote: > Our poor man's implementation of EnterS3WithImmediateWake () currently > sets a high TPL level to disable interrupts, and simply calls the > PEI entrypoint again after disabling the MMU. > > Unfortunately, this is not sufficient:

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Ard Biesheuvel
On Tue, 20 Nov 2018 at 15:30, Ming Huang wrote: > > > > On 11/20/2018 8:58 PM, Leif Lindholm wrote: > > On Tue, Nov 20, 2018 at 08:40:28PM +0800, Ming Huang wrote: > >> > >> > >> On 11/20/2018 8:13 PM, Leif Lindholm wrote: > >>> On Tue, Nov 20, 2018 at 05:01:46PM +0800, Ming Huang wrote: >

[edk2] [PATCH] ArmPkg/ArmSmcPsciResetSystemLib: add missing call to ExitBootServices()

2018-11-20 Thread Ard Biesheuvel
Our poor man's implementation of EnterS3WithImmediateWake () currently sets a high TPL level to disable interrupts, and simply calls the PEI entrypoint again after disabling the MMU. Unfortunately, this is not sufficient: DMA capable devices such as network controllers or USB controllers may

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote: > >>> And all Hisilicon platforms still use > >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > >>> regardless of Secure Boot setting. > >>> > >>> So what problem does this patch solve? A runtime one?

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Thomas Abraham
On Tue, Nov 20, 2018 at 7:48 PM Leif Lindholm wrote: > > On Tue, Nov 20, 2018 at 07:31:34PM +0530, Thomas Abraham wrote: > > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > > wrote: > > > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm > > > wrote: > > > > > > > > Hmm, a follow-up question

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 20, 2018 4:52 PM > To: Gary Lin ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2] [PATCH

Re: [edk2] [PATCH] ArmPkg/ArmSmcPsciResetSystemLib: add missing call to ExitBootServices()

2018-11-20 Thread Ard Biesheuvel
On Tue, 20 Nov 2018 at 15:33, Ard Biesheuvel wrote: > > Our poor man's implementation of EnterS3WithImmediateWake () currently > sets a high TPL level to disable interrupts, and simply calls the > PEI entrypoint again after disabling the MMU. > > Unfortunately, this is not sufficient: DMA capable

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Ming Huang
On 11/20/2018 8:58 PM, Leif Lindholm wrote: > On Tue, Nov 20, 2018 at 08:40:28PM +0800, Ming Huang wrote: >> >> >> On 11/20/2018 8:13 PM, Leif Lindholm wrote: >>> On Tue, Nov 20, 2018 at 05:01:46PM +0800, Ming Huang wrote: Now that the generic Variable Runtime DXE code no longer

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 07:31:34PM +0530, Thomas Abraham wrote: > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > wrote: > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm > > wrote: > > > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > > > We still keep the manually

Re: [edk2] [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

2018-11-20 Thread Thomas Abraham
On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm wrote: > > On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > > package.

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Ard Biesheuvel
On Tue, 20 Nov 2018 at 15:01, Thomas Abraham wrote: > > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > wrote: > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm > > wrote: > > > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > > > We still keep the manually generated

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Thomas Abraham
On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel wrote: > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm wrote: > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > We still keep the manually generated GUIDs in > > ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, > >

Re: [edk2] [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > package. This driver requires the platform to support a maximum variable

Re: [edk2] [PATCH edk2-platforms v3 0/5] Fix D06 SBSA/SBBR issue and improve

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 05:01:45PM +0800, Ming Huang wrote: > Main Change since v2: > 1. Use new way to fix secure boot bug in FlashFvbDxe; > 2. Spilit patch from "Modify Gic base"; > 3. Modify some commit messages; > > Code can also be found in github: >

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 08:40:28PM +0800, Ming Huang wrote: > > > On 11/20/2018 8:13 PM, Leif Lindholm wrote: > > On Tue, Nov 20, 2018 at 05:01:46PM +0800, Ming Huang wrote: > >> Now that the generic Variable Runtime DXE code no longer > >> distinguishes between gEfiVariableGuid and > >>

Re: [edk2] [PATCH edk2-platforms v2 00/15] Fix D06 SBSA/SBBR issue and improve

2018-11-20 Thread Ming Huang
On 11/20/2018 6:32 PM, Leif Lindholm wrote: > On Tue, Nov 20, 2018 at 03:02:44PM +0800, Ming Huang wrote: >>> Please rebase on new master and address comments for v3. >>> If you can merge >>> Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot >>> and >>> Hisilicon/D06: Modify Gic base >>> as

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Ming Huang
On 11/20/2018 8:13 PM, Leif Lindholm wrote: > On Tue, Nov 20, 2018 at 05:01:46PM +0800, Ming Huang wrote: >> Now that the generic Variable Runtime DXE code no longer >> distinguishes between gEfiVariableGuid and >> gEfiAuthenticatedVariableGuid in the varstore FV header. >> We can relax the

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 05:01:46PM +0800, Ming Huang wrote: > Now that the generic Variable Runtime DXE code no longer > distinguishes between gEfiVariableGuid and > gEfiAuthenticatedVariableGuid in the varstore FV header. > We can relax the check in the flashFvb driver to accept > either GUID

Re: [edk2] [PATCH edk2-non-osi v2 0/4] Upload D06 binary modules for SBSA test

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 09:34:51AM +0800, Ming Huang wrote: > > > On 11/20/2018 2:46 AM, Leif Lindholm wrote: > > On Fri, Nov 16, 2018 at 04:13:02PM +0800, Ming Huang wrote: > >> Main Change since v1: > >> 1 Modify comments; > >> > >> Code can also be found in github: > >>

Re: [edk2] [PATCH] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-20 Thread Laszlo Ersek
On 11/20/18 11:38, Vijayenthiran Subramaniam wrote: > Print debug messages if size of the VariableName plus DataSize exceeds > Max(Auth|Voltaile)VariableSize bytes. The messages will be useful if any > platform specific value of Max(Auth|Voltaile)VariableSize PCDs have to > be changed. > > Cc:

Re: [edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

2018-11-20 Thread Laszlo Ersek
On 11/20/18 11:39, Vijayenthiran Subramaniam wrote: > Add debug messages for failed attempts to write to a variable. > > Cc: Siyuan Fu > Cc: Jiaxin Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam > --- > NetworkPkg/IScsiDxe/IScsiMisc.c |

Re: [edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

2018-11-20 Thread Udit Kumar
> -Original Message- > From: edk2-devel On Behalf Of > Vijayenthiran Subramaniam > Sent: Tuesday, November 20, 2018 4:10 PM > To: edk2-devel@lists.01.org; siyuan...@intel.com; jiaxin...@intel.com > Cc: Vijayenthiran Subramaniam > Subject: [edk2] [PATCH] NetworkPkg/IScsiDxe: add debug

Re: [edk2] [PATCH edk2-platforms v2 10/15] Hisilicon/D06: Modify Gic base

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 02:55:11PM +0800, Ming Huang wrote: > > But if I understand correctly, the remainder of the patch will be > > incorrect until the other changes to book from TA have been applied > > (in the subsequent patch). > > So please move the MADT change to the other patch. > > D06

[edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

2018-11-20 Thread Vijayenthiran Subramaniam
Add debug messages for failed attempts to write to a variable. Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- NetworkPkg/IScsiDxe/IScsiMisc.c | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [PATCH] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

2018-11-20 Thread Vijayenthiran Subramaniam
Print debug messages if size of the VariableName plus DataSize exceeds Max(Auth|Voltaile)VariableSize bytes. The messages will be useful if any platform specific value of Max(Auth|Voltaile)VariableSize PCDs have to be changed. Cc: Star Zeng Cc: Jian J Wang Cc: Ruiyu Ni Contributed-under:

Re: [edk2] [PATCH edk2-platforms v2 06/15] Hisilicon/D06: Move some functions to OemMiscLib

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 02:38:32PM +0800, Ming Huang wrote: > > My feedback was: > > --- > > This would be more clear as "platform specific" than "cpld relative". > > > > I did not realise this wasn't a Hisilicon component when reviewing the > > original set. > > > > I approve of this change,

Re: [edk2] [PATCH edk2-platforms v2 00/15] Fix D06 SBSA/SBBR issue and improve

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 03:02:44PM +0800, Ming Huang wrote: > > Please rebase on new master and address comments for v3. > > If you can merge > > Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot > > and > > Hisilicon/D06: Modify Gic base > > as requested and get those sent out before I start

[edk2] [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

2018-11-20 Thread Vijayenthiran Subramaniam
Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg package. This driver requires the platform to support a maximum variable size of atleast 4KB. So increase the maximum supported variable size to 8KB on

Re: [edk2] [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework

2018-11-20 Thread Marcin Wojtas
Thanks! Best regards, Marcin wt., 20 lis 2018 o 10:58 Ard Biesheuvel napisał(a): > > On Mon, 19 Nov 2018 at 07:54, Marcin Wojtas wrote: > > > > Hi, > > > > The sixth version of the patchset applies minor correction in the > > last patch and also simplifies the BoardDesc library callbacks. > >

Re: [edk2] [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework

2018-11-20 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 07:54, Marcin Wojtas wrote: > > Hi, > > The sixth version of the patchset applies minor correction in the > last patch and also simplifies the BoardDesc library callbacks. > There is no unnecessary allocation now. > > Patches are available in the github: >

Re: [edk2] [RFC] Proposal to remove DuetPkg

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 05:27:13AM +, Ni, Ruiyu wrote: > All, > DuetPkg depends on Legacy BIOS to provide a UEFI environment. It was > invented in the era when UEFI environment is hard to find. Since now > UEFI is very popular in PC area, we could stop the official support > of this package

[edk2] [PATCH edk2-platforms v3 5/5] Hisilicon/D06: Move some functions to OemMiscLib

2018-11-20 Thread Ming Huang
As M41T83RealTimeClockLib is common library, so move two platform specific functions to OemMiscLib and rename this two functions. Main gist of this patch is making this library as a common module in Hisilicon. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-platforms v3 4/5] Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot

2018-11-20 Thread Ming Huang
Linux kernel will recognize NUMA node by processor order, and the Node and proximity domain (PXM) will be not identical between BIOS and OS kernel after changing to TA(Totem A) boot, so adjust the NUMA node number and proximity domain (PXM) to match. Contributed-under: TianoCore Contribution

[edk2] [PATCH edk2-platforms v3 0/5] Fix D06 SBSA/SBBR issue and improve

2018-11-20 Thread Ming Huang
Main Change since v2: 1. Use new way to fix secure boot bug in FlashFvbDxe; 2. Spilit patch from "Modify Gic base"; 3. Modify some commit messages; Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: d06-acs-platforms-v3 Ming Huang (5): Hisilicon/D0x:

[edk2] [PATCH edk2-platforms v3 2/5] Hisilicon/D06: Modify Gic base

2018-11-20 Thread Ming Huang
The values of GICD are wrong, so modify it. Fix SBSA test case 21: 21 : Check GIC version GIC version is 0 Failed on PE -0 for Level= 3 : Result: --FAIL-- 2 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-20 Thread Ming Huang
Now that the generic Variable Runtime DXE code no longer distinguishes between gEfiVariableGuid and gEfiAuthenticatedVariableGuid in the varstore FV header. We can relax the check in the flashFvb driver to accept either GUID regardless of whether we are running a secure boot capable build or not.

[edk2] [PATCH edk2-platforms v3 3/5] Hisilicon/D06: Correct PcdGicInterruptInterfaceBase

2018-11-20 Thread Ming Huang
The PcdGicInterruptInterfaceBase(0xFE00) is wrong, it just copy from D05/D03. Maybe somewhere will need the right value of Pcd. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-20 Thread Laszlo Ersek
On 11/19/18 23:29, Jordan Justen wrote: > On 2018-11-19 13:22:27, Andrew Fish wrote: >> I seem to remember we hit an issue like this a long time ago? Do you >> remember the details? Maybe it was we needed to write the >> TempRamSupport code in assembly? > > It does also creep up there, which is

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-20 Thread Laszlo Ersek
On 11/20/18 08:03, Gary Lin wrote: > The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing > square bracket mistakenly. > > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gary Lin > --- >

Re: [edk2] [RFC] Proposal to remove DuetPkg

2018-11-20 Thread Laszlo Ersek
On 11/20/18 06:27, Ni, Ruiyu wrote: > All, > DuetPkg depends on Legacy BIOS to provide a UEFI environment. It was invented > in the era when UEFI environment is hard to find. Since now UEFI is very > popular in PC area, we could stop the official support of this package and > remove it from the

Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-20 Thread Jin, Eric
Please don't forget to change the copyright info when commit patch. Reviewed-by: Eric Jin -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 2:50 PM To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric Cc: Lokesh B V Subject: [edk2-test][PATCH]

Re: [edk2] [edk2-test][PATCH] SctPkg/UEFI: Fix invalid GUID value format error

2018-11-20 Thread Jin, Eric
Please don't forget to change the copyright info when commit patch. Reviewed-by: Eric Jin -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 2:50 PM To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric Cc: Lokesh B V Subject: [edk2-test][PATCH]

Re: [edk2] [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table

2018-11-20 Thread Mark Kettenis
> From: Ard Biesheuvel > Date: Mon, 19 Nov 2018 08:03:38 -0800 > > PL011 is not a valid ACPI identifier so don't expose it as a _CID. > Since _CID (Comptable ID) is optional, let's just drop it. Heh, I Noticed that one when adding ACPI support for OpenBSD/arm64. Reviewed-by: Mark Kettenis >

Re: [edk2] [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

2018-11-20 Thread Jin, Eric
Please don't forget to change the copyright info when commit patch. Reviewed-by: Eric Jin -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 2:50 PM To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric Cc: Lokesh B V Subject: [edk2-test][PATCH]