MdePkg/MdeModulePkg maintainers - any comments?
On Tue, Jan 08, 2019 at 01:28:00AM +0100, Laszlo Ersek wrote:
> On 01/07/19 20:22, Leif Lindholm wrote:
> > On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote:
>
> >> The UEFI spec (v2.7) explicitly requires EFI_GUID to be 64-bit aligned,
On Tue, 8 Jan 2019 at 10:51, Leif Lindholm wrote:
>
> MdePkg/MdeModulePkg maintainers - any comments?
>
> On Tue, Jan 08, 2019 at 01:28:00AM +0100, Laszlo Ersek wrote:
> > On 01/07/19 20:22, Leif Lindholm wrote:
> > > On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote:
> >
> > >> The UEF
On Tue, 8 Jan 2019 at 02:54, Laszlo Ersek wrote:
>
> On 01/07/19 19:08, Laszlo Ersek wrote:
> > On 01/07/19 13:15, Gao, Liming wrote:
> >> Laszlo:
> >> This patch set is good to me. Reviewed-by: Liming Gao
> >>
> >
> > Many thanks to everyone for the quick reviews!
> >
> >> Besides this patc
On 01/08/19 10:51, Leif Lindholm wrote:
> MdePkg/MdeModulePkg maintainers - any comments?
>
> On Tue, Jan 08, 2019 at 01:28:00AM +0100, Laszlo Ersek wrote:
>> On 01/07/19 20:22, Leif Lindholm wrote:
>>> On Mon, Jan 07, 2019 at 07:29:47PM +0100, Laszlo Ersek wrote:
>>
The UEFI spec (v2.7) expl
On Tue, 8 Jan 2019 at 02:11, Laszlo Ersek wrote:
>
> On 01/07/19 20:37, Ard Biesheuvel wrote:
> > On Mon, 7 Jan 2019 at 20:21, Achin Gupta wrote:
>
> >> Could you please explain the need for End of DXE signalling and
> >> the traditional SMM IPL. It is not obvious to me :o(
> >>
> >
> > The point
Laszlo:
Yes. This can be supported. But, I don't know what purpose to specify python
minor version of Python3. Current implementation in Python3 branch always tries
to find the high version installed in OS. For example, Python3.4, Python3.7 are
both installed, Python3.7 will be chosen. Does th
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, January 08, 2019 5:51 PM
> To: Laszlo Ersek
> Cc: Ni, Ray ; tr...@konsulko.com; AKASHI Takahiro
> ; Wu, Hao A ; Heinrich
> Schuchardt ; edk2-devel@lists.01.org; Al
EFI_GUID structure definition follows RFC UUID
https://www.ietf.org/rfc/rfc4122.txt. This RFC has no 64 bit boundary
requirement. I don't know the background why UEFI spec requires to align on
64-bit boundary. This may be true for early IPF arch. UEFI forum can clarify
its purpose. If no specif
On 01/03/19 19:28, Ard Biesheuvel wrote:
> In preparation of providing a standalone MM based variable runtime
> driver, move the existing SMM driver to the new MM services table,
> and factor out some pieces that are specific to the traditional
> driver, mainly related to the use of UEFI boot servi
Thanks Liming, this exactly the reply I was hoping for.
On Tue, Jan 08, 2019 at 03:12:11PM +, Gao, Liming wrote:
> EFI_GUID structure definition follows RFC UUID
> https://www.ietf.org/rfc/rfc4122.txt. This RFC has no 64 bit
> boundary requirement. I don't know the background why UEFI spec
> r
Liming and Laszlo,
What if we add a 4th option to the environment variable - the path to a
specific python interpreter for use.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Tuesday, January 08, 2019 6:
Hi Liming,
On 01/04/19 04:29, Gao, Liming wrote:
> Laszlo:
> This issue has been fixed in edk2 master. I just cherry pick those
> fixes from edk2 master to my Python3 branch
> (https://github.com/lgao4/edk2/tree/Python3).
At commit 90d8b4834fd1 ("BaseTools: Reset FdsGlobalVariable",
2019-01
Ashish,
Good point. I was looking at the code size of a single
uncompressed UEFI Driver (DiskIoDxe). I suspect that the
patch provides a more consistent pattern across all drivers
that use these UefiLib APIs, and then provides better
compression on an FV that contains many UEFI Drivers.
I also
On 01/08/19 14:27, Ard Biesheuvel wrote:
> On Tue, 8 Jan 2019 at 02:11, Laszlo Ersek wrote:
>>
>> On 01/07/19 20:37, Ard Biesheuvel wrote:
>>> On Mon, 7 Jan 2019 at 20:21, Achin Gupta wrote:
>>
Could you please explain the need for End of DXE signalling and
the traditional SMM IPL. It i
On 01/08/19 16:12, Gao, Liming wrote:
> Last, EFI_HII_KEYBOARD_PACKAGE_HDR structure definition doesn't follow UEFI
> spec. I remember we ever meet with the compiler issue for below style. GCC49
> may complaint it. I need to double confirm.
> typedef struct {
> EFI_HII_PACKAGE_HEADER Header;
On 01/08/19 15:22, Gao, Liming wrote:
> Laszlo:
> Yes. This can be supported. But, I don't know what purpose to
> specify python minor version of Python3. Current implementation in
> Python3 branch always tries to find the high version installed in
> OS. For example, Python3.4, Python3.7 ar
Thanks Mike. Please let me know if you have any more questions and/or comments.
Thanks
Ashish
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, January 8, 2019 9:26 AM
To: Ashish Singhal ; edk2-devel@lists.01.org; Gao,
Liming ; Fu, Siyuan ; Wu, Jiaxin
; Kinney, Michael D
Subj
On 01/08/19 17:22, Carsey, Jaben wrote:
> Liming and Laszlo,
> What if we add a 4th option to the environment variable - the path to a
> specific python interpreter for use.
I thought of that, but how do the build tools derive the python version
just from the pathname of the interpreter?
W
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, January 08, 2019 9:26 AM
> To: Carsey, Jaben ; Gao, Liming
> ; Ni, Ray ; edk2-
> de...@lists.01.org; leif.lindh...@linaro.org; af...@apple.com; Kinney,
> Michael D
> Subject: Re: [edk2] [RFC] Edk2 Base
Hi Ard,
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, December 17, 2018 3:14 AM
> To: Chris Co
> Cc: edk2-devel@lists.01.org; Leif Lindholm ; Michael
> D Kinney
> Subject: Re: [PATCH edk2-platforms 19/27] Silicon/NXP: Add i.MX6 ACPI tables
>
> On Fri, 21 Sep 2018 at 10:26
The comments are incorrect for the base version of this lib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
Cc: Star Zeng
Cc: Jian J Wang
---
MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22
1 file changed, 9 insertions(+), 13 delet
1 - Some of these imports are cascaded from another file. Import them locally.
2 - Some of these imports are not used. Remove them.
3 - Some of these were missing the namespace used to import them.
These changes facilitate optimization of BaseTools:
https://bugzilla.tianocore.org/show_bug.cgi?id=4
Jaben:
I also think this way. Now, we have two envs PYTHON3_ENABLE and
PYTHON_COMMAND. The behavior can be combined as the below to support this
usage. If user wants the specific python interpreter, he only needs to set
PYTHON_COMMAND env.
If PYTHON3_ENABLE is set, PYTHON_COMMAND will be set
Reviewed-by: Jian J Wang
> -Original Message-
> From: Carsey, Jaben
> Sent: Wednesday, January 09, 2019 5:58 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Wang, Jian J
> Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
>
> The comments are incorrect for the base v
How about updating "2018" to "2019"? :)
With that, Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Carsey, Jaben
Sent: Wednesday, January 9, 2019 5:58 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Wang, Jian J
Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseS
Ashish,
When I do full platform builds and individual driver
builds, the result is always a little bigger with the
V3 version of the patch.
DEBUG DEBUG+Patch Delta RELEASE
RELEASE+Patch Delta
* *** * ***
Hi Mike,
Thanks for the analysis. I will investigate at my end what could be causing
this. Meanwhile, to fix the issue do you want to submit PATCH v2 1/4 and 2/4
patches? These 2 patches are just what you suggested.
Thanks
Ashish
-Original Message-
From: Kinney, Michael D
Sent: Tuesd
Hi all,
We got some feedback about this BZ. Someone think this timeout is valuable for
the debug purpose, and oppose to remove it.
https://bugzilla.tianocore.org/show_bug.cgi?id=1419
So I'm back to here and want to still use this change. I not use "update
PcdSpinLockTimeout to 0 in platform" s
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1104
Based on the requestion the above BZ, this patch serial removes
the BaseTools C and Python code for EDKI, IPF support.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off
From: "Feng, Bob C"
Remove IPF support from BaseTools C code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Jaben Carsey
---
BaseTools/Source/Python/Common/DataType.py| 19 +-
.../Source/Python/CommonDataClass/FdfClass.py | 20 --
Ba
From: "Feng, Bob C"
Remove EDK module and IA64 support from BaseTools C code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Jaben Carsey
---
BaseTools/Source/C/Common/BasePeCoff.c| 14 +-
BaseTools/Source/C/Common/PeCoffLoaderEx.c
From: "Feng, Bob C"
Remove EDK module type support from BaseTools C code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py| 93 ++---
BaseTools/Source/Python/AutoGen/GenC.py
Hi ALL,
I've an idea regards "Adding conditional compilation support in INF files"
Ides is like, we can condition check in INF file like below
#if Condition1
Protocol1
#elif Condition2
Protocol2
#else
Protocol3
#endif
If we've this support we can add different protocols
This patch removes the logic from BaseTools python code, not C code. And,
please also include BZ link in the commit message.
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 9, 2019 2:44 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming ;
Could you separate this change to two patches for IPF and EBC?
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 9, 2019 2:45 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming ;
> Carsey, Jaben
> Subject: [Patch 3/3] BaseTools: Remove unused logic from C
Sorry for the typo. I'll resent the patch.
-Original Message-
From: Gao, Liming
Sent: Wednesday, January 9, 2019 3:01 PM
To: Feng, Bob C ; edk2-devel@lists.01.org
Cc: Carsey, Jaben
Subject: RE: [Patch 1/3] BaseTools: Remove unused logic for EDKI
This patch removes the logic from BaseToo
From: "Feng, Bob C"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350
Remove EDK module type support from BaseTools python code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.p
Reviewed-by: Eric Jin
-Original Message-
From: Supreeth Venkatesh
Sent: Thursday, December 13, 2018 5:44 AM
To: edk2-devel@lists.01.org
Cc: Jin, Eric ; Supreeth Venkatesh
Subject: [edk2][edk2-test][PATCH v1 1/1] uefi-sct: Change line endings to CR LF.
No functionality change.
Change
38 matches
Mail list logo
