[Freeciv-Dev] Kampuchean.ruleset

2007-01-10 Thread Marko Lindqvist
Is there some reason why empty kampuchean.ruleset still exist in svn? Real ruleset is cambodian.ruleset. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#19132) [Bug] Startunits in non-native terrains

2007-01-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19132 This version of the patch modifies also mapgenerator. Only tiles native to initial unit are considered as starting positions. - ML diff -Nurd -X.diff_ignore freeciv/server/gamehand.c freeciv/server/gamehand.c ---

[Freeciv-Dev] (PR#15416) All defenders too expensive in process_defender_want()

2007-01-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=15416 Untested patch for S2_1 and TRUNK. Usually we choose best defender from those costing less than limit_cost. If all units cost more than limit_cost, cheapest is selected. - ML diff -Nurd -X.diff_ignore freeciv/ai/advmilitary.c

Re: [Freeciv-Dev] Re: (PR#19822) bug in path_finding.c

2007-01-11 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19822 On 8/23/06, Jason Dorje Short [EMAIL PROTECTED] wrote: On a related note, can we remove dangerous tiles? Already glacier is no longer dangerous (it can be made impassable/non-native to make it more realistic). For triremes we

Re: [Freeciv-Dev] Re: (PR#18773) Reordering worklist smeshes it up if there is just bought unit

2007-01-11 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18773 On 7/21/06, Jason Short [EMAIL PROTECTED] wrote: Alternately the client just needs to make all the same checks the server does, BEFORE sending the packets. That's what Tommi's patch does. I'm going to commit it soon if nobody

[Freeciv-Dev] (PR#33324) [Patch] Hardcoded City Walls cost in AI code

2007-01-11 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33324 This patch replaces hardcoded city walls cost with call to impr_buy_gold_cost(). Note that hardcoded value were no longer true even for default ruleset. - ML diff -Nurd -X.diff_ignore freeciv/ai/advmilitary.c

[Freeciv-Dev] (PR#33343) S2_1 singaporean.ruleset broken

2007-01-11 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33343 0: Nation Singaporean: the leader sex count (5) is not equal to the number of leaders (4) - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#21407) Possible bug in Freeciv (crash on next turn)

2007-01-12 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=21407 Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x0810c16a in military_advisor_choose_build (pplayer=0x828b480, pcity=0x89809e0, choice=0x8981318) at ../../src.patched/ai/advmilitary.c:740 740 if (!walls

[Freeciv-Dev] (PR#11068) savegame file compression

2007-01-12 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=11068 Patch updated against svn. Second patch is for disabling bzip2 saves in pubserver. which cannot handle them. - ML diff -Nurd -X.diff_ignore freeciv/client/connectdlg_common.c freeciv/client/connectdlg_common.c ---

Re: [Freeciv-Dev] (PR#21843) Freeciv 2.1.0 Beta2 bug.

2007-01-12 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=21843 On 1/13/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have an alliance, but no shared vision. Alliance allows us to see units inside transport. When transport moves out of sight, transported units are not removed. Patch - ML

[Freeciv-Dev] (PR#33479) [Patch] Change default port to 5556

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33479 $subject Note that ~/.civclientrc might contain default_server_port which client proposes for connecting to. - ML diff -Nurd -X.diff_ignore freeciv/client/clinet.h freeciv/client/clinet.h --- freeciv/client/clinet.h 2006-07-17

Re: [Freeciv-Dev] (PR#18476) [Patch] generate_warmap() and TerrainSpeed

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18476 On 7/11/06, Marko Lindqvist [EMAIL PROTECTED] wrote: Make really_generate_warmap() UCF_TERRAIN_SPEED aware. I had to rewrite most of it. Patch updated. Take advantage of some new interfaces: - Use can_attack_non_native() instead

Re: [Freeciv-Dev] Re: (PR#19822) bug in path_finding.c

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19822 1. First node always gets segment_length = 1. 2. No other node can get segment_length 1. 3. Segment_length can be too big, but not too small. This mostly untested patch modifies create_danger_segment() so that it uses segment_length

[Freeciv-Dev] (PR#14636) tech update bug

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=14636 Christian Knoke [EMAIL PROTECTED]: When an allied has stolen a tech form an enemy, the diplomacy dialog and intelligence is not updated. Same applies when Caravan gets initial science bonus from establishing trade route. Patch is

[Freeciv-Dev] (PR#16350) Beta1: Tutorial translation not possible

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=16350 This leads to the fact that the complete tutorial is not translatable. I believe this is because the translatable strings are marked as _('...') instead of _(...) I tried changing this which made gettext recognize the strings, but

Re: [Freeciv-Dev] (PR#16350) Beta1: Tutorial translation not possible

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=16350 S2_1 version of the tutorial patch. - ML diff -Nurd -X.diff_ignore freeciv/data/scenario/tutorial.sav freeciv/data/scenario/tutorial.sav --- freeciv/data/scenario/tutorial.sav 2006-07-17 14:28:11.0 +0300 +++

[Freeciv-Dev] (PR#33498) [Bug] Edit mode with two clients freezes

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33498 Separately started server and two clients. Trying to select Editor - Edit mode from either client causes both of them to freeze. Chat window for both says 'Server set to edit mode' - 'Server leaves edit mode' over and over again.

Re: [Freeciv-Dev] (PR#9568) Bribing bombers

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=9568 On 1/13/07, Marko Lindqvist [EMAIL PROTECTED] wrote: Untested patch for carrying fuel and some other info over bribing. Moves_left should be already ok. Bomber probably attacked in the beginning of the next turn and not in the same

[Freeciv-Dev] (PR#33510) [Patch] Help for first time user

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33510 I noticed that it's not obvious that new user should 'Start Scenario Game' and load 'Tutorial' from there. 'Start New Game' may sound like more logical place to start and it's even first item in the list. Attached patch adds 'Beginner

Re: [Freeciv-Dev] (PR#33510) [Patch] Help for first time user

2007-01-13 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33510 ...and patch comes here. - ML diff -Nurd -X.diff_ignore freeciv/client/gui-gtk-2.0/gui_main.c freeciv/client/gui-gtk-2.0/gui_main.c --- freeciv/client/gui-gtk-2.0/gui_main.c 2007-01-10 18:13:57.0 +0200 +++

Re: [Freeciv-Dev] (PR#21843) Freeciv 2.1.0 Beta2 bug.

2007-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=21843 On 1/13/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/13/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have an alliance, but no shared vision. Alliance allows us to see units inside transport. When transport moves out

Re: [Freeciv-Dev] (PR#14636) tech update bug

2007-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=14636 On 1/14/07, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=14636 Christian Knoke [EMAIL PROTECTED]: When an allied has stolen a tech form an enemy, the diplomacy dialog

Re: [Freeciv-Dev] (PR#18234) Feature request - Help dialog shows if units require a Building

2007-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18234 On 7/2/06, Billy Naylor [EMAIL PROTECTED] wrote: The help dialogues don't show if units require a specific building, the building help dialog shows what units it allows tho'. Patch - ML diff -Nurd -X.diff_ignore

[Freeciv-Dev] (PR#33625) [Patch] Remove bv_draw

2007-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33625 There is defined bitvector type bv_draw, but nobody uses it. Neither do I see future use for it. Rather we need bv_players, which contain all the players and not only real players (barbarians are not real players). This patch removes

[Freeciv-Dev] (PR#33626) City always sees submarines

2007-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33626 City sees submarine even when it's one square away. Battleship sees it only when in adjacent square. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#33628) Can't make freeciv.pot for trunk

2007-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33628 TRUNK/build/po$ make freeciv.pot /usr/bin/xgettext --default-domain=freeciv --directory=../../src.patched \ --add-comments=TRANS: --escape --keyword=_ --keyword=N_ --keyword=Q_ --keyword=PL_:1,2 \ --language=C

Re: [Freeciv-Dev] (PR#18773) Reordering worklist smeshes it up if there is just bought unit

2007-01-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18773 On 7/21/06, Tommi Björkbacka [EMAIL PROTECTED] wrote: You can reproduce this problem easily. First buy a random unit and then put a new unit into worklist. After that try to adjust new unit to the top of worklist. Result is that you

[Freeciv-Dev] (PR#33703) Re: [Freeciv-commits] r12487 - in /branches/S2_1/utility: inputfile.c registry.c

2007-01-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33703 On 1/15/07, Christian Knoke [EMAIL PROTECTED] wrote: Marko Lindqvist wrote on Jan 15, 16:33 (-): Author: cazfi Date: Mon Jan 15 17:33:43 2007 New Revision: 12487 URL: http://svn.gna.org/viewcvs/freeciv?rev=12487view=rev

Re: [Freeciv-Dev] Re: (PR#19822) bug in path_finding.c

2007-01-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19822 On 1/14/07, Marko Lindqvist [EMAIL PROTECTED] wrote: 1. First node always gets segment_length = 1. 2. No other node can get segment_length 1. 3. Segment_length can be too big, but not too small. This mostly untested patch

Re: [Freeciv-Dev] Re: (PR#19822) bug in path_finding.c

2007-01-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19822 On 1/14/07, Marko Lindqvist [EMAIL PROTECTED] wrote: 3. Segment_length can be too big, but not too small. Of course this is not true! So segment_length has no use whatsoever. - ML

Re: [Freeciv-Dev] Missing features for scenario creation

2007-01-15 Thread Marko Lindqvist
On 1/16/07, Daniel Markstedt [EMAIL PROTECTED] wrote: BTW, does an impassable terrain flag exist, something that stops land units from entering a certain kind of terrain? Most Civ2 modders use an ugly workaround for this: a unit that looks like a mountain and has 0 moves. You can do this only

Re: [Freeciv-Dev] (PR#18234) Feature request - Help dialog shows if units require a Building

2007-01-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18234 On 1/15/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 7/2/06, Billy Naylor [EMAIL PROTECTED] wrote: The help dialogues don't show if units require a specific building, the building help dialog shows what units it allows tho

[Freeciv-Dev] (PR#33761) [Bug] Editor allows placing units inside enemy city

2007-01-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33761 $subject - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#33762) [Patch] UCF_UNREACHABLE

2007-01-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33762 Only F_FIGHER can attack air units. It has been hardcoded to AIR_MOVING. This patch turns it into unit class flag. - ML diff -Nurd -X.diff_ignore freeciv/client/helpdata.c freeciv/client/helpdata.c --- freeciv/client/helpdata.c

[Freeciv-Dev] (PR#33767) gen-base

2007-01-16 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33767 By 'Base' I mean buildings outside cities: fortresses and airbases in current codebase. Some of their properties should come from ruleset instead of being hardcoded. Originally reason I started thinking this was that name 'Airbase' is

[Freeciv-Dev] (PR#33793) [Patch] Fix S2_0 gcc 4 compilation

2007-01-16 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33793 S2_0 does not compile without --disable-alsa with gcc 4. Or maybe problem can be in my alsa version? Anyway, attached patch fixes this. - ML diff -Nurd -X.diff_ignore freeciv/client/audio_alsa.c freeciv/client/audio_alsa.c ---

Re: [Freeciv-Dev] (PR#18234) Feature request - Help dialog shows if units require a Building

2007-01-16 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18234 On 1/16/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/15/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 7/2/06, Billy Naylor [EMAIL PROTECTED] wrote: The help dialogues don't show if units require a specific building

[Freeciv-Dev] (PR#33876) [Patch] tile_has_base_effect()

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33876 This adds new module base.[ch]. It contains one function, base_has_effect(). New function tile_has_base_effect() in tile.c uses it. tile_has_base_effect() is called from number of places instead of directly checking if tile contains

Re: [Freeciv-Dev] (PR#18773) Reordering worklist smeshes it up if there is just bought unit

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18773 On 1/15/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 7/21/06, Tommi Björkbacka [EMAIL PROTECTED] wrote: You can reproduce this problem easily. First buy a random unit and then put a new unit into worklist. After that try

Re: [Freeciv-Dev] Re: (PR#19822) bug in path_finding.c

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19822 New approach. This patch removes segment_length and step completely. When segment or path length is needed, it's determined by extra iteration. I'm afraid this is unavoidable performance hit. This version of the patch is for S2_0

Re: [Freeciv-Dev] Re: (PR#19822) bug in path_finding.c

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19822 On 1/17/07, Marko Lindqvist [EMAIL PROTECTED] wrote: This patch removes segment_length and step completely. When segment or path length is needed, it's determined by extra iteration. I'm afraid this is unavoidable performance hit

[Freeciv-Dev] (PR#33910) [Patch] Debug same nation bug

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33910 Attached patch checks if two players have same nation and prints message if they do. I mean to commit this to both trunk and S2_1 to hunt down #17436. - ML diff -Nurd -X.diff_ignore freeciv/server/srv_main.c

Re: [Freeciv-Dev] (PR#33626) City always sees submarines

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33626 On 1/15/07, Marko Lindqvist [EMAIL PROTECTED] wrote: City sees submarine even when it's one square away. Battleship sees it only when in adjacent square. Is this intentional? Anyway, attached patch changes that so that city sees

(PR#14490) Re: [Freeciv-Dev] (PR#33914) Bug Report

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=14490 On 1/18/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: 1: In file beta2.sav.gz, there is no entry in the registry for c7.ai.urgency (or the entries are out of order.) I think problem is that worklist length varies between cities.

(PR#14490) Re: [Freeciv-Dev] (PR#33914) Bug Report

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=14490 On 1/18/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I can supply the saved game file, if you so desire That would be useful. Thanks. - ML ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#32868) superbarbarians patch

2007-01-17 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=32868 On 1/9/07, Daniel Markstedt [EMAIL PROTECTED] wrote: Updated the superbarbarians patch for dev (applies to S2_1 as well) + adding some helptext. The higher levels SERIOUSLY empowers the barbs: lvl 5 gives them twice the manpower;

[Freeciv-Dev] (PR#33979) Uninitialized variable in aircraft auto-return code

2007-01-18 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33979 Variable 'alive' will be used uninitialized if no path to refuel point is found. Will commit attached fix immediately. - ML diff -Nurd -X.diff_ignore freeciv/server/unittools.c freeciv/server/unittools.c ---

Re: [Freeciv-Dev] (PR#33445) win32 client build broken (patch attached)

2007-01-18 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33445 From: Jonathan Landis [EMAIL PROTECTED] I wrote a patch for the Win32 client a couple of weeks ago. Thanks for the patch, Jonathan. I cannot compile and I have not even seen win32 client, but I looked some of the most obviously

Re: [Freeciv-Dev] (PR#33876) [Patch] tile_has_base_effect()

2007-01-18 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33876 On 1/17/07, Marko Lindqvist [EMAIL PROTECTED] wrote: This adds new module base.[ch]. It contains one function, base_has_effect(). New function tile_has_base_effect() in tile.c uses it. tile_has_base_effect() is called from number

[Freeciv-Dev] (PR#34035) [Patch] Fix memory leak in terrain.ruleset loading

2007-01-18 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34035 $subject - ML diff -Nurd -X.diff_ignore freeciv/server/ruleset.c freeciv/server/ruleset.c --- freeciv/server/ruleset.c 2006-08-18 10:51:27.0 +0300 +++ freeciv/server/ruleset.c 2007-01-19 04:23:36.0 +0200 @@ -1734,6

Re: [Freeciv-Dev] (PR#34032) wishlist: further cripple novice AI

2007-01-18 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34032 On 1/19/07, Daniel Markstedt [EMAIL PROTECTED] wrote: I suggest we cripple novice further so that it becomes what players expect it to be: something that even a novice can stand a chance against. It should build sparser empires,

Re: [Freeciv-Dev] (PR#34032) wishlist: further cripple novice AI

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34032 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: About changing rules, attached is untested patch that halves firepower for novice AI. Not tested, but it breaks victory probability calcultations at client side. However, main

[Freeciv-Dev] (PR#34073) [Patch] H_DANGER

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34073 This adds new AI handicap, H_DANGER. It causes AI to always cosider all it cities to be in grave danger. This causes it to spend some resources to unnecessary defense instead of expansion. Handicap is given to novice level AI. Maybe it

[Freeciv-Dev] (PR#34081) [Patch] Read base flags from ruleset

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34081 Applies on top of #33876. - ML diff -Nurd -X.diff_ignore freeciv/common/base.c freeciv/common/base.c --- freeciv/common/base.c 2007-01-19 13:50:26.0 +0200 +++ freeciv/common/base.c 2007-01-19 13:57:54.0 +0200 @@

(PR#17436) Re: [Freeciv-Dev] (PR#33883) server select duplicate nation

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17436 On 1/17/07, Daniel Markstedt [EMAIL PROTECTED] wrote: In recent trunk: Selected a fictional nation to play as. The server chose the very same nation for one of the AI players. Do you know exact server settings, including gameseed,

Re: [Freeciv-Dev] (PR#33761) [Bug] Editor allows placing units inside enemy city

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33761 On 1/16/07, Marko Lindqvist [EMAIL PROTECTED] wrote: $subject Fix - ML diff -Nurd -X.diff_ignore freeciv/server/edithand.c freeciv/server/edithand.c --- freeciv/server/edithand.c 2006-07-17 23:56:55.0 +0300 +++ freeciv

[Freeciv-Dev] (PR#34095) [Patch] Nation sanity checking

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34095 Some sanity checking for nations and players. For trunk only. - ML diff -Nurd -X.diff_ignore freeciv/common/player.c freeciv/common/player.c --- freeciv/common/player.c 2006-07-17 23:56:46.0 +0300 +++ freeciv/common/player.c

Re: [Freeciv-Dev] (PR#34095) [Patch] Nation sanity checking

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34095 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: Some sanity checking for nations and players. For trunk only. One more assert added - ML diff -Nurd -X.diff_ignore freeciv/common/player.c freeciv/common/player.c --- freeciv

Re: (PR#17436) Re: [Freeciv-Dev] (PR#33883) server select duplicate nation

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17436 handle_nation_select_req() always marks players previous nation available. This is not right when nation is not changed, but only leader name or sex. player_set_nation() sets nation-player correctly, so handle_nation_select_req() should

Re: (PR#17436) Re: [Freeciv-Dev] (PR#33883) server select duplicate nation

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17436 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: handle_nation_select_req() always marks players previous nation available. This is not right when nation is not changed, but only leader name or sex. player_set_nation() sets

[Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 We have two barbarian players but only one nation which they share. This means that nation-player points to one of them, but for another pplayer-nation-player != pplayer. - ML ___

[Freeciv-Dev] (PR#34127) [Patch] Fix gui-stub compilation

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34127 $subject - ML diff -Nurd -X.diff_ignore freeciv/client/gui-stub/mapview.c freeciv/client/gui-stub/mapview.c --- freeciv/client/gui-stub/mapview.c 2006-07-17 23:56:54.0 +0300 +++ freeciv/client/gui-stub/mapview.c 2007-01-20

[Freeciv-Dev] (PR#34131) [Patch] Split F_FIGHTER

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34131 This splits Fighter flag in two. Fighter is very good attacking Helicopter units. AttackAny can attack even otherwise unreachable units. Applies on top of #33762 - ML diff -Nurd -X.diff_ignore freeciv/client/helpdata.c

[Freeciv-Dev] (PR#34133) [Patch] AI bomber vs bomber fix

2007-01-19 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34133 AI bomber might target enemy aircraft, which it cannot attack. Fix attached. - ML diff -Nurd -X.diff_ignore freeciv/ai/aiair.c freeciv/ai/aiair.c --- freeciv/ai/aiair.c 2006-08-18 10:52:03.0 +0300 +++ freeciv/ai/aiair.c

[Freeciv-Dev] (PR#34145) [Bug] Aiferry memory problem

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34145 Autogames differ between executions. This is what valgrind found out: ==6086== Conditional jump or move depends on uninitialised value(s) ==6086==at 0x811ED99: ai_manage_ferryboat (aiferry.c:795) ==6086==by 0x812F8AD:

Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have two barbarian players but only one nation which they share. This means that nation-player points to one of them, but for another pplayer-nation-player != pplayer

[Freeciv-Dev] Re: (PR#34129) gui-sdl compile problem: round()

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34129 On 1/20/07, Christian Prochaska [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] - Sa 20. Jan 2007, 00:49:16]: cc1: warnings being treated as errors ../../../src.patched/client/gui-sdl/widget_scrollbar.c: In function

Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Daniel Markstedt [EMAIL PROTECTED] wrote: On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: We have two barbarian players but only one nation which they share

Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Daniel Markstedt [EMAIL PROTECTED] wrote: Or we could use my Pirate nation. Agreed, the effect would be slightly humorous. But so is having Conestoga wagons in the year 4000 BC. ;) We cannot currently control which

Re: [Freeciv-Dev] (PR#34145) [Bug] Aiferry memory problem

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34145 On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=34145 Autogames differ between executions. This is what valgrind found out: ==6086== Conditional jump or move depends

[Freeciv-Dev] (PR#34168) [Patch] Use player_set_nation() for barbarians

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34168 Use player_set_nation() instead of directly altering player-nation in barbarians code. player_set_nation() also handles setting nation-player correctly. - ML diff -Nurd -X.diff_ignore freeciv/server/barbarian.c

Re: [Freeciv-Dev] (PR#33876) [Patch] tile_has_base_effect()

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33876 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/17/07, Marko Lindqvist [EMAIL PROTECTED] wrote: This adds new module base.[ch]. It contains one function, base_has_effect(). New function tile_has_base_effect() in tile.c

Re: [Freeciv-Dev] (PR#34081) [Patch] Read base flags from ruleset

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34081 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: Applies on top of #33876. - Improvet ruleset comments - Send information to client - ML diff -Nurd -X.diff_ignore freeciv/client/packhand.c freeciv/client/packhand.c

[Freeciv-Dev] (PR#34206) [Patch] Use nation name in uprising message

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34206 Use barbarian nation name instead of hardcoded Barbarians in uprising message. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#34206) [Patch] Use nation name in uprising message

2007-01-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34206 On 1/21/07, Marko Lindqvist [EMAIL PROTECTED] wrote: Use barbarian nation name instead of hardcoded Barbarians in uprising message. And the patch... - ML diff -Nurd -X.diff_ignore freeciv/server/barbarian.c freeciv/server

[Freeciv-Dev] (PR#34224) Memory loss in ai diplomacy

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34224 Form valgrind: ==3480== 1,036 (396 direct, 640 indirect) bytes in 35 blocks are definitely lost in loss record 2 of 6 ==3480==at 0x401C422: malloc (vg_replace_malloc.c:149) ==3480==by 0x804BD0D: fc_real_malloc (mem.c:82)

Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: For S2_1 adding ruleset for another barbarian nation is sufficient, but in trunk code should be changed so that it doesn't even accept same nation for both barbarian players

[Freeciv-Dev] Re: (PR#34129) gui-sdl compile problem: round()

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34129 On 1/21/07, Christian Prochaska [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] - Sa 20. Jan 2007, 13:33:05]: 'man round' says Compile with -std=c99; link with -lm. But when I try to set '-std=c99', log.c no longer compiles.

Re: [Freeciv-Dev] (PR#33445) win32 client build broken (patch attached)

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33445 On 1/21/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Except for cs.po, the win32 client build was ok. Thanks for testing. I have now committed move_type and worklist patches. There were a few warnings from gcc about things that

Re: [Freeciv-Dev] (PR#33876) [Patch] tile_has_base_flag()

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=33876 On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/17/07, Marko Lindqvist [EMAIL PROTECTED] wrote: This adds new module base.[ch]. It contains one function

Re: [Freeciv-Dev] (PR#18466) Gfx problem with two sea types

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18466 On 1/21/07, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=18466 On 7/10/06, Marko Lindqvist [EMAIL PROTECTED] wrote: I don't think it's possible with current codebase to create

Re: [Freeciv-Dev] (PR#18466) Gfx problem with two sea types

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18466 On 1/21/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/21/07, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=18466 On 7/10/06, Marko Lindqvist [EMAIL PROTECTED] wrote: I

[Freeciv-Dev] (PR#34262) [Patch] Rename match_type other - land

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34262 Most tilesets have two layer0 match_type: ocean and other. This patch renames other as land. Even if some terrain type later needs special match_type, it has to come in addition to land, since drawing second ocean type correctly will

[Freeciv-Dev] (PR#34272) [Patch] Deep Ocean gfx fallback

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34272 Most tilesets handle Deep Ocean from #34265 using ocean graphics as fallback. Amplio and Isotrident however use wrong colour blending between Ocean and Deep Ocean tiles in that case. Attached patch defines Deep Ocean gfx separately for

[Freeciv-Dev] Re: (PR#34129) gui-sdl compile problem: round()

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34129 On 1/21/07, Christian Prochaska [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] - So 21. Jan 2007, 11:11:03]: On 1/21/07, Christian Prochaska [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] - Sa 20. Jan 2007, 13:33:05]:

Re: [Freeciv-Dev] (PR#34276) clients default to the wrong port

2007-01-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34276 On 1/22/07, Daniel Markstedt [EMAIL PROTECTED] wrote: The default port has changed from to 5556, but the clients (tested with GTK2 and SDL) still default to . You probably have old port number stored in ~/.civclientrc -

Re: [Freeciv-Dev] (PR#32017) barbarian-only units

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=32017 On 1/7/07, Daniel Markstedt [EMAIL PROTECTED] wrote: This patch adds a Horse Archer as well as Elephants as barbarian-only units. The Horse Archer is available from the beginning, while the Elephant now requires Polytheism and

Re: [Freeciv-Dev] (PR#18466) Gfx problem with two sea types

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18466 On 1/21/07, Marko Lindqvist [EMAIL PROTECTED] wrote: After reading some source code (README.graphics does not document this) I think that matching_style = full can be used to achieve what I want. So far I have found out that client

Re: [Freeciv-Dev] (PR#18466) Gfx problem with two sea types

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18466 On 1/22/07, Daniel Markstedt [EMAIL PROTECTED] wrote: On 1/22/07, Marko Lindqvist [EMAIL PROTECTED] wrote: So this ticket is down to blending problem with amplio seas. 1) We want to blend between Ocean and land. 2) We want

Re: [Freeciv-Dev] (PR#18466) Gfx problem with two sea types

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18466 On 1/22/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/22/07, Daniel Markstedt [EMAIL PROTECTED] wrote: On 1/22/07, Marko Lindqvist [EMAIL PROTECTED] wrote: So this ticket is down to blending problem with amplio seas. 1

Re: (PR#17436) [Freeciv-Dev] (PR#33883) server select duplicate nation

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17436 On 1/22/07, Egor Vyscrebentsov [EMAIL PROTECTED] wrote: On 1/19/07, Marko Lindqvist wrote: handle_nation_select_req() always marks players previous nation available. This is not right when nation is not changed, but only

Re: [Freeciv-Dev] (PR#34111) [Bug] Barbarian players share nation

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34111 On 1/20/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/20/07, Daniel Markstedt [EMAIL PROTECTED] wrote: Or we could use my Pirate nation. Agreed, the effect would be slightly humorous. But so is having Conestoga wagons

Re: [Freeciv-Dev] (PR#32017) barbarian-only units

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=32017 On 1/22/07, Daniel Markstedt [EMAIL PROTECTED] wrote: On 1/22/07, Marko Lindqvist [EMAIL PROTECTED] wrote: Can barbarians really build units with NoBuild flag? Only unit with NoBuild flag so far has been barbarian leader which

[Freeciv-Dev] (PR#34321) [Patch] Check that barbarian can build what it selects

2007-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34321 Barbarian building code just starts building units without checking if building that unit is at all possible in that city. So barbarian can for example end building ship in landlocked city, if someone gives ship a BARBARIAN_BUILD role.

Re: [Freeciv-Dev] (PR#32017) barbarian-only units

2007-01-23 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=32017 On 1/22/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/22/07, Daniel Markstedt [EMAIL PROTECTED] wrote: On 1/22/07, Marko Lindqvist [EMAIL PROTECTED] wrote: Can barbarians really build units with NoBuild flag? Only unit

[Freeciv-Dev] (PR#34379) [Patch] pft_fill_unit_default_parameters() and UCF_TERRAIN_SPEED

2007-01-23 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34379 This fixes pft_fill_unit_default_parameters() in respect of UCF_TERRAIN_SPEED. - ML diff -Nurd -X.diff_ignore freeciv/common/aicore/pf_tools.c freeciv/common/aicore/pf_tools.c --- freeciv/common/aicore/pf_tools.c 2007-01-22

Re: [Freeciv-Dev] (PR#34330) [Patch] Color for Deep Ocean

2007-01-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34330 On 1/22/07, Marko Lindqvist [EMAIL PROTECTED] wrote: Patch adds color for Deep Ocean to colors.tilespec. Colours for Ocean and Deep Ocean were reversed. - ML diff -Nurd -X.diff_ignore freeciv/data/misc/colors.tilespec freeciv

[Freeciv-Dev] (PR#34431) [Patch] AI level requirement type

2007-01-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34431 This adds new requirement type: minimum AI level. This allows creating cheating effects for hard level AI in effects.ruleset. This is just first version. More work is needed before this can go in. There probably should be two

Re: [Freeciv-Dev] (PR#34432) Solar Plant

2007-01-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34432 On 1/24/07, Daniel Markstedt [EMAIL PROTECTED] wrote: Looking at the effects reference, I could only find flags that increased pollution. Did I overlook something, or would such an effect have to be implemented first? Increase

Re: (PR#17436) Re: [Freeciv-Dev] (PR#33883) server select duplicate nation

2007-01-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17436 On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: On 1/19/07, Marko Lindqvist [EMAIL PROTECTED] wrote: handle_nation_select_req() always marks players previous nation available. This is not right when nation is not changed

  1   2   3   4   5   6   7   8   9   10   >