Re: [m5-dev] changeset in m5: slicc: fixed MI_example bug. The directory was...

2009-07-08 Thread nathan binkert
Derek, I'd like to request that you insert newlines such that your comments wrap at 80 columns. Thanks, Nate On Wed, Jul 8, 2009 at 7:23 AM, Derek Howerd...@cs.wisc.edu wrote: changeset 57650468aff1 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=57650468aff1

Re: [m5-dev] Cron m5t...@zizzer /z/m5/regression/do-regression quick

2009-07-08 Thread nathan binkert
* build/ALPHA_SE/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby FAILED! I'm guessing that this changed because of the tweaks Derek has made to the MI_example protocol. Nate ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] Gem5 configuration

2009-07-09 Thread nathan binkert
- You're guaranteed that any SimObject that is passed to you as a parameter has been constructed before your constructor is called, so that the pointer in the params struct is valid.  Since init() hasn't been called yet you can't assume too much about what that other object is prepared to do

Re: [m5-dev] Cron m5t...@zizzer /z/m5/regression/do-regression quick

2009-07-11 Thread nathan binkert
* build/ALPHA_SE/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby FAILED! Derek, M5 regressions not only ensure that the program doesn't crash, but they ensure that the stats don't change either. So, this stat likely failed because the stats changed somewhat due to your recent fix.

Re: [m5-dev] Cron m5t...@zizzer /z/m5/regression/do-regression quick

2009-07-12 Thread nathan binkert
Are there any options passed to memtest-ruby in the regression?  If I run the test as: scons build/ALPHA_SE/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby then the memtest program appears to run in an infinite loop. Are you sure it's an infinite loop? It does take nearly 10 minutes

Re: [m5-dev] changeset in m5: Tester update

2009-07-16 Thread nathan binkert
Polina, Please be very careful when you update files. This update changed the license text on a bunch of files. Please put the license text back the way it was. If there are other licenses you changed in other commits, can you please fix those as well? Nate On Thu, Jul 16, 2009 at 1:38 PM,

Re: [m5-dev] changeset in m5: 1. Got rid of unused functions in DirectoryMemory

2009-07-16 Thread nathan binkert
Polina, In general, please don't put unrelated changes into a single changeset. Also, when you put together a commit message, Can you make the first line be a summary of the commit and subsequent lines go into more detail? This is helpful when using tools such as hg log which by default just

Re: [m5-dev] Cron m5t...@zizzer /z/m5/regression/do-regression quick

2009-07-19 Thread nathan binkert
* build/ALPHA_SE/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby FAILED! The memory tester has failed again. Can someone check it out? Nate ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] missing emails

2009-07-19 Thread nathan binkert
I don't think I got one. It could be a size limit. You can check the archive to see if it made it there. What's the size of the diff? Nate On Sat, Jul 18, 2009 at 4:04 PM, Gabe Blackgbl...@eecs.umich.edu wrote: Are you a moderator for the list? Maybe the attachment was too big and you

Re: [m5-dev] a few questions

2009-07-19 Thread nathan binkert
[responding on m5-dev since it's a better place to deal with this.] 1) How can I build a fast libm5?  i.e. with a -O3 compile flag Just replace libm5_debug.so with libm5_opt.so. There's also libm5_fast.so that has all of the debugging stuff #ifdef'd out. 2) What's the best way to add multiple

Re: [m5-dev] changeset in m5: Tracing: Add accessors so tracers can get at da...

2009-07-20 Thread nathan binkert
No big deal, but we decided a while ago that if you have accessors, it should be: int _foo; int foo() const { return _foo; } void foo(int val) { _foo = val; } instead of: int foo; int getFoo() const { return foo; } void setFoo(int val) { foo = val; } On Mon, Jul 20,

Re: [m5-dev] m5 web cross-reference

2009-07-21 Thread nathan binkert
[Sorry, Alex hit send last time] Awesome! As a note, I was looking into this a little bit and there was some stuff about tomcat 6 not working. I'm not sure if this is still true, but just in case. Nate ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] Scons with SLICC

2009-07-21 Thread nathan binkert
I've noticed that scons creates and runs the SLICC parser every time you build.  Is this absolutely necessary?  It seems to slow down the build quite a bit, especially when recompiling a minor change. This shouldn't be happening. Does this happen whether or not you make any changes? Can you

[m5-dev] repository access

2009-07-29 Thread nathan binkert
As we're adding users, we decided that it is a pain to give everyone a shell account on daystrom, so we're switching to the shared ssh mechanism of access control for committing to the repository. We're doing this for several reasons: 1) ease of management 2) much more secure 3) easier user

Re: [m5-dev] MIPS_SE compile error

2009-07-30 Thread nathan binkert
Korey, can you please comment on this? I'd like to commit a fix since I'm running a compiler that fails on this as well. Nate On Wed, Jul 29, 2009 at 2:48 PM, Vince Weavervi...@csl.cornell.edu wrote: Hello not sure if this is the proper place to send packages, but here it goes currently

[m5-dev] changeset in m5: compile: fix accidental conversion of == into =

2009-07-30 Thread Nathan Binkert
changeset 58e3056d918e in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=58e3056d918e description: compile: fix accidental conversion of == into = diffstat: 1 file changed, 1 insertion(+), 1 deletion(-) src/arch/mips/mt.hh |2 +- diffs (12 lines): diff -r

Re: [m5-dev] GEM5 Issues

2009-07-30 Thread nathan binkert
I have no plans to fix any of this, but please do not just check in fixes without sending out patches for review.I'm particularly interested in the first two. For the generated protocol code, are you trying to simultaneously compile multiple protocols into the same binary or just trying to

Re: [m5-dev] changeset in m5: Rename internal Request fields to start with '_'.

2009-08-02 Thread nathan binkert
Very awesome. I was tempted to do this a number of times. I'm going to go ahead and add this standard to the style guide. ok? Nate On Sat, Aug 1, 2009 at 10:51 PM, Steve Reinhardtsteve.reinha...@amd.com wrote: changeset 50125d42559c in /z/repo/m5 details:

Re: [m5-dev] changeset in m5: Fix setting of INST_FETCH flag for O3 CPU.

2009-08-02 Thread nathan binkert
Also, I think with this flag in place we ought to be able to get rid of the tlb_mode setting; the TLB can just look and see whether isInstFetch() is true to decide how to handle the request... does anyone agree or disagree? Well, mode is read/write/execute. You're proposing figuring just

Re: [m5-dev] changeset in m5: X86: Fix segment override prefixes on instructi...

2009-08-03 Thread nathan binkert
I finally fixed the bug that was making the init scripts segfault. Now fsck is segfaulting, I believe because it's using a bunch of unimplemented SIMD/SSE/3dnow/mmx instructions. These are ~ movss, ucomiss, xorps, cvtsi2ss divss, mulss, addss, cvtss2sd, cvttss2si, and cvtdq2ps up to the point

Re: [m5-dev] changeset in m5: X86: Fix segment override prefixes on instructi...

2009-08-03 Thread nathan binkert
I finally fixed the bug that was making the init scripts segfault. Now Oh, and by the way. This is awesome news! Nate ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Scons cleaning

2009-08-03 Thread nathan binkert
The command: scons -c does not appear to remove SLICC generated files in mem/protocol (nor does scons -c target).  I think it would be helpful if it did to avoid confusion about whether or not you're looking at a recently generated file.  How can this be done? I just checked and the only

[m5-dev] Python SLICC

2009-08-03 Thread nathan binkert
So, maybe I'm crazy, but a whole bunch of things got me convinced to started converting SLICC to python. Before I go way too far, I want to see if any of the Wisc have any objections to this. Here are what I see as the benefits: 1) Use python's powerful formatting function + triple quoted

Re: [m5-dev] Python SLICC

2009-08-03 Thread nathan binkert
system, then that is a major plus.  I would like to know more details of exactly what path you are thinking of and how Python SLICC helps. Thanks, Brad -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of nathan binkert Sent: Monday, August

Re: [m5-dev] Scons with SLICC

2009-08-04 Thread nathan binkert
Here is an output from a build after nothing changes, where I have the parser print when it runs. Which parser? The lex/yacc one or the python one? If it's the former, I'll try to fix it. If it's the latter, that parser has to be run, otherwise SCons won't know what files are being

Re: [m5-dev] Scons with SLICC

2009-08-04 Thread nathan binkert
Which parser?  The lex/yacc one or the python one? The Python one. If it's the former, I'll try to fix it.  If it's the latter, that parser has to be run, otherwise SCons won't know what files are being generated.  I can check to see if there is any real performance impact from doing that,

Re: [m5-dev] Python SLICC

2009-08-04 Thread nathan binkert
I hope you don't mind me asking, but why does the fragility of generated code matter?  One should never modify generated code and only rarely look at it. I'm referring to the generator itself. It's pretty hard to follow what's going on, so if you want to modify the generator itself, you need

Re: [m5-dev] Python SLICC

2009-08-04 Thread nathan binkert
Just an FYI, I'm currently making changes to both the parser and code generator.  I should be able to push those today if you want to hold off on the conversion. Ok, no problem. Let me know if you need any help updating parser.py. Also, for those of you SLICC experts out there, I'm curious

[m5-dev] changeset in m5: slicc: better error messages when the python pa...

2009-08-04 Thread Nathan Binkert
changeset 0e78ffeebffd in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=0e78ffeebffd description: slicc: better error messages when the python parser fails diffstat: 1 file changed, 11 insertions(+), 4 deletions(-) src/mem/slicc/parser/parser.py | 15 +++

Re: [m5-dev] Scons cleaning

2009-08-04 Thread nathan binkert
Yes, especially with the limited error messages SLICC spits out at the moment.  When they aren't deleted it's difficult to even narrow down how far SLICC makes it before it fails; If they are deleted you can at least get an idea of which file SLICC gets stuck on. Ok. I spent some time trying

Re: [m5-dev] Protocol Directories

2009-08-04 Thread nathan binkert
Now that the other GEM5 issues are mostly resolved (thanks everyone!), I wanted to discuss the protocol directory issue in more detail.  I'm completely fine with recompiling all files when changing protocols.  I would just like the ability to have two different M5 binaries, using different

Re: [m5-dev] changeset in m5: X86: Fix segment override prefixes on instructi...

2009-08-05 Thread nathan binkert
qemu has a tests directory and in it, there seems to be a pretty substantial tester for opcodes at least half of those opcodes are listed. Yes, thank you. That's been very helpful in general. I think someone actually recommended it before, but I'd misinterpreted the description of what was

Re: [m5-dev] changeset in m5: X86: Fix segment override prefixes on instructi...

2009-08-05 Thread nathan binkert
The changes I pushed already mostly fix condition codes on existing instructions, plus rotates by more than the width of the target, plus a few minor fixes to multiply related microops. Moving forward in the short term, division instructions aren't getting the answers they should, and the

Re: [m5-dev] gzstream library

2009-08-07 Thread nathan binkert
When you compile m5 as a static library, e.g. scons build/ALPHA_SE/libm5_prof.a it doesn't compile gzstream into the library, nor does it link against a separate gzstream library, making the m5 library unusable. How can I make it compile gzstream? There should be a libgzstream.a in

Re: [m5-dev] using gdb with memtest-ruby

2009-08-07 Thread nathan binkert
I really need to use a debugging tool like gdb, but it seems that it just work with m5.debug. scons run memtest-ruby with m5.fast, how can I make it use m5.debug? In your scons target, you must have the word fast in there somewhere. If you replace it with debug, it should work. If this

Re: [m5-dev] gzstream library

2009-08-07 Thread nathan binkert
I think this is because of the ordering on the command line. If I recall correctly, when two libraries depend on each other, the providing library needs to be listed *after* the consuming library. So you should put gzstream after m5. This is because with static libs linked with -l, the linker

Re: [m5-dev] gzstream library

2009-08-07 Thread nathan binkert
Well that is handy to know.  Seems to do the trick.  Thanks, Nate So, now how can I get scons to build the gzstream library when you specify a static library target? Well, you can just specify gzstream as a target: build/gzstream/libgzstream.a I think that the longer term solution is to just

Re: [m5-dev] [PATCH] bug fix for data_msg_size in network/Network.cc

2009-08-07 Thread nathan binkert
Unless anybody has any concerns, I will try and check in the changes to the repository in an hour. Tushar, I don't have a problem with your patch, but an hour is not giving people enough time to review your patch. If your code is in a mercurial queue, there should be no big rush and you

Re: [m5-dev] configuration graph

2009-08-12 Thread nathan binkert
How difficult would it be to generate a visual graph of the simboject heirarchy from within a config script? It might look something like Simulation.graph() similar to Simulation.run(...). I'm thinking that might be a good sanity check if someone wanted to make sure their simulation was

[m5-dev] changeset in m5: python: Make it possible to import the parts of...

2009-08-16 Thread Nathan Binkert
changeset 312b22c30c16 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=312b22c30c16 description: python: Make it possible to import the parts of m5 that are pure python diffstat: 1 file changed, 10 insertions(+), 3 deletions(-) src/python/m5/__init__.py | 13

[m5-dev] changeset in m5: ply: update PLY to version 3.2

2009-08-16 Thread Nathan Binkert
changeset e21e9ab5fad0 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=e21e9ab5fad0 description: ply: update PLY to version 3.2 diffstat: 164 files changed, 9123 insertions(+), 3820 deletions(-) ext/ply/ANNOUNCE | 19 ext/ply/CHANGES

[m5-dev] changeset in m5: orderdict: Use DictMixin and add orderdict to m...

2009-08-16 Thread Nathan Binkert
changeset ee7587e7c71d in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=ee7587e7c71d description: orderdict: Use DictMixin and add orderdict to m5.util diffstat: 3 files changed, 29 insertions(+), 34 deletions(-) src/python/SConscript |1

[m5-dev] changeset in m5: ply: add a base class called Grammar that encap...

2009-08-16 Thread Nathan Binkert
1b5863aba48c src/python/m5/util/grammar.py --- /dev/null Thu Jan 01 00:00:00 1970 + +++ b/src/python/m5/util/grammar.py Sun Aug 16 13:40:01 2009 -0700 @@ -0,0 +1,119 @@ +# Copyright (c) 2006-2009 Nathan Binkert n...@binkert.org +# All rights reserved. +# +# Redistribution and use in source

[m5-dev] changeset in m5: code_formatter: Add a python class for writing ...

2009-08-16 Thread Nathan Binkert
: Nathan Binkert from attrdict import attrdict, optiondict +from code_formatter import code_formatter from misc import * from multidict import multidict from orderdict import orderdict diff -r 1b5863aba48c -r 6c7d9e9b3c83 src/python/m5/util/code_formatter.py --- /dev/null Thu Jan 01 00:00:00 1970

[m5-dev] [PATCH 0 of 2] python implementation of slicc

2009-08-16 Thread Nathan Binkert
Ok, so I finished the python translation of slicc. With the first patch applied, you can go into src/mem/pyslicc and run ./pyslicc. The output files can be diffed against the C++ slicc with -wBur. There's basically only minimal differences. The second diff changes the generated code output to

[m5-dev] [PATCH 2 of 2] slicc: Change the code generation so that the generated code is easier to read

2009-08-16 Thread Nathan Binkert
# HG changeset patch # User Nathan Binkert n...@binkert.org # Date 1250457436 25200 # Node ID df4b8439bf23f13e4f1793d0dd928bec40cae2c4 # Parent a5771f288585269e01b3a7dd3029e8fd5d551764 slicc: Change the code generation so that the generated code is easier to read diff --git a/src/mem/pyslicc

Re: [m5-dev] problem with running memtest-ruby in gem5?

2009-08-17 Thread nathan binkert
What is the configuration for LIBRUBY_MESI_CMP? As far as I know, this is not in the development tree. On Mon, Aug 17, 2009 at 3:30 PM, Somayeh Sardashtisoma...@cs.wisc.edu wrote: Hi, I have found that in new version of gem5, when we make a protocol it does not create ALPHA_SE directory. It

Re: [m5-dev] problem with running memtest-ruby in gem5?

2009-08-17 Thread nathan binkert
wrote: Yes, it is not in the tree because I have not pushed it yet. However I have the same problem with even MI_example. nathan binkert wrote: What is the configuration for LIBRUBY_MESI_CMP?  As far as I know, this is not in the development tree. On Mon, Aug 17, 2009 at 3:30 PM, Somayeh

Re: [m5-dev] problem with running memtest-ruby in gem5?

2009-08-18 Thread nathan binkert
?  What does it do?  Nate On Mon, Aug 17, 2009 at 6:42 PM, Somayeh Sardashtisoma...@cs.wisc.edu wrote: Yes, it is not in the tree because I have not pushed it yet. However I have the same problem with even MI_example. nathan binkert wrote: What is the configuration for LIBRUBY_MESI_CMP

Re: [m5-dev] changeset in m5: X86: Make the real time clock actually keep tra...

2009-08-20 Thread nathan binkert
I have a couple of comments on this changeset. First, I think this has the potential to affect alpha, so you should run regressions. (MC146818 is used by alpha for the clock). An alternative it to just increment the fields and add rollover code. It would a bunch of lines of code, but really easy

Re: [m5-dev] changeset in m5: X86: Make the real time clock actually keep tra...

2009-08-20 Thread nathan binkert
If it's all UTC then there's no daylight savings issue.  Plus given the rate at which we simulate, we'd have to have a very poorly chosen starting time date to simulate across a leap second (from http://en.wikipedia.org/wiki/Leap_second: Leap seconds occur only at the end of a UTC month, and

[m5-dev] Templating language

2009-08-22 Thread nathan binkert
So, I've been thinking about my old code_formatter thing that I've added to M5 recently and been wondering if it'd be better to just use one of the standard templating languages. I don't know much about them. I'm talking about things like genshi, cheetah, mako, django templates, etc. Does

Re: [m5-dev] seg fault in typeinfo for Printable()

2009-08-24 Thread nathan binkert
Have you tried a newer version of gcc to see what the code looks like? Nate On Mon, Aug 24, 2009 at 10:06 PM, Gabe Blackgbl...@eecs.umich.edu wrote: This appears to be a gcc bug. I will now explain why. If you don't care, stop reading. If you do care and you see some place where I'm wrong,

Re: [m5-dev] So somebody actually -does- use this stuff :)

2009-08-25 Thread nathan binkert
Good point... if we wanted to be completely safe we'd either have to require a prototype to be in scope or forbid using instruction operands directly as function call operands altogether. I feel like I can probably help with some useful ideas, but I don't have a good enough picture of what's

Re: [m5-dev] splitting up decoder.cc

2009-08-25 Thread nathan binkert
I see no mention of specific individuals in my comment!  A lot depends on whether you can hack out a few contiguous 30,000-line chunks or if you'd have to do a lot of interleaving a few lines at a time to get it to work.  Even in the latter case, some emacs macro creativity could possibly go

Re: [m5-dev] Extra 'ioctl' command codes

2009-08-28 Thread nathan binkert
I think this simple patch is fine. We could in the future implement an IOCTL type dispatch like we have for syscalls, but that's overkill right now I think. Nate I noticed this a few days ago. The names aren't wrong, but they are architecture specific and currently there is only one set of

Re: [m5-dev] Enhancement to 'brk' system call

2009-08-28 Thread nathan binkert
Tim, First, let me say that all of your work is awesome. Thanks for doing all of this. It was certainly a pleasant surprise. In your brk patch, I think the zero function on physical memory is not the right thing to do. You want to use a memory port and call memsetBlob on that port. Similar

Re: [m5-dev] Cron m5t...@zizzer /z/m5/regression/do-regression quick

2009-08-31 Thread nathan binkert
I'm rerunning regressions on zizzer and everything seems fine so far... this looks like an issue with swig on the pool machines.  Does anyone have any idea why things might have changed (either with the version of swig on the pool machines, or the version that we require)? Unfortunately the

Re: [m5-dev] config patch

2009-09-01 Thread Nathan Binkert
I will read it today. There are some issues. Please be a bit more patient. On Sep 1, 2009, at 8:15, Polina Dudnik pdud...@gmail.com wrote: I will push this if nobody has any objections. On Mon, Aug 31, 2009 at 4:48 PM, Polina Dudnik pdud...@gmail.com wrote: Hi, I am attaching a small

[m5-dev] hooks: add m5threads

2009-09-05 Thread Nathan Binkert
changeset d1bfbc434cca in /z/repo/hooks details: http://repo.m5sim.org/hooks?cmd=changeset;node=d1bfbc434cca summary: add m5threads diffstat: 1 file changed, 1 insertion(+) notify.ini |1 + diffs (11 lines): diff -r 61e0b644a4a1 -r d1bfbc434cca notify.ini --- a/notify.iniWed Feb 04

Re: [m5-dev] Syscall issue: exit() vs. exit_group()

2009-09-05 Thread nathan binkert
The key issue is that SE mode does not support the Linux pthreads library... it's just too complicated (see http://m5sim.org/wiki/index.php/Splash_benchmarks).  Daniel Sanchez at Stanford has written a lightweight pthreads library that uses a much reduced set of syscalls that SE mode does

Re: [m5-dev] templating readMiscReg and setMiscReg

2009-09-08 Thread nathan binkert
How often are these functions used? I'd have thought that they're not so frequent and wouldn't warrant optimization. Also, couldn't they just be inlined? Or is the variable obfuscated in such a way that the compiler doesn't know what it is at compile time? Nate Hello everybody. I was

Re: [m5-dev] changeset in m5: MI data corruption bug fix

2009-09-11 Thread nathan binkert
I'm guessing that this changes the regression results. Did you re-run them? Nate On Fri, Sep 11, 2009 at 8:58 AM, pdud...@gmail.com wrote: changeset deb20a55147c in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=deb20a55147c description:        MI data corruption bug fix

Re: [m5-dev] changeset in m5: MI data corruption bug fix

2009-09-11 Thread nathan binkert
Those are still broken on zizzer, by the way. We should really fix those soon so we don't discover a big mess when we finally do. Anyone got some free time to work on this? Nate ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] config patch

2009-09-11 Thread nathan binkert
I finally read this diff. My comments are inline. In the future, please use hg email which is found in the patchbomb extension. It makes it far easier to comment on diffs since I can just then reply to the e-mail without having to jump through hoops to get it into my mailer. Nate diff -r

Re: [m5-dev] Large Memory support in Ruby

2009-09-11 Thread nathan binkert
Attached is a patch I would like to check in that allows Ruby to support a very large memory address space and high core count.  Currently ruby uses a flat array to store the memory state of the system.  This works well when the simulated system is roughly 4 GB or less, but is not practical

Re: [m5-dev] templating readMiscReg and setMiscReg

2009-09-11 Thread nathan binkert
That reminds me. Why do we have a convention of read/set? Why not read/write or set/get? It seems a little asymmetric, but admittedly probably not important enough to change in any case. I have no idea, but if you want to change it, I'd suggest read/write. Maybe at some point write meant

Re: [m5-dev] SPARC_SE hook up a few more syscalls

2009-09-13 Thread nathan binkert
Did anyone ever import this code? If not, anyone see any reason not to? On Wed, Jul 29, 2009 at 2:50 PM, Vince Weaver vi...@csl.cornell.edu wrote: Hello I'm trying to run gcc from spec2k under SPARC_SE and ran into a few unimplemented syscalls.  Attached is a patch that enables getrlimit and

Re: [m5-dev] [PATCH 02 of 18] ruby: CacheMemory tag lookup uses a hash instead of a loop

2009-09-14 Thread nathan binkert
One of my personal pet peeves is having code in the tree that's commented out. Is there any reason to do this with a revision control system? Either the code is good and should be kept, or it should just be deleted and live in the history. Nate On Mon, Sep 14, 2009 at 3:14 PM, Derek Hower

Re: [m5-dev] [PATCH 01 of 18] ruby: added random seed option to config scripts

2009-09-14 Thread nathan binkert
This code reminds me that we really need to start having a plan to merge ruby/m5 code more. There are many things in both code bases and this is yet another example. Perhaps we can try to target that we all put some effort into this after ISCA. Nate On Mon, Sep 14, 2009 at 3:14 PM, Derek

Re: [m5-dev] [PATCH 03 of 18] Automated merge with ssh://h...@m5sim.org/m5

2009-09-14 Thread nathan binkert
Are you not using mercurial queues? Generally, you don't get merge changesets when you do. Either way, it's not a major problem, but you can keep the history cleaner if you do. Nate On Mon, Sep 14, 2009 at 3:14 PM, Derek Hower d...@cs.wisc.edu wrote: # HG changeset patch # User Derek Hower

Re: [m5-dev] [PATCH 04 of 18] [mq]: first_patch

2009-09-14 Thread nathan binkert
You are right and that's probably more my mistake than Dereks. What happens is that mercurial crashes whenever it would detect a white-space issue. So, for me to make a patch or commit I hacked the style file, and these changes made it into the patch. Send me the error message and I'll fix it.

Re: [m5-dev] [PATCH] fix x86 loop instruction

2009-09-14 Thread nathan binkert
Gabe, If you didn't know, you can just take his patches and stick them in your queue and use the -u option to qref to add his name to the patch so he gets credit when you push. Also, when people use hg email, you can just take the patch as is and stick it in your queue since it contains all of

Re: [m5-dev] changeset in m5: Syscalls: Implement sysinfo() syscall.

2009-09-16 Thread nathan binkert
I'm glad to see this go in. Has someone stepped up to make sure that all of Vince's patches get in the tree? Nate On Tue, Sep 15, 2009 at 10:37 PM, Vince Weaver vi...@csl.cornell.edu wrote: changeset 30d92d2b66a1 in /z/repo/m5 details:

Re: [m5-dev] [PATCH] fix SPARC udivcc instruction

2009-09-16 Thread nathan binkert
This looks pretty obviously correct to me. I'll add it to my patch queue and make sure that it doesn't break anything. Nate On Mon, Sep 14, 2009 at 10:14 PM, Vince Weaver vi...@csl.cornell.edu wrote: Hello the SPARC udivcc instruction was attempting to read bits 63:32 of a uint32_t, which

Re: [m5-dev] [PATCH] configs: add maxinsts option to SE example

2009-09-16 Thread nathan binkert
This seems fine for me. I'd adjust the commit message though since this will apply to both SE and FS. Nate On Mon, Sep 14, 2009 at 11:29 PM, Korey Sewell ksew...@eecs.umich.edu wrote: # HG changeset patch # User Korey Sewell ksew...@umich.edu # Date 1252996179 14400 # Node ID

Re: [m5-dev] changeset in m5: inorder-smt: remove hardcoded values

2009-09-16 Thread nathan binkert
If possible, put the person's name, not just e-mail in the commit message. i.e. Soumyaroop Roy s...@cse.usf.edu Thanks, Nate On Wed, Sep 16, 2009 at 6:48 AM, s...@cse.usf.edu wrote: changeset 0f7957bb4450 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=0f7957bb4450

Re: [m5-dev] SPARC_SE hook up a few more syscalls

2009-09-16 Thread nathan binkert
Not as far as I know, and no. Looking at this code generally, it would be nice to move the common definitions into a generic base class rather than have 32 bit SPARC inherit from 64 bit SPARC, but that's outside the scope of this patch. In general, there is a lot of repetition in the syscall

Re: [m5-dev] changeset in m5: Rename internal Request fields to start with '_'.

2009-09-16 Thread nathan binkert
This has been in my inbox forever and I figured I should just do it. I guess B is nice since that's the way things are now, the question is, what do we want new code to look like? Maybe it should more be that private/protected members should start with an underscore and publich ones should not.

Re: [m5-dev] changeset in m5: Rename internal Request fields to start with '_'.

2009-09-16 Thread nathan binkert
the accessor. Steve On Wed, Sep 16, 2009 at 7:25 AM, nathan binkert n...@binkert.org wrote: This has been in my inbox forever and I figured I should just do it. I guess B is nice since that's the way things are now, the question is, what do we want new code to look like?  Maybe it should more

Re: [m5-dev] changeset in m5: Rename internal Request fields to start with '_'.

2009-09-16 Thread nathan binkert
http://www.m5sim.org/wiki/index.php/Coding_Style#Naming On Wed, Sep 16, 2009 at 8:19 AM, nathan binkert n...@binkert.org wrote: Sounds good.  I'll update it.  Nate On Wed, Sep 16, 2009 at 8:01 AM, Steve Reinhardt ste...@gmail.com wrote: I think if we're going to say that some fields have

Re: [m5-dev] [PATCH] fix x86 loop instruction

2009-09-16 Thread nathan binkert
I don't think you actually need the explicit (int16_t) cast here. Not a big deal though of course. Nate On Wed, Sep 16, 2009 at 9:22 AM, Vince Weaver vi...@csl.cornell.edu wrote: OK, I think I've fixed this. The key is the line:                code = int16_t simm8 =

Re: [m5-dev] changeset in m5: Rename internal Request fields to start with '_'.

2009-09-16 Thread nathan binkert
It says on the coding guidelines page Lines must be a maximum of 78 characters long. Does that include the space characters used for indentation too? Yes. 78 characters total. There are many reasons that this is a good policy (and is the policy for python, *bsd, linux, etc) Also, what is

[m5-dev] memtest-ruby regression

2009-09-16 Thread nathan binkert
I ran all regressions from a clean tree and the memtest-ruby regression test fails. Can one of the ruby people update it? (I'd just like you guys to sanity check the results). Nate ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] Large Memory support in Ruby

2009-09-18 Thread nathan binkert
- In hindsight, one may see the items in this patch as unrelated, but I initially created this patch with the sole goal of adding large memory support to Ruby.  It turned out I encountered a lot of issues throughout the code, and there are more to come.  That being said, I have no problem

Re: [m5-dev] Large Memory support in Ruby

2009-09-18 Thread nathan binkert
- In hindsight, one may see the items in this patch as unrelated, but I initially created this patch with the sole goal of adding large memory support to Ruby.  It turned out I encountered a lot of issues throughout the code, and there are more to come.  That being said, I have no problem

Re: [m5-dev] Large Memory support in Ruby

2009-09-18 Thread nathan binkert
Darn...I was hoping -X would work.  So by manually creating multiple patches, you mean qnew a few almost empty patches and then cut-and-paste the one patch into those new patch files, right? Or alternatively you can just create the new patch files and import them with 'hg qimport -e'. I

Re: [m5-dev] Large Memory support in Ruby

2009-09-18 Thread nathan binkert
To clarify Nate's statement (since it confused me at first): 'hg qdel -r' (which appears to be aliased to the much more logically named 'hg qfinish' in recent versions) huh, didn't know about qfinish. When you've already got a big monolithic patch like Brad does and want to split it up, then

Re: [m5-dev] Large Memory support in Ruby

2009-09-18 Thread nathan binkert
The record/crecord extension might be useful to handle some of this. crecord looks very cool. Have you used it? Nate ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Large Memory support in Ruby

2009-09-18 Thread nathan binkert
Yes... 'hg qfold' makes it trivial to combine smaller patches into larger ones, so it's better to err on the small side. The one thing about qfold is that is very crudely just sticks the commit messages from the two patches together, so make sure you fix it. Nate

[m5-dev] debug_ss

2009-09-22 Thread nathan binkert
When I run the regression tests, I get a file called debug_ss in my directory that is rather large. I'm assuming that this is some sort of debugging stuff for Ruby. Can whoever added this please remove it ASAP! Nate ___ m5-dev mailing list

[m5-dev] changeset in m5: multiattrdict: make multilevel nesting work pro...

2009-09-22 Thread Nathan Binkert
changeset 9e27313312e6 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=9e27313312e6 description: multiattrdict: make multilevel nesting work properly diffstat: 1 file changed, 5 insertions(+), 1 deletion(-) src/python/m5/util/attrdict.py |6 +- diffs (25

[m5-dev] changeset in m5: python: Move more code into m5.util allow SCons...

2009-09-22 Thread Nathan Binkert
changeset 4c84e771cca7 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=4c84e771cca7 description: python: Move more code into m5.util allow SCons to use that code. Get rid of misc.py and just stick misc things in __init__.py Move utility functions out of

[m5-dev] changeset in m5: scons: add slicc and ply to sys.path and PYTHON...

2009-09-22 Thread Nathan Binkert
changeset 380a32b43336 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=380a32b43336 description: scons: add slicc and ply to sys.path and PYTHONPATH so everyone has access diffstat: 4 files changed, 12 insertions(+), 17 deletions(-) SConstruct | 19

[m5-dev] changeset in m5: params: small cleanup to param description inte...

2009-09-22 Thread Nathan Binkert
changeset 69714e675ee2 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=69714e675ee2 description: params: small cleanup to param description internals diffstat: 2 files changed, 6 insertions(+), 7 deletions(-) src/SConscript |7 +--

[m5-dev] changeset in m5: slicc: Pure python implementation of slicc.

2009-09-22 Thread Nathan Binkert
2009 -0700 +++ b/src/mem/protocol/SConscript Tue Sep 22 18:12:39 2009 -0700 @@ -29,30 +29,56 @@ # Authors: Nathan Binkert import os -import re -import string import sys -from os.path import basename, dirname, exists, expanduser, isdir, isfile -from os.path import join as joinpath - -import

Re: [m5-dev] Cron m5t...@zizzer /z/m5/regression/do-regression --scratch all

2009-09-22 Thread nathan binkert
OK, it looks like changeset 6650 which fixed command line arguments (argc/argv) in MIPS switches up the initiliazation path of the code which in turn creates slightly different stats in instruction count and other things. I think it's OK to update the regression references. OK to update them

Re: [m5-dev] [PATCH 3/7] x86 ioctl changes

2009-09-23 Thread nathan binkert
In general, I'm fine with ignoring things and hoping it works. I think we should probably change the warn to warn_once. Similarly, some of the syscalls that we're ignoring should probably have a warning. Maybe unimplementedFunc should really just be warn_once plus return error? Any other

Re: [m5-dev] [PATCH 4/7] implement time syscall

2009-09-23 Thread nathan binkert
I did send in a patch for this syscall, yes. I used writeBlob to send the value back to memory. Incidentally, I saw Vince needed ftruncate64 to be implemented. I also sent in a patch for that too. Do you want me to do anything with those patches or can they just be added as they are (do I do

[m5-dev] patch/bug tracking

2009-09-23 Thread nathan binkert
Hi everyone, It seems that we're getting more and more contributions from people and we need a better way to manage patches so they don't get dropped on the floor. The biggest problem is probably that a contributor often doesn't seem to hook up with a specific developer to get a given patch into

<    1   2   3   4   5   6   7   8   9   10   >