[gwt-contrib] This patch makes three changes: (issue1093801)

have compiled before. There is no API breakage because of this new constructor. 3. Adds a unit test to exercise the case above. Patch by: amitmanjhi Review by: jat Please review this at http://gwt-code-reviews.appspot.com/1093801/show Affected files: M tools/api-checker/config

[gwt-contrib] Updates the reference api for Api Checker to 2.1. Fixes 2 small bugs in Api Checker. (issue1095801)

Reviewers: jat, Description: Updates the reference api for Api Checker to 2.1. Fixes 2 small bugs in Api Checker. Patch by: amitmanjhi Review by: jat Please review this at http://gwt-code-reviews.appspot.com/1095801/show Affected files: M build.xml A tools/api-checker/config

[gwt-contrib] Remove the onFailure call in case of unauthenticated user. This gets rid of the (issue1061801)

Reviewers: unnurg, robertvawter, Description: Remove the onFailure call in case of unauthenticated user. This gets rid of the multiple popups for a roo-generated GWT app that uses AppEngine. Patch by: amitmanjhi Review by: unnurg,robertvawter Please review this at http://gwt-code

[gwt-contrib] Ignore CSS errors and warnings while running htmlUnit tests. This stops console (issue1032801)

=3090806group_id=47038atid=448266 Patch by: amitmanjhi Review by: rjrjr,jlabanca Please review this at http://gwt-code-reviews.appspot.com/1032801/show Affected files: M user/src/com/google/gwt/junit/RunStyleHtmlUnit.java Index: user/src/com/google/gwt/junit/RunStyleHtmlUnit.java

[gwt-contrib] Send an update notification to a stale client by comparing the incoming version (issue959801)

number is only incremented on a real change. Will fix the test harness shortly in a follow-up patch. Patch by: amitmanjhi Review by: rjrjr, robertvawter Please review this at http://gwt-code-reviews.appspot.com/959801/show Affected files: M user/src/com/google/gwt/requestfactory/server

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

http://gwt-code-reviews.appspot.com/959801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

http://gwt-code-reviews.appspot.com/959801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

http://gwt-code-reviews.appspot.com/959801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixed the serialization bug that the version numbers were not being sent back (issue930802)

-- the serialization bug masked the test harness bug. Patch by: amitmanjhi Review by: robertvawter Please review this at http://gwt-code-reviews.appspot.com/930802/show Affected files: M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java M user/test/com/google/gwt/requestfactory

[gwt-contrib] Re: Fixed the serialization bug that the version numbers were not being sent back (issue930802)

http://gwt-code-reviews.appspot.com/930802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Changes to the expenses sample to match the GWT changes in http://code.google.com/p/google-web-t... (issue932801)

Reviewers: rjrjr, Description: Changes to the expenses sample to match the GWT changes in http://code.google.com/p/google-web-toolkit/source/detail?r= Patch by: amitmanjhi Review by: rjrjr (tbr) Please review this at http://gwt-code-reviews.appspot.com/932801/show Affected files: M

[gwt-contrib] Fix the hack in RequestFactoryGenerator. (issue935801)

Reviewers: rice, Description: Fix the hack in RequestFactoryGenerator. Patch by: amitmanjhi Review by: rice Please review this at http://gwt-code-reviews.appspot.com/935801/show Affected files: M user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java Index: user

[gwt-contrib] Add tests to verify that proxies created on the client side can be sent across the wire, both i... (issue936801)

by: amitmanjhi Review by: rjrjrj Please review this at http://gwt-code-reviews.appspot.com/936801/show Affected files: M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java M user/test/com/google/gwt/requestfactory

[gwt-contrib] Re: Removed the acquire event, renamed WriteOperation to DataEvent, renamed CREATE to PERSIST. (issue892802)

http://gwt-code-reviews.appspot.com/892802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed all the Request sub-types. Fixed the generator and the server code where we were relying... (issue926801)

http://gwt-code-reviews.appspot.com/926801/diff/1/12 File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/926801/diff/1/12#newcode241 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:241: if

[gwt-contrib] Fixed stale error messages. DataTransferObject has been renamed to ProxyFor annotation. (issue927801)

Reviewers: rjrjr, Description: Fixed stale error messages. DataTransferObject has been renamed to ProxyFor annotation. Patch by: amitmanjhi Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/927801/show Affected files: M user/src/com/google/gwt

[gwt-contrib] Re: Use generics for EntityProxyId (issue888802)

LGTM except noted below. http://gwt-code-reviews.appspot.com/02/diff/1/22 File user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java (right): http://gwt-code-reviews.appspot.com/02/diff/1/22#newcode191

[gwt-contrib] Re: Resolves ROO-1447. (issue921801)

LGTM. I just realized that I had 2 comments on the FavoritesWidget, other than the on-phone comments about DeltaValueStore. Just nits. http://gwt-code-reviews.appspot.com/921801/diff/8001/9005 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java

[gwt-contrib] Re: Cleanup for Roo-1401. Refactored the commit method so that it is easier for it (issue920801)

http://gwt-code-reviews.appspot.com/920801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove version from the public api. (issue878802)

Reviewers: rjrjr, Description: Remove version from the public api. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/878802/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java M user/src/com

[gwt-contrib] Fix a corner case in getProxyId. Minor cleanup. (issue914801)

Reviewers: robertvawter, Description: Fix a corner case in getProxyId. Minor cleanup. Patch by: amitmanjhi Review by: robertvawter Please review this at http://gwt-code-reviews.appspot.com/914801/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl

[gwt-contrib] Re: Fix a corner case in getProxyId. Minor cleanup. (issue914801)

http://gwt-code-reviews.appspot.com/914801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixed https://jira.springsource.org/browse/ROO-1429 (issue915801)

Reviewers: rjrjr, Description: Fixed https://jira.springsource.org/browse/ROO-1429 1. Renamed setFoo - putFoo, isFoo - hasFoo, getFoo - foo() in ProxyImpl. 2. Added a bang at the beginning of all meta-data fields in the response. Patch by: amitmanjhi Review by: rjrjr Please review this at http

[gwt-contrib] Re: Fixed https://jira.springsource.org/browse/ROO-1429 (issue915801)

http://gwt-code-reviews.appspot.com/915801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds test that events can be registered and that they fire correctly. (issue878803)

LGTM other than some nits below. http://gwt-code-reviews.appspot.com/878803/diff/1/2 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/878803/diff/1/2#newcode114

[gwt-contrib] Re: Adds test that events can be registered and that they fire correctly. (issue878803)

LGTM++ http://gwt-code-reviews.appspot.com/878803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Cleanup for Roo-1401. Refactored the commit method so that it is easier for it (issue920801)

Reviewers: rjrjr, robertvawter, Description: Cleanup for Roo-1401. Refactored the commit method so that it is easier for it to process additional WriteOperations. Patch by: amitmanjhi Review by: robertvawter Please review this at http://gwt-code-reviews.appspot.com/920801/show Affected files

[gwt-contrib] Re: Resolves ROO-1447. (issue921801)

Partial review. I looked at the DeltaValueStore, Proxy* and AbstractRequest code in user and it looks good except one thing -- I don't think the commit method should be putting values in the deltaValueStore. We don't know for sure, if all fields have been persisted. And the entity value will be

[gwt-contrib] Re: Simplifies the RequestObject api: (issue880801)

The patch is missing a test that we discussed -- the test posts a sequence of edits and verifies that sane results are returned. http://gwt-code-reviews.appspot.com/880801/diff/3001/4001 File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (left):

[gwt-contrib] Remove SyncResults. Use EntityProxyId and RequestFactory.find(EntityProxyId) (issue887802)

Reviewers: rjrjr, Description: Remove SyncResults. Use EntityProxyId and RequestFactory.find(EntityProxyId) instead of the id field in EntityProxy. Please review this at http://gwt-code-reviews.appspot.com/887802/show Affected files: M

[gwt-contrib] Re: Remove SyncResults. Use EntityProxyId and RequestFactory.find(EntityProxyId) (issue887802)

http://gwt-code-reviews.appspot.com/887802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes https://jira.springsource.org/browse/ROO-1213 - Hide Property from public API. (issue842803)

LGTM http://gwt-code-reviews.appspot.com/842803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Initial implementation of a general purpose Find service based on an (issue878801)

Reviewers: rjrjr, robertvawter, Description: Initial implementation of a general purpose Find service based on an EntityProxyId. Added tests that also check with predicates. Patch by: amitmanjhi Review by: rjrjr, robertvawter Please review this at http://gwt-code-reviews.appspot.com/878801

[gwt-contrib] Re: Initial implementation of a general purpose Find service based on an (issue878801)

http://gwt-code-reviews.appspot.com/878801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Extract violations from being a field in sideEffects to a top-level field. Removed the handling ... (issue846802)

Reviewers: rjrjr, robertvawter, Description: Extract violations from being a field in sideEffects to a top-level field. Removed the handling of violations from DeltaValuesStoreJsonImpl.onCommit method. Will do further cleanup once Receiver has a onViolations method. Patch by: amitmanjhi Review

[gwt-contrib] Re: Updates RequestFactory's Receiver type with onViolation() and onFailure() methods, making it an ... (issue855802)

More comments: - Add tests to ensure that onViolation and onError methods are called? - Additionally, remove the violations field from SyncResult and fix AbstractProxyEditActivity? - Similarly, the tests in RequestFactoryTest that check for violations will need to be fixed.

[gwt-contrib] Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE event and implemented the... (issue860801)

Reviewers: rjrjr, Description: Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE event and implemented the copy-on-write semantics. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/860801/show Affected files

[gwt-contrib] Renamed getStableId() to stableId() (issue857801)

Reviewers: rjrjr, Description: Renamed getStableId() to stableId() Patch by: amitmanjhi Review (and suggested) by: rjrjr Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/857801/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl

[gwt-contrib] Renamed *Record* to *Proxy*. Also renamed variables in a few classes. (issue825802)

Reviewers: rjrjr, Description: Renamed *Record* to *Proxy*. Also renamed variables in a few classes. Renamed DataTransferObject - ProxyFor. patch by: amitmanjhi Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/825802/show Affected files: M samples/dynatablerf

[gwt-contrib] Re: Renamed *Record* to *Proxy*. Also renamed variables in a few classes. (issue825802)

http://gwt-code-reviews.appspot.com/825802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Deletes the bikeshed. (issue816801)

LGTM. RIP bikeshed. On 2010/08/30 22:56:24, rjrjr wrote: http://gwt-code-reviews.appspot.com/816801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Deletes the bikeshed. (issue816801)

LGTM http://gwt-code-reviews.appspot.com/816801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Merged the valuestore package into the requestfactory package. Removed all (issue800801)

Reviewers: rjrjr, Description: Merged the valuestore package into the requestfactory package. Removed all references to the valuestore module. Patch by: amitmanjhi Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/800801/show Affected files: M bikeshed/src/com

[gwt-contrib] Removed the doc references for ValueStore. (issue792802)

Reviewers: rjrjr, Description: Removed the doc references for ValueStore. Patch by: amitmanjhi Review by: rjrjr (TBR) Please review this at http://gwt-code-reviews.appspot.com/792802/show Affected files: M doc/build.xml Index: doc/build.xml

[gwt-contrib] Get rid of the dead code in DeltaValueStoreJsonImpl. (issue777802)

Reviewers: rjrjr, Description: Get rid of the dead code in DeltaValueStoreJsonImpl. Patch by: amitmanjhi Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/777802/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl

[gwt-contrib] Re: AbstractEditView now requests all the paths it needs (issue786802)

LGTM http://gwt-code-reviews.appspot.com/786802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support for Record types as method params in RequestFactory, bug fixes (issue767802)

http://gwt-code-reviews.appspot.com/767802/diff/1/3 File user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java (right): http://gwt-code-reviews.appspot.com/767802/diff/1/3#newcode93 user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java:93: eval(xyz= + json);

[gwt-contrib] Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 (issue768801)

Reviewers: Ray Ryan, Description: Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 Fixed the comment in RequestFactoryJreSuite and added a test to RecordKeyTest. Patch by: amitmanjhi Review by: rjrjr Please review this at http://gwt-code

[gwt-contrib] Re: Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 (issue768801)

http://gwt-code-reviews.appspot.com/768801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds (unused by this patch, but needed in forthcoming history code) (issue760801)

LGTM On 2010/08/12 18:10:06, Ray Ryan wrote: http://gwt-code-reviews.appspot.com/760801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixed the create bug by using the futureId field in RecordKey and RecordImpl (issue765801)

Reviewers: Ray Ryan, Description: Fixed the create bug by using the futureId field in RecordKey and RecordImpl Patch by: amitmanjhi Review by: rjrjr(desk review) Please review this at http://gwt-code-reviews.appspot.com/765801/show Affected files: M user/src/com/google/gwt/requestfactory

[gwt-contrib] Fix the equals method for RecordKey. Forgot to make this change in the just (issue766801)

Reviewers: Ray Ryan, Description: Fix the equals method for RecordKey. Forgot to make this change in the just submitted patch. Added tests for it, and organized other tests in suites. Patch by: amitmanjhi Review by: rjrjr (tbr) Please review this at http://gwt-code-reviews.appspot.com/766801

[gwt-contrib] Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

Reviewers: cromwellian, Ray Ryan, robertvawter, Description: Enables setter methods to be directly called on Record/proxy objects, instead of going through a DeltaValueStore. Also removes the now unnecessary DeltaValueStore from the public api. Patch by: amitmanjhi Review by: rjrjr, cromwellian

[gwt-contrib] Re: Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

http://gwt-code-reviews.appspot.com/752802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

http://gwt-code-reviews.appspot.com/752802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

http://gwt-code-reviews.appspot.com/752802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Removed the RequestDataManager class that is no longer used. (issue743801)

Reviewers: cromwellian, Description: Removed the RequestDataManager class that is no longer used. Patch by: amitmanjhi Review by: cromwellian (tbr) Please review this at http://gwt-code-reviews.appspot.com/743801/show Affected files: D user/src/com/google/gwt/requestfactory/shared/impl

[gwt-contrib] Re: Fix datatype renderers to handle nulls properly for some primitive types. (issue725804)

LGTM http://gwt-code-reviews.appspot.com/725804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Moved the create method from DeltaValueStore, used Long futureIds. Deleted ValueStore interface ... (issue721805)

Reviewers: Ray Ryan, Description: Moved the create method from DeltaValueStore, used Long futureIds. Deleted ValueStore interface and made ValueStoreJsonImpl non-public. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/721805/show

[gwt-contrib] Re: Fix RPC charset parameter tests (issue723803)

LGTM http://gwt-code-reviews.appspot.com/723803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Another step towards making instance methods real. The interface on the client is pretty much wh... (issue710803)

on the server. (The hack was already there, this patch just moves it around.) Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/710803/show Affected files: M bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java M

[gwt-contrib] Re: Fix support for null fields and Boolean type types in RequestFactory. (issue739801)

http://gwt-code-reviews.appspot.com/739801/diff/3001/1009 File user/src/com/google/gwt/app/rebind/EditorSupportGenerator.java (right): http://gwt-code-reviews.appspot.com/739801/diff/3001/1009#newcode457 user/src/com/google/gwt/app/rebind/EditorSupportGenerator.java:457: sw.indent(); Lose this

[gwt-contrib] Re: Fix support for null fields and Boolean type types in RequestFactory. (issue739801)

LGTM http://gwt-code-reviews.appspot.com/739801/diff/15001/16004 File user/src/com/google/gwt/valuestore/shared/impl/RecordJsoImpl.java (right): http://gwt-code-reviews.appspot.com/739801/diff/15001/16004#newcode136 user/src/com/google/gwt/valuestore/shared/impl/RecordJsoImpl.java:136: LGTM++

[gwt-contrib] Re: Adds partial support for related fields to RequestFactory. Right now, getters of such fields alw... (issue741801)

LGTM. http://gwt-code-reviews.appspot.com/741801/diff/1/5 File user/test/com/google/gwt/valuestore/server/SimpleBar.java (right): http://gwt-code-reviews.appspot.com/741801/diff/1/5#newcode25 user/test/com/google/gwt/valuestore/server/SimpleBar.java:25: */ Stale comment?

[gwt-contrib] Made the error messages thrown in case of GWTTestCase timeouts more informative, as requested in (issue734801)

Reviewers: mmendez, Description: Made the error messages thrown in case of GWTTestCase timeouts more informative, as requested in http://code.google.com/p/google-web-toolkit/issues/detail?id=4099 Patch by: amitmanjhi Review by: mmendez Please review this at http://gwt-code-reviews.appspot.com

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

Overall, looks good. Thanks for the patch Fred. Minor refactoring suggestions below. Instead of making checkContentType and checkCharacterEncoding public and deprecated, would it be better to add another option of expectedContentType to readContentAsUtf8, and just do everything there? (the

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

I like the refactoring. Some more nits below. Please feel free to submit after fixing them. LGTM http://gwt-code-reviews.appspot.com/674804/diff/9001/10002 File user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java (right):

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

LGTM http://gwt-code-reviews.appspot.com/674804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixed 2 TODOs: (a) removed the RequestFactory variable from AbstractRecordEditActivity, (issue731802)

Reviewers: Ray Ryan, Description: Fixed 2 TODOs: (a) removed the RequestFactory variable from AbstractRecordEditActivity, (b) Removed all the nested interfaces from RequestFactory. Patch by: amitmanjhi Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/731802/show

[gwt-contrib] Re: Implement ROO-933 and ROO-935. Handle java.lang.{Byte/Short/Character/Integer/Long/BigDecimal/Bi... (issue700802)

LGTM. Since you have already taken care of the merge error, there are only minor nits below. Plus, the comments I sent you earlier. Please submit after these changes. One other thing we discussed was to add a RequestFactoryTestSuite class. If you'd like, you can just add a TODO for now.

[gwt-contrib] Partial commit towards making instance methods real. Merged the execution paths (issue726801)

Reviewers: Ray Ryan, Description: Partial commit towards making instance methods real. Merged the execution paths for the syncRequest and RequestObject. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/726801/show Affected files

[gwt-contrib] DynatableRf refactoring in response to http://code.google.com/p/google-web-toolkit/source/detail... (issue674803)

Reviewers: Ray Ryan, Description: DynatableRf refactoring in response to http://code.google.com/p/google-web-toolkit/source/detail?r=8436 Patch by: amitmanjhi Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/674803/show Affected files: M samples/dynatablerf/src

[gwt-contrib] Re: Implement ROO-933 and ROO-935. Handle java.lang.{Byte/Short/Character/Integer/Long/BigDecimal/Bi... (issue700802)

I cursorily looked at the patch. It looks good but it seems you forgot to upload the changes to the files in the bikeshed dir. I also had a few minor comments, noted below. Let me know when you update the complete patch. http://gwt-code-reviews.appspot.com/700802/diff/2001/3004 File

[gwt-contrib] Re: A new version of DynaTable that uses RequestFactory instead of GWT RPC. (issue710801)

The multiple files in user/test with names ending in .orig should probably be excluded. On 2010/07/22 22:17:53, Ray Ryan wrote: http://gwt-code-reviews.appspot.com/710801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: A new version of DynaTable that uses RequestFactory instead of GWT RPC. (issue710801)

There is a lot of copying going here which is bad. Would this be better done by adding just the new classes to the DynaTable sample, and having another gwt.xml in the DynaTable sample. The two gwt.xml could then pull just the subset of files they require.

[gwt-contrib] Moved the maven_script.sh from bikeshed/scripts to tools/scripts (issue666801)

Reviewers: fabbott, Description: Moved the maven_script.sh from bikeshed/scripts to tools/scripts Patch by: amitmanjhi Review by: fabbott (TBR) Please review this at http://gwt-code-reviews.appspot.com/666801/show Affected files: D bikeshed/scripts/maven_script.sh A tools/scripts

[gwt-contrib] Re: Moved the maven_script.sh from bikeshed/scripts to tools/scripts (issue666801)

http://gwt-code-reviews.appspot.com/666801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Removed the dependency of SampleDataPopulator on gwt-dev by inlining the dependency. (issue652802)

by: amitmanjhi Review by: fabbott (TBR) Please review this at http://gwt-code-reviews.appspot.com/652802/show Affected files: M bikeshed/scripts/dataPopulator M user/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java Index: bikeshed/scripts/dataPopulator

[gwt-contrib] Wholesale move of the app, requestfactory, and valuestore packages from the bikeshed dir to user... (issue660802)

Reviewers: fabbott, Description: Wholesale move of the app, requestfactory, and valuestore packages from the bikeshed dir to user dir. The only other changes are to user/build.xml, bikeshed/scripts/maven_script.sh, and eclipse/user/.classpath Review by: fabb...@google.com Please review this at

[gwt-contrib] Drop the bikeshed jar from the GWT distribution. (issue665801)

Reviewers: rdayal, Jason Parekh, Description: Drop the bikeshed jar from the GWT distribution. Patch by: amitmanjhi Review by: rdayal, jasonparekh Please review this at http://gwt-code-reviews.appspot.com/665801/show Affected files: M build.xml Index: build.xml

[gwt-contrib] Bye Bye Boilerplate patch. No static configuration required for servlet (issue661801)

Reviewers: cromwellian, Description: Bye Bye Boilerplate patch. No static configuration required for servlet beyond @Service annotations on request interfaces and @DataTransferObject annotations on Record types. TOKEN no longer required on Record types, as the class itself is used as a token.

[gwt-contrib] Re: Bye Bye Boilerplate patch. No static configuration required for servlet (issue661801)

This time with the correct URL http://gwt-code-reviews.appspot.com/648802/show On 2010/06/23 23:13:19, amitmanjhi wrote: On 2010/06/23 23:07:45, amitmanjhi wrote: Patch is updated version of Ray Cromwell's original patch: http://gwt-code-reviews.appspot.com/661801 http://gwt-code

[gwt-contrib] Added the api warning for newly added classes. (issue619804)

Reviewers: Ray Ryan, Description: Added the api warning for newly added classes. Patch by: amitmanjhi Review by: rjrjr (tbr) Please review this at http://gwt-code-reviews.appspot.com/619804/show Affected files: M bikeshed/src/com/google/gwt/requestfactory/server

[gwt-contrib] Added a guard against IndexOutOfBoundsException (issue613802)

Reviewers: jlabanca, Description: Added a guard against IndexOutOfBoundsException Review by: jlaba...@google.com Please review this at http://gwt-code-reviews.appspot.com/613802/show Affected files: M bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java Index:

[gwt-contrib] Adds more logging to JUnitShell. The redundant logging will be removed later. (issue611802)

Reviewers: scottb, jat, Description: Adds more logging to JUnitShell. The redundant logging will be removed later. Patch by: amitmanjhi Review by: scottb, jat Please review this at http://gwt-code-reviews.appspot.com/611802/show Affected files: M dev/core/src/com/google/gwt/dev

[gwt-contrib] Re: Adds more logging to JUnitShell. The redundant logging will be removed later. (issue611802)

http://gwt-code-reviews.appspot.com/611802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test f... (issue632802)

http://gwt-code-reviews.appspot.com/632802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test f... (issue632802)

Reverted changes to DevMode, DevModeBase. Sorry, I did not get to JUnitHostImpl's failure in deserializing exceptions. On 2010/06/17 20:28:14, amitmanjhi wrote: http://gwt-code-reviews.appspot.com/632802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Added a warning to the javadoc of each src file and to package.html in the app, requestfactory, ... (issue625801)

Reviewers: Ray Ryan, Description: Added a warning to the javadoc of each src file and to package.html in the app, requestfactory, and valuestore modules. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/625801/show Affected files: M

[gwt-contrib] Deleted HasPages, HasValueMap, and ValueListBox since they are not being used. (issue619802)

Reviewers: Ray Ryan, Description: Deleted HasPages, HasValueMap, and ValueListBox since they are not being used. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/619802/show Affected files: D bikeshed/src/com/google/gwt/user/client/ui/HasPages.java D

[gwt-contrib] Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test f... (issue632802)

Reviewers: scottb, jat, Lex, Description: Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test failures. Please review this at http://gwt-code-reviews.appspot.com/632802/show Affected files: M dev/core/src/com/google/gwt/dev/DevMode.java M

[gwt-contrib] Adds tests to ValueStore, specifically RecordJsoImpl and DeltaValueStore. (issue621801)

Reviewers: Ray Ryan, Description: Adds tests to ValueStore, specifically RecordJsoImpl and DeltaValueStore. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/621801/show Affected files: M

[gwt-contrib] Moved Moved RecordToTypeMap and SyncResult from RequestFactory to ValueStore. (issue570801)

Reviewers: Ray Ryan, Description: Moved Moved RecordToTypeMap and SyncResult from RequestFactory to ValueStore. Added a token first test for the ValueStore module. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/570801/show Affected files: D

[gwt-contrib] Moved the Activity subclasses to the App module to break the circular dependency between App and... (issue571801)

Reviewers: Ray Ryan, Description: Moved the Activity subclasses to the App module to break the circular dependency between App and ValueStore. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/571801/show Affected files: A

[gwt-contrib] Re: Breaks the circular dependencies between app, user, valuestore and (issue522803)

LGTM++ for cleanup. Few nits in comment below. Is the com/google/gwt/app/util dir empty now? If so, it should be removed and so should the following line in App.gwt.xml source path=util / http://gwt-code-reviews.appspot.com/522803/diff/1/44 File

[gwt-contrib] Deleting a managed entity makes all its fields null. Updated the code to account for this behavior. (issue520801)

Reviewers: Ray Ryan, Description: Deleting a managed entity makes all its fields null. Updated the code to account for this behavior. Please review this at http://gwt-code-reviews.appspot.com/520801/show Affected files: M

[gwt-contrib] updated the large dataset. Plus misc cleanups: nixed unused import, added copyright header (issue521801)

Reviewers: Ray Ryan, Description: updated the large dataset. Plus misc cleanups: nixed unused import, added copyright header Patch by: amitmanjhi Review by: rjrjr (tbr) Please review this at http://gwt-code-reviews.appspot.com/521801/show Affected files: M trunk/bikeshed/scripts

[gwt-contrib] Added error-checking to SampleDataPopulator and updated the example in dataPopulator. (issue511801)

Reviewers: Ray Ryan, Description: Added error-checking to SampleDataPopulator and updated the example in dataPopulator. Patch by: amitmanjhi Review by: rjrjr (TBR) Please review this at http://gwt-code-reviews.appspot.com/511801/show Affected files: M trunk/bikeshed/scripts/dataPopulator

[gwt-contrib] The generated data was missing an Expense - Report link. Fixed it. Updated the sample Json data. (issue512801)

Reviewers: jgw, Description: The generated data was missing an Expense - Report link. Fixed it. Updated the sample Json data. Patch by: amitmanjhi Review by: jgw (tbr) Please review this at http://gwt-code-reviews.appspot.com/512801/show Affected files: M trunk/bikeshed/scripts

[gwt-contrib] Configure the logging level to not show the warning by default. (issue495803)

Reviewers: Ray Ryan, Description: Configure the logging level to not show the warning by default. Patch by: amitmanjhi Review by: rjrjr (tbr) Please review this at http://gwt-code-reviews.appspot.com/495803/show Affected files: M trunk/bikeshed/scripts/dataPopulator Index: trunk/bikeshed

  1   2   >