Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5146
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5064
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5152
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5064#discussion_r156324988
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java
---
@@ -54,7 +55,12
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5147
[FLINK-8241][tests] Remove ResultPartitionWriter-related "@PrepareForTest"
annotations
## What is the purpose of the change
This is a cleanup PR that removes usages of
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5115
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5099
@greghogan I've addressed your comments.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156052191
--- Diff: docs/monitoring/metrics.md ---
@@ -329,11 +329,11 @@ or by assigning unique names to jobs and operators.
Metrics can be exposed to an external
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156051769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -44,7 +48,13 @@
private static
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5146
[FLINK-8235][build] Spotbugs exclusion file path now absolute
## What is the purpose of the change
With this PR the spotbugs plugin can now be run on a single sub-module. The
path
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5134
Why do you want to add these to flink when they are only used by an
external repository? Wouldn't it make sense to consolidate all benchmarking
code to the flink-benchmark repo?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5052
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155501188
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5052
Since you found no errors I would like to merge it as is (including the
changes to `rest_api.md`) and iterate upon it in follow-ups. My goal was not to
provide a picture-perfect documentation
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r155327970
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5062
ð
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155224199
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -224,6 +225,7
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155224312
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -234,9 +236,14
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155225199
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r155210876
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r155210751
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5120
@aljoscha Did you forget to close this PR?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
After adding kafka09/cassandra, `slf4j-api` and `force-shading` where
included in the jar.
I've added exclusions for these dependencies to the shade-plugin
configuration, as well
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r155185291
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/MetricGroupTest.java
---
@@ -78,6 +81,138 @@ public void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5115
correct link:
https://github.com/zentol/flink/commit/85fe8706e09a4a652b4d4b13f8d0283faf74334c
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r155178904
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/MetricGroupTest.java
---
@@ -78,6 +81,138 @@ public void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5100
Closing due to revised approach showcased in #5125.
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5100
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
Updated the PR.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5125
There are a few reason for that:
1) It keeps the `Outputs` immutable. We need all metrics to be available up
front before creating the output, but since the OperatorIOMetricGroup is
created
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r155004802
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154999100
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154998623
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154998584
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154955042
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Github user zentol commented on the pull request:
https://github.com/apache/flink/commit/dd48a40ab7b3a721c7c78a4b0d6efad5b50f947e#commitcomment-26062390
In
flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerLeaderSessionIDITCase.scala:
In
flink
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154965270
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -441,14 +441,14 @@ private MetricGroup
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154950988
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -191,9 +196,12
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154952648
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/AbstractServerTest.java
---
@@ -66,14
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154950558
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154947643
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154946902
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -416,10 +441,14 @@ public MetricGroup addGroup
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5098
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5098
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5125
[WIP][FLINK-4812][metrics] Expose currentLowWatermark for all operators
This is a revised WIP version of #5100.
## What is the purpose of the change
With this PR all operators
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
That should work.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154904663
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
that's what we're already doing (well technicall yin the `pre-package`
phase).
Thing is that the `package` phase is _always_ executed before `verify`, and
we can't get around that aside from
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
Note that the current approach also prints a warning if `mvn verify` is
executed.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154888733
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -133,7 +134,7
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5098#discussion_r154880974
--- Diff: flink-metrics/flink-metrics-datadog/pom.xml ---
@@ -88,6 +65,7 @@ under the License.
shade
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
As for failing the build, I don't like that option, even if I find a way to
do it. We _do not know_ how such a kill-switch would interact with various IDEs
and tools.
What we could do
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/3916
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
I'll add flink-clients again with a comment.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
`flink-core` is a direct dependency due to the usage of the
[Collector](https://github.com/apache/flink/blob/master/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5120
is the exclusion from flink-dist still necessary?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3916
updated version: #5119
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5119
[FLINK-6590] Integrate automatic docs generation
Rebased version of #3916; builds on #5052.
This PR partially integrates the docs generation introduced in
FLINK-5781/#3495 into the actual
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154665095
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup
Github user zentol commented on the pull request:
https://github.com/apache/flink/commit/aa1f8f31c01d8fd4ae5bdaaf48c44aadc221#commitcomment-26033587
In flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java:
In flink-yarn/src/test/java/org/apache/flink/yarn
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5076#discussion_r154648566
--- Diff: pom.xml ---
@@ -581,6 +581,20 @@ under the License.
0.9.10
test
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5092
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5102
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154646500
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5118
[FLINK-8193][quickstart] Cleanup quickstart poms
## What is the purpose of the change
This PR addresses 2 problems in the quick start poms:
1) The poms declared unused dependencies
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154598676
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -43,8 +46,8 @@
private static
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5071
merged, could you close the PR? Thanks!
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5071
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5110
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5099
We could also make `metrics.reporters` an optional list of reporters to
enable; by default we include all reporters we can find. This would be more
user-friendly since you wouldn't have to modify
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5099
only checking for the class makes sense.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154315071
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ---
@@ -25,20 +25,9 @@
public class MetricOptions
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5103
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5103
feel free to merge it.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5071#discussion_r153923624
--- Diff: docs/monitoring/metrics.md ---
@@ -94,8 +94,8 @@ Alternatively you can also use your own `Counter`
implementation:
{% highlight java
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5100
yes, we _could_ setup all IO metrics in the operator chain. But that will
require some more changes there since the methods there never access 2
operators at the same time.
For a chain A-&g
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5103
[FLINK-7595] [Savepoints] Allow removing stateless operators
This is a fixed version of #4651 for 1.4. It adds some checkstyle fixes and
modifies the SavepointLoaderTest to actually have
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5071#discussion_r153839062
--- Diff: docs/monitoring/metrics.md ---
@@ -61,9 +63,35 @@ public class MyMapper extends RichMapFunction<String,
String> {
}
{% endhig
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5071#discussion_r153838811
--- Diff: docs/monitoring/metrics.md ---
@@ -61,9 +63,35 @@ public class MyMapper extends RichMapFunction<String,
String> {
}
{% endhig
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5066
will fix the checkstyle violation on the way.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5066
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5101
Can we also remove this bit
```
// temporary hack for FLIP-6 since slot-sharing isn't implemented yet
jobGraph.setAllowQueuedScheduling(true);
```
from the `RestClusterClient`?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5100
the coupling of input to output gauge becomes rather tricky. The input
gauge must be reachable in `Stream[Two]InputProcessor`,
`OperatorChain#createChainedOperator`, and the output gauge
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5100
ah, weÃ#re doing the same already for `numRecordsIn` maybe we can do
this after all.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4651
Rebased on top of master, let's see what travis says. Didn't get any
conflicts so ð¤ .
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5100
You can't measure input metrics in the ChainingOutput (nicely) since for a
chain A->B does B at no point have access to the output of A.
We would need to have the task setup all waterm
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5100
input processors only exist once per task, no? So we wouldn't measure them
at the operator level.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153799197
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -166,28 +167,57
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153801913
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -422,20 +467,31
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153804310
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153801762
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -422,20 +467,31
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153793789
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAAbstractQueryableStateTestBase.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153794621
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153788979
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -95,15 +97,20
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153798768
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -166,28 +167,57
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153804523
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153794265
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyImpl.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153786058
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -300,7 +333,7
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153799484
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
1501 - 1600 of 5225 matches
Mail list logo
