Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
On Thu, Oct 20, 2011 at 7:35 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: I'm thinking a bit about how I can draw up some graphs on this... Graphing number of commits is easy, but graphing the review is difficult. Before we got Gerrit going I decided that I could no longer

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Peter Stuge
Øyvind Harboe wrote: Some graphing I've been thinking about: - plot a number that shows the redundancy in maintainers. I.e. are we relying on a single maintainer or are there multiple maintainers I've so far taken infinitely many more commits from Gerrit into openocd.git than before. Much

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
On Thu, Oct 20, 2011 at 8:38 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: Some graphing I've been thinking about: - plot a number that shows the redundancy in maintainers. I.e. are we relying on a single maintainer or are there multiple maintainers I've so far taken infinitely

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Jon Povey
openocd-development-boun...@lists.berlios.de wrote: Jon Povey wrote: this additional barrier to contributing does put me and others off contributing in future. Using Git is also a barrier for some, perhaps even for many. Gerrit is new, so sure there will be resistance. Maybe sometime it will

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Jon Povey
Øyvind Harboe wrote: If you want to spend the time taking other people's patches and pushing them to Gerrit so they don't have to, go right ahead. Obviously not if I am not in a hurry to take the time to setup for gerrit even for myself. Don't think the sarcasm was helpful there. We're

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
Actually, in some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting patches into git and now we don't lift them into Gerrit. Same thing, except with Gerrit contributors (or anyone) have the option of lifting patches into Gerrit themselves.

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Attila Kinali
On Thu, 20 Oct 2011 07:18:18 +0200 Peter Stuge pe...@stuge.se wrote: You need an OpenID from somewhere (let me know if you want one from me) You need to register on a web page and pick a username You need to set an HTTP password or upload a public SSH key The above takes not two minutes.

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
What exactly is checked by jenkins currently? I suggest at least one build with the default ./configure (no options) and one with as many ./configure options enabled as is possible on the build host. It's very early days still and we're still sorting out problems. We have ambitions to do lots

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
Please read HACKING and post to Gerrit. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Freddie Chopin
On 2011-10-19 19:50, Øyvind Harboe wrote: Please read HACKING and post to Gerrit. Sorry, I don't have time to do so because: 1. The patch is trivial 2. I use git in Linux hosted in VitualBox, where emailing patches kinda does not work 3. My knowledge of Linux and Git is minimal So basically

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
If you don't have time to work on OpenOCD, then I don't have any problems with that. The world is full of smart people who could have, but don't have time to, contribute to OpenOCD. If you do want to spend some time on OpenOCD, then I urge you to have a look at what Gerrit+Jenkins does for the

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Peter Stuge
Freddie Chopin wrote: Please read HACKING and post to Gerrit. I second this. Sorry, I don't have time to do so because: Sorry, noone has time to deal with your patch. 1. The patch is trivial It might seem so, but actually it's not. It has multiple logical changes combined in a single

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Jon Povey
openocd-development-boun...@lists.berlios.de wrote: If you don't have time to work on OpenOCD, then I don't have any problems with that. The world is full of smart people who could have, but don't have time to, contribute to OpenOCD. [...] If this means that we loose those contributors who

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Peter Stuge
Jon Povey wrote: this additional barrier to contributing does put me and others off contributing in future. Using Git is also a barrier for some, perhaps even for many. Gerrit is new, so sure there will be resistance. Maybe sometime it will be just as common as Git itself. I think the learning

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
If you want to spend the time taking other people's patches and pushing them to Gerrit so they don't have to, go right ahead. You do not have to be an OpenOCD maintainer to do this, anyone can push anyones patches to Gerrit for review. I don't expect you to step up to take such a role, nor do I

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Peter Stuge
Øyvind Harboe wrote: I'm thinking a bit about how I can draw up some graphs on this... Graphing number of commits is easy, but graphing the review is difficult. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de