Re: [HACKERS] Some bugs in psql_complete of psql

Hello, thank you for committing this. At Sat, 16 Jan 2016 21:09:26 -0500, Peter Eisentraut wrote in <569af7d6.9090...@gmx.net> > On 1/12/16 9:46 PM, Peter Eisentraut wrote: > > On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote: > >> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch >

Re: [HACKERS] count_nulls(VARIADIC "any")

On 25/01/16 19:57, Pavel Stehule wrote: Marco is a author of this patch, so - Marco, please, send final version of this patch I don't really care about the tests. Can we not use the v5 patch already in the thread? As far as I could tell there were no reviewer's comments on it anymore.

Re: [HACKERS] Add generate_series(date,date) and generate_series(date,date,integer)

On 26.01.2016 07:52, Simon Riggs wrote: Imagine for example a script that in some rare cases passes happens to pass infinity into generate_series() - in that case I'd much rather error out than wait till the end of the universe. So +1 from me to checking for infinity. +1 ERROR infinite

Re: [HACKERS] count_nulls(VARIADIC "any")

2016-01-26 11:42 GMT+01:00 Marko Tiikkaja : > On 25/01/16 19:57, Pavel Stehule wrote: > >> Marco is a author of this patch, so - Marco, please, send final version of >> this patch >> > > I don't really care about the tests. Can we not use the v5 patch already > in the thread? As

Re: [HACKERS] [PoC] Asynchronous execution again (which is not parallel)

Hi. At Thu, 21 Jan 2016 19:09:19 +0900, Amit Langote wrote in <56a0ae4f.9000...@lab.ntt.co.jp> > > Hi! > > On 2016/01/21 18:26, Kyotaro HORIGUCHI wrote: > >>> Then, suppose we add a function bool ExecStartAsync(PlanState *target, > >>> ExecCallback callback,

Re: [HACKERS] pglogical most basic setup for logical replication

> > It sounds like you must be running on PostgreSQL 9.4. Indeed I am on PostgreSQL 9.4, I omitted this important point. You'll need to drop the subscriber database and re-create it. Use a new > node name. Seems to work but I still do not really understand what was wrong in the first place

[HACKERS] pglogical most basic setup for logical replication

Hello, I did not manage to make the simplest logical replication scheme work with pglogical. My setup is the following: two postgresql nodes (one provider and one subscriber) with one database and one simple table: `CREATE TABLE t (c1 integer, PRIMARY KEY (c1));` I followed the README provided

Re: [HACKERS] pglogical most basic setup for logical replication

On 26 January 2016 at 18:14, Sebastien Diemer < sebastien.die...@polyconseil.fr> wrote: > Hello, > > I did not manage to make the simplest logical replication scheme work with > pglogical. > My setup is the following: two postgresql nodes (one provider and one > subscriber) with one database and

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 2016/01/25 17:03, Rushabh Lathia wrote: Here are couple of comments: 1) int IsForeignRelUpdatable (Relation rel); Documentation for IsForeignUpdatable() need to change as it says: If the IsForeignRelUpdatable pointer is set to NULL, foreign tables are assumed to be insertable,

Re: [HACKERS] proposal: PL/Pythonu - function ereport

On recent occasions, Pavel Stehule and Catalin Iacob have written: ... >> But *inside* PLPython what I wrote is true, see this example for what I >> mean: >> >> CREATE FUNCTION test() >> RETURNS int >> AS $$ >> def a_func(): >> raise plpy.Error('an error') >> >> try: >> a_func() >>

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

Hi, Please find attached updated patch with an updated interface. On Jan 26, 2016 11:22 AM, "Vinayak Pokale" wrote: > > Hi Amit, > > Thank you for reviewing the patch. > > On Jan 26, 2016 9:51 AM, "Amit Langote" wrote: > > > > > > Hi Vinayak,

Re: [HACKERS] CustomScan under the Gather node?

> -Original Message- > From: Amit Kapila [mailto:amit.kapil...@gmail.com] > Sent: Wednesday, January 27, 2016 2:30 PM > To: Kaigai Kouhei(海外 浩平) > Cc: pgsql-hackers@postgresql.org > Subject: ##freemail## Re: [HACKERS] CustomScan under the Gather node? > > On Tue, Jan 26, 2016 at 12:00 PM,

Re: [HACKERS] Why format() adds double quote?

2016-01-27 6:24 GMT+01:00 Tatsuo Ishii : > >> > I can agree, so current behave can be useful in some cases, but still > it > >> is > >> > bug (inconsistency) between PostgreSQL parser and PostgreSQL escaping > >> > functions. > >> > > >> > Currently, any multibyte char can

Re: [HACKERS] Why format() adds double quote?

>> What do you exactly propose regarding white chars and multibyte chars >> here? Maybe you propose to consider non ASCII white spaces (treate >> them as ASCII white spaces)? >> > > I propose the work with UTF white chars should be same like ASCII white > chars. The current design is too simple -

Re: [HACKERS] Existence check for suitable index in advance when concurrently refreshing.

On Tue, Jan 26, 2016 at 9:33 PM, Masahiko Sawada wrote: > Hi all, > > In concurrently refreshing materialized view, we check whether that > materialized view has suitable index(unique and not having WHERE > condition), after filling data to new snapshot >

Re: [HACKERS] pglogical - logical replication contrib module

On 12/31/2015 03:34 PM, Petr Jelinek wrote: Hi, I'd like to submit the replication solution which is based on the pglogical_output [1] module (which is obviously needed for this to compile). This is fantastic! However, history presents itself here and PostgreSQL in the past has not "blessed"

Re: [HACKERS] Doubt in 9.5 release note

> Tatsuo Ishii writes: >> I saw following item in release-9.5.sgml: >> >> >> Support comments on domain >> constraints (lvaro Herrera) >> >> > >> It seems the release note has nothing to do with the commit. Also, >> commenting on

Re: [HACKERS] Why format() adds double quote?

> 2016-01-26 21:00 GMT+01:00 Daniel Verite : > >> Tatsuo Ishii wrote: >> >> > IMO, it's a bug or at least an inconsistency >> >> Personally I don't see this change being good for everything. >> >> Let's play devil's advocate: >> >> create table abc(U&"foo\2003"

[HACKERS] Code of Conduct plan

Community members: A number of people have contacted the Core Team about taking action regarding a Code of Conduct (CoC) for the project. After some discussion, the plan we have come up with is below. **Please do not reply-all to this email, as we do not wish to generate additional list traffic

Re: [HACKERS] Why format() adds double quote?

>> > I can agree, so current behave can be useful in some cases, but still it >> is >> > bug (inconsistency) between PostgreSQL parser and PostgreSQL escaping >> > functions. >> > >> > Currently, any multibyte char can be unescaped identifier (only >> apostrophes >> > are tested). We should to

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

On Tue, Jan 26, 2016 at 1:40 PM, and...@anarazel.de wrote: > > On 2016-01-26 13:22:09 +0530, Amit Kapila wrote: > > @@ -633,9 +633,11 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser > > Time when the state was last changed > > > >

Re: [HACKERS] Why format() adds double quote?

2016-01-26 21:00 GMT+01:00 Daniel Verite : > Tatsuo Ishii wrote: > > > IMO, it's a bug or at least an inconsistency > > Personally I don't see this change being good for everything. > > Let's play devil's advocate: > > create table abc(U&"foo\2003" int); > >

Re: [HACKERS] CustomScan under the Gather node?

On Tue, Jan 26, 2016 at 12:00 PM, Kouhei Kaigai wrote: > > Hello, > > What enhancement will be necessary to implement similar feature of > partial seq-scan using custom-scan interface? > > It seems to me callbacks on the three points below are needed. > *

Re: [HACKERS] Why format() adds double quote?

2016-01-27 6:13 GMT+01:00 Tatsuo Ishii : > > 2016-01-26 21:00 GMT+01:00 Daniel Verite : > > > >> Tatsuo Ishii wrote: > >> > >> > IMO, it's a bug or at least an inconsistency > >> > >> Personally I don't see this change being good for

Re: [HACKERS] insert/update performance

Ok, I found the vaccum output is correct. I check the codes of lazy_scan_heap(), the rows to be removed are reported in two parts, one is return of heap_page_prune(), the other is ItemIdIsDead() when scanning the page. After scanning all pages of the relation, those rows would be clean up in:

Re: [HACKERS] Why format() adds double quote?

2016-01-27 8:25 GMT+01:00 Tatsuo Ishii : > >> What do you exactly propose regarding white chars and multibyte chars > >> here? Maybe you propose to consider non ASCII white spaces (treate > >> them as ASCII white spaces)? > >> > > > > I propose the work with UTF white chars

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

On 2016-01-26 13:22:09 +0530, Amit Kapila wrote: > @@ -633,9 +633,11 @@ postgres 27093 0.0 0.0 30096 2752 ?Ss > 11:34 0:00 postgres: ser > Time when the state was last changed > > > - waiting > - boolean > - True if this backend is currently waiting

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

On Tue, Jan 26, 2016 at 6:51 PM, Kyotaro HORIGUCHI wrote: > Mmm. I believed that this is on CF app.. > > At Tue, 19 Jan 2016 15:41:54 +0900, Michael Paquier > wrote in >

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada wrote: > Tab completion for REFRESH command is oddly with following scenario. > > =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab] > > It shows only WITH DATA option without WITH NO DATA option. > Attached patch

[HACKERS] pg_lsn cast to/from int8

Is there a reason we don't have casts between int8 and pg_lsn? AFAICT it works fine if I create the cast manually... Is it because of signed/unsigned if people have really really many transactions? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On Tue, Jan 26, 2016 at 4:15 PM, Etsuro Fujita wrote: > On 2016/01/25 17:03, Rushabh Lathia wrote: > >> Here are couple of comments: >> > > 1) >> >> int >> IsForeignRelUpdatable (Relation rel); >> > > Documentation for IsForeignUpdatable() need to change as it says:

Re: [HACKERS] pg_lsn cast to/from int8

On 2016-01-26 14:56:21 +0100, Magnus Hagander wrote: > Is there a reason we don't have casts between int8 and pg_lsn? AFAICT it > works fine if I create the cast manually... Is it because of > signed/unsigned if people have really really many transactions? What for do you want that cast? Yes, the

Re: [HACKERS] pg_lsn cast to/from int8

On Tue, Jan 26, 2016 at 3:00 PM, Andres Freund wrote: > On 2016-01-26 14:56:21 +0100, Magnus Hagander wrote: > > Is there a reason we don't have casts between int8 and pg_lsn? AFAICT it > > works fine if I create the cast manually... Is it because of > > signed/unsigned if

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

On Tue, Jan 26, 2016 at 10:25 PM, Michael Paquier wrote: > On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada > wrote: >> Tab completion for REFRESH command is oddly with following scenario. >> >> =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

On Tue, Jan 26, 2016 at 11:08 PM, Fujii Masao wrote: > On Tue, Jan 26, 2016 at 10:25 PM, Michael Paquier > wrote: >> On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada >> wrote: >>> Tab completion for REFRESH command is

Re: [HACKERS]WIP: Covering + unique indexes.

25.01.2016 03:32, Jeff Janes: On Fri, Jan 22, 2016 at 7:19 AM, Anastasia Lubennikova wrote: Done. I hope that my patch is close to the commit too. Thanks for the update. I've run into this problem: create table foobar (x text, w text); create unique index

Re: [HACKERS] Releasing in September

On Tue, Jan 26, 2016 at 1:01 PM, Andres Freund wrote: > On 2016-01-26 00:26:18 -0600, Joshua Berkus wrote: > > > The alternative to this is an aggressive recruitment and mentorship > > program to create more major contributors who can do deep review of > > patches. But that

Re: [HACKERS] pglogical - logical replication contrib module

On 26 January 2016 at 20:33, leo wrote: > Hi Steve Singer, > >I find the pglogical package has updated, I reinstall the new RPM > package > and test again. But I find the same error in subscription node after I run > pglogical.create_subscription command: > > Please

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

On Tue, Jan 26, 2016 at 8:24 AM, Fujii Masao wrote: > On Tue, Jan 26, 2016 at 11:08 PM, Fujii Masao wrote: >> While testing the patch, I found that >> REFRESH MATERIALIZED VIEW doesn't list the materialized views. > > This is not true. Sorry for

Re: [HACKERS] pglogical most basic setup for logical replication

On 26 January 2016 at 19:18, Sebastien Diemer < sebastien.die...@polyconseil.fr> wrote: > It sounds like you must be running on PostgreSQL 9.4. > > Indeed I am on PostgreSQL 9.4, I omitted this important point. > > I'll update the docs to mention the extra step on 9.4. > You'll need to drop the

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

On Tue, Jan 26, 2016 at 8:43 AM, Kevin Grittner wrote: > I will push something shortly with the > improvements from both of you, plus a couple other MV tab > completion issues I found in testing these patches. Done. -- Kevin Grittner EDB: http://www.enterprisedb.com The

[HACKERS] Proposal:Use PGDLLEXPORT for libpq

Hello hackers. Why we do not use PGDLLEXPORT (__declspec (dllexport)) for the libpq (and other dlls)? Now we are using black magic with gendef.pl for get def (aka export.txt) from .obj files. I have set for some functions and it works. Perhaps there is a circumstance that I do not know but my

Re: [HACKERS] Batch update of indexes

Hi hackers, I have implemented "ALTER INDEX ... WHERE ..." clause allowing to change condition for partial index. Actually it allows us to append index without fully rebuilding it. As I explained in the previous mails, partial indexes can be used to increase insert speed. Right now I get the

Re: [HACKERS] pglogical - logical replication contrib module

On 23 January 2016 at 11:17, Steve Singer wrote: > > 2) Does this patch provide a set of logical replication features that meet > many popular use-cases > > Below I will review some use-cases and try to assess how pglogical meets > them. > > ** Streaming Postgresql Upgrade >

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

On 26 January 2016 at 23:04, Yury Zhuravlev wrote: > Hello hackers. > Why we do not use PGDLLEXPORT (__declspec (dllexport)) for the libpq (and > other dlls)? > Now we are using black magic with gendef.pl for get def (aka export.txt) > from .obj files. > I have set

Re: [HACKERS] remove wal_level archive

On 1 September 2015 at 03:39, Peter Eisentraut wrote: > - The distinction between wal_level settings "archive" and "hot_standby" > is in the way of automation or better intelligence, because the primary > cannot tell what the receiver intends to do with the WAL. > > So here is

Re: [HACKERS] pg_lsn cast to/from int8

On 26 January 2016 at 22:07, Magnus Hagander wrote: > In this case, mostly legacy compatibility. Making an app that works with > versions that don't have pg_lsn have a nice path forward to the modern > world. Being able to cast from pg_lsn to int8 can also make it easier to

Re: [HACKERS] WIP: Failover Slots

Hi all Here's v2 of the failover slots patch. It replicates a logical slot to a physical streaming replica downstream, keeping the slots in sync. After the downstream is promoted a client can replay from the logical slot. UI to allow creation of non-failover slots is pending. There's more

Re: [HACKERS] pgbench stats per script & other stuff

Fabien COELHO wrote: > You know how delighted I am to split patches... Yes, of course, it's the most interesting task in the world. I'm fully aware of that. FWIW I'm going to apply a preliminary commit to pgindent-clean the file before your patches, then apply each patch as pgindent-clean.

Re: [HACKERS] pgbench stats per script & other stuff

Fabien COELHO wrote: > a) add -b option for cumulating builtins and rework internal script >management so that builtin and external scripts are managed the >same way. I tweaked this a bit. I found a bug in threadRun: it was reading the commands first, and setting st->use_file later.

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

Craig Ringer wrote: TL;DR: PGDLLEXPORT is considered ugly Windows-droppings in the code and so a less visible, albeit more convoluted, solution is used. It says more about the modules, and not about libpq. Using gendef.pl for this library in the light of the development of my CMake build

Re: [HACKERS] proposal: PL/Pythonu - function ereport

Hi >>> But in my opinion this discussion shouldn't really even be about >>> catching these things, most of the times you won't catch them and >>> instead you'll let them go to Postgres. The discussion should be >>> whether raise plpy.Error(...), plpy.raise_error, plpy.raise_info(,,,) >>> etc.

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

On 27 January 2016 at 00:16, Yury Zhuravlev wrote: > It says more about the modules, and not about libpq. Using gendef.pl for > this library in the light of the development of my CMake build seems silly. > > For what it's worth I personally agree. I'd rather have

Re: [HACKERS] Add generate_series(date,date) and generate_series(date,date,integer)

On Tue, Jan 26, 2016 at 7:53 AM, Michael Paquier wrote: > On Tue, Jan 26, 2016 at 7:00 PM, Torsten Zuehlsdorff > wrote: > > > > On 26.01.2016 07:52, Simon Riggs wrote: > > > >>> Imagine for example a script that in some rare cases passes

Re: [HACKERS] Add generate_series(date,date) and generate_series(date,date,integer)

On Tue, Jan 26, 2016 at 09:53:26PM +0900, Michael Paquier wrote: > On Tue, Jan 26, 2016 at 7:00 PM, Torsten Zuehlsdorff > wrote: > > > > On 26.01.2016 07:52, Simon Riggs wrote: > > > >>> Imagine for example a script that in some rare cases passes > >>> happens to

Re: [HACKERS] Add generate_series(date,date) and generate_series(date,date,integer)

On 26-01-2016 09:53, Michael Paquier wrote: > Something like the patch attached would be fine? This wins a backpatch > because the query continuously running eats memory, no? > +1. Although it breaks compatibility, a function that just eats resources is not correct. -- Euler Taveira

Re: [HACKERS] remove wal_level archive

On 26-01-2016 12:56, Simon Riggs wrote: > Removing one of "archive" or "hot standby" will just cause confusion and > breakage, so neither is a good choice for removal. > Agree. > What we should do is > 1. Map "archive" and "hot_standby" to one level with a new name that > indicates that it can

Re: [HACKERS] Add generate_series(date,date) and generate_series(date,date,integer)

Revised patch: Differences in this patch vs my first one: - infinite bounds generate errors identical to Michael's timestamp patch (though I did like Simon's highly optimistic error message). - Bounds checking moved before memory context allocation - arg variable "finish" renamed "stop" to match

Re: [HACKERS] Why format() adds double quote?

Tatsuo Ishii wrote: > IMO, it's a bug or at least an inconsistency Personally I don't see this change being good for everything. Let's play devil's advocate: create table abc(U&"foo\2003" int); U+2003 is 'EM SPACE', in Unicode's General Punctuation block. With the current version,

Re: [HACKERS] Speedup twophase transactions

Stas Kelvich wrote: > While this patch touches quite sensible part of postgres replay and there is > some rarely used code paths, I wrote shell script to setup master/slave > replication and test different failure scenarios that can happened with > instances. Attaching this file to show test

Re: [HACKERS] Add generate_series(date,date) and generate_series(date,date,integer)

Simon Riggs wrote: > On 25 January 2016 at 09:55, Tomas Vondra > wrote: > > > > Imagine for example a script that in some rare cases passes happens to > > pass infinity into generate_series() - in that case I'd much rather error > > out than wait till the end of

Re: [HACKERS] Patch: ResourceOwner optimization for tables with many partitions

Aleksander Alekseev writes: >> Um, that's not too surprising, because they're exactly the same patch? > Wrong diff. Here is correct one. This still had quite a few bugs, but I fixed them (hope I caught everything) and pushed it. I did some performance testing of the

Re: [HACKERS] Speedup twophase transactions

Agree, I had the same idea in my mind when was writing that script. I will migrate it to TAP suite and write a review for Michael Paquier's patch. Stas Kelvich Postgres Professional: http://www.postgrespro.com The Russian Postgres Company > On 26 Jan 2016, at 20:20, Alvaro Herrera

Re: [HACKERS] Why format() adds double quote?

2016-01-26 5:29 GMT-02:00 Tatsuo Ishii : > > I assume you used UTF-8 encoding database. Yes, I do. -- Dickson S. Guedes mail/xmpp: gue...@guedesoft.net - skype: guediz http://github.com/guedes - http://guedesoft.net http://www.postgresql.org.br -- Sent via

Re: [HACKERS] Why format() adds double quote?

2016-01-26 18:00 GMT-02:00 Daniel Verite : > ... > create table abc(U&"foo\2003" int); > > U+2003 is 'EM SPACE', in Unicode's General Punctuation block. > > With the current version, format('%I', attname) on this column is: > "foo " > > With the patched version, it

Re: [HACKERS] pgbench stats per script & other stuff

Fabien COELHO wrote: > a) add -b option for cumulating builtins and rework internal script >management so that builtin and external scripts are managed the >same way. I'm uncomfortable with the prefix-matching aspect of -b. It makes "-b s" ambiguous -- whether it stands for select-only

Re: [HACKERS] Speedup twophase transactions

On Wed, Jan 27, 2016 at 5:39 AM, Stas Kelvich wrote: > Agree, I had the same idea in my mind when was writing that script. > I will migrate it to TAP suite and write a review for Michael Paquier's patch. Yeah, please! And you have won a free-hug coupon that I can give

Re: [HACKERS] Why format() adds double quote?

> Thanks for advocate, I see here that it even produces that output with > simple spaces. > > postgres=# create table x ("aí " text); > CREATE TABLE > postgres=# \d x > Tabela "public.x" > Coluna | Tipo | Modificadores > --+--+--- > aí | text | > >

Re: [HACKERS] Why format() adds double quote?

>> IMO, it's a bug or at least an inconsistency > > Personally I don't see this change being good for everything. > > Let's play devil's advocate: > > create table abc(U&"foo\2003" int); > > U+2003 is 'EM SPACE', in Unicode's General Punctuation block. > > With the current version,

Re: [HACKERS] why pg_size_pretty is volatile?

On Tue, Jan 26, 2016 at 3:00 PM, Pavel Stehule wrote: > > > 2016-01-26 2:00 GMT+01:00 Michael Paquier : >> >> On Tue, Jan 26, 2016 at 5:35 AM, Pavel Stehule >> wrote: >> > Vitaly Burovoy pointed on bug in my patch - a

[HACKERS] Does pglogical support PG 9.4.5?

Hi all, I am test pglogical on PG 9.4.5, but I am not successfully even if I install the latest version "postgresql94-pglogical-1.0.1-2". Is there any one running pglogical on PG 9.4.5 successfully? I describe my operation step, please help me to trouble shooting? provider node:

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

On Tue, Jan 26, 2016 at 11:49 PM, Kevin Grittner wrote: > On Tue, Jan 26, 2016 at 8:43 AM, Kevin Grittner wrote: > >> I will push something shortly with the >> improvements from both of you, plus a couple other MV tab >> completion issues I found in testing

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

On Wed, Jan 27, 2016 at 11:41 AM, Fujii Masao wrote: > But ISTM that CREATE MATERIALIZED VIEW doesn't list > existing matviews yet. What's worse it lists existing *views*. Yep. > This happens because words_after_create mechanism doesn't support > the case where the

Re: [HACKERS] brin_summarize_new_values error checking

On Mon, Jan 25, 2016 at 4:03 PM, Jeff Janes wrote: > In reviewing one of my patches[1], Fujii-san has pointed out that I > didn't include checks for being in recovery, or for working on another > backend's temporary index. > > I think that brin_summarize_new_values in 9.5.0

Re: [HACKERS] log_checkpoint's "0 transaction log file(s) added" is extremely misleading

On Fri, Jan 22, 2016 at 11:33 AM, Andres Freund wrote: > On January 22, 2016 3:29:44 AM GMT+01:00, Simon Riggs > wrote: >>On 22 January 2016 at 01:12, Andres Freund wrote: >> >>> Hi, >>> >>> While in theory correct, I think

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 2016/01/26 22:57, Rushabh Lathia wrote: On Tue, Jan 26, 2016 at 4:15 PM, Etsuro Fujita > wrote: On 2016/01/25 17:03, Rushabh Lathia wrote: int IsForeignRelUpdatable (Relation rel);

Re: [HACKERS] Releasing in September

On 26.01.2016 02:09, Peter Eisentraut wrote: On 1/25/16 2:48 AM, Torsten Zühlsdorff wrote: Nobody, but there are different solutions. And the same solutions works different in quality and quantity in the different projects. In FreeBSD for example there is an online tool for review

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

Mmm. I believed that this is on CF app.. At Tue, 19 Jan 2016 15:41:54 +0900, Michael Paquier wrote in

Re: [HACKERS] custom function for converting human readable sizes to bytes

Hi 2016-01-26 13:48 GMT+01:00 Vitaly Burovoy : > Hello, Pavel! > > That letter was not a complain against you. I'm sorry if it seems like > that for you. > ok. It was an intermediate review with several points to be clear for _me_ > from experienced hackers, mostly

[HACKERS] Existence check for suitable index in advance when concurrently refreshing.

Hi all, In concurrently refreshing materialized view, we check whether that materialized view has suitable index(unique and not having WHERE condition), after filling data to new snapshot (refresh_matview_datafill()). This logic leads to taking a lot of time until postgres returns ERROR log if

Re: [HACKERS] Add generate_series(date,date) and generate_series(date,date,integer)

On Tue, Jan 26, 2016 at 7:00 PM, Torsten Zuehlsdorff wrote: > > On 26.01.2016 07:52, Simon Riggs wrote: > >>> Imagine for example a script that in some rare cases passes happens to >>> pass infinity into generate_series() - in that case I'd much rather error >>> out

[HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

Hi all, Tab completion for REFRESH command is oddly with following scenario. =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab] It shows only WITH DATA option without WITH NO DATA option. Attached patch improves tab completion for WITH DATA/NO DATA option of REFRESH MATERIALIZED VIEW.

Re: [HACKERS] pglogical - logical replication contrib module

Hi Steve Singer, I find the pglogical package has updated, I reinstall the new RPM package and test again. But I find the same error in subscription node after I run pglogical.create_subscription command: Error message: < 2016-01-26 12:23:59.642 UTC >LOG: worker process: pglogical

Re: [HACKERS] Speedup twophase transactions

Hi, Thanks for reviews and commit! As Simon and Andres already mentioned in this thread replay of twophase transaction is significantly slower then the same operations in normal mode. Major reason is that each state file is fsynced during replay and while it is not a problem for recovery,

Re: [HACKERS] custom function for converting human readable sizes to bytes

Hello, Pavel! That letter was not a complain against you. I'm sorry if it seems like that for you. It was an intermediate review with several points to be clear for _me_ from experienced hackers, mostly about a code design. 26.01.2016 07:05, Pavel Stehule пишет: >> pg_proc.h has changed, so the

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

Hello Kyotaro-san, Thank you very much Michael but the CF app doesn't allow me to regsiter new one. Filling the Description field with "pgbench - allow backslash-continuations in custom scripts" and chose a topic then "Find thread" shows nothing. Filling the search text field on the "Attach