Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

On Tue, Apr 11, 2017 at 2:38 PM, Simon Riggs <si...@2ndquadrant.com> wrote: > On 11 April 2017 at 09:05, Magnus Hagander <mag...@hagander.net> wrote: > > On Tue, Apr 11, 2017 at 3:26 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >>

Re: [HACKERS] Some thoughts about SCRAM implementation

On Wed, Apr 12, 2017 at 11:13 AM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 04/12/2017 11:22 AM, Magnus Hagander wrote: > >> On Wed, Apr 12, 2017 at 3:25 AM, Bruce Momjian <br...@momjian.us> wrote: >> >> And which enterprises are using SSL without cert

Re: [HACKERS] Some thoughts about SCRAM implementation

and *modify* things. From the backup they can read all the data, but they can't modify anything -- but with a replayable hash, they can connect and modify data. If the superuser has a password they can also use that password to escalate to OS level privileges. I think these are both big wins. And both of them more important than channel binding. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Reversed sync check in pg_receivewal

On Tue, Apr 11, 2017 at 3:53 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > On Tue, Apr 11, 2017 at 3:19 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > >> I think the patch is correct, but if there's any documentation o

Re: [HACKERS] Reversed sync check in pg_receivewal

On Tue, Apr 11, 2017 at 3:19 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > Attached patch reverses the check, and adds a failure message. I'd > > appreciate a quick review in case I have the logic backwards in my >

Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles

On Tue, Apr 11, 2017 at 4:18 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Apr 11, 2017 at 1:45 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Magnus Hagander <mag...@hagander.net> writes: > >>>>> Are these votes for getting rid

Re: [HACKERS] Some thoughts about SCRAM implementation

ent and > provide real value to (I guess, mostly but very interesting) enterprise > customers, for which MITM and impersonating are big things. The good news > is that adding channel binding is like inverse Paretto: a 20% of extra > effort (I bet significantly less) leads to 80% improvement. > I would expect most enterprise customers who care about MITM protection are already using either TLS or ipsec to cover that already. They have benefit from the other parts of SCRAM, but they've already solved those problems. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

does? The output on my laptop for that produces (for example). It's wrapped in a div with class=table. But the old code had . And AFAICT, it's the CALSTABLE that the css is actually matching on? Could this be a toolchain version thing? I'm using jessie on my laptop, which is the same one that th

[HACKERS] Reversed sync check in pg_receivewal

the failure. Oops. Attached patch reverses the check, and adds a failure message. I'd appreciate a quick review in case I have the logic backwards in my head... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://ww

Re: [HACKERS] pg_upgrade vs extension upgrades

On Mon, Apr 10, 2017 at 6:57 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > After you've run pg_upgrade, you have to loop through all your databases > > and do an "ALTER EXTENSION abc UPDATE" once for each

[HACKERS] Function to control physical replication slot

case we can't actually determine the location it gets set to keep, because it will be set to "whatever is current"). -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

On Tue, Apr 11, 2017 at 3:26 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Apr 10, 2017 at 5:47 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > Based on that we seem to agree here, should we add this as an open item? > > Clearly if we want t

[HACKERS] pg_upgrade vs extension upgrades

After you've run pg_upgrade, you have to loop through all your databases and do an "ALTER EXTENSION abc UPDATE" once for each extension. Is there a reason we shouldn't have pg_upgrade emit a script that does this, similar to how it emits a script to run ANALYZE? -- Magnus Hagander

Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles

On Mon, Apr 10, 2017 at 2:07 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Apr 10, 2017 at 8:35 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Magnus Hagander <mag...@hagander.net> writes: > >> Are these votes for getting rid of both

Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles

gt; I agree. > Are these votes for getting rid of both win32.mak and bcc32.mak? If so, count me in for the same :) Want me to do the honors, as it's my fault they're in there in the first place? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

On Wed, Apr 5, 2017 at 6:22 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Mar 23, 2017 at 4:50 AM, Magnus Hagander <mag...@hagander.net> > wrote: > > One thing we might want to consider around this -- in 10 we have > > target_s

[HACKERS] Vacuum full stats reporting

there? Worth it? Due to this, it also does not (AFAICT) reset the counters for things like dead tuples. This part seems like a pure bug. Perhaps we should at least do something like (1) as a backpatch, even if we decide to do (2) in future versions (11+ i guess)? -- Magnus Hagander Me: https

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Mon, Apr 10, 2017 at 4:02 AM, Bruce Momjian <br...@momjian.us> wrote: > On Sun, Apr 9, 2017 at 07:00:38PM +0200, Magnus Hagander wrote: > > > > > > On Sun, Apr 9, 2017 at 2:32 AM, Bruce Momjian <br...@momjian.us> wrote: > > > > On Sat, Apr 8

Re: [HACKERS] pg_basebackup: Allow use of arbitrary compression program

> Yes, I definitely think this would be useful. > - Can anyone see any problems with the above approach? > One thing to consider is the work done recently to ensure that the output is properly synchronized when written to disk. I don't think it's reasonable to expect that from an e

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

it also modifies a global stylesheet for *all* pages. So what about the on all the non-docs pages? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

eb which should fix all of > this. > > Is there any chance we can find a way to do this witha ctual CSS selectors and not use javascript? I realize there might not be, but have we explored the option properly on the way the site layout looks now and with reasonably modern browsers? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Supporting huge pages on Windows

used *before* we create the restricted one). At least that's my guess from reading the docs and trying to remember :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles

anymore though, it wouldn't surprise me if it doesn't. But the non-change-of-name could be why we're not seeing questions about it. FWIW, I've suggested we drop it before, so no objections to that part from me (and if we do, there's some #ifdefs around it in headers as well). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] SCRAM authentication, take three

On Fri, Apr 7, 2017 at 9:59 AM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 04/07/2017 10:38 AM, Magnus Hagander wrote: > >> So here's a wild idea. What if we just call it "sha256"? Does the user >> actually care about it being scram, or is scram just an

Re: [HACKERS] SCRAM authentication, take three

, you wrote: > >> The latest versions document this precisely, but I agree with Peter's >> concern >> about plain "scram". Suppose it's 2025 and PostgreSQL support SASL >> mechanisms >> OAUTHBEARER, SCRAM-SHA-256, SCRAM-SHA-256-PLUS, and SCRAM-SHA3-512. What >> should the pg_hba.conf options look like at that time? I don't think >> having a >> single "scram" option fits in such a world. I see two strategies that >> fit: >> >> 1. Single "sasl" option, with a GUC, similar to ssl_ciphers, controlling >> the >>mechanisms to offer. >> 2. Separate options "scram_sha_256", "scram_sha3_512", "oauthbearer", etc. >> > > The example I gave above is like option 2. The problem with option 1 is > that different SASL mechanisms can have very different properties. You > might want to allow "NTLM" from a trusted network, but require "OTP" from > the public internet, for example. So I don't think a single GUC would be > flexible enough. > +1. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Comment typo in publicationcmd.c

On Fri, Apr 7, 2017 at 9:00 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > Hi all, > > Attached fixes a typo in publicationcmd.c file. > > s/om/on/ > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] walsender.c comments

On Tue, Mar 28, 2017 at 8:59 AM, Erik Rijkers <e...@xs4all.nl> wrote: > Small fry gathered wile reading walsender.c ... > > (to be applied to master) > Thanks, applied. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

On Fri, Mar 31, 2017 at 8:59 AM, Magnus Hagander <mag...@hagander.net> wrote: > > On Wed, Mar 29, 2017 at 1:05 PM, Michael Banck <michael.ba...@credativ.de> > wrote: > >> Hi, >> >> Am Montag, den 27.02.2017, 16:20 +0100 schrieb Magnus Hagander: >>

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

On Mon, Feb 27, 2017 at 7:46 PM, Jeff Janes <jeff.ja...@gmail.com> wrote: > On Sun, Feb 26, 2017 at 12:32 PM, Magnus Hagander <mag...@hagander.net> > wrote: > >> >> On Sun, Feb 26, 2017 at 8:27 PM, Michael Banck <michael.ba...@credativ.de >> > wrote: &

Re: [HACKERS] bumping HASH_VERSION to 3

t; forever. > - No need to worry about doing an in-place upgrade of the metapage for > the above-mentioned patch. > > Thoughts? > Given the state of hash indexes in <= 9.6, I think this is a reasonable tradeoff. Most people won't be using them at all today. Those that do will have to &qu

Re: [HACKERS] REFERENCES privilege should not be symmetric (was Re: [GENERAL] Postgres Permissions Article)

ck branches, even more so than other behavior. In this case I think it's quite unlikely that it would hit somebody, but the risk is there. And people generally auto-upgrade to the latest minor releases, whereas they at least in theory read the top of the release notes when doing a major upgrade (ok,

Re: [HACKERS] Typo in libpq

On Thu, Mar 30, 2017 at 3:48 PM, Daniel Gustafsson <dan...@yesql.se> wrote: > There seems to be a typo in libpq as per attached, “..we will loose error > messages” should probably be “..we will lose error messages”. > Applied, thanks. -- Magnus Hagander Me: http://www.haga

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

On Wed, Mar 29, 2017 at 1:05 PM, Michael Banck <michael.ba...@credativ.de> wrote: > Hi, > > Am Montag, den 27.02.2017, 16:20 +0100 schrieb Magnus Hagander: > > On Sun, Feb 26, 2017 at 9:59 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Is th

Re: [HACKERS] Schedule and Release Management Team for PG10

gt; > FWIW, while I'm sure we had a reason (back at the Ottawa 2016 meeting) > for limiting the final 'fest to just a month, I'm quite sure we did > not allow for most of the senior hackers being at a conference during > the last week of that time. So I now concur with Bruce's suggestion > that a

Re: [HACKERS] Removing binaries

only a very small minority does that. The majority does one of: yum install postgresql setup-postgresql <can't remember the switch offhand, but the one that calls initdb for them> systemctl start postgresql or apt-get install postgresql (which auto-initdb's and autostarts) or double-clicks graphical installer on windows (which auto-initdb's and autostarts) I would bet each one of those have at least one and probably more than one order of magnitude more users than ever call initdb or pg_ctl manually. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

On Tue, Mar 21, 2017 at 8:34 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Sun, Mar 19, 2017 at 12:01 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > I think maybe we should output a message when the slot is created, at > least > > in verbose

Re: [HACKERS] createlang/droplang deprecated

On Mon, Mar 20, 2017 at 1:37 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/18/17 09:00, Peter Eisentraut wrote: > > I just noticed that createlang and droplang have been listed as > > deprecated since PG 9.1. > > > > Do we dare remove the

Re: [HACKERS] Fix for grammatical error in code-comment

"effective", instead of the probably more > correct "efficient". > > The original comment reads as though the code would not do its job > correctly, rather than just not very quickly. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

detectinv readonly standbys as well? Or to flip that, would sending the transaction_read_only parameter be enough for the usecase in this thread, without having to invent a new variable? (I haven't thought it through all the way, but figured I should mention the thought as I'm working through my email backlog.) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] RADIUS fallback servers

* the different authentication methods we have. > > > > At any rate, I'm going to continue moving forward with testing this > patch as is. > > I have run through testing this patch against a small set of RADIUS > servers. This testing included both single server and multiple server > configurations. All seems to work as expected. > Seeps I forgot about this one. Thanks for the review -- I've applied the patch. I'll look into the timeout thing as a separate patch later. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Create replication slot in pg_basebackup if requested and not yet present

" mode in pg_basebackup, but doing it integrated like this is definitely a step even better than that. I think maybe we should output a message when the slot is created, at least in verbose mode, to make sure people realize that happened. Does that seem reasonable? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Removing binaries (was: createlang/droplang deprecated)

On Sat, Mar 18, 2017 at 9:23 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > createuser, dropuser - definitely pollutes the namespace, people do > > sometimes try them for the wrong thing. Unlike the db ones they do add

Re: [HACKERS] Removing binaries (was: createlang/droplang deprecated)

On Sun, Mar 19, 2017 at 1:44 PM, Andreas Karlsson <andr...@proxel.se> wrote: > On 03/18/2017 09:12 PM, Magnus Hagander wrote: > >> createdb, dropdb - also not clear they're about postgres, more likely to >> be used by mistake but not that bad. That said, do they add any *v

[HACKERS] Removing binaries (was: createlang/droplang deprecated)

Magnus Hagander <mag...@hagander.net> writes: >> 2017-03-18 14:00 GMT+01:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: >>> I just noticed that createlang and droplang have been listed as >>> deprecated since PG 9.1. >>> Do we dare remove th

Re: [HACKERS] createlang/droplang deprecated

On Sat, Mar 18, 2017 at 6:13 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Sat, Mar 18, 2017 at 11:29 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Magnus Hagander <mag...@hagander.net> writes: > >>> 2017-03-18 14:00 GMT+01:00 Peter Eisentraut < >

Re: [HACKERS] createlang/droplang deprecated

ce PG 9.1. >> >> Do we dare remove them? >> > > +1 > > +1. (I'd extend it to all the non-prefixed pg binaries, but let's open that can of worms right now, one thing at a time) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in snapbuild.c

On Mon, Mar 13, 2017 at 8:33 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > Hi, > > Attached fixes comment typos in snapbuild.c file. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Need a builtin way to run all tests faster manner

On Fri, Mar 10, 2017 at 3:11 PM, Jim Nasby <jim.na...@openscg.com> wrote: > On 3/10/17 2:05 PM, Magnus Hagander wrote: > >> >> Travis specifically would not help us with this, due to the dependency >> on gifhub, but something that knows how to run "patch ... &a

Re: [HACKERS] Need a builtin way to run all tests faster manner

On Fri, Mar 10, 2017 at 2:53 PM, Jim Nasby wrote: > On 3/10/17 1:09 PM, Peter Eisentraut wrote: > >> On 3/10/17 03:27, Jim Nasby wrote: >> >>> Perhaps https://travis-ci.org/ or something similar could be used for >>> this. That avoids any issues about random code. >>> >>

Re: [HACKERS] Need a builtin way to run all tests faster manner

On Fri, Mar 10, 2017 at 11:29 AM, Dagfinn Ilmari Mannsåker < ilm...@ilmari.org> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > > AFAIK travis-ci would require us to use github as our hoster for all > those > > things, and embrace that workflow,

Re: [HACKERS] SQL/JSON in PostgreSQL

On Thu, Mar 9, 2017 at 1:12 PM, Sven R. Kunze <srku...@mail.de> wrote: > On 08.03.2017 20:52, Magnus Hagander wrote: > > On Wed, Mar 8, 2017 at 11:48 AM, Peter van Hardenberg <p...@pvh.ca> wrote: > >> Small point of order: YAML is not strictly a super-set of JSON. &g

Re: [HACKERS] Need a builtin way to run all tests faster manner

On Fri, Mar 10, 2017 at 3:27 AM, Jim Nasby <jim.na...@openscg.com> wrote: > On 3/7/17 9:52 PM, Magnus Hagander wrote: > >> There have also on and off been discussions about building arbitrary >> patches as they are sent to the mailinglists. Doing that without any >&g

Re: [HACKERS] SQL/JSON in PostgreSQL

ce to the contrary. > > The world of configuration management seems to for some reason run off YAML, but that's the only places I've seen it recently (ansible, puppet etc). That said if we're introducing something new, it's usually better to copy from another format than to invite your own. -- M

Re: [HACKERS] Need a builtin way to run all tests faster manner

till be of good value. An in-between could be to hook something off the CF app, but one important question is how important covering many platforms is. Since we already have good functionality for doing that in the buildfarm, it makes sense to utilize that if we can. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] SCRAM authentication, take three

ble. This seems like an obvious place, but are there any other places where we should also consider something like that for compatibility? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

es from their puppet or chef or whatnot, they may end up opening their database up for replication for users and IP addresses they did not intend to. (For users it's probably not an issue thanks to the replication privilege at the user level, but for IP addresses it definitely does) //Magnus -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] RADIUS fallback servers

ected. If it does not respond at all, we > move > > on to the next one. > > > > I'm wondering if in doing this we should also make the RADIUS timeout a > > configurable as HBA option, since it might become more important now? > > Yes, I think this would make sense and would be a good idea. > > //Magnus -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] port of INSTALL file generation to XSLT

On Wed, Mar 1, 2017 at 3:58 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2/28/17 08:57, Magnus Hagander wrote: > > It appears we need pandoc 1.13 to get the good output. This won't be > > available until Debian stretch. > > >

Re: [HACKERS] port of INSTALL file generation to XSLT

On Mon, Feb 27, 2017 at 4:55 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/31/16 07:33, Magnus Hagander wrote: > > Borka being a standard debian jessie install has Pandoc > > 1.12.4.2~dfsg-1+b14. Should be no problem installing that. > >

Re: [HACKERS] Wrong variable type in KeepLogSeg

otSegNo); > > > slotSegNo should be a XLogSegNo. Both types share the same > intrinsic type so it doesn't harm anything. > > This is back-patchable upto 9.4. > Nice catch. Applied and backpatched. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] rename pg_log directory?

ot;activity_log"? I like the idea of a rename. server_log seems like a better choice then I think. So +1 for that. In theory cluster_log since it's a "cluster level log", but given how many people already get confused by the term cluster being used that way, I think that while maybe technically correct, that would be a very bad choice. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] PGSERVICEFILE as a connection string parameter

t libpq... > That same argument applies to PGPASSFILE, does it not? Properly implementing PGSERVICEFILE is more complicated though -- as it requires LDAP support to go there the whole way for example. But it might not hurt to encourage other drivers (such as jdbc) to support at least the basic

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

On Sun, Feb 26, 2017 at 9:59 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > On Sun, Feb 26, 2017 at 8:27 PM, Michael Banck < > michael.ba...@credativ.de> > > wrote: > >> ISTM the consensus is t

Re: [HACKERS] Automatic cleanup of oldest WAL segments with pg_receivexlog

On Sun, Feb 26, 2017 at 10:46 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Feb 23, 2017 at 9:40 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > I'm not sure this logic belongs in pg_receivexlog. If we put the decision > > making there, then we

Re: [HACKERS] Automatic cleanup of oldest WAL segments with pg_receivexlog

Sun, Feb 26, 2017 at 12:24 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sun, Feb 26, 2017 at 12:41 AM, Magnus Hagander <mag...@hagander.net> > wrote: > > On Feb 25, 2017 15:00, "Michael Paquier" <michael.paqu...@gmail.com> > wrote: >

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

On Sun, Feb 26, 2017 at 9:53 PM, Michael Banck <michael.ba...@credativ.de> wrote: > Hi, > > Am Sonntag, den 26.02.2017, 21:32 +0100 schrieb Magnus Hagander: > > > On Sun, Feb 26, 2017 at 8:27 PM, Michael Banck > > <michael.ba...@credativ.de> wrote: > > &g

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

ouple of entries which were missing the progname in the messages -- I broke those out to a separate patch instead. Made a small change to "using as much I/O as available" rather than "as possible", which I think is a better wording, along with the change of the idle wording I suggested before. (but feel free to point it out to me if that's wrong). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Automatic cleanup of oldest WAL segments with pg_receivexlog

On Feb 25, 2017 15:00, "Michael Paquier" <michael.paqu...@gmail.com> wrote: On Sat, Feb 25, 2017 at 10:32 PM, Magnus Hagander <mag...@hagander.net> wrote: > Oh, I definitely think such a command should be able to take a placeholder > like %f telling which segment it

Re: [HACKERS] Automatic cleanup of oldest WAL segments with pg_receivexlog

On Fri, Feb 24, 2017 at 3:52 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Feb 24, 2017 at 1:10 AM, Magnus Hagander <mag...@hagander.net> > wrote: > > I'm not sure this logic belongs in pg_receivexlog. If we put the decision > > making there, t

Re: [HACKERS] Automatic cleanup of oldest WAL segments with pg_receivexlog

David Steele mentioned that he >> could make use of such a thing. >> > > BTW, I'm not opposed to an end-segment command; I'm just saying I don't > think having it would really help users very much. > > It might not help end users directly, but it could certainly help tools

Re: [HACKERS] Checksums by default?

> Torn page detection is usually/often done by other means than checksums. I don't think those are necessarily related. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Automatic cleanup of oldest WAL segments with pg_receivexlog

other scenarios, be better provided by the "run command at end of segment" function that we've talked about before? And then that external command could implement whatever aging logic would be appropriate for the environment? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] pg_monitor role

To install > them you need admin privileges anyway, so you can easily grant > whatever usage privileges you want at that time. > I'll start by saying "why not cover contrib"? Then I'll say *absolutely* not pageinspect. That is a diagnostics tool and not a monitoring tool. And

Re: [HACKERS] Bold itemized list entries

On Feb 13, 2017 8:45 AM, "Ashutosh Bapat" wrote: Hi Bulletted list in Devel branch are all showing up bold as seen in the screenshot of [1] attached. But the same page for 9.6 branch shows normal bulletted lists. If I try to bulid docs from the latest resources

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

On Sun, Feb 19, 2017 at 1:43 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sun, Feb 19, 2017 at 8:03 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > If password auth is used, we have to store the password in plaintext > > equivalent somewhere. Me

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

On Sun, Feb 19, 2017 at 1:03 PM, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 19/02/17 12:03, Magnus Hagander wrote: > > > > > > On Sun, Feb 19, 2017 at 2:01 AM, Michael Paquier > > <michael.paqu...@gmail.com <mailto:michael.paqu...@gmail.com>

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

ubscription passwords in a prompt of some kind when starting the postmaster, to avoid it? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Help text for pg_basebackup -R

On Fri, Feb 17, 2017 at 5:21 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Stephen Frost <sfr...@snowman.net> writes: > > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > >> Magnus Hagander wrote: > >>> I'm guessing if we backpatch so

Re: [HACKERS] [PATCH] Add pg_disable_checksums() and supporting infrastructure

would be trivial. > Per the point made by somebody else (I think Simon?) on the other thread, I think it also needs WAL support. Otherwise you turn it off on the master, but it remains on on a replica which will cause failures once datablocks without checksum starts replicating. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Help text for pg_basebackup -R

On Wednesday, February 15, 2017, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Magnus Hagander wrote: > > > printf(_(" -R, --write-recovery-conf\n" > > - "

Re: [HACKERS] removing tsearch2

On Tuesday, February 14, 2017, David E. Wheeler <da...@justatheory.com> wrote: > On Feb 14, 2017, at 9:37 AM, Magnus Hagander <mag...@hagander.net > <javascript:;>> wrote: > > > It's a failing in one of the two at least. It either needs to be easier > to build

[HACKERS] Help text for pg_basebackup -R

doesn't say anything about the fact that it writes the file *for replication*. The help page does, but not the message. I propose a new message per the attached patch. Comments? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ diff --git a/src/bin/pg_baseback

Re: [HACKERS] removing tsearch2

On Feb 14, 2017 18:26, "David E. Wheeler" wrote: On Feb 14, 2017, at 5:37 AM, Jim Nasby wrote: >> Until pgxn has a way of helping users on for example Windows (or other >> platforms where they don't have a pgxs system and a compiler around), >>

Re: [HACKERS] Removal of deprecated views pg_user, pg_group, pg_shadow

ying it won't be supported. pgadmin4 will support it of course. But things like the xlog->wal changes are much more likely to break parts of pgadmin than these views are, and I would guess the same for most other admin tools as well. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

On Mon, Feb 13, 2017 at 10:33 AM, Michael Banck <michael.ba...@credativ.de> wrote: > Hi, > > Am Montag, den 13.02.2017, 09:31 +0100 schrieb Magnus Hagander: > > On Mon, Feb 13, 2017 at 3:29 AM, Jim Nasby <jim.na...@bluetreble.com> > > wrote: > >

Re: [HACKERS] Add doc advice about systemd RemoveIPC

On Fri, Feb 10, 2017 at 10:36 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/31/16 11:43 AM, Tom Lane wrote: > > Magnus Hagander <mag...@hagander.net> writes: > >> I still think that some wording in the direction of the fact that the &g

Re: [HACKERS] removing tsearch2

be a "second class citizen". It's certainly part of the community efforts in many ways, but it's a significant loss of usability compared to things that are included. And from the perspective of the testing the infrastructure, you'd loose a lot of platform coverage (unless you can find a way to integrate pgxn building with the buildfarm). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

ing that's better exposed as a server-side view? (and if pg_basebackup could poll it it would probably still not be included by default -- only if -P was given). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Commit fest 2017-01 will begin soon!

as well. > -- Yes, it would be trivial to have the app post a "status changed from x to y" message when that is done. But IIRC we did discuss this around the time the app was dpeloyed and decided we did not want this. But such decisions can of course always be re-visited :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] RADIUS fallback servers

positive, auth is OK. If it responds negative, auth is rejected. If it does not respond at all, we move on to the next one. I'm wondering if in doing this we should also make the RADIUS timeout a configurable as HBA option, since it might become more important now? -- Magnus Hagander Me: http

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

). I would just say "during which pg_basebackup will appear idle". How does that sound to you? As for the code, while I haven't tested it, isn't the "checkpoint completed" message in the wrong place? Doesn't PQsendQuery() complete immediately, and the check needs to be put *after* the PQ

Re: [HACKERS] WIP: About CMake v2

On Feb 10, 2017 19:41, "Andres Freund" <and...@anarazel.de> wrote: On 2017-02-10 19:33:18 +0100, Magnus Hagander wrote: > I guess we wouldn't, but we'd still need the "replacement for autoconf" > part. So then we're back to maintaining multiple buildsystems. H

Re: [HACKERS] WIP: About CMake v2

On Fri, Feb 10, 2017 at 7:31 PM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 02/10/2017 08:27 PM, Magnus Hagander wrote: > >> For me a killer feature would be if/when we can get to a point where we >> can >> have something pgxs-style on cmake that also works

Re: [HACKERS] WIP: About CMake v2

have to do some > amount of extra work as a result of any switch. > > For me a killer feature would be if/when we can get to a point where we can have something pgxs-style on cmake that also works on windows. Our homemade Windows build system works OK for postgres, and while ugly it

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

y at the minutes, the answer is no: > https://wiki.postgresql.org/wiki/FOSDEM/PGDay_2017_Developer_Meeting We discussed discussing it :) And came to the conclusion that we did not have enough of a quorum to actually make any decision on it complete, so we figured it's better if everybody just chime in individually. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] Some patch triage from Brussels

Clustered Index This is not a judgement on if we think we *want* the features -- we actually want all of them. We just don't think they're going to be ready in time for 10. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

nabled by > > default in pg_hba.conf? This requires just uncommenting a couple of > > lines in pg_hba.conf.sample. > > Yes, I think this makes sense, as one of the reason for these changes is > to simplify the use of pg_basebackup. > +1. -- Magnus Hagander Me: http:

[HACKERS] Online enabling of page level checksums

t the core functionality of being able to have "checksum in progress" would have to be in the core codebase. So, is there something obviously missing in this plan? Or just the code to do it :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Checksums by default?

. Yes, you can set up a replica (which today requires third party products like slony, bucardo or pglogical -- at least we'll hopefully have pglogical fully in 10, but it's still a very expensive way to fix the problem). If we can make it cheap and easy to turn them off, that makes a change of the defaul

Re: [HACKERS] Checksums by default?

On Sat, Jan 21, 2017 at 3:05 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sat, Jan 21, 2017 at 7:39 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > Is it time to enable checksums by default, and give initdb a switch to > turn > > it of

<    1   2   3   4   5   6   7   8   9   10   >