Re: [PATCHES] cast bytea to/from bit strings

2006-05-09 Thread Fabien COELHO
Dear Tom, I think that the inability to convert nearly binary compatible standard types one to the other is a postgresql issue. Even if it is not often useful, the point is completeness and soundness of the type provided by the core. OK, can I get some feedback from others about this patch?

Re: [PATCHES] cast bytea to/from bit strings

2006-05-06 Thread Fabien COELHO
Dear Bruce, I am not sure this is of general enough usefulness to be in the backend. Hmm... I think that the inability to convert nearly binary compatible standard types one to the other is a postgresql issue. Even if it is not often useful, the point is completeness and soundness of the

[PATCHES] cast bytea to/from bit strings

2006-05-04 Thread Fabien COELHO
Dear PostgreSQL developers, Please find attached a small patch to convert bytea to bit strings and vice versa. I used it in order to be able xor md5 results so as to checksum bundles of tuples together. The MD5 result is an hexa text convertible to bytea with decode, but then I was

Re: [PATCHES] Users/Groups - Roles

2005-06-30 Thread Fabien COELHO
Dear Stephen, Attached please find files and patches associated with moving from the User/Group system currently in place to Roles, as discussed previously. The files are: pg_authid.h New system table, contains role information To be placed in src/include/catalog, replacing

[PATCHES] pgxs under Win32 for PL/Java

2004-11-07 Thread Fabien COELHO
. I have no mean to test that on a win32 machine. Could you do it? I'm wondering whether the MAKE_DLL fix should also be done under cygwin. Any opinion? Thanks in advance, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/include/Makefile.orig Wed Nov 3 10:32:29 2004 --- ./src/include/Makefile

[PATCHES] pgxs patch for win32 (v2)

2004-11-07 Thread Fabien COELHO
, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/include/Makefile.orig Wed Nov 3 10:32:29 2004 --- ./src/include/Makefile Sun Nov 7 11:14:52 2004 *** *** 18,24 # Subdirectories containing headers for server-side dev SUBDIRS = access bootstrap catalog commands executor lib libpq

Re: [PATCHES] pg_regress --temp-keep

2004-10-20 Thread Fabien COELHO
. (make install INSTALL=install or similar) That simple idea alone seems to give a 25% cpu performance gain on my laptop for a make check... I'll try to find time to test the multi-arg install for further improvements anyway. Thanks! -- Fabien Coelho - [EMAIL PROTECTED

Re: [PATCHES] pg_regress --temp-keep

2004-10-19 Thread Fabien COELHO
right now. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] pg_regress --temp-keep

2004-10-18 Thread Fabien COELHO
Dear Tom, What I'd rather see is some effort spent on speeding up our install script, maybe by allowing it to install multiple files per invocation. The recent changes to force install-all-headers have caused a serious degradation of make install performance, Yes, I agree. and I think that's where

Re: [PATCHES] pgxs default installation + various fixes

2004-09-13 Thread Fabien COELHO
Dear Bruce, So, the question remains the same: is there a consensus to drop install-all-headers/light-install targets for a simple and full install? This is the 8.0 release --- let's remove those targets. Our logic has usually been to remove confusing options and document their removal rather

Re: [PATCHES] pgxs default installation + various fixes

2004-09-11 Thread Fabien COELHO
. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Fabien COELHO
Dear Magnus, Oh. Hmm ... wouldn't it be easier and safer to launch psql script as a subprocess? I'd say no. Executing processes from the installer environment can be a headache (we've had enough problems with initdb already..). And you have to go through all the weirdness with the commandline

Re: [PATCHES] pgxs default installation + various fixes

2004-09-03 Thread Fabien COELHO
to implement with apache example at hand. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] pgxs default installation + various fixes

2004-09-03 Thread Fabien COELHO
packagers to have a clear list of the use of all headers files, in order that they can figure out where they belong to. Opinions? -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose

[PATCHES] pgxs default installation + various fixes - v2

2004-09-03 Thread Fabien COELHO
are the implications. I have to investigate, and I don't have much time right now... Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./GNUmakefile.in.orig Tue Aug 10 08:29:01 2004 --- ./GNUmakefile.inFri Sep 3 10:01:40 2004 *** *** 15,23 @echo All of PostgreSQL

[PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Fabien COELHO
, makefiles and libraries useful for server developpement. I would suggest install-server-dev. - make the contrib regressions work with pgxs. I'm not sure about what is needed for that. I'm available to fix any problem with this patch. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Fabien COELHO
remove both light-install and install -all-headers targets in another submission. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Fabien COELHO
-install targets for a simple and full install? If so, I'll make a new submission. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] [BUGS] BUG #1219: pgxs does not work fully

2004-08-24 Thread Fabien COELHO
Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO: The patch adds missing the libpgport.a file to the installation under install-all-headers. It is needed by some contribs. I install the library in pkglibdir, but I was wondering whether it should be libdir? Yes it should. Please

Re: [PATCHES] [BUGS] BUG #1219: pgxs does not work fully

2004-08-17 Thread Fabien COELHO
. it validates. I'm available to fix any problem with this patch. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./contrib/btree_gist/Makefile.orig Fri May 28 15:09:43 2004 --- ./contrib/btree_gist/Makefile Tue Aug 17 11:54:08 2004 *** *** 1,8 - subdir

[PATCHES] pg_dump 'die on errors' option

2004-08-12 Thread Fabien COELHO
for him? Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/ref/pg_restore.sgml.orig Thu Jul 15 10:29:00 2004 --- ./doc/src/sgml/ref/pg_restore.sgml Thu Aug 12 10:29:09 2004 *** *** 130,135 --- 130,147 /varlistentry varlistentry

[PATCHES] more massaging on pgxs postresql extension infrastructure

2004-08-11 Thread Fabien COELHO
is perfectly possible, I'm really willing to fix them while preserving the ability to compile postgresql contribs with an already installed postgresql. Basically it works for me. Thanks in advance, -- Fabien Coelho - [EMAIL PROTECTED]*** ./contrib/btree_gist/Makefile.orig Wed Aug 11 13:38:31

Re: [PATCHES] fix schema ownership on first connection preliminary

2004-08-10 Thread Fabien COELHO
we should leave the behavior alone, at least for this release cycle. Ok. Thanks for your comments. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe

Re: [PATCHES] pgxs: build infrastructure for extensions v4

2004-07-28 Thread Fabien COELHO
, not internal ones. I really want to be able to install contribs as an afterthought and without reconfiguring. anyway, sorry I cannot really help as I m away from home. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 7

Re: [PATCHES] build infrastructure for extensions v3

2004-07-15 Thread Fabien COELHO
be installed in the normal libdir. Ok. I'll submit a new patch on tomorrow to hopefully address all these issues. Thanks a lot for all these comments, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 2: you can get off all

[PATCHES] build infrastructure for extensions v3

2004-07-05 Thread Fabien COELHO
Dear patchers, Please find attached version number 3 for a patch to enable extensions such as contribs or external add-ons to be installed simply with an already installed postgresql. This version addresses Peter's comments about src/makefiles/Makefile.* that do not need to be installed. It

Re: [PATCHES] pgxs: build infrastructure for extensions v2

2004-07-02 Thread Fabien COELHO
is a symbolic link, so it may depends whether the install.sh copies the link as a file or as a link. Thanks for your comments, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ

Re: [PATCHES] patch queue reminder

2004-06-30 Thread Fabien COELHO
that the submission could be forgotten, hence the reminder. I'd expect that patches stuck in pgsql-patches are still supposed to be in-time for feature freeze. Gut. Danke schoen. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 1: subscribe

Re: [PATCHES] pgxs: build infrastructure for extensions v1

2004-06-19 Thread Fabien COELHO
, so its status is different from others that are to be included. Thanks again, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html

Re: [PATCHES] fix schema ownership for database owner on first

2004-06-10 Thread Fabien COELHO
Dear Bruce, On Wed, 9 Jun 2004, Bruce Momjian wrote: Would you adjust based on Tom's comments and resubmit? Thanks. Done. ! Date: Wed, 9 Jun 2004 14:31:59 +0200 (CEST) ! From: Fabien COELHO [EMAIL PROTECTED] ! To: PostgreSQL Patches [EMAIL PROTECTED] ! Subject: [PATCHES] fix schema

[PATCHES] ALSO keyword to CREATE RULE patch

2004-06-09 Thread Fabien COELHO
. It validated for me with a make check. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/rules.sgml.orig Sun Feb 29 17:35:15 2004 --- ./doc/src/sgml/rules.sgml Sun Feb 29 17:38:45 2004 *** *** 873,879 ListItem Para

[PATCHES] fix schema ownership on first connection v2

2004-06-09 Thread Fabien COELHO
Dear hackers, Please find attached a patch to fix schema ownership on first connection, so that non system schemas reflect the database owner. This revised patch includes fixes after Tom comments on names used in the validation. However, the validation is still there. It is easy to edit it out

Re: [PATCHES] Foreign key type checking patch

2004-06-09 Thread Fabien COELHO
Dear Tom, Thanks for your reply. Here is a proposed patch against 7.4.1 to check exact match of foreign key types wrt the referenced keys, and to show a warning if this is not the case. I think that this concern may be obsolete in CVS tip, I just get the current CVS and had a quick

[PATCHES] fix schema ownership for database owner on first connection

2004-06-08 Thread Fabien COELHO
Dear patchers, Please find attached a patch to fix schema ownership on first connection, so that non system schemas reflect the database owner. (1) It adds a new datisinit attribute to pg_database, which tells whether the database initialization was performed or not. The documentation is

Re: [PATCHES] fix schema ownership for database owner on first

2004-06-08 Thread Fabien COELHO
regressionuser[123], regression[123] as names in the validation. Writing tests cases is not fun, so I tried to put some fun by using these characters. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 2: you can get off all lists

Re: [PATCHES] fix schema ownership for database owner on first

2004-06-08 Thread Fabien COELHO
are not necessary. So maybe some make big_check or the like? -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] add build utilities in default install

2004-05-24 Thread Fabien COELHO
Dear patchers, Subject: [PATCHES] add build utilities in default install I withdraw this submission, which was not yet considered for inclusion anyway. I'll send a more complete patch, which includes this one, but also provide a working infrastructure for extensions, sometimes later. I've

Re: [PATCHES] add build utilities in default install

2004-05-19 Thread Fabien COELHO
. -- Fabien COELHO _ http://www.cri.ensmp.fr/~coelho _ [EMAIL PROTECTED] CRI-ENSMP, 35, rue Saint-Honoré, 77305 Fontainebleau cedex, France phone: (+33|0) 1 64 69 {voice: 48 52, fax: 47 09, standard: 47 08} All opinions expressed here are mine

[PATCHES] new aggregate functions v4

2004-05-19 Thread Fabien COELHO
tests, including the added EVERY aggregate. It DOES NOT validate for me, as errors and rules are broken in current head: undefined symbol: pg_strcasecmp However the aggregate part works fine. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/func.sgml.orig

[PATCHES] add build utilities in default install

2004-05-18 Thread Fabien COELHO
. It validates (make check does perform a make install). I'm obviously ready to update the patch if necessary (missing files, other default directories...). Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./GNUmakefile.in.orig Tue Apr 20 09:35:41 2004 --- ./GNUmakefile.inTue May 18 11:52:08

Re: [PATCHES] new aggregate functions v2

2004-05-05 Thread Fabien COELHO
, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Re: [PATCHES] new aggregate functions v1

2004-05-02 Thread Fabien COELHO
. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] new aggregate functions v1

2004-05-02 Thread Fabien COELHO
(1) boolean-and and boolean-or aggregates named bool_and and bool_or. they correspond to standard sql every and some/any aggregates. They do not, sorry. I'll resubmit. -- Fabien Coelho ---(end of broadcast)--- TIP 7: don't forget

Re: [PATCHES] new aggregate functions v1

2004-05-02 Thread Fabien COELHO
to look for them and being desappointed not to find them (there was a discussion about these very functions last month on some other pg list). Although It is very interesting to learn about how to add aggregates in pg, maybe all users around don't have the time and the motivation for that. -- Fabien

[PATCHES] new aggregate functions v1

2004-05-01 Thread Fabien COELHO
version. It validates for me. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/func.sgml.orig Mon Apr 26 14:00:58 2004 --- ./doc/src/sgml/func.sgmlSat May 1 15:49:39 2004 *** *** 7544,7549 --- 7544,7617 /row row

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5

2004-04-27 Thread Fabien COELHO
there is no 'light' fix, other than acknowledging the fact... Not a big issue. Thanks, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] aclitem accessor functions

2004-04-26 Thread Fabien COELHO
'func.sgml' next to has_*_privileges be an appropriate place? -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so

[PATCHES] patches in the pipe?

2004-04-22 Thread Fabien COELHO
questions I received. (2) is somehow a small bug fix. (1) adds a minor set of functions to access fields in 'aclitem'. Thanks in advance, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 7: don't forget to increase your free space map

Re: [PATCHES] patches in the pipe?

2004-04-22 Thread Fabien COELHO
that the problem is refuted or addressed, That's what I do, but I can only argue, not refute or address issues. Whether it is refuted or addressed is in the head of the decider. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 8: explain

Re: [PATCHES] pg_restore ignore error patch

2004-04-20 Thread Fabien COELHO
in the psql [...] Oh, OK, so make it behave like pg_dump's text output piped into psql. It is really easy to add an option to allow user change the 'ignore' behavior, and make pg_restore exit loudly if it is desired. Maybe it should be proposed just for backwards compatibility? -- Fabien

Re: [PATCHES] CSV patch applied

2004-04-20 Thread Fabien COELHO
columns NO NULL CHECK QUOTED (meaning 'as quoted')? From a language design point of view, I think it may be better to stick to one word versions? -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked our extensive

Re: [PATCHES] guc variables flags explicitly initialisation

2004-04-18 Thread Fabien COELHO
it and it is fine with me. BTW, maybe you could either accept/discuss/reject some other 'small' patches I submitted earlier, if you have some time. They are not cosmetic as this one. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast

Re: [PATCHES] aclitem accessor functions

2004-04-13 Thread Fabien COELHO
Dear Peter, I needed these functions to browse aclitems from user land. I can load them when necessary, but it seems to me that these accessors for a backend type belong to the backend, so I submit them. Can you explain what you want to do from the user level? Sure. Before developing

Re: [PATCHES] pg_restore ignore error patch

2004-04-12 Thread Fabien COELHO
format, and that all syntax re-generation issues should be dealt with by pg_restore (INSERT vs COPY, quoting, and so on). But the tool was not resigned this way in the beginning. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 6: Have

[PATCHES] aclitem accessor functions

2004-04-12 Thread Fabien COELHO
to the backend, so I submit them. I wasn't sure of what oid should be given... I attributed new numbers at the end of pg_proc.h. It validates for me against current cvs head. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/backend/utils/adt/acl.c.orig Sat Nov 29 20:51:57 2003

Re: [PATCHES] pg_restore ignore error patch

2004-04-10 Thread Fabien COELHO
have to restore in an older version. I can guess why it eased the implementation, but it does not look good. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send

Re: [PATCHES] pg_restore ignore error patch

2004-04-10 Thread Fabien COELHO
goes directly against the advice for writing translatable messages. Ok. Also, it might be wise to return a nonzero exit code when any errors are ignored. I'm not sure about that, but it might be best to err on the side of caution... Ok. I'll resubmit. -- Fabien Coelho - [EMAIL PROTECTED

Re: [PATCHES] pg_restore ignore error patch

2004-04-10 Thread Fabien COELHO
do. Hence from this it would be nice if pg_restore could restore to older versions. Hence my comment it does not look good. It is just a question of perspective. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 2

[PATCHES] pg_restore ignore error patch v2

2004-04-10 Thread Fabien COELHO
, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/bin/pg_dump/pg_backup.h.orig Wed Mar 24 17:19:43 2004 --- ./src/bin/pg_dump/pg_backup.h Sat Apr 10 13:04:21 2004 *** *** 57,62 --- 57,67 int remoteVersion; int

[PATCHES] pg_restore ignore error patch

2004-04-09 Thread Fabien COELHO
of pg_restore is that it is only expected to work with its own server. Indeed, it generates some new syntax, such as $$ quoting, which is not compatible with older servers. This fact does not seem to appear in the documentation. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/bin

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-06 Thread Fabien COELHO
. I think it is a small technical issue in the parser internals, and has nothing to do with great principles and whether this or that is a keyword. It's about what keywords need to be tokens. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-06 Thread Fabien COELHO
, or it is not there? Out of the parser, the only information is the offending token (embedded in the error string) and the character number in the string, that is quite small a clue to give a hint. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 3

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-06 Thread Fabien COELHO
Dear Tom, In particular you can't any longer tell the difference between BOOLEAN and boolean (with quotes), which are not the same thing --- a quoted string is never a keyword, per spec. [...] Ok, so you mean that on -boolean- the lexer returns a BOOLEAN_P token, but with -boolean- it

[PATCHES] sound extract century/millennium date_part

2004-04-05 Thread Fabien COELHO
an historical definition. Also, I just want to divide the year by 100 or 1000, I can do that quite easily. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/func.sgml.orig Wed Mar 31 08:58:31 2004 --- ./doc/src/sgml/func.sgmlSun Apr 4 10:23:00 2004

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-05 Thread Fabien COELHO
, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-05 Thread Fabien COELHO
would try to enhance emacs sql-mode. But I don't like much lisp programming. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-05 Thread Fabien COELHO
Dear Tom, No, just redefine yyerror as a macro that passes additional parameters. Ok! That's just the kind of the hack-hook I was looking for!! The terminals are not available, they must be kept separatly if you want them. This can be done in yylex(). We don't need them. Any

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-03 Thread Fabien COELHO
. I'm investigating the internal way. Not really optimistic because of the details, but I may find workarounds. I'll post later when I'll have a definite opinion. -- Fabien COELHO _ http://www.cri.ensmp.fr/~coelho _ [EMAIL PROTECTED] CRI-ENSMP, 35, rue Saint-Honoré, 77305 Fontainebleau cedex

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-03 Thread Fabien COELHO
haven't looked into it closely. That could be a showstopper if true, but it's all speculation at this point. I think the information is there. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 9: the planner will ignore your desire

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-02 Thread Fabien COELHO
Dear Tom, I quite agree that you shouldn't do a complete implementation when it's not clear if we'll accept it or not. What I'd like to see is a demo, basically. How about one example of each of several different kinds of hints? We need to get a feeling for what can be accomplished and

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-02 Thread Fabien COELHO
statement list such as CREATE TABLE/INDEX/SEQUENCE/TRIGGER/VIEW or GRANT or ; expected -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-02 Thread Fabien COELHO
that. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-01 Thread Fabien COELHO
being displayed, thanks to all added noH calls I put. Also, As far as I remember, I put a new option to activate these hints. Hints are disactivated by default. This is because some people do not like advices and may want to turn them on or off. -- Fabien Coelho - [EMAIL PROTECTED

Re: [PATCHES] hint infrastructure setup (v3)

2004-04-01 Thread Fabien COELHO
. If you are okay then you apply, and I'll submit some new patches later on, one command at a time, and when I have time. Does this sound reasonnable enough? -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked our

[PATCHES] [NOT] (LIKE|ILIKE) (ANY|SOME|ALL) (subquery...)

2004-03-28 Thread Fabien COELHO
Dear patchers, Please find my second micro-patch submission for this minor inconsistency. I put comments about why SIMILAR TO cannot be handled simply in the code rather that in the test, as it seemed more logical. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/backend/parser

Re: [PATCHES] [NOT] (LIKE|ILIKE) (ANY|ALL) (...)

2004-03-26 Thread Fabien COELHO
factorization must be changed. It can also be done. Yes. I think we must have an all_subselect_ops or similar. I'll do that and resubmit later. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands

Re: [PATCHES] [NOT] (LIKE|ILIKE) (ANY|ALL) (...)

2004-03-25 Thread Fabien COELHO
Fabien COELHO [EMAIL PROTECTED] writes: Please find attached a patch which allows LIKE/ILIKE/NOT LIKE/NOT ILIKE as operators for ANY/SOME/ALL constructs. This seems to allow a whole lot of unintended and probably uncool things as well. ORDER BY NOT LIKE, for instance. Yes. Well

Re: [PATCHES] syntax error position CREATE FUNCTION bug fix

2004-03-19 Thread Fabien COELHO
programmers will never have syntax errors with their SQL stuff. Thus I really think that the parser should return the processed query, at least in some cases. Anyway, have a nice day! -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 1

[PATCHES] syntax error position CREATE FUNCTION bug fix

2004-03-18 Thread Fabien COELHO
to update the position to get back to the initial query, as escapes may have been processed within the string, so a simple offset would not fix the bug. It validates for me. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/protocol.sgml.orig Wed Mar 10 15:56:59 2004

[PATCHES] hint infrastructure setup (v3)

2004-03-17 Thread Fabien COELHO
arguments after the first. Anyway, please consider the following patch for inclusion to current head. It validates for me. I need it to be able to go on. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] hints_0.patch.gz Description: Binary data ---(end

[PATCHES] hint infrastructure setup (v2)

2004-03-16 Thread Fabien COELHO
way, but other patches should be much more narrow after this one, that's the idea... I don't think it harms the parser code, as it validates for me. I just hope I did not forget any file. Thanks in advance, -- Fabien Coelho - [EMAIL PROTECTED] hints_0.patch.gz Description: Binary data

Re: [PATCHES] client side syntax error position (v3)

2004-03-15 Thread Fabien COELHO
discussions... -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

[PATCHES] hint infrastructure setup (v1)

2004-03-15 Thread Fabien COELHO
in a very simple way, but other patches should be much more narrow after this one, that's the idea... I don't think it harms the parser code, as it validates for me. Thanks in advance, -- Fabien Coelho - [EMAIL PROTECTED] hints_0.patch.gz Description: Binary data ---(end

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Fabien COELHO
Dear Bruce, # [PATCHES] notice about costly ri checks (2), Fabien COELHO This one which appears on the web page can also be removed, It is also replaced by version 4. Sorry again for the inconvenience, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Fabien COELHO
Dear Bruce, It is in the queue because I need that narrative for the commit messase. Ok, I get the point. I should have made a fully standalone version with all comments repeated. Thanks, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-11 Thread Fabien COELHO
seemed to decide that a WARNING was better, and that attributes and types should be shown, hence version (4). So, if you can update, it would be better! Sorry for the inconvenience, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast

[PATCHES] client side syntax error localisation for psql (v1)

2004-03-11 Thread Fabien COELHO
for me against current cvs head. I've also added new regression tests in errors.sql. Although I have taken great and painful care to deal with multi-byte encodings, I'm not sure how I can validate that, as I don't have some japanese terminal to play with. Have a nice day, -- Fabien Coelho

[PATCHES] client side syntax error position (v2)

2004-03-11 Thread Fabien COELHO
number that I found useful. The new version validates for me against current cvs head. Same comment as with version one, I don't know how to test the multi-byte part. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/bin/psql/common.c.origThu Mar 11 15:42:17 2004 --- ./src

[PATCHES] costly foreign key ri checks (4)

2004-03-09 Thread Fabien COELHO
appended to foreign_key.sql It validates for me against current head. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] costly_ri_notice.patch.gz Description: Binary data ---(end of broadcast)--- TIP 9: the planner will ignore your desire

Re: [PATCHES] notice about costly ri checks (2)

2004-03-09 Thread Fabien COELHO
As a side question, if there are multiple cross-type conversions in one constraint on different column pairs, what do we think the message should be? One message with multiple column mentions in detail or multiple notices? (I haven't looked at the patch to see if one or the other is

Re: [PATCHES] ALSO keyword to CREATE RULE patch

2004-03-09 Thread Fabien COELHO
I thought the syntax came from Berkeley. We can add ALSO if folks like it. I can't think of cases where we have keywords for both on and off behavior, and allow a default if the keyword is missing. ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ] CREATE TABLE ... [ WITH OIDS |

Re: [PATCHES] ALSO keyword to CREATE RULE patch

2004-03-04 Thread Fabien COELHO
| WITHOUT OIDS ] ... ; CREATE USER ... [ CREATEDB | NOCREATEDB ] ... ; IMHO, from the language design point of view, it seems better if all options have a name. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 5: Have you checked

Re: [PATCHES] ALSO keyword to CREATE RULE patch

2004-03-04 Thread Fabien COELHO
Shoot me the patch again and I will put in the the queue. Thanks. Please find attached (again) the patch I sent. It is against 7.4.1. If necessary, I can redo the job against current head. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/rules.sgml.orig Sun Feb

[PATCHES] Notice about costly ri checks

2004-03-03 Thread Fabien COELHO
with the difforig script against the current cvs head. Thanks in advance for considering it, and for any comment or cheering, -- Fabien Coelho - [EMAIL PROTECTED]*** ./src/backend/commands/tablecmds.c.orig Wed Mar 3 09:18:19 2004 --- ./src/backend/commands/tablecmds.c Wed Mar 3 09:30:57 2004

[PATCHES] Foreign key type checking patch

2004-03-01 Thread Fabien COELHO
is being processed, as there is not real context information and tell 'while processing this constraint'... However this situation seems to be the normal case with any postgresql messages, as far as I can tell from my use. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] fk_type_check.diff.gz

Re: [PATCHES] Foreign key type checking patch

2004-03-01 Thread Fabien COELHO
I can think of several cases where it might be reasonable for the types to be different. Sure. It's all about a warning, not about an error. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 7: don't forget to increase your