tate (or did you commit that aspect already as well?).
Patch attached, please comment. It only avoids cancelling when the
vacuum is for wraparound.
What we're missing here is doc updates (mainly to lmgr/README, I think)
--
Alvaro Herrerahttp://www.CommandP
n't understand what that code is doing. If there's an
> autovac anywhere in the dependency graph, it'll find it.
Thanks for making that explicit, I was trying to build a test case where
it would lock :-)
(If we had concurrent psql we could even have it in the regression tests
...)
works.
I adjusted the comments -- I think they're more correct now. I also
added a puny paragraph to lmgr/README.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
---
proc_fn.h and I moved all
> extern function definition from related headers into them.
--
Alvaro Herrera http://www.amazon.com/gp/registry/5ZYLFMCVHXC
One man's impedance mismatch is another man's layer of abstraction.
(Lincoln Yeoh)
---(
Zdenek Kotala wrote:
> Alvaro Herrera wrote:
>>> 1) I removed sugar word from postgres.h and put them closer to consumer
>>> :-). I created include/catalog/genbki.h which contains sugar words -
>>> macros for correct catalog data processing. All catalogs fil
that if you define YYLTYPE then you don't need
YYLTYPE_IS_DECLARED as well. Also I don't see any TYPE_IS_DECLARED
here. What I'm thinking is that this patch is not very portable :-(
--
Alvaro Herrera Valdivia, Chile ICBM: S 39º 49' 18.1", W 73º 13' 56.4&q
Zdenek Kotala wrote:
> Alvaro Herrera wrote:
>>>> 3) Put following fake into keyword.c before include "parse.h" line. It
>>>> is easiest way.
>>>> #define TYPE_IS_DECLARED 1
>>>> #define YYLTYPE_IS_DECLARED 1
>>>> #de
d to be afraid of YYLTYPE at present).
> >
> > Thank your for Your and Alvaro's comments. I attached updated patch
> > version only with YYSTYPE definition.
--
Alvaro Herrera Valdivia, Chile ICBM: S 39º 49' 18.1", W 73º 13' 56.4"
"No es bueno cami
Bruce Momjian wrote:
> Tom Lane wrote:
> > Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > > Huh, I think the point is to be able to build 8.3 at all on certain
> > > Solaris releases. I think it qualifies as a portability fix.
> >
> > (a) it wasn
attached patch.
I didn't bother to change the PLy_malloc and friends because I think
that would be too much change for 8.3. PLy_realloc is gone though
because there are no callers left after this patch.
--
Alvaro Herrera http://www.flickr.com/phot
Tom Lane escribió:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Tom Lane escribi�:
> >> This patch isn't acceptable because va_copy() isn't portable.
> >>
> >> I'm kinda wondering why PLy_printf and the functions after it even
> &g
Alvaro Herrera escribió:
> One problem here is that 7.3 does not have appendStringInfoVA. From 7.4
> onwards there is no problem. Should I backport the code from 7.4? (On
> a first try to do it I introduced a nasty bug, so it's not as easy as
> a cut'n paste).
No nast
a try with
the code in CVS and let me know.
(If you are really interested in a fix for 7.3, let me know too ... I
couldn't even get plpython to run a trivial function due to RExec
issues. I didn't try 7.2).
--
Alvaro Herrera Developer, http://www.PostgreSQL.org/
Marko Kreen escribió:
> On 11/23/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote:
> > (If you are really interested in a fix for 7.3, let me know too ... I
> > couldn't even get plpython to run a trivial function due to RExec
> > issues. I didn't try 7.2).
>
L | 123,456,789,01230
(1 registro)
--- 379,397
SET
lc_numeric |to_char
+
! es_CL | 123.456.789,01230
(1 registro)
The first output makes no sense whereas the second is correct (ISTM
we've been doin
ehavior), or ignores them with a
> warning.
This silent-skip behavior is there to avoid noise in other tests. Try
the ecpg tests, contrib tests and src/pl tests.
I didn't check the rest of the patch, but did you verify that it still
works in VPATH builds?
--
Alvaro Herrera
David Fetter wrote:
> Greg Sabino Mullane managed to contrive an example where RULEs might
> conceivably be the least-bad way to do this, that being a machine
> where no PLs may be installed.
Perhaps this just means we should consider installing plpgsql by
default.
--
Alvar
==
test largeobject ... /bin/sh: cannot open ./sql/largeobject.sql: No
such file
diff: ./expected/largeobject.out: No such file or directory
diff: ./results/largeobject.out: No such file or directory
diff command failed with status 512: diff -w "./expected/large
;t read the patch, but variadic macros are not portable. FWIW
uint64 should "portable" to all platforms that have it (and it should be
32 bits on platforms that don't), but you have to watch for
INT64_IS_BUSTED.
--
Alvaro Herrera http://www.amazon.com/gp/regist
t; startup cost (only) and the existing termination condition affects the
> estimated total cost (only).
Yes, but how can you tell by looking at the explain? I think the point
is that the "fraction that would be skipped" should be reported somehow.
--
Alvaro Herrera
look like a portable
interface.
Please note that I'm not saying that fixing that issue means the patch
is acceptable. Personally I'm not sure that this is a worthy goal you
are pursuing here. Wouldn't it be a good idea to propose the feature
first and write the code later?
--
already has a delay, see -W.
--
Alvaro Herrera Valdivia, Chile ICBM: S 39º 49' 18.1", W 73º 13' 56.4"
"Executive Executive Summary: The [Windows] Vista Content Protection
specification could very well constitute the longest suicide note in history."
P
Dave Page wrote:
> I'm aware of postgres -W, but wanted something that wouldn't get in the
> way of other connections and would only affect my pgbench tests.
I think you could get the same effect by putting the -W in PGOPTIONS (in
pgbench's environment).
--
Alvaro Herrera
ses - that aren't affected, of course.
One idea is to have psql "hide" the password on the ps status. That way
it becomes less of a security issue. It would still be a problem on
certain operating systems, but at least several common platforms would
be covered.
--
Alvaro Herrera
Pavel Stehule escribió:
> Hello
>
> documentation fix.
>
> result of convert_to is bytea, not text.
Applied, thanks.
--
Alvaro Herrera http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"No deja de ser humillante para una persona de ingenio saber
que no hay t
search logic.
Would it be a good idea to keep removing redundant clauses and rethink
the preference for clauseful joins, going forward?
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
he comment in line 2180 seems a bit bogus ...?
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
---(end of broadcast)---
TIP 4: Have you searched our
archiver and logger; and there are now two loggers possibly
writing to the same files, and truncated log lines could occur.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
ster
> wait for the archiver to exit.
Yeah, that seems the safest to me -- the problem is that it complicates
the shutdown sequence a fair bit, because postmaster must act
differently depending on whether archiving is enabled or not: wait for
bgwriter exit if disabled,
Tom Lane escribió:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Perhaps a better idea is to create a separate LibxmlContext memcxt,
> > child of QueryContext, and have xml_palloc etc always use that. That
> > way it won't be reset between calls. It probably
and others would call this code and then happily use the return value
without checking for null.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
---(end of broadcast)-
done according to your
> comment. The message, if emited, should say then that only superuser
> can analyze those tables.
How about this patch.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development
Andrew Dunstan wrote:
> I agree. I remain of the opinion that this is not a problem than can be
> solved purely within the bounds of postgres.
I agree. Please comment on my proposed solution.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
Post
Andrew Dunstan wrote:
>
>
> Alvaro Herrera wrote:
>> Andrew Dunstan wrote:
>>
>>
>>> I agree. I remain of the opinion that this is not a problem than can be
>>> solved purely within the bounds of postgres.
>>
>> I agree. Please comme
"please execute \help
instead", and then \help would emit the verbose output. Perhaps
eventually we could adorn it with "\help category", etc.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc
Does anyone know if Oracle or DB2's command line tools have "help"
commands?
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings
e current encoding. Do we do that currently elsewhere?
(Perhaps this is not a problem with your patch, but rather a problem
that's worth fixing separately.)
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
---
Zdenek Kotala wrote:
> It maybe work on linux but I think it is not portable solution.
What we should do is avoid using Solaris' getopt_long and instead use
the copy we have in src/port/.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL
ctly the POSIX standard "-" should not used in a
> option list.
Hmm, right. Our current parsing of --long-opts is quite a hack, it
seems :-( Having to list all GUC options in the getopt_long array would
be a mess. Any other ideas?
--
Alvaro Herrera
Zdenek Kotala wrote:
> Alvaro Herrera napsal(a):
>> Hmm, right. Our current parsing of --long-opts is quite a hack, it
>> seems :-( Having to list all GUC options in the getopt_long array would
>> be a mess. Any other ideas?
>
> I attached patch which replaces any
quot; Avahi client. That's a showstopper. Please consider using
some other approach -- writing our own handlers for AvahiPoll would seem
apropos.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
BJS)
> $(DTRACE) $(DTRACEFLAGS) -G -s $(call expand_subsys,$^) -o $@
Perhaps you need a $< there:
$(DTRACE) $(DTRACEFLAGS) -G -s $< $(call expand_subsys,$^) -o $@
However I think you would also need to $(filter-out) the $< from $^.
--
Alvaro Herrera
isadvantages for keeping the
> way it is now?
>
> #ifdef ENABLE_DTRACE
> #include "utils/probes.h"
> #else
> #include "utils/probes_null.h"
> #endif
Why can't this block be centralized in probes.h?
--
Alvaro Herrera
vherre=# select array_append('{}', a) from bar;
array_append
--
{"foo""}
(1 ligne)
The correct value is
alvherre=# select array_append('{}', a) from bar;
array_append
--
{"foo\""}
(1 ligne)
Of course, the sys
Robert Lor wrote:
> Alvaro Herrera wrote:
>>
>> Why can't this block be centralized in probes.h?
>>
> probes.h is auto generated and it can certainly be massaged to include
> the above logic, but I'd like to avoid doing that if possible.
Hmm,
n lwlocked code), but I'm wondering
if I created a thundering hoard problem that did not exist before.
All tests pass.
As a test of Review Board, I uploaded the patch to it:
http://reviewdemo.postgresql.org/r/19/
--
Alvaro Herrerahttp://www.CommandPrompt.com/
cros to be named
POSTGRESQL_TRACE_TRANSACTION_START()
which is not ideal but at least it's a bit more obvious what it's all
about.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > This patch removes the TCL_ARRAY symbol.
>
> If you're going to remove it you should actually remove it
> (eg from pg_config_manual.h).
Oops. Thanks, removed from there too.
--
Alvaro Herrera
Brendan Jurd escribió:
> I've done up a patch per Tom's idea of combining the binary role
> attributes into a single column.
This patch seems to be missing from the queue.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Co
o
avoid a 64bit-Cid postmaster to start on a 32bit-Cid data area and vice
versa.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org
Rémi Zara wrote:
> Hi,
>
> Recent version of NetBSD/MIPS support dlopen. This patch makes the
> netbsd dynloader tests availability of dlopen on HAVE_DLOPEN rather than
> on __mips__
Applied, thanks.
--
Alvaro Herrerahttp://www.CommandPrompt.
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > R�mi Zara wrote:
> >> Recent version of NetBSD/MIPS support dlopen. This patch makes the
> >> netbsd dynloader tests availability of dlopen on HAVE_DLOPEN rather than
> >> on __mips__
>
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> Weird, I haven't seen the commit message come through here.
>
> > Yeah, that's strange -- the (2) commit message got to me, but this one
> > hasn't.
&g
Alvaro Herrera wrote:
> Tom Lane wrote:
> > Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > > Tom Lane wrote:
> > >> Weird, I haven't seen the commit message come through here.
> >
> > > Yeah, that's strange -- the (2) commit messag
Andrew Dunstan wrote:
>
>
> Alvaro Herrera wrote:
>> Both done -- I backpatched all the way down to 7.4 (and later I noticed
>> that the only 7.3 BF members are NetBSD).
>
> Haven't we declared 7.3 at EOL anyway?
That's why I didn't backpatch it there.
Magnus Hagander wrote:
> Alvaro Herrera wrote:
>> I checked the Majordomo logs and there's nothing about those patches.
>> I do see one message with the "Subject: pgsql: Clean up double negative,
>> per Tom Lane." line. A message held for moderation shows up
Magnus Hagander wrote:
> On Wed, Mar 05, 2008 at 07:38:21PM -0300, Alvaro Herrera wrote:
> > revision 1.23
> > date: 2008/03/05 19:42:11; author: alvherre; state: Exp; lines: +4 -4
> > Add support for dlopen on recent NetBSD/MIPS, per Rémi Zara.
>
> 19:42:11 I
tion.
Also it would get more buildfarm coverage if it were default. If it
breaks something we'll notice earlier.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Sent via pgsq
(xvac))
{
if (xvac_committed)
{
/* committed */
}
else
{
/* aborted */
}
}
else
{
/* in-progress */
}
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Co
can save the palloc/memcpy/pfree
and just return the pointer to the array already in memory?
Not that it'll any much of a performance impact, but just for
cleanliness :-)
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom D
ing, I just
didn't remember what it was and based my transformation purely on the
snippet you posted.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Sent via pgsql-patches mailing list (
rty to
examine pg_listener, thus causing it to see the uncommitted rows. Would
that work at all?
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To m
KaiGai Kohei wrote:
> Alvaro Herrera wrote:
>> Before we go any further, is this work derived from SELinux? If so, is
>> it covered under the GPL? If so, can it be licensed under BSD terms?
>
> All of SE-PostgreSQL works are licensed unser BSD terms.
> We are consideri
under BSD terms?
Obviously, if it's not BSD, we cannot include it in Postgres.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Sent via pgsql-patches mailing list (pgsql-patches@postgre
rs of
snapshots mess with the internals directly (setting snapshot->curcid),
but we could clean that up and make it so that those become external
interface users too.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
*
{}
: Create role
: Create DB
asd | No inherit | {}
: No login
bar | | {}
foo | No login| {asd}
(4 rows)
I'm not sure how to fix this. Thoughts?
--
Alvaro Herrerahttp://www.advogato.
ther changes to
use BIGINT where the original values were int4 seem unnecessary.
One thing I'm not clear about is the change from %d to %u to represent
int4 values. Since the SQL datatype is signed, this can't really work,
now, can it?
--
Alvaro Herrerahtt
. A separate server-only context field perhaps?
Or a separate flag in ErrorData elements saying whether each particular
one should go to server only.
If we add that, perhaps we could clean up the stuff in
checkSharedDependency with it, too.
--
Alvaro Herrerahttp://
nk this part of the patch can be committed right away.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscr
I don't think
my $int64passbyval = "(?($real64 = 1)t|f)";
works. Perhaps
my $int64passbyval = $real64 ? 't' : 'f';
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt,
ql.org/wiki/CommitFest:March
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref
e, but it's better if we're aware of that
fact. I think this could be solved if the "namespace" of the comment
does not contain the patch queue name.
I moved it to the May commitfest on the wiki too.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
T
Bryce Nesbitt wrote:
> I've attached a patch, against current 8.4 cvs, which optionally sets a
> maximum width for psql output:
I have added this patch to the May commitfest queue,
http://wiki.postgresql.org/wiki/CommitFest:May
--
Alvaro Herrera
Greg Sabino Mullane wrote:
> Why not run help when someone enters "help" (or "HELP ME!") on the
> command line? \? is hardly an easy thing to remember (and some people
> can't be bothered to actually read the screen...)
So, have you produced a f
Bruce Momjian escribió:
> Alvaro Herrera wrote:
> > I noticed you broke an URL that previously worked: what was
> > http://momjian.us/mhonarc/patches/[EMAIL PROTECTED]
> > is now
> > http://momjian.us/mhonarc/patches_hold/[EMAIL PROTECTED]
> >
> > May I sug
ely". Unless you want to provide
> another command for changing it insecurely ;-). What does it mean,
> anyway?
The point is that the password is encrypted on the client and
transmitted in md5 form. If you were to use ALTER USER to change the
password, it
Bruce Momjian escribió:
> Alvaro Herrera wrote:
> > My point is that you should only _add_ Message-Ids, not remove them.
> > You can move the messages from one queue to the other to your heart's
> > content, but the Message-Id URL should continue to work with no changes
s to be included in
heapam.h (which is included just about everywhere) just to get the
definition of the HTSU_Result enum, which is a bit useless because it is
only used in three switch statements that contain a "default" clause
anyway. I propose changing the result type of heap_update,
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Agreed, it makes a lot more sense considered in this light. I renamed
> > snapshot.{c,h} into snapmgmt.{c,h}, hopefully making the intent clearer.
>
> I'd have gone with snapmgr.h/c for consistency w
e to absolute with a script. The community
> archives are going to have the same problem.
Ahh, thanks for pointing it out. I think I will use an HTTP redirect.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> I'd have gone with snapmgr.h/c for consistency with existing filenames
> >> (bufmgr, lmgr, etc).
>
> > Doh! Sorry. We're at the best time for changing t
Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > Ahh, thanks for pointing it out. I think I will use an HTTP redirect.
>
> How do you know which directory to redirect to?
The script gets the directory as a parameter.
--
Alvaro Herrera
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> I don't like that very much. What about just moving the HTSU_Result
> >> enum's declaration somewhere else? Two possibilities are heapam.h
> >> itself,
e better to
improve the interaction between GetSnapshotData and RegisterSnapshot, to
avoid some palloc traffic.)
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 suppo
Gregory Stark wrote:
> "Alvaro Herrera" <[EMAIL PROTECTED]> writes:
>
> > The other question is about CommitTransactionCommand. Currently my
> > EOXact routine barfs for every snapshot not unregistered on main
> > transaction commit -- a leak. I see thi
sed that behavior under my
> breath more than once, but again maybe my usage isn't typical.
+1
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org
-04/msg00031.php
(apparently some mails on that thread are missing ...)
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your su
be affected.
I have added this to the May commitfest page,
http://wiki.postgresql.org/wiki/CommitFest:May
Thanks.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@pos
Theo Schlossnagle wrote:
> First whack at exposing the start and finish checkpoint times into SQL.
I suggest using GetCurrentTimestamp() directly instead of time_t and
converting.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consult
age.h, bufmgr.h
What's the point here, again?
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http:
oll the logs, it's quite a bit harder to do it.
I'm not sure about the right values to export -- last checkpoint start
time is the most obvious idea, but I would also suggest exporting last
checkpoint end, or NULL if the checkpoint is ongoing; and also previous-
to-last checkpoint start and
ir link line.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/ma
e a better approach for that.
It's not, because the tool would have a much harder time trolling the
logs. CSV does not really make it much easier -- the DBA is still
tasked with importing the thing after the current file is complete; and
you don't have an up-to-date picture e
Gregory Stark wrote:
>
> Here's the WIP patch I described on -hackers to implemented "ordered" append
> nodes.
Did you ever publish an updated version of this patch?
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replica
Zdenek Kotala wrote:
> PS: Is there any reason to do not start to use inline functions instead
> of macros in some cases?
Not all compilers like (== support) inline macros apparently.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL C
Zdenek Kotala wrote:
> Alvaro Herrera napsal(a):
>> Zdenek Kotala wrote:
>>
>>> PS: Is there any reason to do not start to use inline functions
>>> instead of macros in some cases?
>>
>> Not all compilers like (== support) inline macros apparently.
this is OK. Perhaps it would be good to add a comment on top
of the switch statement explaining this. Otherwise looks fine.
Well, and the ereport("FIXME") needs to be improved :-)
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Compan
x27;%foo%' using a regular and a reverse B-tree index,
> and a bitmap AND. Which is interestingly similar to the way you proposed
> to use a TIDBitmap within GIN.
Huh, can you? I can see doing "col LIKE 'foo%' OR reverse(col) LIKE
reverse(
Heikki Linnakangas wrote:
> Alvaro Herrera wrote:
>> Heikki Linnakangas wrote:
>>> You could satisfy '%foo%' using a regular and a reverse B-tree index,
>>> and a bitmap AND. Which is interestingly similar to the way you
>>> proposed to use a TI
if anyone gets it wrong it's immediately
obvious.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to you
601 - 700 of 812 matches
Mail list logo
