[quagga-dev 16532] Fork of Quagga

All - Since there have been questions on alias about the fork and if you are interested in checking us out, we are working over here: https://github.com/freerangerouting/frr The email alias can be found: https://lists.nox.tf/listinfo/frr We have a public slack channel for realtime discussion:

[quagga-dev 15895] Re: Someone rebased volatile/patch-tracking/8/proposed/ff branch

> > Paul > > > On Wed, 13 Jul 2016, Lou Berger wrote: > >> This is patch that's breaking bgpd in 8/proposed/ff >> >> Author: Donald Sharp <sha...@cumulusnetworks.com> >> Date: Fri Mar 4 15:28:56 2016 -0500 >> >>lib: Refactor read/

[quagga-dev 15770] Re: Quagga project governance

I think our recollections of what happened appears to be very different. I've stated publicly what my position is and would appreciate you to stop continuing to misrepresent my position. donald On Tue, Jun 28, 2016 at 11:12 AM, Paul Jakma <p...@jakma.org> wrote: > On Tue, 28 Jun 201

[quagga-dev 15763] Re: Quagga project governance

I think this is a succinct conveyance of my concerns. I'd like to add one more: I would like to have the ability to have dispute resolution handled in a timely fashion. It should be measured in weeks not months. donald On Fri, Jun 24, 2016 at 11:15 AM, Lou Berger wrote: >

[quagga-dev 15759] Re: Quagga project governance

Lou - It works for me. I believe we've resolved all current comments that were placed into the document. I'd like to hear feedback from everyone on this new version of the document. https://docs.google.com/document/d/19DZcT0cJUSYxVIFenHvGFhLLUmLTRFHuMNZcI7aUNGA/edit?usp=sharing In light of

[quagga-dev 15696] Re: Quagga Monthly Meeting Notes

s among the community? > > Lou > > > > On June 22, 2016 5:53:34 AM Paul Jakma <p...@jakma.org> wrote: > >> On Tue, 21 Jun 2016, Donald Sharp wrote: >> >>> Discussion on where to do the work next. quagga-ce on github or on a >>> branch in Sav

[quagga-dev 15695] Re: [PATCH 31/89] lib, zebra: Block configuration and installation of martians

inet_pton in this case is only called once for every interface. Is that a problem? donald On Tue, Jun 21, 2016 at 8:29 AM, Paul Jakma <p...@jakma.org> wrote: > On Fri, 11 Dec 2015, Donald Sharp wrote: > >> Block martian address configuration on an interface and also blo

[quagga-dev 15693] Re: Quagga Monthly Meeting Notes

Michael - It's clearly defined in the Release Process document. Would a pointer to that document be sufficient? donald On Wed, Jun 22, 2016 at 9:09 AM, Michael H Lambert <lamb...@psc.edu> wrote: >> On 21 Jun 2016, at 10:59, Donald Sharp <sha...@cumulusnetworks.com> wrote

[quagga-dev 15680] Quagga Monthly Meeting Notes

Discussion of the Quagga Maintainers Document: https://docs.google.com/document/d/19DZcT0cJUSYxVIFenHvGFhLLUmLTRFHuMNZcI7aUNGA/edit?usp=sharing The document is updated to reflect the discussion/decisions in this meeting. The highlights of the discussion: 1) Maintainer per protocol. This is

[quagga-dev 15638] Re: quagga ipc

You should look at lib/zclient.c and zebra/zserv.c. As that the answer is 'it depends'. donald On Fri, Jun 17, 2016 at 6:10 AM, dexter i wrote: > what is the ipc mechanism used in Quagga..? > > ___ > Quagga-dev mailing list >

[quagga-dev 15618] Re: [PATCH 16/16] vtysh: fix a memory leak in vtysh_client_execute

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke <ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > buf is dynamically allocated and needs to be freed in the error handling

[quagga-dev 15617] Re: [PATCH 15/16] vtysh: handle case if there is no match in "write terminal $daemon"

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke <ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > While the DEFUN should match the list of clients registered in > vtysh, it s

[quagga-dev 15616] Re: [PATCH 14/16] ripd: print md5 auth digest correctly

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke <ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > The dump of the md5 hash was missing one byte of the hash. > > Si

[quagga-dev 15615] Re: [PATCH 13/16] pimd: don't leak original_s_route on error

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke <ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > original_s_route is allocated on the heap and was not freed during the &

[quagga-dev 15614] Re: RFC: plugin (DSO) + hook support

I personally don't see allot of value in making snmp support runtime -vs- compile time, but as a proof of concept I think it's fine for what it is. I do see value in shared libraries though. Should we be thinking a bit bigger? Could we modify the protocols to all be shared libraries that could

[quagga-dev 15602] Re: [PATCH 12/16] isisd: Fix size of malloc

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > Signed-off-by: Christian Franke <ch...@opensourcerouting.org> > ---

[quagga-dev 15601] Re: [PATCH 11/16] isisd: fix an error that was probably a result of copypasting

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > The code should check for the existance of the correct list prior to >

[quagga-dev 15600] Re: [PATCH 10/16] ospf6d: fix off-by-one on display of spf reasons

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > The loop should only iterate to array_size - 1. > > Si

[quagga-dev 15599] Re: [PATCH 09/16] ospf6d: don't access nexthops out of bounds

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > Given that the && is evaluated lazily from left to right, > i <

[quagga-dev 15598] Re: [PATCH 08/16] ospfd: fix double assignment in ospf_vl_set_timers

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > Signed-off-by: Christian Franke <ch...@opensourcerouting.org> > ---

[quagga-dev 15589] Re: [PATCH 07/16] bgpd: fix memory leaks in show commands

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > sockunion_str2su allocates a struct sockunion that used to be leaked

[quagga-dev 15587] Re: [PATCH 06/16] bgpd: fix off-by-one in attribute flags handling

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > bgp_attr_flag_invalid can access beyond the last element of > attr_flags_valu

[quagga-dev 15585] Re: [PATCH 04/16] bgpd: fix bgp_table_stats for mpls vpn

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:06 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > bgpd uses an internal value SAFI_MPLS_VPN == 4 to index the information &

[quagga-dev 15583] Re: [PATCH 02/16] bgpd: setting nexthop doesn't need inet_pton

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 2:06 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > Signed-off-by: Christian Franke <ch...@opensourcerouting.org>

[quagga-dev 15570] Re: Bug Fixes Fast Lane

Jafar - I would point out that the new process as outlined, is that once a bug get's Acked is immediately placed in master by a maintainer. donald On Tue, Jun 14, 2016 at 3:03 PM, Jafar Al-Gharaibeh wrote: > Greetings, > > I know the Quagga community is in the process

[quagga-dev 15542] Re: [PATCH] vtysh: auto-generated vtysh_cmd.c file should depend on its creator

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Tue, Jun 14, 2016 at 10:06 AM, Paul Jakma <paul.ja...@hpe.com> wrote: > --- > vtysh/Makefile.am | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/vtysh/Makefile.am b/vtysh/Makefile.

[quagga-dev 15540] Re: Round 8

I would recommend reverting: ceecc7e *: Consolidate all double VIEW_NODE and ENABLE_NODE's 0dbe0d2 lib: Consolidate VIEW_NODE to be ENABLE_NODE as well They are the cause of this breakage. Shall I do this? thanks! donald On Tue, Jun 14, 2016 at 10:45 AM, Donald Sharp <

[quagga-dev 15538] Re: Round 8

I'm getting this crash in zebra: root@robot:/etc/quagga# /usr/lib/quagga/zebra --daemon -A 127.0.0.1 Aborted (core dumped) root@robot:/etc/quagga# (gdb) r -A 127.0.0.1 Starting program: /usr/lib/quagga/zebra -A 127.0.0.1 [Thread debugging using libthread_db enabled] Using host libthread_db

[quagga-dev 15524] Re: [PATCH 3/4] lib: AgentX: use threads instead of eventloop hack

As a point of discussion: Why shouldn't we drop support for snmp: 1) The license for quagga is incompatible with the snmp licensing (Yes I'm aware that some people/distributions don't care) 2) There hasn't been any recent developments in quagga for snmp, nor does it look like it's really on

[quagga-dev 15522] Re: round 7, can you test?

Crash traceback that I saw: Backtrace for 11 stack frames: /usr/lib/libzebra.so.0(zlog_backtrace_sigsafe+0x2c)[0x7fa781d97bf8] /usr/lib/libzebra.so.0(zlog_signal+0x2ba)[0x7fa781d9750a] /usr/lib/libzebra.so.0(+0x3a3c6)[0x7fa781da13c6] /lib/x86_64-linux-gnu/libc.so.6(+0x354a0)[0x7fa78138d4a0]

[quagga-dev 15511] [PATCH 1/2] pimd: Fix of using uninitialized Memory

Valgrind is reporting that pimd is using uninitialized memory for comparisons. This commit addresses the issues found there. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- pimd/pim_iface.c | 1 + pimd/pim_ifchannel.c | 7 +-- pimd/pim_igmpv3.c| 5 - pimd/pim

[quagga-dev 15510] [PATCH 2/2] *: Fix warnings generated by clang

Clang is finding a new set of problems. Fix them. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- bgpd/bgp_attr.c| 4 ++-- bgpd/bgpd.h| 1 + lib/vty.c | 2 +- zebra/rt_netlink.c | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git

[quagga-dev 15507] Re: [PATCH] vtysh: send "no interface" command to all daemons that support it

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Thu, Jun 9, 2016 at 9:44 AM, Igor Ryzhov <iryz...@nfware.com> wrote: > Signed-off-by: Igor Ryzhov <iryz...@nfware.com> > --- > vtysh/vtysh.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

[quagga-dev 15486] Re: [PATCH] bgpd: bgp_update_receive ignores non present NLRI

Should we have the opportunity to log something here if we receive this error condition? donald On Wed, Jun 8, 2016 at 2:37 AM, Philippe Guibert wrote: > Fixes 518a4b7eadcb "bgpd: Regularise bgp_update_receive, > add missing notifies and checks" > Error message

[quagga-dev 15481] Re: [PATCH] zebra: make fpm netlink_route_info_fill more robust

I suspected this was a Static Analysis change. I'd prefer (b), but don't care enough really to complain if I got a (c) as well. donald On Tue, Jun 7, 2016 at 1:26 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > On 06/07/2016 04:10 AM, Donald Sharp wrote: >

[quagga-dev 15464] Re: [PATCH] bgpd: fix potential crash in community_list_dup_check

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Mon, Jun 6, 2016 at 4:22 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > extcommunity_list_set may set the ->config for an entry > to

[quagga-dev 15462] Re: [PATCH] zebra: make fpm netlink_route_info_fill more robust

Christian - How is this possible? In zfpm_encode_route we set cmd == RTM_DELROUTE if rib == NULL. Is this setup for some new code? donald On Mon, Jun 6, 2016 at 4:04 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke > > Having an

[quagga-dev 15460] Re: CI Testresult: FAILED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

Martin - Looks like something went wrong with your test system? donald On Mon, Jun 6, 2016 at 9:40 PM, wrote: > Continous Integration Result: FAILED > > See below for issues. > This is an EXPERIMENTAL automated CI system. > For questions and feedback, feel free to email >

[quagga-dev 15458] Re: [PATCH] isisd: exit if daemonizing fails

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Mon, Jun 6, 2016 at 3:13 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > The other daemons in Quagga exit with an error if they cannot fork. > Chang

[quagga-dev 15455] Re: [PATCH] ospf6d: remove unused broken function

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Mon, Jun 6, 2016 at 3:49 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke <nob...@nowhere.ws> > > ospf6_interface_if_del has not been in use since for quite some > years and

[quagga-dev 15454] [PATCH] pimd: Add ability to safely ignore route-maps

pim was not parsing route-map code and causing issues using vtysh because of this. Add code to safely ignore the route-map code and set us up for future expansion into route-maps if neeeded. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- pimd/Makefile.am| 3 ++-

[quagga-dev 15452] [PATCH 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter

The interface name is already passed in as part of the 'struct igrmp *group' pointer. No need to do it twice. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- pimd/pim_igmp.c | 13 ++--- pimd/pim_igmp.h | 3 +-- pimd/pim_igmpv3.c | 11 +-- 3 files chang

[quagga-dev 15451] [PATCH 2/3] pimd: Remove source_new unneeded parameter

The interface name is already passed in as part of the 'struct igmp_group *group' pointer. No need to do it twice. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- pimd/pim_igmp.h | 3 +++ pimd/pim_igmpv3.c | 40 2 files chang

[quagga-dev 15449] [PATCH] bgpd: Fix route-map and redistribution

Commit f3cfc46 introduced this issue. A route-map lookup was being done for IPv6, using IPv4 information. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- bgpd/bgp_routemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_routemap.c

[quagga-dev 15415] Quagga Release Process Meeting Notes

Document is here: https://docs.google.com/document/d/1xYrpTKYDvK23BCxXP-dbE6nOuvBxbGIilNLfVkI3j-I/edit Meeting Notes: Section 2: n == 6 months, let's start w/ 6 and adjust later Discussion around YE and what it should be named. Are YE and CE released at the same time? The are released at

[quagga-dev 15402] Strawman Quagga Release Process

All - Lou and I have taken a first pass at the release document that was discussed in the meeting. This description was inspired by, and loosely based on the Ubuntu release process [https://wiki.ubuntu.com/UbuntuDevelopment/ReleaseProcess]. This document is available at the google doc listed

[quagga-dev 15373] Re: [quagga-users 14335] EIGRP Quagga not working

Jan/Donnie - My assumption is, is that I have a wrong branch that I forward ported to 1.0. What branch should be used? donald On Tue, May 24, 2016 at 7:32 AM, wrote: > Hi > i have downloaded Quagga with EIGRP Support from >

[quagga-dev 15353] Re: Patch Submittal Process Going Forward Discussion.

. thanks! donald On Tue, May 17, 2016 at 11:45 AM, Donald Sharp <sha...@cumulusnetworks.com> wrote: > Golden Rule applies to everything we do. > > A person who Submit’s code cannot be the person who commits it into > quagga. Assume that this can be worked out among

[quagga-dev 15338] Re: Patch Submittal Process Going Forward Discussion.

Paul - On Fri, May 20, 2016 at 5:38 AM, Paul Jakma wrote: > > - "resolve issues at a faster rate", by which you really mean "Ignore > having to address the former". > > Please stop putting words in my mouth. I've never said that and I really don't appreciate this continued

[quagga-dev 15321] Re: Patch Submittal Process Going Forward Discussion.

unanimity for every patch. Nor do I see any advantage to 2 month long arguments about issues. I would like a process where we can resolve issues at a faster rate. donald On Wed, May 18, 2016 at 8:54 AM, Paul Jakma <p...@jakma.org> wrote: > On Tue, 17 May 2016, Donald Sharp wrote: >

[quagga-dev 15320] Re: Patch Submittal Process Going Forward Discussion.

On Thu, May 19, 2016 at 6:15 AM, Martin Winter < mwin...@opensourcerouting.org> wrote: > On 17 May 2016, at 8:45, Donald Sharp wrote: > >> >> >> A maintainer can Ack or Nack code he plans to commit. >> > > Can only maintainers ACK or NACK in your

[quagga-dev 15293] Patch Submittal Process Going Forward Discussion.

Golden Rule applies to everything we do. A person who Submit’s code cannot be the person who commits it into quagga. Assume that this can be worked out amongst the maintainers. A maintainer can Ack or Nack code he plans to commit. Proposal for going forward: 1. Patch Submitted 2. If

[quagga-dev 15289] Monthly Meeting Notes and proposal for moving forward

Monthly meeting: Discussion of slowness of getting patches in. General dissatisfaction with current process and lots of discussion on how to improve. General issue boiled down to unanimity -vs- consensus. Discussion of process of how to move forward. -> Donald to send an email to alias with

[quagga-dev 15256] Reminder

We have the monthly quagga-dev meeting this tuesday 5/17 @ 9:00AM EDT. If you would like to attend and don't have an invite please send me an email and I'll get you one. Also topics for discussion are being solicited. donald ___ Quagga-dev mailing

[quagga-dev 15236] Re: git archive error.

Your missing some part of the git package. Probably git-buildpackage? What does dpkg -l | grep git return? donald On Fri, May 6, 2016 at 8:35 AM, dexter i wrote: > i'm following the quagga hacking guide. As per the guide when i run the > following > command, i'm getting

[quagga-dev 15235] Re: [PATCH v2 08/30] lib: add facility to log all CLI commands

Either would be fine from my perspective too. donald On Fri, May 6, 2016 at 8:33 AM, Lou Berger <lber...@labn.net> wrote: > > > On 5/6/2016 8:29 AM, Donald Sharp wrote: > > I agree with Lou that this is a good thing to do. If necessary to get > > this in, I wo

[quagga-dev 15221] Re: [PATCH] lib: Remove dead code from zrealloc

ch...@opensourcerouting.org> wrote: > On 05/03/2016 07:46 PM, Donald Sharp wrote: > > You are right for the upstream behavior. The version that we have in > > the cumulus tree is this: > > > > 106 void * > > 107 zrealloc (int type, void *ptr, size_t size) > > 108 { >

[quagga-dev 15189] Re: IPv6 BGP default route ignored when using SLAAC

Alex - I haven't answered because I don't know the answers to your question without some research and investigation. Unfortunately routing protocols are complicated and It's sometimes a non-trivial amount of work to answer someone's question. donald On Mon, Apr 25, 2016 at 3:13 AM,

[quagga-dev 15175] Re: proposed 7

hbor index, do you want to push that patch [1902] as > well? > > Thanks, > Jafar > > > On 4/22/2016 7:49 AM, Donald Sharp wrote: > > I've just pushed volatile/patch-tracking/7/proposed/ff to savannah: > > e6ec2d6 lib: Fix priviledge modification for vty

[quagga-dev 15150] Next Major Release Branch

This has been asked a couple of times so let's get it out there: The current plan was to take the take-3 branch ( https://github.com/donaldsharp/quagga/tree/take-3 ) and move that into a proposed/8 branch. Paul and I are in discussions to do this: Current sticking points as I understand it:

[quagga-dev 15151] Route-Map Behavior

Paul and I have been discussing this commit: https://github.com/donaldsharp/quagga/commit/4a77fb6cc78cacfd0c6cd0c35ba766f994a87e11 Quagga behavior without this patch does not take into effect for already processed events. So if you change a route-map you need to reset the peer by hand to make

[quagga-dev 15134] proposed 7

I've just pushed volatile/patch-tracking/7/proposed/ff to savannah: e6ec2d6 lib: Fix priviledge modification for vty group specified 190591f zserv: [pimd] fix - avoid dereferencing a NULL pointer 80f61a9 pimd: Fix hang when doing nexthop lookup from zebra 7e73eb7 zebra: handle multihop nexthop

[quagga-dev 15073] Re: [PATCH] ospfd: stub-router "allow transit" option and add "Host" option support

I'm confused. I thought that was the point of the call to gather consensus as a community. donald On Tue, Apr 19, 2016 at 10:34 AM, Paul Jakma wrote: > On Tue, 19 Apr 2016, David Lamparter wrote: > > On Tue, Apr 19, 2016 at 04:10:04PM +0200, David Lamparter wrote: >> >>>

[quagga-dev 15068] Re: [PATCH] ospfd: stub-router "allow transit" option and add "Host" option support

I would prefer that we are rfc compliant as per default and then have a switch to turn it off if needed. donald On Tue, Apr 12, 2016 at 7:58 AM, Paul Jakma wrote: > * The current stub-router support in Quagga ospfd took the "[max-metric > links] should not be used for

[quagga-dev 15033] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

I think there is value to know the number of times an interface has flapped in addition to the last time it happened. The interface flapped over the weekend? Not sure I care that much. The interface last flapped over the weekend and the counter went up 6000 times? I probably need to check it

[quagga-dev 15025] [PATCH] lib: Fix priviledge modification for vty group specified

When attempting to switch runtime permissions over to the correct group specified for the vty group, if the user specified to run as does not have that vty group then do warn about the issue and stop running Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> Reported-by: Thomas

[quagga-dev 15022] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

Jafar - You know that, I know that. End Users are going to see the incongruence and start asking questions. If I can stop a question from being asked. I think that is a win. On Fri, Apr 8, 2016 at 11:11 AM, Jafar Al-Gharaibeh <ja...@atcorp.com> wrote: > > On 4/8/2016 7:24 AM,

[quagga-dev 15018] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

Christian - If I start Quagga, after the link is already brought up: dell-s6000-02# show int swp31s2.4 Interface swp31s2.4 is up, line protocol is up Link ups: 0last: (never) Link downs: 0last: (never) PTM status: disabled vrf: vrf1014 index 58 metric 0 mtu 1500

[quagga-dev 14975] Re: [PATCH 00/89] Cumulus Take-3 Electric Bugaloooooooooooooooo

at's the status / next steps on this? > > Thanks, > > -David > > On Fri, Dec 11, 2015 at 06:50:44PM -0500, Donald Sharp wrote: > [cut] > ___ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 14950] Re: Fwd: [PATCH 2/2] bgpd: Addition of bgp dampening configuration commands under IPv4 Multicast address family mode.

Balaji - I'm currently working towards getting in the take-3 branch. Once that is done the next maintainer will work towards the other backlog Donald On Mar 19, 2016 10:38 AM, "Balaji Gurudoss" wrote: > Hi > > I think these patches didn't get applied. Can you apply it if

[quagga-dev 14938] Quagga 1.0.20160315 Released

This release addresses a crash found when using redistribute statements. It is recommended that all users upgrade to this release. This release is up on Savannah or download at: http://download.savannah.gnu.org/releases/quagga

[quagga-dev 14933] Re: A question on project roles (was Re: Monthly Quagga Meeting)

t; Hi Donald, (and anyone else who may have an opinion) > > I'm not really sure who to direct this question, but you're mail > prompted me to send this message - so it's going to you. My question is? > > On 3/10/2016 10:46 AM, Donald Sharp wrote: > > Call for more gatekeepers &

[quagga-dev 14923] Re: [PATCH 0/6] Protobuf support, and protobuf as FPM format

Avneesh - I'm inclined to give an Ack to patches 1-3, especially once the small nits are fixed. I'm not convinced we need the ability to call random functions from the cli even in a dev build so I would lean towards a Nack on 4-6. I would be interested in seeing if anyone else has thoughts on

[quagga-dev 14922] Re: [PATCH 3/6] zebra: optionally use protobuf with FPM

Can we get a respin of this patch with a 'GNU Zebra' replaced with 'Quagga' and no introduction of #if def HAVE_IPV6? thanks! donald On Fri, Mar 11, 2016 at 3:21 PM, Avneesh Sachdev wrote: > Change zebra so that it can optionally use protobuf serialization when >

[quagga-dev 14921] Re: [PATCH 1/6] Add support for protobuf.

Can you give us some background on why proto-buf was choosen as a communication methodology and why it's superior from a netlink perspective? Some more thoughts inline. On Fri, Mar 11, 2016 at 3:21 PM, Avneesh Sachdev wrote: > Infrastructure that allows protocol buffers

[quagga-dev 14920] Re: [PATCH] lib: fix MIN/MAX macros to not double-eval

Acked-by: Donald Sharp <sha...@cumulusnetworks.com> On Sat, Mar 12, 2016 at 5:12 PM, David Lamparter < da...@opensourcerouting.org> wrote: > On Sat, Mar 12, 2016 at 04:31:52PM -0500, Donald Sharp wrote: > > Let me rephrase a little bit. If this code was inspired from the

[quagga-dev 14914] Re: [PATCH 5/6] vtysh: support for invoking functions by name

Avneesh - Can you expand a bit on why adding the ability to call random functions from the cli is better than just adding a 'test XXX' function as needed? Additionally how do you plan to allow the end user to pass in useful data to functions if the function you want to call takes a complex data

[quagga-dev 14913] Re: [PATCH 1/3] bgpd, lib: Remove RESTRICTED_NODE from code base

No? :) It's not clear to me at all that: (a) allot of people use telnet over vtysh (b) that they've read the code to know that there is a restricted functionality that only exists for bgp (c) and read the code to implement the functionality (d) that people are logging in and only giving

[quagga-dev 14912] Re: [PATCH] lib: fix MIN/MAX macros to not double-eval

. donald On Sat, Mar 12, 2016 at 4:29 PM, Donald Sharp <sha...@cumulusnetworks.com> wrote: > I agree this is less surprising! I was looking at pretty much the exact > same thing in the linux kernel on friday afternoon right as I walked out > the door. Should we attribute the original aut

[quagga-dev 14901] Re: CI Testresult: PASSED (Re: [quagga-dev, 14893] quagga: Remove double read of stream)

Martin - I've pushed this patch to master. donald On Fri, Mar 11, 2016 at 6:15 PM, Martin Winter < mwin...@opensourcerouting.org> wrote: > Basic testing of the patch shows that this fixed the issue. > > I can do a run after it is committed to a branch > (I would suggest to commit to master) >

[quagga-dev 14879] [PATCH 2/3] lib: Consolidate VIEW_NODE to be ENABLE_NODE as well

If you are in VIEW_NODE, the command should exist in ENABLE_NODE as well. This is being done to reduce chances of code being added to one but not the other NODE. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- lib/command.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[quagga-dev 14870] [PATCH 3/3] lib: Remove unnecessary paranthesis

The freebsd compiler complains that there is an extra set of ()'s around the if statement. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- lib/vty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vty.c b/lib/vty.c index e4510f8..aafa271 100644 ---

[quagga-dev 14868] [PATCH 2/3] bgpd: Fix code path that leads to uninitialized variables

subtype and sublength are not initialized and if on Line 1877 BGP_ATTR_ENCAP != type we will not set subtype and sublength, but these variables are used immediately below that if statement. This issue was discovered via the freebsd compiler. Signed-off-by: Donald Sharp <

[quagga-dev 14869] [PATCH 1/3] zebra: Remove unused #ifdef HAVE_STRUCT_SOCKADDR_DL

The #ifdef HAVE_STRUCT_SOCKADDR_DL is true on freebsd but the data structures that are defined by it are never used. This commit removes the dead code. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- zebra/interface.h | 10 -- zebra/rtadv.c | 3 --- 2 files chang

[quagga-dev 14860] Monthly Quagga Meeting

The quagga monthly meeting is next tuesday. If you would like an invite, please let me know. If you have something that you would like to talk about please let me know and I can add it to the agenda. Current agenda items that I would like to talk about: 1) Proposed branching scheme, sent under

[quagga-dev 14858] Proposal for how to improve patch pipeline

Problem statement: Patches can be in an unaccepted stated for a long time while the current proposed branch is in a frozen state in order to get it ready for release. This causes problems for the developer because there can be an extremely long lead time between feedback on the patch and

[quagga-dev 14856] Release 1.0.20160309 of Quagga

Quagga 1.0.20160309 has been released. This release addresses Security Vulnerability VU #270232. Users using VPNv4 to untrusted peers and zebra that have untrusted clients talking to it are advised to upgrade to this release. This release is up on Savannah or download at:

[quagga-dev 14849] Re: XR-Like Commit Feature

David - Thanks for agreeing to present at the monthly meeting. Can't wait to see what you have. thanks! donald On Tue, Mar 8, 2016 at 7:51 AM, David Lamparter wrote: > My plan is to present this at (or directly after, if people want to > split the topic) the

[quagga-dev 14838] Re: [PATCH 5/5] lib: Add ability to use poll() instead of select

more this evening or tomorrow. I might rework 5 a bit more as well. I'm not totally happy with it yet though. donald On Sat, Mar 5, 2016 at 10:15 AM, Paul Jakma <p...@jakma.org> wrote: > On Fri, 4 Mar 2016, Donald Sharp wrote: > > This patch originated w/ Hannes Hofer <hh

[quagga-dev 14833] Re: CI Testresult: FAILED (Re: [quagga-dev, 14831, 5/5] lib: Add ability to use poll() instead of select)

Awesome - HAVE_POLL is defined in net-snmp-config.h I'm spinning up new patches here shortly. donald On Fri, Mar 4, 2016 at 5:20 PM, wrote: > Continous Integration Result: FAILED > > See below for issues. > This is an EXPERIMENTAL automated CI system. > For questions

[quagga-dev 14830] [PATCH 2/5] lib: Abstract fd set operations

Abstract FD set operations so that we can eventually choose what type of select/poll operation that we want to use. Signed-off-by: Donald Sharp <sha...@cumulusnetowkrs.com> --- lib/thread.c | 69 +++- lib/thread.h | 12 --- 2

[quagga-dev 14826] [PATCH 0/5] Refactor lib/thread.c and allow select/poll

Having the ability to scale beyond 1k fd's by using poll is a good thing. Also write code to setup for using a library like libev where we can use a more efficient os agnostic selection mechanism. Denil Vira (1): lib: Replace lists with arrays to store read and write threads Donald Sharp (4

[quagga-dev 14831] [PATCH 5/5] lib: Add ability to use poll() instead of select

This patch originated w/ Hannes Hofer <hho...@barracuda.com>. I've taken the patch fixed some bugs and reworked the code to allow both poll and select to be choosen at compile time. Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com> --- configure.ac | 6 ++ lib/th

[quagga-dev 14827] [PATCH 1/5] lib: Replace lists with arrays to store read and write threads

From: Denil Vira <de...@cumulusnetworks.com> With arrays, a thread corresponding to given fd is looked up in constant time versus the linear time taken for list traversals. Signed-off-by: Denil Vira <de...@cumulusnetworks.com> Signed-off-by: Donald Sharp <sha...@cumulusnetwork

[quagga-dev 14818] Re: Community and governance

Paul - I believe I understand your logic. I'm not sure I agree with it, but I don't have to necessarily :) The one thing that concerns me most is the semantics of 'rounds keeper'. If I go and talk to someone outside of the quagga community and explain what I do( or am attempting to do ) in the

[quagga-dev 14817] Re: XR-Like Commit Feature

David - In addition to a write up would you be willing to present it at the monthly meeting? We have one in a few weeks and I think that would be a good place to get people familiar with it. thanks! donald On Thu, Mar 3, 2016 at 7:13 AM, David Lamparter < equi...@opensourcerouting.org> wrote:

[quagga-dev 14812] Re: [PATCH 10/10] build: goodbye, gawk

On a side note, extract.pl.in as far as I can tell only is used to auto generate the perl binary location. Is there a modern distribution that doesn't have perl in /usr/bin? Would people mind if I removed the extract.pl.in -> extract.pl configure creation? donald On Wed, Mar 2, 2016 at 8:27

[quagga-dev 14808] Re: XR-Like Commit Feature

Alexander - Cumulus has almost all that, except the timer, but that would be 5 minutes with a shell script. Look at the tools/quagga-reload.py script in our cm_2.5 branch on github. We've also written an addition to vtysh which will tell you if your cli is correct and on what line the error is.

[quagga-dev 14805] Re: XR-Like Commit Feature

We've implemented a couple code changes that allow you to modify the /etc/quagga/*.conf files individually and then to load them via a reload script, which diff's the running and the *.conf and only applies the actual changes needed. You could also do a poor man's vtysh -f if you wanted to as

[quagga-dev 14775] Re: [PATCH 04/10] lib: migrate to new memory-type handling

at 7:18 PM, David Lamparter <equi...@diac24.net> wrote: > On Wed, Feb 24, 2016 at 06:25:06PM -0500, Donald Sharp wrote: > > I'm not a big fan of #if 0 or #if 1's introduced with this patch. Is > there > > someway we can mitigate them? > > This is what the comments f

  1   2   3   4   5   6   >