Re: Python API: Delete a user from a review group

2015-09-02 Thread Steven MacLeod
It looks like it's not actually possible to delete a user from a review group using the Python API at the moment. Review Board seems to be returning an incorrect url which points to the user resource itself, rather than the review-group-user resource for the delete link. you can see that by looking

Re: Recommended Approach To Add Review Diff Comments Through API

2015-08-12 Thread Steven MacLeod
The API is expecting you to pass in the "row number" which is you is the number indicating which row of a side by side diff the comment is on. This row number might not match the file line number if your diff contains adds / deletes on either side. The Review Bot project has some MIT licensed code

Re: Plugin for reviewing .doc, .pdf and .xls in reviewboard

2014-07-16 Thread Steven MacLeod
The Review Board Power Pack provides support for reviewing .pdf https://www.reviewboard.org/powerpack/ I don't currently know of an extension for reviewing .doc and .xls inside Review Board, but you can certainly attach them and then download to review. On Wed, Jul 16, 2014 at 6:37 AM, wrote:

Re: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

2014-05-22 Thread Steven MacLeod
Most sites seem to do the opposite of what I want about 50% of the time. I think in this case though since Review Board gives you a diff viewer, you'd generally want to download the diff when clicking "Download Diff", so I vote for changing it. As an aside, here is a firefox add-on I use for deali

Push Based Workflow

2014-02-12 Thread Steven MacLeod
Hi everyone, Over the weekend Mike Conley and I hacked together a little project to allow posting code for review using a push based workflow. The idea is to allow for code to be pushed to a special "reviews" clone which handles creating the review requests. This only took a few hours to throw to

Re: Problem with signal handling in an extension

2013-12-04 Thread Steven MacLeod
Hi, I'm actually the original author of the WebHooks extension. It was originally written as more of a prototype, and probably has a few bugs. You appear to have hit one. What I believe the problem here is most likely, is the webhooks extension doesn't unregister its signal handlers when it shuts

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

2013-09-25 Thread Steven MacLeod
Right after the section you've pasted, you'll see this: After a tool has been installed on a worker, it must be registered with the Review Bot extension, and configured in the admin panel. Registering tools is accomplished in the following manner: 1. Go to the extension list in the admin panel

Re: listing all review groups and users within the group using a python script

2013-09-11 Thread Steven MacLeod
Yes, this can be done using the API. Assuming you have rbtools 5.x installed, the following script should work. Modify for your desired output. It should be noted that this will make a large number of HTTP requests, and is not optimized. from rbtools.api.client import RBClient client = RBClient("

Re: post-review: Error uploading diff

2013-08-20 Thread Steven MacLeod
The minimum Review Board version which fully supports the rbt commands is RB 1.6.12. There were some changes to the web API in this version which rbt relies on. Unfortunately, you won't be able to make use of most of rbt without a newer version of Review Board. Admittedly, the error reporting here

Re: Bitnami Review Board Stack-Issue while running post-review with perforce on windows

2013-07-25 Thread Steven MacLeod
Try changing the "REPOSITORY" field in your .reviewboardrc to be the name of the repository given in the RB admin panel. This is the name you give the repository when configuring it for the first time. On Thu, Jul 25, 2013 at 2:17 AM, RB wrote: > I have set-up Bitnami Review Board stack on wind

Re: ReviewBot Projects

2013-06-28 Thread Steven MacLeod
Hey Ross, Currently this is unsupported. I'm working on a large patch to Review Bot which will include this, along with a number of new features: - Multiple configurations per tool. - Manual execution of tools on review requests using a drop down on the request page. - Better logging of tool exec

Re: post-review with git

2013-05-29 Thread Steven MacLeod
You can create a '.reviewboardrc' file in the top-level of the repository, and add the following line: REPOSITORY = '' where is the name you gave the repository in the Review Board admin panel. This should make things work. On Wed, May 29, 2013 at 5:23 PM, Peter Snelling wrote: > I posted pre

Re: Creating a review with Python API

2013-05-28 Thread Steven MacLeod
uot;, line 95, in set_review_id >> self.review_request = self.root.get_review_request(** >> review_request_id=str_id) >> File ".../rbtools/api/resource.py", line 273, in __getattr__ >> raise AttributeError >> >> I tried get_diffs() as well and

Re: Creating a review with Python API

2013-05-28 Thread Steven MacLeod
(review_request_id=str_id) > File ".../rbtools/api/resource.py", line 273, in __getattr__ > raise AttributeError > > I tried get_diffs() as well and that is also failing with the same error. > > Is there something I need to do differently? > > Regards, > S

Re: Creating a review with Python API

2013-05-20 Thread Steven MacLeod
Hi, 'root.get_review_requests().get_self(id='15583', repository=repository)' will result in a "GET http://.../api/review_requests/?id=15583&repository=" What you're looking for is 'root.get_review_requests().get_item(15583)', or alternatively 'root.get_review_request(review_request_id=15583). The

Re: Problem with RBTools 0.5

2013-04-08 Thread Steven MacLeod
GMT > Vary: Accept,Cookie,Accept-Language > Last-Modified: Mon, 08 Apr 2013 20:24:40 GMT > Allow: GET, POST > Cache-Control: max-age=0 > Content-Type: text/html; charset=utf-8 > > On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod > wrote: > > Hi Robert, > > > > Sor

Re: Problem with RBTools 0.5

2013-04-08 Thread Steven MacLeod
You can download curl for windows here: http://curl.haxx.se/download.html On Mon, Apr 8, 2013 at 1:34 PM, Robert Dailey wrote: > I'm not on Linux, how can I get you what you want on Windows 7? > > On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod > wrote: > > Hi Robert

Re: Problem with RBTools 0.5

2013-04-04 Thread Steven MacLeod
BUG:root:Making HTTP POST request to > http://reviewboard.corp.good.com/api/review-requests/ > > > DEBUG:root:Making HTTP GET request to > http://reviewboard.corp.good.com/api/review-requests/44580/diffs/ > > > Traceback (most recent call last): > > File "C:\Pytho

Re: Problem with RBTools 0.5

2013-03-29 Thread Steven MacLeod
Hi Robert, What version of Review Board is there server running? Could you also provide the output of rbt post -d --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C The post-review script is still part of rbtools 0.5, so you can use that as a

Re: python API: target_people access fails

2013-03-26 Thread Steven MacLeod
Hi, This is an issue with Python versions < 2.6.5. I have a fix for it which will be part of the RBTools 0.5.1 release which is coming soon. On Fri, Mar 22, 2013 at 6:13 PM, Steven MacLeod wrote: > What version of python are you running? > > > On Fri, Mar 22, 2013 at 3:54

Re: python API: target_people access fails

2013-03-22 Thread Steven MacLeod
What version of python are you running? On Fri, Mar 22, 2013 at 3:54 PM, A.M. wrote: > On Fri, 22 Mar 2013 15:25:48 -0400, Steven MacLeod > wrote: > > That looks correct. I'm not quire sure what's going wrong. > > > > Could you provide me with the JSO

Re: python API: target_people access fails

2013-03-22 Thread Steven MacLeod
That looks correct. I'm not quire sure what's going wrong. Could you provide me with the JSON payload being used to create the review request resource. You can get this by running: review_requests = rb_conn.get_root().get_review_ requests(time_added_from=time_added, status='pending', max_results

Re: Creating a new comment, first_line not being used correctly?

2012-09-17 Thread Steven MacLeod
Hi, first_line is in reference to the line numbers of the file diff resource ( http://www.reviewboard.org/docs/manual/1.6/webapi/2.0/resources/file-diff/). This number doesn't correspond to either the left or right pane of the diff, but a combination of the two. If you were to count down the rows

Re: install RB extension

2012-09-13 Thread Steven MacLeod
Hi, Extensions are not supported in version 1.6.1, support starts in version 1.7 which is currently in beta. Note that 1.7 is still unstable and not recommended for production use yet. Steve On Thu, Sep 13, 2012 at 7:28 AM, Nilesh Jaiswal wrote: > Hi All, > > Presently i am using RB server 1.6.

Re: When i use "post-review", always get the "No supported repository could be accessed at the supplied url."

2012-08-07 Thread Steven MacLeod
It appears that post-review does not support Bazaar yet. There is an issue for this in this tracker: http://code.google.com/p/reviewboard/issues/detail?id=773 And some discussion about working on a patch (From May) can be found in this mailing list thread: https://groups.google.com/d/topic/review

Re: Installing the Web Hooks extension

2012-06-25 Thread Steven MacLeod
Hey Rodrigo, I'm the author of the Web Hooks extension. I believe it should be compatible with the latest 1.7 dev code, as I don't remember any changes which would have broken it since it was committed. As for not running a production site off of 1.7, the Web Hooks extension is even less ready fo

Re: Post-Commit in server side?

2012-03-08 Thread Steven MacLeod
I've never done this myself, but I think it's probably possible. SVN has a number of hook points where you can run scripts, including a post-commit hook. After a quick search I found this: http://svnbook.red-bean.com/en/1.6/svn.reposadmin.create.html#svn.reposadmin.create.hooks On Thursday, Mar

Re: post-commit reviews for svn

2012-02-22 Thread Steven MacLeod
My understanding is the web UI does not support post commit reviews. For this you must use the post-review tool (which is part of RBTools). I think this is what you're looking for: http://www.reviewboard.org/docs/manual/1.6/users/tools/post-review/#posting-committed-code -- Want to help the R

Re: Extension's ModelAdmin and AdminSite

2012-02-19 Thread Steven MacLeod
The bug with Recent Actions in the admin sites seems to be an issue with django.contrib.admin itself. I've filed an issue with django. https://code.djangoproject.com/ticket/17726 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us kno

Re: Extension's ModelAdmin and AdminSite

2012-02-16 Thread Steven MacLeod
An initial review request is up containing the change. http://reviews.reviewboard.org/r/2888/ It is not a complete solution yet, as a small bug exists making it unsuitable for integration. Any input on fixing the bug would be appreciated (please see review request) -- Want to help the Review

Re: Extension's ModelAdmin and AdminSite

2012-02-12 Thread Steven MacLeod
After a design discussion with ChipX86, the plans have changed a little. Instead of allowing extensions to register with the Review Board admin site, I'm going to add support for extensions to have their own admin site instance. By specifying a flag in your extension (similar to how you may set

Re: Calling a script after review submission

2012-02-12 Thread Steven MacLeod
I think writing an extension to do what you want would be your best bet. Using an extension you could listen to one of the review signals (not sure which one you need), and run your script in your extension (the extensions are python after all). The signals you are interested in are probably in

Re: Extension's ModelAdmin and AdminSite

2012-02-11 Thread Steven MacLeod
I came up against this issue myself recently. Currently Djblets has nothing implemented to import the admin.py files from extensions. " django has a function that scans all admin.py files in INSTALLED_APPS and imports them, causing registers to happen" I've started adding something similar to Dj