Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #3 on issue 1382 by robert.munteanu: Inline review comments are not saved with Firefox 3.6 http://code.google.com/p/reviewboard/issues/detail?id=1382 1. It is the big review dialog. The comments are present in the diff viewer, even if I go to the View reviews page and then come back to the diff viewer. But once I go to 'Edit review' to publish the review, the inline comments are empty, but the lines they are attached to are listed as expected. 2.Shift-reload does not change anything. This was working properly on Firefox 3.5 FWIW. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #4 on issue 1382 by robert.munteanu: Inline review comments are not saved with Firefox 3.6 http://code.google.com/p/reviewboard/issues/detail?id=1382 This is how the comments section of the review dialog appears. The comment line ( 22 here ) is attached, with the proper contents, but the comment text ( 'Sample comment' ) is instead empty. Attachments: review-board-missing-comment.jpg 14.1 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #5 on issue 1382 by robert.munteanu: Inline review comments are not
saved with Firefox 3.6
http://code.google.com/p/reviewboard/issues/detail?id=1382
Firebug does not catch any errors, and I got the following XMLHttpRequest
message:
pre
div id=review-form-comments class=review
pinput id=id_shipit class=recommendation type=checkbox / label
for=id_shipitShip It/label/p
pre class=body-top editable/pre
div class=comments
dl class=diff-comments
dt
div id=review_draft_comment_container_191
table class=sidebyside loading
thead
tr
th class=filename
a name=/r/47/diff/5/?file=312#file312line22/xxxfile/a
span class=diffrevision
(Diff revision 5)
/span
/th
/tr
/thead
tbody
trtdprenbsp;/pre/th/tr
/tbody
/table
/div
/dt
dd
pre class=editable comment-editable id=diff-comment-191Sample
comment./pre
script type=text/javascript
var editor = $(#diff-comment-191).reviewFormCommentEditor({
path: getDiffAPIPath(5,
312,
null, null,
22),
data: {
action: set,
num_lines: 1
}
});
$(#edit-diff-comment-191).click(function() {
editor.inlineEditor(startEdit);
});
queueLoadDiffFragment(review_draft_diff_comments, 191,
312
);
/script
/dd
/dl
/div
pre class=body-bottom editable/pre
/div
/pre
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #6 on issue 1382 by robert.munteanu: Inline review comments are not
saved with Firefox 3.6
http://code.google.com/p/reviewboard/issues/detail?id=1382
Firebug does not catch any errors, and I got the following XMLHttpRequest
message:
div id=review-form-comments class=review
pinput id=id_shipit class=recommendation type=checkbox / label
for=id_shipitShip It/label/p
pre class=body-top editable/pre
div class=comments
dl class=diff-comments
dt
div id=review_draft_comment_container_191
table class=sidebyside loading
thead
tr
th class=filename
a name=/r/47/diff/5/?file=312#file312line22/xxxfile/a
span class=diffrevision
(Diff revision 5)
/span
/th
/tr
/thead
tbody
trtdprenbsp;/pre/th/tr
/tbody
/table
/div
/dt
dd
pre class=editable comment-editable id=diff-comment-191Sample
comment./pre
script type=text/javascript
var editor = $(#diff-comment-191).reviewFormCommentEditor({
path: getDiffAPIPath(5,
312,
null, null,
22),
data: {
action: set,
num_lines: 1
}
});
$(#edit-diff-comment-191).click(function() {
editor.inlineEditor(startEdit);
});
queueLoadDiffFragment(review_draft_diff_comments, 191,
312
);
/script
/dd
/dl
/div
pre class=body-bottom editable/pre
/div
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #1 on issue 1382 by robert.munteanu: Inline review comments are not saved with Firefox 3.6 http://code.google.com/p/reviewboard/issues/detail?id=1382 Just noticed that if I save the comments ( draft review ) with FF 3.6 and then edit the review e.g. with Chromium, the comments are visible. If I edit the review with FF 3.6 they are not visible. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1383 in reviewboard: RBTools easy_install on py26 fails when trying to install simplejson
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1383 by p...@swooby.com: RBTools easy_install on py26 fails when trying to install simplejson http://code.google.com/p/reviewboard/issues/detail?id=1383 *NOTE: Do not post confidential information in this bug report.* What version are you running? post-review-script.py 0.8 What's the URL of the page containing the problem? n/a What steps will reproduce the problem? 1. Install py26 2. Install setuptools for py26 3. easy_install -U RBtools What is the expected output? What do you see instead? Install should be successful. Instead, install fails when trying to install the simplejson egg. This initially makes sense, because simplejson has no py26 installer. However, according to the simplejson site, simplejson is built in to py26. The net effect is that easy_install RBTool should be be installing simplejson in py26. What operating system are you using? What browser? XP/Vista Please provide any additional information below. Per Christian Hammond: We just need to turn off the sqlite dependency when building Python 2.6 packages. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Updates: Status: NeedInfo Comment #2 on issue 1382 by chipx86: Inline review comments are not saved with Firefox 3.6 http://code.google.com/p/reviewboard/issues/detail?id=1382 Is this in the big review dialog, or comment flags in the diff viewer? Does shift-reload fix anything? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1381 in reviewboard: diff update doesn't work in web GUI and in post-review utility
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1381 by ostocek: diff update doesn't work in web GUI and in
post-review utility
http://code.google.com/p/reviewboard/issues/detail?id=1381
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.0.5.1
What's the URL of the page containing the problem?
https://ourdevelserver/rb/r/187/diff/
What steps will reproduce the problem?
1. Create a request with diff (works fine)
2. Try to update diff by Upload diff form
What is the expected output? What do you see instead?
The error is displayed with this detail message
{fields: {path: [The diff file is empty]}, stat: fail, err:
{msg: One or more fields had errors, code: 105}}
when I try post-review in the terminal, problem is following:
$ post-review -p -r 187 --description some message
== HTTP Authentication Required
Enter username and password for at ourdevelserver
Username: user
Password:
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.
What operating system are you using? What browser?
Firefox 3.5.1, Opera 10.0.1
Please provide any additional information below.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #30 on issue 1072 by chipx86: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 Did my recommendations not work out for setting those environment variables? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #31 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 yes，I did, see attached screenshot. I still got the error HTTPS certificate not accepted. Please ensure that the proper certificate exists in C:/Documents and Settings/yunshandi/.subversion/auth for the user that reviewboard is running as. But the certificate does exist under the .subversion/auth. Attachments: env.png 16.1 KB failed.png 16.4 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #32 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 I followed the step: 2) Figure out what the home directory is for Apache (I don't know on Windows, but you may be able to figure it out by turning on logging and temporarily modifying, say, reviewboard/__init__.py to add: logging.info(Home directory = %s % os.path.expanduser(~)) After restart apache, check the apache log, and found a few errors Attachments: apache-log.txt 15.6 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #34 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 I have tried anyway i can do, still no help on this issue, i will work on the issue until it works, and i still wish someone could help me to workaround it, many thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #35 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 I have tried anyway i can do, still no help on this issue, i will work on the issue until it works, and i still hope someone could help me to workaround it, many thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 953 in reviewboard: Hg SCMTool doesn't support old mercurial installs
Comment #4 on issue 953 by deuresti79: Hg SCMTool doesn't support old mercurial installs http://code.google.com/p/reviewboard/issues/detail?id=953 I think there are two bugs here. #1 Not supporting old mercurial installs like sandeep says. #2 Not supporting ssh HG repositories (even in newer versions of mercurial sshrepository doesn't have a changectx) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #36 on issue 1072 by chipx86: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 At this point, I recommend taking this to the mailing list and referencing this bug. The original bug is fixed in 1.1, and we don't support HTTPS in any official capacity for 1.0. You would have to see if other people have workarounds they've used. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1379 in reviewboard: Display comment flags for previous diff revisions
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1379 by nathan.auch: Display comment flags for previous diff revisions http://code.google.com/p/reviewboard/issues/detail?id=1379 What version are you running? ReviewBoard 1.0 alpha 4 What's the URL of the page this enhancement relates to, if any? Diffviewer - http://hostname/r/xxx/diff/ Describe the enhancement and the motivation for it: Comment flags are only displayed for the revision of the diff currently being viewed. It would be nice if these were displayed regardless of the diff revision selected. If a reviewer makes a comment on a specific line of code and the submitter uploads a new diff (that does not address the comment) it is difficult to tell when viewing the diff that a comment for this line has already been made. This confusion is further increased when multiple reviewers are reviewing a request at different times and would like to avoid making duplicate comments. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1379 in reviewboard: Display comment flags for previous diff revisions
Updates: Status: Duplicate Mergedinto: 514 Comment #1 on issue 1379 by chipx86: Display comment flags for previous diff revisions http://code.google.com/p/reviewboard/issues/detail?id=1379 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 514 in reviewboard: Comments don't show between multiple versions of a review
Comment #5 on issue 514 by chipx86: Comments don't show between multiple versions of a review http://code.google.com/p/reviewboard/issues/detail?id=514 Issue 1379 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1360 in reviewboard: Can not see diff when the diff was uploaded with parent option on post-review
Comment #1 on issue 1360 by owen.yamauchi: Can not see diff when the diff was uploaded with parent option on post-review http://code.google.com/p/reviewboard/issues/detail?id=1360 The -t option doesn't actually do the right thing - you should get a reversed diff with that flag on. The problem seems to be that the file RB is trying to patch has already been patched. Previously applied patch detected is correct. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1374 in reviewboard: Installation/configuration issue
Comment #1 on issue 1374 by pmuralidharan: Installation/configuration issue http://code.google.com/p/reviewboard/issues/detail?id=1374 Now i got the page to view the following contents. But no one is accessible. I mean if i click Register URL goes to rft-test/account/register but there is no change in my page. And i found any folder which named account under the created site. but is not available. * Log in * - Register * - Documentation * - Bugs * - Report bug Review Board 1.0.5.1 * All review requests * Groups * Submitters The page you were looking for does not exist. If you're pretty sure this page does exist, try logging in and trying again. Thanks Murali -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1374 in reviewboard: Installation/configuration issue
Comment #2 on issue 1374 by pmuralidharan: Installation/configuration issue http://code.google.com/p/reviewboard/issues/detail?id=1374 Now i got the page to view the following contents. But no one is accessible. I mean if i click Register link then the URL goes to rft-test/account/register but there is no change in my page. And i try to find any folders which named account, groups, users, account/register and account/login under the root dir of the created site. but it is not available. * Log in * - Register * - Documentation * - Bugs * - Report bug Review Board 1.0.5.1 * All review requests * Groups * Submitters The page you were looking for does not exist. If you're pretty sure this page does exist, try logging in and trying again. Thanks Murali -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1376 in reviewboard: post-review: --repository-url pointing to a file doesn't work
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1376 by niko...@prokoschenko.de: post-review: --repository-url pointing to a file doesn't work http://code.google.com/p/reviewboard/issues/detail?id=1376 What version are you running? 1.1a2 What steps will reproduce the problem? 1. Try to create a review with --repository- url=http://server/svn/path/to/file.txt 2. post-review will try to upload a diff with http://server/svn/path/to/file.txt/file.txt as filename, which wouldn't be found 3. --repository-url=http://server/svn/path/to/ performs ok, but possibly includes more files than needed. What is the expected output? What do you see instead? post-review should create a post-commit review for this one file Please provide any additional information below. Would be really nice if diffing single files would be possible without the need for the exact URL! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1374 in reviewboard: Installation/configuration issue
Updates: Status: Invalid Comment #3 on issue 1374 by chipx86: Installation/configuration issue http://code.google.com/p/reviewboard/issues/detail?id=1374 These are support issues, and should be on the mailing list instead of the bug tracker. Can you post to the mailing list (reviewbo...@googlegroups.com) and post your Apache configuration file? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1376 in reviewboard: post-review: --repository-url pointing to a file doesn't work
Comment #2 on issue 1376 by niko...@prokoschenko.de: post-review: --repository-url pointing to a file doesn't work http://code.google.com/p/reviewboard/issues/detail?id=1376 It makes perfect sense to me. A little explanation might be in order :) Use case: I've got a developer who'd like to have his committed changes to a file file.txt reviewed, let's say he started at revision 100 and finished at revision 150. There have been five commits, so his commits are probably at 100, 110, 120, 130, 140 and 150 -- but this doesn't really matter, it matters that there were no other changes to that file in the meantime, he's been the only developer. Now I've been asked how to create a review for that. Normally, svn diff -r 100:150 file.txt would generate a proper diff, however post-review doesn't support filenames for revision ranges. So I looked into documentation and notices -- repository-url parameter. Since in SVN every URL inside a repository may be checked out independently, I tried to use http://svn.server/svn/path/to/file.txt as repository URL. post-review -d -n --revision-range=100:150 --repository- url=http://svn.server/svn/path/to/file.txt; ran without problems and has produced proper diff for that single file for revisions 100 to 150. It's only when post- review tried to submit that diff to Review Board that problems began. post-review replaced the Info: field in the diff with http://svn.server/svn/path/to/file.txt/file.txt; (previously just file.txt) assuming that filename in the diff should be attached to the base path given as -- repository-url. This is not really correct -- if the URL points to a file, that filename should be removed from the path between diffing and uploading to Review Board. In that case, filename gets attached properly and RB accepts the diff. That said, I fully understand that I might be bending RB's strain features quite a bit and would prefer doing this all properly. For that, I'd need a way to review changes to single files over several commits -- again, I know developer discipline is probably the Right Way (tm) to go, but my fellow developers don't even grasp the necessity for proper commit messages, not to mention proper atomic bundling of changes. I hope this explanation made it a bit clearer to you. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Comment on ReviewBoardAPI in reviewboard
Comment by p...@swooby.com:
Python example:
import simplejson
import sys
import urllib
class ReviewBoard:
def __init__(self, server, username, password):
self.server = server
self.username = username
self.password = password
def Run(self, command, params=None, throw=True):
if params:
params = urllib.urlencode(params)
url = 'http://%s/api/json/%s/' % (self.server, command)
f = urllib.urlopen(url, params)
# TODO: Request Error handling...
s = f.read()
response = simplejson.loads(s)
self.OK(response, throw)
return response
def OK(self, response, throw=False):
ok = response['stat'] == 'ok'
if not ok and throw:
raise Exception('ReviewBoard response stat not ok')
return ok
def Login(self, username=None, password=None):
if username is None:
username = self.username
if password is None:
password = self.password
rb.Run('accounts/login', {'username': username, 'password': password})
if __name__ == '__main__':
reviewers = ['larry', 'moe', 'curly']
rb = ReviewBoard('10.100.120.86', 'username', 'password')
rb.Login()
response = rb.Run('reviewrequests/11/reviews')
reviews = response['reviews']
for review in reviews:
reviewer = review['user']['username']
ship_it = review['ship_it']
if reviewer in reviewers and ship_it:
print '%s SAYS SHIP IT!' % reviewer.upper()
For more information:
http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 1366 in reviewboard: Group netster is not recognized by review board
Updates: Status: Invalid Comment #1 on issue 1366 by chipx86: Group netster is not recognized by review board http://code.google.com/p/reviewboard/issues/detail?id=1366 This is the issue tracker for bugs in Review Board, which is an open source project used by many companies. You should contact your system administrator. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #10 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Unfortunately, I can't confirm the fix. The issue is still present in version 1.0.5 in our installation (tested with Chromium 4.0.222.4, Firefox 3 and 3.5; all in Linux). The link Expand behaves still the same way as in 1.0.4. It is sending wrong requests as described in comments #2 and #5 above. I don't see our configuration obscure in any way; it is the following: Response Headers DateFri, 23 Oct 2009 22:31:23 GMT Server Apache/2.2.9 (Debian) DAV/2 SVN/1.5.1 mod_jk/1.2.26 PHP/5.2.6-1+lenny3 with Suhosin-Patch mod_python/3.3.1 Python/2.5.2 mod_ssl/2.2.9 OpenSSL/0.9.8g mod_perl/2.0.4 Perl/v5.10.0 Content-Length 232 Content-Languageen-us Content-Encodinggzip VaryCookie,Accept-Language,Accept-Encoding Content-Typetext/html; charset=utf-8 Keep-Alive timeout=15, max=100 Connection Keep-Alive Request Headers Host... User-Agent Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 Accept text/html, */* Accept-Language en,en-us;q=0.8,fr;q=0.5,fr-fr;q=0.3 Accept-Encoding gzip,deflate Accept-Charset UTF-8,* Keep-Alive 300 Connection keep-alive X-Requested-WithXMLHttpRequest Referer https://.../rb/r/171/diff/ Cookie rbsessionid=ae1bc5f72f8e0af9e9f8de5d857676be; ... -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #12 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Yes, I restarted both apache and memcached (and tried also disabling memcached), reloaded the page multiple times, cleared the browser cache and tested it also in Chromium's incognito mode.. ..just to be sure. And I think there is not a problem with any cache, because it works immediately after downgrading to 1.0.1. What about checking changes in the diff viewer between 1.0.1 and 1.0.3? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1363 in reviewboard: API: /api/json/reviewrequests/review_request_id/reviews/ -- Non-existent reviews return 404 not found
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1363 by cybrocop: API: /api/json/reviewrequests/review_request_id/reviews/ -- Non-existent reviews return 404 not found http://code.google.com/p/reviewboard/issues/detail?id=1363 *NOTE: Do not post confidential information in this bug report.* What version are you running? ReviewBoard-1.1alpha1.dev_r2026 What's the URL of the page containing the problem? http://Reviewboard/api/json/reviewrequests/review_request_id/ What steps will reproduce the problem? 1. Create a new review (i.e. Review ID: 123) 2. Delete the review completely. 3. Request the review through the API What is the expected output? What do you see instead? I get a 404 Not Found error. If the review looks like a valid review ID, then instead of 404 I should get a JSON formatted error indicating that the review id was not found. The 404 exception doesn't tell me if the review was not found. It simply tells me there was some server error. Maybe RB is mis-configured. Maybe I'm querying the wrong server. Maybe you will disagree that this is a defect, but I thought I should mention it anyway. The workaround I'm using now is catching 404 exceptions and *assuming* that this means the requested review doesn't exist. What operating system are you using? What browser? N/A Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1363 in reviewboard: API: /api/json/reviewrequests/review_request_id/reviews/ -- Non-existent reviews return 404 not found
Updates: Status: NotABug Owner: chipx86 Labels: Component-API Comment #1 on issue 1363 by chipx86: API: /api/json/reviewrequests/review_request_id/reviews/ -- Non-existent reviews return 404 not found http://code.google.com/p/reviewboard/issues/detail?id=1363 This is how a proper REST API should behave. In fact, we should be doing this more than we do. 404 means not found and in this case, that's exactly the correct response. The idea of REST is that you make use of HTTP's built-in methods and responses as much as possible, since they're universally supported. If you want to get something without any side-effects on the server, you use a GET. If you want to post something, you use a POST. And so on. Likewise, built-in HTTP statuses should be used, since clients all understand them. Now, we don't do nearly as good a job as we should do. We don't use PUT, DELETE, etc., and we don't always use the response codes 100% correctly, but in this case, it is correct. Maybe down the road we could supply a JSON payload along with the 404 (as most error codes can also return page content). This is a nice to have, but won't happen for 1.1. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1360 in reviewboard: Can not see diff when the diff was uploaded with parent option on post-review
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1360 by TAKAHASHI.Kazuyoshi: Can not see diff when the diff was uploaded with parent option on post-review http://code.google.com/p/reviewboard/issues/detail?id=1360 What version are you running? ReviewBoard 1.0.4, RBTools Beta2 What's the URL of the page containing the problem? r/xxx/diff/#index_header What steps will reproduce the problem? 1. post-review --parent=topicA --summary=testA on topicB (branch of topicA). 2. goto the page above. What is the expected output? What do you see instead? expected: could see diff. got: Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/views.py, line 153, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/lib/python2.4/site-packages/Djblets-0.5.4-py2.4.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 126, in patch raise Exception(_(The patch to '%s' didn't apply cleanly. The temporary + Exception: The patch to 'adm/Rakefile' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.xXkaH8' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.xXkaH8/tmpydvPxC Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.xXkaH8/tmpydvPxC-new.rej What operating system are you using? What browser? OS: Cent OS 5.2 Browser: Safari 4.0.3 Please provide any additional information below. I've added -t option at diffutils.py as below. and it works. Here it is... --- /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/diffutils-old.py 2009-10-20 19:08:10.0 +0900 +++ /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4- py2.4.egg/reviewboard/diffviewer/diffutils.py 2009-10-20 19:08:27.0 +0900 @@ -104,7 +104,7 @@ # XXX: catch exception if Popen fails? newfile = '%s-new' % oldfile -p = subprocess.Popen(['patch', '-o', newfile, oldfile], +p = subprocess.Popen(['patch', '-t', '-o', newfile, oldfile], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) p.stdin.write(diff) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 654 in reviewboard: Allow user to reorder the files being diffed
Comment #3 on issue 654 by cybrocop: Allow user to reorder the files being diffed http://code.google.com/p/reviewboard/issues/detail?id=654 Sorting based on file status would be interesting. I personally, would like to see deleted files first. This is because if the author has moved many files around or done re-factoring as a result of which files no longer exist, it would be preferable to see those files first. Then follow the trail and see where the code went. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1196 in reviewboard: Statistics are not available for this backend
Comment #10 on issue 1196 by markbroehm: Statistics are not available for this backend http://code.google.com/p/reviewboard/issues/detail?id=1196 Realized that i have both installed: net-misc/memcached-1.4.1 dev-python/python-memcached-1.40 dev-lang/python-2.5.4-r2 reviewboard ~ # telnet localhost 11211 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. stats STAT pid 2263 STAT uptime 1206023 STAT time 1256047646 STAT version 1.4.1 STAT pointer_size 32 STAT rusage_user 6.524407 STAT rusage_system 17.825114 STAT curr_connections 5 STAT total_connections 11595 STAT connection_structures 8 STAT cmd_get 14386 STAT cmd_set 1217 STAT cmd_flush 0 STAT get_hits 2104 STAT get_misses 12282 STAT delete_misses 0 STAT delete_hits 0 STAT incr_misses 0 STAT incr_hits 0 STAT decr_misses 0 STAT decr_hits 0 STAT cas_misses 0 STAT cas_hits 0 STAT cas_badval 0 STAT bytes_read 35665771 STAT bytes_written 65854408 STAT limit_maxbytes 134217728 STAT accepting_conns 1 STAT listen_disabled_num 0 STAT threads 5 STAT conn_yields 0 STAT bytes 34614404 STAT curr_items 1213 STAT total_items 1217 STAT evictions 0 END -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1196 in reviewboard: Statistics are not available for this backend
Comment #11 on issue 1196 by markbroehm: Statistics are not available for this backend http://code.google.com/p/reviewboard/issues/detail?id=1196 from the above posts by lonico, i see the siteconfig_siteconfiguration table has cache_backend: locmem:/// - is that the problem with my setup? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1196 in reviewboard: Statistics are not available for this backend
Comment #12 on issue 1196 by markbroehm: Statistics are not available for this backend http://code.google.com/p/reviewboard/issues/detail?id=1196 So i tried changing the siteconfig_siteconfiguration table as follows and it works. sweet. OLD: cache_backend: locmem:/// NEW: cache_backend: memcached://127.0.0.1:11211/ results (after restarting apache and memcached): Server Cache Cache backend: django.core.cache.backends.memcached Statistics 127.0.0.1:11211 Memory usage: 2.9 KB Keys in cache: 1 of 1 Cache hits: 0 of 4: 0% Cache misses: 4 of 4: 100% Cache evictions: 0 Cache traffic: 3.2 KB in, 759 bytes out Uptime: 41 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1162 in reviewboard: post-review ignores all but first target file when using --revision-changes
Comment #2 on issue 1162 by cpforbes: post-review ignores all but first target file when using --revision-changes http://code.google.com/p/reviewboard/issues/detail?id=1162 The case where --repository-url=url is not specified is not handled. the do_diff call on line 1137 also needs the files added to the command. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1361 in reviewboard: When space is added before a username on the People field I got Error 500
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1361 by frank.x.liu: When space is added before a username on the People field I got Error 500 http://code.google.com/p/reviewboard/issues/detail?id=1361 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0 RC2 What's the URL of the page containing the problem? Review details What steps will reproduce the problem? 1. put a reviewer's name 2. add space before the name 3. fill in summary and descript 4. publish What is the expected output? What do you see instead? The review details should be saved What operating system are you using? What browser? ubuntu, Firefox Please provide any additional information below. We use LDap authentication What may be happening is the the user with space before it is not found in the LDAP authentication. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 728 in reviewboard: Whitespace not stripped on username
Comment #3 on issue 728 by chipx86: Whitespace not stripped on username http://code.google.com/p/reviewboard/issues/detail?id=728 Issue 1361 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1361 in reviewboard: When space is added before a username on the People field I got Error 500
Updates: Status: Duplicate Mergedinto: 728 Comment #1 on issue 1361 by chipx86: When space is added before a username on the People field I got Error 500 http://code.google.com/p/reviewboard/issues/detail?id=1361 1.0 RC2 is pretty ancient. This has since been fixed. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #27 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 I'm still trying to find solution for the issue, unfortunately... I found another webapp(in python), which is similar to Review Board, and it solved the problem about the https authentication support. attached here for reference. ref: http://transifex.org/browser/transifex/vcs/lib/types/svn.py?rev=946% 3Ae2782e83e8dd Attachments: svn.py 7.0 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1125 in reviewboard: server port number is missing in review request email
Comment #7 on issue 1125 by schettino72: server port number is missing in review request email http://code.google.com/p/reviewboard/issues/detail?id=1125 works for me :) thanks a lot! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #28 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 I'm still trying to find solution for the issue, unfortunately... I found another webapp(in python), which is similar to Review Board in dealing with access to SVN repository, and it solved the problem about the https authentication support. Attached source code here for further reference. ref: http://transifex.org/browser/transifex/vcs/lib/types/svn.py?rev=946% 3Ae2782e83e8dd Wish it be useful to solved the issue. Attachments: svn.py 7.0 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1359 in reviewboard: Diff fails for text file with non-ascii characters
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1359 by pinge...@yahoo.com: Diff fails for text file with non-ascii characters http://code.google.com/p/reviewboard/issues/detail?id=1359 What version are you running? Review board 1.0 on Python 2.4 What's the URL of the page containing the problem? http://omitted/reviews/r/658/diff/#index_header What steps will reproduce the problem? 1. Create a text file containing the byte 0xED (in Windows, Alt+0237) This character corresponds to the latin small letter i with acute in the Windows Western encoding. 2. Check this into source control 3. Edit the file to replace this character with a lowercase 'i' 4. Post the change to review board 5. Attempt to view the diff (This actually happened to me today -- I was trying to fix a source file that had this non-ascii, non utf-8 character in a docstring) What is the expected output? What do you see instead? I would expect to see a diff, possibly with invalid characters replaced by hexadecimal representations. Instead I get the following traceback: 'ascii' codec can't decode byte 0xc3 in position 26: ordinal not in range(128) Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/diffviewer/views.py, line 152, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/lib/python2.4/site-packages/Djblets-0.5-py2.4.egg/djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 434, in get_chunks a[i1:i2], b[j1:j2], oldlines, newlines) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 268, in diff_line if oldline and newline and oldline != newline: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 26: ordinal not in range(128) What operating system are you using? What browser? Firefox 3.5.3 on Windows XP SP3 Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1196 in reviewboard: Statistics are not available for this backend
Comment #8 on issue 1196 by lonico: Statistics are not available for this
backend
http://code.google.com/p/reviewboard/issues/detail?id=1196
I agree it's a different issue, so maybe it's not the right place to
discuss it
I see it too with 1.4. I added a variable in reviewboard/settings.py
# Load local settings. This can override anything in here, but at the very
# least it needs to define database connectivity.
try:
import settings_local
from settings_local import *
except ImportError:
dependency_error('Unable to read settings_local.py.')
LN_CACHE_BACKEND = CACHE_BACKEND
TEMPLATE_DEBUG = DEBUG
And when I try to print it in reviewboard/admin/views.py
logging.debug(settings.CACHE_BACKEND)
logging.debug(=)
logging.debug(settings.LN_CACHE_BACKEND)
This is what I got:
2009-10-19 16:59:24,116 - DEBUG - file:///tmp/reviewboard_cache
2009-10-19 16:59:24,116 - DEBUG - =
2009-10-19 16:59:24,116 - DEBUG - memcached://127.0.0.1:11211/
So clearly settings.CACHE_BACKEND has been modifed in the meantime, but I
cannot find
where.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 1196 in reviewboard: Statistics are not available for this backend
Comment #9 on issue 1196 by lonico: Statistics are not available for this backend http://code.google.com/p/reviewboard/issues/detail?id=1196 I found a discrepancy between settings_local.py and the siteconfig_siteconfiguration table in MySQL. The table had the file:///tmp/reviewboard_cache entry, but it did not prevent memcached from being in use. I believed the discrepancy is because I first installed Review Board without memcached, and then reinstalled it with memcached. I did not delete the tables, and rb-site does not check for that. I had an error because admin was already defined, but I bypassed the issue by using admin2. After fixing the table, I can see the cache statistics :) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 489 in reviewboard: [ ] DON'T SHIP IT button
Updates: Labels: -Milestone-Release1.1 Milestone-Release1.5 Comment #16 on issue 489 by chipx86: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 A lot of discussion and design needs to take place regarding this and the proposals for comment types (which likely will not be happening as part of the core Review Board product, but that's another discussion). I don't feel comfortable making this part of the 1.1 plans. Moving back to 1.5. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 783 in reviewboard: Could a preference be added to disable animation?
Updates: Status: NeedInfo Comment #6 on issue 783 by chipx86: Could a preference be added to disable animation? http://code.google.com/p/reviewboard/issues/detail?id=783 James, remind me what browser you're using? Due to server and client-side caching implications, I would much much rather this be implemented as a Stylish or Greasemonkey script, which obviously wouldn't work for IE, but would for Firefox. If we implement this in Review Board, it means changing pretty much all the caching logic to handle this one preference, which 99% of users will probably never need to be honest :/ Doing it browser-side means that we don't have to change all this code and only those users who really need this disabled could disable it. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1299 in reviewboard: Link back to dashboard from admin page
Updates: Labels: -Milestone-Release1.1 Milestone-Release1.5 Comment #2 on issue 1299 by chipx86: Link back to dashboard from admin page http://code.google.com/p/reviewboard/issues/detail?id=1299 I want to rethink the admin UI, and this won't happen for 1.1. There's no place in the current admin UI header area that I really like for this that's obvious. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 242 in reviewboard: OpenID authentication support
Updates: Owner: trowbrds Comment #7 on issue 242 by chipx86: OpenID authentication support http://code.google.com/p/reviewboard/issues/detail?id=242 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 783 in reviewboard: Could a preference be added to disable animation?
Comment #7 on issue 783 by jamesdlin: Could a preference be added to disable animation? http://code.google.com/p/reviewboard/issues/detail?id=783 I'm using Firefox. A Stylish or Greasemonkey solution would be fine with me. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1356 in reviewboard: error while updating diff on review board
Updates: Status: WontFix Labels: VMware Comment #1 on issue 1356 by chipx86: error while updating diff on review board http://code.google.com/p/reviewboard/issues/detail?id=1356 Please file a helpzilla ticket at work. The version at VMware is pretty old now, there's not enough information in this report for us to determine anything, and any information you would have that we'd need probably couldn't be posted here (such as the diff). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1125 in reviewboard: server port number is missing in review request email
Updates: Status: NeedInfo Comment #6 on issue 1125 by chipx86: server port number is missing in review request email http://code.google.com/p/reviewboard/issues/detail?id=1125 Can you guys try this with 1.0.4? This should be fixed now. We loosened restrictions on the server field, and I'm able to specify a port fine. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1346 in reviewboard: Unable to view/delete unnamed discarded review request
Updates: Status: Fixed Owner: chipx86 Labels: Component-Admin Milestone-Release1.0.x Comment #3 on issue 1346 by chipx86: Unable to view/delete unnamed discarded review request http://code.google.com/p/reviewboard/issues/detail?id=1346 Fixed on master and release-1.0.x (r2947b00) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1277 in reviewboard: Comment Types
Comment #4 on issue 1277 by vi...@djgraphite.com: Comment Types http://code.google.com/p/reviewboard/issues/detail?id=1277 I think that while this is a good idea in spirit, I'm not sure it would work in practice. I don't think severity is useful in the case of code reviews in the same way that severity isn't all that useful in the case of bugs (wait for the explanation). In the case of bugs, in most cases, there are a few people who have a the big picture of the product and set the relative severity of the bugs. In this case however, it sounds like the commenter would set the priority. That's probably not a good way to go. I do like the idea of having comment types - a defect checkbox, or a checkbox that additionally says that security might be a concern. This classifies them without priority. I think it's up to the developer to read _all_ of the comments and then prioritize and address them. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1357 in reviewboard: XMPP chat notification of request changes
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1357 by gic...@gmail.com: XMPP chat notification of request changes http://code.google.com/p/reviewboard/issues/detail?id=1357 Is there a general notification API one can implement to observe changes in review requests? It would be cool if an RB bot could be created to hang out on an XMPP chat and provide updates as relevant review requests change, spit out information on reviews when they are mentioned or when asked, etc. Idea could also be extended to IRC or to simple unicast notifications for any IM network. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1357 in reviewboard: XMPP chat notification of request changes
Updates: Status: Duplicate Mergedinto: 488 Comment #1 on issue 1357 by trowbrds: XMPP chat notification of request changes http://code.google.com/p/reviewboard/issues/detail?id=1357 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 488 in reviewboard: Instant messaging integration
Comment #4 on issue 488 by trowbrds: Instant messaging integration http://code.google.com/p/reviewboard/issues/detail?id=488 Issue 1357 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1355 in reviewboard: Text Box Label and Size Issues for New Review Request and Update Diff windows
Updates: Status: Confirmed Labels: Milestone-Release1.1 Component-Reviews EasyFix Comment #1 on issue 1355 by chipx86: Text Box Label and Size Issues for New Review Request and Update Diff windows http://code.google.com/p/reviewboard/issues/detail?id=1355 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1354 in reviewboard: Google chrome text editing fields expand
Comment #2 on issue 1354 by christopher.james.lahey: Google chrome text editing fields expand http://code.google.com/p/reviewboard/issues/detail?id=1354 How do I find out what version I'm using? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1354 in reviewboard: Google chrome text editing fields expand
Updates: Status: Duplicate Mergedinto: 1306 Comment #5 on issue 1354 by chipx86: Google chrome text editing fields expand http://code.google.com/p/reviewboard/issues/detail?id=1354 Okay. So, this was fixed in 1.0.4. You'll need to get the administrator to upgrade. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1306 in reviewboard: Chrome: description and testing done boxes expand with every letter typed
Comment #3 on issue 1306 by chipx86: Chrome: description and testing done boxes expand with every letter typed http://code.google.com/p/reviewboard/issues/detail?id=1306 Issue 1354 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1354 in reviewboard: Google chrome text editing fields expand
Comment #4 on issue 1354 by christopher.james.lahey: Google chrome text editing fields expand http://code.google.com/p/reviewboard/issues/detail?id=1354 Indeed, it says Beta. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1173 in reviewboard: Binary files aren't listed in the diff?
Updates: Status: Fixed Owner: chipx86 Comment #5 on issue 1173 by chipx86: Binary files aren't listed in the diff? http://code.google.com/p/reviewboard/issues/detail?id=1173 Fixed in master (reb80a58) and release-1.0.x (reb80a58) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Updates: Status: Confirmed Owner: chipx86 Comment #8 on issue 1348 by chipx86: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1353 in reviewboard: Change selection frame sticks to screen position when expanding unchanged lines
Updates: Status: Fixed Owner: chipx86 Labels: Component-DiffViewer Milestone-Release1.0.x Comment #1 on issue 1353 by chipx86: Change selection frame sticks to screen position when expanding unchanged lines http://code.google.com/p/reviewboard/issues/detail?id=1353 Fixed on master and release-1.0.x (rddfc9bd) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1355 in reviewboard: Text Box Label and Size Issues for New Review Request and Update Diff windows
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1355 by hovigpda: Text Box Label and Size Issues for New Review Request and Update Diff windows http://code.google.com/p/reviewboard/issues/detail?id=1355 *NOTE: Do not post confidential information in this bug report.* What version are you running? ReviewBoard-1.1alpha1.dev_r2026 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? N/A What is the expected output? What do you see instead? There are several cosmetic issues. 1. When creating a new review request: a) Base Diff Path textbox is only 20 chars wide, whereas the rest of the line is empty. b) Diff textbox is only 20 chars wide, whereas the rest of the line is empty. 2. When updating a diff on an existing review Same issues as above. 3. In one screen the label says Base directory while in another it says Base Diff Path. The naming should be the same and all text box labels should follow the capitalization style. What operating system are you using? What browser? Firefox 3.5.3 on Windows XP Please provide any additional information below. Screen resolution: 1280 x 1024 Attachments: UploadDiff.jpg 28.1 KB NewReviewRequest.JPG 13.6 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 733 in reviewboard: Review Board as a VMWare Virtual Appliance
Comment #4 on issue 733 by gic...@gmail.com: Review Board as a VMWare Virtual Appliance http://code.google.com/p/reviewboard/issues/detail?id=733 Are you concerned about hosting the built VM or about a place to build the VM? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Comment on IdeasFor2_0 in reviewboard
Comment by katsnelson: At some point the number of reviews becomes quite large. It is difficult to sort them out or find the one of interest. Will it be possible to ad folders to the dashboard? In this case users can sort the reviews int different topics or subprojects. For more information: http://code.google.com/p/reviewboard/wiki/IdeasFor2_0 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 294 in reviewboard: Set Submitted Should Be Automatic
Comment #13 on issue 294 by christopher.james.lahey: Set Submitted Should Be Automatic http://code.google.com/p/reviewboard/issues/detail?id=294 Just 2 cents, but I don't think we should automatically mark a review as submitted. Occasionally, my process will require that I've submitted a review to perforce, but it's still important that the review be on rb. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1354 in reviewboard: Google chrome text editing fields expand
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1354 by christopher.james.lahey: Google chrome text editing fields expand http://code.google.com/p/reviewboard/issues/detail?id=1354 *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? Any page with a multi line edit box. What steps will reproduce the problem? 1. View a review request under google chrome on linux. 2. Click review 3. Edit your review What is the expected output? What do you see instead? Expected: Box expands to fit typed data. Experienced: Box expands one line with every character typed. What operating system are you using? What browser? Ubuntu 9.04 Chrome 4.0.221.8 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1354 in reviewboard: Google chrome text editing fields expand
Updates: Status: NeedInfo Comment #1 on issue 1354 by chipx86: Google chrome text editing fields expand http://code.google.com/p/reviewboard/issues/detail?id=1354 What version of Review Board are you using? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1277 in reviewboard: Comment Types
Updates: Status: NeedInfo Labels: Component-DiffViewer Component-Reviews Comment #2 on issue 1277 by chipx86: Comment Types http://code.google.com/p/reviewboard/issues/detail?id=1277 We're having some discussions and debates about how far to go with this feature. We have absolutely no problem with adding a Defect checkbox, but are wondering if we really do want to add severity and comment type. I think really, we need further convincing. I agree that the data is interesting and I can see the argument for knowing how many performance issues are seen, coding style issues, etc. This does of course depend on people actually being good about setting these. I'm wondering how you see them being used, though. We've generally tried to keep Review Board pretty process-free, keeping it simple and light-weight, but this would certainly add a lot more process to reviewing code. Historically, we've encouraged people to use their words for such things instead of doing a drop-down style code review. It's easy to type This will hinder performance due to XYZ and generally makes communication about such things easier. We could require a comment regardless. What I wonder then is whether people will be good about making a comment *and* selecting from drop-downs for the severity and type. This data is meaningless if it's not consistent. If we provide all this, the data will need to be used in some way. I'd like to know how you see it being used. If we implement this, we'd need to know how users would need to use the data, or it'd end up being useful for only one group of people or another. I'm also trying to decide if we should use a drop-down UI or not. Some people wnat severity *and* comment type, but should both be available? Should comment type imply a severity level? Does it even make sense to have a severity level? Should the types be administrator-provided, or should users be able to create their own as they choose? If we add this, I'd like it to be *really* useful for more than just metrics. For example, filtering comments in such a way to tackle the big problems before going after coding style issues. I'd like to see some more uses for it though. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1285 in reviewboard: Expanding hidden lines between revisions
Updates: Status: Fixed Owner: chipx86 Comment #2 on issue 1285 by chipx86: Expanding hidden lines between revisions http://code.google.com/p/reviewboard/issues/detail?id=1285 Yeah, this should have been fixed a while ago in 1.0.2. Please upgrade to 1.0.4 and see if it's fixed. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1196 in reviewboard: Statistics are not available for this backend
Comment #6 on issue 1196 by chipx86: Statistics are not available for this backend http://code.google.com/p/reviewboard/issues/detail?id=1196 Are you using python-memcached or cmemcached? What version of memcached are you running? What version of Python? What happens if you telnet to localhost:11211 and, at the prompt, type: stats -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 733 in reviewboard: Review Board as a VMWare Virtual Appliance
Updates: Labels: -Milestone-Release1.0 Milestone-Release1.1 Comment #3 on issue 733 by chipx86: Review Board as a VMWare Virtual Appliance http://code.google.com/p/reviewboard/issues/detail?id=733 We do want to get to this. Hosting is a concern, as it's going to be costly for us and we have no budget for this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #22 on issue 1072 by chipx86: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 It doesn't look like you put that at the end of the file. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #24 on issue 1072 by chipx86: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 Ohhh.. You're running a pretty old version. Okay, place this in reviewboard/urls.py instead. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #25 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 Many thanks! I following your suggesting, add the line to the end of the urls.py and restart apache server, and try to create a review request, but with error: Something broke! (Error 500) The log message of apache is: 2009-10-10 15:14:46,717 - WARNING - Could not open logfile /logs/reviewboard.log. Logging to stderr 2009-10-10 15:14:46,717 - INFO - Logging to /logs/reviewboard.log with a minimum level of DEBUG 2009-10-10 15:14:46,717 - INFO - Log file for Review Board v1.0rc3 2009-10-10 15:14:46,779 - INFO - Home directory = ~ 2009-10-10 15:14:58,030 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 10045 2009-10-10 15:14:58,030 - DEBUG - DiffParser.parse: Finished parsing diff. maybe the version of review board is too old, i need switch to newer version... -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #26 on issue 1072 by chipx86: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 Sounds like the expansion failed. The Python docs indicate that this is due to %HOME%, %USERPROFILE%, %HOMEPATH% and %HOMEDRIVE% being unset. Python needs at least two of these to expand the path. The solution may be to figure out where the home directory should be and then add some SetEnv directives to set HOME and USERPROFILE. Subversion, it seems, expects to live in %APPDATA%\.subversion (basically, C:\Document and Settings\username\Application Data\.subversion). Dunno about whether that directory exists for Apache at all, or whatever user Apache is running as. That's something you may need to figure out there. I don't really have a Windows install I can test this on. You may also want to look into hosting Review Board on Linux in a VM or something. It's far more supported by us. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 445 in reviewboard: Add command-line apply-diff script
Updates: Status: Confirmed Labels: -Component-Scripts Component-RBTools Comment #9 on issue 445 by chipx86: Add command-line apply-diff script http://code.google.com/p/reviewboard/issues/detail?id=445 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1351 in reviewboard: _checkForUpdates runs with 0 interval.
Updates: Status: NeedInfo Comment #1 on issue 1351 by chipx86: _checkForUpdates runs with 0 interval. http://code.google.com/p/reviewboard/issues/detail?id=1351 When is your install from? You don't say which version. It never said self.CHECK_UPDATES_MSECS, but this.CHECK_UPDATES_MSECS and actually worked fine. We did just change the logic, but it's still fine. Did you modify your copy at all? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1062 in reviewboard: Errors with SVN repositories should be displayed in post-review
Updates: Summary: Errors with SVN repositories should be displayed in post-review Comment #3 on issue 1062 by chipx86: Errors with SVN repositories should be displayed in post-review http://code.google.com/p/reviewboard/issues/detail?id=1062 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1094 in reviewboard: Copy/paste source code
Updates: Status: ThirdParty Comment #2 on issue 1094 by chipx86: Copy/paste source code http://code.google.com/p/reviewboard/issues/detail?id=1094 Yeah, we won't be able to do this. It's a browser thing. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1116 in reviewboard: Error after 'bugs fixed' field edit
Updates: Status: Duplicate Mergedinto: 1195 Comment #4 on issue 1116 by chipx86: Error after 'bugs fixed' field edit http://code.google.com/p/reviewboard/issues/detail?id=1116 This has been fixed and bug 1195 was referenced, so marking this as a dup. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1122 in reviewboard: Review Board seems to allow comments on diffs when not logged in
Updates: Summary: Review Board seems to allow comments on diffs when not logged in Status: Confirmed Labels: Component-DiffViewer Milestone-Release1.1 Comment #2 on issue 1122 by chipx86: Review Board seems to allow comments on diffs when not logged in http://code.google.com/p/reviewboard/issues/detail?id=1122 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1139 in reviewboard: Email submissions of requests
Comment #2 on issue 1139 by chipx86: Email submissions of requests http://code.google.com/p/reviewboard/issues/detail?id=1139 Issue 1210 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1210 in reviewboard: Accept comments by email
Updates: Status: Duplicate Mergedinto: 1139 Comment #2 on issue 1210 by chipx86: Accept comments by email http://code.google.com/p/reviewboard/issues/detail?id=1210 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1105 in reviewboard: Settings updates may require a webserver restart
Updates: Labels: -Priority-Low Priority-High Comment #9 on issue 1105 by chipx86: Settings updates may require a webserver restart http://code.google.com/p/reviewboard/issues/detail?id=1105 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1249 in reviewboard: Impossible to not use anonymous bind with Ldap functionality
Updates: Status: Duplicate Mergedinto: 1105 Comment #2 on issue 1249 by chipx86: Impossible to not use anonymous bind with Ldap functionality http://code.google.com/p/reviewboard/issues/detail?id=1249 This sounds like the settings issues. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1224 in reviewboard: yellow diff highlighting is off by one line
Updates: Status: Confirmed Labels: Interdiffs Component-DiffViewer Comment #2 on issue 1224 by chipx86: yellow diff highlighting is off by one line http://code.google.com/p/reviewboard/issues/detail?id=1224 Been looking into this. It's not just those lines. Most of the lines are off. Any replace line, in fact. This seems to be due to our markup and text lines being off. We compare the plain text lines and then generate the interline diff highlighting, and then apply the highlighting to the HTML lines. However, we're applying them to a line too early, implying that the HTML line is off by one compared to the plain text lines. This all appears to start with a block that looks somewhat like: /* * NOTE: Blah blah blah... * Blah blah blah... * total of 6 lines of this... */ The highlighting here is wrong. It starts at the line before the comment, actually. While both diffs show a blank line there, the diff viewer shows a replace line. This implies that the lines are not equal. I suspect there's a line termination issue here. Why it starts on that line, I do not know. Perhaps there's something screwy in this particular change with the newlines. We would need a good, self-contained test case for this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1294 in reviewboard: the floating You have a pending review bar squanders precious screen space
Updates: Status: WontFix Comment #3 on issue 1294 by chipx86: the floating You have a pending review bar squanders precious screen space http://code.google.com/p/reviewboard/issues/detail?id=1294 We're pretty happy with the UI as it is today. Sorry about the small screen, but supporting configurable options for this just means more to maintain, and making it less visible is exactly what we don't want. If more people were complaining about this UI we'd look into alternatives, but so far this is the only case I've heard where it's taking up too much space. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1263 in reviewboard: Add file navigation popup list to view diffs page
Updates: Status: Confirmed Labels: Component-DiffViewer Comment #1 on issue 1263 by chipx86: Add file navigation popup list to view diffs page http://code.google.com/p/reviewboard/issues/detail?id=1263 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1353 in reviewboard: Change selection frame sticks to screen position when expanding unchanged lines
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1353 by OliverCGoetz: Change selection frame sticks to screen position when expanding unchanged lines http://code.google.com/p/reviewboard/issues/detail?id=1353 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.4 What's the URL of the page containing the problem? internal system: view diffs What steps will reproduce the problem? 1. Find a review request with collapsed lines above the first diff. 2. Go to View Diff 3. Select the first diff by clicking on it; a rectangular frame will appear around it. 4. Expand collapsed text above the change. What is the expected output? What do you see instead? I would expect that the frame indicating the selected diff moves down the page with the diff. Instead the frame stays on the screen position where the diff was before expanding the hidden lines. What operating system are you using? What browser? OS: Windows XP Browser: Firefox 3.5.3 Please provide any additional information below. I just checked the issue with Internet Explorer 7.0.5730.13, and there it does not occur: instead the frame moved with the selected diff as expected. Attachments: stickyframe1.png 46.2 KB stickyframe2.png 52.1 KB stickyframe3.png 53.8 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1352 in reviewboard: Uncaught TypeError when entering multiple lengthy bug #s for a review request
Updates: Status: Fixed Owner: chipx86 Labels: Milestone-Release1.0.x Component-Reviews Comment #2 on issue 1352 by chipx86: Uncaught TypeError when entering multiple lengthy bug #s for a review request http://code.google.com/p/reviewboard/issues/detail?id=1352 Fixed on master (r10b5857) and release-1.0.x (r62b792c). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1351 in reviewboard: _checkForUpdates runs with 0 interval.
Comment #2 on issue 1351 by sitnikov.vladimir: _checkForUpdates runs with 0 interval. http://code.google.com/p/reviewboard/issues/detail?id=1351 Actually, I use the master branch from the official git repository (http://github.com/reviewboard/reviewboard.git) Here is the link to the source: http://github.com/reviewboard/reviewboard/blob/10b5857f676c598fb6353bb50b54a9f0410f032f/reviewboard/htdocs/media/rb/js/datastore.js#L352 I am not sure whether this is much better or not, but I used RB.ReviewRequest. to be consistent with commit eb6d4c4673983e6901cd9cf7d1893e390c3ff222 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #21 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 I tried again and got the error: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #5 on issue 1348 by premek.paska: Expanding hidden lines broken by
the 1.0.3 update
http://code.google.com/p/reviewboard/issues/detail?id=1348
There are no JS errors reported by Firebug.
The strange thing is that all Expand links within one file use the same
HTTP request:
javascript:expandChunk('file1', '1147', '1', null, '12', this); return
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/
javascript:expandChunk('file1', '1147', '1', null, '19', this); return
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/
The next file:
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/
etc.
And consequently, all responses for different links within the file are the
same:
One of them starts with this html code:
tbody id=chunk0.1
tr line=26
th26/th
tdprespan class=p{/span/pre/td
th26/th
tdprespan class=p{/span/pre/td
/tr
tr line=27
th27/th
...
I compared the responses and realized that they always return the first
five lines of
the file that are already displayed (first lines of the file's diff). So
never the
correct lines.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #17 on issue 1072 by yunshan.di: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 hi chipx86, How to work around the issue HTTPS Subversion repositories don't work with Review Board? I'm a little confused with your explanation, so could you please explain it in detail? thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1352 in reviewboard: Uncaught TypeError when entering multiple lengthy bug #s for a review request
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1352 by th...@ginkel.com: Uncaught TypeError when entering multiple lengthy bug #s for a review request http://code.google.com/p/reviewboard/issues/detail?id=1352 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.4 What's the URL of the page containing the problem? https://reviewboard.domain/api/json/reviewrequests/#/publish/ What steps will reproduce the problem? 1. Post a review for a repository that has an issue tracker assigned 2. Enter two lengthy numerical bug IDs, such as 012006153200030304432009, 012006153200030304432010 3. Publish What is the expected output? What do you see instead? Sorting the bug #s fails with a TypeError, which is not anticipated by the code: Request Method: POST Request URL: https://reviewboard.domain/api/json/reviewrequests/#/publish/ Exception Type: TypeError Exception Value: comparison function must return int Exception Location: [...]\reviewboard\reviews\models.py in get_bug_list, line 550 549 : try: 550 : bugs.sort(cmp=lambda x,y: int(x) - int(y)) 551 : except ValueError: 552 : bugs.sort() -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #6 on issue 1348 by chipx86: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Sounds like this would be the cause, though it's still not happening here. I'll try to repro it some more. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
