, the emails ARE sent out. This is curious because
I've tried setting post-review as a Superuser, and still no emails
were sent.
Any ideas?
-Ryan
On Sep 1, 6:31 pm, RShelley 12gaugeme...@gmail.com wrote:
This has me pretty baffled. I wrote a Java API awhile ago to publish
a review request
Gah! Ok... I found the problem, and it's pretty silly on my part. The
account I was posting/publishing the review requests from did not have
an email address. Problem solved.
-Ryan
On Sep 2, 9:20 am, RShelley 12gaugeme...@gmail.com wrote:
I have narrowed this down further.
I created
.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Sep 2, 2010 at 9:29 AM, RShelley 12gaugeme...@gmail.com wrote:
Gah! Ok... I found the problem, and it's pretty silly on my part. The
account I was posting/publishing the review requests from did
I just opened a bug for this:
http://code.google.com/p/reviewboard/issues/detail?id=1800
But chances are it's my own problem, but I'm not sure.
I was able to create a Review Request on reviews.reviewboard.org with
a diff generated with git diff --full-index, but when I try to
update the diff
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Aug 26, 2010 at 4:02 PM, RShelley 12gaugeme...@gmail.com wrote:
Well, I got past the P4PASSWD issue and then began getting the error
The current directory
This has me pretty baffled. I wrote a Java API awhile ago to publish
a review request, among other things. The API does in fact publish
the request (it's visible to users, and is no longer in draft mode),
however, emails are not being sent to the groups and reviewers on the
request. If I post a
won't have to
maintain a fork for too long.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 25, 2010 at 4:46 PM, RShelley 12gaugeme...@gmail.com wrote:
Dana, that sums it up pretty well. My
I've been struggling recently getting post-review to pick up the
P4PASSWD properly. We have post-review as part of a script and we
first run p4 login -p to get a ticket and then put that ticket in
the environment. Subsequent p4 describe -P ticket changelist
commands work fine, but post-review
the file
I restarted the server (don't know if that's needed or not)
On Aug 25, 8:56 am, RShelley 12gaugeme...@gmail.com wrote:
I've been struggling recently getting post-review to pick up the
P4PASSWD properly. We have post-review as part of a script and we
first run p4 login -p to get
. The full path for mine is: /
usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools. Obviously this is a Unix install. I'm not
quite sure where it would be for windows. Does that help?
On Aug 25, 11:50 am, RShelley 12gaugeme...@gmail.com wrote:
Where would
ReviewBoard-1.5rc1-py2.5.egg was a top level
directory. Under that was the scmtools directory. So I'm not quite
sure how to resolve that they egg isn't a directory.
On Aug 25, 1:11 pm, RShelley 12gaugeme...@gmail.com wrote:
I'm on Linux and I found the site-packages, but I don't have any
I'd like to let everyone know that I've released an open source plugin
for Hudson Continuous Integration (http://www.hudson-ci.org) to
integrate with Reviewboard.
http://wiki.hudson-ci.org/display/HUDSON/Reviewboard+Plugin
The plugin allows an admin to configure a build to monitor SCM
I'm not sure this helps, but when you publish a review request and
then update the review request with a new changeset it will diff again
against the previous diff. Each update/publish produces a delta that
you can follow. However, publishing does email the groups/users,
which you may not want.
Failed to execute command: ['p4', 'describe', '-s', '702076']
Access for user 'family' has not been enabled by 'p4 protect'.
I created the Hudson-Reviewboard plugin but when I deployed it to our
remote Hudson server, I realized that Hudson is running as the user
family, so when Hudson calls
Yeah, I was aware of the post-review help options, but not of the
P4USER environment variable. That resolved one issue, on to the
next :) Thanks Dana!
On Apr 26, 9:13 am, Dana Lacoste dlaco...@aperio.com wrote:
But, realistically, you should probably be using the environment
variables P4USER,
I have a review that has some files that were modified. Then I
modify (delete) a file, submit my change (post-commit), and run post-
review -r XX path to deleted file and other paths to updated files
to update the review, Reviewboard returns a 400 error and other
changes that were included in the
So with this process, you want to continually
update an existing review request, and you want it to incorporate the new
updates alongside the existing ones? So if it's already created with a diff
modifying 5 files, the next update that adds 2 files will result in a diff
containing a total of
I've been able to complete a functional Hudson-Reviewboard plugin
(with many thanks). With the core functionality of it done, I'm now
looking at how to improve upon it, already. I know there isn't
currently a command-line option for this (or may not be one if it
doesn't seem to be ideal), but I
I'd like to just take a moment and say thanks to the developers of
Reviewboard. Within the scope of my Proof of Concept I've had an
opportunity to use the tool in-depth and I'm thoroughly impressed with
it. The integration between Perforce and Eclipse has made it
indispensable for me. Using it
Ok, let me clarify with a concrete scenario.
We use JIRA for our bug tracking. JIRA generates bug IDs such as
BUG-123. We also have Hudson for continuous integration, and it's
tied to Perforce to poll for changes, build the changes, and log the
changelists in the build (for release notes). Our
657749 -d --p4-client=rshelley-tp-1.02
svn info
p4 info
repository info: Path: perforce:1666, Base path: None, Supports changesets:
True
Generating diff for changenum 657749
p4 describe -s 657749
Processing edit of //p4-dol/.../PartitionedCacheManager.java
Writing //p4-dol
We're going to make this error more clear in an upcoming version.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Mar 17, 2010 at 2:56 PM, RShelley 12gaugeme...@gmail.com wrote:
Hey folks, I'm
22 matches
Mail list logo
