404 when adding line comment

2009-09-23 Thread Pv
lib\site-packages\django-1.1-py2.5.egg\django \shortcuts\__init__.py", line 87, in get_object_or_404 raise Http404('No %s matches the given query.' % queryset.model._meta.object_name) Http404: No FileDiff matches the given query. The diff was uploaded via the post-review tool. P

Re: 404 when adding line comment

2009-09-23 Thread Pv
and used the admin to view the "review request draft to change" I got a 500 error. Once published I can admin the non-draft review just fine. Pv On Sep 23, 5:05 pm, Christian Hammond wrote: > Hi, > > Yep, this is the right mailing list. > > So first of all, did y

easy_install rbtools on py26?

2009-10-29 Thread Pv
n and that simplejson is for legacy support on 2.5 & 2.4. So why does easy_install rbtools want to install simplejson? Thanks! Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let u

RBTools 0.2beta2 halts/fails outputting "Cannot display: file marked as a binary type"

2009-10-29 Thread Pv
ss.csproj.FileListAbsolute.txt\n', ' ===\n', "svn: Can't start process 'diff': The system cannot find the file specified. \n"] I understand the origin of the error, but the code of post-review looks li

Re: RBTools 0.2beta2 halts/fails outputting "Cannot display: file marked as a binary type"

2009-10-29 Thread Pv
Duh! This is a "diff" problem that I ran in to before...fixing now. Pv On Oct 29, 10:43 am, Pv wrote: > I am doing a post-commit review on a teammate's checked in C# code on > an SVN server. > I run: > post-review -d --revision-range=24506 > > And I get

Re: RBTools 0.2beta2 halts/fails outputting "Cannot display: file marked as a binary type"

2009-10-29 Thread Pv
Yes, it was a simple diff not being in my path problem. Pv On Oct 29, 10:49 am, Pv wrote: > Duh!  This is a "diff" problem that I ran in to before...fixing now. > > Pv > > On Oct 29, 10:43 am, Pv wrote: > > > > > I am doing a post-commit review on a tea

Re: RBTools 0.2beta2 halts/fails outputting "Cannot display: file marked as a binary type"

2009-10-29 Thread Pv
Opened 1378 Pv On Oct 29, 11:34 am, Christian Hammond wrote: > Glad you figured it out. We need to check for that and fail gracefully. > Would you mind filing a bug so we can track it for the release? > > Christian > > -- > Christian Hammond - chip...@chipx86.com

How to post-commit review a first time checkin?

2009-10-29 Thread Pv
I am using the following command to do a post-commit review on a first time checkin: post-review -d --revision-range=24506 Obviously, I am not specifying a from:to range, but since this is a first time checking any earlier "from" svn rev # wouldn't exist in the newly created path. The [debug] ou

Re: How to post-commit review a first time checkin?

2009-11-03 Thread Pv
--revision-range=1234) and the diff is empty, then try something like an "svn cat", but with a diff compatible output. Pv On Nov 2, 12:41 pm, Christian Hammond wrote: > It sounds like the generated diff is empty. If you add --output-diff to > those parameters, you should be ab

Re: easy_install rbtools on py26?

2009-11-03 Thread Pv
hip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Thu, Oct 29, 2009 at 10:37 AM, Pv wrote: > > > I had ActivePython 2.6 installed and installed ezsetup for py26 (on a > > x64 Windows 2K8 Server). > >

API: How to get list of files affected in reviewrequest?

2009-11-03 Thread Pv
w", but I think that just operates to create a new diff, not get a list of the existing diffs. Is there an API method to get the total file set of a reviewrequest? Thanks! Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www

Re: Download diff

2009-11-04 Thread Pv
GET r/diff/raw sounds like a reasonable way to DL the diff, so I wouldn't expect the API to duplicate this simple request. Pv On Nov 4, 4:19 am, H M wrote: > Is there a way to download a diff through the formal JSON api? > > I realize the diff could be downloaded through

How to get post-review to work w/ http://reviews.reviewboard.org (to request reviews for RB changes)

2009-11-07 Thread Pv
the one installed following this step: http://www.reviewboard.org/docs/codebase/dev/getting-started/#rbtools Any idea what my my malfunction is? Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Le

Re: post-review error: WindowsError: [Error 2] The system cannot find the file specified

2009-11-07 Thread Pv
I ran in to the same thing and opened a bug to make a missing diff binary a friendlier message. Pv On Nov 6, 10:24 pm, Akhilesh wrote: > After a lot of troubleshooting I found the problem: diff.exe was not > present in the PATH. > > On Nov 6, 2:57 pm, Akhilesh wrote: > >

Re: API: How to get list of files affected in reviewrequest?

2009-11-07 Thread Pv
s one, since this does not obligate me to also implement: reviewrequests/(?P[0-9]+)/diff/(? P[0-9]+)/filenames/ Pv On Nov 5, 2:49 am, Christian Hammond wrote: > I forgot that we actually had a patch up for review for this. It's now > committed to master and will be in the

Re: API: How to get list of files affected in reviewrequest?

2009-11-07 Thread Pv
I have no idea why that word wrapped so bad! :( Pv On Nov 7, 12:05 pm, Pv wrote: > Yes, I noticed the patch Friday, sweet! > One nitpick is that because I am writing a pre-commit hook to inerface > w/ RB, all I currently want is a simple list of the latest filenames > in the

Re: How to get post-review to work w/ http://reviews.reviewboard.org (to request reviews for RB changes)

2009-11-08 Thread Pv
ewboard" directory is a git enlistment. svn was in my path, but git was not. I added git to my path and it finally asked me for my reviews.reviewboard.org username/password. Pv On Nov 8, 11:59 am, Dan Savilonis wrote: > You can run post-review with the -d option to see what it i

Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
I've fought this one all day while setting up a new RB server. Server: W2K3, Apache2.2, Python25, plus all of the other required trimmings. I have installed 2 other RB servers [on XP] and hadn't seen this problem before. I install the server and can log in and create users and change other variou

Re: Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
Running dev version does same thing; it immediately quits. The output is: Running dependency checks (set DEBUG=False to turn this off)... Warning: p4python (>=07.3) not found. Perforce integration will not work. Warning: hg not found. Mercurial integration will not work. Warning: PyLucene (with

Re: Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
Running it in winpdb shows: Stack trace for thread 1388: Frame File Name Line Function -- > 0 ...jango\utils\autoreload.py96 python_reloader 1 ...jango\utils\autoreload.py 118

Re: Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
Well, I cleaned my W2K3 Server's Python25 directory and reinstalled all required modules and things started to work fine. I inherited the machine, and I guess it was in a dirty state. :( All is good now! Pv --~--~-~--~~~---~--~~ Want to help the Review

Re: Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
It was for an "svn://server/root" CollabNet SVN server. Cleaning up my Python modules fixed the problem (albeit it took awhile...albeit it was obviously necessary). Pv On Nov 10, 7:20 pm, Christian Hammond wrote: > What sort of SVN repo is this? Plain, https? > > Chris

prob w/ post-review on non-fqdn intranet addresses; lookin for workaround

2009-11-13 Thread Pv
2) ReviewBoard could reuse or add a setting that would be passed as a "domain" attribute in a "Set-Cookie2" header Without patching post-review or ReviewBoard, can anyone think of a way to get Apache to send the "domain" attribute in the cookie? Pv -

Re: Eclipse plugin: basic usage?

2009-11-16 Thread Pv
Where is this Eclipse and/or IDEA plugin? I searched the reviewboard and rbtools git repo and didn't see anything. I do see the review though: http://reviews.reviewboard.org/r/967/ But browsing git I can't find that path. Is there a VS plugin took? [or in the works?] Pv On Nov 1

RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-23 Thread Pv
I have installed a fresh copy of Win7 x64 and VS2K8. I then installed Py2.6 + RBTools 0.2rc1. I create a new C# project, svn add, and then post-review the project. I get a "UnicodeDecodeError" on the Solution's/Project's xml/config files. There is a signature of "\xef\xbb\xbf" at the beginning of t

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-23 Thread Pv
NOTE: If I manually browse to my reviewboard server and upload the diff it accepts it no problem. I am not doing anything to intentionally encode these files beyond the default VS2K8 encoding. Pv On Feb 23, 4:20 pm, Pv wrote: > I have installed a fresh copy of Win7 x64 and VS2K8. >

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-24 Thread Pv
1.1 alpha 2 (dev) I am pretty sure this aborts in RBTools itself before it ever gets to the server. Again, a manual upload of the diff file to the server works fine. Pv On Feb 23, 5:27 pm, Christian Hammond wrote: > Hi Pv, > > Which version of Review Board is this? >

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
Studio 2008. After running in to the problem w/ default encoding I have tried saving the culprit files w/ various other encodings, but nothing seems to make post-review happy. Pv On Feb 24, 4:55 pm, Pv wrote: > 1.1 alpha 2 (dev) > > I am pretty sure this aborts in RBTools itself before

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
Yes, I just commented that out and the upload was successful. Pv On Feb 25, 12:25 pm, "Thilo-Alexander Ginkel" wrote: > On Thursday 25 February 2010 01:55:42 Pv wrote: > > > I am pretty sure this aborts in RBTools itself before it ever gets to > > the server. >

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
It should have been: return content_type, content.encode('utf-8', 'ignore') Pv On Feb 25, 12:43 pm, Pv wrote: > Yes, I just commented that out and the upload was successful. > > Pv > > On Feb 25, 12:25 pm, "Thilo-Alexander Ginkel" > wro

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
code bytes in position 5-6: unexpected end of data >>> u = unicode(s, 'utf8', 'ignore') >>> u u'La Pe' >>> u = unicode(s, 'utf8', 'replace') >>> u u'La Pe\ufffd' >>> I don't kn

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
> u = unicode(s, 'utf8') Traceback (most recent call last): File "", line 1, in File "C:\Python25\lib\encodings\utf_8.py", line 16, in decode return codecs.utf_8_decode(input, errors, True) UnicodeDecodeError: 'utf8' codec can't decode

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-03-03 Thread Pv
nice if reviewboard diffs wouldn't put a red rectangle around the initial BOM chars. The existence of BOM chars is normal and should be gracefully/silently ignored. A red box indicates to me an error/warning of some sort. If the BOM differs between the two files then that should be gracefu