---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51892/#review149054
---
Ship it!
Ship It!
- Nate Cole
On Sept. 15, 2016, 8:31 a.m
> On Sept. 13, 2016, 8:37 a.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, lines
> > 138-140
> > <https://reviews.apache.org/r/51705/diff/3/?file=1497455#file1497455line138>
> >
> > Again, I'm not sure wh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51238/#review148709
---
Ship it!
Ship It!
- Nate Cole
On Sept. 13, 2016, 5:31 a.m
/yaml_utils.py (lines 22 - 28)
<https://reviews.apache.org/r/51818/#comment216210>
NOW I know who to go to for regex shenanigans ;)
- Nate Cole
On Sept. 12, 2016, 3:13 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automati
/ClusterConfiguration.py (lines 137 -
139)
<https://reviews.apache.org/r/51705/#comment216208>
Again, I'm not sure what you're fixing here. Every execution command is
going to have the password properties in them anyway, and there will be
hundreds in /var/lib/ambari-agent/data.
- Nate Cole
On Sept. 12
If so, then the
property should use the word "spnego" somewhere like you have for other
properties.
- Nate Cole
On Sept. 13, 2016, 5 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51811/#review148700
---
Ship it!
Ship It!
- Nate Cole
On Sept. 12, 2016, 11:56 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51811/#review148503
---
Ship it!
Ship It!
- Nate Cole
On Sept. 12, 2016, 11:56 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51762/#review148499
---
Ship it!
Ship It!
- Nate Cole
On Sept. 9, 2016, 1:07 p.m
extending the
Abstract class?
- Nate Cole
On Sept. 9, 2016, 12:59 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
etc. These show as stdout/stderr for the task, so as much detail that we
can get there, the easier it is to pinpoint what happened.
- Nate Cole
On Sept. 9, 2016, 9:49 a.m., Robert Levas wrote:
>
> ---
> This is an autom
> On Sept. 6, 2016, 3:41 p.m., Nate Cole wrote:
> > Ship It!
>
> wang yaoxin wrote:
> Thank you , but I don't have the authority to ship, so i will trouble you
> to commit the patch!
A review needs 2 approvals before b
> On Sept. 8, 2016, 11:13 a.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml,
> > line 473
> > <https://reviews.apache.org/r/51713/diff/1/?file=1493889#file1493889line473>
> >
> > If you use
run, the user
decides to Downgrade? Will the old data be intact or does it get overwritten?
- Nate Cole
On Sept. 8, 2016, 11:09 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://reviews.apache.org/r/51705/#comment215637>
Will this be a performance issue? On large clusters this can be a lot of
iterating for alert and execution commands.
- Nate Cole
On Sept. 7, 2016, 5:14 p.m., Anita Jebaraj
mbari/server/state/RepositoryInfo.java
(lines 179 - 181)
<https://reviews.apache.org/r/51238/#comment215441>
Use Objects.hash(...) for easier going
- Nate Cole
On Sept. 5, 2016, 9:26 a.m., Balázs Bence Sári wrote:
>
> ---
> T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51382/#review148040
---
Ship it!
Ship It!
- Nate Cole
On Aug. 24, 2016, 2:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51691/#review148036
---
Ship it!
Ship It!
- Nate Cole
On Sept. 7, 2016, 1:18 p.m
/services/MetricsRetrievalService.java
(lines 88 - 98)
<https://reviews.apache.org/r/51691/#comment215372>
Just a nit, but this might be called MetricSourceType or something.
"Metric type" could be "point in time" or "series" etc.
- Nate Cole
On Sept. 7, 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51550/#review147905
---
Ping. Can this be pushed and close this review?
- Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49804/#review147904
---
Ship it!
Ship It!
- Nate Cole
On Sept. 6, 2016, 5:57 a.m
s an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51659/
> ---
>
> (Updated Sept. 6, 2016, 1:23 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bu
?
- Nate Cole
On Aug. 25, 2016, 7:26 a.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51550/#review147423
---
Ship it!
Ship It!
- Nate Cole
On Aug. 31, 2016, 4:08 a.m
> On Aug. 29, 2016, 1:27 p.m., Nate Cole wrote:
> > I was under the impression that applying an m-pack would DIRECTLY update
> > repoinfo.xml on the filesystem. Has the design changed since then?
> >
> > What is the purpose of carrying service version around with th
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51498/#review147169
---
Ship it!
Ship It!
- Nate Cole
On Aug. 29, 2016, 12:54 p.m
for them when
formulating the command. Seems easier than munging everything else.
- Nate Cole
On Aug. 26, 2016, 5:25 a.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
1238/#comment214263>
Ordering
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
(lines 213 - 215)
<https://reviews.apache.org/r/51238/#comment214264>
formatting.
- Nate Cole
On Aug. 26, 2016, 5:25 a.m., Balázs Bence Sári wrote:
>
> --
] Finished at: Fri Aug 26 10:13:53 EDT 2016
[INFO] Final Memory: 36M/719M
[INFO]
Thanks,
Nate Cole
,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51430/#review146810
---
Ship it!
Ship It!
- Nate Cole
On Aug. 25, 2016, 12:44 p.m
]
[INFO] Total time: 1:25:27.562s
[INFO] Finished at: Wed Aug 24 15:59:06 EDT 2016
[INFO] Final Memory: 34M/759M
[INFO]
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51383/#review146691
---
Ship it!
Ship It!
- Nate Cole
On Aug. 24, 2016, 2:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51370/#review146684
---
Ship it!
Ship It!
- Nate Cole
On Aug. 24, 2016, 11:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51337/#review146544
---
Ship it!
Ship It!
- Nate Cole
On Aug. 23, 2016, 12:17 p.m
and a value.
- Nate Cole
On Aug. 22, 2016, 2:25 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Aug. 19, 2016, 11:16 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java,
> > line 81
> > <https://reviews.apache.org/r/51241/diff/1/?file=1479502#file1479502line81&g
;
> > }
> > break;
I think it's appropriate to throw an Exception. Will add.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51245/#re
/HTTPUtils.java
cfb7128
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
55cb23b
Diff: https://reviews.apache.org/r/51245/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51179/#review145995
---
Ship it!
Ship It!
- Nate Cole
On Aug. 17, 2016, 11:01 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51004/#review145583
---
Ship it!
Ship It!
- Nate Cole
On Aug. 11, 2016, 3:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145513
---
Ship it!
Ship It!
- Nate Cole
On Aug. 11, 2016, 11 a.m
gt;
Mou isn't showing json formatted correctly, hopefully your editor does :)
- Nate Cole
On Aug. 10, 2016, 2:31 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145444
---
Ship it!
Ship It!
- Nate Cole
On Aug. 10, 2016, 12:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145379
---
Ship it!
Ship It!
- Nate Cole
On Aug. 10, 2016, 2:25 p.m
> On Aug. 10, 2016, 8:28 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java,
> > lines 42-51
> > <https://reviews.apache.org/r/50911/diff/2/?file=1469651#file1469651line42>
> >
> > Shouldn't nee
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50930/#review145246
---
Ship it!
Ship It!
- Nate Cole
On Aug. 9, 2016, 3:41 p.m
> On Aug. 9, 2016, 8:33 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java,
> > lines 92-96
> > <https://reviews.apache.org/r/50911/diff/1/?file=1467509#file1467509line92>
> >
> > Doesn't se
> On July 27, 2016, 9:56 a.m., Nate Cole wrote:
> > Ship It!
>
> Masahiro Tanaka wrote:
> Thank you for reviewing. Could you commit it?
Should it be committed to trunk?
- Nate
---
This is an automaticall
on metrics"
Make the text as descriptive as you like, as long as you don't put full
context of log4j.properties.
- Nate Cole
On July 28, 2016, 7:07 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically g
-upgrade.xml
(lines 659 - 665)
<https://reviews.apache.org/r/50565/#comment209925>
I think you might be able to use the "modern" here:
- Nate Cole
On July 28, 2016, 9:18 a.m., Mugdh
-
>
> (Updated July 28, 2016, 9:18 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan
> Hurley, Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-17945
> https://issues.apache.org/jira/b
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50577/#review143988
---
Ship it!
Ship It!
- Nate Cole
On July 28, 2016, 2:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50539/#review143987
---
Ship it!
Ship It!
- Nate Cole
On July 28, 2016, 2:24 p.m
> On July 28, 2016, 12:29 p.m., Nate Cole wrote:
> > We are going to hold on this patch. Between this and
> > https://reviews.apache.org/r/50508/, we're adding more complexity too late
> > in the stage. Instead, please pursue a custom java class that will do this
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50567/#review143930
---
Ship it!
Ship It!
- Nate Cole
On July 28, 2016, 9:18 a.m
bari-upgrade tags for this file? ambari-server tests
will fail without it if that's the case.
- Nate Cole
On July 27, 2016, 7:06 p.m., Alejandro Fernandez wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50526/#review143785
---
Ship it!
Ship It!
- Nate Cole
On July 27, 2016, 3:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50475/#review143727
---
Ship it!
Ship It!
- Nate Cole
On July 26, 2016, 8:30 p.m
ed FOR. I'm still doing
some testing around that.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50461/#review143605
---
results.
Thanks,
Nate Cole
> On July 26, 2016, 11:18 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java,
> > line 251
> > <https://reviews.apache.org/r/50047/diff/3/?file=1452054#file1452054line251>
> >
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review143599
---
Ship it!
Ship It!
- Nate Cole
On July 26, 2016, 2:15 p.m
> On July 26, 2016, 11:18 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java,
> > line 251
> > <https://reviews.apache.org/r/50047/diff/3/?file=1452054#file1452054line251>
> >
>
> On July 26, 2016, 11:18 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java,
> > line 248
> > <https://reviews.apache.org/r/50047/diff/3/?file=1452054#file1452054line248>
> >
> &g
these regex things in case they're bad. Log
the error and return something which will be non-breaking ("" sufficient?)
- Nate Cole
On July 26, 2016, 11:06 a.m., Anita Jebaraj wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50350/#review143537
---
Ship it!
Ship It!
- Nate Cole
On July 25, 2016, 9:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50409/#review143515
---
Ship it!
Ship It!
- Nate Cole
On July 25, 2016, 5:04 p.m
that's the Golden Ticket to Correctville.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50407/#review143472
---
/test_hbase_master.py f5ed727
Diff: https://reviews.apache.org/r/50407/diff/
Testing
---
Manual testing of above STR, and newly added test:
--
Total run:1033
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50390/
> ---
>
> (Updated July 25, 2016, 6:03 a.m.)
>
>
> Review request for Ambari, Alejandro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50381/#review143342
---
Ship it!
Ship It!
- Nate Cole
On July 24, 2016, 3:12 p.m
, and that the keytabs can be regenerated when pausing the Upgrade.
Automated shows failures not related to UP change.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50349/#review143262
---
Ship it!
Do all existing tests pass?
- Nate Cole
On July 22
t; 2.4, 2.5
HDP-2.5 -> 2.5
Automated tests pending as verification nothing is broken.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50302/#review143098
---
Ship it!
Ship It!
- Nate Cole
On July 21, 2016, 12:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50196/#review142832
---
Ship it!
Ship It!
- Nate Cole
On July 19, 2016, 4:56 p.m
iff: https://reviews.apache.org/r/50201/diff/
Testing
---
Manual only. No automated test for UP changes.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50196/#review142792
---
Ship it!
Ship It!
- Nate Cole
On July 19, 2016, 2:36 p.m
/java/org/apache/ambari/logfeeder/LogFeederUtil.java
(lines 401 - 403)
<https://reviews.apache.org/r/50069/#comment208372>
This entire class needs javadoc
- Nate Cole
On July 19, 2016, 7:23 a.m., Oliver Szabo
> On July 15, 2016, 3:08 p.m., Nate Cole wrote:
> > ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.log, lines
> > 1-3
> > <https://reviews.apache.org/r/50069/diff/2/?file=1444904#file1444904line1>
> >
> > Checking in a log file?
>
WAY and update the DB
correctly.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50101/#review142585
---
Ship it!
Ship It!
- Nate Cole
On July 15, 2016, 8:31 p.m
--
Total run:1019
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
ttps://reviews.apache.org/r/50069/#comment208001>
Checking in a log file?
- Nate Cole
On July 15, 2016, 6:53 a.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50079/#review142388
---
Ship it!
Ship It!
- Nate Cole
On July 15, 2016, 11:56 a.m
generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
>
> (Updated July 11, 2016, 5:50 p.m.)
>
>
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
>
>
> Bug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49826/#review142235
---
Ship it!
Ship It!
- Nate Cole
On July 13, 2016, 4:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50007/#review142223
---
Ship it!
Ship It!
- Nate Cole
On July 13, 2016, 6:05 p.m
. Automated:
--
Total run:1018
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49953/#review141924
---
Ship it!
Ship It!
- Nate Cole
On July 12, 2016, 10:55 a.m
> On July 8, 2016, 4:45 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 68-71
> > <https://reviews.apache.org/r/48972/diff/4/?file=1439903#file1439903line68>
> >
> > We use underscore notation in o
pushing it.
ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py (lines 68 - 71)
<https://reviews.apache.org/r/48972/#comment206839>
We use underscore notation in our json, not dotted names. Match for
consistency.
- Nate Cole
On July 8, 2016, 4:20 p.m., Masahiro Tanaka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49665/#review141161
---
Ship it!
Ship It!
- Nate Cole
On July 6, 2016, 8:41 a.m
On July 4, 2016, 3:01 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
>
> (Updated July 4, 2016, 3:01 p.m.)
>
>
> Review request for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49676/#review141057
---
Ship it!
Ship It!
- Nate Cole
On July 6, 2016, 2:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49640/#review140813
---
Ship it!
Ship It!
- Nate Cole
On July 5, 2016, 12:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49618/#review140812
---
Ship it!
Ship It!
- Nate Cole
On July 4, 2016, 9:02 p.m
ilures:0
OK
Thanks,
Nate Cole
eviews.apache.org/r/49318/#review139898
---
On June 28, 2016, 4:03 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To re
601 - 700 of 891 matches
Mail list logo
