Re: Review Request 59756: Delete view privileges from the Groups page
> On June 27, 2017, 12:24 p.m., Sangeeta Ravindran wrote: > > Ship It! Hi Sangeeta, can you please help in pushing the changes? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/#review178979 --- On June 2, 2017, 6:46 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59756/ > --- > > (Updated June 2, 2017, 6:46 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. > > > Bugs: AMBARI-21172 > https://issues.apache.org/jira/browse/AMBARI-21172 > > > Repository: ambari > > > Description > --- > > The view permissions are listed in the groups page, but in order to remove > it, the user has to drill down to the views page and remove the group from > it. To remove the permission for multiple views for one group, we have to > navigate to different Views page to perform the operation > > Including a delete option in the Groups page for views privilege will simply > this > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > 92406e9 > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html > e472ede8 > > > Diff: https://reviews.apache.org/r/59756/diff/1/ > > > Testing > --- > > Ran mvn test > > > File Attachments > ---- > > Image1.PNG > > https://reviews.apache.org/media/uploaded/files/2017/06/02/2963340b-98ed-4b28-9cdc-7d67f21a0775__Image1.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/ --- (Updated June 26, 2017, 8:16 p.m.) Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Robert Levas, and Tim Thorpe. Bugs: AMBARI-21083 https://issues.apache.org/jira/browse/AMBARI-21083 Repository: ambari Description --- Provide the ability to create custom admin user during ambari server setup, so that the user will have the option to either create the admin user with the username/password of their preference or can use the default username. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java 9cdde8f ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e341405 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6164b2d ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87 ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59503/diff/6/ Changes: https://reviews.apache.org/r/59503/diff/5-6/ Testing --- Added 1 test case Ran mvn test File Attachments custom_admin.PNG https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG Thanks, Anita Jebaraj
Review Request 59756: Delete view privileges from the Groups page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/ --- Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. Bugs: AMBARI-21172 https://issues.apache.org/jira/browse/AMBARI-21172 Repository: ambari Description --- The view permissions are listed in the groups page, but in order to remove it, the user has to drill down to the views page and remove the group from it. To remove the permission for multiple views for one group, we have to navigate to different Views page to perform the operation Including a delete option in the Groups page for views privilege will simply this Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js 92406e9 ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html e472ede8 Diff: https://reviews.apache.org/r/59756/diff/1/ Testing --- Ran mvn test File Attachments Image1.PNG https://reviews.apache.org/media/uploaded/files/2017/06/02/2963340b-98ed-4b28-9cdc-7d67f21a0775__Image1.PNG Thanks, Anita Jebaraj
Re: Review Request 59649: Delete view privileges from the Users page
> On June 1, 2017, 5:39 p.m., Di Li wrote: > > Ship It! Can you please help in pushing the changes? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59649/#review176633 --- On May 30, 2017, 8:10 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59649/ > --- > > (Updated May 30, 2017, 8:10 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. > > > Bugs: AMBARI-21130 > https://issues.apache.org/jira/browse/AMBARI-21130 > > > Repository: ambari > > > Description > --- > > The view permissions are listed in the users page, but in order to remove it, > the user has to drill down to the views page and remove the user from it. To > remove the permission for multiple views for one users, we have to navigate > to different Views page to perform the operation > > Including a delete option in the Users page for views privilege will simply > this > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js > 0706620 > ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html > 7abdf05 > > > Diff: https://reviews.apache.org/r/59649/diff/1/ > > > Testing > --- > > Ran mvn test > > > File Attachments > ---- > > Image1.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/30/9a10ff48-75ed-491f-95ac-5125acab6283__Image1.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 26, 2017, 2:57 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Line 350 (original), 350-356 (patched) > > <https://reviews.apache.org/r/59503/diff/3/?file=1731981#file1731981line350> > > > > This is no longer needed if the trigger to create the admin user is > > based on the existing of an administrator user or not. > > Anita Jebaraj wrote: > Hi Robert, the check if an administrator user exists or not is done in > the createUserHelper class, but this doesn't stop the prompt from being > displayed during ambari-server setup, If I dont have this flag, then the user > will be prompted to enter custom admin user, and later it fails. I thought > there is no point in displaying the prompt during setup again if the user is > already created > > I am not sure if having a java executable command to check if admin user > exists is a good idea. Please let me know how you want this to be handled. > > Robert Levas wrote: > Somehow the setup program knows it has been executed once. Can this > information be used instead? Or maybe a combination of that data and a query > on the database to check for an administrator user? This flag feels to be > unnecessary and will unnecessarily clutter up the ambari.properties file. same as above, using the property server.jdbc.database_name - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review176197 --- On June 1, 2017, 6:08 a.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated June 1, 2017, 6:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 9cdde8f > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/5/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 24, 2017, 1:51 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 351-356 (patched) > > <https://reviews.apache.org/r/59503/diff/2/?file=1730906#file1730906line351> > > > > Is this necessary? It seems like the option is only releated to setup, > > not for normal runtime. > > Anita Jebaraj wrote: > yes it is only used during setup, but I added it here to be included in > the index.md, please let me know if it is not required > > Robert Levas wrote: > I don't think that this is necessary. That index.md file is documentation > for the properties that go in the ambari.properites file. Since the value for > this is only used during Ambari setup, it will not need to be set as a > configuration option and ambari.properties. > > Anita Jebaraj wrote: > I am using this property as a flag in ambari.properties, the prompt to > create custom admin user will be given only the first time of setup if the > flag is set to true then the admin user is created and the prompt is not > required again I am using the property server.jdbc.database_name to determine if the setup is run or not, this is the same property which is used during ambari-server start to check if setup is done, so using the same - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review175924 ------- On June 1, 2017, 6:08 a.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated June 1, 2017, 6:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 9cdde8f > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/5/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/ --- (Updated June 1, 2017, 6:08 a.m.) Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Robert Levas, and Tim Thorpe. Bugs: AMBARI-21083 https://issues.apache.org/jira/browse/AMBARI-21083 Repository: ambari Description --- Provide the ability to create custom admin user during ambari server setup, so that the user will have the option to either create the admin user with the username/password of their preference or can use the default username. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java 9cdde8f ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59503/diff/5/ Changes: https://reviews.apache.org/r/59503/diff/4-5/ Testing --- Added 1 test case Ran mvn test File Attachments custom_admin.PNG https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG Thanks, Anita Jebaraj
Re: Review Request 59503: Create custom admin user during ambari server setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/ --- (Updated June 1, 2017, 5:54 a.m.) Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Robert Levas, and Tim Thorpe. Bugs: AMBARI-21083 https://issues.apache.org/jira/browse/AMBARI-21083 Repository: ambari Description --- Provide the ability to create custom admin user during ambari server setup, so that the user will have the option to either create the admin user with the username/password of their preference or can use the default username. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java 9cdde8f ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59503/diff/4/ Changes: https://reviews.apache.org/r/59503/diff/3-4/ Testing --- Added 1 test case Ran mvn test File Attachments custom_admin.PNG https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG Thanks, Anita Jebaraj
Review Request 59649: Delete view privileges from the Users page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59649/ --- Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. Bugs: AMBARI-21130 https://issues.apache.org/jira/browse/AMBARI-21130 Repository: ambari Description --- The view permissions are listed in the users page, but in order to remove it, the user has to drill down to the views page and remove the user from it. To remove the permission for multiple views for one users, we have to navigate to different Views page to perform the operation Including a delete option in the Users page for views privilege will simply this Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 0706620 ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 7abdf05 Diff: https://reviews.apache.org/r/59649/diff/1/ Testing --- Ran mvn test File Attachments Image1.PNG https://reviews.apache.org/media/uploaded/files/2017/05/30/9a10ff48-75ed-491f-95ac-5125acab6283__Image1.PNG Thanks, Anita Jebaraj
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 26, 2017, 2:57 p.m., Robert Levas wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 1234 (patched) > > <https://reviews.apache.org/r/59503/diff/3/?file=1731985#file1731985line1234> > > > > Why not combine the prompt and the creating of the account here? It can be done, but currently all the prompts are given during setup and then the creation is done (creating tables, creating schema etc.), so I just wanted to follow similar approach, rather than prompting create admin user later - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review176197 ------- On May 24, 2017, 8:40 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated May 24, 2017, 8:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > ambari-server/docs/configuration/index.md ff9ce54 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 9cdde8f > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/3/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 26, 2017, 2:57 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Line 350 (original), 350-356 (patched) > > <https://reviews.apache.org/r/59503/diff/3/?file=1731981#file1731981line350> > > > > This is no longer needed if the trigger to create the admin user is > > based on the existing of an administrator user or not. Hi Robert, the check if an administrator user exists or not is done in the createUserHelper class, but this doesn't stop the prompt from being displayed during ambari-server setup, If I dont have this flag, then the user will be prompted to enter custom admin user, and later it fails. I thought there is no point in displaying the prompt during setup again if the user is already created I am not sure if having a java executable command to check if admin user exists is a good idea. Please let me know how you want this to be handled. - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review176197 ------- On May 24, 2017, 8:40 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated May 24, 2017, 8:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > ambari-server/docs/configuration/index.md ff9ce54 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 9cdde8f > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/3/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 24, 2017, 3:37 p.m., Robert Levas wrote: > > This update will create a security issue. We need to ensure that an admin > > user is only created once via this script. This should occur during the > > *first* call to `ambari-server setup` - which is expected to be done by a > > system administrator - ideally `root`. After that, `ambari-server` may be > > exectued by another user, if an alternate user is set to execute Ambari. > > > > If a non-administrative user can execute `ambari-server setup` and that > > user is allowed to set or update users in the Ambari database (without > > first being authenticated by Ambari), then users other than Ambari > > Administrators can effectively manage Ambari users. We should not allow > > this to happen. > > > > I think that if we want to allow this feature, we need to first query the > > Ambari database to see if there is already a user with administrator > > privileges. If not, then the setup script should be allowed to create the > > first Ambari Administrator account. If one exists, than the setup script > > should not be allowed to create new or update existing users in the > > database. Because `org.apache.ambari.server.controller.CreateUserHelper` is > > an executable class, the check needs to be done there to ensure OS-level > > users with the ability to read this class do not gain the ability to create > > (and possibly update) Ambari user accounts while by-passing needed > > authorization checks. Thank you Robert for your suggestions, I have modified the implementation so for the first time the ambari-server setup is run the admin user gets created and the create.admin.flag is set to true in ambari.properties. If the class CreateUserHelper is executed, it looks if admin user exists and it fails there, so the users cannot be modified/created just by executing the class later. Even if the create.admin.flag in ambari.properties is switched to false and ambari-server setup is run, new admin user cannot be created, since it looks for existing admin users and it fails with the message "User cannot be created, Admin user already exists, login to Ambari UI to create/modify users" - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review175942 --- On May 24, 2017, 8:40 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated May 24, 2017, 8:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > ambari-server/docs/configuration/index.md ff9ce54 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 9cdde8f > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/3/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59496: Enable opening views in a new tab
> On May 24, 2017, 4:31 p.m., Sangeeta Ravindran wrote: > > Ship It! Hi Sangeeta, can you please help pushing the changes? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59496/#review175952 --- On May 23, 2017, 6:58 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59496/ > --- > > (Updated May 23, 2017, 6:58 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, > Pallav Kulshreshtha, and Sangeeta Ravindran. > > > Bugs: AMBARI-21095 > https://issues.apache.org/jira/browse/AMBARI-21095 > > > Repository: ambari > > > Description > --- > > Enable views to be opened in a new tab instead of being opened in the same > tab, this would help in going between the different tabs to look for > information or for config updates in the services. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/index.html 32f9ba7 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > b6ec61d > ambari-web/app/controllers/main/views_controller.js 398cdd8 > ambari-web/app/models/view_instance.js d438640 > ambari-web/test/controllers/main/views_controller_test.js 0ab7654 > ambari-web/test/models/view_instance_test.js 0e977e3 > > > Diff: https://reviews.apache.org/r/59496/diff/1/ > > > Testing > --- > > Modified the test cases, > > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 24, 2017, 1:51 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 351-356 (patched) > > <https://reviews.apache.org/r/59503/diff/2/?file=1730906#file1730906line351> > > > > Is this necessary? It seems like the option is only releated to setup, > > not for normal runtime. > > Anita Jebaraj wrote: > yes it is only used during setup, but I added it here to be included in > the index.md, please let me know if it is not required > > Robert Levas wrote: > I don't think that this is necessary. That index.md file is documentation > for the properties that go in the ambari.properites file. Since the value for > this is only used during Ambari setup, it will not need to be set as a > configuration option and ambari.properties. I am using this property as a flag in ambari.properties, the prompt to create custom admin user will be given only the first time of setup if the flag is set to true then the admin user is created and the prompt is not required again - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review175924 ------- On May 23, 2017, 11:26 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated May 23, 2017, 11:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/2/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 24, 2017, 1:51 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 351-356 (patched) > > <https://reviews.apache.org/r/59503/diff/2/?file=1730906#file1730906line351> > > > > Is this necessary? It seems like the option is only releated to setup, > > not for normal runtime. yes it is only used during setup, but I added it here to be included in the index.md, please let me know if it is not required - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review175924 ------- On May 23, 2017, 11:26 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated May 23, 2017, 11:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/2/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
> On May 23, 2017, 10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > > Lines 19 (patched) > > <https://reviews.apache.org/r/59503/diff/1/?file=1730396#file1730396line19> > > > > Use braces and add javadoc Included javadoc and braces in the new patch > On May 23, 2017, 10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 972 (patched) > > <https://reviews.apache.org/r/59503/diff/1/?file=1730398#file1730398line972> > > > > We should allow special characters in passwords I have added this validation only for username, password allows special characters. I have matched the validation for username to be the same as in UI > On May 23, 2017, 10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 975 (patched) > > <https://reviews.apache.org/r/59503/diff/1/?file=1730398#file1730398line975> > > > > May want to check that it isn't a list of spaces either. I have added a strip() for admin_user, which would remove the leading and trailing white spaces, verified this behavior in the UI as well - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review175864 --- On May 23, 2017, 11:26 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > --- > > (Updated May 23, 2017, 11:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > --- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/2/ > > > Testing > --- > > Added 1 test case > > > Ran mvn test > > > File Attachments > > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59503: Create custom admin user during ambari server setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/ --- (Updated May 23, 2017, 11:26 p.m.) Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Robert Levas, and Tim Thorpe. Bugs: AMBARI-21083 https://issues.apache.org/jira/browse/AMBARI-21083 Repository: ambari Description --- Provide the ability to create custom admin user during ambari server setup, so that the user will have the option to either create the admin user with the username/password of their preference or can use the default username. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 114046f ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java PRE-CREATION ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59503/diff/2/ Changes: https://reviews.apache.org/r/59503/diff/1-2/ Testing --- Added 1 test case Ran mvn test File Attachments custom_admin.PNG https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG Thanks, Anita Jebaraj
Review Request 59503: Create custom admin user during ambari server setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/ --- Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Robert Levas, and Tim Thorpe. Bugs: AMBARI-21083 https://issues.apache.org/jira/browse/AMBARI-21083 Repository: ambari Description --- Provide the ability to create custom admin user during ambari server setup Diffs - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 114046f ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java PRE-CREATION ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59503/diff/1/ Testing --- Added 1 test case Ran mvn test File Attachments custom_admin.PNG https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG Thanks, Anita Jebaraj
Review Request 59496: Enable opening views in a new tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59496/ --- Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. Bugs: AMBARI-21095 https://issues.apache.org/jira/browse/AMBARI-21095 Repository: ambari Description --- Enable views to be opened in a new tab instead of being opened in the same tab, this would help in going between the different tabs to look for information or for config updates in the services. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/index.html 32f9ba7 ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html b6ec61d ambari-web/app/controllers/main/views_controller.js 398cdd8 ambari-web/app/models/view_instance.js d438640 ambari-web/test/controllers/main/views_controller_test.js 0ab7654 ambari-web/test/models/view_instance_test.js 0e977e3 Diff: https://reviews.apache.org/r/59496/diff/1/ Testing --- Modified the test cases, Ran mvn test Thanks, Anita Jebaraj
Re: Review Request 59338: Backport Ambari-17694 - Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59338/#review175273 --- Ship it! Ship It! - Anita Jebaraj On May 17, 2017, 5:09 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59338/ > --- > > (Updated May 17, 2017, 5:09 p.m.) > > > Review request for Ambari, Anita Jebaraj, Laszlo Puskas, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-21043 > https://issues.apache.org/jira/browse/AMBARI-21043 > > > Repository: ambari > > > Description > --- > > Backport Ambari-17694 to Ambari 2.5.1 because the patch was never committed > to branch-2.5 and thus did not make it into Ambari 2.5.0. > > Most of the changes from Ambari 2.4.x applied without much additional work, > however an upgrade path from Ambari 2.5.0 to Ambari 2.5.1 has been created > since users of Ambari 2.5.1 may have missed out on the needed changes. This > additional work was essentially copying > `org.apache.ambari.server.upgrade.UpgradeCatalog240#updateKAFKAConfigs` to > `org.apache.ambari.server.upgrade.UpgradeCatalog251#updateKAFKAConfigs` and > adding to the unit tests in > `org.apache.ambari.server.upgrade.UpgradeCatalog251Test`. > > See AMBARI-17694 for more information about the changes. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java > 77333b8bc4 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > cf0c37dd02 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java > 146520fa11 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > 1327090aa7 > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json > 60fa959f2d > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > d0f82af13d > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json > 501f969a93 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java > 857047bd4d > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 8baf496474 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java > 4575998c50 > > > Diff: https://reviews.apache.org/r/59338/diff/2/ > > > Testing > --- > > Manually tested upgrades from Ambari 2.4.0 to Ambari 2.5.1, and from Ambari > 2.5.0 to Ambari 2.5.1 > > #Local test results: PENDING > > #Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Re: Review Request 59338: Backport Ambari-17694 - Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59338/#review175265 --- Hi Robert, please also backport https://issues.apache.org/jira/browse/AMBARI-18188, due to the typo the method validateKAFKAConfigurations will not be called otherwise. Thanks - Anita Jebaraj On May 17, 2017, 2:18 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59338/ > --- > > (Updated May 17, 2017, 2:18 p.m.) > > > Review request for Ambari, Anita Jebaraj, Laszlo Puskas, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-21043 > https://issues.apache.org/jira/browse/AMBARI-21043 > > > Repository: ambari > > > Description > --- > > Backport Ambari-17694 to Ambari 2.5.1 because the patch was never committed > to branch-2.5 and thus did not make it into Ambari 2.5.0. > > Most of the changes from Ambari 2.4.x applied without much additional work, > however an upgrade path from Ambari 2.5.0 to Ambari 2.5.1 has been created > since users of Ambari 2.5.1 may have missed out on the needed changes. This > additional work was essentially copying > `org.apache.ambari.server.upgrade.UpgradeCatalog240#updateKAFKAConfigs` to > `org.apache.ambari.server.upgrade.UpgradeCatalog251#updateKAFKAConfigs` and > adding to the unit tests in > `org.apache.ambari.server.upgrade.UpgradeCatalog251Test`. > > See AMBARI-17694 for more information about the changes. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java > 77333b8bc4 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > cf0c37dd02 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java > 146520fa11 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > 1327090aa7 > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json > 60fa959f2d > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > d0f82af13d > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json > 501f969a93 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java > 857047bd4d > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 8baf496474 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java > 4575998c50 > > > Diff: https://reviews.apache.org/r/59338/diff/1/ > > > Testing > --- > > Manually tested upgrades from Ambari 2.4.0 to Ambari 2.5.1, and from Ambari > 2.5.0 to Ambari 2.5.1 > > #Local test results: PENDING > > #Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard
> On May 12, 2017, 6:57 a.m., venkat sairam wrote: > > When we enter some random text instead of selecting "tagsinput" option, the > > text is not cleared even after clicking clear filters button. > > Please handle this use case too. Hi, I have updated the patch with this usecase, please review it. Thanks in advance - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58894/#review174766 --- On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58894/ > --- > > (Updated May 4, 2017, 7:09 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20904 > https://issues.apache.org/jira/browse/AMBARI-20904 > > > Repository: ambari > > > Description > --- > > Currently the filters can be cleared only manually by removing the contents, > having a button to clear the filters on one click would be helpful. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 4bfb5fa > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs > b9c6029 > > > Diff: https://reviews.apache.org/r/58894/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > ClearFilters > > https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg > ClearFilters-updated > > https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg > > > Thanks, > > Anita Jebaraj > >
Review Request 59151: Workflow Designer View: Provide sorting of workflows on dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59151/ --- Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran. Bugs: AMBARI-20972 https://issues.apache.org/jira/browse/AMBARI-20972 Repository: ambari Description --- The workflows displayed on the worflow designer view dashboard are not sortable. The ability to sort via Name, Status, User, Created Time, End Time and jobId should be included Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 01eb4ea contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 86ab5a5 Diff: https://reviews.apache.org/r/59151/diff/1/ Testing --- Tested manually File Attachments sort https://reviews.apache.org/media/uploaded/files/2017/05/10/325cfa3d-d3fb-43e8-8e9a-5d1315be299e__wfmSort.PNG Thanks, Anita Jebaraj
Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard
> On May 5, 2017, 5:10 a.m., belliraj hb wrote: > > Ship It! can you please help in pushing the changes, thanks in advance - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58894/#review174001 --- On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58894/ > --- > > (Updated May 4, 2017, 7:09 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20904 > https://issues.apache.org/jira/browse/AMBARI-20904 > > > Repository: ambari > > > Description > --- > > Currently the filters can be cleared only manually by removing the contents, > having a button to clear the filters on one click would be helpful. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 4bfb5fa > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs > b9c6029 > > > Diff: https://reviews.apache.org/r/58894/diff/2/ > > > Testing > --- > > Tested manually > > > File Attachments > > > ClearFilters > > https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg > ClearFilters-updated > > https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard
> On May 3, 2017, 10:30 a.m., belliraj hb wrote: > > I guess "clear filter" takes lot of space. I think clear filter should be a > > simpler icon (may be a X) and it should be before refresh. Thank you for the comments, I have updated the icon, please review the new patch - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58894/#review173719 --- On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58894/ > --- > > (Updated May 4, 2017, 7:09 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20904 > https://issues.apache.org/jira/browse/AMBARI-20904 > > > Repository: ambari > > > Description > --- > > Currently the filters can be cleared only manually by removing the contents, > having a button to clear the filters on one click would be helpful. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 4bfb5fa > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs > b9c6029 > > > Diff: https://reviews.apache.org/r/58894/diff/2/ > > > Testing > --- > > Tested manually > > > File Attachments > > > ClearFilters > > https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg > ClearFilters-updated > > https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict
> On May 3, 2017, 6:54 p.m., Robert Levas wrote: > > Ship It! Thank you Robert, please help in pushing the changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58968/#review173790 --- On May 3, 2017, 6:24 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58968/ > --- > > (Updated May 3, 2017, 6:24 p.m.) > > > Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim > Thorpe. > > > Bugs: AMBARI-20909 > https://issues.apache.org/jira/browse/AMBARI-20909 > > > Repository: ambari > > > Description > --- > > Create a local user "test" in Ambari > > Create a system user "test" with different password > > Trying to authenticate via pam in Ambari UI as user "test" throws Server > Error in Ambari UI, without any error in Ambari-server logs > > Also the UI gets stalled and not even able to login as admin user unless the > browser cache is removed or Ambari UI is opened in a new browser page > > Ambari doesn't allow creating users with same user name but different > types(Local/pam), We reach the pam authentication only when the local user > authentication failed due to non-existing userid or incorrect password, So if > local user exists do not attempt to authenticate via PAM, This lets Ambari to > avoid importing duplicate userid into the database > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java > b3fb861 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java > b7272c5 > > > Diff: https://reviews.apache.org/r/58968/diff/2/ > > > Testing > --- > > Updated the related test cases > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict
> On May 3, 2017, 5:08 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Lines 79 (patched)
> > <https://reviews.apache.org/r/58968/diff/1/?file=1707168#file1707168line79>
> >
> > There are other User types - LDAP and JWT. You should check to see if
> > any user exists with the username. If the existing user is not a PAM user
> > the failure should occur.
> >
> > For example:
> > ```
> > UserEntitiy foundUser = userDAO.findUserByName(username)'
> > if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
> > ... Fail ...
> > }
> > ```
>
> Tim Thorpe wrote:
> Hi Robert, I'm not sure I'm following your logic here. My interpretation
> is that the PAM users will not be found using the
> UserDAO.findLocalUserByName(String userName) method. So basically the
> getUserType() != UserType.PAM is unnecessary. Although it wouldn't hurt.
>
> Anita Jebaraj wrote:
> Hi Tim, Robert means that I should look for all user types like
> (Local/ldap/jwt), I am aware ldap cannot be enabled when pam is enabled, but
> jwt users can exist when pam is enabled. That should be the reason why he
> wants me to look for all the users.
>
> Tim Thorpe wrote:
> Sorry missed the part where you changed findLocalUserByName to
> findUserByName. That makes sense now.
Hi Robert, please review the new patch
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173752
---
On May 3, 2017, 6:24 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
>
> (Updated May 3, 2017, 6:24 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim
> Thorpe.
>
>
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Create a local user "test" in Ambari
>
> Create a system user "test" with different password
>
> Trying to authenticate via pam in Ambari UI as user "test" throws Server
> Error in Ambari UI, without any error in Ambari-server logs
>
> Also the UI gets stalled and not even able to login as admin user unless the
> browser cache is removed or Ambari UI is opened in a new browser page
>
> Ambari doesn't allow creating users with same user name but different
> types(Local/pam), We reach the pam authentication only when the local user
> authentication failed due to non-existing userid or incorrect password, So if
> local user exists do not attempt to authenticate via PAM, This lets Ambari to
> avoid importing duplicate userid into the database
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> b3fb861
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
> b7272c5
>
>
> Diff: https://reviews.apache.org/r/58968/diff/2/
>
>
> Testing
> ---
>
> Updated the related test cases
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58968/ --- (Updated May 3, 2017, 6:24 p.m.) Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim Thorpe. Bugs: AMBARI-20909 https://issues.apache.org/jira/browse/AMBARI-20909 Repository: ambari Description --- Create a local user "test" in Ambari Create a system user "test" with different password Trying to authenticate via pam in Ambari UI as user "test" throws Server Error in Ambari UI, without any error in Ambari-server logs Also the UI gets stalled and not even able to login as admin user unless the browser cache is removed or Ambari UI is opened in a new browser page Ambari doesn't allow creating users with same user name but different types(Local/pam), We reach the pam authentication only when the local user authentication failed due to non-existing userid or incorrect password, So if local user exists do not attempt to authenticate via PAM, This lets Ambari to avoid importing duplicate userid into the database Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java b3fb861 ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java b7272c5 Diff: https://reviews.apache.org/r/58968/diff/2/ Changes: https://reviews.apache.org/r/58968/diff/1-2/ Testing --- Updated the related test cases Thanks, Anita Jebaraj
Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict
> On May 3, 2017, 5:08 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Lines 79 (patched)
> > <https://reviews.apache.org/r/58968/diff/1/?file=1707168#file1707168line79>
> >
> > There are other User types - LDAP and JWT. You should check to see if
> > any user exists with the username. If the existing user is not a PAM user
> > the failure should occur.
> >
> > For example:
> > ```
> > UserEntitiy foundUser = userDAO.findUserByName(username)'
> > if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
> > ... Fail ...
> > }
> > ```
>
> Tim Thorpe wrote:
> Hi Robert, I'm not sure I'm following your logic here. My interpretation
> is that the PAM users will not be found using the
> UserDAO.findLocalUserByName(String userName) method. So basically the
> getUserType() != UserType.PAM is unnecessary. Although it wouldn't hurt.
Hi Tim, Robert means that I should look for all user types like
(Local/ldap/jwt), I am aware ldap cannot be enabled when pam is enabled, but
jwt users can exist when pam is enabled. That should be the reason why he wants
me to look for all the users.
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173752
---
On May 3, 2017, 4:48 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
>
> (Updated May 3, 2017, 4:48 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim
> Thorpe.
>
>
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Create a local user "test" in Ambari
>
> Create a system user "test" with different password
>
> Trying to authenticate via pam in Ambari UI as user "test" throws Server
> Error in Ambari UI, without any error in Ambari-server logs
>
> Also the UI gets stalled and not even able to login as admin user unless the
> browser cache is removed or Ambari UI is opened in a new browser page
>
> Ambari doesn't allow creating users with same user name but different
> types(Local/pam), We reach the pam authentication only when the local user
> authentication failed due to non-existing userid or incorrect password, So if
> local user exists do not attempt to authenticate via PAM, This lets Ambari to
> avoid importing duplicate userid into the database
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> b3fb861
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
> b7272c5
>
>
> Diff: https://reviews.apache.org/r/58968/diff/1/
>
>
> Testing
> ---
>
> Updated the related test cases
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58968/ --- Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim Thorpe. Bugs: AMBARI-20909 https://issues.apache.org/jira/browse/AMBARI-20909 Repository: ambari Description --- Create a local user "test" in Ambari Create a system user "test" with different password Trying to authenticate via pam in Ambari UI as user "test" throws Server Error in Ambari UI, without any error in Ambari-server logs Also the UI gets stalled and not even able to login as admin user unless the browser cache is removed or Ambari UI is opened in a new browser page Ambari doesn't allow creating users with same user name but different types(Local/pam), We reach the pam authentication only when the local user authentication failed due to non-existing userid or incorrect password, So if local user exists do not attempt to authenticate via PAM, This lets Ambari to avoid importing duplicate userid into the database Diffs - ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java b3fb861 ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java b7272c5 Diff: https://reviews.apache.org/r/58968/diff/1/ Testing --- Updated the related test cases Thanks, Anita Jebaraj
Review Request 58894: WFM: Include an option to clear filters in workflow dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58894/ --- Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran. Bugs: AMBARI-20904 https://issues.apache.org/jira/browse/AMBARI-20904 Repository: ambari Description --- Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029 Diff: https://reviews.apache.org/r/58894/diff/1/ Testing --- Tested manually File Attachments ClearFilters https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg Thanks, Anita Jebaraj
Re: Review Request 58429: After pam setup- Hive View user home test fails
> On May 1, 2017, 8:09 p.m., Robert Levas wrote:
> > Ship It!
Thank you Robert, can you please help in pushing the changes
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173498
---
On May 1, 2017, 8 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
>
> (Updated May 1, 2017, 8 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning
> Kropp, Robert Levas, and Tim Thorpe.
>
>
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
>
>
> Repository: ambari
>
>
> Description
> ---
>
> After setting up PAM, tried to login as PAM user and access hive view, user
> home test fails with the error as in screen shot.
>
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was
> not incorporated in the code. Pasting the comment from Henning below.
>
> Something we noticed is that in a secured cluster we have issues with the
> views, getting the following exception for the Hive view as an example:
>
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS,
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to
> validate proxy privilege of ambari for
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege
> of ambari for
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
> serverProtocolVersion:null)
>
> As you can see it tries to impersonte
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
> Changing the UsernamePasswordAuthenticationToken from Principal to username
> fixes this.
>
> So instead of :
>
> UsernamePasswordAuthenticationToken token = new
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
>
> We use:
>
> UsernamePasswordAuthenticationToken token = new
> UsernamePasswordAuthenticationToken(user.getUserName(), null,
> userAuthorities);
>
> What could potential also work is, overriding toString of the principal like:
>
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
>
> @Override
> public String toString()
> { return user.getUserName().toString(); }
>
> };
>
> We did not test this!
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> ca7cd31
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
> 5b3acd0
>
>
> Diff: https://reviews.apache.org/r/58429/diff/2/
>
>
> Testing
> ---
>
> Ran mvn test and also manually tested the scenario
>
>
> File Attachments
>
>
> error screenshot
>
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58429: After pam setup- Hive View user home test fails
> On April 28, 2017, 7 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Line 128 (original), 127 (patched)
> > <https://reviews.apache.org/r/58429/diff/1/?file=1692248#file1692248line128>
> >
> > Can you use
> > `org.apache.ambari.server.security.authorization.AmbariUserAuthentication`
> > to be more consistent with other Ambari-specific authentication providers.
> > For example,
> > `org.apache.ambari.server.security.authorization.AmbariLocalUserProvider`
Hi Robert, yes the authentication provider can be changed, please review the
new patch
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173365
-----------
On May 1, 2017, 8 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
>
> (Updated May 1, 2017, 8 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning
> Kropp, Robert Levas, and Tim Thorpe.
>
>
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
>
>
> Repository: ambari
>
>
> Description
> ---
>
> After setting up PAM, tried to login as PAM user and access hive view, user
> home test fails with the error as in screen shot.
>
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was
> not incorporated in the code. Pasting the comment from Henning below.
>
> Something we noticed is that in a secured cluster we have issues with the
> views, getting the following exception for the Hive view as an example:
>
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS,
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to
> validate proxy privilege of ambari for
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege
> of ambari for
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
> serverProtocolVersion:null)
>
> As you can see it tries to impersonte
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
> Changing the UsernamePasswordAuthenticationToken from Principal to username
> fixes this.
>
> So instead of :
>
> UsernamePasswordAuthenticationToken token = new
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
>
> We use:
>
> UsernamePasswordAuthenticationToken token = new
> UsernamePasswordAuthenticationToken(user.getUserName(), null,
> userAuthorities);
>
> What could potential also work is, overriding toString of the principal like:
>
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
>
> @Override
> public String toString()
> { return user.getUserName().toString(); }
>
> };
>
> We did not test this!
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> ca7cd31
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
> 5b3acd0
>
>
> Diff: https://reviews.apache.org/r/58429/diff/2/
>
>
> Testing
> ---
>
> Ran mvn test and also manually tested the scenario
>
>
> File Attachments
>
>
> error screenshot
>
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58429: After pam setup- Hive View user home test fails
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---
(Updated May 1, 2017, 8 p.m.)
Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning
Kropp, Robert Levas, and Tim Thorpe.
Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760
Repository: ambari
Description
---
After setting up PAM, tried to login as PAM user and access hive view, user
home test fails with the error as in screen shot.
This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was
not incorporated in the code. Pasting the comment from Henning below.
Something we noticed is that in a secured cluster we have issues with the
views, getting the following exception for the Hive view as an example:
Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS,
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate
proxy privilege of ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of
ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
serverProtocolVersion:null)
As you can see it tries to impersonte
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
Changing the UsernamePasswordAuthenticationToken from Principal to username
fixes this.
So instead of :
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
We use:
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);
What could potential also work is, overriding toString of the principal like:
Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }
@Override
public String toString()
{ return user.getUserName().toString(); }
};
We did not test this!
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
ca7cd31
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
5b3acd0
Diff: https://reviews.apache.org/r/58429/diff/2/
Changes: https://reviews.apache.org/r/58429/diff/1-2/
Testing
---
Ran mvn test and also manually tested the scenario
File Attachments
error screenshot
https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
Thanks,
Anita Jebaraj
Re: Review Request 58855: Indentation error in file causing build failure in ambari-server
> On April 28, 2017, 8:44 p.m., Robert Levas wrote: > > Ship It! Hi Robert, can you please push the patch in? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58855/#review173379 --- On April 28, 2017, 8:41 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58855/ > --- > > (Updated April 28, 2017, 8:41 p.m.) > > > Review request for Ambari, Di Li, Jonathan Hurley, Robert Levas, and Tim > Thorpe. > > > Bugs: AMBARI-20892 > https://issues.apache.org/jira/browse/AMBARI-20892 > > > Repository: ambari > > > Description > --- > > Indendation error in one line in file alert_spark_livy_port.py is causing > compilation failure while trying to build ambari server > > > [INFO] Bytecompiling .py files below > /root/workspace-test/ambari/ambari-server/target/rpm/ambari-server/b > uildroot/usr/lib/python2.6 using /usr/bin/python2.6 > [INFO] Compiling > /root/workspace-test/ambari/ambari-server/target/rpm/ambari-server/buildroot/var/lib/amb > > ari-server/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py > ... > [INFO] Sorry: IndentationError: unindent does not match any outer indentation > level (alert_spark_livy_por t.py, line 106) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py > 7396440 > > > Diff: https://reviews.apache.org/r/58855/diff/1/ > > > Testing > --- > > Was able to compile ambari-server successfully > > > Thanks, > > Anita Jebaraj > >
Review Request 58855: Indendation error in file causing compilation failure in ambari-server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58855/ --- Review request for Ambari, Di Li, Jonathan Hurley, Robert Levas, and Tim Thorpe. Bugs: AMBARI-20892 https://issues.apache.org/jira/browse/AMBARI-20892 Repository: ambari Description --- Indendation error in one line in file alert_spark_livy_port.py is causing compilation failure while trying to build ambari server [INFO] Bytecompiling .py files below /root/workspace-test/ambari/ambari-server/target/rpm/ambari-server/b uildroot/usr/lib/python2.6 using /usr/bin/python2.6 [INFO] Compiling /root/workspace-test/ambari/ambari-server/target/rpm/ambari-server/buildroot/var/lib/amb ari-server/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py ... [INFO] Sorry: IndentationError: unindent does not match any outer indentation level (alert_spark_livy_por t.py, line 106) Diffs - ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 7396440 Diff: https://reviews.apache.org/r/58855/diff/1/ Testing --- Was able to compile ambari-server successfully Thanks, Anita Jebaraj
Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error
> On April 28, 2017, 5:24 a.m., Padma Priya N wrote: > > Ship It! Thank you for reviewing, can you please help in pushing the changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/#review173292 --- On April 27, 2017, 4:41 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58780/ > --- > > (Updated April 27, 2017, 4:41 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20850 > https://issues.apache.org/jira/browse/AMBARI-20850 > > > Repository: ambari > > > Description > --- > > Clicking on search icon when the filter is empty in workflow dashboard throws > the error Remote API failed as in screenshot > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 7e69dea > > > Diff: https://reviews.apache.org/r/58780/diff/2/ > > > Testing > --- > > Tested Manually > > > File Attachments > > > error > > https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/ --- (Updated April 27, 2017, 4:41 p.m.) Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran. Bugs: AMBARI-20850 https://issues.apache.org/jira/browse/AMBARI-20850 Repository: ambari Description --- Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea Diff: https://reviews.apache.org/r/58780/diff/2/ Changes: https://reviews.apache.org/r/58780/diff/1-2/ Testing --- Tested Manually File Attachments error https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg Thanks, Anita Jebaraj
Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error
> On April 27, 2017, 6:15 a.m., Padma Priya N wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > > Lines 193 (patched) > > <https://reviews.apache.org/r/58780/diff/1/?file=1701053#file1701053line193> > > > > It is better to use Ember.isBlank() instead of != I have updated in the new patch - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/#review173160 --- On April 27, 2017, 5:59 a.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58780/ > --- > > (Updated April 27, 2017, 5:59 a.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20850 > https://issues.apache.org/jira/browse/AMBARI-20850 > > > Repository: ambari > > > Description > --- > > Clicking on search icon when the filter is empty in workflow dashboard throws > the error Remote API failed as in screenshot > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 7e69dea > > > Diff: https://reviews.apache.org/r/58780/diff/1/ > > > Testing > --- > > Tested Manually > > > File Attachments > ---- > > error > > https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg > > > Thanks, > > Anita Jebaraj > >
Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/ --- Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran. Bugs: AMBARI-20850 https://issues.apache.org/jira/browse/AMBARI-20850 Repository: ambari Description --- Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea Diff: https://reviews.apache.org/r/58780/diff/1/ Testing --- Tested Manually File Attachments error https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg Thanks, Anita Jebaraj
Re: Review Request 58715: WFM: Date filter in workflow dashboard is not working properly
> On April 26, 2017, 4:41 a.m., Padma Priya N wrote: > > Ship It! Thank you for reviewing and pushing the changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58715/#review173021 --- On April 25, 2017, 10:14 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58715/ > --- > > (Updated April 25, 2017, 10:14 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, Pallav Kulshreshtha, and Sangeeta Ravindran. > > > Bugs: AMBARI-20838 > https://issues.apache.org/jira/browse/AMBARI-20838 > > > Repository: ambari > > > Description > --- > > Date filter in workflow dashboard is not filtering the values according to > the date/time entered > AM/PM is not calculated for the time while filtering, So when 1.00 PM is > entered it is sent as 1.00 instead of 13.00 > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 96ee230 > > > Diff: https://reviews.apache.org/r/58715/diff/1/ > > > Testing > --- > > Tested manually > > > Thanks, > > Anita Jebaraj > >
Review Request 58715: WFM: Date filter in workflow dashboard is not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58715/ --- Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran. Bugs: AMBARI-20838 https://issues.apache.org/jira/browse/AMBARI-20838 Repository: ambari Description --- Date filter in workflow dashboard is not filtering the values according to the date/time entered AM/PM is not calculated for the time while filtering, So when 1.00 PM is entered it is sent as 1.00 instead of 13.00 Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 96ee230 Diff: https://reviews.apache.org/r/58715/diff/1/ Testing --- Tested manually Thanks, Anita Jebaraj
Re: Review Request 58591: Roles page in Ambari UI shows extra rows in IE browser
> On April 21, 2017, 6:19 a.m., Alexandr Antonenko wrote: > > Ship It! Can you please help in pushing the changes? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58591/#review172589 --- On April 20, 2017, 8:34 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58591/ > --- > > (Updated April 20, 2017, 8:34 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, Richard Zang, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20810 > https://issues.apache.org/jira/browse/AMBARI-20810 > > > Repository: ambari > > > Description > --- > > Roles page in Ambari UI shows extra empty rows in Internet explorer. > > javascript For..each loop doesn't work as expected for arrays in Internet > explorer, which causes the extra rows as in screenshot. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js > e1b74aa > > > Diff: https://reviews.apache.org/r/58591/diff/1/ > > > Testing > --- > > tested manually, verified in different browsers (IE/firefox/chrome) > > > File Attachments > > > After fix > > https://reviews.apache.org/media/uploaded/files/2017/04/20/d891ffb5-e048-4c4c-9b50-dca3bab48ba2__Afterfix.jpg > Before fix > > https://reviews.apache.org/media/uploaded/files/2017/04/20/a6915f9d-d69b-4dda-9e3b-6cfd338cb815__UI.jpg > > > Thanks, > > Anita Jebaraj > >
Review Request 58591: Roles page in Ambari UI shows extra rows in IE browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58591/ --- Review request for Ambari, Alexandr Antonenko, Di Li, Richard Zang, and Sangeeta Ravindran. Bugs: AMBARI-20810 https://issues.apache.org/jira/browse/AMBARI-20810 Repository: ambari Description --- Roles page in Ambari UI shows extra empty rows in Internet explorer. javascript For..each loop doesn't work as expected for arrays in Internet explorer, which causes the extra rows as in screenshot. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js e1b74aa Diff: https://reviews.apache.org/r/58591/diff/1/ Testing --- tested manually, verified in different browsers (IE/firefox/chrome) File Attachments After fix https://reviews.apache.org/media/uploaded/files/2017/04/20/d891ffb5-e048-4c4c-9b50-dca3bab48ba2__Afterfix.jpg Before fix https://reviews.apache.org/media/uploaded/files/2017/04/20/a6915f9d-d69b-4dda-9e3b-6cfd338cb815__UI.jpg Thanks, Anita Jebaraj
Re: Review Request 58429: After pam setup- Hive View user home test fails
> On April 13, 2017, 6:57 p.m., Robert Levas wrote:
> > Can you add Vishal Ghugare to the review?
Hi Robert, I have added Vishal to the review, he is currently on vacation and
might not be looking at the jira for now. Meanwhile the team would like to get
a solution for this issue, it would be helpful if you can take a look at this.
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review171916
---
On April 13, 2017, 7:01 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
>
> (Updated April 13, 2017, 7:01 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Vishal Ghugare, Henning Kropp,
> and Robert Levas.
>
>
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
>
>
> Repository: ambari
>
>
> Description
> ---
>
> After setting up PAM, tried to login as PAM user and access hive view, user
> home test fails with the error as in screen shot.
>
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was
> not incorporated in the code. Pasting the comment from Henning below.
>
> Something we noticed is that in a secured cluster we have issues with the
> views, getting the following exception for the Hive view as an example:
>
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS,
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to
> validate proxy privilege of ambari for
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege
> of ambari for
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
> serverProtocolVersion:null)
>
> As you can see it tries to impersonte
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
> Changing the UsernamePasswordAuthenticationToken from Principal to username
> fixes this.
>
> So instead of :
>
> UsernamePasswordAuthenticationToken token = new
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
>
> We use:
>
> UsernamePasswordAuthenticationToken token = new
> UsernamePasswordAuthenticationToken(user.getUserName(), null,
> userAuthorities);
>
> What could potential also work is, overriding toString of the principal like:
>
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
>
> @Override
> public String toString()
> { return user.getUserName().toString(); }
>
> };
>
> We did not test this!
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> ca7cd31
>
>
> Diff: https://reviews.apache.org/r/58429/diff/1/
>
>
> Testing
> ---
>
> Ran mvn test and also manually tested the scenario
>
>
> File Attachments
>
>
> error screenshot
>
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58429: After pam setup- Hive View user home test fails
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---
(Updated April 13, 2017, 6:45 p.m.)
Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.
Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760
Repository: ambari
Description
---
After setting up PAM, tried to login as PAM user and access hive view, user
home test fails with the error as in screen shot.
This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was
not incorporated in the code. Pasting the comment from Henning below.
Something we noticed is that in a secured cluster we have issues with the
views, getting the following exception for the Hive view as an example:
Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS,
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate
proxy privilege of ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of
ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
serverProtocolVersion:null)
As you can see it tries to impersonte
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
Changing the UsernamePasswordAuthenticationToken from Principal to username
fixes this.
So instead of :
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
We use:
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);
What could potential also work is, overriding toString of the principal like:
Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }
@Override
public String toString()
{ return user.getUserName().toString(); }
};
We did not test this!
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
ca7cd31
Diff: https://reviews.apache.org/r/58429/diff/1/
Testing
---
Ran mvn test and also manually tested the scenario
File Attachments
error screenshot
https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
Thanks,
Anita Jebaraj
Re: Review Request 58429: After pam setup- Hive View user home test fails
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---
(Updated April 13, 2017, 6:45 p.m.)
Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.
Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760
Repository: ambari
Description
---
After setting up PAM, tried to login as PAM user and access hive view, user
home test fails with the error as in screen shot.
This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was
not incorporated in the code. Pasting the comment from Henning below.
Something we noticed is that in a secured cluster we have issues with the
views, getting the following exception for the Hive view as an example:
Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS,
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate
proxy privilege of ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of
ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
serverProtocolVersion:null)
As you can see it tries to impersonte
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
Changing the UsernamePasswordAuthenticationToken from Principal to username
fixes this.
So instead of :
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
We use:
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);
What could potential also work is, overriding toString of the principal like:
Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }
@Override
public String toString()
{ return user.getUserName().toString(); }
};
We did not test this!
Testing
---
Ran mvn test and also manually tested the scenario
File Attachments (updated)
error screenshot
https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
Thanks,
Anita Jebaraj
Review Request 58429: After pam setup- Hive View user home test fails
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---
Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.
Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760
Repository: ambari
Description
---
After setting up PAM, tried to login as PAM user and access hive view, user
home test fails with the error as in screen shot.
This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was
not incorporated in the code. Pasting the comment from Henning below.
Something we noticed is that in a secured cluster we have issues with the
views, getting the following exception for the Hive view as an example:
Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS,
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate
proxy privilege of ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of
ambari for
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
serverProtocolVersion:null)
As you can see it tries to impersonte
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
Changing the UsernamePasswordAuthenticationToken from Principal to username
fixes this.
So instead of :
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
We use:
UsernamePasswordAuthenticationToken token = new
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);
What could potential also work is, overriding toString of the principal like:
Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }
@Override
public String toString()
{ return user.getUserName().toString(); }
};
We did not test this!
Testing
---
Ran mvn test and also manually tested the scenario
Thanks,
Anita Jebaraj
Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values
> On April 12, 2017, 11:31 a.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you for reviewing, can you please help in pushing the changes? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/#review171710 --- On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57709/ > --- > > (Updated April 5, 2017, 9:43 p.m.) > > > Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN > BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran. > > > Bugs: AMBARI-20334 > https://issues.apache.org/jira/browse/AMBARI-20334 > > > Repository: ambari > > > Description > --- > > capacity field in yarn queue manager should allow entering decimal numbers > upto 2 places, > > currently the field allows entering values like > > 1.2.3 > 12... > 1 2.3 > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > b6c419a > > > Diff: https://reviews.apache.org/r/57709/diff/2/ > > > Testing > --- > > Tested manually > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values
> On March 21, 2017, 4:54 p.m., Alejandro Fernandez wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > > Line 260 (original), 260 (patched) > > <https://reviews.apache.org/r/57709/diff/1/?file=1666450#file1666450line260> > > > > Good practice to always use braces. I have fixed it in the updated patch - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/#review169577 --- On March 21, 2017, 5:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57709/ > --- > > (Updated March 21, 2017, 5:15 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta > Ravindran. > > > Bugs: AMBARI-20334 > https://issues.apache.org/jira/browse/AMBARI-20334 > > > Repository: ambari > > > Description > --- > > capacity field in yarn queue manager should allow entering decimal numbers > upto 2 places, > > currently the field allows entering values like > > 1.2.3 > 12... > 1 2.3 > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > b6c419a > > > Diff: https://reviews.apache.org/r/57709/diff/2/ > > > Testing > --- > > Tested manually > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/ --- (Updated March 21, 2017, 5:15 p.m.) Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta Ravindran. Bugs: AMBARI-20334 https://issues.apache.org/jira/browse/AMBARI-20334 Repository: ambari Description --- capacity field in yarn queue manager should allow entering decimal numbers upto 2 places, currently the field allows entering values like 1.2.3 12... 1 2.3 Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js b6c419a Diff: https://reviews.apache.org/r/57709/diff/2/ Changes: https://reviews.apache.org/r/57709/diff/1-2/ Testing --- Tested manually Thanks, Anita Jebaraj
Review Request 57709: Yarn Queue manager capacity field allows entering invalid values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/ --- Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta Ravindran. Bugs: AMBARI-20334 https://issues.apache.org/jira/browse/AMBARI-20334 Repository: ambari Description --- capacity field in yarn queue manager should allow entering decimal numbers upto 2 places, currently the field allows entering values like 1.2.3 12... 1 2.3 Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js b6c419a Diff: https://reviews.apache.org/r/57709/diff/1/ Testing --- Tested manually Thanks, Anita Jebaraj
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
> On March 10, 2017, 3:40 p.m., Jonathan Hurley wrote:
> > Ship It!
Thank you Jonathan for reviewing, I had to update the patch since there was an
unnecessarily check lingering around in the patch,
+if(propertiesToHideInResponse != null) {
this wont be required now since its assigned to an empty set on the invocation
of the method. Can you please check this out and help me in pushing the changes
to trunk
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168626
---
On March 10, 2017, 3:34 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
>
> (Updated March 10, 2017, 3:34 p.m.)
>
>
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Currently all the details from the ambari.properties file is being returned
> by the API call.
>
> Some of those information may not be utilized and hence an option can be
> provided to filter the properties
>
> A ambari-blacklist.properties file can be created, the properties that are
> entered in the file, will be removed from the api call that returns the
> ambari.properties.
>
>
> Diffs
> -
>
> ambari-server/docs/configuration/index.md af962e1
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> df334c5
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
> dadcf09
>
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
> 8111a39
>
>
> Diff: https://reviews.apache.org/r/57168/diff/8/
>
>
> Testing
> ---
>
> Added 1 test case
> Ran mvn test
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
> On March 8, 2017, 6:44 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 4314-4336 (patched) > > <https://reviews.apache.org/r/57168/diff/5/?file=1656803#file1656803line4314> > > > > This reads from the stream on every invocation. Since it's called a > > REST endpoint, that means the response is based on disk I/O ... can we just > > load these once on startup like other configuration properties? This is fixed in the new patch - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168320 ------- On March 10, 2017, 3:34 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > --- > > (Updated March 10, 2017, 3:34 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr > Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > --- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > - > > ambari-server/docs/configuration/index.md af962e1 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > df334c5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 8111a39 > > > Diff: https://reviews.apache.org/r/57168/diff/7/ > > > Testing > --- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
> On March 10, 2017, 2:05 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 4356 (patched) > > <https://reviews.apache.org/r/57168/diff/6/?file=1659471#file1659471line4356> > > > > Can you initialize this on the first invocation of this method? That > > way, if the black list file isn't defined, it doesn't have to go through > > the check over and over. please refer to the new patch - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168610 ------- On March 10, 2017, 3:34 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > --- > > (Updated March 10, 2017, 3:34 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr > Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > --- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > - > > ambari-server/docs/configuration/index.md af962e1 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > df334c5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 8111a39 > > > Diff: https://reviews.apache.org/r/57168/diff/7/ > > > Testing > --- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- (Updated March 10, 2017, 3:34 p.m.) Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. Bugs: AMBARI-20243 https://issues.apache.org/jira/browse/AMBARI-20243 Repository: ambari Description --- Currently all the details from the ambari.properties file is being returned by the API call. Some of those information may not be utilized and hence an option can be provided to filter the properties A ambari-blacklist.properties file can be created, the properties that are entered in the file, will be removed from the api call that returns the ambari.properties. Diffs (updated) - ambari-server/docs/configuration/index.md af962e1 ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java df334c5 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java dadcf09 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 8111a39 Diff: https://reviews.apache.org/r/57168/diff/7/ Changes: https://reviews.apache.org/r/57168/diff/6-7/ Testing --- Added 1 test case Ran mvn test Thanks, Anita Jebaraj
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
> On March 9, 2017, 7:51 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you...can you please help in pushing the changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168506 --- On March 8, 2017, 11:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57346/ > --- > > (Updated March 8, 2017, 11:15 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20333 > https://issues.apache.org/jira/browse/AMBARI-20333 > > > Repository: ambari > > > Description > --- > > According to yarn documentation, > "yarn.scheduler.capacity..user-limit-factor" should be a float: > https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html > > Hence the user should be allowed to enter decimal values for 'User limit > factor' > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > 8eb06c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 69f5b3b > > > Diff: https://reviews.apache.org/r/57346/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/07/aaae7eff-4584-42d4-800b-68b880c68b04__screenshot-1.png > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators
> On March 9, 2017, 7:50 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you for reviewing, can you please push the changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57467/#review168505 --- On March 9, 2017, 5:24 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57467/ > --- > > (Updated March 9, 2017, 5:24 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20363 > https://issues.apache.org/jira/browse/AMBARI-20363 > > > Repository: ambari > > > Description > --- > > In the "Access Control and Status, clear the content of Users under the > "Administer Queue". It' still shows the user icon in Effective Administraters. > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js > 513031c > > > Diff: https://reviews.apache.org/r/57467/diff/1/ > > > Testing > --- > > Tested manually > > > File Attachments > > > Before Fix > > https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png > After fix > > https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57467/ --- (Updated March 9, 2017, 5:24 p.m.) Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran. Bugs: AMBARI-20363 https://issues.apache.org/jira/browse/AMBARI-20363 Repository: ambari Description --- In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c Diff: https://reviews.apache.org/r/57467/diff/1/ Testing --- Tested manually File Attachments (updated) Before Fix https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png After fix https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG Thanks, Anita Jebaraj
Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57467/ --- Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran. Bugs: AMBARI-20363 https://issues.apache.org/jira/browse/AMBARI-20363 Repository: ambari Description --- In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c Diff: https://reviews.apache.org/r/57467/diff/1/ Testing --- Tested manually Thanks, Anita Jebaraj
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- (Updated March 8, 2017, 11:30 p.m.) Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. Bugs: AMBARI-20243 https://issues.apache.org/jira/browse/AMBARI-20243 Repository: ambari Description --- Currently all the details from the ambari.properties file is being returned by the API call. Some of those information may not be utilized and hence an option can be provided to filter the properties A ambari-blacklist.properties file can be created, the properties that are entered in the file, will be removed from the api call that returns the ambari.properties. Diffs (updated) - ambari-server/docs/configuration/index.md af962e1 ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java df334c5 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java dadcf09 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 51114f8 Diff: https://reviews.apache.org/r/57168/diff/6/ Changes: https://reviews.apache.org/r/57168/diff/5-6/ Testing --- Added 1 test case Ran mvn test Thanks, Anita Jebaraj
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/ --- (Updated March 7, 2017, 1:02 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran. Bugs: AMBARI-20333 https://issues.apache.org/jira/browse/AMBARI-20333 Repository: ambari Description --- According to yarn documentation, "yarn.scheduler.capacity..user-limit-factor" should be a float: https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html Hence the user should be allowed to enter decimal values for 'User limit factor' Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8eb06c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 69f5b3b Diff: https://reviews.apache.org/r/57346/diff/2/ Changes: https://reviews.apache.org/r/57346/diff/1-2/ Testing --- Tested manually File Attachments screenshot-1.png https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png Thanks, Anita Jebaraj
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
> On March 6, 2017, 9:50 p.m., Di Li wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > > Lines 165 (patched) > > <https://reviews.apache.org/r/57168/diff/4/?file=1655687#file1655687line165> > > > > The for loop should not run anyway when propertiesToHideInResponse is > > empty. Please review the new patch. Thank you - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168045 ------- On March 6, 2017, 10:45 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > --- > > (Updated March 6, 2017, 10:45 p.m.) > > > Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > --- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 0991814 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/5/ > > > Testing > --- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- (Updated March 6, 2017, 10:45 p.m.) Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. Bugs: AMBARI-20243 https://issues.apache.org/jira/browse/AMBARI-20243 Repository: ambari Description --- Currently all the details from the ambari.properties file is being returned by the API call. Some of those information may not be utilized and hence an option can be provided to filter the properties A ambari-blacklist.properties file can be created, the properties that are entered in the file, will be removed from the api call that returns the ambari.properties. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 0991814 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java dadcf09 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 51114f8 Diff: https://reviews.apache.org/r/57168/diff/5/ Changes: https://reviews.apache.org/r/57168/diff/4-5/ Testing --- Added 1 test case Ran mvn test Thanks, Anita Jebaraj
Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran. Bugs: AMBARI-20333 https://issues.apache.org/jira/browse/AMBARI-20333 Repository: ambari Description --- According to yarn documentation, "yarn.scheduler.capacity..user-limit-factor" should be a float: https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html Hence the user should be allowed to enter decimal values for 'User limit factor' Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8eb06c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 69f5b3b Diff: https://reviews.apache.org/r/57346/diff/1/ Testing --- Tested manually File Attachments screenshot-1.png https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png Thanks, Anita Jebaraj
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4324 (patched)
> > <https://reviews.apache.org/r/57168/diff/3/?file=1653055#file1653055line4324>
> >
> > Why did you need to restore the keys ? stringPropertyNames already
> > returns a Set object that you may use directly.
Yes...I can use set directly, I have updated the patch
> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4327 (patched)
> > <https://reviews.apache.org/r/57168/diff/3/?file=1653055#file1653055line4327>
> >
> > close instream in finally{}
Fixed in new patch
> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4329 (patched)
> > <https://reviews.apache.org/r/57168/diff/3/?file=1653055#file1653055line4329>
> >
> > How did Ambari server react to an i/o exception on the blacklist file?
> > Please make sure Ambari server start restarts successfully even when the
> > blacklist file causes an i/o exception as I don't think it's a sev1 err
> > like some others in this class, i.e. can't read db pwd, can't read ssl cert
> > pwd.
Throwing the exception would cause server error, so I have changed it to print
a message in the log
> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
> > Lines 168 (patched)
> > <https://reviews.apache.org/r/57168/diff/3/?file=1653056#file1653056line168>
> >
> > The second "tab" seemed to be a real tab than 2 white spaces. please
> > make sure all tabs are replaced by spaces. You can set that in Eclipse as a
> > general setting.
Fixed in new patch
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review167838
---
On March 3, 2017, 8:47 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
>
> (Updated March 3, 2017, 8:47 p.m.)
>
>
> Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran,
> and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Currently all the details from the ambari.properties file is being returned
> by the API call.
>
> Some of those information may not be utilized and hence an option can be
> provided to filter the properties
>
> A ambari-blacklist.properties file can be created, the properties that are
> entered in the file, will be removed from the api call that returns the
> ambari.properties.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> eaecf35
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
> dadcf09
>
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
> 51114f8
>
>
> Diff: https://reviews.apache.org/r/57168/diff/4/
>
>
> Testing
> ---
>
> Added 1 test case
> Ran mvn test
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- (Updated March 3, 2017, 8:47 p.m.) Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. Bugs: AMBARI-20243 https://issues.apache.org/jira/browse/AMBARI-20243 Repository: ambari Description --- Currently all the details from the ambari.properties file is being returned by the API call. Some of those information may not be utilized and hence an option can be provided to filter the properties A ambari-blacklist.properties file can be created, the properties that are entered in the file, will be removed from the api call that returns the ambari.properties. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java eaecf35 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java dadcf09 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 51114f8 Diff: https://reviews.apache.org/r/57168/diff/4/ Changes: https://reviews.apache.org/r/57168/diff/3-4/ Testing --- Added 1 test case Ran mvn test Thanks, Anita Jebaraj
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
> On March 1, 2017, 4:28 p.m., Di Li wrote: > > ambari-server/conf/unix/ambari-blacklist.properties > > Lines 1 (patched) > > <https://reviews.apache.org/r/57168/diff/2/?file=1652014#file1652014line1> > > > > I am not sure Ambari should ship with empty files. > > > > I would suggest you to add an optional property to ambari.property that > > points to the blacklist properties file. > > > > Let's say we call it property.mask.file, its value should be the > > absolute path of a properties file. > > > > Logic can be: > > If "property.mask.file" does not exist in ambari.properties - no action > > If "property.mask.file" does not point to an existing property file - > > print some log but no further action > > Else - mask > > > > Write a wiki on Apache Ambari wiki on how to use this optional property. I have updated the patch as per your suggestions..Please review the new changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review167286 --- On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > --- > > (Updated March 2, 2017, 1:05 a.m.) > > > Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > --- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > eaecf35 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/3/ > > > Testing > --- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
> On March 1, 2017, 6:57 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > > Lines 164 (patched) > > <https://reviews.apache.org/r/57168/diff/2/?file=1652019#file1652019line164> > > > > Is this because of some sort of security concern? > > Why hide properties from the API? > > > > If you do want to hide props, perhaps it's best added as a new > > [blacklisted] section to the current file so that both files can be kept > > in-sync. Hi Alejandro, hiding the properties from the API would help the users to remove the properties which has information such as database name, database user name etc, that are not used in the ambari-web, but exposed in the API. I would like to follow the approach suggested by Di to create a property in ambari.properties which would point to the file containing the list that needs to blacklisted. Eventually if there are many properties that are blacklisted, adding a section [blacklisted] would cause the ambari.properties file to grow and make it difficult to maintain. Once the jira is accepted I can write a wiki about how to use this feature. - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review167543 ------- On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > --- > > (Updated March 2, 2017, 1:05 a.m.) > > > Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > --- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > eaecf35 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/3/ > > > Testing > --- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- (Updated March 2, 2017, 1:05 a.m.) Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. Bugs: AMBARI-20243 https://issues.apache.org/jira/browse/AMBARI-20243 Repository: ambari Description --- Currently all the details from the ambari.properties file is being returned by the API call. Some of those information may not be utilized and hence an option can be provided to filter the properties A ambari-blacklist.properties file can be created, the properties that are entered in the file, will be removed from the api call that returns the ambari.properties. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java eaecf35 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java dadcf09 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 51114f8 Diff: https://reviews.apache.org/r/57168/diff/3/ Changes: https://reviews.apache.org/r/57168/diff/2-3/ Testing --- Added 1 test case Ran mvn test Thanks, Anita Jebaraj
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- (Updated Feb. 28, 2017, 8:59 p.m.) Review request for Ambari, Di Li, Oleksandr Diachenko, and Sangeeta Ravindran. Bugs: AMBARI-20243 https://issues.apache.org/jira/browse/AMBARI-20243 Repository: ambari Description --- Currently all the details from the ambari.properties file is being returned by the API call. Some of those information may not be utilized and hence an option can be provided to filter the properties A ambari-blacklist.properties file can be created, the properties that are entered in the file, will be removed from the api call that returns the ambari.properties. Diffs (updated) - ambari-server/conf/unix/ambari-blacklist.properties PRE-CREATION ambari-server/conf/windows/ambari-blacklist.properties PRE-CREATION ambari-server/src/main/assemblies/server-windows.xml ce1e270 ambari-server/src/main/assemblies/server.xml cc9ad0f ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java eaecf35 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java dadcf09 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 51114f8 Diff: https://reviews.apache.org/r/57168/diff/ Testing --- Added 1 test case Ran mvn test Thanks, Anita Jebaraj
Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- Review request for Ambari, Di Li, Oleksandr Diachenko, and Sangeeta Ravindran. Bugs: AMBARI-20243 https://issues.apache.org/jira/browse/AMBARI-20243 Repository: ambari Description --- Currently all the details from the ambari.properties file is being returned by the API call. Some of those information may not be utilized and hence an option can be provided to filter the properties A ambari-blacklist.properties file can be created, the properties that are entered in the file, will be removed from the api call that returns the ambari.properties. Diffs - ambari-server/src/main/assemblies/server-windows.xml ce1e270 ambari-server/src/main/assemblies/server.xml cc9ad0f ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java eaecf35 ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java dadcf09 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 51114f8 Diff: https://reviews.apache.org/r/57168/diff/ Testing --- Added 1 test case Ran mvn test Thanks, Anita Jebaraj
Review Request 53788: HTTP responses needs to have the character encoding specified in the content type header
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53788/ --- Review request for Ambari, Di Li, Robert Levas, and Sangeeta Ravindran. Bugs: AMBARI-18871 https://issues.apache.org/jira/browse/AMBARI-18871 Repository: ambari Description --- The charset information(UTF-8) can be added to all the response headers to harden the security for the client. When the charset information is not specified the web browser may choose a different encoding by guessing which encoding is actually being used by the web page. This specific issue is mentioned in the section 3.1.1.5 of RFC7231 Diffs - ambari-server/conf/unix/ambari.properties 371653f ambari-server/conf/windows/ambari.properties e47319e ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 15f186b ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java 423a013 ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java aa00ac2 ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java d1be8cc ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java d812ee6 Diff: https://reviews.apache.org/r/53788/diff/ Testing --- Ran mvn test. The test cases failing in hadoop QA is not related to the patch for this jira Thanks, Anita Jebaraj
Re: Review Request 53273: Not able to change the default port ambari server listens to
> On Nov. 8, 2016, 4:40 p.m., Di Li wrote: > > Hello Anita, > > > > I pushed the change to trunk as > > https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=352fe85181d81cf23f82953f05bc66a7c88d639b > > > > Please provide a patch rebased for branch-2.5, AMBARI-18741-Nov7.patch does > > not apply to branch-2.5 > > Anita Jebaraj wrote: > Hi Di, these changes are not included in branch-2.5, this issue was > existing only in trunk. Thank you for pushing the changes - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review155299 ------- On Nov. 7, 2016, 6:11 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > --- > > (Updated Nov. 7, 2016, 6:11 p.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > --- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc > ambari-server/src/main/python/ambari_server/utils.py 757c333 > ambari-server/src/test/python/TestUtils.py 367b7fe > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > --- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53273: Not able to change the default port ambari server listens to
> On Nov. 8, 2016, 4:40 p.m., Di Li wrote: > > Hello Anita, > > > > I pushed the change to trunk as > > https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=352fe85181d81cf23f82953f05bc66a7c88d639b > > > > Please provide a patch rebased for branch-2.5, AMBARI-18741-Nov7.patch does > > not apply to branch-2.5 Hi Di, these changes are not included in branch-2.5, this issue was existing only in trunk. - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review155299 ------- On Nov. 7, 2016, 6:11 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > --- > > (Updated Nov. 7, 2016, 6:11 p.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > --- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc > ambari-server/src/main/python/ambari_server/utils.py 757c333 > ambari-server/src/test/python/TestUtils.py 367b7fe > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > --- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53273: Not able to change the default port ambari server listens to
> On Nov. 7, 2016, 5:29 p.m., Di Li wrote: > > hello Anita, AMBARI-18741-Nov2.patch does not apply to trunk, can you > > please rebase and provide a new patch ? Hi Di, I have rebased the patch - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review155164 --- On Nov. 7, 2016, 6:11 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > --- > > (Updated Nov. 7, 2016, 6:11 p.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > --- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc > ambari-server/src/main/python/ambari_server/utils.py 757c333 > ambari-server/src/test/python/TestUtils.py 367b7fe > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > --- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53273: Not able to change the default port ambari server listens to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- (Updated Nov. 7, 2016, 6:11 p.m.) Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. Bugs: AMBARI-18741 https://issues.apache.org/jira/browse/AMBARI-18741 Repository: ambari Description --- After including client.api.port in ambari.properties, ambari-server still tries to connect to port 8080 The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is defined in ambari.properties then the value should be taken as the port number. https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html Diffs (updated) - ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc ambari-server/src/main/python/ambari_server/utils.py 757c333 ambari-server/src/test/python/TestUtils.py 367b7fe Diff: https://reviews.apache.org/r/53273/diff/ Testing --- Performed manual testing. Thanks, Anita Jebaraj
Re: Review Request 53273: Not able to change the default port ambari server listens to
> On Nov. 2, 2016, 9:18 a.m., Attila Doroszlai wrote: > > ambari-server/src/test/python/TestUtils.py, line 130 > > <https://reviews.apache.org/r/53273/diff/3/?file=1550521#file1550521line130> > > > > I think get_properties_mock was added to avoid this error: > > > > ``` > > Failed tests: > > ERROR: test_wait_for_pid (TestUtils.TestUtils) > > -- > > Traceback (most recent call last): > > File "ambari-common/src/test/python/mock/mock.py", line 1199, in > > patched > > return func(*args, **keywargs) > > File "ambari-server/src/test/python/TestUtils.py", line 129, in > > test_wait_for_pid > > from ambari_server.serverConfiguration import SSL_API, > > CLIENT_API_PORT_PROPERTY > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 571, in > > configDefaults = ServerConfigDefaults() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 488, in __init__ > > super(ServerConfigDefaultsLinux, self).__init__() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 343, in __init__ > > properties = get_ambari_properties() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 229, in get_ambari_properties > > conf_file = find_properties_file() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 222, in find_properties_file > > raise FatalException(1, err) > > FatalException: 'Fatal exception: File ambari.properties not found in > > search path $AMBARI_CONF_DIR: /etc/ambari-server/conf, exit code 1' > > ``` The test case test_wait_for_pid has passed in Hadoop QA and I also tried running it using python unitTests.py and it passed - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154525 --- On Nov. 2, 2016, 6:31 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > --- > > (Updated Nov. 2, 2016, 6:31 p.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > --- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc > ambari-server/src/main/python/ambari_server/utils.py 348d5df > ambari-server/src/test/python/TestUtils.py 5d32125 > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > --- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53273: Not able to change the default port ambari server listens to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- (Updated Nov. 2, 2016, 6:31 p.m.) Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. Bugs: AMBARI-18741 https://issues.apache.org/jira/browse/AMBARI-18741 Repository: ambari Description --- After including client.api.port in ambari.properties, ambari-server still tries to connect to port 8080 The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is defined in ambari.properties then the value should be taken as the port number. https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html Diffs (updated) - ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc ambari-server/src/main/python/ambari_server/utils.py 348d5df ambari-server/src/test/python/TestUtils.py 5d32125 Diff: https://reviews.apache.org/r/53273/diff/ Testing --- Performed manual testing. Thanks, Anita Jebaraj
Re: Review Request 53273: Not able to change the default port ambari server listens to
> On Oct. 29, 2016, 5:04 p.m., Attila Doroszlai wrote: > > Nice catch. > > > > Would be nice to use the constants defined in `serverConfiguration` for > > default port and property names. > > > > Even nicer: extract the logic for getting the port (including check for > > SSL) into a function in `serverConfiguration`. Similar logic is > > implemented in `serverUtils.get_ambari_server_api_base()`. hi Attilathank you..I have updated the patch based on your comments...can you please help in pushing the code? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154216 ----------- On Nov. 1, 2016, 5:39 a.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > --- > > (Updated Nov. 1, 2016, 5:39 a.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > --- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc > ambari-server/src/main/python/ambari_server/utils.py 5886561 > ambari-server/src/test/python/TestUtils.py 5d32125 > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > --- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53273: Not able to change the default port ambari server listens to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- (Updated Nov. 1, 2016, 5:39 a.m.) Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. Changes --- Updated the test cases Bugs: AMBARI-18741 https://issues.apache.org/jira/browse/AMBARI-18741 Repository: ambari Description --- After including client.api.port in ambari.properties, ambari-server still tries to connect to port 8080 The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is defined in ambari.properties then the value should be taken as the port number. https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html Diffs (updated) - ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc ambari-server/src/main/python/ambari_server/utils.py 5886561 ambari-server/src/test/python/TestUtils.py 5d32125 Diff: https://reviews.apache.org/r/53273/diff/ Testing --- Performed manual testing. Thanks, Anita Jebaraj
Re: Review Request 53273: Not able to change the default port ambari server listens to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- (Updated Oct. 31, 2016, 8:52 p.m.) Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. Bugs: AMBARI-18741 https://issues.apache.org/jira/browse/AMBARI-18741 Repository: ambari Description --- After including client.api.port in ambari.properties, ambari-server still tries to connect to port 8080 The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is defined in ambari.properties then the value should be taken as the port number. https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html Diffs (updated) - ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc ambari-server/src/main/python/ambari_server/utils.py 5886561 Diff: https://reviews.apache.org/r/53273/diff/ Testing --- Performed manual testing. Thanks, Anita Jebaraj
Re: Review Request 53273: Not able to change the default port ambari server listens to
> On Oct. 31, 2016, 3:10 p.m., Di Li wrote: > > ambari-server/src/main/python/ambari_server/utils.py, line 150 > > <https://reviews.apache.org/r/53273/diff/1/?file=1548411#file1548411line150> > > > > Use constants and corresponding defaults instead of text > > client.api.port, api.ssl, client.api.ssl.port. > > > > i.e > > from ambari_server.serverConfiguration import CLIENT_API_PORT, > > CLIENT_API_PORT_PROPERTY, SSL_API, DEFAULT_SSL_API_PORT, SSL_API_PORT Updated the patch based on your comments and Attila's, I created a function in serverConfiguration and imported it in utils.py. I have imported it within the function wait_for_pid due to circular dependency. - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154267 ------- On Oct. 28, 2016, 9:46 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > --- > > (Updated Oct. 28, 2016, 9:46 p.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > --- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > - > > ambari-server/src/main/python/ambari_server/utils.py 5886561 > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > --- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
Review Request 53273: Not able to change the default port ambari server listens to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. Bugs: AMBARI-18741 https://issues.apache.org/jira/browse/AMBARI-18741 Repository: ambari Description --- After including client.api.port in ambari.properties, ambari-server still tries to connect to port 8080 The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is defined in ambari.properties then the value should be taken as the port number. https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html Diffs - ambari-server/src/main/python/ambari_server/utils.py 5886561 Diff: https://reviews.apache.org/r/53273/diff/ Testing --- Performed manual testing. Thanks, Anita Jebaraj
Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.
> On Oct. 27, 2016, 6:49 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Dipayan, Can you please help in pushing the code. This is an isolated > change and hence wont impact the changes from Ambari-18691 > > DIPAYAN BHOWMICK wrote: > Done, have committed to trunk, branch-2.4 and branch-2.5. Thank you - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/#review154063 --- On Oct. 27, 2016, 6:39 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53126/ > --- > > (Updated Oct. 27, 2016, 6:39 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18665 > https://issues.apache.org/jira/browse/AMBARI-18665 > > > Repository: ambari > > > Description > --- > > Workflow designer view doesn't execute on clicking the go to instance button > after creating the view. > Navigating to the Ambari dashboard and executing the view using the drop down > menu works and loads the workflow designer view > > > The issue is caused due to the space in the URI, it works in chrome and > firefox version 38.8, but does't work in the latest version of firefox > (49.0). The App.router.route handles it properly and so the menu redirect > works as expected, but the issue arises when the URI contains space in href. > > As per the standard practices, using spaces in URI is considered as unsafe, > hence the view name can be changed from Workflow Manager to WORKFLOW_MANAGER, > which will also be consistent with the other view names. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/view.xml ec3d5f5 > > Diff: https://reviews.apache.org/r/53126/diff/ > > > Testing > --- > > Ran mvn test > > Performed manual testing. > > tested after applying the patch from jira AMBARI-18691, the issue still > exists and the patch is relevant. > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.
> On Oct. 27, 2016, 6:49 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Hi Dipayan, Can you please help in pushing the code. This is an isolated change and hence wont impact the changes from Ambari-18691 - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/#review154063 --- On Oct. 27, 2016, 6:39 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53126/ > --- > > (Updated Oct. 27, 2016, 6:39 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18665 > https://issues.apache.org/jira/browse/AMBARI-18665 > > > Repository: ambari > > > Description > --- > > Workflow designer view doesn't execute on clicking the go to instance button > after creating the view. > Navigating to the Ambari dashboard and executing the view using the drop down > menu works and loads the workflow designer view > > > The issue is caused due to the space in the URI, it works in chrome and > firefox version 38.8, but does't work in the latest version of firefox > (49.0). The App.router.route handles it properly and so the menu redirect > works as expected, but the issue arises when the URI contains space in href. > > As per the standard practices, using spaces in URI is considered as unsafe, > hence the view name can be changed from Workflow Manager to WORKFLOW_MANAGER, > which will also be consistent with the other view names. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/view.xml ec3d5f5 > > Diff: https://reviews.apache.org/r/53126/diff/ > > > Testing > --- > > Ran mvn test > > Performed manual testing. > > tested after applying the patch from jira AMBARI-18691, the issue still > exists and the patch is relevant. > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/ --- (Updated Oct. 27, 2016, 6:39 p.m.) Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18665 https://issues.apache.org/jira/browse/AMBARI-18665 Repository: ambari Description --- Workflow designer view doesn't execute on clicking the go to instance button after creating the view. Navigating to the Ambari dashboard and executing the view using the drop down menu works and loads the workflow designer view The issue is caused due to the space in the URI, it works in chrome and firefox version 38.8, but does't work in the latest version of firefox (49.0). The App.router.route handles it properly and so the menu redirect works as expected, but the issue arises when the URI contains space in href. As per the standard practices, using spaces in URI is considered as unsafe, hence the view name can be changed from Workflow Manager to WORKFLOW_MANAGER, which will also be consistent with the other view names. Diffs - contrib/views/wfmanager/src/main/resources/view.xml ec3d5f5 Diff: https://reviews.apache.org/r/53126/diff/ Testing (updated) --- Ran mvn test Performed manual testing. tested after applying the patch from jira AMBARI-18691, the issue still exists and the patch is relevant. Thanks, Anita Jebaraj
Re: Review Request 53140: Include an option to upload query in hive-view
> On Oct. 24, 2016, 6:57 p.m., Alexandr Antonenko wrote: > > Ship It! > > Anita Jebaraj wrote: > Thank you...Can you please help in pushing the code? > > Alexandr Antonenko wrote: > done Thank you - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53140/#review153724 --- On Oct. 24, 2016, 4:58 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53140/ > --- > > (Updated Oct. 24, 2016, 4:58 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18638 > https://issues.apache.org/jira/browse/AMBARI-18638 > > > Repository: ambari > > > Description > --- > > An option to upload the hive query directly into the worksheet from the UI > can be included. > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/upload-query.js > PRE-CREATION > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js > e67aaed > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > cc789e8 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/index.hbs > a06c330 > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/upload-query.js > PRE-CREATION > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js > 7d5f4ae > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > aca366f > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs > a06c330 > > Diff: https://reviews.apache.org/r/53140/diff/ > > > Testing > --- > > Ran mvn test > > > File Attachments > > > screenshot1.jpg > > https://reviews.apache.org/media/uploaded/files/2016/10/24/371b95c5-f60e-4250-84d5-25987617fa3d__screenshot1.jpg > screenshot2.jpg > > https://reviews.apache.org/media/uploaded/files/2016/10/24/9cc85ddf-8554-4db1-a132-f1380017c7d3__screenshot2.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53140: Include an option to upload query in hive-view
> On Oct. 24, 2016, 6:57 p.m., Alexandr Antonenko wrote: > > Ship It! Thank you...Can you please help in pushing the code? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53140/#review153724 --- On Oct. 24, 2016, 4:58 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53140/ > --- > > (Updated Oct. 24, 2016, 4:58 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18638 > https://issues.apache.org/jira/browse/AMBARI-18638 > > > Repository: ambari > > > Description > --- > > An option to upload the hive query directly into the worksheet from the UI > can be included. > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/upload-query.js > PRE-CREATION > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js > e67aaed > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > cc789e8 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/index.hbs > a06c330 > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/upload-query.js > PRE-CREATION > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js > 7d5f4ae > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > aca366f > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs > a06c330 > > Diff: https://reviews.apache.org/r/53140/diff/ > > > Testing > --- > > Ran mvn test > > > File Attachments > > > screenshot1.jpg > > https://reviews.apache.org/media/uploaded/files/2016/10/24/371b95c5-f60e-4250-84d5-25987617fa3d__screenshot1.jpg > screenshot2.jpg > > https://reviews.apache.org/media/uploaded/files/2016/10/24/9cc85ddf-8554-4db1-a132-f1380017c7d3__screenshot2.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 53140: Include an option to upload query in hive-view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53140/ --- (Updated Oct. 24, 2016, 4:58 p.m.) Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-18638 https://issues.apache.org/jira/browse/AMBARI-18638 Repository: ambari Description --- An option to upload the hive query directly into the worksheet from the UI can be included. Diffs - contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/upload-query.js PRE-CREATION contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js e67aaed contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js cc789e8 contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/index.hbs a06c330 contrib/views/hive/src/main/resources/ui/hive-web/app/components/upload-query.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 7d5f4ae contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js aca366f contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs a06c330 Diff: https://reviews.apache.org/r/53140/diff/ Testing --- Ran mvn test File Attachments (updated) screenshot1.jpg https://reviews.apache.org/media/uploaded/files/2016/10/24/371b95c5-f60e-4250-84d5-25987617fa3d__screenshot1.jpg screenshot2.jpg https://reviews.apache.org/media/uploaded/files/2016/10/24/9cc85ddf-8554-4db1-a132-f1380017c7d3__screenshot2.jpg Thanks, Anita Jebaraj
Review Request 53140: Include an option to upload query in hive-view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53140/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-18638 https://issues.apache.org/jira/browse/AMBARI-18638 Repository: ambari Description --- An option to upload the hive query directly into the worksheet from the UI can be included. Diffs - contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/upload-query.js PRE-CREATION contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js e67aaed contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js cc789e8 contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/index.hbs a06c330 contrib/views/hive/src/main/resources/ui/hive-web/app/components/upload-query.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 7d5f4ae contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js aca366f contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs a06c330 Diff: https://reviews.apache.org/r/53140/diff/ Testing --- Ran mvn test Thanks, Anita Jebaraj
Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/ --- (Updated Oct. 24, 2016, 1:33 a.m.) Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18665 https://issues.apache.org/jira/browse/AMBARI-18665 Repository: ambari Description (updated) --- Workflow designer view doesn't execute on clicking the go to instance button after creating the view. Navigating to the Ambari dashboard and executing the view using the drop down menu works and loads the workflow designer view The issue is caused due to the space in the URI, it works in chrome and firefox version 38.8, but does't work in the latest version of firefox (49.0). The App.router.route handles it properly and so the menu redirect works as expected, but the issue arises when the URI contains space in href. As per the standard practices, using spaces in URI is considered as unsafe, hence the view name can be changed from Workflow Manager to WORKFLOW_MANAGER, which will also be consistent with the other view names. Diffs - contrib/views/wfmanager/src/main/resources/view.xml ec3d5f5 Diff: https://reviews.apache.org/r/53126/diff/ Testing --- Ran mvn test Thanks, Anita Jebaraj
Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/ --- Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18665 https://issues.apache.org/jira/browse/AMBARI-18665 Repository: ambari Description --- Workflow designer view doesn't execute on clicking the go to instance button after creating the view. Navigating to the Ambari dashboard and executing the view using the drop down menu works and loads the workflow designer view The issue is caused due to the space in the URI, it works in chrome and firefox version 38.8, but does't work in the latest version of firefox (49.0). The App.router.route handles it properly and so the menu redirect works as expected, but the issue arises when the URI contains space in href. As per the standard practices, using spaces in URI is considered as unsafe, hence the view name can be changed from Workflow designer to WORKFLOW_DESIGNER, which will also be consistent with the other view names. Diffs - contrib/views/wfmanager/src/main/resources/view.xml ec3d5f5 Diff: https://reviews.apache.org/r/53126/diff/ Testing --- Ran mvn test Thanks, Anita Jebaraj
Re: Review Request 52430: Include an option to download the saved query in hive view
> On Oct. 7, 2016, 4:41 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Hi Dipayan...thank you for reviewing the code.Can you please help in pushing the code? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151812 --- On Oct. 7, 2016, 4:33 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52430/ > --- > > (Updated Oct. 7, 2016, 4:33 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, and > Tim Thorpe. > > > Bugs: AMBARI-18496 > https://issues.apache.org/jira/browse/AMBARI-18496 > > > Repository: ambari > > > Description > --- > > An option to download the saved query can be included. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java > ccc4512 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js > cbf6b42 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > f7f7706 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java > 9ea19c6 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js > cbf6b42 > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > f7f7706 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java > d55858f > > Diff: https://reviews.apache.org/r/52430/diff/ > > > Testing > --- > > Ran mvn test > > Added 1 new test case > > > File Attachments > > > screenshot2.jpg > > https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg > screenshot1.jpg > > https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 52430: Include an option to download the saved query in hive view
> On Oct. 4, 2016, 7:18 p.m., Alexandr Antonenko wrote: > > UI changes are looking good, but you need also aprove from java developer Thank you Alex - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151374 --- On Oct. 3, 2016, 11:25 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52430/ > --- > > (Updated Oct. 3, 2016, 11:25 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18496 > https://issues.apache.org/jira/browse/AMBARI-18496 > > > Repository: ambari > > > Description > --- > > An option to download the saved query can be included. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java > ccc4512 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js > cbf6b42 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > f7f7706 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java > 9ea19c6 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js > cbf6b42 > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > f7f7706 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java > d55858f > > Diff: https://reviews.apache.org/r/52430/diff/ > > > Testing > --- > > Ran mvn test > > Added 1 new test case > > > File Attachments > > > screenshot2.jpg > > https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg > screenshot1.jpg > > https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 52430: Include an option to download the saved query in hive view
> On Oct. 3, 2016, 7:41 p.m., Di Li wrote:
> > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java,
> > line 86
> > <https://reviews.apache.org/r/52430/diff/2/?file=1518869#file1518869line86>
> >
> > what's the point of passing the fileName only for the backend to add it
> > to the header ? Can UI handle naming the file ?
> >
> > HTTP URL is to identify a resource ({queryId}), HTTP request types are
> > for basic action type ( read - GET, create - PUT, update - POST, and delete
> > - DELETE). predicates are for detailing an action when the basic HTTP
> > request types aren't enough.
> >
> > so I am not clear on passing the file name here, as it's not really a
> > resource (since that's identified by the queryId), and it's just so that
> > web browser can name the file, right ? so I wonder if UI can do it without
> > overheading it to the server backend.
Hi Di, yes its a valuable suggestion, I have updated the patch by removing the
fileName from query param and handling it in the UI
> On Oct. 3, 2016, 7:41 p.m., Di Li wrote:
> > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java,
> > line 87
> > <https://reviews.apache.org/r/52430/diff/2/?file=1518869#file1518869line87>
> >
> > You may want to consider using operation=name format so that you don't
> > need to add more query params each time you need to support a new
> > operation. Think about download=true vs op=download, where op can be later
> > extended to new operations, but download=true is set in stone and you will
> > have no othe options but to introduce more URL query parameters for new
> > operations.
Thank you for the suggestion, I have updated accordingly.
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/#review151220
---
On Oct. 3, 2016, 11:25 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52430/
> ---
>
> (Updated Oct. 3, 2016, 11:25 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-18496
> https://issues.apache.org/jira/browse/AMBARI-18496
>
>
> Repository: ambari
>
>
> Description
> ---
>
> An option to download the saved query can be included.
>
>
> Diffs
> -
>
>
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
> ccc4512
>
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
> cbf6b42
>
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
> f7f7706
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
> 9ea19c6
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js
> cbf6b42
> contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js
> f7f7706
>
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
> d55858f
>
> Diff: https://reviews.apache.org/r/52430/diff/
>
>
> Testing
> ---
>
> Ran mvn test
>
> Added 1 new test case
>
>
> File Attachments
>
>
> screenshot2.jpg
>
> https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
> screenshot1.jpg
>
> https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 52430: Include an option to download the saved query in hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/ --- (Updated Oct. 3, 2016, 11:25 p.m.) Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-18496 https://issues.apache.org/jira/browse/AMBARI-18496 Repository: ambari Description --- An option to download the saved query can be included. Diffs (updated) - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java ccc4512 contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js cbf6b42 contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js f7f7706 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java 9ea19c6 contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js cbf6b42 contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js f7f7706 contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java d55858f Diff: https://reviews.apache.org/r/52430/diff/ Testing --- Ran mvn test Added 1 new test case File Attachments screenshot2.jpg https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg screenshot1.jpg https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg Thanks, Anita Jebaraj
Re: Review Request 52430: Include an option to download the saved query in hive view
> On Sept. 30, 2016, 7:48 p.m., Di Li wrote: > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java, > > line 117 > > <https://reviews.apache.org/r/52430/diff/1/?file=1516903#file1516903line117> > > > > Does this store the entire query result in the memory ? can it be > > streamed for better performance ? I have updated the latest patch based on your comments - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151070 ------- On Oct. 3, 2016, 6:13 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52430/ > --- > > (Updated Oct. 3, 2016, 6:13 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18496 > https://issues.apache.org/jira/browse/AMBARI-18496 > > > Repository: ambari > > > Description > --- > > An option to download the saved query can be included. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java > ccc4512 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js > cbf6b42 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > f7f7706 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java > 9ea19c6 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js > cbf6b42 > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > f7f7706 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java > d55858f > > Diff: https://reviews.apache.org/r/52430/diff/ > > > Testing > --- > > Ran mvn test > > Added 1 new test case > > > File Attachments > > > screenshot2.jpg > > https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg > screenshot1.jpg > > https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 52430: Include an option to download the saved query in hive view
> On Sept. 30, 2016, 7:45 p.m., Di Li wrote:
> > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java,
> > line 103
> > <https://reviews.apache.org/r/52430/diff/1/?file=1516903#file1516903line103>
> >
> > REST API URLs mostly use nouns (names) instead of verbs (actions). your
> > current URL design ends on an action.
> >
> > I am also not sure I see the point of having a new @GET annotated
> > method just for the download action (due to introducting the new URL, I
> > guess?).
> >
> > Can this be handled in the original @GET method ? You can pass in
> > pradicates like ?op=download.
> >
> > If you look at the blueprint export rest api, it's still the @GET
> > against /clusters, the only diff is the ?format=json parameter. so I also
> > wonder - Can {queryId} support such parameter like if it's ?format=txt,
> > then it means to download ?
I have added download as a query param in the existing @GET, so the download
operation will happen when ?download=true, the fileName is also added as query
param along with download
- Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/#review151067
---
On Oct. 3, 2016, 6:13 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52430/
> ---
>
> (Updated Oct. 3, 2016, 6:13 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-18496
> https://issues.apache.org/jira/browse/AMBARI-18496
>
>
> Repository: ambari
>
>
> Description
> ---
>
> An option to download the saved query can be included.
>
>
> Diffs
> -
>
>
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
> ccc4512
>
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
> cbf6b42
>
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
> f7f7706
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
> 9ea19c6
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js
> cbf6b42
> contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js
> f7f7706
>
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
> d55858f
>
> Diff: https://reviews.apache.org/r/52430/diff/
>
>
> Testing
> ---
>
> Ran mvn test
>
> Added 1 new test case
>
>
> File Attachments
> ----
>
> screenshot2.jpg
>
> https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
> screenshot1.jpg
>
> https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 52430: Include an option to download the saved query in hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/ --- (Updated Oct. 3, 2016, 6:13 p.m.) Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-18496 https://issues.apache.org/jira/browse/AMBARI-18496 Repository: ambari Description --- An option to download the saved query can be included. Diffs (updated) - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java ccc4512 contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js cbf6b42 contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js f7f7706 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java 9ea19c6 contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js cbf6b42 contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js f7f7706 contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java d55858f Diff: https://reviews.apache.org/r/52430/diff/ Testing --- Ran mvn test Added 1 new test case File Attachments screenshot2.jpg https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg screenshot1.jpg https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg Thanks, Anita Jebaraj
