Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-10 Thread Maxim Khutornenko
/ Testing --- ./pants test.pytest src/test/python/apache/aurora/client:: Thanks, Maxim Khutornenko

Re: Review Request 30859: Remove thrift checksum verification script and resources.

2015-02-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30859/#review71898 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 11, 2015, 1:14

Re: Review Request 30858: Upgrade to checkstyle 6.3

2015-02-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30858/#review71918 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 11, 2015, 1:08

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-11 Thread Maxim Khutornenko
est/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java, > > lines 700-726 > > <https://reviews.apache.org/r/30225/diff/6/?file=853470#file853470line700> > > > > I think you've done the right thing, but note that this uni

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-11 Thread Maxim Khutornenko
achineTest.java 89765ac3d34a827d3748fb96a275d78e9d1b8b72 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 41d422939209d0808235128e4242c11e8ef25969 Diff: https://reviews.apache.org/r/30225/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2015-02-11 Thread Maxim Khutornenko
> On Feb. 5, 2015, 12:01 a.m., Bill Farner wrote: > > Can you see any opportunity to break this diff apart? As it stands i'm > > having a hard time giving a thoughtful review. Perhaps you can start by > > introducing the `Assignment` class? > > Maxim Khu

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-11 Thread Maxim Khutornenko
can drop the else? Sure. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review72014 --- On Feb. 11, 2

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-11 Thread Maxim Khutornenko
achineTest.java 89765ac3d34a827d3748fb96a275d78e9d1b8b72 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 41d422939209d0808235128e4242c11e8ef25969 Diff: https://reviews.apache.org/r/30225/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-11 Thread Maxim Khutornenko
52ee7c1e3742d9315c7e7aaa77677121e1e9288d Diff: https://reviews.apache.org/r/30890/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-11 Thread Maxim Khutornenko
src/jmh/java/org/apache/aurora/benchmark/Tasks.java 1a35f9ee9e8e76def0f9bf5454cf8cbdf6a89c25 Diff: https://reviews.apache.org/r/30895/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-11 Thread Maxim Khutornenko
5647349854a5e04de749c4d809684a0066d4da06 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 6cc13231560996b144101eba36577f49017aba06 Diff: https://reviews.apache.org/r/30891/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

2015-02-11 Thread Maxim Khutornenko
/TaskSchedulerTest.java 6cc13231560996b144101eba36577f49017aba06 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 411a55a8d85f60bb2703468f2d69b64b2736eee4 Diff: https://reviews.apache.org/r/30888/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

2015-02-11 Thread Maxim Khutornenko
03line102> > > > > use a constant for this Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30888/#review72026 --------

Re: Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

2015-02-11 Thread Maxim Khutornenko
/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-11 Thread Maxim Khutornenko
performance than private class cohesiveness in this case. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72030 ----------

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-11 Thread Maxim Khutornenko
ike it will overcomplicate things for no good reason here. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71840 -------

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-11 Thread Maxim Khutornenko
gt; > s/final// Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71878 --- On Feb. 10, 20

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-11 Thread Maxim Khutornenko
s/Key// Done and done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71904 --- On Feb. 10, 2015, 12

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-11 Thread Maxim Khutornenko
Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-11 Thread Maxim Khutornenko
. SUCCESS > > > > FAILURE > > > >  > >FAILURE > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" Te

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-11 Thread Maxim Khutornenko
issues.apache.org/jira/browse/AURORA-1119 - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review72060 ------- On

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-11 Thread Maxim Khutornenko
://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-11 Thread Maxim Khutornenko
r/30461/#review72068 --- On Feb. 11, 2015, 1:19 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72091 --- @ReviewBot retry - Maxim Khutornenko On Feb. 11, 2015, 1:19 a.m

Review Request 30913: Adding UPDATE_COORDINATOR role access into pause/resume/abort RPCs

2015-02-11 Thread Maxim Khutornenko
2a9d36ab2c01960dc5384fc3ed90df4e11c0b12a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ee329496adf051de717d42c60410c0469f7e90da Diff: https://reviews.apache.org/r/30913/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 30915: Increase findbugs heap size.

2015-02-11 Thread Maxim Khutornenko
sting --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-12 Thread Maxim Khutornenko
/diff/ Testing --- ./pants test.pytest src/test/python/apache/aurora/client:: Thanks, Maxim Khutornenko

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Maxim Khutornenko
from Set to Iterable in this class. The interface contract should clearly state the expectations. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72061 -

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Maxim Khutornenko
pache/aurora/scheduler/filter/SchedulingFilterImplTest.java 52ee7c1e3742d9315c7e7aaa77677121e1e9288d Diff: https://reviews.apache.org/r/30890/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 30942: Displaying blockIfNoPulseAfterMs in the UI

2015-02-12 Thread Maxim Khutornenko
/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Maxim Khutornenko
l applies and is actually a better name. > > It's odd for an enum value to be considered a 'group'. (When i hear group > > i think collection.) > > Maxim Khutornenko wrote: > VetoType is used to describe the particular type of veto applied. This &

Re: Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

2015-02-12 Thread Maxim Khutornenko
/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72274 --- @ReviewBot retry - Maxim Khutornenko On Feb. 12, 2015, 6:05 p.m

Re: Review Request 29117: Adding thrift API changes document.

2015-02-12 Thread Maxim Khutornenko
/populated_deprecation/docs/thrift-deprecation.md Thanks, Maxim Khutornenko

Re: Review Request 29117: Adding thrift API changes document.

2015-02-12 Thread Maxim Khutornenko
02a0f > docs/thrift-deprecation.md PRE-CREATION > > Diff: https://reviews.apache.org/r/29117/diff/ > > > Testing > --- > > https://github.com/maxim111333/incubator-aurora/blob/populated_deprecation/docs/thrift-deprecation.md > > > Thanks, > > Maxim Khutornenko > >

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Maxim Khutornenko
/scheduler/filter/SchedulingFilterImplTest.java 52ee7c1e3742d9315c7e7aaa77677121e1e9288d Diff: https://reviews.apache.org/r/30890/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Maxim Khutornenko
52ee7c1e3742d9315c7e7aaa77677121e1e9288d Diff: https://reviews.apache.org/r/30890/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-12 Thread Maxim Khutornenko
/scheduler/async/TaskSchedulerImplTest.java d0e11932e8b5ba1393279137c8465a308e1d6bf5 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 74e31334bc139c47eb8b0beee46ee7bad62a2f80 Diff: https://reviews.apache.org/r/30891/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Maxim Khutornenko
/reviews.apache.org/r/30890/#review72300 --- On Feb. 13, 2015, 12:58 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-12 Thread Maxim Khutornenko
/scheduler/async/TaskSchedulerImplTest.java d0e11932e8b5ba1393279137c8465a308e1d6bf5 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 74e31334bc139c47eb8b0beee46ee7bad62a2f80 Diff: https://reviews.apache.org/r/30891/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-13 Thread Maxim Khutornenko
- Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72429 --- On Feb. 13, 2015, 2:27 a.m., Maxim Khutornenko wrote: > > -

Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
uence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
https://reviews.apache.org/r/31022/#review72443 ------- On Feb. 13, 2015, 9:54 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-ma

Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Maxim Khutornenko
ce59bee302ee2323b65622635b8b51d965dd6507 Diff: https://reviews.apache.org/r/31029/diff/ Testing --- https://github.com/maxim111333/incubator-aurora/blob/pulse_docs/docs/client-commands.md#user-content-coordinated-job-updates-beta Thanks, Maxim Khutornenko

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
])]) TypeError: sequence item 0: expected string, NoneType found ``` After: ``` $ aurora beta-update status devcluster/www-data/prod/hello INFO] No updates found for job devcluster/www-data/prod/hello INFO] Command terminated with error code 6 ``` Thanks, Maxim Khutornenko

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
> On Feb. 13, 2015, 10:06 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/client/cli/test_supdate.py, line 120 > > <https://reviews.apache.org/r/31022/diff/1/?file=863675#file863675line120> > > > > Shouldn't 'test' be self.TEST_

Re: Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Maxim Khutornenko
ds.md#user-content-coordinated-job-updates-beta Thanks, Maxim Khutornenko

Re: Review Request 30710: add mesos role feature

2015-02-17 Thread Maxim Khutornenko
sources.java <https://reviews.apache.org/r/30710/#comment118870> Prefer using guava `Ordering` [1] instead. It will avoid excessive collection copies. [1] - https://code.google.com/p/guava-libraries/wiki/OrderingExplained - Maxim Khutornenko On Feb.

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

2015-02-17 Thread Maxim Khutornenko
<https://reviews.apache.org/r/31136/#comment118937> shouldn't it rather be select_update_row_id? - Maxim Khutornenko On Feb. 17, 2015, 11:06 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

2015-02-17 Thread Maxim Khutornenko
ra/scheduler/storage/db/JobUpdateDetailsMapper.java <https://reviews.apache.org/r/31136/#comment118971> s/updat/key src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java <https://reviews.apache.org/r/31136/#comment118972> s/update/key - Maxim

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-17 Thread Maxim Khutornenko
1932e8b5ba1393279137c8465a308e1d6bf5 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java > 74e31334bc139c47eb8b0beee46ee7bad62a2f80 > > Diff: https://reviews.apache.org/r/30891/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-17 Thread Maxim Khutornenko
n for a thing named Queue to make > > logic decisions about its contents. Have you considered having the > > `acceptor` own this behavior? > > Maxim Khutornenko wrote: > Well, I don't really see why it has "Queue" in its name in the first > place :) It

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-17 Thread Maxim Khutornenko
-Pq build Thanks, Maxim Khutornenko

Review Request 31144: Renaming OfferQueue into OfferManager.

2015-02-17 Thread Maxim Khutornenko
4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 652d2477e0fd69d9f9f4d46a150145ad062cf5d2 Diff: https://reviews.apache.org/r/31144/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-17 Thread Maxim Khutornenko
, Maxim Khutornenko

Review Request 31171: Saving backups asynchronously.

2015-02-18 Thread Maxim Khutornenko
8bc91d43df Diff: https://reviews.apache.org/r/31171/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-18 Thread Maxim Khutornenko
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/annotations/Beta.html - Maxim Khutornenko On Feb. 19, 2015, 12:19 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 31171: Saving backups asynchronously.

2015-02-19 Thread Maxim Khutornenko
BackupTest.java 15fc4404fa2ace4391e4ddc7153c848bc91d43df Diff: https://reviews.apache.org/r/31171/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31171: Saving backups asynchronously.

2015-02-19 Thread Maxim Khutornenko
st to preserve that behavior. Good point. Moved as such. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73064 --------

Review Request 31235: Refactoring CronJobManager interface.

2015-02-20 Thread Maxim Khutornenko
t_end_to_end.sh Thanks, Maxim Khutornenko

Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Maxim Khutornenko
: https://reviews.apache.org/r/31241/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31171: Saving backups asynchronously.

2015-02-20 Thread Maxim Khutornenko
need to assign to a new FakeClock > > above? Good catch. Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73291 -------

Re: Review Request 31171: Saving backups asynchronously.

2015-02-20 Thread Maxim Khutornenko
build Thanks, Maxim Khutornenko

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

2015-02-20 Thread Maxim Khutornenko
/Updates.java <https://reviews.apache.org/r/31170/#comment119639> JobKeys.assertValid(summary.getJobKey()) should be better here. Also, you may want to inline these checks with the JobUpdateKey construction statement. - Maxim Khutornenko On Feb. 19, 2015, 8:30 p.m., Bill Farner

Re: Review Request 31240: Remove single caller methods from AuroraCommandContext

2015-02-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31240/#review73343 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 20, 2015, 10:29

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-20 Thread Maxim Khutornenko
build Thanks, Maxim Khutornenko

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-20 Thread Maxim Khutornenko
map via a debug endpoint. Done and done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review73208 --- On Feb. 20, 2

Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Maxim Khutornenko
eviews.apache.org/r/31241/#review73328 --- On Feb. 20, 2015, 10:31 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Maxim Khutornenko
pache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4 Diff: https://reviews.apache.org/r/31241/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-20 Thread Maxim Khutornenko
her places where we use enums (e.g. task_store_ASSIGNED). - Maxim Khutornenko On Feb. 21, 2015, 12:04 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-20 Thread Maxim Khutornenko
----- On Feb. 20, 2015, 11:58 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30891/ > ---

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-20 Thread Maxim Khutornenko
depending on the test execution sequence. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review73355 -----------

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-20 Thread Maxim Khutornenko
> On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, > > line 199 > > <https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199> > > > > Use StringBuilder

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-20 Thread Maxim Khutornenko
> On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, > > line 199 > > <https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199> > > > > Use StringBuilder

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-20 Thread Maxim Khutornenko
> On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, > > line 199 > > <https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199> > > > > Use StringBuilder

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Maxim Khutornenko
> > (Updated Feb. 21, 2015, 6:33 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1028 > https://issues.apache.org/jira/browse/AURORA-1028 > > > Repository: aurora > > > Description >

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
Thanks for reminding. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73217 --- On Feb. 11, 2015, 9:39 p.m

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
org/r/30895/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-23 Thread Maxim Khutornenko
what's the motivation here? > > Maxim Khutornenko wrote: > Test coverage for the fine-logging statements. > > Maxim Khutornenko wrote: > Just noticed you are referring to the `setUp()`. This is making sure > anything with INFO is still logged and setting to

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-23 Thread Maxim Khutornenko
build Thanks, Maxim Khutornenko

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73642 ------- On Feb. 23, 2015, 7:34 p.m., Maxim Khutornenko wrote: > > ---

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
org/r/30895/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31171: Saving backups asynchronously.

2015-02-23 Thread Maxim Khutornenko
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73225 ------- On Feb. 20, 2015, 10:48 p.m., Maxim Khutornenko wrote: > > ---

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
ps://reviews.apache.org/r/30895/#review73680 ------- On Feb. 23, 2015, 9:03 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
org/r/30895/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31235: Refactoring CronJobManager interface.

2015-02-23 Thread Maxim Khutornenko
cheduler/thrift/SchedulerThriftInterfaceTest.java 945144dcb5240c3713d909344c82a9312cd3ba5c Diff: https://reviews.apache.org/r/31235/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 31235: Refactoring CronJobManager interface.

2015-02-23 Thread Maxim Khutornenko
reviews.apache.org/r/31235/#review73710 --- On Feb. 23, 2015, 11:41 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 31334: Fixing cron update quota checking.

2015-02-23 Thread Maxim Khutornenko
06c8faa9de4d0ac8389dbf07d4e81934b503761b Diff: https://reviews.apache.org/r/31334/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 31235: Refactoring CronJobManager interface.

2015-02-23 Thread Maxim Khutornenko
ora/scheduler/thrift/SchedulerThriftInterfaceTest.java 945144dcb5240c3713d909344c82a9312cd3ba5c Diff: https://reviews.apache.org/r/31235/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Maxim Khutornenko
/test/python/apache/aurora/common/test_clusters.py <https://reviews.apache.org/r/31350/#comment120237> Please, assert the entire contents here, e.g. `assert clusters == [Cluster(...)]` - Maxim Khutornenko On Feb. 24, 2015, 2:18 p.m.,

Re: Review Request 31235: Refactoring CronJobManager interface.

2015-02-24 Thread Maxim Khutornenko
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31235/#review73712 --- On Feb. 24, 2015, 1:23 a.m., Maxim Khutornenko wrote: > > --

Re: Review Request 29943: Uptime-driven scheduler job updates

2015-02-24 Thread Maxim Khutornenko
his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29943/#review73877 --- On Jan. 20, 2015, 9:12 p.m., Maxim Khutornenko wrote: > > -

Re: Review Request 31376: Introduce JobUpdateSummary.key field, dual write that field when it is read/received.

2015-02-24 Thread Maxim Khutornenko
/Updates.java <https://reviews.apache.org/r/31376/#comment120333> Would it make sense to accept/return `JobUpdateSummary`? The mutable/immutable dance is rather confusing at call sites. - Maxim Khutornenko On Feb. 24, 2015, 8:12 p.m., Bill Farner

Re: Review Request 31376: Introduce JobUpdateSummary.key field, dual write that field when it is read/received.

2015-02-24 Thread Maxim Khutornenko
mail. To reply, visit: > https://reviews.apache.org/r/31376/ > --- > > (Updated Feb. 24, 2015, 8:12 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1093 > https://issues.apache.org/jira/browse/

Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-24 Thread Maxim Khutornenko
/scheduler/thrift/SchedulerThriftInterfaceTest.java 9d233d16150b3b7f47408b36f927fb2440a10892 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4 Diff: https://reviews.apache.org/r/31241/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-24 Thread Maxim Khutornenko
s/may/will/? Changed. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review73703 --- On Feb. 23, 2015, 8

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-24 Thread Maxim Khutornenko
ic Assignment failure(Set vetoes) { return new Assignment(NO_TASK_INFO, MorePreconditions.checkNotBlank(vetoes)); } ``` - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72448 -

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-24 Thread Maxim Khutornenko
radlew -Pq build Thanks, Maxim Khutornenko

<    3   4   5   6   7   8   9   10   11   12   >