[GitHub] [helix] pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance

pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r353013663 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java

[GitHub] [helix] pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance

pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r353000617 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java

[GitHub] [helix] pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance

pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352996525 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java

[GitHub] [helix] pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance

pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r353017214 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java

[GitHub] [helix] pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance

pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r353011414 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance

pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r353011586 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance

pkuwm commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352996371 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352956958 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352955623 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352955778 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352955442 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352957677 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352954997 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352957441 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352954957 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352956641 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java

[GitHub] [helix] jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance

jiajunwang commented on a change in pull request #642: Fix zk session race condition before creating a live instance URL: https://github.com/apache/helix/pull/642#discussion_r352954823 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java

[GitHub] [helix] pkuwm opened a new pull request #642: Fix zk session race condition when creating a live instance

pkuwm opened a new pull request #642: Fix zk session race condition when creating a live instance URL: https://github.com/apache/helix/pull/642 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fixes #641 When a

[GitHub] [helix] pkuwm opened a new issue #641: Zk session race condition when creating a live instance

pkuwm opened a new issue #641: Zk session race condition when creating a live instance URL: https://github.com/apache/helix/issues/641 When a storage node's network adapter has issues, network connection is lost, which causes around 5-10 Zookeeper sessions to become expired. Reconnect

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352912598 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352909007 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352907708 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352907972 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352905012 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

narendly commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352903841 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

narendly commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352903841 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352902854 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

narendly commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352902319 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352901801 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352901161 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352899615 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352899469 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352897141 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352896760 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352896282 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352895899 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352894474 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352893558 ## File path:

[GitHub] [helix] zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352893197 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352892479 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352892479 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352891224 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352889711 ## File path:

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352889150 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352889150 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352889050 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352888571 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352887316 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352886850 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #589: Add CloudConfig operations

narendly commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352883946 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352883378 ## File path: helix-core/src/main/java/org/apache/helix/common/cloud/SourceType.java

[GitHub] [helix] jiajunwang commented on issue #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on issue #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#issuecomment-560686297 > Could adding the "algorithm" field in the constructor have been in a separate PR as well? There are a lot of

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352878618 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352878366 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352876386 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352876082 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352875366 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352874624 ## File path:

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352873970 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352874065 ## File path:

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352872380 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352872534 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -562,11 +563,33 @@ public

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352872598 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352872434 ## File path: helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java ## @@ -0,0 +1,176 @@ +package

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352871466 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352871777 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload.

jiajunwang commented on a change in pull request #639: Refine the WAGED rebalancer to minimize the partial rebalance workload. URL: https://github.com/apache/helix/pull/639#discussion_r352866188 ## File path:

[GitHub] [helix] jiajunwang commented on issue #638: Decouple the event type and the scheduled rebalance cache refresh option.

jiajunwang commented on issue #638: Decouple the event type and the scheduled rebalance cache refresh option. URL: https://github.com/apache/helix/pull/638#issuecomment-560586403 > I have a feeling that this should actually require more changes in other parts of the code since there are

[GitHub] [helix] jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option.

jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option. URL: https://github.com/apache/helix/pull/638#discussion_r352846861 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option.

jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option. URL: https://github.com/apache/helix/pull/638#discussion_r352845728 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option.

jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option. URL: https://github.com/apache/helix/pull/638#discussion_r352840336 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option.

jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option. URL: https://github.com/apache/helix/pull/638#discussion_r352838782 ## File path:

[GitHub] [helix] jiajunwang opened a new issue #640: Create a constant for `REBALANCE_IMMEDIATELY` or `IMMEDIATE_REBALANCE` to replace the hardcoded -1?

jiajunwang opened a new issue #640: Create a constant for `REBALANCE_IMMEDIATELY` or `IMMEDIATE_REBALANCE` to replace the hardcoded -1? URL: https://github.com/apache/helix/issues/640 Nit: could we create a constant for `REBALANCE_IMMEDIATELY` or `IMMEDIATE_REBALANCE` with value -1?

[GitHub] [helix] jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option.

jiajunwang commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option. URL: https://github.com/apache/helix/pull/638#discussion_r352837789 ## File path:

[GitHub] [helix] jiajunwang commented on issue #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE".

jiajunwang commented on issue #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE". URL: https://github.com/apache/helix/pull/637#issuecomment-560580941 I rollback part of the change. The additional enum in the cluster config is dangerous. When you only have one enum

[GitHub] [helix] jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE".

jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE". URL: https://github.com/apache/helix/pull/637#discussion_r352823237 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java

[GitHub] [helix] jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE".

jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE". URL: https://github.com/apache/helix/pull/637#discussion_r352823880 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java

[GitHub] [helix] jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE".

jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE". URL: https://github.com/apache/helix/pull/637#discussion_r352823237 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java

[GitHub] [helix] jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE".

jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE". URL: https://github.com/apache/helix/pull/637#discussion_r352818947 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java

[GitHub] [helix] jiajunwang commented on a change in pull request #636: Simply and enhance the RebalanceLatencyGauge so it can be used in multi-threads.

jiajunwang commented on a change in pull request #636: Simply and enhance the RebalanceLatencyGauge so it can be used in multi-threads. URL: https://github.com/apache/helix/pull/636#discussion_r352815776 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #636: Simply and enhance the RebalanceLatencyGauge so it can be used in multi-threads.

jiajunwang commented on a change in pull request #636: Simply and enhance the RebalanceLatencyGauge so it can be used in multi-threads. URL: https://github.com/apache/helix/pull/636#discussion_r352815049 ## File path:

[GitHub] [helix] jiajunwang commented on issue #635: Fix a potential issue in the ResourceChangeSnapshot.

jiajunwang commented on issue #635: Fix a potential issue in the ResourceChangeSnapshot. URL: https://github.com/apache/helix/pull/635#issuecomment-560568983 This PR is ready to be merged, approved by @narendly I will merge it together with the other related PRs in

[GitHub] [helix] jiajunwang commented on a change in pull request #635: Fix a potential issue in the ResourceChangeSnapshot.

jiajunwang commented on a change in pull request #635: Fix a potential issue in the ResourceChangeSnapshot. URL: https://github.com/apache/helix/pull/635#discussion_r352814127 ## File path:

[GitHub] [helix] i3wangyi closed issue #515: PropertyStore accessor that supports read/write content from/to ZK /PROPERTYSTORE

i3wangyi closed issue #515: PropertyStore accessor that supports read/write content from/to ZK /PROPERTYSTORE URL: https://github.com/apache/helix/issues/515 This is an automated message from the Apache Git Service. To

[GitHub] [helix] narendly merged pull request #516: Implement the propertyStore read endpoint

narendly merged pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r352764769 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -110,14 +113,40

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r352762988 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -118,6 +120,29

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r352759603 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -118,6 +120,29

[GitHub] [helix] narendly commented on a change in pull request #589: Add CloudConfig operations

narendly commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352751986 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] narendly commented on a change in pull request #589: Add CloudConfig operations

narendly commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352753271 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -562,11 +563,33 @@ public ClusterConfig

[GitHub] [helix] narendly commented on a change in pull request #589: Add CloudConfig operations

narendly commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352752228 ## File path: helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java ## @@ -0,0 +1,176 @@ +package

[GitHub] [helix] narendly commented on a change in pull request #589: Add CloudConfig operations

narendly commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r352750303 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,287 @@ +package

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352748508 ## File path: helix-core/src/main/java/org/apache/helix/common/cloud/SourceType.java ##

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352740366 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352740272 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352747837 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r352745751 ## File path: helix-core/src/main/java/org/apache/helix/common/cloud/CloudInformationFetcher.java