[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Time out new connections after --fe_service_threads .. Patch Set 14: Verified+1 Code-Review+2 Carrying

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-29 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Andrew Sherman, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#14). Change subject: IMPALA-7800: Time out new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Time out new connections after --fe_service_threads .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Time out new connections after --fe_service_threads .. Patch Set 14: -Verified -- To view, visit

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-28 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Andrew Sherman, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#13). Change subject: IMPALA-7800: Time out new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Time out new connections after --fe_service_threads .. Patch Set 12: (1 comment) Fixed flake8 warning.

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-28 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Andrew Sherman, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#12). Change subject: IMPALA-7800: Time out new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Time out new connections after --fe_service_threads .. Patch Set 11: (2 comments) Thanks Michael. Please

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-26 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 10: (9 comments) Thanks Michael.

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-26 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Andrew Sherman, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#11). Change subject: IMPALA-7800: Time out new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-26 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 10: Code-Review+1 Carrying Andrew's +1

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-26 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Andrew Sherman, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#10). Change subject: IMPALA-7800: Reject new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-25 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 8: (5 comments) Thanks for your comments,

[Impala-ASF-CR] IMPALA-8332: Remove Impala Shell warnings part 1

2019-03-22 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12837 ) Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 .. Patch Set 1: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-18 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#8). Change subject: IMPALA-7800: Reject new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 7: (1 comment) Fixed

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-18 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#7). Change subject: IMPALA-7800: Reject new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: (6 comments) Addressed your comments,

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-05 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#6). Change subject: IMPALA-7800: Reject new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-05 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-28 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#5). Change subject: IMPALA-7800: Reject new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 3: (10 comments) Thanks for the review.

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-28 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#4). Change subject: IMPALA-7800: Reject new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-26 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 1: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-26 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12579 to look at the new patch set (#3). Change subject: IMPALA-7800: Reject new connections after --fe_service_threads

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-26 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 2: (11 comments) Fixed

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-25 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12579 Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. IMPALA-7800: Reject new connections after

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-25 Thread Zoram Thanga (Code Review)
Zoram Thanga has abandoned this change. ( http://gerrit.cloudera.org:8080/12226 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Abandoned Changing the design. -- To view, visit

[Impala-ASF-CR] IMPALA-8187: UDF samples hide symbols by default

2019-02-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12451 ) Change subject: IMPALA-8187: UDF samples hide symbols by default .. Patch Set 3: Code-Review+1 (1 comment) Thanks for doing this!

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-01-24 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 ) Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. Patch Set 1:

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-01-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12226 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: > I meant "the timeout can also be

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-01-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12226 Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. IMPALA-7800: Reject new connections after

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-03 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 3: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-6664: Tag log statements with fragment ids.

2019-01-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 ) Change subject: IMPALA-6664: Tag log statements with fragment ids. .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string"

2018-12-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12073 ) Change subject: IMPALA-7960: Revert "IMPALA-5929: Remove redundant explicit casts to string" .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 2: Code-Review+1 LGTM. -- To view,

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 1: (3 comments) Thanks for doing this.

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-589: Add a sql function to return the impalad coordinator hostname for diagnostic purposes.

2018-09-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11459 ) Change subject: IMPALA-589: Add a sql function to return the impalad coordinator hostname for diagnostic purposes. .. Patch Set 1:

[Impala-ASF-CR] IMPALA-3819: Clarify stale block metadata warning message

2018-09-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11433 ) Change subject: IMPALA-3819: Clarify stale block metadata warning message .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-3819: Clarify stale block metadata warning message

2018-09-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11433 ) Change subject: IMPALA-3819: Clarify stale block metadata warning message .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-09-10 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 18: (3 comments) Thanks for doing this.

[Impala-ASF-CR] IMPALA-7542: fix find-fragment-instances to find all "root threads"

2018-09-07 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11396 ) Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads" .. Patch Set 2: Code-Review+1 Thanks for fixing

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-31 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11352 to look at the new patch set (#4). Change subject: IMPALA-7508: Add Impala Python GDB module

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 ) Change subject: IMPALA-7508: Add Impala Python GDB module .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11352 to look at the new patch set (#3). Change subject: IMPALA-7508: Add Impala Python GDB module

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11352 to look at the new patch set (#2). Change subject: IMPALA-7508: Add Impala Python GDB module

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 ) Change subject: IMPALA-7508: Add Impala Python GDB module .. Patch Set 1: (10 comments) Thanks for the comments. Uploading PS#2.

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11352 Change subject: IMPALA-7508: Add Impala Python GDB module .. IMPALA-7508: Add Impala Python GDB module This patch adds a new Impala

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#4). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#3). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-15 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 1: (2 comments) > Just being

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-15 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#2). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default

2018-07-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10964 Change subject: IMPALA-7014: Disable stacktrace symbolisation by default .. IMPALA-7014: Disable stacktrace symbolisation by default

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 5: Code-Review+1 LGTM -- To

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-13 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 5: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-13 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10850 to look at the new patch set (#5). Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-12 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10850 to look at the new patch set (#4). Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB

[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()

2018-07-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: > I am not sure what kind of tests I can add to

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 4: Can you also add test case

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-06 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-03 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 2: (6 comments) Thanks.

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-03 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10850 to look at the new patch set (#2). Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-03 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 1: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10850 Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. IMPALA-6086: Use of permanent function

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has abandoned this change. ( http://gerrit.cloudera.org:8080/10842 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Abandoned Raising a new review. -- To view,

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10842 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 1: (3 comments) Abandoning

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-06-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10842 Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. IMPALA-6086: Use of permanent function

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-06-21 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 3: (1 comment)

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-06-01 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-14 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: Ping? -- To view, visit

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite

2018-04-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10251 ) Change subject: IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: I don't have +2 rights, so someone else must do that.

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-14 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: GVO does not seem to

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-13 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1 comment) Thanks

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-13 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#4). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail.

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1 comment) Please

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: > (1 comment)

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#3). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail.

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#2). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail.

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9590 Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. IMPALA-6498:

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 5: Thanks Sailesh. I do not have the permission to

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9038 to look at the new patch set (#4). Change subject: IMPALA-2642: Fix a potential deadlock in statestore

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-26 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9038 to look at the new patch set (#3). Change subject: IMPALA-2642: Fix a potential deadlock in statestore

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-22 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 11: Let's wait for

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 1: (1 comment) Thanks for fixing

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#10). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 9: (2 comments) Thanks.

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 2: (3 comments) Working on the test case.

  1   2   >