[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: > > This can't be tested on

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: > This can't be tested on

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. IMPALA-7735: Expose queuing

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11555 ) Change subject: IMPALA-7166: ExecSummary should be a first class object. .. IMPALA-7166: ExecSummary should be a first

[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 ) Change subject: IMPALA-7166: ExecSummary should be a first class object. .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-7687: [DOCS] Support for multiple DISTINCT in a query

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11823 ) Change subject: IMPALA-7687: [DOCS] Support for multiple DISTINCT in a query .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-7687: [DOCS] Support for multiple DISTINCT in a query

2018-10-29 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11823 Change subject: IMPALA-7687: [DOCS] Support for multiple DISTINCT in a query .. IMPALA-7687: [DOCS] Support for multiple DISTINCT in a

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 4: OK. Will do a pass tonight. -- To view, visit

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#8). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11822 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11822 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Abandoned Duplicate -- To view, visit

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: This can't be tested on

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11800 ) Change subject: IMPALA-6374: fix handling of commas in .test files .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 4: Code-Review+1 (2 comments) Thanks, Tim for

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 7: (14 comments) Thanks, Phil, for the code review.

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11822 Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. IMPALA-7655: Rewrite if, isnull, coalesce to use CASE See

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11800 ) Change subject: IMPALA-6374: fix handling of commas in .test files .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-29 Thread Tim Armstrong (Code Review)
Hello Michael Brown, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11800 to look at the new patch set (#4). Change subject: IMPALA-6374: fix handling of commas in .test files

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11800 ) Change subject: IMPALA-6374: fix handling of commas in .test files .. Patch Set 3: (1 comment)

[Impala-ASF-CR] CDH-73537: Skip test default timezone when testing a real cluster.

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11820 ) Change subject: CDH-73537: Skip test_default_timezone when testing a real cluster. .. Patch Set 2: Build Successful

[Impala-ASF-CR] CDH-73537: Skip test default timezone when testing a real cluster.

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11820 ) Change subject: CDH-73537: Skip test_default_timezone when testing a real cluster. .. Patch Set 1: Build Successful

[Impala-ASF-CR] CDH-73537: Skip test default timezone when testing a real cluster.

2018-10-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11820 ) Change subject: CDH-73537: Skip test_default_timezone when testing a real cluster. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted stress and perf

2018-10-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

2018-10-29 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 ) Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options .. Patch Set 1: Tiany and Adrian, Could you please review for

[Impala-ASF-CR] CDH-73537: Skip test default timezone when testing a real cluster.

2018-10-29 Thread David Knupp (Code Review)
Hello Michael Brown, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11820 to look at the new patch set (#2). Change subject: CDH-73537: Skip test_default_timezone when testing a real cluster.

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: -Code-Review Adding a

[Impala-ASF-CR] CDH-73537: Skip test default timezone when testing a real cluster.

2018-10-29 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11820 Change subject: CDH-73537: Skip test_default_timezone when testing a real cluster. .. CDH-73537: Skip test_default_timezone when testing

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: I haven't yet tested this

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 3: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 2: Code-Review+2 carrying over +2

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11816 to look at the new patch set (#2). Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 1: Code-Review+2 (6 comments)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 7: (14 comments) Thanks for the updates!

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 ) Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option .. Patch Set 3: Verified+1 Build

[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option

2018-10-29 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 ) Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option .. Patch Set 3: One clarification per Tim's

[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 ) Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option .. Patch Set 3: Build Started

[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option

2018-10-29 Thread Alex Rodoni (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11804 to look at the new patch set (#3). Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11790 ) Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog .. Patch Set 3: Verified+1

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11800 ) Change subject: IMPALA-6374: fix handling of commas in .test files .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (5 comments) Thanks Thomas and Csaba for

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted stress and perf

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder

[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 ) Change subject: IMPALA-7166: ExecSummary should be a first class object. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 ) Change subject: IMPALA-7166: ExecSummary should be a first class object. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7166: ExecSummary should be a first class object.

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11555 ) Change subject: IMPALA-7166: ExecSummary should be a first class object. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 18: Hi Csaba,

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-29 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/11790 ) Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#7). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#6). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-29 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11790 ) Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-29 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Adrian Ng, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11790 to look at the new patch set (#3). Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-29 Thread Tim Armstrong (Code Review)
Hello Michael Brown, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11800 to look at the new patch set (#3). Change subject: IMPALA-6374: fix handling of commas in .test files

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 5: Thanks everyone for your patient reviews of this

[Impala-ASF-CR] IMPALA-5031: Make UBSAN-friendly arithmetic generic

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11810 ) Change subject: IMPALA-5031: Make UBSAN-friendly arithmetic generic .. Patch Set 1: Code-Review+2 (1 comment) Just had a comment

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#5). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. IMPALA-7749:

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. Patch Set 3: Verified+1

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 1: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 3: Code-Review+1 Actually I should let michael take a

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Bharath Vissapragada (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11778 to look at the new patch set (#3). Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-5031: memcpy cannot take null arguments

2018-10-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11812 ) Change subject: IMPALA-5031: memcpy cannot take null arguments .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7727: Fix TStatusCode to TErrorCode mapping

2018-10-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 ) Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11816 Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. IMPALA-7735: Expose queuing status in

[Impala-ASF-CR] IMPALA-7765: [DOCS] Document IMPALA MAX MEM ESTIMATE FOR ADMISSION option

2018-10-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11804 ) Change subject: IMPALA-7765: [DOCS] Document IMPALA_MAX_MEM_ESTIMATE_FOR_ADMISSION option .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-29 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/11790 ) Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. IMPALA-7749: Compute

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 4: > Patch

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 4: > Yes,

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 4: > Patch

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 4:

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-29 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Paul Rogers, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#7). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries