[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (1 comment) Fixed the tests that failed in the

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (9 comments) Thanks for your comments. I need

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 7: (1 comment) Lgtm, just one pending clarific

[Impala-ASF-CR] IMPALA-8156: Add format options to the EXPLAIN statement

2019-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12340 ) Change subject: IMPALA-8156: Add format options to the EXPLAIN statement .. Patch Set 1: (7 comments) I think this is super he

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2019-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 2: Code-Review+1 (1 comment) Lgtm. I'm not super

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-07 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#8). Change subject: IMPALA-5872: Testcase builder for query planner ..

[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

2019-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 2: (12 comments) http://g

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12414 Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. IMPALA-8177: Log DDL failures in coordinator logs If a DDL

[Impala-ASF-CR] IMPALA-8163: Add banner showing for local catalog mode when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. .. Patch Set 1: (3 comments) http://gerr

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 7: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8163: Add banner showing for local catalog mode when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. .. Patch Set 1: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-08 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#9). Change subject: IMPALA-5872: Testcase builder for query planner ..

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-08 Thread Bharath Vissapragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12414 to look at the new patch set (#2). Change subject: IMPALA-8177: Log DDL failures in coordinator logs ...

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12414 ) Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. Patch Set 2: I logged it at ERROR severity since we are de

[Impala-ASF-CR] IMPALA-8163: Add banner showing for local catalog mode when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. .. Patch Set 5: (4 comments) A bunch of

[Impala-ASF-CR] IMPALA-8163: Add banner showing local catalog mode on web UI when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing local catalog mode on web UI when enabled. .. Patch Set 10: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-10 Thread Bharath Vissapragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12414 to look at the new patch set (#4). Change subject: IMPALA-8177: Log DDL failures in coordinator logs ...

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12414 ) Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. Patch Set 4: Code-Review+2 There were merge conflicts. Reb

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12414 ) Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. Patch Set 4: Paul, this patch is just about the error prop

[Impala-ASF-CR] Additions to .gitignore

2019-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12430 ) Change subject: Additions to .gitignore .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12430

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12428 Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. IMPALA-7961: Avoid adding unmodified objects to D

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object endpoint when local catalog mode is enabled.

2019-02-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 ) Change subject: IMPALA-7935: Disable /catalog_object endpoint when local_catalog_mode is enabled. .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2019-02-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8039: Incorrect selectivity estimate for not-equals predicate

2019-02-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-8039: Incorrect selectivity estimate for not-equals predicate .. Patch Set 2: (3 comments) Patch makes

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 4: (5 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#4). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response ..

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 ) Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. .. Patch Set 3: (5 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8182: Add single-node plan to PlanCtx

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12436 ) Change subject: IMPALA-8182: Add single-node plan to PlanCtx .. Patch Set 1: (6 comments) Few minor comments, lgtm otherwise.

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#5). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 5: Redid the patch after discussing w

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-13 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#6). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 6: Code-Review+2 (1 comment) Carryin

[Impala-ASF-CR] IMPALA-8182: Add single-node plan to PlanCtx

2019-02-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12436 ) Change subject: IMPALA-8182: Add single-node plan to PlanCtx .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 7: Looks like this change introduced

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-7560: Improve selectivity estimate for != .. Patch Set 3: Code-Review+2 (3 comments) Couple of nits. h

[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 8: Code-Review+1 I didn't

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-14 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#8). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 8: Code-Review+2 Turns out the lock r

[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog

2019-02-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalo

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

2019-02-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 ) Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. .. Patch Set 4: (5 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 6: Code-Review+2 (2 comments) Feel free to carry +2

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 3: Code-Review+2 (2 comments) Couple

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 6: Gerrit says there are merge conflicts, rebase and

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 5: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 5: (6 comments) Bunch o

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 6: (7 comments) http://

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 7: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-6900: Fix the min version invariant for invalidate metadata

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12547 ) Change subject: IMPALA-6900: Fix the min version invariant for invalidate metadata .. Patch Set 3: Todd, you touched this code

[Impala-ASF-CR] IMPALA-6900: Fix the min version invariant for invalidate metadata

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12547 ) Change subject: IMPALA-6900: Fix the min version invariant for invalidate metadata .. IMPALA-6900: Fix the min version invariant

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-7560: Improve selectivity estimate for != .. Patch Set 4: Gerrit still complaining about the merge confl

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12437 ) Change subject: IMPALA-8185: Abstract out real/mock file system operations .. Patch Set 5: (4 comments) The general separation

[Impala-ASF-CR] IMPALA-7975 : Improve supportability of the automatic invalidate feature

2019-02-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12549 ) Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature .. Patch Set 2: (15 comments) Haven'

[Impala-ASF-CR] IMPALA-8243: Fix racy access to nonPartFieldSchemas

2019-02-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12572 Change subject: IMPALA-8243: Fix racy access to nonPartFieldSchemas_ .. IMPALA-8243: Fix racy access to nonPartFieldSchemas_ **

[Impala-ASF-CR] IMPALA-8243: Fix racy access to nonPartFieldSchemas

2019-02-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12572 ) Change subject: IMPALA-8243: Fix racy access to nonPartFieldSchemas_ .. IMPALA-8243: Fix racy access to nonPartFieldSche

[Impala-ASF-CR] IMPALA-7645: Add a query option to set the default table file format

2019-02-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12568 ) Change subject: IMPALA-7645: Add a query option to set the default table file format .. Patch Set 6: Looks like PS5 is a draft

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 4: (9 comments) B

[Impala-ASF-CR] IMPALA-7645: Add a query option to set the default table file format

2019-02-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12568 ) Change subject: IMPALA-7645: Add a query option to set the default table file format .. Patch Set 7: Code-Review+2 (2 comments

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 5: (2 comments) h

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 7: Code-Review+2 (1 comm

[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files. .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 5: (1 comment) ht

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 6: Code-Review+2 (

[Impala-ASF-CR] IMPALA-8240: Event processor should keep trying when metastore is unavailable.

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 ) Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. .. Patch Set 8: Code-Review+2

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 5: (16 comments) Mostly general c

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 7: Code-Review+2 (4 comments) Tha

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 8: Code-Review+2 Thanks for addres

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-03-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 10: (3 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8272: Fix test catalog tablesfilesusage failing

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12649 ) Change subject: IMPALA-8272: Fix test_catalog_tablesfilesusage failing .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8273 : Change metastore configuration template to not exclude impala specific parameters

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore configuration template to not exclude impala specific parameters .. Patch Set 1:

[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 2: Code-

[Impala-ASF-CR] IMPALA-8272: Fix test catalog tablesfilesusage failing

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12649 ) Change subject: IMPALA-8272: Fix test_catalog_tablesfilesusage failing .. Patch Set 2: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 7: (9 comments) Nice clean separation. The patc

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: I have some questions around how the Fk-Pk

[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 4: Code-R

[Impala-ASF-CR] IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12656 ) Change subject: IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness .. Patch Set 7: (6 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 8: Code-Review+1 (2 comments) Will let Paul +2

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2019-03-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Abandoned Stale now. Feel free to restore

[Impala-ASF-CR] IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness

2019-03-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12656 ) Change subject: IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness .. Patch Set 9: (8 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness

2019-03-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12656 ) Change subject: IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness .. Patch Set 11: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-03-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 12: (9 comments) I think the new

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 7: Code-Review+1 (4 comments) I'll let Paul tak

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: (2 comments) My understanding of the math

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-03-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 17: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification

2019-03-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12700 ) Change subject: IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification .. Patch Set 5: (2 comments) http://

[Impala-ASF-CR] IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification

2019-03-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12700 ) Change subject: IMPALA-7974: [DOCS] Document automatic invalidation via HMS notification .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync

2019-03-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 1: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-03-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 8: Code-Review+1 -- To view, visit http://ger

[Impala-ASF-CR] [DOCS] Event based HMS sync works for Metadata V1 and V2

2019-03-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12745 ) Change subject: [DOCS] Event based HMS sync works for Metadata V1 and V2 .. Patch Set 3: Code-Review+2 (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 4: (2 comments) http://

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 5: (5 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 4: (2 comments) http://

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 8: Code-Review+2 (5 comm

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (1 comment) http://gerrit.cloudera

<    1   2   3   4   5   6   7   8   9   10   >