[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-05 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12885 to look at the new patch set (#4). Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 2: (8 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12885 to look at the new patch set (#6). Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 6: Code-Review+2 Carry +2 -- To v

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 5: (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. IMPALA-8371: Return appropriate error

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12968 Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. IMPALA-8322: Add periodic dirty check of do

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#2). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb ..

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 2: (4 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#3). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb ..

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#4). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb ..

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 15: Code-Review+1 (3 comments) This makes sen

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 4: Code-Review+1 (1 comment) This ma

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. Patch Set 7: Code-Review+2 This makes sense to me. -- T

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: Code-Review+2 Thanks for getting this done

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#5). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb ..

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-04-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13020 Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. IMPALA-8344: Add support for running the miniclust

[Impala-ASF-CR] IMPALA-8415: Fix tests broken by storage layer information

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13025 Change subject: IMPALA-8415: Fix tests broken by storage layer information .. IMPALA-8415: Fix tests broken by storage layer information

[Impala-ASF-CR] IMPALA-8415: Fix tests broken by storage layer information

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13025 ) Change subject: IMPALA-8415: Fix tests broken by storage layer information .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8415: Fix tests broken by storage layer information

2019-04-16 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13025 to look at the new patch set (#2). Change subject: IMPALA-8415: Fix tests broken by storage layer information ..

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 3: (3 comments) Before more work go

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 10: Code-Review+1 (1 comment) This looks fine to me. I can

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 11: Code-Review+2 Bump this to +2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build

2019-04-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-04-22 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13020 to look at the new patch set (#2). Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .

[Impala-ASF-CR] Remove references to the $IMPALA HOME/thirdparty directory

2019-04-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13092 Change subject: Remove references to the $IMPALA_HOME/thirdparty directory .. Remove references to the $IMPALA_HOME/thirdparty directory

[Impala-ASF-CR] Remove references to the $IMPALA HOME/thirdparty directory

2019-04-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13092 ) Change subject: Remove references to the $IMPALA_HOME/thirdparty directory .. Patch Set 1: Test failure is a known flaky issue. -- T

[Impala-ASF-CR] IMPALA-8072: remove junk configs from containers

2019-04-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13104 ) Change subject: IMPALA-8072: remove junk configs from containers .. Patch Set 2: Code-Review+2 Makes sense -- To view, visit http://

[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker

2019-04-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13119 ) Change subject: IMPALA-8119: document how to set heap size in docker .. Patch Set 1: Code-Review+2 Good to get this cleaned up -- To

[Impala-ASF-CR] Configure Hive 3's HS2 to execute queries using Tez local mode

2019-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12931 ) Change subject: Configure Hive 3's HS2 to execute queries using Tez local mode .. Configure Hive 3's HS2 to execute queries usi

[Impala-ASF-CR] Configure Hive 3's HS2 to execute queries using Tez local mode

2019-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12931 ) Change subject: Configure Hive 3's HS2 to execute queries using Tez local mode .. Patch Set 6: Code-Review+2 I think this makes sense,

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 12: (2 comments) Starting to review

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 14: (3 comments) http://gerrit.clou

[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13182 ) Change subject: Revert "IMPALA-7971: Add support for insert events in event processor." .. Patch Set 1: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 19: (3 comments) I'm basically read

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 19: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 20: Code-Review+2 This looks good. T

[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13181 ) Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster .. Patch Set 1: Code-Review+2 Thanks for fixing this --

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 23: Code-Review+2 Fix looks correct

[Impala-ASF-CR] IMPALA-8475: Fix unbound CMAKE BUILD TYPE LIST in buildall.sh

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13204 Change subject: IMPALA-8475: Fix unbound CMAKE_BUILD_TYPE_LIST in buildall.sh .. IMPALA-8475: Fix unbound CMAKE_BUILD_TYPE_LIST in build

[Impala-ASF-CR] IMPALA-8478: Fix test provider.py Python 2.6 compatibility

2019-05-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13211 ) Change subject: IMPALA-8478: Fix test_provider.py Python 2.6 compatibility .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

2019-05-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 ) Change subject: IMPALA-8269: Refactor authorization test package structure .. Patch Set 1: Code-Review+1 (1 comment) This makes sense

[Impala-ASF-CR] IMPALA-8428: Add support for caching file handles on s3

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13221 ) Change subject: IMPALA-8428: Add support for caching file handles on s3 .. Patch Set 2: Code-Review+2 Thanks for putting this together

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13224/2/testd

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 2: I'm running a gerrit-verify-dryrun-external (which won't submi

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13224/3/testd

[Impala-ASF-CR] IMPALA-8492: reenable large string tests in docker

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13233 ) Change subject: IMPALA-8492: reenable large string tests in docker .. Patch Set 2: Code-Review+2 Looks good to me -- To view, visit

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13224/3/testd

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/132

[Impala-ASF-CR] IMPALA-7490: fix uninitialized variables in load-data.py

2018-08-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11330 ) Change subject: IMPALA-7490: fix uninitialized variables in load-data.py .. Patch Set 2: Code-Review+2 Thanks for fixing this. -- To

[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"

2018-08-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/7080 ) Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. Abandoned This is an old review that was fixed elsewhere

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 3: (4 comments) I'm making my way through this. F

[Impala-ASF-CR] IMPALA-5031: fix signed overflows in decimal

2018-10-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11604 ) Change subject: IMPALA-5031: fix signed overflows in decimal .. Patch Set 1: Took a first pass on this. Functionally, it makes sense.

[Impala-ASF-CR] IMPALA-5031: fix signed overflows in decimal

2018-10-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11604 ) Change subject: IMPALA-5031: fix signed overflows in decimal .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"

2018-10-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 ) Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver" .. Patch Set 1: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-7654: [DOCS] TRUNCATE does not put HDFS data files to the trash

2018-10-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11583 ) Change subject: IMPALA-7654: [DOCS] TRUNCATE does not put HDFS data files to the trash .. Patch Set 1: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 3: Quick comment: I think we are going to be

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"

2018-10-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 ) Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver" .. Patch Set 1: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 4: (2 comments) Add some comments on stuff

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 4: (4 comments) Looking through the existin

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"

2018-10-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11671 Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. IMPALA-7704: Revert "IMPALA-764

[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"

2018-10-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 ) Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver" .. Patch Set 3: Code-Review+2 (1 comment

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 6: Code-Review+2 (1 comment) One small comment. O

[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"

2018-10-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: > Is this a clea

[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"

2018-10-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. IMPALA-7704: Revert "I

[Impala-ASF-CR] IMPALA-7639: Move concurrent UDF tests to a custom cluster test

2018-10-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11701 Change subject: IMPALA-7639: Move concurrent UDF tests to a custom cluster test .. IMPALA-7639: Move concurrent UDF tests to a custom cl

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 5: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7639: Move concurrent UDF tests to a custom cluster test

2018-10-17 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11701 to look at the new patch set (#2). Change subject: IMPALA-7639: Move concurrent UDF tests to a custom cluster test .

[Impala-ASF-CR] IMPALA-7639: Move concurrent UDF tests to a custom cluster test

2018-10-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11701 ) Change subject: IMPALA-7639: Move concurrent UDF tests to a custom cluster test .. Patch Set 1: (12 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7639: Move concurrent UDF tests to a custom cluster test

2018-10-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11701 ) Change subject: IMPALA-7639: Move concurrent UDF tests to a custom cluster test .. Patch Set 2: Code-Review+2 Fixed flake8 issues. Car

[Impala-ASF-CR] IMPALA-7639: Move concurrent UDF tests to a custom cluster test

2018-10-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11701 ) Change subject: IMPALA-7639: Move concurrent UDF tests to a custom cluster test .. IMPALA-7639: Move concurrent UDF tests to a

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 7: Code-Review+2 This looks good! -- To view, vi

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 7: (2 comments) I'm basically ready to +2 t

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 8: Code-Review+2 Thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#10) to the change originally created by mackror...@apache.org. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. ..

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 10: Code-Review+2 Fixed disk-io-mgr-test.cc

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 4: (2 comments) Thanks for doing this! http://gerr

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. Patch Set 4: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-7758: Fix LOCATION clause when creating chars formats *

2018-10-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11789 ) Change subject: IMPALA-7758: Fix LOCATION clause when creating chars_formats_* .. Patch Set 2: Code-Review+2 It makes sense to fix the

[Impala-ASF-CR] IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS)

2018-11-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 ) Change subject: IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS) .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS)

2018-11-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 ) Change subject: IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS) .. Patch Set 3: (4 comments) A few minor comments. http://gerr

[Impala-ASF-CR] IMPALA-7788: [DOCS] Impala supports ADLS Gen 2 (ABFS)

2018-11-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 ) Change subject: IMPALA-7788: [DOCS] Impala supports ADLS Gen 2 (ABFS) .. Patch Set 4: Code-Review+1 I'm fine with this and if Jim does

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-08 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11874 to look at the new patch set (#3). Change subject: IMPALA-7738: Implement timeouts for HDFS open calls ..

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 4: (1 comment) > Thanks! > > I was a little surpri

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-11-08 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11874 to look at the new patch set (#4). Change subject: IMPALA-7738: Implement timeouts for HDFS open calls ..

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2018-11-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 3: I would like there to be a

[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme

2018-11-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 ) Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme .. Patch Set 1: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme

2018-11-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11948 ) Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme .. Patch Set 2: Code-Review+2 Thanks, looks good.

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11944 to look at the new patch set (#2). Change subject: IMPALA-7871: Don't load Hive builtins .. IMPALA-7871: D

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11944 ) Change subject: IMPALA-7871: Don't load Hive builtins .. IMPALA-7871: Don't load Hive builtins Dataload has a step of "Loading

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11959 Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. IMPALA-7804: Mitigate s3 consistency issues for test_sc

<    1   2   3   4   5   6   7   8   9   10   >