[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (1 comment) Did we intentionally not u

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/895

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 3: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 7: (13 comments) Looking good. Some minor comments. http

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 11: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 4: Code-Review+2 (3 comments) http://gerr

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 12: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 2: GVO failed with IMPALA-6399 -- To view, vis

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 2: Code-Review+2 -- To view, visit http://gerri

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9120 ) Change subject: Build old versions of gperftools and thrift. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9120/1/build

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/895

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9121 to review the following change. Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() ..

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Removed reviewer Todd Lipcon. -- To view, visi

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Removed reviewer Kudu Jenkins. -- To view, vi

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 1: Clean cherry-pick. -- To view, visit

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9122 ) Change subject: Build old versions of gperftools and thrift. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9122/1/build

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9122 ) Change subject: Build old versions of gperftools and thrift. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9125 Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. IMPALA-6356: Reduce amount of logging from RpczStore::Lo

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9125 to look at the new patch set (#2). Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() ...

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Lars Volker, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9121 to look at the new patch set (#2). Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() ..

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 2: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9125 to look at the new patch set (#3). Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() ...

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/8914/

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 3: Code-Review+1 Carry +1 -- To view, visi

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/8914

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 11: Code-Review+2 (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9058 to look at the new patch set (#2). Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled ...

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 1: (1 comment) The changes to the BE tests we

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 2: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 14: Code-Review+1 (5 comments) Tim may want to take anoth

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/8914/

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-01-29 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9158 Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable ConditionVar

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-01-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/915

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/8914

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9164

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 1: (4 co

[Impala-ASF-CR] IMPALA-6369: Exchange node's memory usage should include its receiver's

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9202 Change subject: IMPALA-6369: Exchange node's memory usage should include its receiver's .. IMPALA-6369: Exchange node's memory usage should

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. IMPALA-6396: Exchange node's memory usage should

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/915

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-05 Thread Michael Ho (Code Review)
Hello Jim Apple, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9158 to look at the new patch set (#2). Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/915

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 2: (4 co

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-06 Thread Michael Ho (Code Review)
Michael Ho has removed Lars Volker from this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Removed reviewer Lars Volker. -- To view

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 3: Code-R

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-07 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9202 to look at the new patch set (#3). Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's ...

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 3: (4 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9202 to look at the new patch set (#4). Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's ...

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 4: Code-Review+2 (1 comment) Carry

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9202 to look at the new patch set (#5). Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 5: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 5: Code-Review+2 Carry +2 -- To vi

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9202 to look at the new patch set (#6). Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 6: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 6: Code-Review+2 Carry +2 -- To vi

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-11 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9282 Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. IMPALA-6116: Bound memory usage of DataStreamSevice'

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: Is this a clean cherry-pick ? -- To view, visit http

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6269: Cherry-pick dependency change for KRPC

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 ) Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9287/

[Impala-ASF-CR] IMPALA-6508: add krpc test flag

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add krpc test flag .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9291/4/bin/start-impala-

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: Code-Review+2 (1 comment) Seems simp

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#2). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (14 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 4: @tarmstrong. oops. sorry, must have picked the wrong change

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#3). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 2: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/9291/7/bin/start-impala-

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 2: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9331 Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. IMPALA-6512: Fix test_exchange_delays for KRPC The sender timed out error

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9331 ) Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. Patch Set 1: FWIW, this is the error message in question: https://githu

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9291/8/test

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: Michael and/or David may want to do another pass and +2 the change. -- T

[Impala-ASF-CR] IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9344 Change subject: IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool .. IMPALA-5518: Allocate RowBatch tuples pointers a

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 5: (6 comments) Some initial comments. Doing another pass.

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/9292/6

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9337/1/be

[Impala-ASF-CR] IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#2). Change subject: IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool .

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#3). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool ...

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 3: (6 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#4). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: (7 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#4). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool ...

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 4: (7 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/9292/7

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 4: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 1: (2 comments) http://gerrit.clo

  1   2   3   4   5   6   7   8   9   10   >