[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1144: Fix exception when CTRL+C on running query in Impala-shell

2017-11-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when CTRL+C on running query in Impala-shell .. Patch Set 2: (5 comments) The Python

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 5: Code-Review+1 Thanks. Tim: I'm good with

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-11-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8529 ) Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI. .. Patch Set 1: (3 comments) I took a very

[Impala-ASF-CR] IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process

2017-11-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process .. Patch Set 2: Based on my

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 4: Code-Review+1 (1 comment) Thanks for the

[Impala-ASF-CR] Pin gen build version's git handling to typical git dir.

2017-11-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8500 ) Change subject: Pin gen_build_version's git handling to typical git dir. .. Patch Set 1: Ping? Thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 3: Code-Review+1 (3 comments) Thanks for the

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 6: Well, that's what I get for being clever with bash.

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Philip Zeyliger (Code Review)
Hello David Knupp, Joe McDonnell, Zach Amsden, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8456 to look at the new patch set (#6). Change subject: IMPALA-6148: Specifying thirdparty deps as URLs

[Impala-ASF-CR] Remove unused/defunct Maven repositories.

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8497 ) Change subject: Remove unused/defunct Maven repositories. .. Patch Set 1:

[Impala-ASF-CR] Remove unused/defunct Maven repositories.

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8497 Change subject: Remove unused/defunct Maven repositories. .. Remove unused/defunct Maven repositories. Removes three Maven

[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.

2017-11-08 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8496 to look at the new patch set (#3). Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Expose

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 9: (1 comment) I'm still a little weirded out that we

[Impala-ASF-CR] Pin gen build version's git handling to typical git dir.

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8500 Change subject: Pin gen_build_version's git handling to typical git dir. .. Pin gen_build_version's git handling to typical git dir.

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 4: (6 comments) Thanks for the reviews! I think I

[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.

2017-11-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8496 Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. With this

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-08 Thread Philip Zeyliger (Code Review)
Hello David Knupp, Joe McDonnell, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8456 to look at the new patch set (#4). Change subject: IMPALA-6148: Specifying thirdparty deps as URLs

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-06 Thread Philip Zeyliger (Code Review)
Hello David Knupp, Joe McDonnell, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8456 to look at the new patch set (#3). Change subject: IMPALA-6148: Specifying thirdparty deps as URLs

[Impala-ASF-CR] Fix errant, newline-including log directory.

2017-11-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8459 ) Change subject: Fix errant, newline-including log directory. .. Patch Set 1: Looking through

[Impala-ASF-CR] Fix errant, newline-including log directory.

2017-11-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8459 Change subject: Fix errant, newline-including log directory. .. Fix errant, newline-including log directory. We've seen cases where a

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8456 Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. IMPALA-6148: Specifying thirdparty deps as URLs If the environment

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (1 comment) > Should I create tests

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 5: Code-Review-1 (3 comments) I took a quick look

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-11-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: (1 comment) Thanks for the reviews! I'll report

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-11-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-11-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: Hi Dan, This is a draft of the change to let query

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8434 Change subject: IMPALA-5564: Release lock during planning. (wip) .. IMPALA-5564: Release lock during planning. (wip) ** I'm looking

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8432 Change subject: Correct log line in start-impala-cluster.py. .. Correct log line in start-impala-cluster.py. Updated logging in

[Impala-ASF-CR] Install OpenJDK-dbg for development environments.

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8431 Change subject: Install OpenJDK-dbg for development environments. .. Install OpenJDK-dbg for development environments. Updates the

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 3: > Patch Set 3: > > I'm still testing this change.

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (1 comment) Most of this looks

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6073: Fail on misconfigured CLASSPATH.

2017-10-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8327 ) Change subject: IMPALA-6073: Fail on misconfigured CLASSPATH. .. Patch Set 1: Code-Review-1 > Patch Set 1: > > > I think this check

[Impala-ASF-CR] IMPALA-6108, IMPALA-6070: Parallel data load (re-instated).

2017-10-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8405 ) Change subject: IMPALA-6108, IMPALA-6070: Parallel data load (re-instated). .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6108, IMPALA-6070: Parallel data load (re-instated).

2017-10-27 Thread Philip Zeyliger (Code Review)
Hello Joe McDonnell, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8405 to look at the new patch set (#3). Change subject: IMPALA-6108, IMPALA-6070: Parallel data load (re-instated).

[Impala-ASF-CR] IMPALA-6108, IMPALA-6070: Parallel data load (re-instated).

2017-10-27 Thread Philip Zeyliger (Code Review)
Hello Joe McDonnell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8405 to look at the new patch set (#2). Change subject: IMPALA-6108, IMPALA-6070: Parallel data load (re-instated).

[Impala-ASF-CR] IMPALA-6108, IMPALA-6070: Parallel data load (re-instated).

2017-10-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8405 Change subject: IMPALA-6108, IMPALA-6070: Parallel data load (re-instated). .. IMPALA-6108, IMPALA-6070: Parallel data load

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. .. Patch Set 8: > Patch Set 8: > > > Oof. GVO caught a

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. .. Patch Set 8: Oof. GVO caught a (correct) clang-tidy issue.

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. .. Patch Set 7: Code-Review+1 Carrying the +1. I've not made

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-10-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 2: (7 comments) Thanks for tackling this! As a

[Impala-ASF-CR] IMPALA-6108: Revert "IMPALA-6070: Parallel data load."

2017-10-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8386 Change subject: IMPALA-6108: Revert "IMPALA-6070: Parallel data load." .. IMPALA-6108: Revert "IMPALA-6070: Parallel data load." We

[Impala-ASF-CR] IMPALA-3998: deprecate --refresh after connect

2017-10-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8381 ) Change subject: IMPALA-3998: deprecate --refresh_after_connect .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. .. Patch Set 6: Code-Review-1 The test failures are real; I'm

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: Hi Laszlo, We're interested in this change

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 3: (4

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, David Knupp, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8354 to look at the new patch set (#4). Change subject: IMPALA-6070: Parallel compute_table_stats.py

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: > Patch Set 2: > > (1 comment) Sure. I did the

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, David Knupp, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8354 to look at the new patch set (#3). Change subject: IMPALA-6070: Parallel compute_table_stats.py

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: BTW,

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Philip Zeyliger (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8354 to look at the new patch set (#2). Change subject: IMPALA-6070: Parallel compute_table_stats.py .. IMPALA-6070:

[Impala-ASF-CR] IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

2017-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls. .. Patch Set 8: (4 comments) Thanks for the review, Alex! I

[Impala-ASF-CR] IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

2017-10-23 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8238 to look at the new patch set (#9). Change subject: IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

[Impala-ASF-CR] IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

2017-10-23 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8238 to look at the new patch set (#8). Change subject: IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8354 Change subject: IMPALA-6070: Parallel compute_table_stats.py .. IMPALA-6070: Parallel compute_table_stats.py Uses a thread pool to

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. .. Patch Set 4: (4 comments) Thanks. I think I got all the

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-21 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8211 to look at the new patch set (#5). Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. ..

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-21 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8211 to look at the new patch set (#4). Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. ..

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8320 ) Change subject: IMPALA-6070: Parallel data load. .. Patch Set 2: (9 comments) Thanks for the reviews! I observed memory when

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-21 Thread Philip Zeyliger (Code Review)
Hello Jim Apple, Joe McDonnell, Alex Behm, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8320 to look at the new patch set (#2). Change subject: IMPALA-6070: Parallel data load.

[Impala-ASF-CR] IMPALA-6073: Fail on misconfigured CLASSPATH.

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8327 Change subject: IMPALA-6073: Fail on misconfigured CLASSPATH. .. IMPALA-6073: Fail on misconfigured CLASSPATH. Asserts, early, that

[Impala-ASF-CR] IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8262 ) Change subject: IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04 .. Patch Set 3: > Patch Set 3: > > > Sorry to get to

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8320 Change subject: IMPALA-6070: Parallel data load. .. IMPALA-6070: Parallel data load. This commit loads functional-query, TPC-H data,

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-18 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8211 to look at the new patch set (#3). Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. ..

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.

2017-10-18 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8211 to look at the new patch set (#2). Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. ..

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. .. Patch Set 7: Code-Review+1 Carry post rebase. -- To

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. .. Patch Set 6: Code-Review+1 (1 comment) Carrying

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add 'psmisc' to bootstrap system.sh.

2017-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8306 ) Change subject: Add 'psmisc' to bootstrap_system.sh. .. Patch Set 1: > Would you like me to submit this for you, Phil? Yes, please.

[Impala-ASF-CR] Add 'psmisc' to bootstrap system.sh.

2017-10-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8306 Change subject: Add 'psmisc' to bootstrap_system.sh. .. Add 'psmisc' to bootstrap_system.sh. testdata/bin/kill-all.sh uses

[Impala-ASF-CR] Making bin/bootstrap system.sh executable.

2017-10-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8292 Change subject: Making bin/bootstrap_system.sh executable. .. Making bin/bootstrap_system.sh executable. Script should be executable,

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-16 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8238 to look at the new patch set (#5). Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 4: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. .. Patch Set 4: (2 comments) Thanks for the review! I ran

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-16 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8238 to look at the new patch set (#4). Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 1: Code-Review+1 (3 comments) This looks fine to

[Impala-ASF-CR] IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04

2017-10-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8262 ) Change subject: IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04 .. Patch Set 3: (2 comments) Sorry to get to this a

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-12 Thread Philip Zeyliger (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8238 to look at the new patch set (#3). Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. ..

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 4: (10 comments) Thanks! I think

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.

2017-10-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8258 ) Change subject: IMPALA-6027: Retry downloading toolchain components. .. IMPALA-6027: Retry downloading toolchain components. We've

[Impala-ASF-CR] IMPALA-6027: Retry downloading toolchain components.

2017-10-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8258 Change subject: IMPALA-6027: Retry downloading toolchain components. .. IMPALA-6027: Retry downloading toolchain components. We've

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8237 Change subject: Download toolchain in parallel. .. Download toolchain in parallel. By downloading from the toolchain S3 buckets in

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-06 Thread Philip Zeyliger (Code Review)
Hello Michael Ho, Sailesh Mukil, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8100 to look at the new patch set (#6). Change subject: IMPALA-5940: Avoid log spew by using Status::Expected.

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 1: (5 comments) I'm excited by

[Impala-ASF-CR] IMPALA-6021: Revert "IMPALA-6009: Upgrade Guava to 14.0.1"

2017-10-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8225 ) Change subject: IMPALA-6021: Revert "IMPALA-6009: Upgrade Guava to 14.0.1" .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.

2017-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 ) Change subject: IMPALA-6011: Remove use of Guava Hasher. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 3: (2 comments)

  1   2   >