[Impala-ASF-CR] IMPALA-6021: Revert "IMPALA-6009: Upgrade Guava to 14.0.1"

2017-10-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8225 ) Change subject: IMPALA-6021: Revert "IMPALA-6009: Upgrade Guava to 14.0.1" .. Patch Set 1: Code-Review+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.

2017-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 ) Change subject: IMPALA-6011: Remove use of Guava Hasher. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8216/2/fe/

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 3: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.

2017-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 ) Change subject: IMPALA-6011: Remove use of Guava Hasher. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8216/1/fe/s

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 2: (7 comments) Thanks

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: The build error seems to be: > 19:44:25 ] [

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables. (wip)

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. (wip) .. Patch Set 1: Hi Tim, As you suggested, I'm sharing wha

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables. (wip)

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8211 Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. (wip) .. IMPALA-5243: Speed up code gen for wide Avro tables. (wip

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 1: (1 comment) http://

[Impala-ASF-CR] Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8096 ) Change subject: Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: > P

[Impala-ASF-CR] Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8096 ) Change subject: Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: > P

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-29 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#11). Change subject: IMPALA-5908: Allow SET to unset modified query options. ...

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-29 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8100 to look at the new patch set (#4). Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. ...

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5990: Part 1: JNI-based LZ4 de/compression

2017-09-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8150 ) Change subject: IMPALA-5990: Part 1: JNI-based LZ4 de/compression .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/81

[Impala-ASF-CR] IMPALA-5986: Correct set-option logic to recognize digits in names.

2017-09-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8166 ) Change subject: IMPALA-5986: Correct set-option logic to recognize digits in names. .. Patch Set 1: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 3: (10 comments) The UI feels good

[Impala-ASF-CR] IMPALA-5986: Correct set-option logic to recognize digits in names.

2017-09-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8166 ) Change subject: IMPALA-5986: Correct set-option logic to recognize digits in names. .. Patch Set 1: Code-Review+1 (1 comment) I'm f

[Impala-ASF-CR] IMPALA-5990: Part 1: JNI-based LZ4 de/compression

2017-09-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8150 ) Change subject: IMPALA-5990: Part 1: JNI-based LZ4 de/compression .. Patch Set 1: It looks like libraries like https://github.com/lz4

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Hello Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8100 to look at the new patch set (#3). Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Hello Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8100 to look at the new patch set (#2). Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .

[Impala-ASF-CR] IMPALA-5940. Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940. Avoid log spew by using Status::Expected. .. Patch Set 1: (1 comment) Thanks for the review! I added i

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 10: (8 comments) I filed https://issues.apache.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-25 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#10). Change subject: IMPALA-5908: Allow SET to unset modified query options. ...

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 1: Code-Review+1 This seems fine to me. Have we filed a

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: This passes tests, so is ready to be reviewed. -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#9). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5940. Avoid log spew by using Status::Expected.

2017-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/8100 Change subject: IMPALA-5940. Avoid log spew by using Status::Expected. .. IMPALA-5940. Avoid log spew by using Status::Expected. In IM

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 8: I'm still re-running tests. The Overlay function wasn't setting __is_set when it shoul

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#8). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 7: I'm still fighting through some test failures in this latest iteration. -- To view, v

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8070/7/be/src/service/impala-server.h

[Impala-ASF-CR] Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 1: This is a re-run of http://gerrit.cloudera.or

[Impala-ASF-CR] Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/8096 Change subject: Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Re-apply: IMPALA-5

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#7). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8035/3/common/yarn-extras/pom.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 5: Following through on the layering (process options, pool defaults, session options, an

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/filter-context.cc File

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 6: Code-Review-1 Dan pointed out an important point that unsetting might mean that we shou

[Impala-ASF-CR] Revert "IMPALA-5589: change "set" in impala-shell to show empty string for unset query options"

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/8087 Change subject: Revert "IMPALA-5589: change "set" in impala-shell to show empty string for unset query options" .. Revert "IMPALA-5589

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#6). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#5). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 5: How embarrassing! New patch uploaded. The relevant test passes now. -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 4: I'm not an expert at reading these yet, but I think it's complaining about the followi

[Impala-ASF-CR] IMPALA-5211: Simplifying nullif conditional.

2017-09-15 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#9). Change subject: IMPALA-5211: Simplifying nullif conditional. .. IMPALA-5211: S

[Impala-ASF-CR] IMPALA-5211: Simplifying nullif conditional.

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying nullif conditional. .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/7829/7/fe/src/test/java/org/apache/impala/analys

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 3: Code-Review+1 Carry'ing Tim's +1. -- To view, visit http://gerrit.cloudera.org:8080/8

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8070/2/be/src/service/query-options.h

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#3). Change subject: IMPALA-5908: Allow SET to unset modified query options. ..

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 2: Can this be tested in tests/shell/test_shell_interactive.py? -- To view, visit http://

[Impala-ASF-CR] IMPALA-5211: Simplifying nullif conditional.

2017-09-14 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#8). Change subject: IMPALA-5211: Simplifying nullif conditional. .. IMPALA-5211: S

[Impala-ASF-CR] IMPALA-5211: Simplifying nullif conditional.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying nullif conditional. .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/7829/7/fe/src/main/java/org/apache/impala/rewrit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). Change subject: IMPALA-5908: Allow SET to unset modified query options. .. IMPALA-5908: Allow SET to unset modified query options. The query 'SET =""' will now unset option, rev

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8070/1//COMMIT_MSG Commit Message: L

[Impala-ASF-CR] IMPALA-5926: Avoid printing expensive stack when closing a session

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5926: Avoid printing expensive stack when closing a session .. Patch Set 3: I took the liberty of trawling through some large impalad log files to see

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/8070 Change subject: IMPALA-5908: Allow SET to unset modified query options. .. IMPALA-5908: Allow SET to unset modified query options. The

[Impala-ASF-CR] IMPALA-5905: build-all-flag-combinations addendum

2017-09-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5905: build-all-flag-combinations addendum .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8061 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-5211: Simplifying nullif conditional.

2017-09-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying nullif conditional. .. Patch Set 7: I should also mention that previous commit messages referred to "ifnull" where they should have r

[Impala-ASF-CR] IMPALA-5211: Simplifying nullif conditional.

2017-09-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying nullif conditional. .. Patch Set 6: (17 comments) Thanks for the review. I've addressed all of the comments except moving around Tes

[Impala-ASF-CR] IMPALA-5211: Simplifying nullif conditional.

2017-09-13 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#7). Change subject: IMPALA-5211: Simplifying nullif conditional. .. IMPALA-5211: S

[Impala-ASF-CR] IMPALA-5905: add script for all-build-options job

2017-09-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5905: add script for all-build-options job .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8043/1/bin/all-build-options.sh File bin/al

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8038/1//COMMIT_MSG Commi

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8014/2/fe/src/main/c

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for some scratch failures.

2017-09-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). Change subject: IMPALA-3642: Adding backend addresses to error statuses for some scratch failures. .. IMPALA-3642: Adding backend addresses to error statuses for some scratch f

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.

2017-09-11 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#6). Change subject: IMPALA-5211: Simplifying ifnull conditional. .. IMPALA-5211: S

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: For this options serialization question, we have a C++ implementation of "

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.

2017-09-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull conditional. .. Patch Set 5: Alex, Thanks for your reviews. I put together a new diff which ties to do the re-write. The unit

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.

2017-09-06 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#5). Change subject: IMPALA-5211: Simplifying ifnull conditional. .. IMPALA-5211: S

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 4: My apologies! I failed to run some of the tests in my n

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7886 to look at the new patch set (#4). Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 4: -Code-Review (2 comments) Thanks for the review, Alex! I'll update nullif() to be

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: Code-Review+1 Carry of Dan's +1. -- To view, visit ht

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7886/

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7886 to look at the new patch set (#3). Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 4: Code-Review+1 Carry +1 from Matt Jacobs. -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#4). Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) ..

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7829/3/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7943/1/be/src/runtime/co

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-08-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. IMPALA-5589: change "set" in impala-shell to show empty string for unse

[Impala-ASF-CR] IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options

2017-08-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7886/

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh File bin/impala-confi

[Impala-ASF-CR] IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options

2017-08-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/7886 Change subject: IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options .. IMPALA-5589: change "set" in

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#3). Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) This commit simplifies the following

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 2: (14 comments) http://gerrit.cloudera.org:8080/#/c/7829/2/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7834 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 1: (1 comment) Looks like there are some stray comments? http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) This commit simplifies the following

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/7829 Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. IMPALA-5211: Simplifying conditionals (istrue, nullif,

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7781/6/fe/src/mai

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Philip Zeyliger (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7781 to look at the new patch set (#7). Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 5: (1 comment) I also ran the "jococo" coverage tool on the java file

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-24 Thread Philip Zeyliger (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7781 to look at the new patch set (#6). Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/7781/4/fe/src/mai

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-24 Thread Philip Zeyliger (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7781 to look at the new patch set (#5). Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for scratch failures.

2017-08-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-3642: Adding backend addresses to error statuses for scratch failures. .. Patch Set 1: I'm looking for feedback on whether we have more explicit ways t

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for scratch failures.

2017-08-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/7816 Change subject: IMPALA-3642: Adding backend addresses to error statuses for scratch failures. .. IMPALA-3642: Adding backend addresses

[Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.

2017-08-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/7803 Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration. .. IMPALA-5836: Improvements to Eclipse frontend configura

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-23 Thread Philip Zeyliger (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7781 to look at the new patch set (#4). Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

<    1   2   3   >