[Impala-ASF-CR] IMPALA-1144: Fix exception when CTRL+C on running query in Impala-shell

2017-11-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when CTRL+C on running query in Impala-shell .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 8: > Patch Set 6: > > Well, that's what I get for being clev

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 5: (1 comment) Thanks for starting that gerrit-verify-dryru

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 4: Code-Review+2 (1 comment) > Patch Set 4: > > (1 comment)

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8456/4/

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8456/2/b

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8456/2/

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8354/2/tes

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8354/2/tes

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8354/1/test

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8354/2/test

[Impala-ASF-CR](asf-site) Remove old leftover, unmaintained parts of website.

2017-10-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8234 ) Change subject: Remove old leftover, unmaintained parts of website. .. Patch Set 1: Code-Review+2 Seems reasonable to me. -- To view, v

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 6: Tim, can you provide more context

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 5: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-19 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 4: This was submitted by hand. I accidentally had clicked "dry_run" in je

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-19 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8081 To u

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-19 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 3: Started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1234/ --

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: Code-Review+2 In order to get this change in, you'll need a committer to ru

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7891/3/tests/query_test/te

[Impala-ASF-CR] IMPALA-5617: Include full workload name in tpch nested query filenames

2017-08-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7891/3/tests/query_test/te

[Impala-ASF-CR] IMPALA-5617: Rename tpch nested query files per pattern

2017-08-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5617: Rename tpch_nested query files per pattern .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7891/2/tests/query_test/test_tpch_nested_q

[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py

2017-08-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py .. Patch Set 4: Code-Review+2 Rebase only, carrying +2. -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py

2017-08-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py .. Patch Set 4: I was stupid. I specifically tested my patch against the RELEASE build, which did

[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py

2017-08-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py .. IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py Make the call to format() compat

[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py

2017-08-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py .. IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py Make the call to format() compat

[Impala-ASF-CR] Fix string format() syntax to in test scanners fuzz.py

2017-08-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/7761 Change subject: Fix string format() syntax to in test_scanners_fuzz.py .. Fix string format() syntax to in test_scanners_fuzz.py Make the

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7518 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/2/tests/query_test/test_insert_parquet.py File t

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/test_insert_parquet.py File t

[Impala-ASF-CR] IMPALA-3496: stress test: print version info

2017-07-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3496: stress test: print version info .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7501 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-4868: Disable flaky TestRequestPoolService test

2017-07-19 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4868: Disable flaky TestRequestPoolService test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7466 To unsubscribe, visit

[native-toolchain-CR] Prevent leaking AWS credentials to the log.

2017-07-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Prevent leaking AWS credentials to the log. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7391 To unsubscribe, visit http://gerr

[native-toolchain-CR] Prevent leaking AWS credentials to the log.

2017-07-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Prevent leaking AWS credentials to the log. .. Patch Set 2: Code-Review+1 Lars asked me to look at this as well, and I feel the same way. Tim Wood is better at b

[Impala-ASF-CR] Complete guide to important environment variables for build, test, and mini-cluster operations.

2017-07-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7

[Impala-ASF-CR] Complete guide to important environment variables for build, test, and mini-cluster operations.

2017-07-05 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 1: (2 comments) Whether it's a .txt file in the code

[Impala-ASF-CR] IMPALA-5281: stress test: introduce stricter pass guidelines

2017-06-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5281: stress test: introduce stricter pass guidelines .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7282 To unsubscribe,

[Impala-ASF-CR] IMPALA-5281: stress test: introduce stricter pass guidelines

2017-06-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5281: stress test: introduce stricter pass guidelines .. Patch Set 1: >From a code perspective, it's straightforward. But Matt may have more stress >test k

[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden

2017-06-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden .. Patch Set 3: Code-Review+2 Rebase only. Carrying +2. -- To view, visit http://gerrit.cloudera.org:8080/719

[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden

2017-06-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7197/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden

2017-06-20 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden .. IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden Tested by exporting a different IMPALA_LOGS_DIR path, then

[Impala-ASF-CR] IMPALA-5517: Allow default IMPALA LOGS DIR to be explicity overridden

2017-06-15 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/7197 Change subject: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden .. IMPALA-5517: Allow default IMPALA_LOGS_DIR to be

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7115 To uns

[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop

2017-06-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7159 To unsubscri

[Impala-ASF-CR] IMPALA-5263: test infra: support CA bundles with secure clusters

2017-06-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7152/2/tests/compar

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. .. Patch Set 3: Code-Review+2 Removed one blank # comment. Carrying +2 from Alex. -- To vie

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7046/2/tests/query_test/test

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7046 to look at the new patch set (#3). Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. ..

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. .. IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. This patch includes a c

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. Patch Set 1: It might be a bug in Hive or beeline? Beeline is throwing a WRITE access

[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls

2017-06-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7107 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7046/1/tests/query_test

[Impala-ASF-CR] IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store sales

2017-06-05 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store_sales .. Abandoned Abandoning. Part of this change is not relevant anymore. I'll open a new review for the p

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-01 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/7046 Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. IMPALA-5413: Skip test_seq_writer_hive_compati

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6818 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Patch Set 1: Code-Review-1 -- To view, visit http://gerrit.cloudera.org:8080/6989 To unsubscribe,

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Patch Set 1: s/for that file/for that module/ -- To view, visit http://gerrit.cloudera.org:8080/6

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Patch Set 1: So, I'm a little concerned about this. The datetime being installed here isn't the st

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6818/4/bin/single_node_perf_run.py File b

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 7: Code-Review+1 Python test code looks OK to me. -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6894/6/tests/data_errors/test_dat

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6910/2/tests/util/adls_util.py File tests/ut

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6910/2/tests/util/adls_util.py File tests/u

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6910/2/tests/common/impala_test_suite.py Fi

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 2: (1 comment) Jim, this is mainly just to confirm that this review request has been noted.

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py File tes

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools-scm

2017-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools-scm .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6599 To unsubscribe, visit http://gerri

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: > unless we feel we should pin the package to 1.15.0 anyways We could pin to 1.15.4 as our known workin

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: > Do we still want to pin this dependency, or should we abandon this change? My opinion is that pinning

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: I'm totally in agreement. -- To view, visit http://gerrit.cloudera.org:8080/6579 To unsubscribe

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: Again, just wanted to reiterate that I think if this is the quickest path to unlocking the repo

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: There may well be some historical context that I'm missing here, or just some complication that I

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: I have to confess, I've long felt like there's lot of over engineering in the way that we set up

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6579/1/infra/python/deps/pip_download.py File in

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Code-Review+1 I agree -- I don't see any downsides to scoping the connection fixture at test leve

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: Sure, for the sake of consistency, I'm OK with this change. There are actually two places where this occurs.

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: With pytest fixtures, I don't think order matters. -- To view, visit http://gerrit.cloudera.org:8080/6228 T

[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.

2017-02-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/6144 Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network. .. IMPALA-4987: Skip test_rows_availability when tes

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-02-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 2: # E101 - Reinden

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: The changes here seem reasonable. Is there a plan to migrate other HTML tables to DataTables? (E.g., Queries, Query Loc

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 3: Code-Review+1 Agreed. -- To view, visit http://gerrit.cloudera.org:8080/5995 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 3: (1 comment) So, I believe that all of the pages still point to the old blog site. This patch doesn't seem to addres

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6002/1/bin/ru

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md Fil

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5995/1//COMMIT_MSG Commit Message: PS1, Line 7: A blog post about

[Impala-ASF-CR] IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars

2017-02-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5978 To

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 8: Pre-review build: http://jenkins.impala.io:8080/view/Utility/job/pre-review-test/18

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-08 Thread David Knupp (Code Review)
Hello Michael Brown, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5877 to look at the new patch set (#8). Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5877/7/tests/conftest.py File tests

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 7: Code-Review+1 Carrying +1. -- To view, visit http://gerrit.cloudera.org:8080/5877

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread David Knupp (Code Review)
Hello Michael Brown, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5877 to look at the new patch set (#7). Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5877/6//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 6: Pre-review build: http://jenkins.impala.io:8080/view/Utility/job/pre-review-test/17

  1   2   3   >