[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 1: > MJ, do you prefer one option wi

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message: PS9

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message: PS9

[Impala-ASF-CR] IMPALA-5920: addendum - add missing RAT check

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: addendum - add missing RAT check .. Patch Set 2: Thanks for fixing this. @Alex The test job had a known spurious failure cleaning up the workspace

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 7: > The rat-check job actually failed because of a file introduced here > - it br

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. IMPALA-5920: Remove admission control dependency on YARN RM jar Impala's admission c

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 6: Verified+1 The job actually passed, cleaning up the workspace failed 21:19:36 E

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 6: Code-Review+2 I'll count the +1s from Tim and Zach, and no further comments from

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 5: (2 comments) Thanks for the detailed review, Zach. If nobody has further feedba

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8035 to look at the new patch set (#5). Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 4: (13 comments) Thanks, Zach - some good observations. I made a bunch of the chan

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8035 to look at the new patch set (#4). Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8035/3/common/yarn-extras/pom.x

[Impala-ASF-CR] IMPALA-5905: build-all-flag-combinations addendum

2017-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5905: build-all-flag-combinations addendum .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8061 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8035/2//COMMIT_MSG Commit Mess

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. IMPALA-5920: Remove admission control dependency on YARN RM jar Impala's admission controller r

[Impala-ASF-CR] [DOCS] Explain Boost setting needed for 96-bit timestamps

2017-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7983/2/docs/shared/impala_common.xml

[Impala-ASF-CR] Bump Kudu version to 3f49724

2017-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 3f49724 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8040 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. IMPALA-5920: Remove admission control dependency on YARN RM jar Impala's admission controller r

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN resourcemanager

2017-09-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/8035 Change subject: IMPALA-5920: Remove admission control dependency on YARN resourcemanager .. IMPALA-5920: Remove admission control depen

[native-toolchain-CR] Bump Kudu version to 3f49724

2017-09-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 3f49724 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8028 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] Bump Kudu version to a71ecfd

2017-09-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/8000 Change subject: Bump Kudu version to a71ecfd .. Bump Kudu version to a71ecfd Change-Id: Ie23d852f0d630f9484d8ae4f772af6bba13ea24f --- M

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7910/3//COMMIT_MSG Commit Message: PS3, Line 22: 1.

[native-toolchain-CR] Bump Kudu version to a71ecfd

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to a71ecfd .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7975 To unsubscribe, visit http://gerrit.cloudera.org

[native-toolchain-CR] Bump Kudu version to a71ecfd

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to a71ecfd .. Bump Kudu version to a71ecfd Change-Id: I4fb177b80f6c193af3f6b6bf9d7b205ab31d2f3e --- M buildall.sh 1 file changed, 1 i

[native-toolchain-CR] Bump Kudu version to a71ecfd

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7975 Change subject: Bump Kudu version to a71ecfd .. Bump Kudu version to a71ecfd Change-Id: I4fb177b80f6c193af3f6b6bf9d7b205ab31d2f3e --- M

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 2: Please fix the typos before submitting -- To view, vis

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5891: fix PeriodicCounterUpdater initialization

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7942 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 3: (1 comment) The fact that we found 3 issues in this code (after IMPALA-3894) makes me nervous. I di

[Impala-ASF-CR] IMPALA-5871: KuduPartitionExpr incorrectly handles its child types

2017-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5871: KuduPartitionExpr incorrectly handles its child types .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7922/1//COMM

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 3: Code-Review+1 (3 comments) Looks good, thanks! Just a few small things. Clearly Al

[Impala-ASF-CR] Bump Kudu version to 1c70e5d

2017-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7903 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh File bin/impala-config

[Impala-ASF-CR] IMPALA-5863: Include-what-you-use for Kudu client

2017-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5863: Include-what-you-use for Kudu client .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7872 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-5854: Update external hadoop versions

2017-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5854: Update external hadoop versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh File bin/impala-config

[Impala-ASF-CR] IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options

2017-08-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7886/1

[Impala-ASF-CR] Include-what-you-use for Kudu client

2017-08-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Include-what-you-use for Kudu client .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7872/2//COMMIT_MSG Commit Message: Line 7: Include-what-y

[Impala-ASF-CR] IMPALA-5857: avoid invalid free of hedged read metrics

2017-08-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5857: avoid invalid free of hedged read metrics .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7885 To unsubscribe, vis

[Impala-ASF-CR] Bump Kudu version to 1c70e5d

2017-08-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 1: (1 comment) does the code not compile without the header changes? It's best to separate code changes from toolcha

[Impala-ASF-CR] IMPALA-5855: reserve enough memory for preaggs

2017-08-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5855: reserve enough memory for preaggs .. Patch Set 2: I think you may need to update test admission-reject-min-reservation.test now too, since that we

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7861/1/common/thrift/generate_error_

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error .. Patch Set 1: Code-Review+1 Looks more helpful to me, thanks -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 6: Code-Review+2 Agg memory changed in the test cases after Tim's recent patch for pre-agg

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-28 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#6). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ..

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/7829/2/fe/src/main/java/org/apac

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7855 To unsubscribe, visit http://gerrit.cloudera.

[native-toolchain-CR] Bump Kudu version to 1c70e5d

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1c70e5d .. Patch Set 2: > (1 comment) Ah, that's on Cloudera's github mirror. Let's choose the Apache repo. -- To view, visit http://ger

[native-toolchain-CR] Bump Kudu version to 22a19d9

2017-08-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 22a19d9 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7855/1//COMMIT_MSG Commit Message: PS1, Line 7: 22a19d9 where is

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#5). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMP

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#4). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMP

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7834/3/testdata/workloads/functional-que

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7834 to look at the new patch set (#3). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMP

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7834/2/be/src/scheduling/admission-contr

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7834/2/be/src/scheduling/admission-contr

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7834/1/tests/custom_cluster/test_admissi

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMPALA-5838: Improve errors on AC buffer mem rejection The error message returned when a query is reject

[Impala-ASF-CR] IMPALA-5838: Improve errors on AC buffer mem rejection

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7834 Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection .. IMPALA-5838: Improve errors on AC buffer mem rejection The er

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7781/6/testdata/wor

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7781/5/fe/src/test/

[Impala-ASF-CR] IMPALA-5799: Kudu DML can crash if schema has changed

2017-08-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7688 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7787 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7560 To un

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 4: (2 comments) > > Matt: Might be nice to have some tests like those

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queri

[Impala-ASF-CR] IMPALA-5784: Separate planner and user set query options in profile

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784: Separate planner and user set query options in profile .. Patch Set 4: Code-Review+1 Great, thanks! -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/7560/8/fe/src/test/java/o

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7560/8/fe/src/test/java/org

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7721/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7721/3/be/src/service/cli

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7721/3/be/src/service/cli

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 3: Might be nice to have some tests like those added in this patch whic

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7721/3/be/src/service/cli

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7640 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7640/9/be/src/runtime/disk-io-mgr-handl

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile .. Patch Set 1: > > > > (1 comment) > > > Relying to Dan and Balasz: > > > > > > It's a

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile .. Patch Set 1: > > > (1 comment) > > Relying to Dan and Balasz: > > > > It's actually

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7640 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5798: ASAN use-after-poison in Parquet decoder

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5798: ASAN use-after-poison in Parquet decoder .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7769 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7640 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile .. Patch Set 1: > (1 comment) Relying to Dan and Balasz: It's actually hard to determine

[Impala-ASF-CR] IMPALA-5799: Kudu DML can crash if schema has changed

2017-08-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7688/3/be/src/exec/kudu-table-sink.cc Fil

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 10: Code-Review+2 String msg changed and an existing test needed to be updated -- To view,

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#10). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements ...

[Impala-ASF-CR] IMPALA-5799: Kudu DML can crash if schema has changed

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7688/3/be/src/exec/kudu-table-sink.cc Fi

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#9). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements ...

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7678/8/be/src/runtime/bufferpool/reservat

[Impala-ASF-CR] Bump Kudu version to 44a820b

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7767 Change subject: Bump Kudu version to 44a820b .. Bump Kudu version to 44a820b Change-Id: I1e86ce13d1fdc73487b8067f3670ee73b9269366 --- M

[native-toolchain-CR] Bump Kudu version to 44a820b

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 44a820b .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7755 To unsubscribe, visit http://gerrit.cloudera.org

[native-toolchain-CR] Bump Kudu version to 44a820b

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 44a820b .. Bump Kudu version to 44a820b Change-Id: I599843a7c230ec75699b9f236f9f0a97949278b9 --- M buildall.sh 1 file changed, 1 i

[native-toolchain-CR] Bump Kudu version to 44a820b

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7755 Change subject: Bump Kudu version to 44a820b .. Bump Kudu version to 44a820b Change-Id: I599843a7c230ec75699b9f236f9f0a97949278b9 --- M

[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7380/8/be/

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 8: looks like test_spilling.py will still require a lot of changes -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5799: Kudu DML can crash if schema has changed

2017-08-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/7688/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-5352: Age out unused file handles from the cache

2017-08-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7640/3/be/src/runtime/disk-io-mgr-hand

[Impala-ASF-CR] IMPALA-5504: Fix TupleIsNullPredicate evaluation.

2017-08-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5504: Fix TupleIsNullPredicate evaluation. .. Patch Set 1: Code-Review+2 Nice catch -- To view, visit http://gerrit.cloudera.org:8080/7737 To unsubscri

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#8). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements ...

  1   2   3   4   5   6   7   8   9   10   >