[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 8: (9 comments)

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 7: (5 comments)

[kudu-CR] [master] extra tests for the placement policy

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11562 ) Change subject: [master] extra tests for the placement policy .. Patch Set 1: Verified+1 Unrelated flake in

[kudu-CR] [master] extra tests for the placement policy

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11562 ) Change subject: [master] extra tests for the placement policy .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [master] extra tests for the placement policy

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11562 Change subject: [master] extra tests for the placement policy .. [master] extra tests for the placement policy Added a few more tests

[kudu-CR] Fix Pandas Tests in Python 2.6 client

2018-10-01 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 ) Change subject: Fix Pandas Tests in Python 2.6 client .. Patch Set 3: Yep, makes sense -- To view, visit

[kudu-CR] Fix Pandas Tests in Python 2.6 client

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 ) Change subject: Fix Pandas Tests in Python 2.6 client .. Patch Set 3: > Patch Set 3: > > You could flip the argument here and ask why

[kudu-CR] [test] Move BaseKuduTest to a Junit Rule

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11547 ) Change subject: [test] Move BaseKuduTest to a Junit Rule .. Patch Set 6: (1 comment) > I agree we could make the rule more flexible to

[kudu-CR] Fix Pandas Tests in Python 2.6 client

2018-10-01 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 ) Change subject: Fix Pandas Tests in Python 2.6 client .. Patch Set 3: You could flip the argument here and ask why would it be too

[kudu-CR] [test] Migrate the Spark tests to use the new KuduRule

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11548 ) Change subject: [test] Migrate the Spark tests to use the new KuduRule .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 ) Change subject: [tools] ksck checksums: Add KsckChecksummer class .. Patch Set 4: (3 comments)

[kudu-CR] [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11554 to look at the new patch set (#3). Change subject: [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11498 to look at the new patch set (#5). Change subject: [tools] ksck checksums: Add KsckChecksummer class

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 7: (1 comment)

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-01 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 7: (1 comment)

[kudu-CR] Fix Pandas Tests in Python 2.6 client

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 ) Change subject: Fix Pandas Tests in Python 2.6 client .. Patch Set 3: (7 comments) I guess I don't really understand; requirements.txt

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 7: (6 comments) Looks good, but needs support for

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 ) Change subject: [tools] ksck checksums: Add KsckChecksummer class .. Patch Set 4: (2 comments)

[kudu-CR] [test] Move BaseKuduTest to a Junit Rule

2018-10-01 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11547 to look at the new patch set (#6). Change subject: [test] Move BaseKuduTest to a Junit Rule

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11498 to look at the new patch set (#4). Change subject: [tools] ksck checksums: Add KsckChecksummer class

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#8). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11554 to look at the new patch set (#2). Change subject: [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets

[kudu-CR] [test] Migrate the Spark tests to use the new KuduRule

2018-10-01 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11548 to look at the new patch set (#4). Change subject: [test] Migrate the Spark tests to use the new KuduRule

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 6: (7 comments)

[kudu-CR] [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11554 ) Change subject: [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets .. Patch Set 1: (10 comments)

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 ) Change subject: [tools] ksck checksums: Add KsckChecksummer class .. Patch Set 2: (11 comments)

[kudu-CR] Fix Pandas Tests in Python 2.6 client

2018-10-01 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Jordan Birdsell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11557 to look at the new patch set (#3). Change subject: Fix Pandas Tests in Python 2.6 client .. Fix

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 ) Change subject: [tools] ksck checksums: Add KsckChecksummer class .. Patch Set 3: (7 comments)

[kudu-CR] [test] Migrate the Spark tests to use the new KuduRule

2018-10-01 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11548 to look at the new patch set (#3). Change subject: [test] Migrate the Spark tests to use the new KuduRule

[kudu-CR] Fix Pandas Tests in Python 2.6 client This is to resolve issues with the pandas tests in the kudu-python client. Pandas must be installed in the virtualenv for python2.6 for test but we don'

2018-10-01 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11557 to look at the new patch set (#2). Change subject: Fix Pandas Tests in Python 2.6 client This is to resolve issues with the pandas tests in the kudu-python client. Pandas must be

[kudu-CR] Fix Pandas Tests in Python 2.6 client\n\n This is to resolve issues with the pandas tests in the kudu-python\n client. Pandas must be installed in the virtualenv for python2.6\n for test but

2018-10-01 Thread Anonymous Coward (Code Review)
a...@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11557 Change subject: Fix Pandas Tests in Python 2.6 client\n\n This is to resolve issues with the pandas tests in the kudu-python\n client. Pandas must be installed in the virtualenv for python2.6\n for

[kudu-CR] [test] Move BaseKuduTest to a Junit Rule

2018-10-01 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11547 to look at the new patch set (#4). Change subject: [test] Move BaseKuduTest to a Junit Rule

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 6: (4 comments) A couple of nits, otherwise LGTM.

[kudu-CR] [test] Migrate the Spark tests to use the new test rule

2018-10-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11548 ) Change subject: [test] Migrate the Spark tests to use the new test rule .. Patch Set 1: (1 comment)

[kudu-CR] [test] Migrate the Spark tests to use the new test rule

2018-10-01 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11548 to look at the new patch set (#2). Change subject: [test] Migrate the Spark tests to use the new test rule

[kudu-CR] [spark] Add KuduReadOptions to encapsulate the read parameters

2018-10-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11537 ) Change subject: [spark] Add KuduReadOptions to encapsulate the read parameters .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 13: Verified+1 Precommit failure is KUDU-2576. -- To view,

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2245 Graceful leadership transfer .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit

[kudu-CR] [test] Move BaseKuduTest to a Junit Rule

2018-10-01 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11547 to look at the new patch set (#2). Change subject: [test] Move BaseKuduTest to a Junit Rule

[kudu-CR] [test] Move BaseKuduTest to a Junit Rule

2018-10-01 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11547 to look at the new patch set (#3). Change subject: [test] Move BaseKuduTest to a Junit Rule

[kudu-CR] [test] Move BaseKuduTest to a Junit Rule

2018-10-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11547 ) Change subject: [test] Move BaseKuduTest to a Junit Rule .. Patch Set 1: (21 comments) I agree we could make the rule more flexible to

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-01 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11422 to look at the new patch set (#7). Change subject: [location_awareness] Add location info in ksck report

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 6: The master can't register the new tablet server

[kudu-CR] [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11554 Change subject: [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets .. [tools] KUDU-2179: Have ksck not use a

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#7). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11498 to look at the new patch set (#3). Change subject: [tools] ksck checksums: Add KsckChecksummer class

[kudu-CR] [tools] Fix bug in CheckCompleteMove

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11508 ) Change subject: [tools] Fix bug in CheckCompleteMove .. [tools] Fix bug in CheckCompleteMove It was possible for the

[kudu-CR] [tools] Fix bug in CheckCompleteMove

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11508 ) Change subject: [tools] Fix bug in CheckCompleteMove .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Upgrade Dependencies

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11541 ) Change subject: [Java] Upgrade Dependencies .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11541 To

[kudu-CR] [Java] Upgrade Dependencies

2018-10-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11541 ) Change subject: [Java] Upgrade Dependencies .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11541/2//COMMIT_MSG Commit

[kudu-CR] [Java] Upgrade Dependencies

2018-10-01 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11541 to look at the new patch set (#3). Change subject: [Java] Upgrade Dependencies .. [Java] Upgrade

[kudu-CR] [Java] Upgrade Dependencies

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11541 ) Change subject: [Java] Upgrade Dependencies .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11541/2//COMMIT_MSG Commit

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-01 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#13). Change subject: KUDU-2245 Graceful leadership transfer

[kudu-CR] [tools] Fix bug in CheckCompleteMove

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11508 ) Change subject: [tools] Fix bug in CheckCompleteMove .. Patch Set 1: (2 comments)

[kudu-CR] [tools] Fix bug in CheckCompleteMove

2018-10-01 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11508 to look at the new patch set (#2). Change subject: [tools] Fix bug in CheckCompleteMove .. [tools]

[kudu-CR] [test] Migrate the Spark tests to use the new KuduRule

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11548 ) Change subject: [test] Migrate the Spark tests to use the new KuduRule .. Patch Set 1: (1 comment)

[kudu-CR] [test] Move BaseKuduTest to a Junit Rule

2018-10-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11547 ) Change subject: [test] Move BaseKuduTest to a Junit Rule .. Patch Set 1: (21 comments) I think composing RetryRule within KuduRule

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-01 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 6: Hi Will & Alexey, do you guys have ideas about

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-10-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 ) Change subject: [tools] ksck checksums: Add KsckChecksummer class .. Patch Set 2: (4 comments)

[kudu-CR] WIP [rebalancer] location-aware rebalancer (part 1/3)

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11549 Change subject: WIP [rebalancer] location-aware rebalancer (part 1/3) .. WIP [rebalancer] location-aware rebalancer (part 1/3) Added