[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/11754/9//COMMIT_MSG

[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 10: (1 comment)

[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11754 to look at the new patch set (#10). Change subject: authz: verify tokens on writes

[kudu-CR] [util] change return type of Cache::Allocate()

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12876 ) Change subject: [util] change return type of Cache::Allocate() .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 6: (2 comments) Whoops, it seems I missed a typo in the commit message

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 7: (1 comment)

[kudu-CR] [util] change return type of Cache::Allocate()

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12876 ) Change subject: [util] change return type of Cache::Allocate() .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#7). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] [util] change return type of Cache::Allocate()

2019-03-27 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12876 to look at the new patch set (#2). Change subject: [util] change return type of Cache::Allocate()

[kudu-CR] ksck remote-test: deflake some more

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12853 ) Change subject: ksck_remote-test: deflake some more .. ksck_remote-test: deflake some more Apparently fixing KUDU-2748 wasn't

[kudu-CR] java: add support for flaky test reporting

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#5) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. java: add support for flaky

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 6: (1 comment)

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-03-27 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12872 to look at the new patch set (#2). Change subject: java: ensure KuduTestHarness or RetryRule in every test

[kudu-CR] java: round out log4j.properties in all modules

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12873 ) Change subject: java: round out log4j.properties in all modules .. java: round out log4j.properties in all modules These modules

[kudu-CR] java: fix tests that use ExpectedException

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12875 ) Change subject: java: fix tests that use ExpectedException .. java: fix tests that use ExpectedException There's a weird

[kudu-CR] test result server: allow for longer test names

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12874 ) Change subject: test_result_server: allow for longer test names .. test_result_server: allow for longer test names Some Java

[kudu-CR] java: add support for flaky test reporting

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Patch Set 4: (12 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#6). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 5: (2 comments)

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. Patch Set 1: > I thought about doing this when the RetryRule

[kudu-CR] [util] change signature of Cache::Allocate()

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12876 ) Change subject: [util] change signature of Cache::Allocate() .. Patch Set 1: (3 comments)

[kudu-CR] build: enable Java flaky test reporting

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 ) Change subject: build: enable Java flaky test reporting .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] java: add support for flaky test reporting

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Patch Set 4: (12 comments)

[kudu-CR] [util] change signature of Cache::Allocate()

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12876 Change subject: [util] change signature of Cache::Allocate() .. [util] change signature of Cache::Allocate() This patch changes the

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. Patch Set 1: I thought about doing this when the RetryRule

[kudu-CR] java: round out log4j.properties in all modules

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12873 ) Change subject: java: round out log4j.properties in all modules .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] test result server: allow for longer test names

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12874 ) Change subject: test_result_server: allow for longer test names .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] java: fix tests that use ExpectedException

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12875 ) Change subject: java: fix tests that use ExpectedException .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] java: add support for flaky test reporting

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Patch Set 4: I manually tested the following: - Reporting off. - Reporting

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-03-27 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Mike Percy, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12872 to review the following change. Change subject: java: ensure KuduTestHarness or RetryRule in every test

[kudu-CR] java: fix tests that use ExpectedException

2019-03-27 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Mike Percy, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12875 to review the following change. Change subject: java: fix tests that use ExpectedException

[kudu-CR] java: add support for flaky test reporting

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#4) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. java: add support for flaky

[kudu-CR] java: round out log4j.properties in all modules

2019-03-27 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Mike Percy, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12873 to review the following change. Change subject: java: round out log4j.properties in all modules

[kudu-CR] util: helper class for working with bitsets

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. util: helper class for working with bitsets Adds a templatized

[kudu-CR] [Java] Fix new errorprone warnings

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12871 ) Change subject: [Java] Fix new errorprone warnings .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] util: helper class for working with bitsets

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 7: Code-Review+2 (1 comment)

[kudu-CR] util: helper class for working with bitsets

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11754 To

[kudu-CR] util: helper class for working with bitsets

2019-03-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12866 to look at the new patch set (#7). Change subject: util: helper class for working with bitsets

[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11754 to look at the new patch set (#8). Change subject: authz: verify tokens on writes

[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 7: (4 comments)

[kudu-CR] util: helper class for working with bitsets

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 6: (3 comments)

[kudu-CR] util: helper class for working with bitsets

2019-03-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12866 to look at the new patch set (#6). Change subject: util: helper class for working with bitsets

[kudu-CR] [Java] Upgrade dependencies

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 ) Change subject: [Java] Upgrade dependencies .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12869 To

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 6: Verified+1 Failure is a known flaky. -- To view,

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [KUDU-1344] Part 1: cmake install for executables .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12847 To

[kudu-CR] [Java] Fix new errorprone warnings

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12871 Change subject: [Java] Fix new errorprone warnings .. [Java] Fix new errorprone warnings This patch fixes all the new error prone

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#6). Change subject: [KUDU-1344] Part 1: cmake install for executables

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 6: (1 comment)

[kudu-CR] WIP [util] introduce TTL cache

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 ) Change subject: WIP [util] introduce TTL cache .. Patch Set 4: Code-Review+1 (1 comment) LGTM, though Adar's question about

[kudu-CR] WIP [util] introduce TTL cache

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 ) Change subject: WIP [util] introduce TTL cache .. Patch Set 4: Also is this still WIP? Do you intend on adding the TTL-metric gauges in

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#5). Change subject: [KUDU-1344] Part 1: cmake install for executables

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#4). Change subject: [KUDU-1344] Part 1: cmake install for executables

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#3). Change subject: [KUDU-1344] Part 1: cmake install for executables

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 2: (1 comment)

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

2019-03-27 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 2: (11 comments)

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryAuthzCache .. Patch Set 5: (1 comment)

[kudu-CR] [Java] Upgrade dependencies

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 ) Change subject: [Java] Upgrade dependencies .. Patch Set 1: (1 comment)

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryAuthzCache .. Patch Set 5: (1 comment)

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryAuthzCache .. Patch Set 5: (24 comments)

[kudu-CR] util: helper class for working with bitsets

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 4: (4 comments)

[kudu-CR] [Java] Upgrade dependencies

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 ) Change subject: [Java] Upgrade dependencies .. Patch Set 1: (2 comments)

[kudu-CR] [Java] Upgrade dependencies

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12869 Change subject: [Java] Upgrade dependencies .. [Java] Upgrade dependencies Upgrades the Java dependencies and Gradle versions. Some

[kudu-CR] authz: verify tokens on writes

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 6: (4 comments) a few more nits: it seems I missed those last review

[kudu-CR] WIP [util] introduce TTL cache

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 ) Change subject: WIP [util] introduce TTL cache .. Patch Set 4: (5 comments)

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryAuthzCache .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 5: (2 comments)

[kudu-CR] gradle: upgrade gradle-animalsniffer-plugin

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12867 ) Change subject: gradle: upgrade gradle-animalsniffer-plugin .. gradle: upgrade gradle-animalsniffer-plugin This eliminates the

[kudu-CR] [java] Add private diff scan support

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12689 ) Change subject: [java] Add private diff scan support .. [java] Add private diff scan support Adds a private diff scan API to

[kudu-CR] gradle: upgrade gradle-animalsniffer-plugin

2019-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12867 ) Change subject: gradle: upgrade gradle-animalsniffer-plugin .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#5). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryAuthzCache .. Patch Set 5: (11 comments)

[kudu-CR] WIP [util] introduce TTL cache

2019-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 ) Change subject: WIP [util] introduce TTL cache .. Patch Set 3: (29 comments) http://gerrit.cloudera.org:8080/#/c/12825/3//COMMIT_MSG

[kudu-CR] WIP [util] introduce TTL cache

2019-03-27 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12825 to look at the new patch set (#4). Change subject: WIP [util] introduce TTL cache

[kudu-CR] WIP [master] introduced SentryAuthzCache

2019-03-27 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#5). Change subject: WIP [master] introduced SentryAuthzCache

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#4). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: (9 comments) yes, the impala catalog uses kudu java