[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 6: Code-Review+1 (2 comments) I think Mike should do

[kudu-CR] periodic: add one-shot timers

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 1: (1 comment)

[kudu-CR] periodic: add one-shot timers

2017-09-22 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8130 to review the following change. Change subject: periodic: add one-shot timers .. periodic: add

[kudu-CR] periodic: prevent runaway callback loops

2017-09-22 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8116 to look at the new patch set (#4). Change subject: periodic: prevent runaway callback loops

[kudu-CR] KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 ) Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API .. Patch Set 11: Code-Review+2 -- To view, visit

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 8: Verified+1 Overriding Jenkins, the latest run hit

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] Revert "[tests] fix flakiness in catalog manager tsk-itest"

2017-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8129 ) Change subject: Revert "[tests] fix flakiness in catalog_manager_tsk-itest" .. Revert "[tests] fix flakiness in

[kudu-CR] Revert "[tests] fix flakiness in catalog manager tsk-itest"

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8129 ) Change subject: Revert "[tests] fix flakiness in catalog_manager_tsk-itest" .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API

2017-09-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 ) Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API .. Patch Set 11: (1 comment)

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 5: (12 comments)

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 7: (5 comments)

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-22 Thread Adar Dembo (Code Review)
Hello Mike Percy, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8090 to look at the new patch set (#6). Change subject: KUDU-1125: issue one catalog write per tablet report

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#8). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic

[kudu-CR] Fix changes that were left out of KUDU-501 and /table template patches

2017-09-22 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8125 ) Change subject: Fix changes that were left out of KUDU-501 and /table template patches .. Fix changes that were left out of

[kudu-CR] Revert "[tests] fix flakiness in catalog manager tsk-itest"

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8129 ) Change subject: Revert "[tests] fix flakiness in catalog_manager_tsk-itest" .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. ( http://gerrit.cloudera.org:8080/8128 ) Change subject: Prioritize freeing memory over releasing WAL segments .. Abandoned Letting this go, I don't think this is an issue. -- To

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (6 comments)

[kudu-CR] KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 ) Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API .. Patch Set 11: (1 comment)

[kudu-CR] Revert "[tests] fix flakiness in catalog manager tsk-itest"

2017-09-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8129 to look at the new patch set (#2). Change subject: Revert "[tests] fix flakiness in catalog_manager_tsk-itest"

[kudu-CR] Revert "[tests] fix flakiness in catalog manager tsk-itest"

2017-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8129 Change subject: Revert "[tests] fix flakiness in catalog_manager_tsk-itest" .. Revert "[tests] fix flakiness in

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8128 ) Change subject: Prioritize freeing memory over releasing WAL segments .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API

2017-09-22 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7656 to look at the new patch set (#11). Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API

[kudu-CR] periodic: prevent runaway callback loops

2017-09-22 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8116 to look at the new patch set (#2). Change subject: periodic: prevent runaway callback loops

[kudu-CR] periodic: prevent runaway callback loops

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8116 ) Change subject: periodic: prevent runaway callback loops .. Patch Set 1: (2 comments)

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8128 ) Change subject: Prioritize freeing memory over releasing WAL segments .. Patch Set 1: (1 comment)

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. thirdparty: fix to protobuf bump Commit 57de48d bumped protobuf to 3.4.1 but

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8128 Change subject: Prioritize freeing memory over releasing WAL segments .. Prioritize freeing memory over releasing WAL segments

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. Patch Set 2: > Patch Set 1: > > > Patch Set 1: > > > > |I removed the patch level

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8115 to look at the new patch set (#2). Change subject: thirdparty: fix to protobuf bump

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: btw looks like a newer (C++11-y) version is available

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (2 comments)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (2 comments)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (9 comments)

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8127 Change subject: WIP: Pull StatusOr and related tests from protobuf .. WIP: Pull StatusOr and related tests from protobuf Needs

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 ) Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API .. Patch Set 9: (2 comments)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (6 comments)

[kudu-CR] Fix changes that were left out of KUDU-501 and /table template patches

2017-09-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8125 ) Change subject: Fix changes that were left out of KUDU-501 and /table template patches .. Patch Set 1: Affirmative -- To view,

[kudu-CR] Fix changes that were left out of KUDU-501 and /table template patches

2017-09-22 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8125 Change subject: Fix changes that were left out of KUDU-501 and /table template patches .. Fix changes that were left out of KUDU-501

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 5: (2 comments)

[kudu-CR] Add mustache template for /table

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8067 ) Change subject: Add mustache template for /table .. Patch Set 11: (2 comments)