[kudu-CR] Add missing test dependency for Hive tests

2018-10-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Patch Set 1: (2 comments)

[kudu-CR] Add missing test dependency for Hive tests

2018-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Patch Set 1: Tracked down a bit more info on what's going on here. The

[kudu-CR] Add missing test dependency for Hive tests

2018-10-18 Thread Dan Burkert (Code Review)
Hello Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11733 to review the following change. Change subject: Add missing test dependency for Hive tests

[kudu-CR] [location awareness] Add ts location to TSInfoPB

2018-10-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 ) Change subject: [location_awareness] Add ts location to TSInfoPB .. Patch Set 1: Hi Adar, thanks for the suggestion. But it seems

[kudu-CR] [location awareness] Add ts location to both client and internal client

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [location_awareness] Add ts location to both client and internal client .. Patch Set 4: (1 comment)

[kudu-CR] Add ExtractDouble method to JsonReader and small improvements

2018-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11728 ) Change subject: Add ExtractDouble method to JsonReader and small improvements .. Patch Set 1: (1 comment)

[kudu-CR] [tools] Add locate row support for unsupported key column types

2018-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11729 ) Change subject: [tools] Add locate_row support for unsupported key column types .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add ts location to both client and internal client

2018-10-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [location_awareness] Add ts location to both client and internal client .. Patch Set 2: (1 comment)

[kudu-CR] thread: show thread limit info when thread creation fails

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11726 ) Change subject: thread: show thread limit info when thread creation fails .. Patch Set 3: Code-Review+2 I'm still skeptical of the

[kudu-CR] [location awareness] Add ts location to both client and internal client

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [location_awareness] Add ts location to both client and internal client .. Patch Set 4: (1 comment)

[kudu-CR] thread: show thread limit info when thread creation fails

2018-10-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11726 ) Change subject: thread: show thread limit info when thread creation fails .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2038: Support bitmap indexing

2018-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11722 ) Change subject: KUDU-2038: Support bitmap indexing .. Patch Set 1: (6 comments) Didn't look through the code much yet, just left some

[kudu-CR] [tools] Add locate row support for unsupported key column types

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11729 ) Change subject: [tools] Add locate_row support for unsupported key column types .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [tools] Add locate row support for unsupported key column types

2018-10-18 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11729 to look at the new patch set (#2). Change subject: [tools] Add locate_row support for unsupported key column types

[kudu-CR] [tools] Add locate row support for unsupported key column types

2018-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11729 ) Change subject: [tools] Add locate_row support for unsupported key column types .. Patch Set 1: (1 comment)

[kudu-CR] [tools] Add locate row support for unsupported key column types

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11729 ) Change subject: [tools] Add locate_row support for unsupported key column types .. Patch Set 1: (1 comment)

[kudu-CR] Add ExtractDouble method to JsonReader and small improvements

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11728 ) Change subject: Add ExtractDouble method to JsonReader and small improvements .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add ts location to TSInfoPB

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 ) Change subject: [location_awareness] Add ts location to TSInfoPB .. Patch Set 1: Can you add a test? master-test has some examples of

[kudu-CR] Add ExtractDouble method to JsonReader and small improvements

2018-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11728 Change subject: Add ExtractDouble method to JsonReader and small improvements .. Add ExtractDouble method to JsonReader and small

[kudu-CR] [tools] Add locate row support for unsupported key column types

2018-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11729 Change subject: [tools] Add locate_row support for unsupported key column types .. [tools] Add locate_row support for unsupported key

[kudu-CR] Fix thrift operator< implementations

2018-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11693 ) Change subject: Fix thrift operator< implementations .. Patch Set 4: (1 comment)

[kudu-CR] thread: show thread limit info when thread creation fails

2018-10-18 Thread Mike Percy (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11726 to look at the new patch set (#3). Change subject: thread: show thread limit info when thread creation fails

[kudu-CR] thread: show thread limit info when thread creation fails

2018-10-18 Thread Mike Percy (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11726 to look at the new patch set (#2). Change subject: thread: show thread limit info when thread creation fails

[kudu-CR] [location awareness] Add ts location to both client and internal client

2018-10-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [location_awareness] Add ts location to both client and internal client .. Patch Set 4: I made a separate

[kudu-CR] [location awareness] Add ts location to both client and internal client

2018-10-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [location_awareness] Add ts location to both client and internal client .. Patch Set 2: (4 comments)

[kudu-CR] [java] Allow command line override of kuduBinDir

2018-10-18 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11725 ) Change subject: [java] Allow command line override of kuduBinDir .. [java] Allow command line override of kuduBinDir This patch

[kudu-CR] [location awareness] Add ts location to both client and internal client

2018-10-18 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11679 to look at the new patch set (#4). Change subject: [location_awareness] Add ts location to both client and internal client

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11724 ) Change subject: [tools] updated comments on 'kudu perf loadgen' .. Patch Set 2: Verified+1 Unrelated flake in

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11724 ) Change subject: [tools] updated comments on 'kudu perf loadgen' .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11724 ) Change subject: [tools] updated comments on 'kudu perf loadgen' .. [tools] updated comments on 'kudu perf loadgen' While

[kudu-CR] thread: show ulimit nproc when thread creation fails

2018-10-18 Thread Mike Percy (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11726 to review the following change. Change subject: thread: show ulimit nproc when thread creation fails .. thread: show

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11724 ) Change subject: [tools] updated comments on 'kudu perf loadgen' .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] mini cluster: Add scripts to build binaries for testing use

2018-10-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11377 ) Change subject: mini cluster: Add scripts to build binaries for testing use .. Patch Set 1: (2 comments)

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11724 to look at the new patch set (#2). Change subject: [tools] updated comments on 'kudu perf loadgen' ..

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11724 ) Change subject: [tools] updated comments on 'kudu perf loadgen' .. Patch Set 1: (4 comments)

[kudu-CR] [java] Allow command line override of kuduBinDir

2018-10-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11725 ) Change subject: [java] Allow command line override of kuduBinDir .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [java] Allow command line override of kuduBinDir

2018-10-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11725 Change subject: [java] Allow command line override of kuduBinDir .. [java] Allow command line override of kuduBinDir This patch allows

[kudu-CR] tablet server-test: wait for leader in some tests

2018-10-18 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11718 ) Change subject: tablet_server-test: wait for leader in some tests .. tablet_server-test: wait for leader in some tests The fix

[kudu-CR] tablet server-test: wait for leader in some tests

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11718 ) Change subject: tablet_server-test: wait for leader in some tests .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [sentry] improve SentryAction

2018-10-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11720 ) Change subject: [sentry] improve SentryAction .. Patch Set 2: (1 comment)

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11724 ) Change subject: [tools] updated comments on 'kudu perf loadgen' .. Patch Set 1: (4 comments)

[kudu-CR] [sentry] improve SentryAction

2018-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11720 ) Change subject: [sentry] improve SentryAction .. Patch Set 2: (2 comments)

[kudu-CR] [tools] updated comments on 'kudu perf loadgen'

2018-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11724 Change subject: [tools] updated comments on 'kudu perf loadgen' .. [tools] updated comments on 'kudu perf loadgen' While using the

[kudu-CR] Move TabletReplica::Stop() VLOG to end of function

2018-10-18 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11672 ) Change subject: Move TabletReplica::Stop() VLOG to end of function .. Move TabletReplica::Stop() VLOG to end of function

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/3)

2018-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11662 ) Change subject: [rebalancer] location-aware rebalancer (part 2/3) .. Patch Set 4: (15 comments) It looks pretty good to me but it's

[kudu-CR] [sentry] improve SentryAction

2018-10-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11720 ) Change subject: [sentry] improve SentryAction .. Patch Set 2: Verified+1 Unrelated flaky failure

[kudu-CR] [sentry] improve SentryAction

2018-10-18 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [sentry] improve SentryAction .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11720 To unsubscribe, visit

[kudu-CR] [sentry] improve SentryAction

2018-10-18 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11720 to look at the new patch set (#2). Change subject: [sentry] improve SentryAction .. [sentry] improve SentryAction

[kudu-CR] KUDU-2038: Support bitmap indexing

2018-10-18 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11722 Change subject: KUDU-2038: Support bitmap indexing .. KUDU-2038: Support bitmap indexing One DRS has a set of bitmap info independently, one

[kudu-CR] wip: [sentry] add SentryAuthzProvider

2018-10-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: wip: [sentry] add SentryAuthzProvider .. Patch Set 2: (7 comments)

[kudu-CR] wip: [sentry] add SentryAuthzProvider

2018-10-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#2). Change subject: wip: [sentry] add SentryAuthzProvider ..