Sailesh Mukil has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 3:
> (1 comment)
We will still be using Kerberos + TLS for now. I went over the change and the
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5898
Change subject: Fix 'Building with TSAN' doc mistake
..
Fix 'Building with TSAN' doc mistake
This fixes the cmake command suggested in
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 4:
Thanks Todd. As Todd fixed in the patch, the issue was that the client had a
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#4).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
Sailesh Mukil has posted comments on this change.
Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically
renewed
..
Patch Set 2:
(17 comments)
Sorry for the slow response, I kept getting pulled onto
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#2).
Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically
renewed
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#6).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
Sailesh Mukil has uploaded a new patch set (#6).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
KUDU-1845: Kerberos client keytab should be periodically renewed
With the current kerberos
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 6:
> Uploaded patch set 6.
I just had to #include
The util/random library
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 5:
(6 comments)
@Todd: Thanks, I got the ASAN build working. Aside from the code
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations
..
Patch Set 1:
(2 comments)
I found a couple of bugs, but there are still some memory leaks I haven't
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 4:
So the ASAN build fails because the renew thread is leaking all its
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 7:
(2 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#7).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#5).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
Sailesh Mukil has posted comments on this change.
Change subject: rpc: allow using encrypted private key for SSL
..
Patch Set 1:
> For Kudu's usage, we're a little less interested in this
> specifically and more interested in
Sailesh Mukil has posted comments on this change.
Change subject: rpc: allow using encrypted private key for SSL
..
Patch Set 1:
Just checking in on the ETA for this patch.
--
To view, visit
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5820
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
KUDU-1845: Kerberos client keytab should be
Sailesh Mukil has posted comments on this change.
Change subject: tls_socket: fix handling of syscall errors
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5954/1/src/kudu/security/tls_socket.cc
File
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations
..
Patch Set 1:
> (2 comments)
>
> I found a couple of bugs, but there are still some memory leaks I
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5905
to look at the new patch set (#2).
Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations
..
Sailesh Mukil has posted comments on this change.
Change subject: tls_socket: fix handling of syscall errors
..
Patch Set 1: Code-Review+1
LGTM when the other comment is addressed.
--
To view, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#8).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1738. Allow users of the client to disable OpenSSL
initialization
..
Patch Set 5:
(2 comments)
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 8:
(2 comments)
> Build Failed
>
> http://104.196.14.100/job/kudu-gerrit/6321/
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#9).
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6011
Change subject: Supress compile-time '((unused)) attribute ignored' warning
..
Supress compile-time '((unused)) attribute ignored'
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 10:
(11 comments)
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6168
Change subject: Fix TestKerberosRenewal/Reacquire flakiness
..
Fix TestKerberosRenewal/Reacquire flakiness
It has been observed that an
Sailesh Mukil has posted comments on this change.
Change subject: Fix TestKerberosRenewal/Reacquire flakiness
..
Patch Set 2:
(1 comment)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6168
to look at the new patch set (#2).
Change subject: Fix TestKerberosRenewal/Reacquire flakiness
..
Fix
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#3).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 2:
(83 comments)
Thanks Dan, Alexey and Todd. I've made the changes.
Sorry for the delay.
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4955
Change subject: Fix broken GFlags documentation link
..
Fix broken GFlags documentation link
Change-Id:
Sailesh Mukil has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
..
Patch Set 1:
(1 comment)
After reading the attached discussion, LGTM.
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 8: Code-Review+1
(11 comments)
Carry +1.
http://gerrit.cloudera.org:8080/#/c/4789/7//COMMIT_MSG
Commit Message:
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#8).
Change subject: KuduRPC integration with OpenSSL
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 4:
(34 comments)
http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#5).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#6).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 5:
(2 comments)
Should I convert all the C-style casts in the ported code to C++ style casts?
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#4).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/rpc/reactor.cc
File src/kudu/rpc/reactor.cc:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#7).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 6:
(18 comments)
http://gerrit.cloudera.org:8080/#/c/4789/6/LICENSE.txt
File LICENSE.txt:
PS6, Line 512:
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1700: Debug build will not fail gracefully on
Messenger::Init() failure
..
Patch Set 1:
(1 comment)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4724
to look at the new patch set (#2).
Change subject: KUDU-1700: Debug build will not fail gracefully on
Messenger::Init() failure
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1700: Debug build will not fail gracefully on
Messenger::Init() failure
..
Patch Set 2:
(1 comment)
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4724
Change subject: KUDU-1700: Debug build will not fail gracefully on
Messenger::Init() failure
..
KUDU-1700: Debug build will not fail
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4724
to look at the new patch set (#3).
Change subject: KUDU-1700: Debug build will not fail gracefully on
Messenger::Init() failure
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1700: Debug build will not fail gracefully on
Messenger::Init() failure
..
Patch Set 3:
(2 comments)
Sailesh Mukil has posted comments on this change.
Change subject: WIP: rpc: Initiate TLS connection upgrade following SASL
negotiation
..
Patch Set 1:
> > I was under the impression that previously, it was decided that
> the
Sailesh Mukil has posted comments on this change.
Change subject: [rpc] WIP: Introduce configurable options to Messenger
..
Patch Set 1:
> Build Failed
>
> http://104.196.14.100/job/kudu-gerrit/7167/ : FAILURE
I'll do the
Sailesh Mukil has posted comments on this change.
Change subject: [security] fixed memory leak in Krb5CallToStatus
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6411/1/src/kudu/security/init.cc
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6555
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
KUDU-1965: Allow user provided TLS certificates to
Sailesh Mukil has uploaded a new patch set (#2).
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
KUDU-1965: Allow user provided TLS certificates to work with KRPC
This patch adds a bool in
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6556
Change subject: Replace deprecated OpenSSL function ERR_remove_state()
..
Replace deprecated OpenSSL function ERR_remove_state()
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6556
to look at the new patch set (#2).
Change subject: Replace deprecated OpenSSL function ERR_remove_state()
..
Sailesh Mukil has posted comments on this change.
Change subject: Replace deprecated OpenSSL function ERR_remove_state()
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6556/1/src/kudu/security/tls_socket.cc
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
Patch Set 3:
(2 comments)
Sailesh Mukil has posted comments on this change.
Change subject: rpc: allow using encrypted private key for SSL
..
Patch Set 1:
> Hey Sailesh. I don't think we have any urgent need for this patch
> from the Kudu perspective,
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6594
to look at the new patch set (#3).
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
Patch Set 3:
(1 comment)
Added a few test cases to negotiation-test
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6594
to look at the new patch set (#4).
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6556
to look at the new patch set (#3).
Change subject: Replace deprecated OpenSSL function ERR_remove_state()
..
Sailesh Mukil has uploaded a new patch set (#3).
Change subject: Replace deprecated OpenSSL function ERR_remove_state()
..
Replace deprecated OpenSSL function ERR_remove_state()
ERR_remove_state() has been deprecated.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5906
to look at the new patch set (#2).
Change subject: WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for
inbound calls
Sailesh Mukil has posted comments on this change.
Change subject: WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for
inbound calls
..
Patch Set 2:
Just rebased this. Sorry for the noise.
--
To view, visit
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
Patch Set 3:
(1 comment)
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
Patch Set 3:
(2 comments)
Sailesh Mukil has posted comments on this change.
Change subject: Replace deprecated OpenSSL function ERR_remove_state()
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6556/2/src/kudu/security/tls_socket.cc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6594
to look at the new patch set (#5).
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
Patch Set 5:
(1 comment)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6635
to look at the new patch set (#4).
Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6594
to look at the new patch set (#2).
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
Sailesh Mukil has uploaded a new patch set (#2).
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
KUDU-1965: Allow user provided TLS certificates to work with KRPC
This patch adds a bool in
Sailesh Mukil has abandoned this change.
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
Abandoned
Patch is incorrect. Will post another one shortly.
--
To view, visit
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6594
Change subject: KUDU-1965: Allow user provided TLS certificates to work with
KRPC
..
KUDU-1965: Allow user provided TLS certificates to
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6635
Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
..
KUDU-1929: [rpc] Allow using encrypted private keys for
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6635
to look at the new patch set (#2).
Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6635
to look at the new patch set (#3).
Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
..
Sailesh Mukil has posted comments on this change.
Change subject: [rpc-test] fixed TestConnectionKeepalive flakiness
..
Patch Set 1: Code-Review+1
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/6683
To unsubscribe,
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7583
Change subject: Clean up spurious declarations in messenger.cc
..
Clean up spurious declarations in messenger.cc
Change-Id:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7662
to look at the new patch set (#4).
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
Patch Set 4:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/7662/2//COMMIT_MSG
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
Patch Set 4:
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/9318/
Sailesh Mukil has posted comments on this change.
Change subject: rpc: move ConnectionId to its own file
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7685/1/src/kudu/rpc/proxy.h
File
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
Patch Set 2:
(4 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7662
to look at the new patch set (#3).
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7662
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
KUDU-2091: Certificates with intermediate CA's
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
Patch Set 2:
(41 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7662
to look at the new patch set (#2).
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6635
to look at the new patch set (#9).
Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
..
Patch Set 9: Code-Review+2
> Build Successful
>
>
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC
proxies
..
Patch Set 5: Code-Review+1
(4 comments)
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC
proxies
..
Patch Set 4:
(2 comments)
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG
Sailesh Mukil has posted comments on this change.
Change subject: [security] avoid tickets with NULL 'renew_till'
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7770/2//COMMIT_MSG
Commit Message:
PS2, Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7770
to look at the new patch set (#3).
Change subject: [security] avoid tickets with NULL 'renew_till'
..
[security]
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG
1 - 100 of 223 matches
Mail list logo