[kudu-CR] [security] adjust TLS certificate verification

2017-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [security] adjust TLS certificate verification .. Patch Set 3: > (1 comment) We will still be using Kerberos + TLS for now. I went over the change and the

[kudu-CR] Fix 'Building with TSAN' doc mistake

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5898 Change subject: Fix 'Building with TSAN' doc mistake .. Fix 'Building with TSAN' doc mistake This fixes the cmake command suggested in

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 4: Thanks Todd. As Todd fixed in the patch, the issue was that the client had a

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#4). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] WIP: KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 2: (17 comments) Sorry for the slow response, I kept getting pulled onto

[kudu-CR] WIP: KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-01 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#2). Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#6). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#6). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. KUDU-1845: Kerberos client keytab should be periodically renewed With the current kerberos

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 6: > Uploaded patch set 6. I just had to #include The util/random library

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 5: (6 comments) @Todd: Thanks, I got the ASAN build working. Aside from the code

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 1: (2 comments) I found a couple of bugs, but there are still some memory leaks I haven't

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 4: So the ASAN build fails because the renew thread is leaking all its

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-06 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#7). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#5). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] rpc: allow using encrypted private key for SSL

2017-01-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL .. Patch Set 1: > For Kudu's usage, we're a little less interested in this > specifically and more interested in

[kudu-CR] rpc: allow using encrypted private key for SSL

2017-01-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL .. Patch Set 1: Just checking in on the ETA for this patch. -- To view, visit

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5820 Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. KUDU-1845: Kerberos client keytab should be

[kudu-CR] tls socket: fix handling of syscall errors

2017-02-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: tls_socket: fix handling of syscall errors .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5954/1/src/kudu/security/tls_socket.cc File

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-02-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 1: > (2 comments) > > I found a couple of bugs, but there are still some memory leaks I

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-02-09 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5905 to look at the new patch set (#2). Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations ..

[kudu-CR] tls socket: fix handling of syscall errors

2017-02-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: tls_socket: fix handling of syscall errors .. Patch Set 1: Code-Review+1 LGTM when the other comment is addressed. -- To view, visit

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#8). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1738. Allow users of the client to disable OpenSSL initialization

2017-02-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1738. Allow users of the client to disable OpenSSL initialization .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 8: (2 comments) > Build Failed > > http://104.196.14.100/job/kudu-gerrit/6321/

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#9). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] Supress compile-time '((unused)) attribute ignored' warning

2017-02-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6011 Change subject: Supress compile-time '((unused)) attribute ignored' warning .. Supress compile-time '((unused)) attribute ignored'

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 10: (11 comments)

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

2017-02-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6168 Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Fix TestKerberosRenewal/Reacquire flakiness It has been observed that an

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

2017-02-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Patch Set 2: (1 comment)

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

2017-02-27 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6168 to look at the new patch set (#2). Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Fix

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#3). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 2: (83 comments) Thanks Dan, Alexey and Todd. I've made the changes. Sorry for the delay.

[kudu-CR] Fix broken GFlags documentation link

2016-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4955 Change subject: Fix broken GFlags documentation link .. Fix broken GFlags documentation link Change-Id:

[kudu-CR] ssl: switch to older APIs for initializing SSL

2016-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: ssl: switch to older APIs for initializing SSL .. Patch Set 1: (1 comment) After reading the attached discussion, LGTM.

[kudu-CR] KuduRPC integration with OpenSSL

2016-11-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 8: Code-Review+1 (11 comments) Carry +1. http://gerrit.cloudera.org:8080/#/c/4789/7//COMMIT_MSG Commit Message:

[kudu-CR] KuduRPC integration with OpenSSL

2016-11-02 Thread Sailesh Mukil (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#8). Change subject: KuduRPC integration with OpenSSL

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 4: (34 comments) http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc File

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#5). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#6). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 5: (2 comments) Should I convert all the C-style casts in the ported code to C++ style casts?

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#4). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc:

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#7). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 6: (18 comments) http://gerrit.cloudera.org:8080/#/c/4789/6/LICENSE.txt File LICENSE.txt: PS6, Line 512:

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4724 to look at the new patch set (#2). Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4724 Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. KUDU-1700: Debug build will not fail

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4724 to look at the new patch set (#3). Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 3: (2 comments)

[kudu-CR] WIP: rpc: Initiate TLS connection upgrade following SASL negotiation

2016-12-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: WIP: rpc: Initiate TLS connection upgrade following SASL negotiation .. Patch Set 1: > > I was under the impression that previously, it was decided that > the

[kudu-CR] [rpc] WIP: Introduce configurable options to Messenger

2017-03-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [rpc] WIP: Introduce configurable options to Messenger .. Patch Set 1: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/7167/ : FAILURE I'll do the

[kudu-CR] [security] fixed memory leak in Krb5CallToStatus

2017-03-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [security] fixed memory leak in Krb5CallToStatus .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6411/1/src/kudu/security/init.cc

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6555 Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. KUDU-1965: Allow user provided TLS certificates to

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. KUDU-1965: Allow user provided TLS certificates to work with KRPC This patch adds a bool in

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6556 Change subject: Replace deprecated OpenSSL function ERR_remove_state() .. Replace deprecated OpenSSL function ERR_remove_state()

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

2017-04-05 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6556 to look at the new patch set (#2). Change subject: Replace deprecated OpenSSL function ERR_remove_state() ..

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Replace deprecated OpenSSL function ERR_remove_state() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6556/1/src/kudu/security/tls_socket.cc

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 3: (2 comments)

[kudu-CR] rpc: allow using encrypted private key for SSL

2017-04-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL .. Patch Set 1: > Hey Sailesh. I don't think we have any urgent need for this patch > from the Kudu perspective,

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-11 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6594 to look at the new patch set (#3). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 3: (1 comment) Added a few test cases to negotiation-test

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-11 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6594 to look at the new patch set (#4). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

2017-04-11 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6556 to look at the new patch set (#3). Change subject: Replace deprecated OpenSSL function ERR_remove_state() ..

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

2017-04-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: Replace deprecated OpenSSL function ERR_remove_state() .. Replace deprecated OpenSSL function ERR_remove_state() ERR_remove_state() has been deprecated.

[kudu-CR] WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls

2017-04-06 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5906 to look at the new patch set (#2). Change subject: WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls

[kudu-CR] WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls

2017-04-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: WIP: KUDU-1865 (part 2): pre-allocate OutboundTransfer for inbound calls .. Patch Set 2: Just rebased this. Sorry for the noise. -- To view, visit

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 3: (2 comments)

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

2017-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Replace deprecated OpenSSL function ERR_remove_state() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6556/2/src/kudu/security/tls_socket.cc

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-12 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6594 to look at the new patch set (#5). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-04-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6635 to look at the new patch set (#4). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ..

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6594 to look at the new patch set (#2). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. KUDU-1965: Allow user provided TLS certificates to work with KRPC This patch adds a bool in

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Abandoned Patch is incorrect. Will post another one shortly. -- To view, visit

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6594 Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. KUDU-1965: Allow user provided TLS certificates to

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-04-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6635 Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. KUDU-1929: [rpc] Allow using encrypted private keys for

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-04-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6635 to look at the new patch set (#2). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ..

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-04-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6635 to look at the new patch set (#3). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ..

[kudu-CR] [rpc-test] fixed TestConnectionKeepalive flakiness

2017-04-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [rpc-test] fixed TestConnectionKeepalive flakiness .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/6683 To unsubscribe,

[kudu-CR] Clean up spurious declarations in messenger.cc

2017-08-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7583 Change subject: Clean up spurious declarations in messenger.cc .. Clean up spurious declarations in messenger.cc Change-Id:

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7662 to look at the new patch set (#4). Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/7662/2//COMMIT_MSG

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 4: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/9318/

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7685/1/src/kudu/rpc/proxy.h File

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7662 to look at the new patch set (#3). Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7662 Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. KUDU-2091: Certificates with intermediate CA's

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 2: (41 comments)

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-12 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7662 to look at the new patch set (#2). Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-06-27 Thread Sailesh Mukil (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6635 to look at the new patch set (#9). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-06-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 9: Code-Review+2 > Build Successful > >

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 5: Code-Review+1 (4 comments)

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG

[kudu-CR] [security] avoid tickets with NULL 'renew till'

2017-08-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [security] avoid tickets with NULL 'renew_till' .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7770/2//COMMIT_MSG Commit Message: PS2, Line

[kudu-CR] [security] avoid tickets with NULL 'renew till'

2017-08-22 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7770 to look at the new patch set (#3). Change subject: [security] avoid tickets with NULL 'renew_till' .. [security]

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG

  1   2   3   >